- 22 Jan, 2020 40 commits
-
-
Elly Fong-Jones authored
Per request from waffles@ :) Bug: None Change-Id: Ia0499c064c4c098c47bb208d0d6dd2d3244081da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015604Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#734175}
-
Luke Zielinski authored
TBR=robertma Change-Id: Icd82857de549cb4f6812f172b749adce6bdda4a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015347Reviewed-by:
Luke Z <lpz@chromium.org> Commit-Queue: Luke Z <lpz@chromium.org> Cr-Commit-Position: refs/heads/master@{#734174}
-
Naoki Fukino authored
Following errors are not automatically fixed by eslint. I fixed these manually. ui/file_manager/file_manager/foreground/js/import_controller.js 6:1 error Unexpected var, use let or const instead no-var ui/file_manager/file_manager/foreground/js/metadata/image_parsers.js 180:9 error Unexpected var, use let or const instead no-var 193:9 error Unexpected var, use let or const instead no-var ui/file_manager/file_manager/foreground/js/ui/file_table.js 131:10 error Unexpected var, use let or const instead no-var ui/file_manager/file_manager/foreground/js/ui/file_tap_handler.js 111:9 error Unexpected var, use let or const instead no-var 139:9 error Unexpected var, use let or const instead no-var Bug: 778674 Test: Ran browser_tests/closure_compiler Change-Id: I77ddedbc46f3ac5d63f29836156b5e584e2a7fa0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014620 Commit-Queue: Noel Gordon <noel@chromium.org> Auto-Submit: Naoki Fukino <fukino@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#734173}
-
Chase Phillips authored
Bug: 989611 Change-Id: I44bc45661e194f78f5cfa90d59e0e78c8b20c278 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2005670 Auto-Submit: Chase Phillips <cmp@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Commit-Queue: Chase Phillips <cmp@chromium.org> Cr-Commit-Position: refs/heads/master@{#734172}
-
Mark Schillaci authored
This CL addresses various coupled bugs in both text selection and non- default granularity navigation for input fields/contenteditables on Android. It fixes various issues with improper announcements, announcements at the wrong time, and text selection not functioning in general. It also addresses AccessibilityEvent discrepancies under-the- hood in cases where we appeared to have the correct functionality to the user, but only by happenstance as we were passing bad data to TalkBack. This CL addresses: Bug 1041649 - Text selection on Android broken/not functioning Bug 1017466 - Contenteditable word granularity navigation not reading correctly Bug 1041587 - Beginning/End of field announcements being read at wrong index Bug: 1041649,1017466,1041587 Change-Id: I30a8888e99e90356398d14319fbdf225839f5dac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1998829 Commit-Queue: Mark Schillaci <mschillaci@google.com> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#734171}
-
Toni Barzic authored
When showing a context menu, shelf view uses ShelfItemDelegate::GetContextMenu to get the item's context menu model. This operation is async, and may take non-trivial amount of time, during which the user might start the app item drag. If the context menu is shown after the drag starts, it will consume subsequent pointer events and leave drag operation in dangling state (e.g. drag view does not get hidden). To prevent this, wrap GetContextMenu callback in cancellable callback, and cancel it when drag starts (thus cancelling context menu showing). BUG=1042505 Change-Id: I30af7f4514bfa8318e84e04b91b284a2d42b3715 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013527Reviewed-by:
Manu Cornet <manucornet@chromium.org> Commit-Queue: Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#734170}
-
Ahmed Fakhry authored
UX decided we should remove the "Turn off for tonight" button from the Auto Night Light notification, and change the body's text slightly. Demo: https://bugs.chromium.org/p/chromium/issues/detail?id=1034761#c4 BUG=1034761 TEST=Adjusted unit tests, manually. Change-Id: I5c4de30e94b431d56de3692c702949b835c09830 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2008014Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#734169}
-
Theresa Wellington authored
Create a new/separate build target for native_page classes: - BasicNativePage - FrozenNativePage - NativePage - NativePageHost Several classes that are currently only used by the NTP/Explore Sites were left behind (for now). There are also several "glue" classes that will stay with the main chrome_java target. BUG=1026637 Change-Id: Ia31413241b5da4d15a87950e96a438c82ca166ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2009841 Commit-Queue: Theresa <twellington@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#734168}
-
Aaron Leventhal authored
Bug: 1044104 Change-Id: Ieb4361fe15122ea676b638af4be649f81fb0f9f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2012880Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#734167}
-
Aaron Gable authored
This is an emergency measure. On Jan 8th, many browser_tests were re-enabled on Mac10.13 Tests, and were thereby also re-enabled on the mac-rel CQ bot. This resulted in a 50% increase in browser_tests runtime at both the median and atthe 90th percentile (approximately 2hrs to 3hrs). This has led to capacity shortages and significant violations of the Chromium CQ cycle time SLO. We are disabling this test suite as a simple emergency measure until better long-term solutions (disabling just a subset of the tests, having mac-rel mirror Mac10.14 Tests instead, or other ideas) are in place. Bug: 1042757 Change-Id: Iad8e9f852dccf8c630b4fe165103d25b0bc3bbd7 No-Try: True Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015786Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Commit-Queue: Aaron Gable <agable@chromium.org> Auto-Submit: Aaron Gable <agable@chromium.org> Cr-Commit-Position: refs/heads/master@{#734166}
-
David Bienvenu authored
This reverts commit 4189e014. Reason for revert: <may have broken blink_heap_unittests on fuschia> Original change's description: > [fuchsia] Stop overriding safestack & shadow-call-stack settings. > > Fuchsia builds have been forcibly disabling safestack because it broke > V8 tests under Fuchsia, and forcibly enabling shadow-call-stack in > advance of it becoming the toolchain default, to gauge size impact. > > Enabling shadow-call-stack under x64 is not recommended and breaks code > which uses C++ exceptions, which is true of some V8 code & tests. > > Since the toolchain default should now be correct, remove the overrides > entirely. > > Bug: 1028617, 821951 > Change-Id: I36333f8cff5ea62584032a802337cdeb95f33466 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014407 > Auto-Submit: Wez <wez@chromium.org> > Reviewed-by: Kevin Marshall <kmarshall@chromium.org> > Commit-Queue: Wez <wez@chromium.org> > Cr-Commit-Position: refs/heads/master@{#734110} TBR=wez@chromium.org,kmarshall@chromium.org Change-Id: I182cb1fd966d08b9af68f5c50bb67928567cfb61 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1028617, 821951 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015355Reviewed-by:
David Bienvenu <davidbienvenu@chromium.org> Commit-Queue: David Bienvenu <davidbienvenu@chromium.org> Cr-Commit-Position: refs/heads/master@{#734165}
-
wutao authored
Required to extend finch experiment. Bug: b/147229300 Test: pass the PRESUBMIT.py Change-Id: I0342367e91aa0ea89ef846d33a52a77e15ac230a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2008067Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: Tao Wu <wutao@chromium.org> Cr-Commit-Position: refs/heads/master@{#734164}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/6b66b67f69e2..8ffd3f23331d git log 6b66b67f69e2..8ffd3f23331d --date=short --first-parent --format='%ad %ae %s' 2020-01-22 cwallez@chromium.org Move EXPECT_LAZY_CLEAR to TextureZeroInitTests.cpp Created with: gclient setdep -r src/third_party/dawn@8ffd3f23331d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: I2e432291b37415b1bb56bbd73d3f19808ac6ad58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013666Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#734163}
-
Mike Dougherty authored
BrowserState and application wide breadcrumbs are combined and attached to crash reports under a single key. Rename this key to a more appropriate name. Bug: 1003922 Change-Id: Ic1c6cb04d5d1047c090c51fdc5e5df82c78cacb2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013816 Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Auto-Submit: Mike Dougherty <michaeldo@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#734162}
-
Jeremy Roman authored
Bug: 1040627 Change-Id: If4f98b2269a0266ea9c56630a7f968d5b04af2b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013486 Commit-Queue: Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#734161}
-
Vasiliy Telezhnikov authored
This CL modifies BeginFrameSourceWebView::BeginFrameObserver to prevent reentrancy of OnBeginFrame. If the clients of this BeginFrameSource add or remove observers during OnBeginFrame this will cause the source to subscribe/unsubscribe from upstream BeginFrameSource and potentially get missed BeginFrame. To avoid this we save last_used_begin_frames_ before actually processing BeginFrame. Bug: 1044340 Change-Id: I6df71952c0efa1e8bf7db4953453684b955c42e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013808Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#734160}
-
Matthew Mourgos authored
In this change, the hotseat background will change color for different shelf states and will animate between colors when changing. When in-app shelf is shown the hotseat color should have an alpha value of 90%. When the home shelf is shown the hotseat color should have an alpha value of 60%. Bug: 1041132 Change-Id: I9459fbb61cbc538029039cd48c04144a98ab82c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003919Reviewed-by:
Manu Cornet <manucornet@chromium.org> Commit-Queue: Matthew Mourgos <mmourgos@chromium.org> Cr-Commit-Position: refs/heads/master@{#734159}
-
Thomas Lukaszewicz authored
Fixed the trigger check for MenuButtonController so that it always checks to see if a given menu triggering event is valid during an OnMousePressed event. Previously the timing check was made during either OnMousePressed or OnMouseReleased. If the check was made during OnMouseReleased the event may or may not have registered as a triggering event based on the timing of the action (ie long press of the button), resulting in inconsistent behaviour. Bug: 1036441 Change-Id: I566fae882b7ef0e7c69a1359237b11f7c4a3d53d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013747 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#734158}
-
Sylvain Defresne authored
Instead of forward declaring ChromeBrowserState in the ios namespace, use a header. This will allow moving the class to the global namespace without having to change all the forward declaration at the same time. This CL was uploaded by git cl split. R=sczs@chromium.org Bug: 1042208 Change-Id: I388055914d1180bf7ecd228c42cb019bfdf5f7a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007427 Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#734157}
-
David Van Cleve authored
Updates blink/common/feature_policy's README to reflect some restructuring of the feature policy framework that: - uses a json5 for defining new features - does away with some boilerplate elsewhere (e.g. mojom-traits) that was previously necessary. Change-Id: I6b9425be81ae5fb0539394e993ecb3d3fbadbd92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2012887 Commit-Queue: David Van Cleve <davidvc@chromium.org> Reviewed-by:
Ian Clelland <iclelland@chromium.org> Cr-Commit-Position: refs/heads/master@{#734156}
-
Anastasia Helfinstein authored
This is a quick fix for a small bug related to the listener for childrenChanged events. Bug: None Change-Id: I72dad6423d68301597fa1728feae4f775b6e6337 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013914Reviewed-by:
Aran Gilman <gilmanmh@google.com> Commit-Queue: Anastasia Helfinstein <anastasi@google.com> Cr-Commit-Position: refs/heads/master@{#734155}
-
David Van Cleve authored
Another CL I'm working on concurrently involves adding some tests involving CorsURLLoaderFactories, which are a little laborious to initialize in tests, in part because a couple of the dependencies are tricky to mock out. This CL makes it slightly easier by adding a fake (TestResourceScheduler) for ResourceScheduler to the network service's test support library. Change-Id: I758c355ffe0d9241798d119cb12e2f36bb6f3fcc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007523 Commit-Queue: David Van Cleve <davidvc@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#734154}
-
Xida Chen authored
Right now this dcheck is at the time of reporting metrics, where the debug string could be long. This CL improves the dcheck by: 1. At the end of each impl frame, dcheck that this impl frame should either be no-damage or submitted. 2. At the time of reporting metrics, only output the string for the frames that doesn't satisfy 1. Bug: 1043091 Change-Id: Ib7b106faa41c169a7ee44567a2444d064d8b38c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2008318 Commit-Queue: Xida Chen <xidachen@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#734153}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/71fa12130a57..527fd16079a5 Created with: gclient setdep -r src-internal@527fd16079a5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1031156 Tbr: jbudorick@google.com Change-Id: Ib8e2092aefdb501d9a5f1b6961ae04dead2f1c0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013667Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#734152}
-
Mustafa Emre Acer authored
This CL adds a list of Thai characters that look like Latin characters. A domain consisting only of these characters and not having a .th ccTLD or other Thai TLDs such as .ไทย will be converted to punycode, as is done for other whole-script-confusables such as Cyrillic and Hebrew. Some of the Thai characters look similar to Latin only on Linux, so more characters are included for Linux in this CL. This affects a number of single letter domains such as น.com (xn--q3c.com) and ม.com (xn--y3c.com) on Linux and บ.com (xn--r3c.com) on other platforms. However, most of these domains are parked and don't have significant usage. Here are screenshots of the characters on different platforms: Linux: https://drive.google.com/open?id=12VaeWI6C5Vx-FjgpuOHWlY7SoVeozq6o Mac: https://drive.google.com/open?id=1r2VkoeQZUJUHSBoqkruzdylVtg5T9o_x Windows: https://drive.google.com/open?id=1gLFDwy5T6uIQkVU7lPz6Tzoe2GGapTvS Bug: 722167 Change-Id: Iba083eab566ae3110d55e02006ff3292233dff10 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2012089 Commit-Queue: Mustafa Emre Acer <meacer@chromium.org> Reviewed-by:
Joe DeBlasio <jdeblasio@chromium.org> Cr-Commit-Position: refs/heads/master@{#734151}
-
Patrick Monette authored
This CL is a no-op functionality-wise. Bug: 268984 Change-Id: I897e9728e4800ce2069e11dfe00a71638ededaef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994019 Commit-Queue: Patrick Monette <pmonette@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#734150}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/8fff8c3b7dc8..1e8486b1739d git log 8fff8c3b7dc8..1e8486b1739d --date=short --first-parent --format='%ad %ae %s' 2020-01-22 bclayton@google.com CMake: Make the use of endif() / endif(EXPR) consistent 2020-01-22 bclayton@google.com Vulkan debugger: Don't wait for debugger by default. 2020-01-22 bclayton@google.com CMakeLists: Allow overriding of building cppdap 2020-01-22 bclayton@google.com CMakeLists: Only expose options if they're not set as vars Created with: gclient setdep -r src/third_party/swiftshader@1e8486b1739d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: If54466e3d8d332b8f16b203fc1a89b6aa1d04ab1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013773Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#734149}
-
Ben Pastene authored
Forgot the scheduler configs in crrev.com/c/2012838. Bug: 1032336 Change-Id: I3c52f9762f195566fb44ae0e6a3e4bd75936d6c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015163 Commit-Queue: Ben Pastene <bpastene@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Auto-Submit: Ben Pastene <bpastene@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#734148}
-
Mason Freed authored
Prior to this CL, the load event was not being fired when the textContent of a <style> element was changed, contrary to the spec ([1]). Now, the load event is fired in this case. Note that when textContent is changed, per spec [2], the children changed steps are run. This first removes the existing <style> contents, which once complete, fires a "load" event. Then the new <style> contents are parsed, after which another "load" event is fired. So in the example of 674518, two load events will now be fired when the style is changed. [1] https://html.spec.whatwg.org/multipage/semantics.html#update-a-style-block [2] https://dom.spec.whatwg.org/#concept-node-children-changed-ext Fixed: 674518 Change-Id: Idb0ddb9f0ca2478a8a35d06817928503e74fa3fb Bug: 674518 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2011133 Commit-Queue: Mason Freed <masonfreed@chromium.org> Auto-Submit: Mason Freed <masonfreed@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#734147}
-
Naoki Fukino authored
Following errors by eslint are not automatically fixed. I fixed these manually. (Used eslint-disable-next-line for redefining global object.) /ui/file_manager/file_manager/test/js/chrome_api_test_impl.js 13:1 error Unexpected var, use let or const instead no-var 152:9 error Unexpected var, use let or const instead no-var /ui/file_manager/file_manager/test/js/chrome_file_manager_private_test_impl.js 283:1 error Unexpected var, use let or const instead no-var /ui/file_manager/file_manager/test/js/test_util.js 8:1 error Unexpected var, use let or const instead no-var 376:3 error Unexpected var, use let or const instead no-var Bug: 778674 Test: Run browser_tests/closure_compiler Change-Id: Ifeccd95fd0c459c5752855ef7f218d646bd6c6ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014600 Commit-Queue: Noel Gordon <noel@chromium.org> Auto-Submit: Naoki Fukino <fukino@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#734146}
-
Bence Béky authored
https://quiche.googlesource.com/quiche.git/+log/dfabdfb6884b..f579b5e51aaf $ git log dfabdfb68..f579b5e51 --date=short --no-merges --format='%ad %ae %s' 2020-01-21 nharper Refactor TlsServerHandshaker to implement QuicCryptoServerStreamBase directly 2020-01-21 fayang Disable gfe2_restart_flag_quic_default_on_ietf_loss_detection in QuicEndpointTest.Competition while investigating the issue. 2020-01-21 wub gfe-relnote: (n/a) Change the return value of QuicUdpSocketApi::ReadMultiplePackets from number of good packets to number of total packets read. Code not used yet. 2020-01-21 bnc Use quiche_export instead of http2_export. 2020-01-21 ianswett gfe-relnote: Add a connection option(1ACK) to send only one immediate ACK in QUIC after reordering, instead of 4. Protected by gfe2_reloadable_flag_quic_one_immediate_ack Created with: roll-dep src/net/third_party/quiche/src Change-Id: I6a3b22464f673884affc55883c090a8df1dead3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014053 Commit-Queue: Ryan Hamilton <rch@chromium.org> Auto-Submit: Bence Béky <bnc@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#734145}
-
Stephen Nusko authored
It remains disabled by default by the tracing flag --enable-features=kEnablePerfettoSystemTracing, but when enabled will attempt to connect to the result of GetProducerSocket(). This will be useful for people who want system wide tracing on linux from crashed browser processes since the tracing service will be alive even after Chrome dies. Bug: 1007310 Change-Id: I62e67bcdc9ff720da2a59497a6d3ebf855413b8f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1953718 Auto-Submit: Stephen Nusko <nuskos@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#734144}
-
Mikel Astiz authored
This addresses a TODO in SyncServiceCrypto about honoring the result of MarkKeysAsStale(), which is called when a previous call to FetchKeys() returns keys that are insufficient to resolve the encryption issue. If MarkKeysAsStale() reports true, it suggests another FetchKeys() attempt is worth (usually meaning some local cache was invalidated). This means another FetchKeys() call should be issued, as a second and last attempt to resolve the encryption issue. Bug: 1012659 Change-Id: Idd766233d0cacd2fb1030ca107e51efd667ad414 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003132 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#734143}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/2e45f00d3687..04ccecc2d7b2 git log 2e45f00d3687..04ccecc2d7b2 --date=short --first-parent --format='%ad %ae %s' 2020-01-22 aerotwist@chromium.org [Global] Updates references to Common.console 2020-01-22 aerotwist@chromium.org Adds e2e scripts and 'Hello, World' test 2020-01-22 aerotwist@chromium.org Migrates sources/ to ESM internally Created with: gclient setdep -r src/third_party/devtools-frontend/src@04ccecc2d7b2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1006759,chromium:1044632 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I55227c4b5447b0dcdacd908ff34475edcf623800 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015144Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#734142}
-
Min Qin authored
BUG=103745 Change-Id: Icc6e06fbcfc17b1b824ab9406f73a89a52c2b8be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993387 Commit-Queue: Min Qin <qinmin@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#734141}
-
Cammie Smith Barnes authored
Because some same-origin root ad frames have children who are cross-origin, the current same-origin vs cross-origin ad metric classifies the origin status of cross-origin ad creatives with same-origin root ad frames as same-origin. This new metric heuristically determines which frame in the ad frame tree contains the actual ad creative by assuming it is the first frame with a First Contentful Paint. Test 1: chrome/test:unit_tests --gtest_filter=*CreativeOriginStatus* Test 2: chrome/test:browser_tests --gtest_filter=*CreativeOriginStatus* Bug: 1011407 Change-Id: I2571734216b5abd5facd4dac79e5b1a1ee91bdb3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894168 Commit-Queue: Cammie Smith Barnes <cammie@chromium.org> Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#734140}
-
Rohit Rao authored
TBR=eugenebut@chromium.org BUG=1044676 Change-Id: I83a925af601b4916a69b7e737352339610a258f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014128Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#734139}
-
Miguel Casas authored
This CL adds a Media.PlatformVideoDecoding.Decode histogram to the VA-API Wrapper (a similar one could be added to others). This histogram is used for CrOs perf testing: crrev.com/c/2013491. Bug: 1014836 Change-Id: I0b108d9488472640b3f9e640eeeb73dc3784008f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013583Reviewed-by:
Dan Sanders <sandersd@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#734138}
-
Sammie Quon authored
Discovered new bug regarding windows with top insets which affects both minimized windows and unminimzed windows. The current patch does not make it perfect in the case of windows with top insets (especially if they are letterboxed), but its a lot closer than before. Test: added test, manual Bug: 1041555 Change-Id: I3503ca4a6760517176607c50d1dc6f1a2b9ca376 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2001753Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#734137}
-
Daniel Hosseinian authored
Epson printers use the "Ink" attribute instead of other commonly used attributes like "ColorModel". Remove unnecessary scoping in some unit tests. Bug: 1043255 Change-Id: I3a71c0354de266cf41b99d06372e883e8b200eb8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014101Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Sean Kau <skau@chromium.org> Commit-Queue: Daniel Hosseinian <dhoss@chromium.org> Cr-Commit-Position: refs/heads/master@{#734136}
-