- 08 Nov, 2018 40 commits
-
-
Scott Graham authored
Bug: 883496 Change-Id: I2a769b4779ff0f56622ed62099ee0b620aefb16e Reviewed-on: https://chromium-review.googlesource.com/c/1318745 Commit-Queue: Scott Graham <scottmg@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#606295}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/8621cb09ab31..ff46b65fdb14 git log 8621cb09ab31..ff46b65fdb14 --date=short --no-merges --format='%ad %ae %s' 2018-11-07 treehugger-gerrit@google.com Merge "trace_processor: Add lowmemory_kill events to instants table" Created with: gclient setdep -r src/third_party/perfetto@ff46b65fdb14 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I218561947e7d211ffcae0e92d574c8e59dbe1aec Reviewed-on: https://chromium-review.googlesource.com/c/1325130Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#606294}
-
David Tseng authored
Bug: 902432 Change-Id: Ia551251759af9c285a9d371393028ee02628718d Reviewed-on: https://chromium-review.googlesource.com/c/1324372Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#606293}
-
Koji Ishii authored
This patch allows computing NGOffsetMapping for legacy inline formatting context. For an experimental project "Invisible DOM"[1][2] to support the find-in-page feature, it is needed to compute the text content with whitespace collapsing applied, along with the mapping to the DOM offset. This patch adds an API to compute NGOffsetMapping even when the LayoutBlockFlow is not laid out by LayoutNG for that purpose. Note that the project is still in the early phase. We may revisit the design as it moves forward. [1] https://github.com/rakina/searchable-invisible-dom [2] https://www.chromestatus.com/feature/5105291213406208 Bug: 636993, 873057 Change-Id: I101b411960813a7b9b5c9c6e2db85d28737af882 Reviewed-on: https://chromium-review.googlesource.com/c/1322184Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Rakina Zata Amni <rakina@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#606292}
-
Darren Shen authored
This is a reland of ed0f2f84 We changed a test to call WaitUntilShown before setting the size. TBR=jamescook@chromium.org Original change's description: > [VK] Automatically notify when test keyboard UI is loaded. > > Previously, test implementations of KeyboardUI did not call > KeyboardController::NotifyKeyboardWindowLoaded. KeyboardController > requires that function to be called in order to proceed to show the > virtual keyboard. Thus, individual test files had to manually call > NotifyKeyboardWindowLoaded. > > We change the test implementations to automatically call > NotifyKeyboardWindowLoaded (through a callback) and move the function > to be private. We use PostTask to simulate asynchronity. > > Bug: 849995 > Change-Id: I1eae9a94c785622ed645c2437a0457f5516fed47 > Reviewed-on: https://chromium-review.googlesource.com/c/1277129 > Commit-Queue: Darren Shen <shend@chromium.org> > Reviewed-by: Steven Bennetts <stevenjb@chromium.org> > Reviewed-by: James Cook <jamescook@chromium.org> > Cr-Commit-Position: refs/heads/master@{#605980} Bug: 849995 Change-Id: I0af055fd0d47ec3969e110e9ef6cced089692446 Reviewed-on: https://chromium-review.googlesource.com/c/1324529Reviewed-by:
Darren Shen <shend@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#606291}
-
siyua authored
Bug: 897998 Change-Id: I040aa20d9c388c8490db51e120227a3bdecb6aab Reviewed-on: https://chromium-review.googlesource.com/c/1318535Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Commit-Queue: Siyu An <siyua@chromium.org> Cr-Commit-Position: refs/heads/master@{#606290}
-
Becca Hughes authored
Add previous and next track buttons to the media notification. BUG=893296 Change-Id: I2918e82bfa3ef11ce65e0fd8d21783e683cd3203 Reviewed-on: https://chromium-review.googlesource.com/c/1300114 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#606289}
-
Sadrul Habib Chowdhury authored
Report the delta between the swap-time in the renderer, and the presentation time in the gpu. This would allow us to understand how switching to presentation-time would affect the paint-timing metrics. BUG=899847 Change-Id: I31dd6f5f9ef159e464d7616d2ad04a9c971d7d4a Reviewed-on: https://chromium-review.googlesource.com/c/1305249Reviewed-by:
Bryan McQuade <bmcquade@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#606288}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/1bf18ce9e2ca..448b99f1a580 git log 1bf18ce9e2ca..448b99f1a580 --date=short --no-merges --format='%ad %ae %s' 2018-11-07 jmadill@chromium.org Add WebKit bounds checking to Chrome credits. Created with: gclient setdep -r src/third_party/angle@448b99f1a580 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:None TBR=syoussefi@chromium.org Change-Id: I138225b150709c3489ff3e5daa47147927f0818c Reviewed-on: https://chromium-review.googlesource.com/c/1324855Reviewed-by:
-
Kent Tamura authored
Before this CL, we didn't save webkitRelativePath values on saving a tab session, and we computed them with the longest common ancestor directory of all files on restoring the tab session. After this CL, we save webkitRelativePath values, and restore them without finding the common ancestor directory. This CL is a preparation of fixing crbug.com/124187. * FileInputType::SaveFormControlState(): Save webktiRelativePath. * FormStateSignature() in form_controller.cc: Increment the version string due to the format change. * FileInputType::RestoreFormControlState(): Create |File| instances from FormControlState directly. We used to create a FileChooserFileInfoList from a FormControlState, and FileInputType::CreateFileList() converted it to |File| instances. We bypass FileChooserFileInoList because it can't represent webkitRelativePath. * FileInputType::FilesFromFormControlState(), HTMLInputElement:: FilesFromFileInputFormControlState(), and SavedFormState:: GetReferencedFilePaths(): Pass Vector<String> instead of FileChooserFileInfoList. These functions just need Vector<String>. Bug: 124187 Change-Id: I225463694d164c1f6ed1cb61da8a5bc42e2542c6 Reviewed-on: https://chromium-review.googlesource.com/c/1322671Reviewed-by:
-
Luciano Pacheco authored
These logs were added as part of debugging flakiness, which has been fixed, so removing the logs. Test: No change in behaviour. Bug: 899664 Change-Id: Ifb66c9beb6ab22bd1002dbda64dcbe461d5fb8e3 Reviewed-on: https://chromium-review.googlesource.com/c/1325269 Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#606285}
-
Fergus Dall authored
Currently, we assume that debugd sends back a boolean success/fail value in the response when asked to shutdown vm_concierge, but in fact the response is empty, resulting in spurious error messages. This CL changes this behaviour to assume success when receving any response, including an empty one. Bug: 900841 Change-Id: I04682973c6dc9d190d43c1626c9b4e05cfa35484 Reviewed-on: https://chromium-review.googlesource.com/c/1312140 Commit-Queue: Fergus Dall <sidereal@google.com> Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Reviewed-by:
Nicholas Verne <nverne@chromium.org> Cr-Commit-Position: refs/heads/master@{#606284}
-
Andrew Grieve authored
chrome_public_test_apk is now the union of: * chrome_public_apk_for_test * chrome_public_test_apk * chrome_sync_shell_apk * chrome_sync_shell_test_apk Motivation is to simplify the targets, as well as to work around multidex restrictions. This change disabled two tests because fixing wasn't trivial: * FirstRunIntegrationTest.java * FirstRunTest.java https://crbug.com/902774 will track un-@Disable'ing them. NOTRY=true # linux bot flakiness TBR=agrieve # Trivial rename in a couple files. Bug: 833545, 841628, 901488 Change-Id: I9ebe035e86f1b6e5a208e36040baf038efa6cc15 Reviewed-on: https://chromium-review.googlesource.com/c/1319335 Commit-Queue: agrieve <agrieve@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#606283}
-
Kristi Park authored
Add edit shortcut menu check before starting the reorder flow. This will prevent the flow from being initiated when the edit shortcut menu is clicked. Bug: 851335 Change-Id: I064d3553b52215152671d9d4c1573ca9450dec0a Reviewed-on: https://chromium-review.googlesource.com/c/1325075Reviewed-by:
Mathieu Perreault <mathp@chromium.org> Commit-Queue: Kristi Park <kristipark@chromium.org> Cr-Commit-Position: refs/heads/master@{#606282}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/85b2efb9fc33..c9546dc1a494 Created with: gclient setdep -r src-internal@c9546dc1a494 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:883003 TBR=mmoss@chromium.org Change-Id: I154009eb3cb098d05e2bcd207851ccfb50900b59 Reviewed-on: https://chromium-review.googlesource.com/c/1324854Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#606281}
-
Roberto Carrillo authored
We will need to customize the test targets that run on coverage bots, so this change creates a dedicated suite. Also, this creates the config for the new cq trybot. R=jbudorick,stgao,liaoyuke No-Try: true Change-Id: I08563dd9b5375fa140356d36d536aa5d9e1c6418 Reviewed-on: https://chromium-review.googlesource.com/c/1324142 Commit-Queue: Roberto Carrillo <robertocn@chromium.org> Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#606280}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/19757a1acfeb..4a463d57e9aa git log 19757a1acfeb..4a463d57e9aa --date=short --no-merges --format='%ad %ae %s' 2018-11-07 tsepez@chromium.org Remove redundancy between CFX_KeyValue and JSGlobalData. 2018-11-07 tsepez@chromium.org Tidy some small TODOs in CFX_GlobalData. 2018-11-07 tsepez@chromium.org Make public IndirectObjectHolder orphan tracking feature. Created with: gclient setdep -r src/third_party/pdfium@4a463d57e9aa The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:901654 TBR=dsinclair@chromium.org Change-Id: Iaec4b0444581e37c7063fe0df49e77885cea999b Reviewed-on: https://chromium-review.googlesource.com/c/1324853Reviewed-by:
-
bsheedy authored
Updates several VR JavaScript golden images that have started failing due to some recent text formatting changes. TBR=mthiesse@chromium.org Change-Id: I9a41cdd0c32741cc50a1f64821652ee372c31ad1 Reviewed-on: https://chromium-review.googlesource.com/c/1324930Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#606278}
-
Toni Barzic authored
The test has PRE_DataAvailableOnRestart part which creates a note in lock screen note storage. DataAvailableOnRestart then verifies that a onDataItemsAvailable event is dispatched as the user session is started. The event is dispatched early on during the test - before the test body is run, which means there is no guarantee that a result catcher created in the test body will be created before the test app runs all the tests, and thus it might miss a test result message. To fix the issue, update the LockScreenNoteTakingTest setup to create a result catcher just after the browser main parts are created - this should be early enough to catch any messages from the test app (i.e. before the event observed by the test app is dispatched), but late enough to have NotificationService available (without it extensions::ResultCatcher cannot be created). BUG=901616 Change-Id: I58b3ccda9b93bc355bab7fb1f24e2d4a769c44d8 Reviewed-on: https://chromium-review.googlesource.com/c/1324870 Commit-Queue: Toni Baržić <tbarzic@chromium.org> Reviewed-by:
-
Darwin Huang authored
Only allow frames who are ancestors of the drag_src_ to reset a drag_src_ Created layout test to show previous lack of dragend when moving iframe in dom as a result of dragging Created layout test to verify lack of regression when frames containing drag source are moved/detached Bug: 737691 Change-Id: Ic6cc8ac0528d35ac93a21612b453d6b3203a152d Reviewed-on: https://chromium-review.googlesource.com/c/1265818 Commit-Queue: Darwin Huang <huangdarwin@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#606276}
-
Steve Kobes authored
This lets tests supply PageRenderData to the MetricsWebContentsObserver through the plumbing added in crrev.com/603785. Also remove an unused declaration and make SimulatePageLoadTimingUpdate private in PageLoadMetricsObserverTester. Bug: 581518 Change-Id: I89409eff3346855c03450ceeb2030b63068d6d3a Reviewed-on: https://chromium-review.googlesource.com/c/1318058 Commit-Queue: Steve Kobes <skobes@chromium.org> Reviewed-by:
-
David Jacobo authored
This CL removes a few unused libraries from HatService and fixes small style nits. Funcionality is untouched. Bug: None Test: Build. Change-Id: Ic6132da73f728b86a0a8b58afb7021125166a3ac Reviewed-on: https://chromium-review.googlesource.com/c/1324609 Commit-Queue: David Jacobo <djacobo@chromium.org> Reviewed-by:
-
yoshiki iguchi authored
Recently the chrome pip windows have WindowStateType::PIP and behaves as pip windows. Pip windows moves with animation but the mask bounds was not synced with these animation. As the result, the test was flaky (see the bug). This CL adds the observer of window bounds and make it sure that the layer bounds is synced with the window bounds. Bug: 901235 Test: Ran PictureInPictureWindowControllerBrowserTest. EnterPictureInPictureThenFullscreen 10 times and observed no error. Change-Id: Ide03ab1465170ccaf35af08377d3dd1df0cf7ee2 Reviewed-on: https://chromium-review.googlesource.com/c/1316986 Commit-Queue: Yoshiki Iguchi <yoshiki@chromium.org> Reviewed-by:Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#606273}
-
Eric Seckler authored
This allows mocking of the NotificationManager in places where areNotificationsEnabled() is called. Added in preparation of the mobile tracing feature, which requires mocking this method for tests. TBR=mvanouwerkerk@chromium.org,nyquist@chromium.org Bug: 898512 Change-Id: Ic739269858970a2365ae6772f269e0aff19d4f5c Reviewed-on: https://chromium-review.googlesource.com/c/1321730Reviewed-by:
Eric Seckler <eseckler@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Commit-Queue: Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#606272}
-
Dale Curtis authored
I'll switch ffmpeg over in a future CL since it seems to need some work before it's ready to go. Per davidben at chromium.org who originally authored this update on https://chromium-review.googlesource.com/c/chromium/src/+/1119211: Yasm has been unmaintained for a few years, while NASM is actively maintained. Yasm is already missing some of the newer Intel instructions, and will continue to miss newer ones. Additionally, BoringSSL gets its assembly from OpenSSL which natively tests with NASM, not Yasm, so using NASM puts us closer to the tested path. BUG=766721 TEST=CQ is happy R=brucedawson, davidben Change-Id: Ifa49686e2985967c19b7fc91f94ef6350038fb7c Reviewed-on: https://chromium-review.googlesource.com/c/1313832 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Reviewed-by:
David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#606271}
-
Stephen Martinis authored
Adds a general CQ documentation page. Will add an auto generated markdown doc based on cq.cfg once this lands. Bug: 902507 Change-Id: I153efab72885faa2d70051f4372bfbcc2164f6d4 Reviewed-on: https://chromium-review.googlesource.com/c/1321579 Commit-Queue: Stephen Martinis <martiniss@chromium.org> Reviewed-by:
Sergey Berezin <sergeyberezin@chromium.org> Reviewed-by:
Andrii Shyshkalov <tandrii@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#606270}
-
Ken Rockot authored
This fixes some regressions which caused Answer Card display handling to interfere with normal search UI behavior in the app list. Namely, automatic selection of top non-Answer-Card results, and autocomplete of text in the input box. Bug: 902563 Change-Id: Ie45672ae64184d7ed6116752bad1c7a0ca38c646 Reviewed-on: https://chromium-review.googlesource.com/c/1325081Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#606269}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/421605af68e3..49c8eafcd54c git log 421605af68e3..49c8eafcd54c --date=short --no-merges --format='%ad %ae %s' 2018-11-07 ehmaldonado@chromium.org git-cl: Stop logging response headers on 404 Gerrit RPC status. Created with: gclient setdep -r src/third_party/depot_tools@49c8eafcd54c The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:881860 TBR=agable@chromium.org Change-Id: Ic7135e3c7f4b082ba5407ee2ff44670d41a4929b Reviewed-on: https://chromium-review.googlesource.com/c/1324809Reviewed-by:
-
Clark DuVall authored
These will help us know how often these special headers are changed or removed. Also added a histogram to track the number of users with a webRequest extension installed. Bug: 827582 Change-Id: Ia4e53d528363eb29a9271e6b635b97dd90117a7d Reviewed-on: https://chromium-review.googlesource.com/c/1320469 Commit-Queue: Clark DuVall <cduvall@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#606267}
-
Philip Rogers authored
These failures have been added since BGPT was initially turned on and I have verified that each of these is not a real failure. Change-Id: I9aa8210ad071cf1aad517bc18b7bc1dcba0acc5a Reviewed-on: https://chromium-review.googlesource.com/c/1324882 Commit-Queue: Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#606266}
-
Livvie Lin authored
Updates color from yellow to black (by relying on default color) to improve contrast and better match neutral state icon color. Screenshot: https://drive.google.com/file/d/1JMptH0qC9cIyPIzSD99T29Qvm22M4fr-/view?usp=sharing Bug: 900027 Change-Id: I1732de356aed28c4c505b5b24cf0e3c666b927fb Reviewed-on: https://chromium-review.googlesource.com/c/1321858 Commit-Queue: Livvie Lin <livvielin@chromium.org> Reviewed-by:
Erik Luo <luoe@chromium.org> Cr-Commit-Position: refs/heads/master@{#606265}
-
Filip Gorski authored
Replacing suggestion source with an empty suggestions source, once SuggestionsUiDelegateImpl is destroyed. Bug: 898078 Change-Id: Ic6f05da92e0c90f566275d4b9f0e1fb12afeb2a6 Reviewed-on: https://chromium-review.googlesource.com/c/1324611Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Filip Gorski <fgorski@chromium.org> Cr-Commit-Position: refs/heads/master@{#606264}
-
Khushal authored
YUV decoding is currently hardcoded to jpegs and the decision is spilled to a couple of places. Since we want to add it for WebP, centralize it to DeferredImageDecoder which makes the decision at paint time based on whether it is supported by the ImageDecoder implementation for each format. R=pdr@chromium.org Change-Id: I156d397c578c45a1490385aecbd96546c4ce798b Reviewed-on: https://chromium-review.googlesource.com/c/1320750Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#606263}
-
Joel Hockey authored
Bug: 878324 Change-Id: I09976b84a4016d687c505f0808d92d57ab87ee7c Reviewed-on: https://chromium-review.googlesource.com/c/1312138 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
-
Scott Graham authored
This also required implementing the type tables for int64/uint64 as BigInt. Additionally, some test support code to pull BigInt out of V8 as 64-bit types because gin assumes always-Number. Bug: 883496 Change-Id: I10d07124e59f0fdde8f053007eca30508751b211 Reviewed-on: https://chromium-review.googlesource.com/c/1318729 Commit-Queue: Scott Graham <scottmg@chromium.org> Reviewed-by:
-
Roberto Carrillo authored
This is because we don't want to allocate dedicated hardware for this cq builder yet, as it's optional and still under development. R=stgao,smut,liaoyuke Change-Id: Ie0d896993ed54172c502af938229612e9e268714 Reviewed-on: https://chromium-review.googlesource.com/c/1325073 Commit-Queue: Roberto Carrillo <robertocn@chromium.org> Reviewed-by:
smut <smut@google.com> Reviewed-by:
-
Francois Doray authored
The documentation for ScopedTaskEnvironment recommends making it the first member of the test fixture: https://cs.chromium.org/chromium/src/base/test/scoped_task_environment.h?l=54-59&rcl=376db7a96e0287f0d010acd18e7a379d190cac71 We are chaning this particular case because we want to make the constructor of ScopedTaskEnvironment set a global variable that is read by PlatformThread::SetCurrentThreadPriority(). If ScopedTaskEnvironment is initialized late in the test execution, setting this global variable races with a call to PlatfromThread::SetCurrentThreadPriority() on the thread created from this stack: base::(anonymous namespace)::CreateThread base::PlatformThread::CreateWithPriority base::Thread::StartWithOptions net::test::QuicHttpProxyBackendStreamTest::CreateTestBackendProxy net::test::QuicHttpProxyBackendStreamTest::SetUp Bug: 902441 Change-Id: I4869410f43383bd7f94f68fc7790e3305f3d1b4a Reviewed-on: https://chromium-review.googlesource.com/c/1320654 Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#606259}
-
James Hawkins authored
R=hansberry@chromium.org Bug: 899324 Test: none Change-Id: I4d1f6b4f7eec6ec938360dd955ce37b9df4a5914 Reviewed-on: https://chromium-review.googlesource.com/c/1325031Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Commit-Queue: James Hawkins <jhawkins@chromium.org> Cr-Commit-Position: refs/heads/master@{#606258}
-
Ben Pastene authored
This will add a comment to the gn_arg log link on chromium bots: https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8930669115526655984/+/steps/lookup_GN_args/0/logs/gn_args/0 This will hopefully help avoid confusion when a non-CrOS chromium dev gets a CL blocked by a simplechrome bot. (See the linked bug where someone wasn't familiar with it and tried copy-pasting the arg dump outside the SDK.) I looked into adding the comment further upstream in chromite's cros_chrome_sdk libs, but it makes heavy use of gn_helpers, and adding comment support to that is non-trivial. This can't land until https://chromium-review.googlesource.com/c/chromiumos/chromite/+/1320309 and gets rolled into chromium. Bug: 901471 Change-Id: I9ad646a9b6ab6fd29d4adb7acfd842b26c3825ae Reviewed-on: https://chromium-review.googlesource.com/c/1318179Reviewed-by:
-
Erik Luo authored
Adds new experimental protocol method, which uses `WebContents::GenerateMHTML` underneath. Bug: 901933 Change-Id: I52e707f89378fe3a1488a3cd8afd7cdded1b77ea Reviewed-on: https://chromium-review.googlesource.com/c/1297732 Commit-Queue: Erik Luo <luoe@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#606256}
-
