- 26 Apr, 2018 40 commits
-
-
Matt Falkenhagen authored
ServiceWorkerNewScriptLoader was using the ptr then letting it fall out of scope. ServiceWorkerScriptLoaderFactory still held a ptr to the factory which is strongly bound, so the factory shouldn't die anyway, but it seems safer if ServiceWorkerNewScriptLoader holds the cloned ptr too throughout its life. I'm not sure if this is actually needed for ExtensionURLLoaderFactory, but it seems possible to write a factory that would fail if the cloned ptr falls out of scope. Bug: 836129 Change-Id: Id7b4ab9d72bb758fe639e963e2747f915e67aea3 Reviewed-on: https://chromium-review.googlesource.com/1029271Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#553929}
-
https://chromium.googlesource.com/angle/angle.git/+log/23dc90b81efb..197d52949eed $ git log 23dc90b81..197d52949 --date=short --no-merges --format='%ad %ae %s' 2018-04-25 geofflang Wrap all preprocessor code in the angle namespace. Created with: roll-dep src/third_party/angle BUG=chromium:836820,chromium:801364 The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=geofflang@chromium.org Change-Id: I4e73dc6ca51b5b8863fbcd0b266f8cd1a5df2500 Reviewed-on: https://chromium-review.googlesource.com/1029194Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#553928}
-
Gyuyoung Kim authored
The flaky failure of the test seems to be due to not waiting long enough after resuming work again. This Cl changes the workaround logic to actually wait until the javascript work again (or let the test fail by timing out otherwise). Bug: 832191 Change-Id: I3c2f04ccf4d00cee6505e607566628d690f4ef00 Reviewed-on: https://chromium-review.googlesource.com/1011744 Commit-Queue: Gyuyoung Kim <gyuyoung.kim@lge.com> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#553927}
-
Renee Wright authored
This CL adds a preference called kCrostiniEnabled (= "crostini.enabled") and sets it to true when Crostini is installed. Bug: 833125 Change-Id: I58f27113e49cdcbc1c4aaf99f5aa4096fcdab902 Reviewed-on: https://chromium-review.googlesource.com/1013843 Commit-Queue: Renée Wright <rjwright@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Cr-Commit-Position: refs/heads/master@{#553926}
-
https://pdfium.googlesource.com/pdfium.git/+log/7132ee35925f..9b8b217e6f8f $ git log 7132ee359..9b8b217e6 --date=short --no-merges --format='%ad %ae %s' 2018-04-25 tsepez Replace reinterpret_cast with static_cast where possible 2018-04-25 hnakashima Make XFA Caret become immediately visible when moved. 2018-04-25 rharrison Use local for return value in factory method 2018-04-25 rharrison Don't store CE (comment extension) block data when decoding GIF 2018-04-25 thestig Use a bool in FindBit() in the fax codec. 2018-04-25 thestig Add PostScript PASSTHROUGH options to FPDF_SetPrintMode(). 2018-04-25 thestig Use PredictorType in more places. Created with: roll-dep src/third_party/pdfium BUG=chromium:835608,chromium:833168 The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Ib59b785d5d3425a110c42e7af4b7eb1533232813 Reviewed-on: https://chromium-review.googlesource.com/1029189Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#553925}
-
Hirokazu Honda authored
BUG=chromium:834170 TEST=VDA/VEA/JDA/JEA unittest built scueessfully for Chrome OS on both x86 and ARM platforms TEST=made sure for other platforms by CQ Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I480220047ac23e4c26ee4dfff0ac2ef3bac70f6b Reviewed-on: https://chromium-review.googlesource.com/1016222Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#553924}
-
Rakina Zata Amni authored
TBR=qinmin@chromium.org Bug: 837104 Change-Id: I8f59a618815ce71de395af29795b891529a75ef4 Reviewed-on: https://chromium-review.googlesource.com/1029554Reviewed-by:
Rakina Zata Amni <rakina@chromium.org> Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Cr-Commit-Position: refs/heads/master@{#553923}
-
Tsuyoshi Horo authored
Bug: 836832 Change-Id: I2930377b31e99e82704aa4d5e27780181c38c3ba Reviewed-on: https://chromium-review.googlesource.com/1028530 Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#553922}
-
https://skia.googlesource.com/skia.git/+log/25af671a3d7d..6b043cb9cc1a $ git log 25af671a3..6b043cb9c --date=short --no-merges --format='%ad %ae %s' 2018-04-26 angle-skia-autoroll Roll third_party/externals/angle2/ f827123d9..197d52949 (2 commits) 2018-04-25 fmalita [skottie] Add support for inverse mask paths 2018-04-25 swiftshader-skia-autoroll Roll third_party/externals/swiftshader/ c8eedebdf..840f47ea8 (5 commits) 2018-04-25 enne Fix GrAAConvexTessellator trying to fan a 0 point ring 2018-04-25 bsalomon Reland "Revert "Add arcs as a specialized geometry to GrShape."" 2018-04-25 liyuqian Remove SkASSERT(fConvexity == kUnknown_Convexity) due to racing 2018-04-25 bsalomon Make SkString::appendf safe for long strings. 2018-04-25 skcms-skia-autoroll Roll skia/third_party/skcms 2c9b55f..ba9fcb3 (1 commits) 2018-04-25 reed fix android-framework 2018-04-25 csmartdalton Remove the MSAA path renderer Created with: roll-dep src/third_party/skia BUG=chromium:830038 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=stani@chromium.org Change-Id: I027b96e1a3a856ef003b64a2fbc01864671fea9b Reviewed-on: https://chromium-review.googlesource.com/1029611Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#553921}
-
Darren Shen authored
This patch introduces a new ash::Shell::ReloadKeyboard() method that reloads the IME without recreating a KeyboardController. It destroys the keyboard UI window instead and replaces it with a new one. We use this for accessibility prefs. The accessibility VK and normal VK are different, so when we switch between the two, we have to reload IME. Bug: 731537 Change-Id: I2388839206a48d81873f4bc6e7cf1ad2d0ed30f6 Reviewed-on: https://chromium-review.googlesource.com/1025532 Commit-Queue: Darren Shen <shend@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Yuichiro Hanada <yhanada@chromium.org> Cr-Commit-Position: refs/heads/master@{#553920}
-
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/2f2142eff8c0..2acf49579846 $ git log 2f2142eff..2acf49579 --date=short --no-merges --format='%ad %ae %s' 2018-04-26 ehmaldonado Revert "bot_update: Patch on gclient by default." Created with: roll-dep src/third_party/depot_tools BUG=chromium:643346 The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: Id9901636e94a10f8218b33afa2579f93796c2c41 Reviewed-on: https://chromium-review.googlesource.com/1029351Reviewed-by:
depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#553919}
-
Peter Kotwicz authored
The android.app.Activity passed to the BasicNativePage constructor is always a ChromeActivity. This CL changes the type of the parameter to the BasicNativePage constructor to ChromeActivity. This enables removing an always-true "instanceof ChromeActivity" if() statement. BUG=835294 Change-Id: I7e63c26ae1d1eb53aa7e5be71174310320c6b471 Reviewed-on: https://chromium-review.googlesource.com/1021993 Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#553918}
-
Luciano Pacheco authored
This CL fixes the keyboard navigation when using screen reader/ Chromevox. The main fix is to force focus on the cr.ui.Tree/DirectoryTree element when navigating with Chromevox keyboard shortcut "Search+right arrow", before the focus was staying on "body" element so Tree couldn't handle the keyboard events to expand/collapse directories. It's a series of small fixes. 1. Fix text read by Chromevox when navigating on directories, it was reading all sub-directories names, instead of only the current focused directory's name, fixed by adding |id| to each entries' label element, to make existing |aria-labelledby| attribute work for screen reader. This was broken because we overwrite the |innerHTML| from |cr.ui.TreeItem|, losing the |id|. 2. Listen to |click| event on DirectoryTree and forces the focus to it when the focus/activeElement is the "body" element. This happens when Chromevox issues the |click| event when user press "Search+right arrow". 3. Replace |cr.ui.Tree|'s |role| attribute from "group" to "navigation", which is a "landmark" type which is recommended [1]. This required to change |cr.ui.Tree| to not overwrite existing |role| attribute. [1] - https://developers.google.com/web/fundamentals/accessibility/how-to-review#take_advantage_of_headings_and_landmarks Bug: 755278 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: If33be610e1d28f0a69205ee148783328a367fe80 Reviewed-on: https://chromium-review.googlesource.com/985772 Commit-Queue: Luciano Pacheco (SYD) <lucmult@chromium.org> Reviewed-by:
Naoki Fukino <fukino@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Reviewed-by:
Sasha Morrissey <sashab@chromium.org> Cr-Commit-Position: refs/heads/master@{#553917}
-
Nicholas Verne authored
Concierge client's long-running StartContainer method is terminated by one of two signals: ContainerStarted or ContainerStartupFailed. After this change, CrostiniManager can respond to the failures as well as the successes. Bug: 822507 Change-Id: Ic86f8876d084029436a99a3e0500a306d7cea54c Reviewed-on: https://chromium-review.googlesource.com/1026950Reviewed-by:
Timothy Loh <timloh@chromium.org> Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Commit-Queue: Nicholas Verne <nverne@chromium.org> Cr-Commit-Position: refs/heads/master@{#553916}
-
Hwanseung Lee authored
according to previous git log[1], it looks likes used to store test files in official Chrome build gs:// drops. these files haven't been touched in a long time. and it seems like not used any more. [1]https://codereview.chromium.org/545103003 Bug: 829975 Change-Id: Ida8e887c64d4d18b7eb877f3cda2001a1871b844 Reviewed-on: https://chromium-review.googlesource.com/1027598Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Hwanseung Lee <hwanseung@chromium.org> Cr-Commit-Position: refs/heads/master@{#553915}
-
Koji Ishii authored
This patch changes visual rect of NGPhysicalTextFragment to include its frame rect. Legacy does so, but NG did not when it was first implemented due to the lack of understanding. After reviewing test results, it turns out that by not doing so, background and decorations on space characters are affected by this difference because space characters do not have glyph bounding box, which results in empty visual rect. Includes rebaselines that improve the rendering. Bug: 636993, 714962 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_layout_ng;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I888f8b27680aa1ff806cca15c84919461c06fc31 Reviewed-on: https://chromium-review.googlesource.com/1027012Reviewed-by:
Aleks Totic <atotic@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#553914}
-
tzik authored
In C++17, noexcept keyword is a part of the function type, and that causes a pattern match failure on base::Bind implementation. This CL fixes the failure by falling it back to bare function cases. Bug: 752720 Change-Id: I98c71977fa3fd759956c86e394fb9e30179c951c Reviewed-on: https://chromium-review.googlesource.com/1027530Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Cr-Commit-Position: refs/heads/master@{#553913}
-
Peter Boström authored
The generic icon should be shown when there's only one (non-signed in) user. We need to listen for add/remove profile events so we can detect whether a generic icon should be shown or not for existing windows as well. Bug: chromium:822070 Change-Id: Ia84feb13dd10b4459aeff326e2fd6e1d29698a76 Reviewed-on: https://chromium-review.googlesource.com/1028981Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#553912}
-
Katie D authored
Because language -> voice pref is a DICTONARY type pref, this change extends settings-dropdown-menu to work with dictionary prefs given a new parameter, prefKey. When set, prefKey tells the settings dropdown which key in the dictionary is associated with the value it represents. This is not yet hooked up to the Text-to-Speech controller. In addition, we don't yet define default voices per language. Bug: 823359 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I6b7ae800ed6f0230076da5d65114d305fc1dc64d Reviewed-on: https://chromium-review.googlesource.com/1020456 Commit-Queue: Katie Dektar <katie@chromium.org> Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/heads/master@{#553911}
-
Maggie Chen authored
The callback function UpdateGpuInfoOnIO is added to the DX12/Vulkan info collection path. The data is now saved in gpu_info of the browser process. Both DX12 and Vulkan info collection functions are removed from the about:gpu path. The data can be found in the gpu info. There is no need to call these two functions again. BUG=775983 TEST=manual,Chrome://histograms R=zmo@chromium.org Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I6716aed172c8c6821f60124fb9cedc0c2e2b5079 Reviewed-on: https://chromium-review.googlesource.com/1026946Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#553910}
-
Yoichi Osato authored
Bug: 766694, 523952 Change-Id: Ic794281024e97783d9f2bde6f2ca6c7f2eefdbb8 Reviewed-on: https://chromium-review.googlesource.com/1027551Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Yoichi Osato <yoichio@chromium.org> Cr-Commit-Position: refs/heads/master@{#553909}
-
Kevin Marshall authored
This change uses the tempfile library to manage temporary named files instead of using a DIY try/finally approach. Bug: 832849 Change-Id: I439ff29edfb0e8791202604d56f891827d79f0a2 Reviewed-on: https://chromium-review.googlesource.com/1029212Reviewed-by:
Scott Graham <scottmg@chromium.org> Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#553908}
-
https://chromium.googlesource.com/chromiumos/chromite.git/+log/ad0b2d2757e8..48a13aacf880 $ git log ad0b2d275..48a13aacf --date=short --no-merges --format='%ad %ae %s' 2018-04-25 dgarrett remote_try: Use luci_builder build config value. Created with: roll-dep src/third_party/chromite BUG=chromium:832747 The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I100607416aef078b66dbe44a837db19069ca5ecb Reviewed-on: https://chromium-review.googlesource.com/1029352Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#553907}
-
Tetsui Ohkubo authored
This is a reland of 59692b72 Change from original CL (PS#1): Fix use-after-free in unit test. Original change's description: > Observe ClockModel directly from DateView/TimeView > > This CL changes DateView and TimeView to directly observe ClockModel. > It removes unrelated logic from SystemTrayItem and makes embeding these > views easier. > > TEST=ash_unittests > BUG=none > > Change-Id: I70b3a873c0ac259a05597d3f93b77fd7519dd462 > Reviewed-on: https://chromium-review.googlesource.com/1025615 > Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> > Reviewed-by: Steven Bennetts <stevenjb@chromium.org> > Cr-Commit-Position: refs/heads/master@{#553433} TBR=stevenjb@chromium.org Bug: none Change-Id: I0c609729e5ccc7fea66a696b57a689097f3465af Reviewed-on: https://chromium-review.googlesource.com/1029390 Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#553906}
-
Chris Blume authored
The LSI allocators previously did not store a copy of the last generated LSI. As a result, many call sites would have to keep their own copies. Now that the LSI allocators have their own copies, the call sites can be updated to no longer store a separate copy. FrameGenerator is one such call site. BUG=759031 Change-Id: I39774ba04f4bbfd61909e9df12df76c1fd76c492 Reviewed-on: https://chromium-review.googlesource.com/1029427 Commit-Queue: Fady Samuel <fsamuel@chromium.org> Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Cr-Commit-Position: refs/heads/master@{#553905}
-
Noel Gordon authored
After crrev.com/553147 FolderShortcuts/FileManagerBrowserTest.Test/1 is a persistent TIMEOUT on the DEBUG and ASAN bots, also Test/0 is a flaky TIMEOUT on DEBUG and ASAN. Disable them on DEBUG and ASAN. Seems the expandTreeItem querySelector() is the problem: the element the test expects should appear, never does => TIMEOUT. Bug: 837106,836254 Change-Id: Icfb19ad7e2c170dc125f7081e4d69b12d0df5811 Reviewed-on: https://chromium-review.googlesource.com/1029591Reviewed-by:
Stuart Langley <slangley@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#553904}
-
Takuto Ikuta authored
We don't want to run test on the builders. I will add webrtc target in tools repository. https://chromium.googlesource.com/chromium/tools/build/+/master/scripts/slave/recipe_modules/chromium_tests/chromium_fyi.py Bug: b/78251210 Bug: 835686 Bug: 834213 Change-Id: Ib2ac5238e86fc965df9bfd4af098d60d3cbfb89b Reviewed-on: https://chromium-review.googlesource.com/1027575Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#553903}
-
Patti authored
gfx::VectorIcons were refactored in r552619 to allow arbitrarily many versions for the same icon. Update documentation to reflect this. Bug: 647286 Change-Id: I2b82a7c1c9832ed2a7bf4c83bd3223b7d73f1110 Reviewed-on: https://chromium-review.googlesource.com/1023625 Commit-Queue: Patti <patricialor@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#553902}
-
Erik Luo authored
After marking Document's "location" attribute as kHasNoSideEffect, the CL [1] failed to reset bindings tests results. [1] https://chromium-review.googlesource.com/c/chromium/src/+/1024863/ Bug: none Change-Id: Ie0be4542bd1b58939b12c342056d521abb5e4ddd Reviewed-on: https://chromium-review.googlesource.com/1029451Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Erik Luo <luoe@chromium.org> Cr-Commit-Position: refs/heads/master@{#553901}
-
Hajime Hoshi authored
According to the task type usage guideline, we use kInternalDefault for internal and default behavior tasks. This CL introduces kInternalDefault by renaming kUnspecedTimer. Doc: https://docs.google.com/document/d/1k7EEHQUEujgQ7BAhbmNdeaddwfJPWp7qjLy8mnVTQ9Y/edit Bug: 836410 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Id3d1aec136c6c30c632b87d58a13b8de76738653 Reviewed-on: https://chromium-review.googlesource.com/1027572 Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#553900}
-
Kenichi Ishibashi authored
The GDB pretty printers for blink has moved. Update the doc accordingly. Bug: N/A Change-Id: Ifce05658d6c207d761fb349d5c4ab877f7e09ae9 Reviewed-on: https://chromium-review.googlesource.com/1029650 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#553899}
-
Alan Cutter authored
This CL fixes a regression caused by https://chromium-review.googlesource.com/1004886 where permission prompts would appear partially off screen in full screen mode on platforms where we hide the Chrome UI. Before: https://bugs.chromium.org/p/chromium/issues/attachment?aid=334665&signed_aid=cQIe_b4bfUZn8i-akRK_ZQ==&inline=1 After: https://bugs.chromium.org/p/chromium/issues/attachment?aid=334829&signed_aid=cXhOlJe-_oibvrzmLtL4Bw==&inline=1 This also fixes the DCHECK in GetPageInfoAnchorRect() to be relative to GetPageInfoAnchorView() rather than copy pasting its bail out condition. Bug: 833257, 814532 Change-Id: I6ef85ace735b0b217b3a473365791ad453cf8378 Reviewed-on: https://chromium-review.googlesource.com/1013676 Commit-Queue: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#553898}
-
tzik authored
https://chromium.googlesource.com/webm/libwebm.git/+log/b03c65468b06..af81f26025b7 $ git log b03c65468..af81f2602 --date=short --no-merges --format='%ad %ae %s' 2018-03-02 mjbshaw Fix MSVC warning about 2147483648 not fitting in an int 2018-02-28 mjbshaw Fix compilation with MSVC 2018-02-06 tomfinegan Allow shared builds of libwebm. 2018-01-31 tomfinegan webm2pes: Avoid OOB reads caused by invalid superframe index. 2018-02-01 jzern vp9_header_parser: make SetFrame private 2018-01-30 tomfinegan Limit string element size to 20 million bytes. 2018-01-22 velden Replace uses of deprecated std::auto_ptr with std::unique_ptr. 2018-01-19 mjbshaw Set a maximum limit on element recursion depth 2017-12-18 tomfinegan Silence -Wdeprecated-declarations in GCC 4.7+. 2017-12-07 huisu Update VP9 level definition Created with: roll-dep src/third_party/libwebm/source BUG=836706 Change-Id: I16a6a0a850e9a47a81176d116af7ddde4fd6c0bf Reviewed-on: https://chromium-review.googlesource.com/1027561Reviewed-by:
Miguel Casas <mcasas@chromium.org> Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Cr-Commit-Position: refs/heads/master@{#553897}
-
Kunihiko Sakamoto authored
This patch fixes a bug where font display timeouts (100ms and 3s) didn't start if the font resource is already started loading by <link rel=preload>. Bug: 835583 Change-Id: Ie464179ebcc56f2d18c99d234eadd4fc26bc1fcd Reviewed-on: https://chromium-review.googlesource.com/1027331Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#553896}
-
kapishnikov authored
BUG=836347 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I53cb9dca6a9dd1d874c58d72b36c75e82b1142c4 Reviewed-on: https://chromium-review.googlesource.com/1026415Reviewed-by:
Misha Efimov <mef@chromium.org> Commit-Queue: Andrei Kapishnikov <kapishnikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#553895}
-
Brad Lassey authored
changes Socket::Read(), Socket::ReadIfRead(), Socket::Write(), StreamSocket::Connect(), SocketPosix::Accept() & SocketPosix::Connect() to CompletionOnceCallback. R=bnc@chromium.org, reillyg@chromium.org, sergeyu@chromium.org, sky@chromium.org Bug: 807724 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo;master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ia363b632bf1193c40576e3ccdd93188081aca589 Reviewed-on: https://chromium-review.googlesource.com/907076 Commit-Queue: Brad Lassey <lassey@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Stephen Lanham <slan@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Bence Béky <bnc@chromium.org> Cr-Commit-Position: refs/heads/master@{#553894}
-
Sam McNally authored
Mime handler guests currently do not set their view type. Thus, their foreground pages do not count as foreground pages for the purpose of deciding whether to keep their background pages alive, resulting in the background page being shut down while the mime handler remains open. Set the view type to VIEW_TYPE_EXTENSION_GUEST when creating mime handler guests to ensure mime handlers keep their background pages alive while open. Bug: 819761 Change-Id: Ibc64c93bbb33022375cf91b45785f543a53ca71c Reviewed-on: https://chromium-review.googlesource.com/1023518 Commit-Queue: Sam McNally <sammc@chromium.org> Reviewed-by:
Ehsan Karamad <ekaramad@chromium.org> Cr-Commit-Position: refs/heads/master@{#553893}
-
Yoichi Osato authored
This patch wanted to confirm changing selection invalidation between execCommand("selectAll") and Selection.setBaseAndExtent(). However calling execCommand("selectAll") before load is flaky from the point of invalidation. This patch arranges the function calls so that invalidation occurs only on selection difference w/o flakiness. Bug: 774437 Change-Id: I63efe553282f4a6643c0d7b8eb0b0597b1ccac9f Reviewed-on: https://chromium-review.googlesource.com/1025594 Commit-Queue: Yoichi Osato <yoichio@chromium.org> Reviewed-by:Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#553892}
-
Maks Orlovich authored
This is so that exporting of this functionality over mojo can accurately express the underlying type and the kNoLimit constant. (Which doesn't seem doable with size_t since its size, and therefore value of its max, differs on different platforms). Bug: 767450 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I741bfe1c942e5ee7752f346932a26e861cefb0c8 Reviewed-on: https://chromium-review.googlesource.com/1027905Reviewed-by:
Eric Roman <eroman@chromium.org> Commit-Queue: Maks Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#553891}
-
https://chromium.googlesource.com/catapult.git/+log/d43ffede2b5c..dc970d3e1f7b $ git log d43ffede2..dc970d3e1 --date=short --no-merges --format='%ad %ae %s' 2018-04-24 simonhatch Dashboard - Remove alert_group. Created with: roll-dep src/third_party/catapult The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=sullivan@chromium.org Change-Id: Ia5ddfdf725e1f290fe2f04d6c0db1ff92fe17093 Reviewed-on: https://chromium-review.googlesource.com/1028990Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#553890}
-