- 07 Feb, 2019 40 commits
-
-
Daniel Rubery authored
Bug: 927515 Change-Id: Id50577de69b38df4d99bec89228eb6e8f98cbed0 Reviewed-on: https://chromium-review.googlesource.com/c/1458919 Commit-Queue: Daniel Rubery <drubery@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#630074}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/be531eda4378..ff3805a63456 Created with: gclient setdep -r src-internal@ff3805a63456 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:891313 TBR=mmoss@chromium.org Change-Id: I37a948c429007f14825cbbca6d87d63db5b399bf Reviewed-on: https://chromium-review.googlesource.com/c/1459198Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#630073}
-
Lambros Lambrou authored
This tool stopped working when comments ({#..#}) were added to the manifest Jinja templates. Change-Id: I54a0fce1907b55671787a9dd57f62d2f2e958d2e Reviewed-on: https://chromium-review.googlesource.com/c/1459062 Auto-Submit: Lambros Lambrou <lambroslambrou@chromium.org> Reviewed-by:Jamie Walch <jamiewalch@chromium.org> Commit-Queue: Jamie Walch <jamiewalch@chromium.org> Cr-Commit-Position: refs/heads/master@{#630072}
-
Danan S authored
Records apps that have been launched by a user using the device during Demo mode. The sample is recorded when each app is launched. For any given app id, the metric is recorded only once. Also: - Fixed bug where kBrowser enum wasn't resolved from its app id. - Fixed description of when the UniqueAppsLaunched metric is recorded. Bug: 900261 Change-Id: Icee9c834a4e76432184307433aa96e54cc9df832 Reviewed-on: https://chromium-review.googlesource.com/c/1444694 Commit-Queue: Danan S <danan@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Dan Erat <derat@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#630071}
-
wutao authored
This patch modifies the behavior that Back() from assistant_page should be to the search_result_page. Bug: 924624 Test: manual Change-Id: Iba644fee5426ab8b36f47ad4b2e459b1286bd50d Reviewed-on: https://chromium-review.googlesource.com/c/1455519Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: Tao Wu <wutao@chromium.org> Cr-Commit-Position: refs/heads/master@{#630070}
-
Daniel Bratell authored
Change-Id: Ib42849852e32348385fcb4389e7ddcfb0085cdf3 Reviewed-on: https://chromium-review.googlesource.com/c/1456010Reviewed-by:
Fredrik Söderquist <fs@opera.com> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#630069}
-
Harald Alvestrand authored
This is a step in the process of making the IceTransportAdapter use interfaces from webrtc/api rather than interfaces from cricket:: Bug: chromium:864871 Change-Id: Ibd402232d29949e4aa50d01fd3ff510b950099c1 Reviewed-on: https://chromium-review.googlesource.com/c/1458176 Commit-Queue: Harald Alvestrand <hta@chromium.org> Reviewed-by:
Steve Anton <steveanton@chromium.org> Cr-Commit-Position: refs/heads/master@{#630068}
-
Rayan Kanso authored
The CL adds a general-purpose feature flag, and creates DevToolsBackgroundServicesContext which is part of the StoragePartition. The context will be responsible for logging the events from the relevant features (BackgroundFetch/BackgroundSync), and will be accessible from the soon-to-be-added DevTools protocol handler (via the StoragePartition) to perform the reads/writes. Bug: 927726 Change-Id: I7c48a1bac742b9e6e8eaed52f8e69eace6c25f1b Reviewed-on: https://chromium-review.googlesource.com/c/1407077 Commit-Queue: Rayan Kanso <rayankans@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#630067}
-
Vlad Tsyrklevich authored
This reverts commit dcea6896. Reason for revert: The underlying change causes failures in the headless_browsertests on Mac10.13 Tests (dbg) https://bugs.chromium.org/p/chromium/issues/detail?id=929873 Original change's description: > Add GWP-ASan hook to macOS crashpad handler > > Add the GWP-ASan UserStreamDataSource to the macOS crashpad handler. > The GWP-ASan hook determines when an exception is related to GWP-ASan > and reports additional debug information. > > Bug: 912286 > Change-Id: I1cd0227ca8aade1bd17e25b83832cdb8f3e58d5e > Reviewed-on: https://chromium-review.googlesource.com/c/1457461 > Reviewed-by: Mark Mentovai <mark@chromium.org> > Commit-Queue: Vlad Tsyrklevich <vtsyrklevich@chromium.org> > Cr-Commit-Position: refs/heads/master@{#629881} TBR=mark@chromium.org,vtsyrklevich@chromium.org Change-Id: I9557c90e7ef6db6cf68e0b518538409783762395 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 912286 Reviewed-on: https://chromium-review.googlesource.com/c/1459595Reviewed-by:
Vlad Tsyrklevich <vtsyrklevich@chromium.org> Commit-Queue: Vlad Tsyrklevich <vtsyrklevich@chromium.org> Cr-Commit-Position: refs/heads/master@{#630066}
-
Daniel Murphy authored
This re-enables the onion-soup codepath, which was disabled due to crashes (hangs) on stable. There is now more debugging info being collected, so when we see crashes on Canary, we can figure out the cause. R=mek@chromium.org Bug: 927534 Change-Id: I6f12acfd074e9931d1654e66a6a17e8ee002166e Reviewed-on: https://chromium-review.googlesource.com/c/1456652Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#630065}
-
Ian Wells authored
Propagates a status code from MHTMLArchive::Create back to the browser so that OfflinePageTabHelper can report the result of trying to load the archive along with the page's offline namespace. Bug: 905409 Change-Id: I75df2dc65498598a6c3ce676899b8b9dab872822 Reviewed-on: https://chromium-review.googlesource.com/c/1336216Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Carlos Knippschild <carlosk@chromium.org> Reviewed-by:
Jian Li <jianli@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
-
bsheedy authored
Updates all of the tests in VrBrowserDialogTest to be actual RenderTests instead of just capturing an image and doing nothing with it. Also moves the majority of them out into different test classes that are more appropriate for what they are testing since most aren't actually for permission dialogs. Bug: 887505, 864775, 862182 Change-Id: If65738034d49558f48d89ab26dda8aacc15c4774 Reviewed-on: https://chromium-review.googlesource.com/c/1414192 Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Bill Orr <billorr@chromium.org> Cr-Commit-Position: refs/heads/master@{#630063}
-
Daichi Hirono authored
Passing NULL for mime-type here is valid and indicates that the drop destination does not support dropping at the current location. We were creating a std::string from a nullptr when calling DataOffer::Accept() and that called strlen on nullptr. BUG=b:120240161 TEST=exo_unittests Change-Id: I00cfe116f01383cc94f3f93f4b8ca4af7587db2e Reviewed-on: https://chromium-review.googlesource.com/c/1436469 Commit-Queue: Kristian H. Kristensen <hoegsberg@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
Kristian H. Kristensen <hoegsberg@chromium.org> Cr-Commit-Position: refs/heads/master@{#630062}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/af5e7a520e64..413f0052c89e git log af5e7a520e64..413f0052c89e --date=short --no-merges --format='%ad %ae %s' 2019-02-07 lalitm@google.com Merge "trace_processor: improve trace processor testing infra" 2019-02-07 taylori@google.com Merge "perfetto-ui: Add border on selection" 2019-02-07 eseckler@google.com Merge "service: Write a trusted PacketSequenceID with each packet." 2019-02-07 lalitm@google.com trace_processor: add missing ref type on instants table 2019-02-07 fmayer@google.com Merge "Add SharedRingBuffer" Created with: gclient setdep -r src/third_party/perfetto@413f0052c89e The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: Ia1db71323c04a496969232f1f1d3428ace2e7c0f Reviewed-on: https://chromium-review.googlesource.com/c/1459197Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#630061}
-
John Delaney authored
Record how many pages and how many ad iframes would be affected by a size intervention on frames without user activation, that exceed a size on 1050 kilobytes. This defines size as the sum of all cached resource sizes and all network bytes used to load a frame and all of its subresources. Bug: 878393 Change-Id: I4ea1ba03f6b348f83a02d7f22650e1b38a46a28e Reviewed-on: https://chromium-review.googlesource.com/c/1440912 Commit-Queue: John Delaney <johnidel@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#630060}
-
David Bokan authored
Not sure how this can happen. ScrollbarsFor somehow returns a nullptr in the ScrollbarSet. This must mean ToScrollbarLayer returns nullptr. This method returns nullptr in the base and this in the ScrollbarLayerImplBase override. Therefore the LayerToId muse be returning a non-scrollbar layer. The only time we add anything to element_id_to_scrollbar_layer_ids_ though is from LTI::RegisterScrollbar which is necessarily a scrollbar layer. I think this means the Layer with the scrollbar layer's ID at some point changes to a different layer. The ID-to-Layer mapping is cleared when a layer is destroyed and the scrollbar layer clears the element_id_to_scrollbar_layer_ids_ mapping in its destructor so I'm speculating that we might be registering a new non-scrollbar layer with the same id. I've converted the DCHECK to a CHECK at that location to see if it comes back with any crashes from the wild. Bug: 924068 Change-Id: I9bb15812aeda0a2c92d2547a52af9fbdbacc65b0 Reviewed-on: https://chromium-review.googlesource.com/c/1435686Reviewed-by:
Robert Flack <flackr@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#630059}
-
Lukasz Anforowicz authored
This CL changes how SharedWorkers create their URLLoaderFactory: 1. Ad-hoc creation code is replaced with a call into RenderProcessHost::CreateURLLoaderFactory, which 1.1. Sets |request_initiator_site_lock| to the right origin, 1.2. Sets |is_corb_enabled| to true. 2. Code is integrated with URLLoaderInterceptor (at least if the NetworkService is enabled) which helps test the changes wrt their impact on CORB behavior. This CL also tweaks RequestInterceptor used by various CORB tests, so that it forwards the actual headers / body / error-code of the response (previously the renderer was always told that the response errored out with ERR_NOT_IMPLEMENTED code). Bug: 927849 Change-Id: Ic4c673d2f9c74fd89b8482552b7b72346f783c44 Reviewed-on: https://chromium-review.googlesource.com/c/1450430 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#630058}
-
Ben Wagner authored
The Chromium build system doesn't generally care, but warnings pop up in several ides when projects have duplicate source files. Change-Id: I4f747246dde1736799f85faa4ae97c0bf6eb8b7e Reviewed-on: https://chromium-review.googlesource.com/c/1459036 Commit-Queue: Ben Wagner <bungeman@chromium.org> Commit-Queue: Dominik Röttsches <drott@chromium.org> Reviewed-by:
Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#630057}
-
Dave Tapuska authored
BUG=907125 Change-Id: Icf032038eb14d9df65da9d1bc39870c63a1db944 Reviewed-on: https://chromium-review.googlesource.com/c/1458370Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#630056}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/d6d7c729..dd39fc4a Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I8be285c26d621f540ae91b57b9b600277afd772c Reviewed-on: https://chromium-review.googlesource.com/c/1458476Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#630055}
-
Scott Violet authored
Previously LocalSurfaceId's for top-levels came solely from the window-service. This patch allows clients to generate ids as well. Generation is handled by a MusLsiAllocator subclass. The TopLevelAllocator makes use of Compositor/LayerTreeHost to handle generation of client local surface-ids. BUG=921129 TEST=covered by tests Change-Id: I8d9fefdf6168c358510232fb9e43ab72253c66c4 Reviewed-on: https://chromium-review.googlesource.com/c/1450040Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Jonathan Ross <jonross@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#630054}
-
Weidong Guo authored
Changes: Avoid announcing search box focus when opening or closing a folder. Bug: 921189 Change-Id: Id9b3096534b1b1196d41ce290bbc4617d9ddc2a9 Reviewed-on: https://chromium-review.googlesource.com/c/1457413 Commit-Queue: Weidong Guo <weidongg@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#630053}
-
Charlie Harrison authored
Quite frequently, QUIC folks update versions and need to find a PLM reviewer. Just let them review these trivial changes themselves. Bug: None Change-Id: I9e6e0c824f515e921fb117b05cbff0bfa30b9ecf Reviewed-on: https://chromium-review.googlesource.com/c/1458799Reviewed-by:
Bryan McQuade <bmcquade@chromium.org> Commit-Queue: Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#630052}
-
Ken Rockot authored
This converts the following service manifests from JSON to C++: - Ash Pref-connector service - App service - CUPS IPP parser service - Misc Chrome file utility service - Isolated XR service - Chrome media gallery util service Bug: 895616 Change-Id: I1297990fcadb9208a8a474037179bfdcf65822e7 TBR: jamescook@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/1455465Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
-
Caleb Rouleau authored
NOTRY=True TBR=charliea@chromium.org Bug: 929839 Change-Id: If4489971e87cbb72568a6b845a479c38d25f2d5b Reviewed-on: https://chromium-review.googlesource.com/c/1459804Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#630050}
-
Moe Ahmadi authored
Currently TranslateInforbarView and its subviews assume that the translate infobar is always created in "before translate" state, i.e., the source language tab would be selected and the target language tab would be unselected. The translate infobar, however, can be created in "translating" or "after translate" states, i.e., the target language tab would be in loading or selected states respectively. This CL removes the assumed default state and instead propagates the default state to the TranslateInforbarView (and its subviews) after creation. TBR=droger@ Bug: 910994 Change-Id: Ifdb280a104e61cde81c703a490f7637986b76a72 Reviewed-on: https://chromium-review.googlesource.com/c/1448807 Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#630049}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/06d1040fab75..20be13b329a2 git log 06d1040fab75..20be13b329a2 --date=short --no-merges --format='%ad %ae %s' 2019-02-07 recipe-roller@chromium.org Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@20be13b329a2 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: Ic3450779271ee8fc09d9016360fb016424f0a69e Reviewed-on: https://chromium-review.googlesource.com/c/1458520Reviewed-by:
-
Brian White authored
Bug: 923083 Change-Id: Ic774c0bda4ce2f0fb794923d31c92511fabc76cb Reviewed-on: https://chromium-review.googlesource.com/c/1447845 Commit-Queue: Brian White <bcwhite@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#630047}
-
Wojciech Dzierżanowski authored
Bug: 926427 TBR: tbansal@chromium.org Change-Id: Ic31bc0c40a1b21c45a3d5a47c13e07255a144234 Reviewed-on: https://chromium-review.googlesource.com/c/1457317 Commit-Queue: Wojciech Dzierżanowski <wdzierzanowski@opera.com> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#630046}
-
Karan Bhatia authored
BUG=929563 TBR=dmazzoni@chromium.org Change-Id: I12c4ff8778cdfbdbf78c5bc09775bc3bd7541148 Reviewed-on: https://chromium-review.googlesource.com/c/1459316Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#630045}
-
danakj authored
R=nasko@chromium.org Change-Id: Ic53c63758fcfa393bed7193f99b9f78c8f4b8ec1 Reviewed-on: https://chromium-review.googlesource.com/c/1459137Reviewed-by:
Nasko Oskov <nasko@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#630044}
-
Daniel Rubery authored
There's a small race condition where, if the download is cancelled before we send a download ping, when we notify the IncidentReportingService, we'll fail a DCHECK, since the IncidentReportingService expects us to only send pings for IN_PROGRESS or COMPLETED downloads. Change-Id: If9e5647f2e60f19f0469f51709990ae8226cd5ee Reviewed-on: https://chromium-review.googlesource.com/c/1457672 Commit-Queue: Daniel Rubery <drubery@chromium.org> Reviewed-by:
Nathan Parker <nparker@chromium.org> Cr-Commit-Position: refs/heads/master@{#630043}
-
W. James MacLean authored
This CL implements scaling of scroll deltas for OOPIFs, in CC. Main frame scroll deltas are adjusted by CC's page_scale_factor, but OOPIFs use external_page_scale_factor instead. Bug: 795386 Change-Id: I01efe26b788bd36aaeba28773bd03262b26c45df Reviewed-on: https://chromium-review.googlesource.com/c/1363358 Commit-Queue: James MacLean <wjmaclean@chromium.org> Reviewed-by:
-
Karan Bhatia authored
This reverts commit 5fdbf6eb. Reason for revert: Introduced tests are failing Original change's description: > Click to Open PDF: Improve first-time IFRAME throttle behavior > > Currently, the IFRAME throttle doesn't always work on first-time use, > when the Chrome process is first started. This is because the IFRAME > throttle itself doesn't trigger the plugin list load. > > This CL updates the throttle to also trigger the plugin list load > itself (only if it hasn't been loaded already), and should make the > behavior less flaky. > > Bug: 924823 > Change-Id: If51e85bf2d7005af1a5a825279388dd6d9324409 > Reviewed-on: https://chromium-review.googlesource.com/c/1452771 > Commit-Queue: Lei Zhang <thestig@chromium.org> > Reviewed-by: Nasko Oskov <nasko@chromium.org> > Reviewed-by: Camille Lamy <clamy@chromium.org> > Reviewed-by: Lei Zhang <thestig@chromium.org> > Cr-Commit-Position: refs/heads/master@{#629878} TBR=nasko@chromium.org,thestig@chromium.org,tommycli@chromium.org,clamy@chromium.org Change-Id: Icb6d2acff0ad9d3bcc9072bf3e6ca42d653f27a3 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 924823, 929819 Reviewed-on: https://chromium-review.googlesource.com/c/1459339Reviewed-by:
-
Dominik Röttsches authored
Preparation for introducing a separate singleton class that builds the font unique name lookup table. These font file related methods will be used by both. No functional changes. Bug: 889864 Change-Id: Id06dc705036483f1c9972c6e66ce34c6920295be Reviewed-on: https://chromium-review.googlesource.com/c/1458296 Auto-Submit: Dominik Röttsches <drott@chromium.org> Commit-Queue: Emil A Eklund <eae@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#630040}
-
Andrew Xu authored
Implement a new UI feature: hiding the drag handle of app list in tablet mode if there is no activatable window. The main strategy is listed as following: (1) OnWindowDestroyed event should be listened to. Considering about the situation that closing the browser window through shelf while home launcher is visible. Hence we need to observe all windows from MRU list in app list code, which is pretty much what MruWindowTracker does. So the app list controller should observe MruWindowTracker and hide/show the drag handle when a window is closed. (2) When the gesture makes the app list show, the home launcher gesture handler should notify the app list controller when animation ends. The latter checks MRU window list then hides/shows the handle. Test: ash_unittests Bug: 923089 Change-Id: I9d9d60e705326cfe2ff90c59da2cccb18db87942 Reviewed-on: https://chromium-review.googlesource.com/c/1445111 Commit-Queue: Andrew Xu <andrewxu@chromium.org> Reviewed-by:
-
Peng Huang authored
For Vulkan, the CL will use the format from driver instead of hard coding. This CL also replaces the deprecated Vulkan enum VK_COLORSPACE_SRGB_NONLINEAR_KHR. Change-Id: I061eccad85f12fbfe57273e1e945b89f268ebcd0 Reviewed-on: https://chromium-review.googlesource.com/c/1456224Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#630038}
-
Sahel Sharify authored
When the fling controller generates GSU and GSE events, it uses the positions of GFS and GFC events. This cl properly populates the positions in widget of GFS and GFC events that are generated in RWHI. This fix is enough to address crbug.com/769390 where scrolling stops after deletion of the DOM element and rehittesting fails due to GSUs having (0,0) coordinates. In the following cl both position_in_widget and position_in_screen of autoscroll GFS and GFCs will get populated in the browser process using the coordinates of mouse middle click and mouse move events: [WIP] https://chromium-review.googlesource.com/c/chromium/src/+/1239174 Bug: 769390 Test: AutoscrollBrowserTest.GSUGSEValidPositionInWidget Change-Id: Ib5e12fa57b5246e5cb1ae349d3081a98863eca31 Reviewed-on: https://chromium-review.googlesource.com/c/1452505Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Commit-Queue: Sahel Sharify <sahel@chromium.org> Cr-Commit-Position: refs/heads/master@{#630037}
-
Alex Clarke authored
Store enough state inside immediate_incoming_queue_lock_ to allow ImmediateTasksTimeBudgetThrottling to know whether or not we need to schedule a DoWork. In addition we ensure that posting a task to a disabled queue with a TaskQueue::Observer doesn't schedule a DoWork (the observer may well schedule a DoWork itself however). This patch will let us simplify: https://chromium-review.googlesource.com/c/chromium/src/+/1436044/ Bug: 897751 Change-Id: I5f426fabf39acffb891bd53a2b0bf5b828ae22bf Reviewed-on: https://chromium-review.googlesource.com/c/1452162Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Alex Clarke <alexclarke@chromium.org> Cr-Commit-Position: refs/heads/master@{#630036}
-
Stephen McGruer authored
This reverts commit cd74eba0. Reason for revert: Speculative revert due to DCHECK failures in linux-chromeos-dbg Bug: 929785 Original change's description: > Declare Chrome OS Account Manager for field trial testing > > Bug: 816954 > Change-Id: I4ee640075af0948cbb8b5bfcc127123348cad98b > Reviewed-on: https://chromium-review.googlesource.com/c/1426779 > Commit-Queue: Kush Sinha <sinhak@chromium.org> > Reviewed-by: Ilya Sherman <isherman@chromium.org> > Cr-Commit-Position: refs/heads/master@{#629940} TBR=isherman@chromium.org,sinhak@chromium.org Change-Id: I3d89e1e798164bc774c084e867e7cbd969487063 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 816954 Reviewed-on: https://chromium-review.googlesource.com/c/1459326Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#630035}
-
