- 19 Feb, 2020 40 commits
-
-
Tim Dresser authored
Used https://cs.chromium.org/chromium/src/tools/perf/experimental/story_clustering/README.md to find representative stories. Bug: 1051558 Change-Id: I2a4169c8549e1ee6ed0b9d78b9ef7819ab791e42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050735 Commit-Queue: Timothy Dresser <tdresser@chromium.org> Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#742696}
-
Sergey Poromov authored
Sample run: https://ci.chromium.org/p/chromium/builders/ci/Deterministic%20Linux/26874 No-Try: true Bug: 1040247 Change-Id: Idf8f06a1899c8ef66b9b2355f6d9aad57577efa6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062986Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#742695}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/2d44550a1bd9..3db377c1c2ae Created with: gclient setdep -r src-internal@3db377c1c2ae If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I2cf8cf44fac29ee694f6e5660833a28675b5f918 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063685Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#742694}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/86b4388fdcb4..5f1ad0dc47b5 git log 86b4388fdcb4..5f1ad0dc47b5 --date=short --first-parent --format='%ad %ae %s' 2020-02-19 mtklein@google.com rm release swiftshader msan bots 2020-02-19 brianosman@google.com Reland "Move runtime shader/colorfilter into SkRuntimeEffect.cpp" 2020-02-19 fmalita@chromium.org Clip-only tiling in Viewer 2020-02-19 brianosman@google.com Switch SPIRV-Cross to use third_party GN template Created with: gclient setdep -r src/third_party/skia@5f1ad0dc47b5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC lovisolo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: lovisolo@google.com Change-Id: I88047da12a0bfa9f3313b78d20ee927888891d2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063684Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#742693}
-
Avi Drissman authored
BUG=1023913 Change-Id: I8f0364896d0cc5d4480aa293ddf38c61daea617e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036350 Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by:
ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#742692}
-
Maksim Sisov authored
When tests are initialized, some of them try to set a test input method factory. However, they fail to do so, because OzonePlatform::InitializeUi is called earlier. That method does various initialization and also sets the input method factory. Previously, we used to set the factory in CreateInputMethod method if that hasn't been set yet. (see https://crrev.com/c/1531600), but after https://crrev.com/c/1798263, that functionality was moved back to InitializeUi. We didn't run any tests with Wayland and couldn't spot this problem. However, now, I'm enabling views_unittests, and that problem was hit. Thus, to fix the issue, let the GtkUi call CreateInputMethod to give an OzonePlatform chance to set an input method. If it is not set, then use gtkui provided one. Bug: 578890 Change-Id: Ic09de5a18a1ff969e1a96977a987f09cac1129f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062974Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Maksim Sisov <msisov@igalia.com> Cr-Commit-Position: refs/heads/master@{#742691}
-
Manuel Rego Casasnovas authored
In r738875 we stopped marking ancestors if overflow recalc flags were already present, however by mistake the code was checking SelfNeedsLayoutOverflowRecalc() instead of ChildNeedsLayoutOverflowRecalc(). This improves the performance in perf_tests/shadow_dom/v1-small-deep-distribution.html. BUG=1051342,941180 Change-Id: Ie94432dd6f207b5abc20132a85ee677a7994a9d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055084Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Manuel Rego <rego@igalia.com> Cr-Commit-Position: refs/heads/master@{#742690}
-
Jordan Taylor authored
Added corresponding unit tests for new conversions. This change is needed in order to support new changes to ScrollTimeline, which needs to be able to support -infinity and infinity values. The infinity values were already covered, but -infinity values were not. https://chromium-review.googlesource.com/c/chromium/src/+/2028173 Change-Id: I634860353782cf56a560228bf37903395b400dc6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2038130Reviewed-by:
Clemens Arbesser <arbesser@google.com> Reviewed-by:
Yuri Wiitala <miu@chromium.org> Commit-Queue: Jordan Taylor <jortaylo@microsoft.com> Cr-Commit-Position: refs/heads/master@{#742689}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/526921b3db19..7e63268dc86c git log 526921b3db19..7e63268dc86c --date=short --first-parent --format='%ad %ae %s' 2020-02-19 skyostil@google.com TrackEvent: Switch from ssize_t to ptrdiff_t 2020-02-19 treehugger-gerrit@google.com Merge "traced_perf: enable by default" 2020-02-19 lalitm@google.com Merge "tp: add support for dynamic tables and migrate flamegraph/counter dur" 2020-02-19 lalitm@google.com tp: fix parsing of counter events from Chromium 2020-02-19 treehugger-gerrit@google.com Merge "Improve logging on session creation" 2020-02-19 ilkos@google.com Merge "Normalize special symbols" 2020-02-19 skyostil@google.com Merge "TrackEvent: Fix missing include for 'ssize_t'" 2020-02-19 treehugger-gerrit@google.com Merge "TrackEvent: Fix namespace confusion with trace point" 2020-02-18 ilkos@google.com Merge "Support java.lang.Class remapping" 2020-02-18 treehugger-gerrit@google.com Merge "Add PERFETTO_EXPORT annotations" 2020-02-18 treehugger-gerrit@google.com Merge "TrackEvent: Fix warning about missing braces around std::array initializer." 2020-02-18 treehugger-gerrit@google.com Merge "Expose bytes written to TraceWriter to client API." 2020-02-18 treehugger-gerrit@google.com Merge "Improve logging if creating ftrace fails." 2020-02-18 treehugger-gerrit@google.com Merge "TrackEvent: Add category tags and groups" 2020-02-18 treehugger-gerrit@google.com Merge "Do not log /proc/self/page_idle error in client." 2020-02-18 ddrone@google.com Merge "Parse all fields in ChromeLatencyInfo message" 2020-02-18 taylori@google.com perfetto-ui: Processes with heap profiles first 2020-02-18 treehugger-gerrit@google.com Merge "traced_perf: basic metatracing" Created with: gclient setdep -r src/third_party/perfetto@7e63268dc86c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:149198396,chromium:149804989 Tbr: perfetto-bugs@google.com Change-Id: If992fbacdb68dd8293a4c758391bf9f4949bce63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2064348Reviewed-by:
-
Nico Weber authored
Looks like it's no longer needed. Change-Id: Idbf3d5a8fbd4f75c2c0f7c998e2617b8542dfb5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062296 Commit-Queue: Robert Sesek <rsesek@chromium.org> Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#742687}
-
Sami Kyostila authored
When posting tasks with base::PostDelayedTask(), explicitly specify whether the tasks should run on the thread pool on a specific named thread. This is in preparation for making it always mandatory to specify the destination for posted tasks. This patch has no functional changes. This CL was uploaded by git cl split. Bug: 968047 Change-Id: I74434ddac6214f954b040adb8eec904549fc725f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062338 Commit-Queue: Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Cr-Commit-Position: refs/heads/master@{#742686}
-
Elly Fong-Jones authored
This is a speculative fix, waiting for me to figure out how to trybot it :) Change-Id: Ibc74b5cb94eff639abe8c4032fda1714445a69b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062678 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#742685}
-
kjd564 authored
Prevent sync XHR from being fired in a child frame when the unload handler was attached from a parent document. As of M80, sync XHR during page dismissal is not allowed by default. However, it was still possible to send a sync XHR request during dismissal by attaching an unload handler defined in the parent document to a child frame from the parent's script. This change prevents that from happening. (Note: It is still possible to schedule a sync XHR during a page dismissal, ie doing a SetTimeout in a beforeUnload handler that will do the synchronous XHR.) This change also removes some use counters that are no longer needed. Bug: 1044348 Change-Id: Ieab8fd018d61aecc75241c6d7d01ad6c08eff7da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032426 Commit-Queue: Katie Dillon <kdillon@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/master@{#742684}
-
Alex Chau authored
Bug: 1037793 Change-Id: Iee42f82af527875c936310764f323942c8f97023 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062983Reviewed-by:
Richard Knoll <knollr@chromium.org> Commit-Queue: Alex Chau <alexchau@chromium.org> Cr-Commit-Position: refs/heads/master@{#742683}
-
Christian Dullweber authored
Log these UserActions from the controller, so they get logged on Android as well. Bug: 1040091 Change-Id: I2f938d54c376b88d020e2a576d7dd2348c1b64ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063130Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Christian Dullweber <dullweber@chromium.org> Auto-Submit: Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#742682}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/ac15544d..07a0ee92 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ie6e6d5676b43dcda141cc4d0b8aad6fd9f173f78 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063453Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#742681}
-
Anatoliy Potapchuk authored
Currently, there are a few kiosk tests which are failing when we most probably get to STATUS_ERROR of KioskAppData. Let's add a log line which will indicate whether it's a fake cws issue. Bug: 1044417 Change-Id: I685d10c7cab773d3b7ee5a9f2d426ef2eea8da59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062444Reviewed-by:
Sergey Poromov <poromov@chromium.org> Commit-Queue: Anatoliy Potapchuk <apotapchuk@chromium.org> Cr-Commit-Position: refs/heads/master@{#742680}
-
Wez authored
Allow an optional RepeatingCallback<std::string()> to be supplied to ScopedRunLoopTimeout, to provide an additional message string in case of timeout. Update base::test::TaskEnvironment to have DescribeAllPendingTasks' output appending to the timeout message. Bug: 1021777 Change-Id: I32ff686924aea50cc56b6f103696bdbde7e8d8fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062984 Auto-Submit: Wez <wez@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#742679}
-
Robert Sesek authored
Bug: 710376 Change-Id: I0c28c2cfbc6a034bbe41d68b6b1e021408365ff7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062339Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#742678}
-
Ken Rockot authored
This wipes out obsolete references to Service Manager in service-related documentation and replaces it with simpler docs reflecting the new service model. Bug: None Change-Id: Iab5662bcc48b34954a9003532cd407058e470282 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063773 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#742677}
-
Rahul Arakeri authored
This CL gets rid of InputHandlerProxy::RouteToTypeSpecificHandler and instead, uses InputHandlerProxy::HandleInputEventWithLatencyInfo so that events get injected at an interface level. Bug: 1041898 Change-Id: Id371e9fb544ea5906bd09fe4b66e3d2a261adc8d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2001288Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Rahul Arakeri <arakeri@microsoft.com> Cr-Commit-Position: refs/heads/master@{#742676}
-
Andreas Haas authored
With the recent ArrayBuffer refactoring, the backing store memory is announced to the GC when it gets wrapped by a JSArrayBuffer object. The assumption is that backing store memory is always wrapped by a JSArrayBuffer object. However, the bug report shows one example where this is not the case. When an ArrayBuffer is post-messsaged to a Worker but the Worker never takes the ArrayBuffer out of the message, then the backing store memory becomes dead before it ever gets wrapped by a JSArrayBuffer object. Therefore the GC does not know about the memory used by the backing store and does not trigger garbage collection. With this CL the MessageEvent now announces the backing store memory to the GC. With that, garbage collection is triggered, and the backing store memory is collected as expected. R=haraken@chromium.org Bug: chromium:1049005 Change-Id: I517f65a4cb1546ae469be29514183314f62e3d42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2044272 Commit-Queue: Andreas Haas <ahaas@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#742675}
-
Rushan Suleymanov authored
This reverts commit f9a31275. Reason for revert: users must have migrated to prefs after 9 months. Clients that haven't migrated meanwhile will incur in additional data downloaded from sync servers, and may worst-case run into undeletions if they were unlikely enough to have pending local deletions. Previous patch was reverted earlier due to running into sync protocol violations. This patch also introduces cleaning up of Directory on GUID mismatch. Original change's description: > Reland "Reintroduce sync cache GUID migration logic from directory to prefs" > > This reverts commit 631967a6. > > Reason for revert: suspect of running into sync protocol violations and the corresponding DCHECK failures. > > Original change's description: > > Revert "Reintroduce sync cache GUID migration logic from directory to prefs" > > > > This reverts commit 37ca67ee with > > various non-trivial updates to the patch due to git conflicts as well > > as logic having evolved meanwhile. > > > > Reason for revert: users must have migrated to prefs after 9 months. > > Clients that haven't migrated meanwhile will incur in additional data > > downloaded from sync servers, and may worst-case run into undeletions if > > they were unlikely enough to have pending local deletions. > > > > Original change's description: > > > Reintroduce sync cache GUID migration logic from directory to prefs > > > > > > After some back and forth, we've concluded that there's too much risk > > > involved in assuming most clients have already migrated to prefs, i.e. > > > cache GUID and birthday populated. > > > > > > As middle ground, we keep considering the values in prefs the > > > authoritative ones, but if empty, we populate them from the sync > > > directory. This adds some complexity, but allows us to defer the more > > > aggressive turndown (disable migration), which in addition can now be > > > guarded behind a feature toggle. > > > > > > Bug: 923285 > > > Change-Id: I11c4814dae1810c34c1473af36ace9a1b517067f > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1609242 > > > Commit-Queue: Mikel Astiz <mastiz@chromium.org> > > > Reviewed-by: Marc Treib <treib@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#659030} > > > > Bug: 923285 > > Change-Id: I35cad35fdd398db08ee3a5cea82eaee5ebd9e980 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2022787 > > Commit-Queue: Mikel Astiz <mastiz@chromium.org> > > Reviewed-by: Marc Treib <treib@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#735486} > > TBR=treib@chromium.org,mastiz@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 923285, 1048771 > Change-Id: Ie19c4d300428d59358921e55800337fbf10f0f64 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042617 > Commit-Queue: Rushan Suleymanov <rushans@google.com> > Reviewed-by: Mikel Astiz <mastiz@chromium.org> > Cr-Commit-Position: refs/heads/master@{#739375} Bug: 923285, 1048771 Change-Id: I900235b66fd0186aece1d05eb1e99da70f2548b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2061751 Commit-Queue: Rushan Suleymanov <rushans@google.com> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#742674}
-
Jan Wilken Dörrie authored
This change implements obtaining the list of saved passwords in SavedPasswordsPresenter and makes it listen to appropriate events and notifying its observers. Bug: 1047726 Change-Id: Ic859e4f1aca19be36d6df8ef525564dc023191ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063129Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#742673}
-
Ayu Ishii authored
This change adds performance metrics previously used in the SMS Receiver API to the credential manager. It uses the same histograms to provide continuity with previous iterations of the API. It adds the following metrics. 1. Blink.Sms.Receive.TimeSuccess Time from when the API has been called to when it returns a successful outcome. 2. Blink.Sms.Receive.TimeCancel Time from when the API has been called to when the user dismisses the infobar and returns a cancelled outcome. Bug: 1045231 Change-Id: I36736e1d8c7919541cb91e23154d142e957d9975 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055891Reviewed-by:
Victor Costan <pwnall@chromium.org> Commit-Queue: Ayu Ishii <ayui@chromium.org> Cr-Commit-Position: refs/heads/master@{#742672}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 3d601f27. With Chromium commits locally applied on WPT: ec83d167 "Update performance.measureMemory to the latest proposal" d5cd6b98 "SharedWorker: Assign unique names to SharedWorkers to avoid unintentional matching" 48b21f05 "Remove `tentative` flag from Fetch Metadata tests." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: mkwst@chromium.org, andypaicu@chromium.org: external/wpt/content-security-policy NOAUTOREVERT=true TBR=lpz No-Export: true Change-Id: I14b91a1dc5a26e6cdffd3d78f12cbcbf305cf61b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063073Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#742671}
-
Maksim Sisov authored
Video playback is broken in Ozone/Wayland whenever Wayland compositor announces that R_8 buffer is supported and sends supported format modifiers for that buffer type. Then, when video is played, GbmPixmapWayland is created with format modifiers supplied by Wayland compositor. However, this result in a video playback that is garbled. The reason to this is that the buffer is requested to be linear, which means no format modifiers should be supplied. I believe it could be the gbm handling that, but it turns out that messes up and we have weird behaviour. Thus, do not use format modifiers if the buffer usage is linear. Bug: 1050364 Change-Id: I980c462f857b3a462f95677810e3ff2aaaf340c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2049978Reviewed-by:
Michael Spang <spang@chromium.org> Reviewed-by:
-
David Van Cleve authored
This is a minimal change adding a struct representing a Trust Tokens key commitment registry's contents [1], with some slight variations described in the Trust Tokens design doc (currently internal-only; working to release a public version). This is a common ancestor CL of trust token issuance, redemption, and key commitment fetching and parsing. [1]: https://github.com/alxdavids/draft-privacy-pass/blob/master/draft-privacy-pass.md#key-registration-registry Bug: 1042962 Change-Id: Ic0a20cb266c8133bb3545821b975e813bfb59c50 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062674 Commit-Queue: David Van Cleve <davidvc@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#742669}
-
Sorin Jianu authored
This CL allows the update_client to persist some component metadata in prefs during Component::StateUpdated. New functions were added to update_client::PersistedData to provide access to these persisted members. The persisted data is not used in any Chrome component updater execution flows but the data is going be used by //chrome/updater to query the version of CRXs installed by update client. Bug: 1052164 Change-Id: I48c62e9dea12ec8a68d7ad003d3651b90df7b26e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063148Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#742668}
-
Avi Drissman authored
BUG=1023913 Change-Id: I218a549768b8c9929d8857be6356ed09fcfecfaa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032078 Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Cr-Commit-Position: refs/heads/master@{#742667}
-
Alexei Svitkine authored
Pointing at the other bug was confusing, because it's state was unclear about next steps. Bug: 1053702 Change-Id: Ia885dc21f028aabe150d55e74d927f3a37c8a371 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063331 Auto-Submit: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#742666}
-
Alex Lau authored
https://chromium.googlesource.com/chromiumos/platform2/system_api.git/+log/8bece5273c7d..c22aa6b47ff6 $ git log 8bece5273..c22aa6b47 --date=short --no-merges --format='%ad %ae %s' 2020-01-23 alexlau vm_tools: concierge: vm suspend/resume via D-Bus messages 2020-02-07 garrick system_api: Fix patchpanel cid types Created with: roll-dep src/third_party/cros_system_api Bug: b:140083246 Change-Id: I6d6463ead4d715548cfc565ef116cfbf23fa8cda Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063566 Auto-Submit: Alex Lau <alexlau@chromium.org> Commit-Queue: Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Cr-Commit-Position: refs/heads/master@{#742665}
-
Sami Kyostila authored
When posting tasks with base::PostDelayedTask(), explicitly specify whether the tasks should run on the thread pool on a specific named thread. This is in preparation for making it always mandatory to specify the destination for posted tasks. This patch has no functional changes (aside from ui_controller_android.cc). This CL was uploaded by git cl split. Bug: 968047 Change-Id: If74592ccdd999f3271b3228ab1f784d0c606b5a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062414 Commit-Queue: Sami Kyöstilä <skyostil@chromium.org> Auto-Submit: Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#742664}
-
Yi Gu authored
Clear the animating scroll snap targets in LayerTreeHostImpl whenever we update the animation target. This ensures that we attempt to snap to an actual snap position once the animation finishes. Bug: 1035953 Change-Id: Ieb2b8d04d6a6f795124770a599373a21c9d61989 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1976826 Commit-Queue: Yi Gu <yigu@chromium.org> Reviewed-by:
Majid Valipour <majidvp@chromium.org> Cr-Commit-Position: refs/heads/master@{#742663}
-
John Abd-El-Malek authored
This applies to frame and subresource requests from the CCT tab. It'll also apply to tabs created from it, e.g. using target="_blank". It is not applied for requests from service or shared workers, since these aren't per tab. Bug: 1040143 Change-Id: Ia06e24e2dff5ad6c5c36f5382fc87a4403890e4e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2046526 Commit-Queue: Clark DuVall <cduvall@chromium.org> Auto-Submit: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Clark DuVall <cduvall@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Cr-Commit-Position: refs/heads/master@{#742662}
-
Liquan (Max) Gu authored
This reverts commit f0990340. Reason for revert: the added test is flaky Original change's description: > [ExpandablePaymentHandler] Add tests: request.abort() > > Context: > This CL adds a test for payment abortion. The test calls request.abort() > from the merchant side. > > Expectation: > The test expects that the request.show() promise would be rejected with > the reason written in the exception message. > > Bug: 1042892 > > Change-Id: Ib764ad689a6b114a45e86d8351086c9a4519fbfe > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2040440 > Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> > Reviewed-by: Liquan (Max) Gu <maxlg@chromium.org> > Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#741551} TBR=rouslan@chromium.org,maxlg@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1042892, 1053877 Change-Id: I4332ba329a13f54aad5b36096b21971df523e95b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063664 Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
Liquan (Max) Gu <maxlg@chromium.org> Cr-Commit-Position: refs/heads/master@{#742661}
-
Dave Tapuska authored
Add a WidgetBase which will eventually be the owner of the compositing machinery. For now it holds onto objects passed in from RenderWidget. There was indirection of going via the WebWidgetClient to LayerTreeHost indirectly. blink depends on cc and can call APIs on LayerTreeHost so do just that. See design doc: https://docs.google.com/document/d/10uBnSWBaitGsaROOYO155Wb83rjOPtrgrGTrQ_pcssY/edit?ts=5e3b26f7 Change-Id: I1cd4119fc3275cfcfcf8c5806d82c1745efa4c14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015784 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
-
Peter Kasting authored
Wanted to minimize the amount of manual change in the clang-format patch itself. Bug: 1053845 Change-Id: I893c61571967f50d2d8a141caf72ac953000d1d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063899 Auto-Submit: Peter Kasting <pkasting@chromium.org> Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org> Reviewed-by:
Thomas Lukaszewicz <tluk@chromium.org> Cr-Commit-Position: refs/heads/master@{#742659}
-
Peter Kotwicz authored
This CL introduces ToolbarColors#canUseIncognitoToolbarThemeColorInOverview() which determines whether the incognito theme color can be used in overview mode. The purpose is to share code between AppThemeColorProvider#updateTheme() and StatusBarColorController#calculateBaseStatusBarColor() BUG=None Change-Id: I671a40084f670655a39395fa365bb1b64d8fec52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063872Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Cr-Commit-Position: refs/heads/master@{#742658}
-
Miyoung Shin authored
This is a precursor CL to replace ExternalPopupMenu class by a mojo connection, and replace blink::WebTextDirection with base::i18n::TextDirection. Bug: 1044268 Change-Id: Ie6bc0879b7afde81cb565afa513eacb270dab169 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2060208 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
-
