- 05 Mar, 2019 40 commits
-
-
Giovanni Ortuño Urquidi authored
AppRegistrar should be used by clients to query information about apps. For example, if an app is installed. AppRegistrar has two implementations BookmarkAppRegistrar and WebAppRegistrar. BookmarkAppRegistrar is built on top of extensions. PendingBookmarkApp uses BookmarkAppRegistrar to avoid querying the ExtensionRegistry and ExtensionPrefs directly. Bug: 916381 Change-Id: I0706bef37f2ecbf4b86d63eafe8de1dd168f440a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1498736 Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#637598}
-
Dan Beam authored
R=dpapad@chromium.org BUG=930042 Change-Id: Ic20ceb781e363b033a56fbd541dabecd52f2158f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1497541Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Auto-Submit: Dan Beam <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#637597}
-
Dan Beam authored
Screenshot: https://imgur.com/a/inurhXK R=dpapad@chromium.org BUG=926658 Change-Id: I26bca3932d0e92dad7d6c3cbfab35fe543e022f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1501992 Commit-Queue: Dan Beam <dbeam@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Auto-Submit: Dan Beam <dbeam@chromium.org> Reviewed-by:
-
Lei Zhang authored
As is, by the time PrintViewManager::PrintPreviewDone() gets called to unblock a Print Preview initiator, FocusController already tried to give the initiator focus and failed, because the initiator was in a blocked state. Add PrintViewManager::PrintPreviewAlmostDone() and call it right before the Print Preview dialog closes. This is necessary to get the timing right so the underlying Print Preview initiator can be unblocked before the FocusController tries to give it back focus. BUG=936542 TEST=Manual, see bug. Change-Id: Ifa7fcb451b94a6da82c554b685bca350be032120 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1497860 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#637595}
-
Darren Shen authored
There was a flaky failure in compiling components/subresource_filter/content/browser/subresource_filter_client.h See: https://ci.chromium.org/p/chromium/builders/ci/win32-rel/12234 Error message was that it couldn't find: components/subresource_filter/core/mojom/subresource_filter.mojom.h Speculatively fixing this issue by adding the mojom file to DEPS. TBR=sky@chromium.org Change-Id: I72668d5e8d12af8d6cb32fae4b8258c4b1b62bd2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1502332Reviewed-by:
Darren Shen <shend@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#637594}
-
Kyle Milka authored
If a customize background dialog is opened and the space key is pressed the main page shouldn't scroll. If the mouse is used to scroll the page the dialog should stay centered while the page scrolls in the background (this is consistent with the custom links dialogs). Screencast: http://go/scrcast/NTY3MzY0NjkyODQyOTA1Nnw1MzY0N2JhNS1hZA Bug: 908381, 899730 Change-Id: I71e99f6d4481c9e61d3f98d0ff23f4d059a21464 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1501934Reviewed-by:
Kristi Park <kristipark@chromium.org> Commit-Queue: Kyle Milka <kmilka@chromium.org> Cr-Commit-Position: refs/heads/master@{#637593}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/232c456db8e9..d69cdaba1445 git log 232c456db8e9..d69cdaba1445 --date=short --no-merges --format='%ad %ae %s' 2019-03-05 loganchien@google.com Add -Wno-implicit-fallthrough Created with: gclient setdep -r src/third_party/swiftshader@d69cdaba1445 The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:b/115344057 TBR=swiftshader-team+autoroll@chromium.org Change-Id: I1c5fdee380ff778b376bb09d4ba8e052b0ff00e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1502095Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#637592}
-
Shao-Chuan Lee authored
In case of a crash, metrics from previous session is not available when generating initial stability logs, which is probably why aggregated crash counts on UMA don't have ARC state associated. This patch introduces StabilityMetricsManager, which persists stability metrics into local state and record value from local state to UMA when needed. Bug: 929583 Change-Id: I747493f2462454baa7fc187421932ea71d52c9a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1469810 Commit-Queue: Shao-Chuan Lee <shaochuan@chromium.org> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Yury Khmel <khmel@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#637591}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/5610d5a7e96a..6dacdbca1d6e Created with: gclient setdep -r src-internal@6dacdbca1d6e The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=yigu@chromium.org,peria@chromium.org,dgrogan@chromium.org,treib@chromium.org Change-Id: I8bf02633bad98c62a7cd3fdb2342517d505b330a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1502092Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#637590}
-
Shu Chen authored
This cl doesn't change any behaviors. Bug: 937167 Change-Id: I35be2c76784d38c651f0e3d21a12e07a96b5e1af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1498253 Commit-Queue: Shu Chen <shuchen@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#637589}
-
Dan Beam authored
<extension-code-section> is used from 2 places in extensions (AFAICT), when showing where runtime errors come from and when showing errors trying to load an extension (i.e. manifest errors). This CL should confine "light mode" to just the actual code parts, and show the load errors in dark mode. Screenshots: https://imgur.com/a/gF1gd5D R=dpapad@chromium.org BUG=936524 Change-Id: I99b9cc56df1712c04023206a493a883d42d6fb8c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1497804 Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
-
Simon Que authored
R=dpranke@chromium.org, hinoka@chromium.org, jbudorick@chromium.org Bug: 915568 Change-Id: I34e1cd438423e614db0652ff3c17f0832e8a6a82 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1500714Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Simon Que <sque@chromium.org> Cr-Commit-Position: refs/heads/master@{#637587}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/b36f7a25a8a4..b8cff9e9347c git log b36f7a25a8a4..b8cff9e9347c --date=short --no-merges --format='%ad %ae %s' 2019-03-05 jiajia.qin@intel.com ES31: Add MAX_COMPUTE_SHARED_MEMORY_SIZE Created with: gclient setdep -r src/third_party/angle@b8cff9e9347c The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Change-Id: I8e8805b73514e6ca255591b1cd09390bdd987d25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1502094Reviewed-by:
-
Jérôme Lebel authored
For some reasons, those metrics were not implemented for sign-in before unity. + Signin_Signin_WithDefaultSyncSettings + Signin_Signin_WithAdvancedSyncSettings This patch adds implementations for those 2 metrics for pre-unity and unity code. Also "Signin_Undo_Signin" is added for unity code (already implemented) with pre-unity. Bug: 937820 Change-Id: I27ec9769e9954b1daeccd273f4d663c35f9fa605 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1496981Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#637585}
-
rbpotter authored
Only use color and duplex setByPolicy on Chrome OS, since these policies aren't implemented on other platforms. To make this simpler, move logic for computing whether any setting on the page is managed out of header.js and into model.js. This is also more reasonable since model.js is responsible for tracking the settings and is the only element where settings' |setByPolicy| field is updated. Change-Id: Ie682c38ffd775cccc4f47c15b66fa85a46761e20 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1500785Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#637584}
-
Donna Wu authored
Bug: 716628 Change-Id: If48a9b1aaa71a9264475dd0ad62707a45bd927e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1493716Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/4f63c40831f1..525c349dbfeb git log 4f63c40831f1..525c349dbfeb --date=short --no-merges --format='%ad %ae %s' 2019-03-05 dhanyaganesh@chromium.org BuildStore: Unittest for GetSlaveStatuses 2019-03-05 dhanyaganesh@chromium.org BuildStore: Redirect InsertBuildMessage & GetBuildMessages Created with: gclient setdep -r src/third_party/chromite@525c349dbfeb The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@chromium.org Change-Id: I01f56858d30011112969e431a5dfaf6376dd651d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1501854Reviewed-by:
-
Dan Beam authored
No screenshots cuz I can't easily reproduce. And yes, this will mildly change the "light mode" (GB 500->700) but I think it's pretty clear that this UI is emulating a link and therefore should use the standard link colors. R=hcarmona@chromium.org BUG=926658 Change-Id: I6b9cc4697239edea6a165108935acb7ad2e07bff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1501795 Commit-Queue: Dan Beam <dbeam@chromium.org> Commit-Queue: Hector Carmona <hcarmona@chromium.org> Auto-Submit: Dan Beam <dbeam@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/5800f2e8a920..fbc887df72ec git log 5800f2e8a920..fbc887df72ec --date=short --no-merges --format='%ad %ae %s' 2019-03-05 reed@google.com Revert "Remove (unnecessary?) flush in RenderYUVAToRGBA" 2019-03-04 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2019-03-04 halcanary@google.com SkQP: fix five tests 2019-03-04 robertphillips@google.com Reduce usage of SkCanvas::flush 2019-03-04 fmalita@chromium.org Fix handling of SkSL nullable FPs 2019-03-04 mtklein@google.com mark lowp TODOs 2019-03-04 brianosman@google.com Add SkParticleValue to allow further customization of curve behavior 2019-03-04 herb@google.com Introduce SkStrikeCacheInterface 2019-03-04 egdaniel@google.com Add API for creating SkImage from AHB while uploading data to it. 2019-03-04 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 4d153383bd3a..0e1ce2e55387 (1 commits) 2019-03-04 robertphillips@google.com Clean up GrSurfaceContext's relationship with GrRecordingContext 2019-03-04 mtklein@google.com add kRGBA_F16Norm_SkColorType 2019-03-04 robertphillips@google.com Remove (unnecessary?) flush in RenderYUVAToRGBA 2019-03-04 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src aae499d4..8e3cddfd (217 commits) 2019-03-04 halcanary@google.com SkQP: fix androidx (follows 2ccdd2bc1d0) 2019-03-04 robertphillips@google.com Remove peekProxy's side-effect behavior 2019-03-04 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 823ca85404fb..bb305299f4de (1 commits) 2019-03-04 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update go_deps asset 2019-03-04 recipe-roller@chromium.org Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/skia@fbc887df72ec The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=reed@chromium.org Change-Id: Iefa4920baa09e09884108378028aaeefd39a7174 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1502093Reviewed-by:
-
Kent Tamura authored
SECURITY_OWNERS should not be necessary to approve web_feature.mojom, but //PRESUBMIT.py asks to specify SECURITY_OWNERS for *.mojom. This CL adds per-file lines for web_features.mojom. Bug: 919393 Change-Id: Id2c99de603f13ee0cfd5c91ad40de93d4dba4b17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1501195Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#637579}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=cmasso@chromium.org Change-Id: Ifc01a9d734470021084260cefcbf545dbf763d54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1502213Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#637578}
-
Antonio Gomes authored
R=haraken@chromium.org CC=blink-reviews-vendor@chromium.org BUG=891908 Change-Id: I044f26b4cb2d2e0ae7ee0e1d55518765cdb34864 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1500972Reviewed-by:
-
Miyoung Shin authored
- short/int16_t -> uint16_t considering importing the value from web_bluetooth.mojom and exporting the value through bluetooth_advertising_event.idl. - Reference: https://google.github.io/styleguide/cppguide.html#Integer_Types Bug: 929985 Change-Id: Ib910dce00f0382fa7688547583d9c09d65272e5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1501772Reviewed-by:
-
Miyoung Shin authored
- short -> int16_t - No logic changes. - Reference: https://google.github.io/styleguide/cppguide.html#Integer_Types Bug: 929985 Change-Id: I6b22716e77ad858152a3255eb52204bb35a985ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1501237Reviewed-by:
-
Nektarios Paisios authored
Line break elements are not defined as text nodes in Blink. However, traditionally we have been able to set a selection before or after a line break and our accessibility code on the browser side treats objects with the line break role as text objects. These tests ensure that line break elements are not treated as text objects for selection purposes. Also, adds more selection tests for text fields. R=dmazzoni@chromium.org, dtseng@chromium.org, aleventhal@chromium.org Change-Id: I4cf968225322a9bbc4eb2ace4b80c07dffc5a801 Bug: 639340 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1498611Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Commit-Queue: Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#637574}
-
Hector Carmona authored
Bug: 936624 Change-Id: Ifa7b57212f6de0346b5523ed6795f65d21b6e12d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1493374 Commit-Queue: Hector Carmona <hcarmona@chromium.org> Reviewed-by:
-
Malay Keshav authored
This patch adds an API to ui::Layers that lets clients set a rounded corner radius on the layer. The change is propagated to the cc layer and its effect node as well. Adds unit test for the change. Bug: 903486 Change-Id: Ib0d36af9e76b9f6701e0cb674e855e29f5844c7f Component: ui layer, cc layer, effect node Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1497851 Commit-Queue: Malay Keshav <malaykeshav@chromium.org> Reviewed-by:
enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#637572}
-
Michael Moss authored
This reverts commit ad0f43e7. Reason for revert: breaking youtube, crbug/937702 Original change's description: > Remove Shadow DOM V0, Custom Element V0 and HTML Imports > > This patch removes Shadow DOM V0, Custom Element V0 (CEv0) and HTML Imports. > Intent to Deprecate and Remove: http://bit.ly/2RGHe3x > > Bug: 911943 > Change-Id: I1baa906e019e0f59331c1fb590eccbc38a482fec > Reviewed-on: https://chromium-review.googlesource.com/c/1481130 > Reviewed-by: Hayato Ito <hayato@chromium.org> > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Reviewed-by: Kent Tamura <tkent@chromium.org> > Commit-Queue: Yoichi Osato <yoichio@chromium.org> > Cr-Commit-Position: refs/heads/master@{#636728} TBR=kinuko@chromium.org,hayato@chromium.org,tkent@chromium.org,yoichio@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 911943, 937702 Change-Id: I4aa4e34f3846ee8b5c2e19b29905243e0db5319a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1501935 Commit-Queue: Michael Moss <mmoss@chromium.org> Reviewed-by:
Michael Moss <mmoss@chromium.org> Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Cr-Commit-Position: refs/heads/master@{#637571}
-
Dan Beam authored
R=aee@chromium.org BUG=833049 Change-Id: I51412d06bf6ed61ba6afc35d6166d15754cb603d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1501575 Commit-Queue: Dan Beam <dbeam@chromium.org> Auto-Submit: Dan Beam <dbeam@chromium.org> Reviewed-by:
Esmael El-Moslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#637570}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/cf661acb705f..adbf3bef6872 git log cf661acb705f..adbf3bef6872 --date=short --no-merges --format='%ad %ae %s' 2019-03-04 recipe-roller@chromium.org Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@adbf3bef6872 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: I2a228a26f05b2078e1c4e5df9026457016527255 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1501974Reviewed-by:
-
chrome-search://ntpiconKristi Park authored
Limit max icon size to 192dp and scale factor to the maximum device scale factor. Bug: 932774 Change-Id: Ia03d50a8530fa32292e6591ab75b6131ba2ed986 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1497655 Commit-Queue: Kristi Park <kristipark@chromium.org> Reviewed-by:
Mathieu Perreault <mathp@chromium.org> Cr-Commit-Position: refs/heads/master@{#637568}
-
Alexey Baskakov authored
Create SetCrxInstallerFactory test-only method which enables tests to inject a CrxInstaller mock. This change will allow us to support parallel installs (see next CLs). Bug: 915043 Change-Id: I2872a815e1d6255488e4c0af182f26f776b042aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1498259Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Commit-Queue: Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#637567}
-
Ashitha Santhosh authored
Added ProduceRGBEmulationGLTexture function that creates a new texture and binds the existing GL image with this texture as per the specified internal format. This will be used for RGB emulation on Mac for WebGL blitFramebuffer. Bug: 924198 Change-Id: I5c3267015c411803dbacc828d3536448f6bba1a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1484859 Commit-Queue: Ashitha Santhosh <ashithasantosh@google.com> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#637566}
-
Shu Chen authored
Bug: 937001 Change-Id: If0026c566270327f5b7d90ffa311d90a6e0bfa4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1498252Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Shu Chen <shuchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#637565}
-
Pavel Feldman authored
The only reason it was there was for the trace, where it was misinterpreted. Change-Id: If1fe338516ecc1a72984ab7ec16cd3fb58cd779b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1495870 Commit-Queue: Pavel Feldman <pfeldman@chromium.org> Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#637564}
-
Jamie Walch authored
Currently these messages are suppressed for @google.com addresses, but we'll want to start showing them soon. This CL lets us control that via gstatic, rather than requiring a webapp update. Change-Id: Ifca5fa9058510f54eacb80ca74c461a79192822f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1501533Reviewed-by:
Joe Downing <joedow@chromium.org> Commit-Queue: Jamie Walch <jamiewalch@chromium.org> Cr-Commit-Position: refs/heads/master@{#637563}
-
Yoshisato Yanagisawa authored
We seem not add iOS and ChromeOS builders to cr-buildbucket.cfg. I suppose that might be the reason why we did not see any updates for the builders in milo. Let me try to add them. Bug: 874754 Change-Id: I72969147d3199cffad4c543cd88f7693bacd26c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1501632 Auto-Submit: Yoshisato Yanagisawa <yyanagisawa@chromium.org> Commit-Queue: Fumitoshi Ukai <ukai@chromium.org> Reviewed-by:
Fumitoshi Ukai <ukai@chromium.org> Cr-Commit-Position: refs/heads/master@{#637562}
-
Yi Gu authored
Dashboard: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=unit_tests&tests=UserActivityManagerTest.MultiBrowsersAndTabs TBR=pdyson@chromium.org Bug: 938141 Change-Id: Ib127d62d026ce05d7528921f2d4f574cdd571f83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1502073Reviewed-by:
Yi Gu <yigu@chromium.org> Reviewed-by:
Dan Erat <derat@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#637561}
-
Johannes Henkel authored
In Values_cpp.template, always check for the empty string first. This covers WTF::String::IsNull, for which the other routines may not work so well. Change-Id: I44ede6ca51970fca3f1d1320fb427a64fbd47b18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1501536 Commit-Queue: Johannes Henkel <johannes@chromium.org> Reviewed-by:
-
kyle Ju authored
Currently all Webdriver test failures are expected failures until the two-way sync with upstream github is created. The bug is caused by the fact that expected != actual in the output Json output while the is_unexpected (by default when this field is not set) field is false. Comparing patch 9 where two fields are equal and the webdrvier test suit didn't retry when green, to patch 10 where two fields are not equal and webdriver test suits retried, I conclude that this is the cause of the bug for 929689 and 936557 Bug: 929689, 936557 Change-Id: Iee0da2344ef1a6feff3ccde4746810f3c5ec8b76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1490897Reviewed-by:
Robert Ma <robertma@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Kyle Ju <kyleju@chromium.org> Cr-Commit-Position: refs/heads/master@{#637559}
-
