- 01 Feb, 2018 40 commits
-
-
Michael Thiessen authored
Allows VR to be entered without any tab (in which case you'll just see a page with a grey background, but can still interact with omnibox). This allows us to stay in VR when the renderer crashes and leaves us without a Tab. I had to special case overview mode and NTP so that we don't enter VR when those are visible as we don't support them yet. I also had to fix an issue where the progress bar would get re-shown transitioning from no tab to tab. Bug: 770380 Change-Id: Icd267aa0fa28b52cad03fac8f80c17091680b41f Reviewed-on: https://chromium-review.googlesource.com/896030Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Yash Malik <ymalik@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#533727}
-
Steven Bennetts authored
These strings were not being loaded for the details dialog which also uses them. Bug: none Change-Id: I0ed1753b96461fc09e45e1df6ab665dae8bd3cb7 Reviewed-on: https://chromium-review.googlesource.com/897914Reviewed-by:
Toni Barzic <tbarzic@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#533726}
-
Tommy Steimel authored
This reverts commit 75edf20e. Reason for revert: inspector-protocol/heap-profiler/heap-snapshot-with-iframe.js is failing on Mac bots. Example: https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Mac10.12/10410 diff from failure: https://isolateserver.appspot.com/browse?namespace=default-gzip&digest=c317416b36978b21d32382d0c64469a05a334287&as=heap-snapshot-with-iframe-diff.txt Original change's description: > Capture all DOM nodes reachable from V8 in heap snapshot. > > This patch uses the new EmbedderGraph API to provide the heap snapshot > generator with all DOM nodes and references reachable from V8. > > Bug: 749490 > Change-Id: I26750a8b80dab4f88508e504b431d976a598c6c3 > Reviewed-on: https://chromium-review.googlesource.com/890260 > Commit-Queue: Ulan Degenbaev <ulan@chromium.org> > Reviewed-by: Alexei Filippov <alph@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Michael Lippautz <mlippautz@chromium.org> > Cr-Commit-Position: refs/heads/master@{#533664} TBR=dcheng@chromium.org,ulan@chromium.org,alph@chromium.org,haraken@chromium.org,mlippautz@chromium.org Change-Id: I8fc35e1c2638bb8ef77b3b19053a7bcbe74a347a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 749490 Reviewed-on: https://chromium-review.googlesource.com/896686Reviewed-by:
Tommy Steimel <steimel@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#533725}
-
Weidong Guo authored
Changes: Add four animations to transit from the closed folder item icon to the opened folder view: 1. Background animation: This is a slide animation which transits from the rounded background of the folder item's icon to the folder's background when opening the folder. 2. Folder item title animation: This is a slide animtion which changes the opacity of the folder item's title. 3. Top icon animation: A group of layer animations to transit from the items within the folder item icon to the same items in the opened folder. 4. Contents container animation: A layer animation to transit from the bounds of the folder item icon to the opened folder's bounds and transit opacity from 0 to 1. Specs: https://drive.google.com/file/d/1-qeCz6YEzQPRUKWDAI1HXdL4bKag2Q_G/view 2500 ms duration video demo: https://drive.google.com/file/d/1Q-3s9dl1bT0xSzpzbENCX4vyD0Ud2eqG/view?usp=sharing 250 ms duration video demo: https://drive.google.com/file/d/1vXkOCaDKoQEvKpyLXnJO79OKAyo-E7m6/view?usp=sharing BUG: 796632 Change-Id: I00aa09dbb65f10c6611aad89194b2f8310b0ece7 Reviewed-on: https://chromium-review.googlesource.com/890019 Commit-Queue: Weidong Guo <weidongg@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#533724}
-
Xianzhu Wang authored
When a subframe initiates printing, all coordinates should be in the subframe's space, so we should not map anchors to the root frame. Bug: 808057 Change-Id: I8714cfaddc1bd5471da2561f69ef92994d57c559 Reviewed-on: https://chromium-review.googlesource.com/894464 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#533723}
-
Sylvain Defresne authored
The target //ios/chrome/browser/upgrade:unit_tests was never added to ios_chrome_unittests and thus the test never ran. Fix this ommision. Bug: none Change-Id: Ib434fb73eb329dfd6ea6d7d3ccafc55b99416538 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Reviewed-on: https://chromium-review.googlesource.com/895765Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#533722}
-
https://chromium.googlesource.com/angle/angle.git/+log/8efd1268eb2e..c0db9addeaeb $ git log 8efd1268e..c0db9adde --date=short --no-merges --format='%ad %ae %s' 2018-01-29 lucferron Fix dEQP renderbuffer unspecified attachment test. 2018-01-29 lucferron Vulkan: Finish implementing caps limitations for ES 2.0 support Created with: roll-dep src/third_party/angle The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=jmadill@chromium.org Change-Id: Ie0f74a39485f857652a47946caea4db0b3f5b616 Reviewed-on: https://chromium-review.googlesource.com/897905Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#533721}
-
Mitsuru Oshima authored
Do not move the cursor if the cursor is invisible when display configuration is changed. This was to make sure that X11's cursor stays inside a display, as reconfiguring display can potentially move the cursor to outside of displays. I think this is no longer a concern, and I'll replace this with just a notification after merged to 65. This also fixes the test harness that assumes the cursor is visible by default but wasn't. BUG=773479 TEST=covered by unit test. also tested on device. Change-Id: I7debc957145318352f7ee3c858031091eb2a8e56 Reviewed-on: https://chromium-review.googlesource.com/890056 Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#533720}
-
clamy authored
This CL introduces a mojo method to send renderer debug URLS to the renderer for handling, instead of using CommitNavigation. This allows not to create a NavigationRequest nor a NavigationHandle for these URLs, which do not represent actual navigations. Bug: 784904,803859 Change-Id: Ica9b17a071d2f9faa7f43eb428b0d73424a180e9 Reviewed-on: https://chromium-review.googlesource.com/817560Reviewed-by:
Charlie Reis <creis@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: Camille Lamy <clamy@chromium.org> Cr-Commit-Position: refs/heads/master@{#533719}
-
Yutaka Hirano authored
Bug: 753658, 754918 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: Id9206b68b1b85b0db20919763e45aede88d565cc Reviewed-on: https://chromium-review.googlesource.com/892938Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#533718}
-
W. James MacLean authored
This CL removes the tooltip IPC code from BrowserPlugin and BrowserPluginGuest. This code is no longer in use since mouse events are directly routed to the guest, and no longer go through the embedder. Bug: 533069 Change-Id: I916b534d86faf81d64f855368d055f8faccaf440 Reviewed-on: https://chromium-review.googlesource.com/895192Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Commit-Queue: James MacLean <wjmaclean@chromium.org> Cr-Commit-Position: refs/heads/master@{#533717}
-
Gabriel Charette authored
This will help identify the portion of our population that is still susceptible to a poor ticks clock (last update on this is in time_win.cc and dates to 2015, not clear which data source this was based on). R=asvitkine@chromium.org Bug: 807615 Change-Id: I76627355c1357f1ad6c80ba461798facd41718b0 Reviewed-on: https://chromium-review.googlesource.com/897606 Commit-Queue: Gabriel Charette <gab@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#533716}
-
Mounir Lamouri authored
As promised during review. Bug: None Change-Id: I8d028c7fa87469a94c858600e7acb297cb7b527d Reviewed-on: https://chromium-review.googlesource.com/897605Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Commit-Queue: Mounir Lamouri (slow) <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#533715}
-
Kouhei Ueno authored
This CL: - clarifies that the map keys are sorted according to https://tools.ietf.org/html/rfc7049 section 3.9 (with errata 4409), and - add support for "byte string" keys in map. We plan to use this to encode signed exchange "Canonical CBOR". Bug: 803774, 808022 Change-Id: I336a703efe6a3910f069034086b2c84e6a81a075 Reviewed-on: https://chromium-review.googlesource.com/895227 Commit-Queue: Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#533714}
-
Maria Khomenko authored
Bug: 807807 Change-Id: Ibaff48b7c5d998da98526c10d5996b5920b199c6 Reviewed-on: https://chromium-review.googlesource.com/896632Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#533713}
-
Fredrik Söderquist authored
A 'pathLength' attribute on a <path> referenced from <textPath> will affect the starting offset on the path as computed from 'startOffset' attribute. Refactor the PathPositionMapper setup a bit so that the start offset is computed together with all the other path related state. Bug: 803127 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Id12c88580dd74db403598d2aa05ac9764ad68cdb Reviewed-on: https://chromium-review.googlesource.com/897626Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#533712}
-
Eugene Ostroukhov authored
Network panel will now preview all HTML responses. Bug: 785050 Change-Id: I79b3c22300a4f132bf1b3e4842c06f291249a09d Reviewed-on: https://chromium-review.googlesource.com/896367 Commit-Queue: Eugene Ostroukhov <eostroukhov@chromium.org> Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Cr-Commit-Position: refs/heads/master@{#533711}
-
arthursonzogni authored
With NavigationMojoResponse (or the NetworkService), the NavigationURLLoader implementation is no more the NavigationURLLoaderImpl but the NavigationURLLoaderNetworkService. Some NavigationURLLoader unittests needs to be rewritten. This CL removes: * NavigationURLLoaderTest.Basic * NavigationURLLoaderTest.RequestRedirected These two tests are not replaced. They are very basic and there are already a huge number of test doing navigation and redirects. Design doc: https://goo.gl/Rrrc7n (NavigationMojoResponse) Bug: 705744 Change-Id: I7e3926593f1ca2eafc3f8f15ed782f440cff037a Reviewed-on: https://chromium-review.googlesource.com/868212 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Cr-Commit-Position: refs/heads/master@{#533710}
-
https://webrtc.googlesource.com/src.git/+log/06c944f0353d..10d9d59db164 $ git log 06c944f03..10d9d59db --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng;master.tryserver.chromium.win:win-msvc-dbg TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I93a63343eeaf869298c892af7f5e916caa8bf5c5 Reviewed-on: https://chromium-review.googlesource.com/897906 Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#533709}
-
Louis Romero authored
Bug: none Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I85707229335f196476e3843bc944129712d5853e Reviewed-on: https://chromium-review.googlesource.com/897567Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Louis Romero <lpromero@chromium.org> Cr-Commit-Position: refs/heads/master@{#533708}
-
Christian Dullweber authored
This CL changes StoragePartition to wait for localstorage deletions to finish before calling its callback. Some extension tests can leak memory because they don't wait until StorageParitition deletions are finished. This CL adds a method to StoragePartition to check if it is done and changes extension tests to always wait for StoragePartition. Bug: 796151 Change-Id: Ica6f6ef47457eb34f82923ec6ae144f6b5b67fda Reviewed-on: https://chromium-review.googlesource.com/852234 Commit-Queue: Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Cr-Commit-Position: refs/heads/master@{#533707}
-
phweiss authored
If the admin installed a certificate that gets piped through to the Android side, the user should not be able to remove the cert in Android settings. Therefore, we set the configCredentialsDisallowed policy in clouddpc, that gets mapped to the DISALLOW_CONFIG_CREDENTIALS user restriction. Bug: b/67891423 Test: $OUT-DIR/unit_tests --gtest_filter=ArcPolicyBridgeTest.CaCertificateTest Change-Id: I7f3f349225c88c0eb4561e71bf235a081c153b16 Reviewed-on: https://chromium-review.googlesource.com/881443 Commit-Queue: Philipp Weiß <phweiss@chromium.org> Reviewed-by:
Bartosz Fabianowski <bartfab@chromium.org> Reviewed-by:
Luis Hector Chavez <lhchavez@chromium.org> Cr-Commit-Position: refs/heads/master@{#533706}
-
Bence Béky authored
The underlying bug of the three linked issues found by Clusterfuzz is that if a QUIC PUSH is received with an empty hostname, it used to be passed on to X509Certificate::VerifyHostname(), where a DCHECK() would fail. This has been fixed at https://crrev.com/c/893625 by wangyix. The current CL is adding a regression test for this. Note that it has been suggested at https://crbug.com/797825#c7 that the connection be terminated (not only the stream reset) on such a malformed input. Bug: 788537, 797825, 801811 Change-Id: I96bb1528264549ca05e64da914de3f3a70d0f7c4 Reviewed-on: https://chromium-review.googlesource.com/851194 Commit-Queue: Bence Béky <bnc@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#533705}
-
Danyao Wang authored
With WKBasedNavigationManager, after the back navigation, the URL has an extra '#' at the end as a result of the link click. LegacyNavigationManager reloads the URL on back navigation so doesn't have this problem. However, the new behavior is consistent with Safari, Firefox and Blink. Changed test to check for the content of the first link instead of looking at the URL. Bug: 807428 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ia98f5a6f69b3aa322781c4a48cf4a8bef90fad2f Reviewed-on: https://chromium-review.googlesource.com/896683 Commit-Queue: Danyao Wang <danyao@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#533704}
-
Gauthier Ambard authored
This CL adds a cancel button to stop editing the location bar. It also adds the appearance/disappearance animation. Bug: 804750 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ibb9723fe3df94e1f43b332116128518c309b817b Reviewed-on: https://chromium-review.googlesource.com/897364 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Louis Romero <lpromero@chromium.org> Cr-Commit-Position: refs/heads/master@{#533703}
-
Gauthier Ambard authored
The ContractOmnibox command was only forwarding its call to the OmniboxFocuser's cancelOmniboxEdit method. This CL removes ContractOmnibox and directly calls the OmniboxFocuser. Bug: none Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I8a18cb967e6dd114ded4bcff978ac4d3402d7cd3 Reviewed-on: https://chromium-review.googlesource.com/895532Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#533702}
-
https://skia.googlesource.com/skia.git/+log/16aa82a974f6..5f9ee7cc53d2 $ git log 16aa82a97..5f9ee7cc5 --date=short --no-merges --format='%ad %ae %s' 2018-02-01 rmistry Fixes to trigger_wait_ac_task.py Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=bungeman@chromium.org Change-Id: I061ed52c2c6711d3614f5e4a4ea7577eda7a15d9 Reviewed-on: https://chromium-review.googlesource.com/897344 Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#533701}
-
arthursonzogni authored
With NavigationMojoResponse (or the NetworkService), the NavigationURLLoader implementation is no more the NavigationURLLoaderImpl but the NavigationURLLoaderNetworkService. Some NavigationURLLoader unittests needs to be rewritten. This CL removes NavigationURLLoaderTest.LoaderDetached and adds BrowserSideNavigationBrowserTest.FetchResponseAfterNavigationURLLoaderDeleted. Design doc: https://goo.gl/Rrrc7n (NavigationMojoResponse) Bug: 705744 Change-Id: I0c133c5f464d483df187c111853031766218e7a1 Reviewed-on: https://chromium-review.googlesource.com/868136 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Cr-Commit-Position: refs/heads/master@{#533700}
-
arthursonzogni authored
With NavigationMojoResponse (or the NetworkService), the NavigationURLLoader implementation is no more the NavigationURLLoaderImpl but the NavigationURLLoaderNetworkService. Some NavigationURLLoader unittests needs to be rewritten. This CL removes NavigationURLLoaderTest.RequestBlocked and adds BrowserSideNavigationBrowserTest.RequestBlockedByResourceDispatcherHostDelegate. Design doc: https://goo.gl/Rrrc7n (NavigationMojoResponse) Bug: 705744 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I2c2788e25182d8c3302daf77557160fa57313b84 Reviewed-on: https://chromium-review.googlesource.com/867951 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#533699}
-
kylechar authored
VizMainImpl thread shutdown issues have been fixed. Enabled tests that were disabled because of that problem. Bug: 785023 Change-Id: I6dc21fabbfaacd7d0e458fb06697b03651a3f396 Reviewed-on: https://chromium-review.googlesource.com/893534 Commit-Queue: kylechar <kylechar@chromium.org> Reviewed-by:
Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#533698}
-
Matt Falkenhagen authored
These started passing after https://github.com/w3c/web-platform-tests/commit/e5febc7 was imported in r533346. TBR=shimazu Bug: 626703, 678905 Change-Id: I1525f8a34ae060db9f0fc404a60f4e5a11ddee61 Reviewed-on: https://chromium-review.googlesource.com/897073Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#533697}
-
Dave Tapuska authored
This message is only generated for sync compositor and was discarded when we weren't using the browser compositor. That makes the message useless. Seems to be left over from when viz moved its begin frame messaging. BUG=722928 Change-Id: I65fa542b937c87568e63c25faca436e6a4939365 Reviewed-on: https://chromium-review.googlesource.com/889324 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#533696}
-
arthursonzogni authored
With NavigationMojoResponse (or the NetworkService), the NavigationURLLoader implementation is no more the NavigationURLLoaderImpl but the NavigationURLLoaderNetworkService. Some NavigationURLLoader unittests needs to be rewritten. This CL removes... * NavigationURLLoaderTest.DownloadAllowed. * NavigationURLLoaderTest.DownloadDisallowed. ...and adds: * BrowserSideNavigationDownloadBrowserTest.AllowedResourceDownloaded * BrowserSideNavigationDownloadBrowserTest.AllowedResourceNotDownloaded * BrowserSideNavigationDownloadBrowserTest.Disallowed Design doc: https://goo.gl/Rrrc7n (NavigationMojoResponse) Bug: 705744 Change-Id: Id81668b6dc2f55916db796d870968aa335cadc01 Reviewed-on: https://chromium-review.googlesource.com/867061 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Cr-Commit-Position: refs/heads/master@{#533695}
-
Stefan Zager authored
*** PLEASE DO NOT REVERT *** This CL is the culmination of literally years of work. If you believe it is breaking something, please contact szager@chromium.org or skobes@chromium.org before reverting. With this change, all blink layout tests will run with root layer scrolling enabled. The main components of this patch: 1) Set the runtime_enabled_features.json5 entry for "RootLayerScrolling" to "experimental". 2) Remove virtual/rootlayerscrolls prefix from entries in LayoutTests/TestExpectations and FlagExpectations/*, and resolve redundancies with existing expectations lines. 3) Copy the current contents of LayoutTests/TextExpectations to LayoutTests/FlagExpectations/no-root-layer-scrolls 4) Append the contents of FlagExpectations/root-layer-scrolls to TestExpectations 5) Remove the "rootlayerscrolls" entries from VirtualTestSuites, and remove the "--root-layer-scrolls" flag from all remaining entries in that file. 6) Delete the directory LayoutTests/virtual/rootlayerscrolls, and all of its contents. 7) Move/copy test expectations files in LayoutTests/flag-specific/root-layer-scrolls and in the canonical (i.e., not flag-specific) LayoutTests/ locations as follows: - for each layout test that has at least one expectation file in flag-specific/root-layer-scrolls/: - if the test has any .png files in flag-specific/root-layer-scrolls/: - move all .png files in the canonical location to flag-specific/no-root-layer-scrolls - move all .png files in flag-specific/root-layer-scrolls/ to the canonical location. - if the test has any .txt files in flag-specific/root-layer-scrolls/: - move all .txt files in the canonical location to flag-specific/no-root-layer-scrolls - move all .txt files in flag-specific/root-layer-scrolls/ to the canonical location. BUG=417782 R=skobes@chromium.org,bokan@chromium.org,chrishtr@chromium.org Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I7a13ad251efc573acc5b737bd9ca29adf21a5c87 Reviewed-on: https://chromium-review.googlesource.com/893624 Commit-Queue: Stefan Zager <szager@chromium.org> Reviewed-by:
Steve Kobes <skobes@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#533694}
-
Shivani Sharma authored
There was an extra Read being invoked by the consumer of HttpCache::Transaction in some cases and the transaction state machine was not handling it well (crashing with dcheck/infinite loop in DoLoop). This CL fixes the handling. Tested that the unit test indeed asserts without the fix if dcheck is enabled (if not, the DoLoop will go in an infinite loop since we were entering it with next_state_ set as STATE_NONE and then in the while loop setting it as STATE_UNSET). Test: net_unittests --gtest_filter=HttpCache.SimpleGET_ExtraRead Bug: 806344 Change-Id: I8b9472b48b15ed9f6c2132863f66941010b7aa52 Reviewed-on: https://chromium-review.googlesource.com/896145 Commit-Queue: Shivani Sharma <shivanisha@chromium.org> Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Cr-Commit-Position: refs/heads/master@{#533693}
-
Danyao Wang authored
This CL moves form repost detection for WKBasedNavigationManager to in |webView:decidePolicyForNavigationAction|, where WKWebView gives a clear signal about form reposting (WKNavigationTypeFormResubmitted). This allows simplifying reload for WKBasedNavigationManager to directly delegating to [WKWebView reload]. FormsTestCase now pass with WKBasedNavigationManager. Bug: 807428,705020 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ia35978c42b21405a3749d1764a0485cde9c805d2 Reviewed-on: https://chromium-review.googlesource.com/894892 Commit-Queue: Danyao Wang <danyao@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#533692}
-
https://pdfium.googlesource.com/pdfium.git/+log/f5ca90c00198..1fc533150a27 $ git log f5ca90c00..1fc533150 --date=short --no-merges --format='%ad %ae %s' 2018-02-01 bratell [jumbo] Compile fix: Move a GetPageContent to a more limited scope Created with: roll-dep src/third_party/pdfium The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Ib75b3b9c7153f3ae159e277a3e0c7edd3dbf6ce8 Reviewed-on: https://chromium-review.googlesource.com/896399 Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#533691}
-
Friedrich Horschig authored
This is a reland of 1a544c78. Original change's description: > Remove influence of group name on NTPPopularSites studies > > Recently, a misnamed study (see deleted test config) caused the feature > to fall back to the default popular sites. This isn't a big problem but > when it was finally named correctly, the names of the groups disabled > all popular sites. > > Popular sites should not be so easy to disable. Therefore, remove the > group name condition. > > A forced cmd line flag should cover all possible cases and make the > intention very clear. This is already in place and remains untouched. > > Bug: 794329 > Change-Id: I71458d41de6d0e0d5f0d8fcde1b636b0fe18618c > Reviewed-on: https://chromium-review.googlesource.com/827072 > Commit-Queue: Friedrich Horschig <fhorschig@chromium.org> > Reviewed-by: Gayane Petrosyan <gayane@chromium.org> > Reviewed-by: Marc Treib <treib@chromium.org> > Cr-Commit-Position: refs/heads/master@{#528301} Bug: 794329 Change-Id: I0c391668095cd66be012f0d1d483ff0970cbb018 Reviewed-on: https://chromium-review.googlesource.com/888560Reviewed-by:
Gayane Petrosyan <gayane@chromium.org> Commit-Queue: Friedrich Horschig <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#533690}
-
Steven Valdez authored
Bug: 765161 Change-Id: I1793dc689489c0648d7f6cc2988483355b81ff34 Reviewed-on: https://chromium-review.googlesource.com/893805Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
David Benjamin <davidben@chromium.org> Commit-Queue: Steven Valdez <svaldez@chromium.org> Cr-Commit-Position: refs/heads/master@{#533689}
-
Stephen McGruer authored
position:sticky shipped always-on in M56. Bug: 231752 Change-Id: I7bff1d34540745a7220358965a933141d6f172e7 Reviewed-on: https://chromium-review.googlesource.com/896143Reviewed-by:
Robert Flack <flackr@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#533688}
-