- 16 Oct, 2019 40 commits
-
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/8f91a46b0230..25741699ee0e Created with: gclient setdep -r src-internal@25741699ee0e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I03483f962d5cd45a0b0d261100cdc32733cb318e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864509Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#706315}
-
Miyoung Shin authored
This CL converts CameraAppDeviceProviderRequest and CameraAppHelperRequest in media to the new Mojo type. Bug: 955171 Change-Id: Ifdd02ad052b50879ca54556b0f3cf1a7e8596f95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862446Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Cr-Commit-Position: refs/heads/master@{#706314}
-
Miyoung Shin authored
This CL converts WiFiDisplaySessionService{Ptr, Request} in extensions to the new Mojo type. Bug: 955171 Change-Id: I5eba79faacfb08a099feeca4d003270f21c5364a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862456Reviewed-by: -
Wei Lee authored
Bug: 1004482, 1004483, 1004484 Test: None Change-Id: If0e1b037ab542e211ea5b9d2db37d9867a03779c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860857Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Wei Lee <wtlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#706312}
-
Nicolas Arciniega authored
When running the traffic annotation auditor with the python extractor and either the --all-files option or --no-filtering option turned on, the auditor ignores any path filters when running the extractor since the python extractor is quite fast. Later, if there are any path filters the auditor will attempt to fill in any missing, un-audited annotations from the annotations.xml so that we don't report that those annotations have been removed. In the case of the python extractor, we'd be adding multiple copies of the same annotations into our list of extracted annotations. The result is that the auditor will complain about duplicate annotations. This change fixes the issue by keeping track of whether or not we decided to ignore existing |path_filters| in favor of following the --all-files or --no-filtering flags. Bug: 1005537 Change-Id: Icda9bb469bf4a8f90d099a53c79d3154f68b12fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1853853Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#706311}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/8cde4063d097..9097eeb5359b git log 8cde4063d097..9097eeb5359b --date=short --no-merges --format='%ad %ae %s' 2019-10-16 sugoi@google.com Workaround a compiler issue Created with: gclient setdep -r src/third_party/swiftshader@9097eeb5359b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@google.com Bug: chromium:1013375 Change-Id: I444959f7d1b8be0e4a5dacb523a4ec1c86b7a9b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864449Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#706310}
-
Takashi Toyoshima authored
services/network/public/cpp/cors/cors.cc contains several test parsing code. These all are in an inner anonymous namespace, but can be accessible via IsCorsSafelistedHeader interface with some specific arguments. This patch adds fuzzing tests for the interface and call it with several header names so that it covers all parsing functions. Bug: 1007883 Change-Id: I9440a34d57aedb265a4f09a3445d9edc55270d3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1855627 Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#706309}
-
Alex Danilo authored
Bug: 980452 Change-Id: I5a60f59b64f290513bb2dfc2aa7d9e2a34471495 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864489 Commit-Queue: Alex Danilo <adanilo@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Auto-Submit: Alex Danilo <adanilo@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#706308}
-
Kent Tamura authored
DOM mutation doesn't affect DocumentLifecycle. If it was kLayoutClean before UpdateType(), it's still kLayoutClean in Document::UpdateFocusAppearanceAfterLayout(). What we'd like to ensure in UpdateType() is no synchronous style recalc or layout. So this CL adds |DocumentLifecycle:: DisallowTransitionScope()|. Bug: 1009806 Change-Id: I0ad30908e76a9084ba8d685285e613a7194c02fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1861436Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#706307}
-
Makoto Shimazu authored
This CL converts base::Bind to BindOnce or BindRepeating, and also changes relevant base::Callbacks or base::Closures to appropriate types. This CL is split from https://crrev.com/c/1831621. This CL was uploaded by git cl split. R=dtrainor@chromium.org Bug: 1007760, 1007685 Change-Id: Iba9be2981b042593327e9ca5bf862c263f4f6ffc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849531 Commit-Queue: Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Reviewed-by:
Chase Phillips <cmp@chromium.org> Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Auto-Submit: Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#706306}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 34c175bd. With Chromium commits locally applied on WPT: 6386d9d8 "Update service_worker_unregister_and_register()" f399b336 "Fetch Metadata: Add a test for `<embed>` navigated after loading." e547ca2c "[CSS] Add test to to ensure that ::part overrides inline-style." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=lpz No-Export: true Change-Id: Id2314b6fc5d2092ad2533ebb5eb84e057c6fc932 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863441Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#706305}
-
Marina Sakai authored
Since Blink properly supports the incumbent realm now, there is no more need to use OriginSafeMethodSetter, which sets value via V8PrivateProperty. So there is no need to use V8PrivateProperty also in OriginSafeMethodGetter. This CL makes it possible to handle "data properties" of cross-origin properties as the proper data properties. Bug: 715418 Change-Id: I336a8459b80bc63d08a248f3ed7a34dc0806e5ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844520 Commit-Queue: Marina Sakai <marinasakai@google.com> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#706304}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/ac6afeb999e9..c2615b7727cb git log ac6afeb999e9..c2615b7727cb --date=short --no-merges --format='%ad %ae %s' 2019-10-16 mmortensen@google.com Add determine_chrome_version to GetTargetVersions. Created with: gclient setdep -r src/third_party/chromite@c2615b7727cb If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I046ec654cc15fcee3959822de87338d9bc5ea888 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864329Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/ecd11dd1..480cfc4a Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I050a170d087667721d661f9a02243de8482f426f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863440Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#706302}
-
Takashi Toyoshima authored
This patch introduces two enterprise policies, one is kCorsLegacyModeEnabled, and the other is kCorsMitigationList. kCorsLegacyModeEnabled disbles OOR-CORS feature completely, and uses the legacy Blink CORS instead. The policy can not be dynamically modified, and a consistent value is managed by per-profile instance in the browser process. Call sites in the browser process checks the OOR-CORS mode via BrowserContext, and if the actual instance inherits Profile class, it counts in the policy. If call sites do not have a corresponding BrowserContext, it directly checks base::FeatureList. Call sites in the renderer processes are managed via a command line flag. The browser process properly sets the flag based on the OOR-CORS mode that is checked by the steps described above. Call sites in the network process should ask the relevant NetworkContext. Each NetworkContext should initialize the OOR-CORS mode based on the NetworkContextParams that should be properly set by the browser process. If the constructor that does not have the NetworkContextParams argument is called, base::FeatureList is directly checked to initialize the mode. Thus, all components for chromium can use a consistent CORS mode during each profile session. kCorsMitigationList still activate the OOR-CORS as long as the feature is not disabled for other reasons. But it adopts compatibility mitigation to mimic the legacy behavior. E.g., it enforces all Extensions to call webRequest API with "extraHeaders" option, and specified header names are assumed as CORS-safelisted so that it does not trigger CORS preflights. Bug: 1000977, 1000984, 1000982 Change-Id: I4166e26405482e479c895db639bb73a4388fc0b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1830253Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
-
Daniel Rubery authored
Per the documentation, these should only apply to files selected for deep scanning. The current implementation, however, applies these restrictions to all downloads. Bug: 980777 Change-Id: I62e80d590def15e19d2ba1740356390a757ae628 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849415 Commit-Queue: Daniel Rubery <drubery@chromium.org> Reviewed-by:
Bettina Dea <bdea@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#706300}
-
Charles Zhao authored
FileOpening and UrlVisiting is observed inside SearchResultRanker as a quick fix. Since the CrOSActionRecorder is disabled by default, and it's constructor is relatively trivial. This will not be a problem. Bug: 1012936 Change-Id: I42c32b2b622881ddaa802dc31e9afcae8f1c2e52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862881 Commit-Queue: Charles . <charleszhao@chromium.org> Reviewed-by:
Tony Yeoman <tby@chromium.org> Cr-Commit-Position: refs/heads/master@{#706299}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/120275e84dca..8f91a46b0230 Created with: gclient setdep -r src-internal@8f91a46b0230 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None,chromium:None Change-Id: Iabdcad8844a8b57f8905b2cc9777fe77c93a79fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864270Reviewed-by:
-
Alexandre Courbot authored
This is a reland of 61ae3ddf. Changes: check that backend_ is not nullptr before using it in places where this can happen. Original change's description: > There are two V4L2 decode APIs: stateless and stateful. In the VDA era > these were implemented as two completely separate classes > (V4L2VideoDecodeAccelerator and V4L2SliceVideoDecodeAccelerator), which > resulted in a lot of duplicated code and bugs due to fixes not being > replicated on both classes. > > For the VD-based decoder, we want to avoid doing the same error and > use a single V4L2 decoder, supported by different backends depending on > which V4L2 API we are using. > > This CL is the first step towards that direction: it splits the > V4L2SliceVideoDecoder into its general V4L2 part and the one that is > specific to the stateless API. > > Bug: 1003223 > Test: video_decode_accelerator_tests passing on Kevin. > > Change-Id: I373f3ea739b6799ecad009d053ca7e415b8484bd > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1840034 > Commit-Queue: Alexandre Courbot <acourbot@chromium.org> > Reviewed-by: Hirokazu Honda <hiroh@chromium.org> > Reviewed-by: David Staessens <dstaessens@chromium.org> > Reviewed-by: Chih-Yu Huang <akahuang@chromium.org> > Cr-Commit-Position: refs/heads/master@{#705894} Bug: 1014756 Test: video_decode_accelerator_tests passing on Kevin. Change-Id: I5ec23f64faf0e309f26f973ce7fa3f81eb05d60c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863053Reviewed-by:
David Staessens <dstaessens@chromium.org> Reviewed-by:
Chih-Yu Huang <akahuang@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Commit-Queue: Chih-Yu Huang <akahuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#706297}
-
Manu Cornet authored
Bug: 1012353, 1006013, 1009716 Change-Id: Ib056dc7c7dcf38e54b83cb3e0ffcd3461e4c1b3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863672 Commit-Queue: Manu Cornet <manucornet@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#706296}
-
Renjie Tang authored
Change-Id: I8ffb26d392a312e18a7b5982b02337a1120fd7aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1859639 Commit-Queue: Renjie Tang <renjietang@chromium.org> Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#706295}
-
Xida Chen authored
At this moment, CSSPaintValue keeps a CSSPaintImageGenerator which is associated with a Document. In the test case that is reported in the bug, the GetImage is called on a new Document. While the old Document could have gone out of the scope, the GetImage function would crash. This CL makes CSSPaintValue keeps a hash map from Document to CSSPaintImageGenerator. In this case, we can use the correct generator whenever GetImage is called. A unit test case is added. Bug: 998439 Change-Id: Id625e7c0b6840a6f27e2b4e6ea39623c7eaf904b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838674Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#706294}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/a27dfcf868bf..8cde4063d097 git log a27dfcf868bf..8cde4063d097 --date=short --no-merges --format='%ad %ae %s' 2019-10-16 swiftshader.regress@gmail.com Regres: Update test lists @ a27dfcf8 Created with: gclient setdep -r src/third_party/swiftshader@8cde4063d097 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@google.com Bug: None Change-Id: Ie6ddefd682eefc7eb7f0758021efdf256aee8779 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863519Reviewed-by:
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=cmasso@chromium.org Change-Id: I6403ba30a79ae7caaff045e6b3f75f010eadccdb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864350Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#706292}
-
Jay Harris authored
The particular motivation for this CL is file handling on Linux, as registering and unregistering file handlers requires regenerating app shortcuts, making a BMO agnostic approach to regenerating shortcuts desirable. (Note: BMO is a refactoring effort to move WebApps of the extensions system). Bug: 860581 Change-Id: Iec10bbc48f2dfa00ff407eb9c0aa2546aad01ce9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846422 Commit-Queue: Jay Harris <harrisjay@chromium.org> Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#706291}
-
Shuo-Peng Liao authored
ImageProcessor stores input and output's configuration with VideoFrameLayout object and VideoFrame::StorageType. However, VideoFrameLayout is unable to represent proprietary format, e.g. MT21, so it is not suitable to represent IP's input/output config. Instead of storing individual configuration properties (format, visible_size, color_plane_layout, storage_type), we modify an existing class, ImageProcessor::PortConfig, to store ImageProcessor's input/output configuration. BUG=1004727, 1005636 TEST=Run VDA test on hana TEST=Run VEA test on kevin TEST=pass webrtc.DecodeAccelUsedVP8 on kevin Change-Id: Id5cef9c77903f42de95612311569cb08f6e9afb0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1855142 Auto-Submit: Chih-Yu Huang <akahuang@chromium.org> Reviewed-by:
Alexandre Courbot <acourbot@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Commit-Queue: Alexandre Courbot <acourbot@chromium.org> Cr-Commit-Position: refs/heads/master@{#706290}
-
Yutaka Hirano authored
This is a follow up change for https://crrev.com/8ee3f7e6d3a79b15824b6e286eb71c0a96c4d879. See its CL description for details. Bug: 961614, 1006292 Change-Id: Idff6f6645cf01cc7ea8c873cbde9039e641f7ecc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862014Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#706289}
-
Chase Phillips authored
This CL moves the date assumed for corrupted caches from Tue Jan 29, 2019 to Sun Jul 6, 2019. We expect this change to land in master and be backported to M78. The CL currently has placeholder text where information about the affected regions of response timestamp vs max-age/TTL will go in a later change. AppCache is currently deprecated with removal targeted for M82. We expect that either we'll deploy a more permanent solution by M82 or AppCache will be removed in that milestone. Bug: 1014794 Change-Id: I98fb5042aea144048f82d686025ff7d84ee10ed5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860143 Commit-Queue: Chase Phillips <cmp@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Auto-Submit: Chase Phillips <cmp@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#706288}
-
Hirokazu Honda authored
crrev.com/c/1847432 introduced the bug that VaapiWrapper is destroyed when VaapiWrapper::CreateContextAndSurfaces is successful. This CL fixes the wrong check on the return value. Bug: 1009297, 1005205 Test: https://appr.tc/?debug=loopback&vsc=vp8&video=maxWidth=640,maxHeight=360,minWidth=640,minHeight=360&debug=loopback Change-Id: I9a31b305c991cee5e28139d307f87430c20b45e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862880Reviewed-by:
Ricky Liang <jcliang@chromium.org> Auto-Submit: Hirokazu Honda <hiroh@chromium.org> Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#706287}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/821fe40443ea..120275e84dca Created with: gclient setdep -r src-internal@120275e84dca If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: Ia1f8a53d516202af8748cb0e66d2592e8119c741 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864089Reviewed-by:
-
Fergal Daly authored
This test is already passing for blink but some other browsers fail. This test is a clone of simple.html but moves the color inline. Bug: 1014400 Change-Id: I4810222d43f99ae229afa58458e1830202b7d444 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862134Reviewed-by:
-
Lei Zhang authored
Use more C++11. Along the way, also use base::Contains() in more places and improve STL usage. Change-Id: I34e96d3d9801bcdf30f0f10eea2f5ca91ed43508 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863157Reviewed-by:
Rakina Zata Amni <rakina@chromium.org> Reviewed-by:
-
Mitsuru Oshima authored
of defaultTests because lockScreen test changes the session state. Bug: None Test: No functionality change. Change-Id: I3c6f6353525e97b6a547684066f26a30d8c9f3cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862718 Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Cr-Commit-Position: refs/heads/master@{#706283}
-
Ian Barkley-Yeung authored
Add the AIRA role of "alert" to the "selected file is too big" error message. This should convince screen readers to announce the error. It's time sensitive (per aira "alert" role guidelines) because if the user presses "Send" before hearing the alert, they won't know the file wasn't sent. Not perfect (if the user chooses another file that is too big, the error is not re-announced), but better than what we have currently. Also add aira-describedby to the attach file window, so that the screen readers treat "File will be sent to Google for debugging" as an extra description of the field. BUG=chromium:1005559, chromium:1005528 TEST=ChromeVox on ChromeOS. "Selected file is too big" was announced after selecting a large file. (Took a long time, but it was announced). "File will be sent to Google for debugging" was spoken after "Attach file No file chosen". R=afakhry@chromium.org Change-Id: Ic60b811cd1902e6e621048ed6e9ab6da838ba267 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863363Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Auto-Submit: Ian Barkley-Yeung <iby@chromium.org> Cr-Commit-Position: refs/heads/master@{#706282}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/22f14e2a1c49..ac6afeb999e9 git log 22f14e2a1c49..ac6afeb999e9 --date=short --no-merges --format='%ad %ae %s' 2019-10-16 gbiv@google.com afdo: add indirect call redaction to merged profiles 2019-10-16 vapier@chromium.org cros_build_lib.run: drop old signal workaround 2019-10-16 vapier@chromium.org wrapper: require Python 2.7.5+ and 3.4+ 2019-10-16 vapier@chromium.org run_tests: turn on more python3 coverage 2019-10-15 vapier@chromium.org signer_payloads_client: read hashes as binary data Created with: gclient setdep -r src/third_party/chromite@ac6afeb999e9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I4d8c00b371bee014b1686c9e41b4a56d50e386eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864099Reviewed-by:
-
Xinghui Lu authored
Since high confidence allowlist is currently not available on GMSCore, we plan to have it hardcoded in our code. This is similar to what we have done for CSD allowlist. Bug: 1014202 Change-Id: I5489b3d4ed56b8dd7ad7a79ea205b403b444a077 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860980Reviewed-by:
Daniel Rubery <drubery@chromium.org> Commit-Queue: Xinghui Lu <xinghuilu@chromium.org> Cr-Commit-Position: refs/heads/master@{#706280}
-
Peter Kasting authored
* Use GetPreferredSize() where applicable instead of CalculatePreferredSize() * Format * Remove unnecessary and now-outdated section-divider comment blocks * Use AddChildView(unique_ptr) * Remove duplicated code * Shorten * Don't bother with named constants that add no clarity * Fix comments * Use GetCornerRadiusMetric() * Remove dead code * Use in-declaration initializers Bug: none Change-Id: I3850f944311eb7521ab5827accfc9720532979a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1856925 Commit-Queue: Peter Kasting <pkasting@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by:
manuk hovanesian <manukh@chromium.org> Cr-Commit-Position: refs/heads/master@{#706279}
-
Lei Zhang authored
The global |kRawData| std::map constant have to be initialized when the program starts. Instead, make it a static local by wrapping it in a GetRawData() function so the map is initialized on first use instead. This remove 14 static initializers. Along the way, make some globals fully const, use |kKeyMapCount| in more places instead of hardcoding its value, simplify some code, and make the modified files free of lint errors. Bug: 537099 Change-Id: I1b6d059f608db108bb4ecb672119a5f43634bef5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824067Reviewed-by:
Shu Chen <shuchen@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#706278}
-
Hirokazu Honda authored
This adds if statement to cause a software encoder fallback if non GBM based VideoFrame is given in native input mode. This CL also changes DCHECK_EQs to if-statements in MojoVideoEncodeAccelerator. It is because, if the conditions are false, it causes a renderer process crash. Bug: 1014209 Test: webrtc.DecodeAccelUsedVP8 Change-Id: I7aefe0c8e37dae5f086c6f0ce49651a3816194d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862355Reviewed-by:
-
Evan Stade authored
Use the standard creation path for KeyedServices. Bug: 268984 Change-Id: Id4a555cad9a64d00376e16cc1d072f2bf39b0e3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1852578Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#706276}
-
