- 29 Aug, 2018 40 commits
-
-
Christopher Grant authored
BUG= R=mthiesse Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I4e47915e63ad0485edaf7e252d497fc939f86367 Reviewed-on: https://chromium-review.googlesource.com/1195842Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Christopher Grant <cjgrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#587261}
-
Donn Denman authored
This is a speculative fix for a few flaky tests. For some reason some tests fail on some KitKat devices, probably due to speed issues with timeouts to prevent double-tap recognition. This CL just uses a somewhat longer timeout as a workaround. BUG=878517 Change-Id: I53a8ec93de6eab075a00c89d7edb0f3f15d8b378 Reviewed-on: https://chromium-review.googlesource.com/1194828Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Donn Denman <donnd@chromium.org> Cr-Commit-Position: refs/heads/master@{#587260}
-
Xida Chen authored
In chrome VR, we could get GestureScrollBegin without receiving a GestureTapDown. In this case we should set touch action to Auto. As a result of this, we need to add a TapDown in many unit tests because they send GSB without TapDown. TBR=dtapuska@chromium.org Bug: 851644 Change-Id: Ifa04259b68524e96b0a4faa2f8e1d0bd9b35c81c Reviewed-on: https://chromium-review.googlesource.com/1195649 Commit-Queue: Xida Chen <xidachen@chromium.org> Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Cr-Commit-Position: refs/heads/master@{#587259}
-
Etienne Pierre-doray authored
This CL uses ScopedBlockingCall to mark blocking calls in /chrome/browser/profile_resetter. This CL was created by replacing calls to AssertBlockingAllowed() with instantiations of ScopedBlockingCall(MAY_BLOCK). I kindly ask the reviewer to make sure of the following: - ScopedBlockingCall is instantiated in a scope with minimal CPU usage. If this is not the case, ScopedBlockingCall should be instantiated closer to the blocking call. See scoped_blocking_call.h for more info. Please let me know when/where the blocking call happens if this needs to be changed. - Parameter |blocking_type| matches expectation (MAY_BLOCK/WILL_BLOCK). See BlockingType for more info. While I assumed MAY_BLOCK by default, that might not be the best fit if we know that this callsite is guaranteed to block. - The ScopedBlockingCall's scope covers the entirety of the blocking operation previously asserted against by the AssertBlockingAllowed(). This CL was uploaded by git cl split. R=engedy@chromium.org Bug: 874080 Change-Id: Ib5ad110d3469e8813b0df121d88cfe2170de26ac Reviewed-on: https://chromium-review.googlesource.com/1191131Reviewed-by:Balazs Engedy <engedy@chromium.org> Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Cr-Commit-Position: refs/heads/master@{#587258}
-
Jun Choi authored
Currently FidoCableDiscovery::transport() returns FidoTransportProtocol::kBluetoothLowEnergy. Fix this so that it returns FidoTransportProtocol::kCloudAssistedBluetoothLowEnergy instead. Bug: 877344 Change-Id: I870e57b747738b5a2608e3c18b71ca46c22818f6 Reviewed-on: https://chromium-review.googlesource.com/1195120 Commit-Queue: Jun Choi <hongjunchoi@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#587257}
-
chcunningham authored
SigninManager is being deprecated. Long live IdentityManager. IdentityManager recently added ClearPrimaryAccount() (aka SignOut()) which unblocks migration of this class and its tests. A follow up CL will remove the SigninWrapper used to initialize ProfileSyncService. We now just need the IdentityManager. Bug: 809031 Change-Id: If7fd07ea1c53ea1ed24daf7ee70b27c67cd7e20c Reviewed-on: https://chromium-review.googlesource.com/1175911 Commit-Queue: Chrome Cunningham <chcunningham@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#587256}
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/6443c8dade1c..7dfd811ec106 git log 6443c8dade1c..7dfd811ec106 --date=short --no-merges --format='%ad %ae %s' 2018-08-29 pasko@chromium.org devil: Replace mock asserts with the working ones Created with: gclient setdep -r src/third_party/catapult@7dfd811ec106 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:878777 TBR=sullivan@chromium.org Change-Id: I2e1436b377593c4c838a80acb6b1eeb5e5e1c66c Reviewed-on: https://chromium-review.googlesource.com/1195054Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#587255}
-
Zhiqiang Zhang authored
This CL migrates the logic of handling connection messages from clients. The logic was moved from MRP to message handler to separate all message handling from MRP. Bug: 711860 Change-Id: I009deda26ee51a9be1d5ea0a31af6af9d3ea6605 Reviewed-on: https://chromium-review.googlesource.com/1194968Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Commit-Queue: Zhiqiang Zhang <zqzhang@chromium.org> Cr-Commit-Position: refs/heads/master@{#587254}
-
Qiyu authored
- PauseDiscovery on Connect to paired device - UnpauseDiscovery when connection is over Bug: chromium:523176 Test: Manual test to connect paired devices Change-Id: I7de1e410611b54c7911ef405421789e710997d78 Reviewed-on: https://chromium-review.googlesource.com/1185630 Commit-Queue: Rahul Chaturvedi <rkc@chromium.org> Reviewed-by:
Rahul Chaturvedi <rkc@chromium.org> Cr-Commit-Position: refs/heads/master@{#587253}
-
Paul Jensen authored
Previously runnables would destroy themselves after running. This caused leaks when executors were shutdown with unrun runnables because they wouldn't get destroyed. With this change executors are responsible for destroying runnables, whether they are run or not. For internal runnables (the ones that inherit from Cronet_Runnable) the destroy call properly invokes virtual destructors. This is the first of three CLs to fix runnable destruction, the other two being: 1. when DCHECKs are enabled verify that embedder's executors do in fact destroy the runnables. 2. disallow user created runnables as they have no way of catching destruction and properly cleaning up. Bug: 812334 Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ifcdb96bd7991b9a5757ff65b150ffd2a3d5f73fe Reviewed-on: https://chromium-review.googlesource.com/1193966 Commit-Queue: Paul Jensen <pauljensen@chromium.org> Reviewed-by:
Misha Efimov <mef@chromium.org> Cr-Commit-Position: refs/heads/master@{#587252}
-
Vladimir Levin authored
This patch removes one passing paint containment test expectation. It also fixed an expectation in one other that has an incorrect word s/digit/number/ R=chrishtr@chromium.org Change-Id: I756dc10ff49d7b3ef762d9d9733b566501cb2f5e Reviewed-on: https://chromium-review.googlesource.com/1195678Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#587251}
-
Eric Karl authored
Flips the fieldtrial test config to enable OOP-D for Android bots. We've worked out all the remaining test failures issues and would like to turn this on to collect additional data from the perf bots, as well as to ensure stability while we run our finch trial. Change-Id: I8b896753b6c64aefa36d355c35c40241ba4f88fd Reviewed-on: https://chromium-review.googlesource.com/1180574 Commit-Queue: Eric Karl <ericrk@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#587250}
-
Nicolas Ouellet-Payeur authored
This is a follow-up to: https://chromium-review.googlesource.com/c/chromium/src/+/1149994 Bug: 785242 Change-Id: Iddd3019d7b6695c4ff6f03364fb9c72a1afee446 Reviewed-on: https://chromium-review.googlesource.com/1170855 Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#587249}
-
angle-chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/3e217f65044d..4c3108319e42 git log 3e217f65044d..4c3108319e42 --date=short --no-merges --format='%ad %ae %s' 2018-08-29 jmadill@chromium.org Vulkan: Return VkDeviceSize from DynamicBuffer. Created with: gclient setdep -r src/third_party/angle@4c3108319e42 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=geofflang@chromium.org Change-Id: I837b61737c023ff3538ab266ec2369b84f64aceb Reviewed-on: https://chromium-review.googlesource.com/1195058Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#587248}
-
Pedro Amaral authored
Disabling the button would make it become somewhat grayed out which caused the fading animation to look janky. Bug: 878549 Change-Id: I17d9fbaee3c2fadd49487f018c6d788ab1c4119f Reviewed-on: https://chromium-review.googlesource.com/1195001 Commit-Queue: Pedro Amaral <amaralp@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#587247}
-
Chromite Chromium Autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/45e7b57c0467..df4880942b7d git log 45e7b57c0467..df4880942b7d --date=short --no-merges --format='%ad %ae %s' 2018-08-29 xixuan@chromium.org cbuildbot: move reef-release to skylab and non-important. Created with: gclient setdep -r src/third_party/chromite@df4880942b7d The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: If7328505f2103fa45ce84bdff0586d5c6222b27a Reviewed-on: https://chromium-review.googlesource.com/1195056Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#587246}
-
John Abd-El-Malek authored
This was introduced in r585571. The cause is that MojoDataPump could be hanging on to an unretained callback to CastTransportImpl::OnReadResult. CastSocketImpl::CloseInternal() would reset CastTransportImpl but not MojoDataPump. Depending on the timing of when the data comes back, a UAF could happen. Bug: 878021 Change-Id: I1edf4d2bfdc6ed7c47344f715a7323ed6954cbf7 Reviewed-on: https://chromium-review.googlesource.com/1195747Reviewed-by:
Derek Cheng <imcheng@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#587245}
-
manuk authored
The location bar displays a separator between the location icon and the omnibox text when either the location icon has an attached label, or when omnibox text jog is disabled. Previously, the location icon was 1 px too wide (33 px without a label instead of 32 px) when the separator was shown. This cl decreases the location icon width by 1 px when a separator is shown, and increases the text padding by 1 px in order to retain alignment between the omnibox and results popup texts. This change applies to location icons with and without a label. This change only applies with material refresh. Bug: 865523 Change-Id: I5205a9ee81af6e33bbcb79637c69dd7444fc9b09 Reviewed-on: https://chromium-review.googlesource.com/1188886 Commit-Queue: manuk hovanesian <manukh@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#587244}
-
Joshua Peraza authored
2906581f1051 win: Fix GYP build of http_transport_test_server f540abb506ac Treat response codes in [200..203] as successful e6f26587e435 fuchsia, net: Disable TLS, not currently working for in- Fuchsia tests 606368a39341 linux: Use correct handler argument for client FDs f8b0538406ea fuchsia: Don’t require test certificate setup for disabled TLS tests 3ab5d5eff2b9 Update mini_chromium to 8d641e30a8b1 5c6e19f0001e Use std::shuffle instead of std::random_shuffle 7198015c7318 Fix the Chromium build on ChromeOS for aarch64 2c6c0935e226 Fix an implicit 64-bit to 32-bit conversion 255a4e0c0e51 Add "external" dependency mode for Crashpad's GN build 8068e2dd6df7 Remove references to exe_and_shlib_deps 0204fbd38b72 posix: Make DoubleForkAndExec accept an envp parameter d4d2f8557aac android: Add client methods to start a Java handler 30b8c0dc2aff win: disable string_number_conversion_test for asan/dll Change-Id: I822b8e83d9be4a251f1c3a816684d2e0a688f286 Reviewed-on: https://chromium-review.googlesource.com/1195670Reviewed-by:Mark Mentovai <mark@chromium.org> Commit-Queue: Joshua Peraza <jperaza@chromium.org> Cr-Commit-Position: refs/heads/master@{#587243}
-
Victor Miura authored
To get correct thread names in Chrome tracing, it's necessary to register threads with the base::ThreadIdNameManager and set the thread name. BUG=873377 Change-Id: Icb8d68f941f95f65c53ae19b16e05f0d85c9bfbd Reviewed-on: https://chromium-review.googlesource.com/1192589Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Victor Miura <vmiura@chromium.org> Cr-Commit-Position: refs/heads/master@{#587242}
-
Boris Sazonov authored
This CL wires up 'Activity and interactions' and 'Google activity controls' entries in SyncAndServicesPreferences. It also updates strings used for 'Google activity controls' entry. Bug: 814728 Change-Id: I161bdc0df44d46aba3ad795da2c2a9be5ca543c9 Reviewed-on: https://chromium-review.googlesource.com/1194038Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#587241}
-
Dominic Mazzoni authored
* The site uses Polymer, so we get some web components performance coverage * Tests some simple animations and re-layout, helping us prevent accessibility performance regressions when those occur Bug: none Change-Id: I0e7d55c587b05148e76c532cd21a8d37696c36d5 Reviewed-on: https://chromium-review.googlesource.com/1188893 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Annie Sullivan <sullivan@chromium.org> Cr-Commit-Position: refs/heads/master@{#587240}
-
Rakina Zata Amni authored
Bug: 868227 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I4dc042dbcf7e38b71a64d1caa2982110e2796fef Reviewed-on: https://chromium-review.googlesource.com/1193602Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Cr-Commit-Position: refs/heads/master@{#587239}
-
Pete Williamson authored
This replaces the FileObserver based screenshot detection algorithm with an algorithm based on ContentObserver, which has proven more reliable in our testing. Design doc here: https://docs.google.com/document/d/1iyiVQODF1qh_Qiz7Is1y9jvWt1DYjgXmiJgLbFt2tSs Bug: 857505 Change-Id: Ie4edf56683d92f0834dd1afbe77a49949d2d932f Reviewed-on: https://chromium-review.googlesource.com/1191922Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Peter Williamson <petewil@chromium.org> Cr-Commit-Position: refs/heads/master@{#587238}
-
David Tseng authored
When an aura Window receives a new transform, it possibly impacts its bounds. Previously, we were only observing OnWindowBoundsChanged, which does not get called for transform changes. This change makes it so we also observe OnWindowTransformed and fire a location change to push the new location to all accessibility clients. Bug: 842868 Change-Id: I5251198da8b4af6cb96ad3197a6d37caa0a37faa Reviewed-on: https://chromium-review.googlesource.com/1195645Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#587237}
-
Ian Clelland authored
This queues a report through the Reporting API whenever an image is encountered which violates the 'unsized-media' policy, in a document in which that feature is not allowed according to feature policy. Bug: 867471 Change-Id: I8d39639d21d9a993685f97efc078a9a1ab6f303c Reviewed-on: https://chromium-review.googlesource.com/1195675Reviewed-by:
Steve Kobes <skobes@chromium.org> Commit-Queue: Ian Clelland <iclelland@chromium.org> Cr-Commit-Position: refs/heads/master@{#587236}
-
Joe Downing authored
This CL splits up the existing Mouse input monitor for Windows into a common base class for mouse and keyboard and adds the keyboard implementation for Windows. We can implement the other platforms as needed. Bug: 877176 Change-Id: I2ae2168ff340b81306065e647a2d1bd17b59c9d9 Reviewed-on: https://chromium-review.googlesource.com/1187335 Commit-Queue: Joe Downing <joedow@chromium.org> Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Cr-Commit-Position: refs/heads/master@{#587235}
-
Matt Reynolds authored
Add a default configuration for the GamepadPollingInterval finch experiment to fieldtrial_testing_config.json. BUG=855188 Change-Id: I0168675acaa21c95db0e6f61d4735a5dc791ef61 Reviewed-on: https://chromium-review.googlesource.com/1191808Reviewed-by:
Robert Kaplow (slow) <rkaplow@chromium.org> Commit-Queue: Matt Reynolds <mattreynolds@chromium.org> Cr-Commit-Position: refs/heads/master@{#587234}
-
Sebastien Marchand authored
This switch the value of the flag to true by default. The only reason why it was set to false was that the UKM was still pending approval, but it has now been approved and it's probably better to set it to true by default rather than setting it manually in every experiments. Bug: 844426 Change-Id: I0fdea3413886f4610233e95696306f25fc9d70a0 Reviewed-on: https://chromium-review.googlesource.com/1195543 Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#587233}
-
Majid Valipour authored
will-change workaround is no longer necessary. Most other cases have been removed in http://crrev.com/584946 Bug: 873673 Change-Id: I3f531c58951aba923f390674c7acac58fe39b860 Reviewed-on: https://chromium-review.googlesource.com/1195646Reviewed-by:
Peter Mayo <petermayo@chromium.org> Commit-Queue: Majid Valipour <majidvp@chromium.org> Cr-Commit-Position: refs/heads/master@{#587232}
-
David Tseng authored
Bug: 862419 Change-Id: Id04a7a505333a33227924051f336e2440e4ba5a0 Reviewed-on: https://chromium-review.googlesource.com/1194572 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#587231}
-
Sarah Hu authored
This is only used by settings and is no longer needed per latest mock. Bug: 876067 Change-Id: Ib9dd98b1912f87d881fb7ec8f74b17f56352b656 Reviewed-on: https://chromium-review.googlesource.com/1188454Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Jacob Dufault <jdufault@chromium.org> Commit-Queue: Xiaoyin Hu <xiaoyinh@chromium.org> Cr-Commit-Position: refs/heads/master@{#587230}
-
Stephen McGruer authored
Upstream the spec has changed from using 'null' to represent a missing composite value on keyframes to using 'auto'. Instead of changing our internal representations to use two different enums (i.e. CompositeOperator and CompositorOperationOrAuto), this CL just updates the conversion logic to treat 'auto' as the previous 'null' value, avoiding any change of internal logic. Spec change: https://github.com/w3c/csswg-drafts/issues/3000 Bug: 877967 Change-Id: I8a1c83799f4a538c0102875f6259ac337e9d0843 Reviewed-on: https://chromium-review.googlesource.com/1191205Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Majid Valipour <majidvp@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#587229}
-
Christopher Cameron authored
In previous patches, we have routed almost all usage of the views APIs in BridgedContentView to go through the BridgedNativeWidgetHost. This completes this process. Change initialization of BridgedContentView to not take a views::View, and instead take the initial bounds (which were previously the only thing read from the views::View). Move the functions CreateContentView and DestroyContentView to the public interface. Add a new non-public function, CreateDragDropClient, because drag-drop behavior has not been routed through mojo-ifiable interfaces yet. Add an accessor to BridgedNativeWidget to query whether or not the window is translucent (which was previously determined by querying properties of the ui::Layer). Bug: 859152 Change-Id: Iaa5b628f619fc35a48530812c15d0cc877a3d40c Reviewed-on: https://chromium-review.googlesource.com/1192547 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#587228}
-
kristipark authored
Delete any links initialized from Most Visited when their history entry is cleared. If the link is modified by the user (i.e. edit/add), the link will not be deleted when history is cleared. Bug: 874185 Change-Id: I762fe713c097bfa75e86b25368cff25e116d674d Reviewed-on: https://chromium-review.googlesource.com/1179246 Commit-Queue: Kristi Park <kristipark@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#587227}
-
Navid Zolghadr authored
Push a new PointerRawMove in the main thread event queue for MouseMove events. Note that we do not send compatibility mouse events for this type. Only PointerEvent with the type pointerrawmove. Also note that this change only adds pointerrawmove for mouse events at this point. pointerrawmove for touch events should come in the following CLs. Intent to implement: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/84RGJvm_PMM Bug: 873684 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Icb003b8ba978f1c64157dbbe79222a687d4aa42d Reviewed-on: https://chromium-review.googlesource.com/1181171Reviewed-by:
Mustaq Ahmed <mustaq@chromium.org> Reviewed-by:
Rick Byers <rbyers@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Ella Ge <eirage@chromium.org> Commit-Queue: Navid Zolghadr <nzolghadr@chromium.org> Cr-Commit-Position: refs/heads/master@{#587226}
-
Etienne Pierre-doray authored
This CL uses ScopedBlockingCall to mark blocking calls in /chrome/browser/ui/webui. This CL was created by replacing calls to AssertBlockingAllowed() with instantiations of ScopedBlockingCall(MAY_BLOCK). I kindly ask the reviewer to make sure of the following: - ScopedBlockingCall is instantiated in a scope with minimal CPU usage. If this is not the case, ScopedBlockingCall should be instantiated closer to the blocking call. See scoped_blocking_call.h for more info. Please let me know when/where the blocking call happens if this needs to be changed. - Parameter |blocking_type| matches expectation (MAY_BLOCK/WILL_BLOCK). See BlockingType for more info. While I assumed MAY_BLOCK by default, that might not be the best fit if we know that this callsite is guaranteed to block. - The ScopedBlockingCall's scope covers the entirety of the blocking operation previously asserted against by the AssertBlockingAllowed(). This CL was uploaded by git cl split. R=scottchen@chromium.org Bug: 874080 Change-Id: If28d24f284744bcdda4b48c27d20952d17c20db2 Reviewed-on: https://chromium-review.googlesource.com/1191419Reviewed-by:Tommy Li <tommycli@chromium.org> Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Cr-Commit-Position: refs/heads/master@{#587225}
-
Min Chen authored
Drop the dragged window into overview if the window has been dragged further than half of the distance from top of the display to the top of the new selector item in overview. Do not apply this rule if preview area is shown or splitview is active. Bug: 874508 Change-Id: Ib3faf6aadd8a49f2380b330fddd1b647bf63a9e7 Reviewed-on: https://chromium-review.googlesource.com/1192699 Commit-Queue: Min Chen <minch@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#587224}
-
Ian Clelland authored
This queues a report through the Reporing API whenever the PaymentRequest API is invoked from a frame in which the 'payment' feature is not allowed according to feature policy. Bug: 867471 Change-Id: Ie03fe06924a634829d03fb9d9693aee29ab66dd2 Reviewed-on: https://chromium-review.googlesource.com/1191411Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Ian Clelland <iclelland@chromium.org> Cr-Commit-Position: refs/heads/master@{#587223}
-
Justin Cohen authored
This reverts commit ae6e8514. Reason for revert: cronet and webrtc aren't on Xcode 10 yet. Original change's description: > [ios] Bump minimum Xcode requirement to 10. > > Change-Id: I60521b36cb903ca18d59fe88caa1a9c7b1aa9e87 > Reviewed-on: https://chromium-review.googlesource.com/1182377 > Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> > Reviewed-by: Rohit Rao <rohitrao@chromium.org> > Reviewed-by: Justin Cohen <justincohen@chromium.org> > Commit-Queue: Justin Cohen <justincohen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#587174} TBR=rohitrao@chromium.org,sdefresne@chromium.org,justincohen@chromium.org Change-Id: I815f001ec9c75008791dd46cb1ee39f62248a160 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/1194601Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#587222}
-