GitLab

related to how a flag was persisted.

BUG=141081,141643


Review URL: https://chromiumcodereview.appspot.com/10854069

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150928 0039d316-1c4b-4281-b951-d872f2087c98

BUG=127323
TEST=New test


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=150420

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=150725

Review URL: https://chromiumcodereview.appspot.com/10825210

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150927 0039d316-1c4b-4281-b951-d872f2087c98

The NaCL SDK builds this code with -Wswitch-enum -Werror so
this is failing to build.

Perhaps in light if this its best to just remove the default
case?

BUG=


Review URL: https://chromiumcodereview.appspot.com/10855056

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150926 0039d316-1c4b-4281-b951-d872f2087c98

Changes to the annotator required launching the script differently.

BUG=none
TEST=nacl mono buildbots

Review URL: https://chromiumcodereview.appspot.com/10829266

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150925 0039d316-1c4b-4281-b951-d872f2087c98

The UI string should reflect the true nature of the date. The date is in fact when the Chrome OS image is built, not when it is installed on the device.

BUG=132561
TEST=locally verified on lumpy.


Review URL: https://chromiumcodereview.appspot.com/10824214

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150924 0039d316-1c4b-4281-b951-d872f2087c98

TBR=ben@chromium.org
BUG=none

Review URL: https://chromiumcodereview.appspot.com/10826237

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150923 0039d316-1c4b-4281-b951-d872f2087c98

This allows us to round-trip from PepperPluginInfo to WebPluginInfo and back. This happens in the component updater when it registers Flash.

BUG=138902


Review URL: https://chromiumcodereview.appspot.com/10831224

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150922 0039d316-1c4b-4281-b951-d872f2087c98

IPConfig interface.

BUG=chromium-os:33223,chromium:129052
TEST=built and tested with another in-process CL that will use it.


Review URL: https://chromiumcodereview.appspot.com/10824242

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150921 0039d316-1c4b-4281-b951-d872f2087c98

Due to a bug, the Clang-plugin style checker failed to warn about
inline constructors, destructors, non-empty virtual methods, etc.
for nested classes.

The plugin has been fixed, and this patch is part of a clean-up of all
the code that now causes the plugin to issue errors.

BUG=139346


Review URL: https://chromiumcodereview.appspot.com/10834248

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150920 0039d316-1c4b-4281-b951-d872f2087c98

BUG=141503
TEST=Remove non-touch resource paks, no missing resources in renderers when touch optimized layout is used.

Review URL: https://chromiumcodereview.appspot.com/10827256

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150919 0039d316-1c4b-4281-b951-d872f2087c98

BUG=125937

Review URL: https://chromiumcodereview.appspot.com/10831240

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150918 0039d316-1c4b-4281-b951-d872f2087c98

Due to a bug, the Clang-plugin style checker failed to warn about
inline constructors, destructors, non-empty virtual methods, etc.
for nested classes.

The plugin has been fixed, and this patch is part of a clean-up of all
the code that now causes the plugin to issue errors.

BUG=139346


Review URL: https://chromiumcodereview.appspot.com/10854063

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150917 0039d316-1c4b-4281-b951-d872f2087c98

This removes dependency on ui::TouchEvent interface, and cleans up some parts of
the code.

BUG=125937

Review URL: https://chromiumcodereview.appspot.com/10832230

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150916 0039d316-1c4b-4281-b951-d872f2087c98

BUG=125937

Review URL: https://chromiumcodereview.appspot.com/10829262

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150915 0039d316-1c4b-4281-b951-d872f2087c98

We do some relatively minor changes to our policies and adopt
a baseline on which the GPU and Flash policies are now based.

We allow a few more syscalls than we used to to make our sandbox
more robust against library updates or rarely exercised codepaths.

BUG=


Review URL: https://chromiumcodereview.appspot.com/10837156

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150914 0039d316-1c4b-4281-b951-d872f2087c98

Due to a bug, the Clang-plugin style checker failed to warn about
inline constructors, destructors, non-empty virtual methods, etc.
for nested classes.

The plugin has been fixed, and this patch is part of a clean-up of all
the code that now causes the plugin to issue errors.

BUG=139346


Review URL: https://chromiumcodereview.appspot.com/10855076

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150913 0039d316-1c4b-4281-b951-d872f2087c98

Due to a bug, the Clang-plugin style checker failed to warn about
inline constructors, destructors, non-empty virtual methods, etc.
for nested classes.

The plugin has been fixed, and this patch is part of a clean-up of all
the code that now causes the plugin to issue errors.

BUG=139346


Review URL: https://chromiumcodereview.appspot.com/10829258

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150912 0039d316-1c4b-4281-b951-d872f2087c98

The cause of the error was work_area in screen coordinates was passed to CalculateAttachedSizes while bounds is in |window()->parent()|'s coordinates.

BUG=139231
TEST=Set the 2nd display on left, open two windows and use multi window resizer on debug build, and check crash does not occur.

Review URL: https://chromiumcodereview.appspot.com/10836157

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150911 0039d316-1c4b-4281-b951-d872f2087c98

Previously, I thought width was used in layout in render_text_linux.cc,
but it turns out that the width that's passed in to SetupPangoLayout()
gets cleared right after. So the width of the display rect does not
actually affect layout and thus does not need to cause the layout to
be reset.

BUG=137064
TEST=No behavior change.

Review URL: https://chromiumcodereview.appspot.com/10829261

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150908 0039d316-1c4b-4281-b951-d872f2087c98

The original name was a misnomer. Looking at the code, the function
moves an entry from the root directory to another directory.

Along the way, remove if (!callback.is_null()) and PostTask() from
this and related functions.

BUG=126634, 139446
TEST=copying and moving of files on Drive work as before

Review URL: https://chromiumcodereview.appspot.com/10828238

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150907 0039d316-1c4b-4281-b951-d872f2087c98

As titled, switches everything over to using the AudioBus
class instead of const std::vector<float*>.  Allows removal
of lots of crufty allocations and memsets.

BUG=114700
TEST=unit tests, layout tests, try bots.  Nothing should change.


Review URL: https://chromiumcodereview.appspot.com/10823175

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150906 0039d316-1c4b-4281-b951-d872f2087c98

This applies the mmap workaround to all "Chrome" builds, since we're
also seeing the error on Chrome continuous branch builders, which aren't
marked as "Official" builds.

Review URL: https://chromiumcodereview.appspot.com/10823264

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150905 0039d316-1c4b-4281-b951-d872f2087c98

This tool checks all third-party code used on Android, for the purposes of the Android WebView build.

BUG=138921

Review URL: https://chromiumcodereview.appspot.com/10816041

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150904 0039d316-1c4b-4281-b951-d872f2087c98

The code paths have been different for quite some time without any new suppressions filed. In addition to that, I've landed a few patches that improve the thread safety of code in question!

BUG=46642,107181
TBR=timurrrr

Review URL: https://chromiumcodereview.appspot.com/10830250

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150903 0039d316-1c4b-4281-b951-d872f2087c98

Most of our existing disk cache histograms focus on the speed of operations on the cache itself. This CL adds a bunch that break down http transactions by type, and track both time spent reading (either from disk cache or network), and time spent waiting for the disk cache to allow us to send the network request.

Note that these patches are based on http://codereview.chromium.org/10797042/ , which must land first.

R=rvargas@chromium.org, tburkhard@chromium.org
BUG=None

Review URL: https://chromiumcodereview.appspot.com/10808047

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150902 0039d316-1c4b-4281-b951-d872f2087c98

- Update third_party/mach_override from https://github.com/rentzsch/mach_star/mach_override to include the fix for building Chromium on 64 bits.

BUG=138535

Review URL: https://chromiumcodereview.appspot.com/10834127

TBR=mmaerean@adobe.com
Review URL: https://chromiumcodereview.appspot.com/10830249

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150901 0039d316-1c4b-4281-b951-d872f2087c98

Unfortunately until bug 110228 is fixed I have to keep IsInitializedForTesting() around but atleast it enforces that state_ is accessed on the same thread instead of locking.

Review URL: https://chromiumcodereview.appspot.com/10823261

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150899 0039d316-1c4b-4281-b951-d872f2087c98

This CL: 
- eliminates unnecessary dispatches
- correctly handles devices that are discovered before interest is
registered

TEST=ran api test
BUG=133179


Review URL: https://chromiumcodereview.appspot.com/10815072

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150898 0039d316-1c4b-4281-b951-d872f2087c98

NOTRY=true


Review URL: https://chromiumcodereview.appspot.com/10831244

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150897 0039d316-1c4b-4281-b951-d872f2087c98

The public functions TransferFileFromRemoteToLocal() and
TransferFileFromLocalToRemote() are called from file_browser_private_api.cc
with callbacks, hence it's safe to make the callback parameter mandatory.

BUG=126634, 139446
TEST=out/Release/unit_tests --gtest_filter=GData*

Review URL: https://chromiumcodereview.appspot.com/10824240

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150896 0039d316-1c4b-4281-b951-d872f2087c98

http://crbug.com/125937
TEST=existing
TBR=jochen@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10825254

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150895 0039d316-1c4b-4281-b951-d872f2087c98

sourceSetTimestampOffset() was removed in r150129 because it looked like it wasn't being used.  It just hadn't been hooked up to WebKit yet.  This patch will add it back.

BUG=141659

Review URL: https://chromiumcodereview.appspot.com/10823260

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150894 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/10825189

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150893 0039d316-1c4b-4281-b951-d872f2087c98

due to fame navigation flakiness.

TBR=jochen@chromium.org 
BUG=141497
Review URL: https://chromiumcodereview.appspot.com/10827258

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150892 0039d316-1c4b-4281-b951-d872f2087c98

Due to a bug, the Clang-plugin style checker failed to warn about
inline constructors, destructors, non-empty virtual methods, etc.
for nested classes.

The plugin has been fixed, and this patch is part of a clean-up of all
the code that now causes the plugin to issue errors.

BUG=139346


Review URL: https://chromiumcodereview.appspot.com/10825275

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150891 0039d316-1c4b-4281-b951-d872f2087c98

DownloadItem::Observer::OnDownloadDestroyed() replaces DownloadItem::REMOVING
Changes from original CL only in downloads_api.*

Reviewers:
Ben Goodger: chrome/browser/ui/views/download/download_item_view.*, chrome/browser/plugin_installer.*, chrome/browser/automation/automation_provider.cc
rdsmith, asanka: all
Nico (thakis): chrome/browser/ui/cocoa/download/download_item_mac.*
Achuith: chrome/browser/chromeos/gdata/gdata_download_observer.*
Evan (estade): chrome/browser/ui/gtk/download/download_item_gtk.*, chrome/browser/ui/webui/downloads_dom_handler.*
Scott (sky): chrome/browser/history/history_unittest.cc
Aaron (aa): chrome/browser/extensions/webstore_installer.*

Add DownloadItem::Observer::OnDownloadRemoved() to signal when a download is being removed from history.
Make chrome.downloads.onErased trigger from DownloadItem::Observer::OnDownloadRemoved() so that extensions don't think that all downloads are being erased just because the browser is closing.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=149794
Reverted: http://src.chromium.org/viewvc/chrome?view=rev&revision=150086
http://crbug.com/140687

Review URL: https://chromiumcodereview.appspot.com/10704026

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150890 0039d316-1c4b-4281-b951-d872f2087c98

Resubmit of r145925

BUG=136828
TEST=none

Review URL: https://chromiumcodereview.appspot.com/10702038


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150889 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150888 0039d316-1c4b-4281-b951-d872f2087c98

TBR=yutak@chromium.org

BUG=

Review URL: https://chromiumcodereview.appspot.com/10823236

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150887 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/10827248

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150886 0039d316-1c4b-4281-b951-d872f2087c98