- 04 May, 2018 40 commits
-
-
https://chromium.googlesource.com/catapult.git/+log/2048c078d45e..4f42243e85c8 $ git log 2048c078d..4f42243e8 --date=short --no-merges --format='%ad %ae %s' 2018-05-03 simonhatch Dashboard - Use new isolate target for linux-perf. Created with: roll-dep src/third_party/catapult BUG=chromium:836037 The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=sullivan@chromium.org Change-Id: I812ed7c6ee64248f9595c2590dd7682492042590 Reviewed-on: https://chromium-review.googlesource.com/1043605 Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#555998}
-
Darren Shen authored
This patch adds a new OnFocus event to the private keyboard API. This event has additional information about whether the focus was triggered by a pen stylus or other means. The plan is for IME extension to listen to this event and change its keyset/position/mode etc. depending on the focus reason. If the extension listens to the private OnFocus event, then the public version would not be triggered (and vice versa). This is to prevent OnFocus from being raised twice. Bug: 824604 Change-Id: I5dd523a183d517e166bbc73abd6a79a6557c6942 Reviewed-on: https://chromium-review.googlesource.com/1015446 Commit-Queue: Darren Shen <shend@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Shu Chen <shuchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#555997}
-
Patrik Höglund authored
This reverts commit a99efe4b. Reason for revert: Still flaky. Original change's description: > Revert "Disable flaky capture unittests on Linux." > > This reverts commit 46bf6346. > > Reason for revert: New webcam plugged in; let's see if they're still flaky. > > Original change's description: > > Disable flaky capture unittests on Linux. > > > > The tests went flaky when we replaced the bot and get VIDIOC_STREAMON > > errors about 25% of the builds. I have no idea to fix that; we tried > > replacing the webcam and moving it around in the USB ports and that > > didn't help. See http://crbug.com/828568 for discussion. > > > > Bug: chromium:831514 > > Change-Id: Ic55c09a16a22dd0402c3360b710e310c733ec5f9 > > Reviewed-on: https://chromium-review.googlesource.com/1016301 > > Reviewed-by: Christian Fremerey <chfremer@chromium.org> > > Commit-Queue: Christian Fremerey <chfremer@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#552165} > > TBR=phoglund@chromium.org,chfremer@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: chromium:831514, chromium:828568 > Change-Id: I01b21c5073e79e004c74430cc6eeb3422b602745 > Reviewed-on: https://chromium-review.googlesource.com/1039425 > Reviewed-by: Patrik Höglund <phoglund@chromium.org> > Commit-Queue: Patrik Höglund <phoglund@chromium.org> > Cr-Commit-Position: refs/heads/master@{#555342} TBR=phoglund@chromium.org,chfremer@chromium.org Change-Id: I9c976f8bb2e0812029d13ae020896bebadf4ef1c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:831514, chromium:828568 Reviewed-on: https://chromium-review.googlesource.com/1041945 Commit-Queue: Patrik Höglund <phoglund@chromium.org> Reviewed-by:
Patrik Höglund <phoglund@chromium.org> Cr-Commit-Position: refs/heads/master@{#555996}
-
rbpotter authored
Bug: 838663 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I6a8f0c84ebc5b53ed0c74061794d07287a420aa6 Reviewed-on: https://chromium-review.googlesource.com/1038574Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#555995}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/60da1b2e..068949a8 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I75a7ecfe7fb7f745e9f88856571a725101d2de2d Reviewed-on: https://chromium-review.googlesource.com/1043430Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#555994}
-
Fady Samuel authored
Resize throttling in Chromium is complicated. There are three "pending" bits: one for resize, one for paint, and one for auto-resize and the throttling system tries to decide whether to send an ACK from renderer => browser depending on whether the browser wants / expects an ACK. The browser tells the renderer whether it expects an ACK on SynchronizeVisualProperties. This all adds a lot of complexity, and isn't particularly compatible with moving LocalSurfaceId allocation and ACK'ing to the impl thread. SynchronizeVisualProperties will continue to go to the Blink main thread whereas the ACK will come from the compositor thread so it doesn't make sense to push ack bits from main to impl. This CL simplifies throttling to support impl-side ACK'ing and LocalSurfaceId allocation in the following way: The browser manages its throttling independently from the renderer by only issuing a SynchronizeVisualProperties if the previous one has ACK'ed (and it was expecting an ACK). The renderer's ACK decision in this CL is just based on receiving a SynchronizeVisualProperties...that implies that the next commit gets an ACK IPC. In a subsequent CL, ACKs will be based on change in LocalSurfaceId. The invariant maintained by surface sync is: Change in Visual Properties => Change in LocalSurfaceId => Commit => Draw Thus, post-commit, if the LocalSurfaceId changes then it's equivalent to ACK'ing a SynchronizeVisualProperties. Change-Id: Ib3eda5e28e91f34d00a06917911bfd2f778580f7 Bug: 672962 TBR: piman@chromium.org Reviewed-on: https://chromium-review.googlesource.com/1039768 Commit-Queue: Fady Samuel <fsamuel@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Saman Sami <samans@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Cr-Commit-Position: refs/heads/master@{#555993}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/2f62de01d3a7..d8a189fca3cd $ git log 2f62de01d..d8a189fca --date=short --no-merges --format='%ad %ae %s' 2018-05-03 brianosman Revert "Fix a bug in SkGpuBlurUtils::GaussianBlur" 2018-05-03 skcms-skia-autoroll Roll skia/third_party/skcms aee343c..cc1799c (1 commits) 2018-05-03 egdaniel Implement canCopySurface for GrMock and GrMtl. 2018-05-03 swiftshader-skia-autoroll Roll third_party/externals/swiftshader/ ce8eb945c..e76163e3c (1 commit) 2018-05-03 brianosman Disable unpack-row-length support on iOS 2018-05-03 reed remove support code for serialized bitmaps 2018-05-03 brianosman Remove colorspaceinfo 2018-05-03 liyuqian Remove legacy guard flags 2018-05-03 reed check index for valid before subtracting 2018-05-03 egdaniel Remove SK_SUPPORT_LEGACY_BACKEND_OBJECTS from public.bzl. 2018-05-03 robertphillips Fix a bug in SkGpuBlurUtils::GaussianBlur 2018-05-03 reed allow div-by-zero 2018-05-03 egdaniel Implement GL canCopySurface in GrGLCaps. 2018-05-03 angle-skia-autoroll Roll third_party/externals/angle2/ e708f004b..03bb2231a (1 commit) 2018-05-03 csmartdalton Add support for building with MoltenVK 2018-05-03 reed saturate your adds 2018-04-30 liyuqian Change SkMatrix44::fTypeMask to atomic 2018-05-03 herb Add move to quiet warning 2018-05-02 liyuqian Add name field to calmbench json Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=brianosman@chromium.org Change-Id: Id2ce28252d4ae405f8c6e270d949f713a6b6f795 Reviewed-on: https://chromium-review.googlesource.com/1043451Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#555992}
-
Wenzhao Zang authored
1) The focused pod on views login should request wallpaper, the same with web-ui login. 2) Views-based login calls |ShowGaiaScreenIfReady| to pre-load Gaia, before Gaia page is actually open, which results in the bug. We should move the wallpaper-related code to |UpdateGaiaDialogVisibility| which controls the actual visibility of Gaia page on views-login. Bug: 836112 Change-Id: Ide91ba2e7379b23bae94b40be022bfaa7da3c360 Reviewed-on: https://chromium-review.googlesource.com/1043264Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> Cr-Commit-Position: refs/heads/master@{#555991}
-
Xianzhu Wang authored
This will make the raster invalidation tracking result more understandable, by distinguishing appeared and disappeared chunks from appeared and disappeared display items. Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2;master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: Id1ff9218201b7fbca0360c9d93656b8c966c08f7 Reviewed-on: https://chromium-review.googlesource.com/1041573 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Tien-Ren Chen <trchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#555990}
-
rbpotter authored
Add listeners for the print-failed and print-preset-options Web UI events in the new UI, and migrate the behaviors of calling onPrintFailed_() for print-failed and setting the copies and duplex setting values based on the presets when they are received. Also migrate the tests used to verify that presets work. Bug: 773928 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I6cb17b5a189c8d138647a82cf845a47b51d91bdf Reviewed-on: https://chromium-review.googlesource.com/1038660Reviewed-by:
-
Nasko Oskov authored
Chrome error pages currently commit in either the source or destination RenderFrameHost and are not isolated in any way. The "Committed Interstitials" project will change interstitials to work just like error pages. Since interstitial pages use renderer-initiated messaging to proceed through, the security model of them being rendered in a separate process needs to be preserved. This CL is implementing a process isolation model for error pages as described in the following design doc: https://docs.google.com/document/d/17IOOppwf8re2dpz4TflH_7wFkJr6Or-ltXGsTeMOhM0/edit Bug: 448486, 838161 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation Change-Id: I58cdc8f823ffa10a7a7ee219e2ade3d69b538882 Reviewed-on: https://chromium-review.googlesource.com/762520 Commit-Queue: Nasko Oskov <nasko@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#555988}
-
rbpotter authored
Migrate the test that verifies only one printer is fetched at startup, even when there are multiple recent destinations. Bug: 814860 Change-Id: Ia4da53b322b86191b64f5510cfa8260affe2e5f5 Reviewed-on: https://chromium-review.googlesource.com/1042541 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
-
Xi Cheng authored
Bug: 734095 Change-Id: I08275fff11aef97c3265a6832dc1485b4ef19b61 Reviewed-on: https://chromium-review.googlesource.com/1038432 Commit-Queue: Xi Cheng <chengx@chromium.org> Reviewed-by:
Tommy Martino <tmartino@chromium.org> Cr-Commit-Position: refs/heads/master@{#555986}
-
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/25309ca66e03..7c592e6301d6 $ git log 25309ca66..7c592e630 --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src-internal The AutoRoll server is located here: https://src-internal-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I54539b6b356963920bdd729f544cd25dee2b8561 Reviewed-on: https://chromium-review.googlesource.com/1043272Reviewed-by:
src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#555985}
-
Chong Zhang authored
This CL makes |StoragePartitionImpl::url_loader_factory_getter_| available even when Network Service is disable, such that |StoragePartitionImpl::GetURLLoaderFactoryForBrowserProcessIOThread()| can be used in all cases. Note that |URLLoaderFactoryGetter::GetBlobFactory()| is only available when the network service or servicified service worker is enabled. This CL also affects some functional unrelated tests, which are tracked as TODOs and will be addressed in followup CLs. Bug: 826869 Change-Id: If408dc20f5e4564a5865c93a4c66316d5682d9e2 Reviewed-on: https://chromium-review.googlesource.com/1033728 Commit-Queue: Chong Zhang <chongz@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#555984}
-
Johannes Henkel authored
This way, entries correspond with ResourceRequestBlockedReason. Also sort entries more logically and update BuildBlockedReason. Missing content-type is probably a bug / oversight. Change-Id: I3091d5ec5cd85b0cd51dc8e637c9665bd3bc7448 Reviewed-on: https://chromium-review.googlesource.com/1043388Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Johannes Henkel <johannes@chromium.org> Cr-Commit-Position: refs/heads/master@{#555983}
-
Xianzhu Wang authored
For now we don't allow fragmentation of composited layers, so they should skip fragment clips. Bug: 839008 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I33f5ef3e246c0b9bdf1f3e70798e1fd793ea1b58 Reviewed-on: https://chromium-review.googlesource.com/1042997 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#555982}
-
Ramin Halavati authored
IO time out of network traffic annotation tests on the FYI bot is increased. One of the tests takes a considerably long time to make an output and needs to stay alive to do so. Bug: 690323 Change-Id: Iae8384aaea46d48ad9d584b8747d1a576cec9fe1 Reviewed-on: https://chromium-review.googlesource.com/1042287 Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#555981}
-
Donn Denman authored
Changes the current UI_CLOSED to UI_CLOSED_OBSOLETE, and adds new UI_DISMISSED_WITHOUT_OPEN and UI_DISMISSED_AFTER_OPEN events that will log to a new UMA enums for the existing hitogram. BUG=838951 Change-Id: I90ee3c786188e65a1db5f40f04670554f93f2d3c Reviewed-on: https://chromium-review.googlesource.com/1040682Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Commit-Queue: Donn Denman <donnd@chromium.org> Cr-Commit-Position: refs/heads/master@{#555980}
-
jongkwon.lee authored
|updateCursor:| might be called outside the view bounds. Check the mouse location before setting the cursor. Also, do not set cursor if it's not a key window. Bug: 837182 Change-Id: Idd2f12648e858284c6fc4cb1ba3b03eb7ad4f274 Reviewed-on: https://chromium-review.googlesource.com/1039283Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#555979}
-
https://chromium.googlesource.com/catapult.git/+log/153134ef26c3..2048c078d45e $ git log 153134ef2..2048c078d --date=short --no-merges --format='%ad %ae %s' 2018-05-01 eakuefner [Dashboard] Fix stdio URLs for histogram uploads 2018-05-03 spelchat Store the time seed used by deterministic.js. 2018-05-03 eakuefner [Dashboard] Fix logic for add a_tracing_uri to histogram Rows Created with: roll-dep src/third_party/catapult The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=sullivan@chromium.org Change-Id: I501319c30488be9e0cbc503fb353e83097239ef4 Reviewed-on: https://chromium-review.googlesource.com/1043498 Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
-
https://chromium.googlesource.com/angle/angle.git/+log/03bb2231a821..d7b56642c9f7 $ git log 03bb2231a..d7b56642c --date=short --no-merges --format='%ad %ae %s' 2018-04-27 oetuaho Fix blit rect calculations on D3D11 backend 2018-04-28 yizhou.jiang Disable avoid1BitAlphaTextureFormats workaround on Intel Created with: roll-dep src/third_party/angle The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Change-Id: I5aa458b63b2b5306eb85cee35bc146de19a45052 Reviewed-on: https://chromium-review.googlesource.com/1042862Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#555977}
-
Dale Curtis authored
BUG=609890 TBR=alexander.shalamov@intel.com Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ie2ba05773f5f0c929471b3203287a83e17bc6efb Reviewed-on: https://chromium-review.googlesource.com/1036524 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Sergey Volk <servolk@chromium.org> Reviewed-by:
Yuri Wiitala <miu@chromium.org> Reviewed-by:
Olga Sharonova <olka@chromium.org> Cr-Commit-Position: refs/heads/master@{#555976}
-
Fady Samuel authored
Surface synchronization is on in M66 stable for desktop platforms and so we can now safely deleted the old code path. Change-Id: Idbc4859cc01342dcbeca6a9c1b7a381202fe49e6 Reviewed-on: https://chromium-review.googlesource.com/1040866Reviewed-by:
-
Ben Pastene authored
Will all likely fail until I fix crbug.com/839187 This'll at least get them running. Bug: 836447, 832374 Change-Id: I1d206ab931230652b4ba3dc8ba519f386a80da96 Reviewed-on: https://chromium-review.googlesource.com/1043258 Commit-Queue: Ben Pastene <bpastene@chromium.org> Reviewed-by:
Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#555974}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=mmoss@chromium.org Change-Id: Ia7712f84414c21690e9ac5715d37fe8e90a9d557 Reviewed-on: https://chromium-review.googlesource.com/1043472Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#555973}
-
Christopher Lam authored
See go/closure-compile-gn for details. This CL converts the Closure Compilation of chrome://media-router from GYP to GN, and fixes a number of type-checking issues that were somehow suppressed due to the way the compiler used to be run. A local closure compile can be run by setting closure_compile = true in args.gn, and then running ninja -C out/Default webui_closure_compile. A more localized compile may look like: ninja -C out/Default chrome/browser/resources/media_router:closure_compile Bug: 632206 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I3a41ec8701a68ae71fa2a613401daf213c41e0ff Reviewed-on: https://chromium-review.googlesource.com/1036709 Commit-Queue: calamity <calamity@chromium.org> Reviewed-by:
apacible <apacible@chromium.org> Reviewed-by:
calamity <calamity@chromium.org> Cr-Commit-Position: refs/heads/master@{#555972}
-
Dave Tapuska authored
If the Input Method is removed we won't be able to remove the raw observer pointer in the dtor leaving a dangling pointer in the observer list for the input method. BUG=839339 Change-Id: I60f04a8e669415f4ee2dd431e2332d5dd0778b0b Reviewed-on: https://chromium-review.googlesource.com/1042347 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Cr-Commit-Position: refs/heads/master@{#555971}
-
Simeon Anfinrud authored
Although subsequent start() calls to CastWebContentsComponent correspond to foregrounding a fragment, this has no bearing if the ActivityDelegate is used for this component. When CastWebContentsActivity receives a new intent, even with the same WebContents, it will restart the state machine that handles the start parameters, which can cause unexpected side effects. Bug: Internal b/77459373 Test: cast_shell_junit_tests Change-Id: I54a2d9628de4e185df0946291d86eb9553889fda Reviewed-on: https://chromium-review.googlesource.com/1043099Reviewed-by:
Stephen Lanham <slan@chromium.org> Commit-Queue: Simeon Anfinrud <sanfin@chromium.org> Cr-Commit-Position: refs/heads/master@{#555970}
-
Alexander Alekseev authored
This reverts commit fe99bbd3. Reason for revert: broken on Kevin device (https://crbug.com/839672 ) Original change's description: > ozone: drm: Emulate per-CRTC color transform matrix > > On some devices we don't have a per-CRTC color transform matrix, > but we do have a per-plane CTM that is currently not used. > > This CL emulates a per-crtc CTM on those devices. > > Bug: 749250 > Test: Night light on RK3399 > Change-Id: Id5135e00e72085b7890426dca7688d34cf6759f7 > Reviewed-on: https://chromium-review.googlesource.com/1037403 > Commit-Queue: Daniele Castagna <dcastagna@chromium.org> > Reviewed-by: Ahmed Fakhry <afakhry@chromium.org> > Reviewed-by: Miguel Casas <mcasas@chromium.org> > Reviewed-by: Daniel Nicoara <dnicoara@chromium.org> > Cr-Commit-Position: refs/heads/master@{#555571} TBR=dnicoara@chromium.org,mcasas@chromium.org,dcastagna@chromium.org,afakhry@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 749250 Change-Id: I10649350317ccab3dc3d10950e5245578716d033 Reviewed-on: https://chromium-review.googlesource.com/1043228Reviewed-by:
-
chrome://flagsIan Clelland authored
Bug: 837344 Change-Id: Ie1367ed1c12c714bad4d6aa28aa989b2a712c309 Reviewed-on: https://chromium-review.googlesource.com/1030841 Commit-Queue: Ian Clelland <iclelland@chromium.org> Reviewed-by:
-
Hiroshige Hayashizaki authored
This CL imports the async-local-storage implementation as-is except for renaming to index.js. Original author: Domenic Denicola (domenic@chromium.org) https://github.com/domenic/async-local-storage All code were written and contributed by Googlers who are Chromium Contributors. Tentatively this CL imports the files under core/script/resources until a long-term plan for repository location etc. is settled. This is a still experimental feature behind a flag, and its API interface and implementation can be changed significantly before shipped. This CL also imports a test with some modifications. Change-Id: I99944c75240ab2f1d114aa85f5c8ffac1f5e9b98 Reviewed-on: https://chromium-review.googlesource.com/1033713 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#555967}
-
Robert Liao authored
1) C4146 (unary minus operator applied to unsigned type, result still unsigned) for constexpr size_t dynamic_extent = -1; 2) Workarounds for ternary expressions in templates (parens currently needed). BUG= Change-Id: Ia5d4ded07e819589800e957ce8cf369ddd6cd4ac Reviewed-on: https://chromium-review.googlesource.com/1042806Reviewed-by:
-
Khushal authored
The context is allocated an id which is implicitly assumed to be 2 bytes, so it can be encoded in framebuffers/texture ids and used to verify that textures used with a context are allocated by it. This causes overflow issues with fuzzer runs, so wrap around the id once it reaches the max value. R=enne@chromium.org Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: I10c799520be55a310ad90a4dfdb564f805cc3ce5 Reviewed-on: https://chromium-review.googlesource.com/1040878 Commit-Queue: Khushal <khushalsagar@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#555965}
-
Hiroshige Hayashizaki authored
This reverts commit 9a6936e7. Reason for revert: Suspected to cause compile failure on Windows debug builds: https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Win%20Builder%20%28dbg%29/130944 Original change's description: > Refactor AXSnapshotNodeAndroid into mojo. > > Test: browser_tests --gtest_filter=ArcVoiceInteractionArcHomeServiceTest.* > Change-Id: I25e45f2663767d5d7ef20bd8bb5637b077c6eb44 > Reviewed-on: https://chromium-review.googlesource.com/1014464 > Commit-Queue: Muyuan Li <muyuanli@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> > Cr-Commit-Position: refs/heads/master@{#555921} TBR=dmazzoni@chromium.org,sky@chromium.org,dcheng@chromium.org,muyuanli@chromium.org Change-Id: I6b9ad7763f07410278c2aa5ea40b4aacbbe10e75 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/1043187Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/master@{#555964}
-
Hiroshige Hayashizaki authored
This CL imports the virtual-list implementation as-is except for renaming virtual-list-element.js to index.js. Original author: Valdrin Koshi (valdrin@google.com) and Gray Norton (graynorton@google.com) https://github.com/valdrinkoshi/virtual-list All code were written and contributed by Googlers who are Chromium Contributors. Tentatively this CL imports the files under core/script/resources until a long-term plan for repository location etc. is settled. This is a still experimental feature behind a flag, and its API interface and implementation can be changed significantly before shipped. Change-Id: I07071ae2dd17481d3240198f91f28cf0cef5536d Reviewed-on: https://chromium-review.googlesource.com/1031749 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Alex Russell <slightlyoff@chromium.org> Reviewed-by:
Ojan Vafai <ojan@chromium.org> Cr-Commit-Position: refs/heads/master@{#555963}
-
Antonio Gomes authored
This is a preparation CL to migrate GoogleURLTracker from URLFetcher to SimpleURLLoader. BUG=714018 Change-Id: I1ba490d9fea5bf5c23212471f723407de488023f Reviewed-on: https://chromium-review.googlesource.com/1042505 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Maria Khomenko <mariakhomenko@chromium.org> Cr-Commit-Position: refs/heads/master@{#555962}
-
Hiroshige Hayashizaki authored
This is a reland of bde742c2 This reland contains fixes for: - Issue 839236 (by adding a dependency in core/script/BUILD.gn), and - A unit test failure that caused revert https://chromium-review.googlesource.com/1042065 (by adding skip_minify flag as the minifier inserted unexpected newlines to scripts) TBR=kinuko@chromium.org,kouhei@chromium.org Original change's description: > [Layered API] Implement Layered API infrastructure behind a flag > > This CL > 1. Maps std:x|y URLs to std:x (according to the draft spec [1]), > 2. Then maps to std-internal://x/index.js (not spec'ed [2]) > in GetInternalURL(), > 3. Then retrieves and serves the script contents for std-internal: > URLs in GetSourceText() using ui::ResourceBundle() > from blink_resources.pak. > > The source JavaScript files for Layered APIs are placed under > third_party/blink/renderer/core/script/resources/layered_api > and bundled into blink_resources.pak. > > This CL introduces std: and std-internal: schemes that are used in Blink side > (std: is user-facing while std-internal: is mostly invisible for users) > but not outside Blink. > > [1] Spec: > https://github.com/drufball/layered-apis/blob/master/spec.md > [2] Implementation design doc: > https://docs.google.com/document/d/1V-WaCZQbBcQJRSYSYBb8Y6p0DOdDpiNDSmD41ui_73s/edit > > Bug: 829084 > Change-Id: I61fc0a2f17d937db6e859303ab8a84e4b2b87850 > Reviewed-on: https://chromium-review.googlesource.com/1013321 > Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Reviewed-by: Kouhei Ueno <kouhei@chromium.org> > Cr-Commit-Position: refs/heads/master@{#555524} Bug: 829084, 839236 Change-Id: I37ed111cf924b52f5998c1e6a2b6dd7d1965c813 Reviewed-on: https://chromium-review.googlesource.com/1042616 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#555961}
-
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/8f20428bf4dc..848c86e3e858 $ git log 8f20428bf..848c86e3e --date=short --no-merges --format='%ad %ae %s' 2018-05-03 mmoss Make 'gclient_gn_args*' handling consistent between sync and flatten. 2018-05-03 martiniss Revert "Reland "bot_update: Patch on gclient by default."" Created with: roll-dep src/third_party/depot_tools BUG=chromium:825063,chromium:643346 The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: I38178ecfae2023a5ade41d0f584905010540cafb Reviewed-on: https://chromium-review.googlesource.com/1043461 Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#555960}
-
Rohit Rao authored
Switches to TableViewModel instead of a std::vector of BookmarkNodes. BUG=839423 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I0b12b1c22f6f0d229eed79da407df2443081bbfe Reviewed-on: https://chromium-review.googlesource.com/1042349Reviewed-by:
Sergio Collazos <sczs@chromium.org> Commit-Queue: Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#555959}
-
