GitLab

Also add the UMA suffix FromLink, FromOmnibox, and FromChromeInternal
for DefaultAppLaunchSource based on TODO comments.

BUG=1005640

Change-Id: I1ab92d9ea2aabf7afdd9c1b2599b8af349b326df
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1996964Reviewed-by: Alex Ilin <alexilin@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Commit-Queue: Nancy Wang <nancylingwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#730964}

`gn format` recently changed its formatting behavior
for deps, source, and a few other elements when they
are assigned (with =) single-element lists to be consistent
with the formatting of updates (with +=) with single-element.

Now that we've rolled in a GN binary with the change,
reformat all files so that people don't get presubmit
warnings due to this.

This CL was uploaded by git cl split.

R=yoavweiss@chromium.org

Bug: 1041419
Change-Id: I7fff56ed3f06009203fa9cf81fcf4d71577c3b3d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1998314
Auto-Submit: Nico Weber <thakis@chromium.org>
Reviewed-by: Yoav Weiss <yoavweiss@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#730963}

`gn format` recently changed its formatting behavior
for deps, source, and a few other elements when they
are assigned (with =) single-element lists to be consistent
with the formatting of updates (with +=) with single-element.

Now that we've rolled in a GN binary with the change,
reformat all files so that people don't get presubmit
warnings due to this.

This CL was uploaded by git cl split.

R=rajendrant@chromium.org

Bug: 1041419
Change-Id: Ic53a705035bee6656c7195b95295fcf69f4f08d2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1998637
Auto-Submit: Nico Weber <thakis@chromium.org>
Reviewed-by: rajendrant <rajendrant@chromium.org>
Commit-Queue: rajendrant <rajendrant@chromium.org>
Cr-Commit-Position: refs/heads/master@{#730962}

The previous method for disabling these tests didn't work, as the
parameterized prefix was added before the DISABLED_ prefix & gtest
ignored it. This moves the DISABLED_ prefix to the parameterized
prefix.

Bug: 514632
Change-Id: I2fda9d744a4801d70affbf1f066e3e65c7715818
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1995639
Auto-Submit: John Budorick <jbudorick@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#730961}

`gn format` recently changed its formatting behavior
for deps, source, and a few other elements when they
are assigned (with =) single-element lists to be consistent
with the formatting of updates (with +=) with single-element.

Now that we've rolled in a GN binary with the change,
reformat all files so that people don't get presubmit
warnings due to this.

This CL was uploaded by git cl split.

R=sky@chromium.org

Bug: 1041419
Change-Id: I78142fdf2541e1f4a9152b47c71f5acf4f1d314f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1998315
Auto-Submit: Nico Weber <thakis@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#730960}

Failures on these bots lack stace traces, eg:
https://logs.chromium.org/logs/chrome/buildbucket/cr-buildbucket.appspot.com/8892247654280769408/+/steps/interactive_ui_tests/0/logs/Deterministic_failure:_TabDragging__x2f_DetachToBrowserTabDragControllerTest.OffsetForDraggingTab__x2f_0__status_CRASH_/0

That's due to exclude_unwind_tables defaulting to true on official builds.
This will explicitly include them on our official testers (won't affect
any other official build).

Bug: 1041069
Change-Id: Idf568a06939529936fc4cb6e361b1f6a36ca3852
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1996123
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#730959}

`gn format` recently changed its formatting behavior
for deps, source, and a few other elements when they
are assigned (with =) single-element lists to be consistent
with the formatting of updates (with +=) with single-element.

Now that we've rolled in a GN binary with the change,
reformat all files so that people don't get presubmit
warnings due to this.

This CL was uploaded by git cl split.

R=pkasting@chromium.org

Bug: 1041419
Change-Id: I2bffb2735322f74e3b6349a0ec5b597e80191d6e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1997796
Auto-Submit: Nico Weber <thakis@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#730958}

`gn format` recently changed its formatting behavior
for deps, source, and a few other elements when they
are assigned (with =) single-element lists to be consistent
with the formatting of updates (with +=) with single-element.

Now that we've rolled in a GN binary with the change,
reformat all files so that people don't get presubmit
warnings due to this.

This CL was uploaded by git cl split.

R=rouslan@chromium.org

Bug: 1041419
Change-Id: I99ed345f485b53dffd7c56393cb0c5155e3dc7e6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1995792
Auto-Submit: Nico Weber <thakis@chromium.org>
Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#730957}

ResizeObserver notifications are delivered out of order because
observers for the same element are stored in a HeapHashSet, which does
not track insertion order. Using HeapLinkedHashSet mitigates this issue.
Web test to insure correct notification order is also added.

Bug: 1026663
Change-Id: I532c566d16f00bcd60a7164af4f4e6fc22cb881b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992910Reviewed-by: Aleks Totic <atotic@chromium.org>
Commit-Queue: Sahir Vellani <sahir.vellani@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#730956}

`gn format` recently changed its formatting behavior
for deps, source, and a few other elements when they
are assigned (with =) single-element lists to be consistent
with the formatting of updates (with +=) with single-element.

Now that we've rolled in a GN binary with the change,
reformat all files so that people don't get presubmit
warnings due to this.

This CL was uploaded by git cl split.

R=nyquist@chromium.org

Bug: 1041419
Change-Id: I2b170f09acfa44ada72eb0f88ec1a04e512cfc5e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1995791
Auto-Submit: Nico Weber <thakis@chromium.org>
Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Commit-Queue: Tommy Nyquist <nyquist@chromium.org>
Cr-Commit-Position: refs/heads/master@{#730955}

`gn format` recently changed its formatting behavior
for deps, source, and a few other elements when they
are assigned (with =) single-element lists to be consistent
with the formatting of updates (with +=) with single-element.

Now that we've rolled in a GN binary with the change,
reformat all files so that people don't get presubmit
warnings due to this.

This CL was uploaded by git cl split.

R=dcheng@chromium.org

Bug: 1041419
Change-Id: Ifda2bd08230bb9c9403bc8d82f8f97d564b00939
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1997921
Auto-Submit: Nico Weber <thakis@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#730954}

Update the Deep Scanning DLP supported file types to mirror those
currently supported internally.

Change-Id: I93036341678cf4138eba429f0abd327fc800b618
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1991996Reviewed-by: Roger Tawa <rogerta@chromium.org>
Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#730953}

`gn format` recently changed its formatting behavior
for deps, source, and a few other elements when they
are assigned (with =) single-element lists to be consistent
with the formatting of updates (with +=) with single-element.

Now that we've rolled in a GN binary with the change,
reformat all files so that people don't get presubmit
warnings due to this.

This CL was uploaded by git cl split.

R=dbeam@chromium.org

Bug: 1041419
Change-Id: I56203e5f4245372031c8d5120d552a5b33caa9a2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1997764
Auto-Submit: Nico Weber <thakis@chromium.org>
Reviewed-by: Dan Beam <dbeam@chromium.org>
Commit-Queue: Dan Beam <dbeam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#730952}

This is a reland of 834f2092

Now not squashing ERR_NOT_IMPLEMENTED to avoid disrupting existing
InProcessBrowserTests.

Original change's description:
> Squash top level error code returned from host resolver.
>
> If the host resolution process fails, the top level error code should
> now be only ERR_NAME_NOT_RESOLVED. A more specific error code (e.g.
> ERR_CONNECTION_REFUSED if a secure mode DoH server was offline) may be
> found in ResolveErrorInfo.
>
> Bug: 1016325
> Change-Id: I9f5f857fffd71be6485d05280239cd0b649d7a8f
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974678
> Commit-Queue: Katharine Daly <dalyk@google.com>
> Reviewed-by: Matt Menke <mmenke@chromium.org>
> Reviewed-by: John Abd-El-Malek <jam@chromium.org>
> Reviewed-by: Eric Orth <ericorth@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#728725}

Bug: 1016325
Change-Id: If2d029ea94f1a85f95d641cf02e4283973316a98
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992191Reviewed-by: Eric Orth <ericorth@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Katharine Daly <dalyk@google.com>
Cr-Commit-Position: refs/heads/master@{#730951}

`gn format` recently changed its formatting behavior
for deps, source, and a few other elements when they
are assigned (with =) single-element lists to be consistent
with the formatting of updates (with +=) with single-element.

Now that we've rolled in a GN binary with the change,
reformat all files so that people don't get presubmit
warnings due to this.

This CL was uploaded by git cl split.

R=reillyg@chromium.org

Bug: 1041419
Change-Id: I18ccdffc4fc953b70ed6389c0e3f24809f2301ae
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1998649
Auto-Submit: Nico Weber <thakis@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Commit-Queue: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#730950}

This patch requires the infra changed in:
https://chromium-review.googlesource.com/c/chromium/src/+/1988376

Implements the logic required to select the correct baseline from a
child and propagate it to its parent.

This should fix the remaining baseline issues with FlexNG.

Bug: 1038467
Change-Id: I166dcdc5b71f264734924f700e21c99a52786d5f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994064
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Reviewed-by: David Grogan <dgrogan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#730949}

`gn format` recently changed its formatting behavior
for deps, source, and a few other elements when they
are assigned (with =) single-element lists to be consistent
with the formatting of updates (with +=) with single-element.

Now that we've rolled in a GN binary with the change,
reformat all files so that people don't get presubmit
warnings due to this.

This CL was uploaded by git cl split.

R=mfoltz@chromium.org

Bug: 1041419
Change-Id: Ic27e22f6c510f6892da29aa78af3e506c56b092d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1997925
Auto-Submit: Nico Weber <thakis@chromium.org>
Reviewed-by: mark a. foltz <mfoltz@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#730948}

`gn format` recently changed its formatting behavior
for deps, source, and a few other elements when they
are assigned (with =) single-element lists to be consistent
with the formatting of updates (with +=) with single-element.

Now that we've rolled in a GN binary with the change,
reformat all files so that people don't get presubmit
warnings due to this.

This CL was uploaded by git cl split.

R=jhawkins@chromium.org

Bug: 1041419
Change-Id: I8a59a74e2c57daef2143f6328f31798734224409
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1997990
Auto-Submit: Nico Weber <thakis@chromium.org>
Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
Commit-Queue: Ryan Hansberry <hansberry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#730947}

`gn format` recently changed its formatting behavior
for deps, source, and a few other elements when they
are assigned (with =) single-element lists to be consistent
with the formatting of updates (with +=) with single-element.

Now that we've rolled in a GN binary with the change,
reformat all files so that people don't get presubmit
warnings due to this.

This CL was uploaded by git cl split.

R=pkasting@chromium.org

Bug: 1041419
Change-Id: Ib84c89b68833fa71528a3f2977d0dac6893acb0e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1998703
Auto-Submit: Nico Weber <thakis@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#730946}

https://www.w3.org/TR/html-aam-1.0/#html-element-role-mappings

The <area> tag should only be exposed as a Link with the Value Control
Pattern if it has an |href| attribute.

Adjusting the intrinsic role of AXImageMapLink to be Role::kStaticText
if it doesn't have a link.

Bug: 1040717
Change-Id: Icfa1c5e6d97f9bb8514df88b07b3768b36fc0d74
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994525Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Kevin Babbitt <kbabbitt@microsoft.com>
Commit-Queue: Adam Ettenberger <adettenb@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#730945}

`gn format` recently changed its formatting behavior
for deps, source, and a few other elements when they
are assigned (with =) single-element lists to be consistent
with the formatting of updates (with +=) with single-element.

Now that we've rolled in a GN binary with the change,
reformat all files so that people don't get presubmit
warnings due to this.

This CL was uploaded by git cl split.

R=yuweih@chromium.org

Bug: 1041419
Change-Id: I0294a2309b33a72deba3f518f6efad470dc10ab0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1998786
Auto-Submit: Nico Weber <thakis@chromium.org>
Reviewed-by: Yuwei Huang <yuweih@chromium.org>
Commit-Queue: Yuwei Huang <yuweih@chromium.org>
Cr-Commit-Position: refs/heads/master@{#730944}

https://dawn.googlesource.com/dawn.git/+log/15c442e941fb..e5cb8f2eff7e

git log 15c442e941fb..e5cb8f2eff7e --date=short --first-parent --format='%ad %ae %s'
2020-01-13 rharrison@chromium.org Rolling 3 dependencies

Created with:
  gclient setdep -r src/third_party/dawn@e5cb8f2eff7e

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dawn-chromium-autoroll
Please CC cwallez@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel
Bug: None
Tbr: cwallez@google.com
Change-Id: Iacece499b60f27d966c7118f4c6320adca792358
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1998229Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#730943}

Bug: none
Change-Id: Iecd47b49f9f89aa43f36eb3f43388bb8eb3bec59
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1999060
Auto-Submit: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Yury Khmel <khmel@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Commit-Queue: Yury Khmel <khmel@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#730942}

`gn format` recently changed its formatting behavior
for deps, source, and a few other elements when they
are assigned (with =) single-element lists to be consistent
with the formatting of updates (with +=) with single-element.

Now that we've rolled in a GN binary with the change,
reformat all files so that people don't get presubmit
warnings due to this.

This CL was uploaded by git cl split.

R=pkasting@chromium.org

Bug: 1041419
Change-Id: I8505619899bde8bfea8cf098c00ea4aad0e0f990
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1998271
Auto-Submit: Nico Weber <thakis@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#730941}

This config contains the information necessary to configure an
InfobarPasswordModalConsumer.

Bug: 1030357
Change-Id: Ie5d68e53540bbf9f92617c792db2c14653a518c9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1996128
Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#730940}

`gn format` recently changed its formatting behavior
for deps, source, and a few other elements when they
are assigned (with =) single-element lists to be consistent
with the formatting of updates (with +=) with single-element.

Now that we've rolled in a GN binary with the change,
reformat all files so that people don't get presubmit
warnings due to this.

This CL was uploaded by git cl split.

R=khorimoto@chromium.org

Bug: 1041419
Change-Id: If30a489cd751d1764d1caede26136a2ee1dd8626
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1998292
Auto-Submit: Nico Weber <thakis@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#730939}

`gn format` recently changed its formatting behavior
for deps, source, and a few other elements when they
are assigned (with =) single-element lists to be consistent
with the formatting of updates (with +=) with single-element.

Now that we've rolled in a GN binary with the change,
reformat all files so that people don't get presubmit
warnings due to this.

This CL was uploaded by git cl split.

R=pkasting@chromium.org

Bug: 1041419
Change-Id: Icfc1dab6a6aa67f8347ad83de8aa7b94296e4205
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1998667
Auto-Submit: Nico Weber <thakis@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#730938}

Re-enables BrowserMinidumpTest on ChromeOS except for on betty devices,
where the issue that caused the tests to be disabled actually occurs.

TBR=crouleau@chromium.org

Bug: 1038043
Change-Id: I871f98842bc42c925e7cf0c05676d546316b7af1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1997653Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#730937}

This is a reland of 9d870f42

Original change's description:
> Add a field trial config for ChromeStart.
> 
> Bug: 1004441
> Change-Id: I9a5f182b9997fc0b6b61cf2b721d53fbc9c06ebe
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946939
> Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
> Commit-Queue: Matt Simmons <mattsimmons@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#721012}

Bug: 1004441
Change-Id: I0e5a47214bfb0af87f03c84cc42024a0a1a0c79b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1997998Reviewed-by: Ganggui Tang <gogerald@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Commit-Queue: Matt Simmons <mattsimmons@chromium.org>
Cr-Commit-Position: refs/heads/master@{#730936}

`gn format` recently changed its formatting behavior
for deps, source, and a few other elements when they
are assigned (with =) single-element lists to be consistent
with the formatting of updates (with +=) with single-element.

Now that we've rolled in a GN binary with the change,
reformat all files so that people don't get presubmit
warnings due to this.

This CL was uploaded by git cl split.

R=sczs@chromium.org

Bug: 1041419
Change-Id: I57b749d5873cf687718a10adc072f02a9fe94853
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1998653
Auto-Submit: Nico Weber <thakis@chromium.org>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Commit-Queue: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#730935}

`gn format` recently changed its formatting behavior
for deps, source, and a few other elements when they
are assigned (with =) single-element lists to be consistent
with the formatting of updates (with +=) with single-element.

Now that we've rolled in a GN binary with the change,
reformat all files so that people don't get presubmit
warnings due to this.

This CL was uploaded by git cl split.

R=pwnall@chromium.org

Bug: 1041419
Change-Id: I3d2f1d21348882a527c1afd01fafec0fe4f60cc3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1998862
Auto-Submit: Nico Weber <thakis@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Commit-Queue: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#730934}

Bug:1035639

The purpose of this changelist is to help improve the performance on the ui when there is background blur. The related bug is https://bugs.chromium.org/p/chromium/issues/detail?id=1035639
The general idea is to avoid recomputation of a background blur if the damaged regions under the blur surface don't intersect the surface, as any damage coming from above the surface doesn't contribution to the re-calculation of backdrop blur.
A flag can_use_cached_backdrop_filtered_result_ is added to RenderSurfaceImpl to indicate if backdrop filter cache from last update can be used.
The major changes here in this changelist are in DamageTracker and they are quite contained. It will be combined with another couple of changelists on GL side to fulfill the end goal.

Description of the approach:

This changelist is based on the presumption that any render surface has to have at least one layer contributing to it. In other words, in the 'tree' where all layers and surfaces pointing to their respective render targets, leaves can only be layers and vice versa, non-leaves can only be surfaces and vice versa.
Even though the changes here are to serve to performance improvement of backdrop blur filters, they are written in a generic way so you can use the functions for other purposes where you see fit.
To achieve the goal requires the damage tracker to be able to tell if any damage coming from below intersects a rect on the surface in question. This is done through the walk over all layers and surfaces to accumulate damage in DamageTracker::UpdateDamageTracking() [1]. As we know, when anytime we visit a surface in [1], all its ancestor render targets on the chain to the root have already accumulated all the damage from layers and surfaces below this surface. Whether this surface has accumulated damage on top itself is not relevant. So at this point, we only have to walk up the ancestor render target chain to root to see if any damage rect intersects the rect in question (backdrop filter surface rect).
However this is not sufficient, as some layers and render surfaces that were in the previous update can be removed and no longer exist in the current update. If any of these layers and surfaces were below the surface in question, they need to be considered as well. This requires us to know the order of layers and surfaces when they are drawn to the same render target. I call these layers and surfaces siblings and added a prev_sibling_ and next_sibling_ pointers in RectMapData so each layer and surface in rect_history_for_layers_ and rect_history_for_surfaces_ points to both its immediate older and younger siblings. These pointers are to help track the draw order of siblings. When you go through the siblings through the prev_sibling_ pointer one by one, you get all surfaces and layers drawn before the current surface. This is how I did the damage intersection check. (There are more details. Please see code.)
When a new layer or surface is added, the prev_sibling_ and next_sibling_ pointers have to be hooked up. This is done when each layer is iterated in [1]. Since we know the layers are visited once and only once in each update, I hook up the sibling pointers for the new layer when it is visited and walk up its ancestor render target chain to hook up the sibling pointers of each target until root or a target that already had the pointers hooked up. This ensures all layers and surfaces are hooked up.

Possible further improvement:
Backdrop filters sometimes have bounds (or clipping?), so maybe we could
use the bounds or clipped region to do the intersection check with
damage below the surface and the backdrop filter cache thus could take less space.

Change-Id: I27e593ffce0046aa60c3eeca76961ce10e9511ef
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988155
Commit-Queue: Jun Liu <yjliu@chromium.org>
Auto-Submit: Jun Liu <yjliu@chromium.org>
Reviewed-by: weiliangc <weiliangc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#730933}

`gn format` recently changed its formatting behavior
for deps, source, and a few other elements when they
are assigned (with =) single-element lists to be consistent
with the formatting of updates (with +=) with single-element.

Now that we've rolled in a GN binary with the change,
reformat all files so that people don't get presubmit
warnings due to this.

This CL was uploaded by git cl split.

R=reillyg@chromium.org

Bug: 1041419
Change-Id: I9b6e47cc5b373c6e2b186a2185bfec96cbf841e0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1998627
Auto-Submit: Nico Weber <thakis@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Commit-Queue: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#730932}

`gn format` recently changed its formatting behavior
for deps, source, and a few other elements when they
are assigned (with =) single-element lists to be consistent
with the formatting of updates (with +=) with single-element.

Now that we've rolled in a GN binary with the change,
reformat all files so that people don't get presubmit
warnings due to this.

This CL was uploaded by git cl split.

R=pwnall@chromium.org

Bug: 1041419
Change-Id: I4a60f516570499f06808f65541f6209aca04b3c1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1998274
Auto-Submit: Nico Weber <thakis@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Commit-Queue: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#730931}

`gn format` recently changed its formatting behavior
for deps, source, and a few other elements when they
are assigned (with =) single-element lists to be consistent
with the formatting of updates (with +=) with single-element.

Now that we've rolled in a GN binary with the change,
reformat all files so that people don't get presubmit
warnings due to this.

This CL was uploaded by git cl split.

R=pkasting@chromium.org

Bug: 1041419
Change-Id: Ifa634f5939f17473ee3a01f4c4af538c3fa4cfea
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994437
Auto-Submit: Nico Weber <thakis@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#730930}

`gn format` recently changed its formatting behavior
for deps, source, and a few other elements when they
are assigned (with =) single-element lists to be consistent
with the formatting of updates (with +=) with single-element.

Now that we've rolled in a GN binary with the change,
reformat all files so that people don't get presubmit
warnings due to this.

This CL was uploaded by git cl split.

R=khorimoto@chromium.org

Bug: 1041419
Change-Id: If9a6b90958cd60f7d6ac1886553e730cfa87be38
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1998344
Auto-Submit: Nico Weber <thakis@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#730929}

If you start dragging a minimized window from overview and drag to
another display, the shadow bounds are too big, because the window is
visually represented by a WindowPreviewView whose bounds extend outside
the visually occupied area.

Test: ash_unittests DragWindowResizerTest.DragWindowControllerWithCustomShadowBounds
Bug: 961170
Change-Id: Ic0efbb1aa790f72a64d9559e5076ae37a3ff7a5e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1995706Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Commit-Queue: Avery Musbach <amusbach@chromium.org>
Cr-Commit-Position: refs/heads/master@{#730928}

`gn format` recently changed its formatting behavior
for deps, source, and a few other elements when they
are assigned (with =) single-element lists to be consistent
with the formatting of updates (with +=) with single-element.

Now that we've rolled in a GN binary with the change,
reformat all files so that people don't get presubmit
warnings due to this.

This CL was uploaded by git cl split.

R=seantopping@chromium.org

Bug: 1041419
Change-Id: I2fb896607f48bb4ead0f20c016b1d268013caa32
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1997715
Auto-Submit: Nico Weber <thakis@chromium.org>
Reviewed-by: Sean Topping <seantopping@chromium.org>
Commit-Queue: Sean Topping <seantopping@chromium.org>
Cr-Commit-Position: refs/heads/master@{#730927}

`gn format` recently changed its formatting behavior
for deps, source, and a few other elements when they
are assigned (with =) single-element lists to be consistent
with the formatting of updates (with +=) with single-element.

Now that we've rolled in a GN binary with the change,
reformat all files so that people don't get presubmit
warnings due to this.

This CL was uploaded by git cl split.

R=oysteine@chromium.org

Bug: 1041419
Change-Id: Ic9e82356b306e7eb0ec62d5c124f602af0219c7c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1998248
Auto-Submit: Nico Weber <thakis@chromium.org>
Reviewed-by: oysteine <oysteine@chromium.org>
Commit-Queue: oysteine <oysteine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#730926}

`gn format` recently changed its formatting behavior
for deps, source, and a few other elements when they
are assigned (with =) single-element lists to be consistent
with the formatting of updates (with +=) with single-element.

Now that we've rolled in a GN binary with the change,
reformat all files so that people don't get presubmit
warnings due to this.

This CL was uploaded by git cl split.

R=jsbell@chromium.org

Bug: 1041419
Change-Id: I0d5089e4c5ce6d07cbeade73cae75ff7777e5099
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1998641
Auto-Submit: Nico Weber <thakis@chromium.org>
Reviewed-by: Joshua Bell <jsbell@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#730925}