- 22 Sep, 2020 40 commits
-
-
Gavin Williams authored
In destination dialog display red error status text whenever a local CrOS printer has an error printer status. Hide the search-hint <span> when empty to make more room for the error status text. Screenshot: http://screen/rsAqy3dWhECQNyS Bug: 1123754 Change-Id: Ifbbee309b8dee17ad88c4a51923c0f445cf225c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2405711Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Gavin Williams <gavinwill@chromium.org> Cr-Commit-Position: refs/heads/master@{#809435}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/ada5d5129f48..82c70d97576c 2020-09-22 fmayer@google.com Merge "Have separate sampler per heap." If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I40e4aaf295b21fb28ff7be47ff71746a99d72825 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424567Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#809434}
-
Keren Zhu authored
An non-focasable widget will not set its anchor view's kAnchoredDialogKey, but currently a bubble dialog will reset kAnchoredDialogKey when it detaches from its anchor view. This will break the focus traversal path if kAnchoredDialogKey was pointing to a different widget. This CL fixes this issue by resetting kAnchoredDialogKey only if it is pointing to the current bubble. This issue blocks bug 1121399 where a focusable IPH bubble will contest kAnchoredDialogKey of a tab while a non-focusable tab hover card might anchor to it. The hover card will later accidentally detaches the IPH bubble from the tab when it dismisses. Bug: 1121399 Change-Id: Ia7f82ee166eae100cd18ffa816ddf50cf02acba6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422709Reviewed-by:
Wei Li <weili@chromium.org> Commit-Queue: Keren Zhu <kerenzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#809433}
-
Camillo Bruni authored
Change ModuleRecord::ModuleRequests to return directly Vector<ModuleRequest>. This avoids the overhead of two temporary Vectors for source position and specifiers. Remove ModuleRecord::ModuleRequestPositions as it is no longer needed. Bug: 945094 Change-Id: Ie6400e7511f2a5879bbf95223f4eeb021b4ae0c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414288 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Auto-Submit: Camillo Bruni <cbruni@chromium.org> Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#809432}
-
Xiaodan Zhu authored
This CL add system toast for reverse scrolling gesture changes. - If the user perform wrong gestures twice, a system toast will show up to indicate the right gestures. - If the toast shows at the fist time, it will disappear until the user perform the right gesture. Otherwise, it will shows for 2500ms. Bug: 1107183 Change-Id: I1fd3fb9f0c898ca15cae2de87df6e89c7b62aecc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417242 Commit-Queue: Xiaodan Zhu <zxdan@chromium.org> Reviewed-by:
Jun Mukai <mukai@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#809431}
-
David Grogan authored
Old behavior: Use max content contribution for flex base size, which is roughly: use computed width if it exists, otherwise use intrinsic size after applying the aspect ratio and min/main/max height. In either case, apply min/max width. New behavior is similar to the 'max-content' size: use the intrinsic width after applying the aspect ratio and min/main/max height. Ignore computed min/main/max width. Also, we weren't returning available size as the max-content size of an SVG item that only has an aspect ratio and no intrinsic sizes, which is what Firefox does and what the spec dictates. Both of these are fixed with a new aspect-ratio sizing method that currently lives in flex but will be moved to NGReplacedLayoutAlgorithm when it exists. Change-Id: I4afb382a7604a4fcd0626f0702edf72f21cd0bcc Bug: 987000 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399082Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: David Grogan <dgrogan@chromium.org> Cr-Commit-Position: refs/heads/master@{#809430}
-
Dave Tapuska authored
Fix a crash related to change https://chromium-review.googlesource.com/c/chromium/src/+/2418998 Seems there is reentrancy during destruction for pepper plugin instance. Do not access any containers if we've been marked for deletion. This follows the same convention for handling messages. BUG=1130991 Change-Id: I2004265dc5592761c24c957be6231c3a1ad86d2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423271Reviewed-by:
Bill Budge <bbudge@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#809429}
-
Adrienne Walker authored
This is a followup to this patch: https://chromium-review.googlesource.com/c/chromium/src/+/2412834 ...to make the same changes to LocalFileStreamReader that were requested for the FilesystemProxyFileStreamReader in that review. Bug: 1119547 Change-Id: Ibaccd858c807969eb185012add8ab01fed4aad33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422271 Auto-Submit: enne <enne@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#809428}
-
danakj authored
The callers can just do layer->device_scale_factor() themselves. R=sky@chromium.org Bug: 1130050 Change-Id: Iccfd2ae47b4988e3f83868f10f99b61b4be3e0a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419507 Auto-Submit: danakj <danakj@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#809427}
-
Lei Zhang authored
As is, the utility processes launched by the Cloud Print service process are generic utility processes. This worked fine for Cloud Print on Windows until https://crrev.com/748400 limited the sandbox types to do gdi32.dll patching for. To resume gdi32.dll patching, update the utility processes to be of type |kPdfConversion|, which better reflects what they do. Bug: 1128450 Change-Id: Ib2f3bfb688891d628ba798965f3e137ec4490c28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423543Reviewed-by:
Will Harris <wfh@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#809426}
-
rbpotter authored
R=johntlee@chromium.org Fixed: 1130854 Change-Id: I546c0650bb940ce8a92d4cf2a3ea54a309ba1346 Bug: 1130854 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423056Reviewed-by:
John Lee <johntlee@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#809425}
-
Peter Qiu authored
The client is using the supported pixel format reported by the capture device to start capturing, NV12 is supported by some capture devices on Chrome OS and virtual capture devices. So we should allow the client to request NV12 as the capture pixel format. device Bug: b/166284508 Test: Manually on Cast device that use NV12 virtual capture Change-Id: I8fd713ec46c52f49928bed5fedc51bdcc342c855 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416757Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Peter Qiu <zqiu@chromium.org> Cr-Commit-Position: refs/heads/master@{#809424}
-
Sammie Quon authored
Increase the animation layer on each side by a ratio of the root window width. When swiping, users can see this padding if they swipe towards a direction with no more desks (i.e. swipe right at desk 0). Clamps the translation such that the entire animation layer is always visible. Tested that the edge padding does not affect non continuous gestures. Though not seen, the edge padding is there for simplification. Can be easily modified if desired in the future. Test: manual Bug: 1111445 Change-Id: I3b204d8ef1e1648b421310e1aa714346a94959aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417491 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#809423}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/ff52c73e..eb373a50 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I2a9ca78044b2e5367b61e547aa09a1977c2ab881 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424065Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#809422}
-
Dave Tapuska authored
Use the WidgetBase implementations instead of going via the WebWidgetClient. BUG=1097816 Change-Id: Ib08b5748806fe3862ac291d354043326d3172282 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419129Reviewed-by:
danakj <danakj@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#809421}
-
Owen Min authored
In the past, Conflict(409) are used when 1) There are multiple device records for one device id. 2) Database concurrent update exception. Few months ago, the enterprise server began to return the Too Many Request(429) for the second situation above to allow the client side to setup different retry strategies. Policy Fetch and CBCM reporting will retry on 429 but not 409. Chrome OS demo mode will show the error message and retry. Chrome OS enrollment will record a different UMA value. Bug: 1108817 Skip-Translation-Screenshots-Check: True Change-Id: I3b302ab03e16a41a30103f809c1b51813647dd7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419119 Commit-Queue: Owen Min <zmin@chromium.org> Reviewed-by:
Aga Wronska <agawronska@chromium.org> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#809420}
-
Max Curran authored
Previously when navigating through a link from a page that was translated would case the new page to be translated automatically without any UI being shown. Now the normal translate UI will be shown, so that the user knows that the page is being translated. Bug: 1057731 Change-Id: I777955d2b755c212565ed374641eb819e636bd41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422816Reviewed-by:
Megan Jablonski <megjablon@chromium.org> Commit-Queue: Max Curran <curranmax@chromium.org> Auto-Submit: Max Curran <curranmax@chromium.org> Cr-Commit-Position: refs/heads/master@{#809419}
-
David Roger authored
This CL enables the profile switch interception, and adds performance histograms. It supports switching to an existing profile, whether it is already loaded or not. It also adds an histogram to measure the performance of the session startup (which in mainly the time to inject the account on the web). Screenshot: https://screenshot.googleplex.com/95FNoDH6QqSkCcV Note: strings are not finalized and will be updated in a follow-up CL. Bug: 1076880 Change-Id: Ia3ce4a816dc328d032d7660fac199a7a36338429 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416349Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Monica Basta <msalama@chromium.org> Commit-Queue: David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#809418}
-
Chrome Metrics Logs authored
Updates the expires_after attribute for 91 histograms that show frequent access in the past 90 days. These are the 90% most frequently used histograms over that time that do not already have a date later than or within 60 days of 2020-12-21. TBR=chromium-metrics-reviews@google.com Change-Id: I3eb8a8b903a4d423a43ffd0216aefe5eaf86a50f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424484Reviewed-by:
Chrome Metrics Logs <chrome-metrics-team+robot@google.com> Commit-Queue: Chrome Metrics Logs <chrome-metrics-team+robot@google.com> Cr-Commit-Position: refs/heads/master@{#809417}
-
Roman Arora authored
Bug: 1099917 Change-Id: I33b7700dc218308af87373722afe7c7639f5cb8f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417074 Commit-Queue: Roman Arora <romanarora@chromium.org> Reviewed-by:
Thomas Lukaszewicz <tluk@chromium.org> Cr-Commit-Position: refs/heads/master@{#809416}
-
Mirko Bonadei authored
Chromium iOS recipes seem to be based on generic recipes like for example [1] nowadays. This is a follow-up of https://chromium-review.googlesource.com/c/chromium/tools/build/+/2418820. [1] - https://source.chromium.org/chromium/chromium/tools/build/+/master:recipes/recipes/chromium_trybot.py Bug: webrtc:11604 Change-Id: I3abc8b53f79ff5ca27fc9f2b965f611e396eeaf7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2420609Reviewed-by:
Dirk Pranke <dpranke@google.com> Commit-Queue: Mirko Bonadei <mbonadei@chromium.org> Cr-Commit-Position: refs/heads/master@{#809415}
-
Mitsuru Oshima authored
Bug: 1123889 Test: manual. see bug for repro step. Change-Id: I3f99b00ccb6478a1bdc1dc871827a48e8560911f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422866Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#809414}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/9f82884d032c..f46b7d67f8f2 2020-09-22 cpinnamaneni@microsoft.com Network sort requests on type If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1130839 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ic0695c0ce4cf998d3d58d8b12492c6f0af92099d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424564Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#809413}
-
Chrome Metrics Logs authored
Updates the expires_after attribute for 2 histograms that have been used to generate alerts in the past 90 days and do not already have a date later than or within 60 days of 2020-12-21. TBR=chromium-metrics-reviews@google.com Change-Id: Iacab9b2d240b398566ad36946caac6473e9b9cbb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423171Reviewed-by:
Chrome Metrics Logs <chrome-metrics-team+robot@google.com> Commit-Queue: Chrome Metrics Logs <chrome-metrics-team+robot@google.com> Cr-Commit-Position: refs/heads/master@{#809412}
-
chromium-internal-autoroll authored
Release_Notes: http://go/media_app-x20/relnotes/Main/media_app_202009220800_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/media_app/app/+/u9IxXetAD5rBCs-E3qW49qhhcWCVkh51yLFjLWQfwOIC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/media-app-chromium-autoroll Please CC media-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: b/138961540,b/165872577,b/168547738 Tbr: media-app@grotations.appspotmail.com Change-Id: I72b1d5a7241225e24308c8663c6332eebb3d5c66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423979Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#809411}
-
Haiyang Pan authored
According the query https://console.cloud.google.com/bigquery?sq=575346572923:aac7a4bc484d424f93a1f65b7000c6cb, unit_tests has the second highest failure count. Also move the chrome_public_test_apk to MM-x86-rel-non-cq Bug: 997376, 1127110 Change-Id: I1ca4a1250233fe0cf1d0615f3580ccc10ba01ed4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422710 Auto-Submit: Haiyang Pan <hypan@google.com> Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#809410}
-
Alexandre Courbot authored
V4L2Request::ApplyCtrls(), which is called on the next line, will do this for us. BUG=None TEST=video.DecodeAccel.h264 passes on Kukui. Change-Id: I34196a4d65c03a0bec7da87854d226b8905b3027 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421992 Commit-Queue: Fritz Koenig <frkoenig@chromium.org> Reviewed-by:
Fritz Koenig <frkoenig@chromium.org> Cr-Commit-Position: refs/heads/master@{#809409}
-
Adlai Holler authored
Change-Id: Ic258eb1562dc776805d1530c480493b0739ffba1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423062 Auto-Submit: Adlai Holler <adlai@google.com> Commit-Queue: Florin Malita <fmalita@chromium.org> Reviewed-by:
Florin Malita <fmalita@chromium.org> Cr-Commit-Position: refs/heads/master@{#809408}
-
Xida Chen authored
We are deprecating the Universal throughput tracker. The first CL has been landed here: https://chromium-review.googlesource.com/c/chromium/src/+/2392768 Both UMA and UKM xml files has been updated where the related metrics are marked as deprecated. But the UKM reporting code isn't removed yet. This CL removed the code. It is basically a manual revert of the following CL: https://chromium-review.googlesource.com/c/chromium/src/+/2112953 Bug: 1128993 Change-Id: I2bb040fb4a0edf31aea3b304dbd60c91c95acae5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418804Reviewed-by:
vmpstr <vmpstr@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Reviewed-by:
Steve Kobes <skobes@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#809407}
-
chromium-internal-autoroll authored
Release_Notes: http://go/help_app-x20/relnotes/Main/help_app_nightly_202009220800_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/help_app/app/+/mkV9yCGYkfTE2DLD-MHNfrrbpo8vMhrcvgRQwtJGUjMC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/help-app-chromium-autoroll Please CC help-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: b/165375429 Tbr: help-app@grotations.appspotmail.com Change-Id: I39db595f59d99ebdabca1fe9a693e5343486360e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424406Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#809406}
-
George Burgess IV authored
It seems that this constructor call was intended to be used as a scope guard. In order for that to happen, there has to be a variable name here. Bug: 1130379 Change-Id: Ibc40863e1cfe31616b18c304358274ba89ba9bf9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2420919Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Commit-Queue: George Burgess <gbiv@chromium.org> Cr-Commit-Position: refs/heads/master@{#809405}
-
Alexandre Courbot authored
We were using SetFormat() when we wanted to just test the availability of a given format on a device. This is a bit misleading for the reader. Implement and use TryFormat(), which properly uses the TRY_FORMAT ioctl, and use it where relevant. BUG=None TEST=video.DecodeAccel.h264 passed on Trogdor Change-Id: I223a2911451bae753e8560180ccdaa5a3502a1db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422103 Commit-Queue: Fritz Koenig <frkoenig@chromium.org> Reviewed-by:
Fritz Koenig <frkoenig@chromium.org> Auto-Submit: Alexandre Courbot <acourbot@chromium.org> Cr-Commit-Position: refs/heads/master@{#809404}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/77960d9addc8..a9be76de8b43 2020-09-22 johnstiles@google.com Reduce the number of inliner temporaries by swizzling. 2020-09-22 johnstiles@google.com Calculate texture clamping X/Y coordinates in parallel. 2020-09-22 fmalita@chromium.org Fix skia_use_ffmpeg builds 2020-09-22 brianosman@google.com Change default of fBuiltinFMASupport back to false 2020-09-22 michaelludwig@google.com Use analytic coverage FPs with MSAA 2020-09-22 brianosman@google.com Remove RTAdjust plumbing If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC csmartdalton@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: csmartdalton@google.com Change-Id: I67e2fe58ef1d8f1c463aa289b3177bd8b4c6630d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424410Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#809403}
-
Andrew Grieve authored
Removes direct usage (StrictModeContext left for follow-up) These suppressions are safe to remove now that StrictMode handling in chrome has been switched to a filter-based approach. Bug: 1038384 Change-Id: I59ee33bd1e34249c6be7973e5d759007ec0b2533 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410537 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Peter Kotwicz <pkotwicz@chromium.org> Cr-Commit-Position: refs/heads/master@{#809402}
-
Tommy Li authored
Adds all three shown header variations, as well as the default-hidden header variation, for a total of 4. I'm doing this because Android users, and our off-corp tester team cannot use the Google Experimental Web interface. Bug: 1106096 Change-Id: Ie87ea1c36afc3983dc8221d5ef7c695a54e6c60a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422473Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#809401}
-
Maria Kazinova authored
Created a feature and a flag to experiment with using numeric renderer IDs instead of string form and field identifiers in Autofill filling logic. Bug: 1075444, 1131038 Change-Id: I8a3110d3271028d5a347dbea21c6031274955e76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418331 Commit-Queue: Maria Kazinova <kazinova@google.com> Reviewed-by:
Matthias Körber <koerber@google.com> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#809400}
-
Leonid Baraz authored
The server is free to process Records in arbitrary order, and timestamp will allow to rearrange them according to the order they were enqueued by the Client device. Change-Id: I3df98f61b4dfa67933eef322dc2959dd28c3d17b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422721 Commit-Queue: Leonid Baraz <lbaraz@chromium.org> Reviewed-by:
Zach Trudo <zatrudo@google.com> Cr-Commit-Position: refs/heads/master@{#809399}
-
Rob Buis authored
Add helper methods to NGLayoutInputNode to test whether the input node is MathML and to get the DOM node for the wrapped layout object. Bug: 6606 Change-Id: I4b12e81b2c044e9bd98479c1ab0cf8f0c7cea898 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424183 Commit-Queue: Rob Buis <rbuis@igalia.com> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#809398}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ac231dd664d0..899ea244a8db If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC lgrey@google.com,rsorokin@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: lgrey@google.com,rsorokin@google.com Change-Id: If311234950ce6fa90f4f711d681c8cbc21b736aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423978Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#809397}
-
Michael Thiessen authored
Migrates NavigationHandle to use GURL internally and adds getUrlString for callsites that still need URLs to be a string (to be fixed in followups). Some unit tests needed to be moved to Instrumentation tests, one requiring a change to CriteriaHelper to allow checking for a condition after every task. QualityEnforcerUnitTest was too difficult to migrate to Instrumentation tests, so it now uses JUnitTestGURLs to use GURL in junit tests. Bug: 783819 Change-Id: I1283d5d7d1946e666e964f8d24aeaf0352eb8805 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419140Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#809396}
-