GitLab

The command-line will now be populated from
/data/cast/castagent-command-line.

Bug: b/122267826
Test: Add command-line to show verbose logging, cast_shell_unittests
Change-Id: I741a1a32e59bea07a2ce857d24df57712cf32761
Reviewed-on: https://chromium-review.googlesource.com/c/1396135
Commit-Queue: Aidan Wolter <awolter@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Reviewed-by: Yuchen Liu <yucliu@chromium.org>
Reviewed-by: Sergey Volk <servolk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625457}

Bug: crbug.com/916420
Change-Id: Ie56c05165aa2398cc10c046923c0799b43fe700c
Reviewed-on: https://chromium-review.googlesource.com/c/1432413Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Michael Martis <martis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625456}

Currently the 'Usage' showing on site details page didn't show all the
web storage data. This CL updates the data fetching and clearing to use
CookiesTreeModel to show and clear all the storage data for a origin.

BUG=922355

Change-Id: Ia06a18d561471f1a0cc1d18d0fc558881f984027
Reviewed-on: https://chromium-review.googlesource.com/c/1424678
Commit-Queue: Maggie Cai <mxcai@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Patti <patricialor@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Reviewed-by: Joshua Bell <jsbell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625455}

https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Headers.git/+log/79b6681aadcb..f3abb280c2aa


git log 79b6681aadcb..f3abb280c2aa --date=short --no-merges --format='%ad %ae %s'
2019-01-23 johnkslang@users.noreply.github.com Merge pull request #91 from LukasBanana/master


Created with:
  gclient setdep -r src/third_party/spirv-headers/src@f3abb280c2aa

The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-headers-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: I3343e5299b98f9615c5a1bf3a483982fb8b30ac6
Reviewed-on: https://chromium-review.googlesource.com/c/1431840Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#625454}

We don't consider document markers when calculating visual overflow,
so we should not paint outside of the line box. Previously, we painted
outside so bad things happened (e.g. under invalidation).

Bug: 896985
Change-Id: Id551e501fc273bbcb7c238a8f8c34d5c50fd2e96
Reviewed-on: https://chromium-review.googlesource.com/c/1429625
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625453}

Specific changes:
 * Provide constants to use in place of raw bools when calling Navigate() in the unit test. This makes it a bit easier to determine what the call does without scrolling up and looking at the method.
 * Replace ASSERT_* to EXPECT_*. None of these conditions prevent the test from continuing, so it should be allowed to do so in case it uncovers more errors.
 * Make getters const.

Change-Id: I933daa3820d0b3dc957212a0d2a2fc88251538dc
Reviewed-on: https://chromium-review.googlesource.com/c/1419438Reviewed-by: Mike Pinkerton <pinkerton@chromium.org>
Commit-Queue: Aran Gilman <gilmanmh@google.com>
Cr-Commit-Position: refs/heads/master@{#625452}

When go/herd-immunity (Google internal doc) extension is enabled,
unelide URLs and turn off Query in Omnibox. We're choosing to hard-code
the extension id since only one extension needs this, and we don't need
the added complexity of making this an extension API.

Bug: 914422
Change-Id: I1c8f3ddd6f236d2812adad6272225aa07d47fb54
Reviewed-on: https://chromium-review.googlesource.com/c/1415751
Commit-Queue: Livvie Lin <livvielin@chromium.org>
Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625451}

BUG=none
TEST=none

Change-Id: I666ee290ff4182844c2862cd9ae4a2ec6274021f
Reviewed-on: https://chromium-review.googlesource.com/c/1432393
Commit-Queue: Scott Violet <sky@chromium.org>
Commit-Queue: danakj <danakj@chromium.org>
Auto-Submit: Scott Violet <sky@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625450}

This component is only used by iron-input which in turn is only used
on CrOS.

Bug: 899982
Change-Id: Ib10e1bc77f143591882aefde0e039907cd722568
Reviewed-on: https://chromium-review.googlesource.com/c/1432679Reviewed-by: Esmael El-Moslimany <aee@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625449}

The class base::NoDestructor is a simpler way to define a static
global value (aka a singleton) than base::{LazyInstance,Singleton}
and is the recommended pattern to use.

The changes were automated using a custom one-shot script, then
fine tuned by hand (to remove unnecessary classes, ...).

This fixes usages in src/ios/chrome/browser/update_client.

This CL was uploaded by git cl split.

Bug: none
Change-Id: I3eb76f475aa91dd3af90b69c17a1620b5bbbe0cc
Reviewed-on: https://chromium-review.googlesource.com/c/1426697
Auto-Submit: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625448}

TBR=mpearson@chromium.org
This is a reland of 3244db37

Original change's description:
> Add FieldTrial Testing config for Company Name Test in Beta
>
>
> Bug: 890972
> Change-Id: Ib1aad147f260a1fd84df4d6ad9fc761742e16491
> Reviewed-on: https://chromium-review.googlesource.com/c/1385547
> Reviewed-by: Theresa <twellington@chromium.org>
> Reviewed-by: Ganggui Tang <gogerald@chromium.org>
> Reviewed-by: Mark Pearson <mpearson@chromium.org>
> Commit-Queue: Jeffrey Cohen <jeffreycohen@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#622647}

Bug: 890972
Change-Id: I63e7c059bc4d2d3d0cf8ba390a95394566c43a15
Reviewed-on: https://chromium-review.googlesource.com/c/1427101Reviewed-by: Mark Pearson <mpearson@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Reviewed-by: Roger McFarlane <rogerm@chromium.org>
Commit-Queue: Jeffrey Cohen <jeffreycohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625447}

These tests are now passing with the updated Java tests.

Bug: chromedriver:2748
Bug: chromedriver:2664
Change-Id: I8dc3885410104c663e99f809de4de47a1c9e1dbc
Reviewed-on: https://chromium-review.googlesource.com/c/1432054Reviewed-by: John Chen <johnchen@chromium.org>
Commit-Queue: Artur Khachatryan <khachatryan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625446}

Bug: 845780
Change-Id: I07e73631ec2ebb363f4ab96d1b6489006692054b
Reviewed-on: https://chromium-review.googlesource.com/c/1432412
Commit-Queue: Yuichiro Hanada <yhanada@chromium.org>
Auto-Submit: Darren Shen <shend@chromium.org>
Reviewed-by: Yuichiro Hanada <yhanada@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625445}

This provides styling for mathematical equations.

Bug: 920396
Change-Id: I7c11f2a55da20d69d4697094072f9596be8d6298
Reviewed-on: https://chromium-review.googlesource.com/c/1422298Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Ender <ender@google.com>
Auto-Submit: Ender <ender@google.com>
Cr-Commit-Position: refs/heads/master@{#625444}

The sync service API is exposed by the syncer::SyncService interface
and browser_sync::ProfileSyncService is an implementation of it. The
code should prefer to use the abstract interface (for one, testing
is easier as the surface to mock is smaller) instead of a particular
concrete implementation.

This change both factories in src/ios to return a syncer::SyncService
and port client code that could not use syncer::SyncService to access
the service as browser_sync::ProfileSyncService via dedicated methods.

Those methods will eventually be removed once there are alternative
way to access the corresponding API (either because it is moved to a
separate service, or moved to the syncer::SyncService interface).

Bug: 924508
Change-Id: I49db34ea7c79ef7b6165eb6d51f03b0af0394b41
Reviewed-on: https://chromium-review.googlesource.com/c/1429939
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625443}

- http/tests/devtools/layers/layer-compositing-reasons.js
  When it failed, the text difference was:
   +ERROR: No layer for iframe
   -Compositing reasons for iframe#iframe: iFrame
  which means that the iframe is not composited when we dump the
  compositing reasons.
  This is probably a synchronization issue, but instead of fixing
  the issue, I removed the iframe from the test because
  1. the other layers already provide enough test coverage of the
     compositing reasons feature of devtools,
  2. whether the iframe is composited is not a matter of the test,
     but compositing tests to test, and
  3. CompositeAfterPaint no longer needs to composite iframes
     containing composited contents

- http/tests/devtools/layers/layer-scroll-rects-get.js
  When it failed, the touch action rects were missing.
  Let the page wait one additional frame to ensure the touch
  action rects are updated.

Bug: 794180,859169
Change-Id: I633bc0db1c9ff848d51182b5222fbaf82920250a
Reviewed-on: https://chromium-review.googlesource.com/c/1423931
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625442}

Bug: 915791
Change-Id: I27bad3cd49bf5c3036a09c73f9139886e3955cdf
Reviewed-on: https://chromium-review.googlesource.com/c/1380941Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Reviewed-by: Gang Wu <gangwu@chromium.org>
Commit-Queue: Brandon Wylie <wylieb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625441}

Delete deprecated ScopedAllowWait and remove related friendship in
ThreadRestrictions.

Bug: 766678
Change-Id: I25c33b87150c6dbfb3325c4591d34919b975e59d
Reviewed-on: https://chromium-review.googlesource.com/c/1417790Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Reviewed-by: Etienne Pierre-Doray <etiennep@chromium.org>
Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625440}

This warning is incorrect when cpplint is run on Objective-C headers.

This CL also adds an explicit "verbose" config, which shouldn't
change behavior, but explicit is better than implicit.

Bug: 924509
Change-Id: I39f35926ae799fc1c03947a2320590932757d4bc
Reviewed-on: https://chromium-review.googlesource.com/c/1431892Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org>
Commit-Queue: Quinten Yearsley <qyearsley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625439}

As discussed in the bug, the condition under DCHECK is legitimate, and
the existing code does no harm in this case.

Bug: 923806
Change-Id: I5c46ac94174ba91184d6a5dad46702899abef95e
Reviewed-on: https://chromium-review.googlesource.com/c/1431613
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625438}

This is a reland of 41e54be1

One of the checks is converting the times from ms->s. In practice
seconds is plenty precise but in the test 800ms ended up being 0,
so increase it to 1000ms (similar to ImpressionCountResetsAfterTimeout
which was not flaky).

Original change's description:
> [NTP] Cap search suggestion impressions
>
> The parameters for capping suggestions impressions are provided as part
> of the update proto. Read and update the local pref on each fetch. Use
> these prefs to determine if the impression cap has been reach or if
> fetching is frozen due to an empty response.
>
> Bug: 904565
> Change-Id: Ib5539a99f18e9da2ac1223ecc7aff65cb909bca8
> Reviewed-on: https://chromium-review.googlesource.com/c/1395188
> Commit-Queue: Kyle Milka <kmilka@chromium.org>
> Reviewed-by: Kristi Park <kristipark@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#624994}

Bug: 904565
Change-Id: I424cb51d2a9c1738c0e5168f58ef52b73ed4b223
Reviewed-on: https://chromium-review.googlesource.com/c/1431472Reviewed-by: Kristi Park <kristipark@chromium.org>
Commit-Queue: Kyle Milka <kmilka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625437}

This includes formatting the files with clang-format, adding and rewriting comments to make the code easier to understand, and adding/removing includes.

Change-Id: I91395c1974f8ad68a2fd0245c2362fe6d1803ddc
Reviewed-on: https://chromium-review.googlesource.com/c/1423091
Commit-Queue: Aran Gilman <gilmanmh@google.com>
Reviewed-by: Mike Pinkerton <pinkerton@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625436}

The previous browser tests CL got reverted twice due to flaky tests,
so I will try to break the browser tests into several CLs. Listed the
following tests to be added in the TODO in the browser tests file.


Bug: 897998
Change-Id: Ib3c99de27028530e2f8bce7b616d7d5a9dae4cd3
Reviewed-on: https://chromium-review.googlesource.com/c/1364695
Commit-Queue: Siyu An <siyua@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Reviewed-by: Jared Saul <jsaul@google.com>
Cr-Commit-Position: refs/heads/master@{#625435}

This CL removes AccountTrackerService from IdentityAPI and
uses IdentityManager instead of it.

Bug: 922750, 922751
Change-Id: Ibb4f2cd90fd9439b0889f25608d8491d110dcba0
Reviewed-on: https://chromium-review.googlesource.com/c/1429883Reviewed-by: David Roger <droger@chromium.org>
Commit-Queue: Julie Jeongeun Kim <jkim@igalia.com>
Cr-Commit-Position: refs/heads/master@{#625434}

Also remove people who have switched teams.

Change-Id: I097dbec4407f157ad640a1782e75a33f6b992990
Reviewed-on: https://chromium-review.googlesource.com/c/1428093Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Caleb Rouleau <crouleau@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625433}

https://android.googlesource.com/platform/external/perfetto.git/+log/3eabfafdae1e..843e4c41417f


git log 3eabfafdae1e..843e4c41417f --date=short --no-merges --format='%ad %ae %s'
2019-01-23 ilkos@google.com Strip newlines from atrace events


Created with:
  gclient setdep -r src/third_party/perfetto@843e4c41417f

The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG=chromium:b/123286408
TBR=perfetto-bugs@google.com

Change-Id: Icc63d470266d5dfbae56bd38ce68227e44732bd6
Reviewed-on: https://chromium-review.googlesource.com/c/1432532Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#625432}

As per crbug640232, RecordCorruptionInfo's method of writing a
corruption report to a file is modified from making a file and then
writing to it to writing it atomically using ImportantFileWriter's
WriteFileAtomically method to avoid issues involving interruption of
the file write between file creation and actual writing of the record.

Bug: 640232
Change-Id: I69aad54da0c341528dbcf46ebf5a2b08cc3270f6
Reviewed-on: https://chromium-review.googlesource.com/c/1419261Reviewed-by: Daniel Murphy <dmurph@chromium.org>
Commit-Queue: Andreas Butler <andreasbutler@google.com>
Cr-Commit-Position: refs/heads/master@{#625431}

This CL updates the uses of WebXR API in test pages.
Additionally, there is an update needed in webxr-version-shim.js.

Change-Id: If50624de7fed88c612751f709397755344e467c1
Reviewed-on: https://chromium-review.googlesource.com/c/1431915
Commit-Queue: Piotr Bialecki <bialpio@chromium.org>
Reviewed-by: Klaus Weidner <klausw@chromium.org>
Reviewed-by: Bill Orr <billorr@chromium.org>
Auto-Submit: Piotr Bialecki <bialpio@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625430}

components_perftests and views_perftests run on the CQ
and use run_performance_tests_wrapper.py. This changelist
migrates them to use run_performance_tests.py. This migration
unblocks deleting run_gtest_perf_test.py (and then all the
perf tests use run_performance_tests.py as their runner,
which then allows us to finally delete
run_performance_tests_wrapper.py.)

Note that I also needed to add a slash at the end of
a target for components/BUILD.gn since I was getting the
error
"Input directory [...]src/components/subresource_filter/
core/common/perftests/data must have a trailing slash
"

CC=​​​​​​tapted@chromium.org
R=johnchen@chromium.org,eyaich@chromium.org
TBR=blundell@chromium.org

Bug: 924351
Change-Id: I9f4542c22b72d45176574d379ed4eaedf6eb8e92
Reviewed-on: https://chromium-review.googlesource.com/c/1428090
Commit-Queue: Caleb Rouleau <crouleau@chromium.org>
Reviewed-by: Ben Pastene <bpastene@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Reviewed-by: Caleb Rouleau <crouleau@chromium.org>
Reviewed-by: John Chen <johnchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625429}

UrlFetchRequestBase::WriteFileData was using an invalid
base::StringPiece object. This was because the StringPiece
passed to OnDataReceived is only guaranteed to be valid
for the duration of the call, but was being posted to
another task runner. This fixes this bug by creating a copy
of the file data.

Bug: 905097
Change-Id: I335d4ddce29b21f4b7fcd6d686b1de20d3bdad47
Reviewed-on: https://chromium-review.googlesource.com/c/1431692Reviewed-by: Stuart Langley <slangley@chromium.org>
Commit-Queue: Chris Mumford <cmumford@google.com>
Cr-Commit-Position: refs/heads/master@{#625428}

Currently the All Sites page |siteGroupMap| will not repopulate when we
click the back button from the Site Details page. This CL populates the
site list data whenever the All Sites route is navigated.

This CL also simplifies the |siteGroupMap| updating mechanism. Since the
site list sent from the backend will always include permissions and
storage, we can simply in-place update the |siteGroupMap| when a new list
is fetched.

BUG=835712

Change-Id: If8c6d8ae5092cfaa7b85dd49527c478243cddf86
Reviewed-on: https://chromium-review.googlesource.com/c/1428622Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Patti <patricialor@chromium.org>
Commit-Queue: Maggie Cai <mxcai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625427}

Follow-up work includes adding "setUpOnlineDemoMode" in oobe.py.

oobe.py uses md_login_shared.js instead of oobe.js as the entry point
for autotests.

Bug: 870049
Change-Id: I97afc5e5aac16c8ff83f168af4c63b0e0439f3d2
Reviewed-on: https://chromium-review.googlesource.com/c/1431479Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625426}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/5f9f137868bd..80e56cb3f138


Created with:
  gclient setdep -r src-internal@80e56cb3f138

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=mmoss@chromium.org

Change-Id: I6e4614f5e3d16c03edb451e97dc5d41ea74e548f
Reviewed-on: https://chromium-review.googlesource.com/c/1432513Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#625425}

shouldInterceptRequest callback should not be called for special
android URLs, unless they fail to load. Special android urls are
urls such as "file:///android_asset/", "file:///android_res/"
or "content:" scheme urls.

Fixed tests:
-AwContentsClientShouldInterceptRequestTest.testNotCalledForExistingAsset
-AwContentsClientShouldInterceptRequestTest.testNotCalledForExistingContentUrl
-AwContentsClientShouldInterceptRequestTest.testNotCalledForExistingResource

BUG=893566,841556

Cq-Include-Trybots: master.tryserver.chromium.android:android_mojo
Change-Id: I1fd6275194d2ee2d09822896f53626e96789ff32
Reviewed-on: https://chromium-review.googlesource.com/c/1424892Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Tobias Sargeant <tobiasjs@chromium.org>
Commit-Queue: Tim Volodine <timvolodine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625424}

There is no way for a FlingingRenderer (which corresponds 1:1 with a
video playing remotely on a cast device) to signal to WMPI that an
external device has paused/resumed the video.

This CL adds the necessary plumbing for FlingingRenderer to send state
changes back to media::Pipeline, via the RendererClient interface.

Two follow up CLs are planned: adding OnRemotePlayStateChange to
Pipeline::Client, and adding the logic to keep WMPI's play/pause state
in sync with the externally playing video.

Bug: 790766
Change-Id: I85bb77d85000d7913bc9e7f52048daf527e1c8c7
Reviewed-on: https://chromium-review.googlesource.com/c/1412806Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
Reviewed-by: Dan Sanders <sandersd@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Commit-Queue: Thomas Guilbert <tguilbert@chromium.org>
Auto-Submit: Thomas Guilbert <tguilbert@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625423}

It is very similar to the one in current StubbedProvider

Bug: 728297
Change-Id: I6df1af44ac2746acdc23d5ae0f095ced5951132c
Reviewed-on: https://chromium-review.googlesource.com/c/1419857
Commit-Queue: Yun Liu <yliuyliu@google.com>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625422}

safety_net_id field is still unset.
Added a TODO for that.

R=drubery

Bug: 907280
Change-Id: Ic6b78615aeb79e7cb5e07c741d30a312e50e6640
Reviewed-on: https://chromium-review.googlesource.com/c/1422741
Commit-Queue: Varun Khaneja <vakh@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Reviewed-by: Daniel Rubery <drubery@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625421}

This reverts commit cb521877.

Reason for revert: causing compile errors on ios bots:

https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/ios-device/112397

Original change's description:
> CC: Support YUV images in PaintImage and GpuImageDecodeCache
> 
> This patch modifies PaintImage to have an interface to indicate
> that the underlying image is YUV pixel format and adds a
> corresponding DecodeYuv() method.
> 
> In GpuImageDecodeCache, this change adds "is YUV" variables/getters to
> DecodedImageData, UploadedImageData (has_yuv_planes()), and ImageData,
> as well as base:Optional arrays for the SkImages and GL texture IDs for
> each Y, U, and V plane in the relevant places.
> 
> The YUV decoding path will initially be implemented for in-process
> GPU rasterization and later for OOPR (Out of Process Rasterization).
> Changes that affect WebP decoding in Blink will be hidden behind a flag called
> kDecodeLossyWebPImagesToYUV.
> 
> Finally, because this decides whether to YUV decode based on
> the result of PaintImageGenerator::QueryYUVA8, we separately modified
> JPEGImageDecoder::CanDecodeToYUV (crrev.com/c/1400764) and
> VideoImageGenerator::QueryYUVA8 (crrev.com/c/1418322)
> to return false in order to avoid prematurely going down the YUV decode path.
> 
> See bit.ly/webp-decoding-into-yuv for the design document and
> crrev.com/c/1338461 for a working prototype CL.
> 
> Bug: 900672
> Change-Id: I14f60d83cc2da2382e3da296fab598597b7e8ec8
> Reviewed-on: https://chromium-review.googlesource.com/c/1368687
> Reviewed-by: Miguel Casas <mcasas@chromium.org>
> Reviewed-by: Khushal <khushalsagar@chromium.org>
> Commit-Queue: Madeleine Barowsky <mbarowsky@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#625406}

TBR=scroggo@chromium.org,ccameron@chromium.org,mcasas@chromium.org,dcastagna@chromium.org,khushalsagar@chromium.org,jvanverth@chromium.org,ericrk@chromium.org,andrescj@chromium.org,mbarowsky@chromium.org

Change-Id: I5b67ca61424074b5d51c33692071a4306803c283
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 900672
Reviewed-on: https://chromium-review.googlesource.com/c/1432878Reviewed-by: Tommy Steimel <steimel@chromium.org>
Commit-Queue: Tommy Steimel <steimel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625420}

Remove kcarattini@ and miguelg@, and instead, add hkamila@ and engedy@
for the following histograms:

Permissions.Action.*
ContentSettings.PermissionRequested*

Bug: None
Change-Id: I015402bf77edcf5e6a250ea3f2244eb87638a37a
Reviewed-on: https://chromium-review.googlesource.com/c/1430240Reviewed-by: Brian White <bcwhite@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Commit-Queue: Balazs Engedy <engedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625419}

- Add helper functions to differentiate getting preconfigured share
  paths for both dropdown and premount modes.

Bug: chromium=878502
Test: compiles
Change-Id: I62f5811e2f320a54b783abfdb9b0ffd719abc68a
Reviewed-on: https://chromium-review.googlesource.com/c/1407658
Commit-Queue: jimmy gong <jimmyxgong@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Bailey Berro <baileyberro@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625418}