- 02 Aug, 2014 40 commits
-
-
blink-deps-roller@chromium.org authored
http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=179329:179430&mode=html TBR=alancutter@chromium.org,pdr@chromium.org,enne@chromium.org BUG= Review URL: https://codereview.chromium.org/433863003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287202 0039d316-1c4b-4281-b951-d872f2087c98
-
thakis@chromium.org authored
Picks up: r286582 - Update to NSPR 4.10.7 Beta 3. r287121 - Refactor clang warning flags BUG=396377 TBR=wtc@chromium.org Review URL: https://codereview.chromium.org/423713010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287201 0039d316-1c4b-4281-b951-d872f2087c98
-
costan@gmail.com authored
This is necessary for being able to test the File API, or code depending on it, in the blink unit tests. BUG=398366 TEST=no webkit_unit_tests crash in https://codereview.chromium.org/434823002/ Review URL: https://codereview.chromium.org/434833002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287200 0039d316-1c4b-4281-b951-d872f2087c98
-
tfarina@chromium.org authored
This are the remaining uses of the deprecated webkitNotifications in Chromium repo. BUG=None TEST=None R=peter@chromium.org,kalman@chromium.org Review URL: https://codereview.chromium.org/418173006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287199 0039d316-1c4b-4281-b951-d872f2087c98
-
isherman@chromium.org authored
BUG=393775, 397336, 397339 TEST=Verify that error strings in EasyUnlock setup dialog match expected strings. R=tengs@chromium.org Review URL: https://codereview.chromium.org/435083003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287198 0039d316-1c4b-4281-b951-d872f2087c98
-
fsamuel@chromium.org authored
BUG=330264 TBR=fsamuel@chromium.org Review URL: https://codereview.chromium.org/434523003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287197 0039d316-1c4b-4281-b951-d872f2087c98
-
samuong@chromium.org authored
BUG=chromedriver:868 Review URL: https://codereview.chromium.org/420663006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287196 0039d316-1c4b-4281-b951-d872f2087c98
-
vitalyp@chromium.org authored
BUG=393873 TEST=./third_party/closure_compiler/checker_test.py R=dbeam@chromium.org Review URL: https://codereview.chromium.org/435053002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287195 0039d316-1c4b-4281-b951-d872f2087c98
-
miu@chromium.org authored
Root cause of the flakiness is that the StandaloneCastEnvironment, as a ref-counted object, was being destroyed on a thread other than the one that created it. At destruction, it attempted to join on the threads it owns, but these threads must be joined with the thread that they were spawned from. BUG=396480 Review URL: https://codereview.chromium.org/436673004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287194 0039d316-1c4b-4281-b951-d872f2087c98
-
mostynb@opera.com authored
If you try to build with enable_webrtc=0 and remoting=1, gyp will fail: libjingle.gyp:libpeerconnection#target' when processing remoting.gyp:remoting_host#target. This happens because the libpeerconnnection target is defined inside an enable_webrtc==1 condition. Therefore, these dependencies in remoting.gyp should be too. BUG=399413 Review URL: https://codereview.chromium.org/431163002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287193 0039d316-1c4b-4281-b951-d872f2087c98
-
simonhatch@chromium.org authored
Per creis' request, place the transition page in the same process as the destination page. This is done to avoid the overhead of potentially spawning an extra new renderer for the transition. The idea behind this was to put the transition page into the same render process as the incoming page. Approach so far was to instantiate a new WebContents in the embedder via a new function createNativeWebContentsWithSharedSiteInstance(source_content_view_core), passing the SiteInstance of the incoming page. The transition ContentViewCore can then be navigated to a blank page and the serialized markup is added to the page. Since the transition and incoming pages share the same SiteInstance, they will be placed in the same process. Design doc: https://docs.google.com/a/chromium.org/document/d/17jg1RRL3RI969cLwbKBIcoGDsPwqaEdBxafGNYGwiY4/edit# Implementation details: https://docs.google.com/a/chromium.org/document/d/1kREPtFJaeLoDKwrfmrYTD7DHCdxX1RzFBga2gNY8lyE/edit#heading=h.bng2kpmyvxq5 BUG=370696 Review URL: https://codereview.chromium.org/378743002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287192 0039d316-1c4b-4281-b951-d872f2087c98
-
feng@chromium.org authored
During Finch experiment, for users enrolled in the experimental group, we don't want to show interstitial for phishing site to them to avoid confusion. However, the database check is still exercised. This doesn't affect flywheel protection. BUG=381896 Review URL: https://codereview.chromium.org/425223007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287191 0039d316-1c4b-4281-b951-d872f2087c98
-
earthdok@chromium.org authored
BUG=313751 TBR=glider@chromium.org NOTRY=true Review URL: https://codereview.chromium.org/437023002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287190 0039d316-1c4b-4281-b951-d872f2087c98
-
dalecurtis@chromium.org authored
Saves us over 1200 files during compilation!! Also cleans up media_perftests for a smaller savings. BUG=302505 TEST=media_unittests is at ~3000 files now. Review URL: https://codereview.chromium.org/438963005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287189 0039d316-1c4b-4281-b951-d872f2087c98
-
isherman@chromium.org authored
Due to the current experiment setup, this feature will still only be used by a fraction of canary/dev users, but the trybots should now run with this feature enabled. BUG=114092,295787 R=gcasto@chromium.org Review URL: https://codereview.chromium.org/433213003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287188 0039d316-1c4b-4281-b951-d872f2087c98
-
derat@chromium.org authored
LockStateController starts its 350 ms pre-lock animation when the screen is locked via the system tray. When the animation completes, the controller was incorrectly starting the lock-fail timer. If the lock screen had already become ready before this point (possible on a fast system), the timer would crash the process eight seconds later. Change LockStateController to only start the timer when actually requesting that the screen be locked. BUG=349083 Review URL: https://codereview.chromium.org/435083002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287187 0039d316-1c4b-4281-b951-d872f2087c98
-
tonyg@chromium.org authored
Looks like we have to restart the browser if a tab crashes in a browser that doesn't support tab control. BUG=337829 Review URL: https://codereview.chromium.org/437443006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287186 0039d316-1c4b-4281-b951-d872f2087c98
-
thestig@chromium.org authored
Move more extensions code from ChromeContentBrowserClient to ChromeContentBrowserClientExtensionsPart. Review URL: https://codereview.chromium.org/434023004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287185 0039d316-1c4b-4281-b951-d872f2087c98
-
tonyg@chromium.org authored
It was leaving the CanFindAvailableBrowsers method in a bad state. BUG=337829 Review URL: https://codereview.chromium.org/436963003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287184 0039d316-1c4b-4281-b951-d872f2087c98
-
wez@chromium.org authored
This will be used to record sequences of video frames for real-world sessions, for performance-evaluation purposes. If the host is run with a video-recording buffer size specified then it will advertise a videoRecorder capability to clients. Clients seeing this capability can send "video-recorder" extension messages to the host to start and stop recording, and to fetch the next recorded frame. Frames are encoded to VideoPackets using the "verbatim" encoder, and must then be serialized and Base-64 encoded for transmission via the extension message protocol. See crrev.com/386853002 for the client part of this. Review URL: https://codereview.chromium.org/372943002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287183 0039d316-1c4b-4281-b951-d872f2087c98
-
thildebr@chromium.org authored
The BspTree perf tests should ideally perform equally or better than the current LayerSorter tests do in the same tests (i.e. "rubik" vs. "rubik"). Performance results on Z600: layer_sort_cubes= 3.547ms layer_sort_rubik= 0.634ms bsp_tree_cubes= 1.485ms bsp_tree_rubik= 0.136ms bsp_tree_cubes_2= 2.915ms (2x duplicated layers) bsp_tree_cubes_4= 5.667ms (4x duplicated layers) BUG=230833 Review URL: https://codereview.chromium.org/416273002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287182 0039d316-1c4b-4281-b951-d872f2087c98
-
ivandavid@chromium.org authored
PNG. BUG=388517 Review URL: https://codereview.chromium.org/431403002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287181 0039d316-1c4b-4281-b951-d872f2087c98
-
pkotwicz@chromium.org authored
BUG=381266 TEST=Manual, see bug Review URL: https://codereview.chromium.org/436033002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287180 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-admin@google.com authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287179 0039d316-1c4b-4281-b951-d872f2087c98
-
wez@chromium.org authored
This CL also moves all platform checks to dedicated functions, to help keep calling logic more readable. BUG=396348 Review URL: https://codereview.chromium.org/435043002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287178 0039d316-1c4b-4281-b951-d872f2087c98
-
agl@chromium.org authored
This roll brings in the changes below. Most importantly it includes a change that enables dynamic visibility in the same way as normal Chromium components. BUG=398965 commit 533cbee57eec77268ef9f53c4039ec753240fb37 Author: Adam Langley <agl@chromium.org> Date: Fri Aug 1 10:33:29 2014 -0700 Also export some deprecated functions. I didn't mark these functions as OPENSSL_EXPORT in the first place because I was hoping that they wouldn't be needed. However, WebRTC and libjingle are using them. Change-Id: I7a9de770a0a2213e99725b9b5ac7d3d13754ebfd commit e216d6bb9f9139656e1d0c6b6312787fc2e596f9 Author: David Benjamin <davidben@chromium.org> Date: Thu Jul 31 13:59:47 2014 -0400 Add PKCS8_{decrypt,encrypt}_pbe. The original functions do an ascii_to_ucs2 transformation on the password. Deprecate them in favor of making that encoding the caller's problem. ascii_to_ucs2 doesn't handle, say, UTF-8 anyway. And with the original OpenSSL function, some ciphers would do the transformation, and some wouldn't making the text-string/bytes-string confusion even messier. BUG=399121 Change-Id: I7d1cea20a260f21eec2e8ffb7cd6be239fe92873 Reviewed-on: https://boringssl-review.googlesource.com/1347Reviewed-by:
Adam Langley <agl@google.com> commit cf052cf7328478d46c78dc67dd4f5ac44db02c20 Author: Adam Langley <agl@chromium.org> Date: Thu Jul 31 18:46:35 2014 -0700 Fix build for PNaCl. PNaCl builds BoringSSL with OPENSSL_NO_ASM, but the new OPENSSL_cleanse was using inline assembly anyway. It appears that even though the inline asm was empty, it still breaks the PNaCl build: disallowed: inline assembly: call void asm sideeffect "", "r,~{memory}"(i8* %.asptr319), !dbg !96986 With this change, we don't have any compiler scarecrows for OPENSSL_cleanse any longer when using OPENSSL_NO_ASM :( Maybe, one day, we'll get memset_s in our base platform. Change-Id: Ia359f6bcc2000be18a6f15de10fc683452151741 Reviewed-on: https://boringssl-review.googlesource.com/1353Reviewed-by:
David Benjamin <davidben@chromium.org> Reviewed-by:
Adam Langley <agl@google.com> commit 581a17f5c874758ec60c1256423c15842edc68f2 Author: Adam Langley <agl@chromium.org> Date: Thu Jul 31 19:24:57 2014 -0700 Fix typo from eb7d2ed1. The RC4_set_key was calling itself rather than the asm function that it should be calling. Change-Id: Idfc730c8a651540961e05bc8c8f663a44713f680 commit 31ebde9e5e7573f70e132e63abf65036688b46ec Author: Adam Langley <agl@chromium.org> Date: Thu Jul 31 12:16:48 2014 -0700 Add a control to disable the Poly1305 NEON code. Some phones have a buggy NEON unit and the Poly1305 NEON code fails on them, even though other NEON code appears to work fine. This change: 1) Fixes a bug where NEON was assumed even when the code wasn't compiled in NEON mode. 2) Adds a second NEON control bit that can be disabled in order to run NEON code, but not the Poly1305 NEON code. https://code.google.com/p/chromium/issues/detail?id=341598 Change-Id: Icb121bf8dba47c7a46c7667f676ff7a4bc973625 Reviewed-on: https://boringssl-review.googlesource.com/1351Reviewed-by:
Adam Langley <agl@google.com> commit eb7d2ed1fe8a33b3e3871502ba7e12efaf94360c Author: Adam Langley <agl@chromium.org> Date: Wed Jul 30 16:02:14 2014 -0700 Add visibility rules. This change marks public symbols as dynamically exported. This means that it becomes viable to build a shared library of libcrypto and libssl with -fvisibility=hidden. On Windows, one not only needs to mark functions for export in a component, but also for import when using them from a different component. Because of this we have to build with |BORINGSSL_IMPLEMENTATION| defined when building the code. Other components, when including our headers, won't have that defined and then the |OPENSSL_EXPORT| tag becomes an import tag instead. See the #defines in base.h In the asm code, symbols are now hidden by default and those that need to be exported are wrapped by a C function. In order to support Chromium, a couple of libssl functions were moved to ssl.h from ssl_locl.h: ssl_get_new_session and ssl_update_cache. Change-Id: Ib4b76e2f1983ee066e7806c24721e8626d08a261 Reviewed-on: https://boringssl-review.googlesource.com/1350Reviewed-by:
Adam Langley <agl@google.com> commit 60d4c0e81042e4c014f38575a72c4befded62eef Author: Piotr Sikora <piotr@cloudflare.com> Date: Thu Jul 31 03:13:13 2014 -0700 Fix "type qualifiers ignored on function return type" errors. Change-Id: If0dbbadb33a073b4faee500fdff900a5094ec889 Signed-off-by:
Piotr Sikora <piotr@cloudflare.com> Reviewed-on: https://boringssl-review.googlesource.com/1362Reviewed-by:
Adam Langley <agl@google.com> commit 1d8adf18d20a4d65150af62159ab631d847e869a Author: Piotr Sikora <piotr@cloudflare.com> Date: Thu Jul 31 03:09:49 2014 -0700 Fix CPU architecture detection on BSDs. CMake calls "uname" in order to detect the CPU architecture, so $(CMAKE_SYSTEM_PROCESSOR) varies from platform to platform. This changes adds support for "i386" and "amd64" values, which are used by BSDs for the x86 family of CPUs. Change-Id: I532ce787a9ac06220c92a6d8c78ad5a55d8c40bf Signed-off-by:
Piotr Sikora <piotr@cloudflare.com> Reviewed-on: https://boringssl-review.googlesource.com/1360Reviewed-by:
Adam Langley <agl@google.com> commit ad1907fe73334d6c696c8539646c21b11178f20f Author: Adam Langley <agl@chromium.org> Date: Wed Jul 30 11:55:17 2014 -0700 Use asm directives to protect OPENSSL_cleanse. Compilers have a bad habit of removing "superfluous" memset calls that are trying to zero memory. For example, when memset()ing a buffer and then free()ing it, the compiler might decide that the memset is unobservable and thus can be removed. Previously we tried to stop this by a) implementing memset in assembly on x86 and b) putting the function in its own file for other platforms. This change removes those tricks in favour of using asm directives to scare the compiler away. As best as our compiler folks can tell, this is sufficient and will continue to be so. Change-Id: I40e0a62c3043038bafd8c63a91814a75a3c59269 Reviewed-on: https://boringssl-review.googlesource.com/1339Reviewed-by:
David Benjamin <davidben@chromium.org> Reviewed-by:
Adam Langley <agl@google.com> Review URL: https://codereview.chromium.org/428753004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287177 0039d316-1c4b-4281-b951-d872f2087c98
-
xiyuan@chromium.org authored
EasyUnlockService is created with profile. Previous code to prevent it from being created on login screen does not work for all cases. Move the logic to EasyUnlockServiceFactory::GetBrowserContextToUse fixes the issue. BUG=399705 TBR=rogerta@chromium.org Review URL: https://codereview.chromium.org/423363004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287176 0039d316-1c4b-4281-b951-d872f2087c98
-
pneubeck@chromium.org authored
This only affects users of domains that the device is registered to for policy. All other users are unaffected (EnableNSSSystemKeySlotForResourceContext is only called for USER_AFFILIATION_MANAGED) For the affected users, this enables and uses the slot for - client authentication for TSL (see ClientCertStoreChromeOS) - client authentication for 802.1x networks - listing/removing certificates on the settings page (see CertificateManager) In a follow up, also the enterprise.platformKeys API will be updated. Depends on: https://codereview.chromium.org/426983002/ https://codereview.chromium.org/428933002/ BUG=210525 R=mattm@chromium.org, rsleevi@chromium.org, willchan@chromium.org, xiyuan@chromium.org Review URL: https://codereview.chromium.org/424523002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287175 0039d316-1c4b-4281-b951-d872f2087c98
-
dalecurtis@chromium.org authored
Facilitates gapless playback across mp3 and aac. Relying on splice frames and crossfading doesn't work in cases where the prior segment signal diverges to null-padding values too quickly relative to the newly appended segment. BUG=395899 TEST=new unittests. llama-demo works. Review URL: https://codereview.chromium.org/414603002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287174 0039d316-1c4b-4281-b951-d872f2087c98
-
wez@chromium.org authored
- Fix EXPECT_EQ() ordering in Capabilities tests. - Move MATCHERs definitions in ClientSession tests. Review URL: https://codereview.chromium.org/428403003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287173 0039d316-1c4b-4281-b951-d872f2087c98
-
thestig@chromium.org authored
BUG=349436 Review URL: https://codereview.chromium.org/428323002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287172 0039d316-1c4b-4281-b951-d872f2087c98
-
chromeos-lkgm@google.com authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287171 0039d316-1c4b-4281-b951-d872f2087c98
-
pneubeck@chromium.org authored
This new test had a memory leak as reported by Linux ASan LSan: http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Tests%20%281%29/builds/4540/steps/browser_tests/logs/Events TBR=kalman@chromium.org, liyanhou@chromium.org BUG=397197 NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/433073003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287170 0039d316-1c4b-4281-b951-d872f2087c98
-
pneubeck@chromium.org authored
Revert of Remove deprecated extension notification from WebstoreStartupInstallerTest (https://codereview.chromium.org/437603002/) Reason for revert: Broke several tests on Linux Asan/Lsan: http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Tests%20%282%29/builds/5662/steps/browser_tests/logs/LimitedAccept http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Tests%20%283%29/builds/5973/steps/browser_tests/logs/Cancel http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Tests%20%283%29/builds/5973/steps/browser_tests/logs/Accept E.g. ==21932==ERROR: AddressSanitizer: heap-use-after-free on address 0x611000210570 at pc 0x00000c56a19d bp 0x7fff04951d00 sp 0x7fff04951cf8 READ of size 8 at 0x611000210570 thread T0 (browser_tests) #0 0xc56a19c in begin third_party/libc++/trunk/include/vector:1417:12 #1 0xc56a19c in RemoveObserver base/observer_list.h:168 #2 0xc56a19c in extensions::ExtensionRegistry::RemoveObserver(extensions::ExtensionRegistryObserver*) extensions/browser/extension_registry.cc:37 #3 0x13a2de2 in RemoveAll base/scoped_observer.h:39:7 #4 0x13a2de2 in ~ScopedObserver base/scoped_observer.h:22 #5 0x13a2de2 in CommandLineWebstoreInstall::~CommandLineWebstoreInstall() chrome/browser/extensions/webstore_startup_installer_browsertest.cc:250 Original issue's description: > Remove deprecated extension notification from WebstoreStartupInstallerTest > > BUG=354046 > TEST=browser_tests WebstoreStartupInstallerTest.* > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287154 TBR=kalman@chromium.org,limasdf@gmail.com NOTREECHECKS=true NOTRY=true BUG=354046 Review URL: https://codereview.chromium.org/428123004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287169 0039d316-1c4b-4281-b951-d872f2087c98
-
rtenneti@chromium.org authored
Add case for PING frame in QuicFrame <<. Merge internal change: 71908470 https://codereview.chromium.org/421963006/ Add methods to the QuicConnectionDebug visitor for tracking various events which cause a QuicConnection to discard a packet. Merge internal change: 71871881 https://codereview.chromium.org/421913015/ Change ReliableQuicStream::OnStreamFrame to return void since the method already closes the connection when there are errors and callers are not checking the return value Make QuicStreamSequencer::OnStreamFrame return void instead of bool since it is already closing the connect or resetting the stream when there is an error. Make two QUIC methods return void instead of bool. Merge internal change: 71870242 https://codereview.chromium.org/420393004/ Create a visitor which can allow using both a trace... visitor and the existing stats visitor. Changed QuicConnection's QuicConnectionDebugVisitor to a scoped_ptr. Merge internal change: 71863508 https://codereview.chromium.org/429453003/ Use 1350 byte QUIC packets by default. Merge internal change: 71837432 https://codereview.chromium.org/427673005/ Improve debug logging of QUIC crypto handshake. Merge internal change: 71833151 https://codereview.chromium.org/428803002/ Fix a bug in QuicUnackedPacketMap where an in flight packet could be removed before being removed from bytes_in_flight. Merge internal change: 71783653 https://codereview.chromium.org/422123005/ Inline the members of QUIC's ReceivedPacketInfo into QuicAckFrame now that version 15 is gone. Merge internal change: 71763611 https://codereview.chromium.org/424003002/ Remove FixRate congestion frame type. Merge internal change: 71746617 https://codereview.chromium.org/424903002/ Remove QUIC_VERSION_15 now that Chrome Stable supports QUIC_VERSION_16. Merge internal change: 71718286 https://codereview.chromium.org/413403008/ R=rch@chromium.org TBR=thestig@chromium.org Review URL: https://codereview.chromium.org/420313005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287168 0039d316-1c4b-4281-b951-d872f2087c98
-
boliu@chromium.org authored
Crash caused by RenderThreadImpl::OnMemoryPressure being called before blink is initialized. Fix by skipping the crashing code if blink has not been initialized. BUG=398768 Review URL: https://codereview.chromium.org/437623003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287167 0039d316-1c4b-4281-b951-d872f2087c98
-
tonyg@chromium.org authored
showmap may not exist. For example, see the Moto E: http://chromegw/i/chromium.perf/builders/Android%20MotoE%20Perf/builds/494/steps/page_cycler.intl_hi_ru/logs/stdio This causes us to degrade gracefully and not output memory metrics. BUG= Review URL: https://codereview.chromium.org/431243002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287166 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-admin@google.com authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287165 0039d316-1c4b-4281-b951-d872f2087c98
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia/+log/490d49c5dcc4b2242c9b25f082b23ec5e842c4e7..c6f57840475cb17aa1cf2f50c181d3235b924056 CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_layout_rel TBR=bensong@google.com BUG= Review URL: https://codereview.chromium.org/436913003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287164 0039d316-1c4b-4281-b951-d872f2087c98
-
vabr@chromium.org authored
This is to help investigating a clusterfuzz crash, but should stay permanently to document the expectations. BUG=399215 Review URL: https://codereview.chromium.org/432863003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287163 0039d316-1c4b-4281-b951-d872f2087c98
-