Skip to content

GitLab

T
tangled
Switch branch/tag
  1. 31 Oct, 2017 13 commits
    • Makoto Shimazu's avatar
      Revert "Servicifying ShellHandlerWin." · c52f5bd4
      Makoto Shimazu authored 
      This reverts commit 8232f416.

Reason for revert: Google Chrome Win builder failed.
shell_handler_win.mojom.h is still included by shell_integration_win.cc which was renamed by the original CL.
I'm wondering why the trybots missed this.

Original change's description:
> Servicifying ShellHandlerWin.
> 
> As part of the effort to deprecate UtilityProcessMojoClient, changing
> ShellHandlerWin to a service and consumers to bind the service through
> the service manager.
> Renamed the interface from ShellHandlerWin to WinShellUtil.
> 
> Bug: 777032
> Change-Id: I71a45a38a5fd0d5d02a8a0bccabf6a7e140acbd7
> Reviewed-on: https://chromium-review.googlesource.com/736147
> Commit-Queue: Jay Civelli <jcivelli@chromium.org>
> Reviewed-by: Scott Violet <sky@chromium.org>
> Reviewed-by: Tom Sepez <tsepez@chromium.org>
> Reviewed-by: Patrick Monette <pmonette@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#512682}

TBR=sky@chromium.org,thestig@chromium.org,jcivelli@chromium.org,noel@chromium.org,tsepez@chromium.org,pmonette@chromium.org

Change-Id: I03bb3ac7bfa0e9e98fc63034d7e81a62fcdfd21a
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 777032
Reviewed-on: https://chromium-review.googlesource.com/745461Reviewed-by: default avatarMakoto Shimazu <shimazu@chromium.org>
Commit-Queue: Makoto Shimazu <shimazu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512693}
      c52f5bd4
    • Manuel Rego Casasnovas's avatar
      [css-grid] Remove unneeded code in FreeSpaceForStretchAutoTracksStep() · f2061c44
      Manuel Rego Casasnovas authored 
      This is a follow up after r510461. In that patch we added a TODO in
IndefiniteSizeStrategy::FreeSpaceForStretchAutoTracksStep().
This was related to how preferred widths were computed,
that could be missing the min-width information.

However after r511451 removing some wrong code
in LayoutGrid::UpdateBlockLayout(), that was trying to compute
the preferred widths, we can avoid doing any special calculation
for the columns case, as that's already managed
by LayoutBlock::ComputePreferredLogicalWidths().

Basically GridTrackSizing provides a min and max logical widths
that ignore min-width. But that's not an issue as LayoutGrid only
overrides ComputeIntrinsicLogicalWidths(),
then ComputePreferredLogicalWidths() will use that information
together with the min-size and properly compute the preferred widths.

For this reason in FreeSpaceForStretchAutoTracksStep() we don't need
any special computation for columns, the same that happens
in RecomputeUsedFlexFractionIfNeeded().

Added two unit tests to verify that the preferred widths are right
in both cases (auto and flexible tracks with min-width).

Bug=773625

Change-Id: I69efeb064fa03685c3e77bca33d294df3e1db79d
Reviewed-on: https://chromium-review.googlesource.com/741505Reviewed-by: default avatarJavier Fernandez <jfernandez@igalia.com>
Commit-Queue: Manuel Rego Casasnovas <rego@igalia.com>
Cr-Commit-Position: refs/heads/master@{#512692}
      f2061c44
    • angle-deps-roller@chromium.org's avatar
      Roll src/third_party/angle/ e7c5f4f05..163965d5c (1 commit) · 4605f2dd
      angle-deps-roller@chromium.org authored 
      https://chromium.googlesource.com/angle/angle.git/+log/e7c5f4f05c87..163965d5ce2b

$ git log e7c5f4f05..163965d5c --date=short --no-merges --format='%ad %ae %s'
2017-10-11 cwallez BUILD.gn: prepare dEQP test support on Mac

Created with:
  roll-dep src/third_party/angle


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.angle:android_angle_rel_ng,android_angle_deqp_rel_ng,linux_angle_rel_ng,linux_angle_dbg_ng,linux_angle_deqp_rel_ng,linux_angle_ozone_rel_ng,mac_angle_rel_ng,mac_angle_dbg_ng,win_angle_rel_ng,win_angle_dbg_ng,win_angle_x64_rel_ng,win_angle_x64_dbg_ng,win_angle_deqp_rel_ng,win_angle_x64_deqp_rel_ng;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=cwallez@chromium.org

Change-Id: If105bad8635efef8c27bc54145eaa862836f5912
Reviewed-on: https://chromium-review.googlesource.com/744972Reviewed-by: default avatarangle-deps-roller . <angle-deps-roller@chromium.org>
Commit-Queue: angle-deps-roller . <angle-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512691}
      4605f2dd
    • Shubhie Panicker's avatar
      Decouple Stopped in bg signal from stop loading experiment. · 9ffd6254
      Shubhie Panicker authored 
      Make triggering of Stopped in bg signal more generic, it should not be
tied to the experiment to stop loading.
A future CL will trigger a JS callback to indicate stopped to the app. 

Bug: 763573
Change-Id: I439e70fab824d2e243ebfa731d5f27464dc629ff
Reviewed-on: https://chromium-review.googlesource.com/736903
Commit-Queue: Shubhie Panicker <panicker@chromium.org>
Reviewed-by: default avatarSami Kyöstilä <skyostil@chromium.org>
Reviewed-by: default avatarFadi Meawad <fmeawad@chromium.org>
Reviewed-by: default avatarAlexander Timin <altimin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512690}
      9ffd6254
    • Charles Harrison's avatar
      AbusiveExperienceEnforce: add end to end safe browsing test · 890f8aa0
      Charles Harrison authored 
      This CL adds a new harness to the safe browsing triggered popup
blocker browser test which mocks HTTP responses from the safe browsing
server.

It also tweaks the ScopedLoggingObserver to stop listening (globally)
on messages when it is destroyed, and it only considers messages that
have come in since it is instantiated.

Bug: 756009,756089
Change-Id: I2ad8bcebbdaf09252fa323e9de49c0de943e372b
Reviewed-on: https://chromium-review.googlesource.com/731406
Commit-Queue: Charlie Harrison <csharrison@chromium.org>
Reviewed-by: default avatarShivani Sharma <shivanisha@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512689}
      890f8aa0
    • Lucas Garron's avatar
      Create a --committed-interstitials Chrome flag. · b9539b73
      Lucas Garron authored 
      The flag is exposed in chrome://flags

Also deny requests that encounter certificate errors in
ChromeContentBrowserClientAllow::CertificateError, causing them to appear like
net errors with ERR_INSECURE_RESPONSE. Subsequent CLs will make them behave more
and more like old interstitials.

Bug: 778857
Change-Id: Ie50f8475db5ae0f6b98f17e17128587fc8553848
Reviewed-on: https://chromium-review.googlesource.com/742136Reviewed-by: default avatarEmily Stark <estark@chromium.org>
Commit-Queue: Lucas Garron <lgarron@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512688}
      b9539b73
    • Bo Liu's avatar
      Reset GPU timeout on retry · e1249bf1
      Bo Liu authored 
      Only for Android. Right now OnEstablishedOnIO retries on failure
indefinitely. The main reason this is a problem on android is in
CompositorImpl, there is a timeout waiting for EstablishChannel. If the
failure is due to a gpu timeout, then CompositorImpl doesn't known about
the try and doesn't reset its timeout, thus making it more like to have
the entire browser be killed.

Move the timeout logic into BrowserGpuChannelHostFactory instead so
that the timeout can be reset when EstablishGpuChannel is retried.

Bug: 680777
Change-Id: I47da7d3f2b3ca238c3aec547497adf57dc63a73d
Reviewed-on: https://chromium-review.googlesource.com/742484
Commit-Queue: Bo <boliu@chromium.org>
Reviewed-by: default avatarAntoine Labour <piman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512687}
      e1249bf1
    • Antoine Labour's avatar
      gpu fuzzers: take configuration bits from input data · 72bb2907
      Antoine Labour authored 
      Some of the decoder code paths depend on underlying driver (e.g.
version, extensions, workarounds), and of the client configuration (e.g.
context type and options). This CL allows the fuzzers to take some bits
from the input data to configure the decoder in different ways, to allow
exploring those various code paths and increasing coverage.

Bug: None
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I23a77878414ade4400a267b30d89f979a0ff4374
Reviewed-on: https://chromium-review.googlesource.com/744735Reviewed-by: default avatarVictor Miura <vmiura@chromium.org>
Commit-Queue: Antoine Labour <piman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512686}
      72bb2907
    • Hiroshige Hayashizaki's avatar
      Add IntegrityMetadataSet to ScriptFetchOptions · 17090875
      Hiroshige Hayashizaki authored 
      This CL
- introduces integrity-related members to ScriptFetchOptions,
- sets them in PrepareScript(), WorkletGlobalScope.cpp and
  DynamicModuleResolver.cpp as specced, and
- uses them for classic scripts, in ClassicPendingScript::Fetch().

For module scripts, the integrity-related members are not used,
and are sometimes set incorrectly.
This will be fixed in a subsequent CL.

Bug: 771486, 772100
Change-Id: I0983bc6ad02b73472d67bf1b2ce169d2d71c5be3
Reviewed-on: https://chromium-review.googlesource.com/736721
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Reviewed-by: default avatarKouhei Ueno <kouhei@chromium.org>
Reviewed-by: default avatarYutaka Hirano <yhirano@chromium.org>
Reviewed-by: default avatarHiroki Nakagawa <nhiroki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512685}
      17090875
    • Ryan Hansberry's avatar
      Remove all screen lock logic from TetherService. · 7ec9bdc8
      Ryan Hansberry authored 
      Bug: 779649
Change-Id: Ic3ffb1886a3d3dae5389aef0d5a52c12c6c31635
Reviewed-on: https://chromium-review.googlesource.com/744422
Commit-Queue: Dan Erat <derat@chromium.org>
Reviewed-by: default avatarJeremy Klein <jlklein@chromium.org>
Reviewed-by: default avatarSteven Holte <holte@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512684}
      7ec9bdc8
    • lpy's avatar
      Revert "Make resource_coordinator/ strongly typed." · 5d86ecd0
      lpy authored 
      This reverts commit 8a3a84dc.

Reason for revert: Unit test failed in Linux Test, see https://luci-milo.appspot.com/buildbot/chromium.linux/Linux%20Tests/63991

Original change's description:
> Make resource_coordinator/ strongly typed.
> 
> This patch:
> 1. Added CU relation manipulation methods in mojo interface and public APIs;
> 2. Created one type of *ResourceCoordinator for each coordination unit type;
> 3. Removed generic CoordinationUnit mojo interface and implementation;
> 4. Replaced every call of SetProperty and SendEvent with new public APIs;
> 5. Added more tests.
> 
> BUG=775691
> 
> Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation
> Change-Id: I10b5c6a5ce9d8f0fbe3c2c3afef4ee4da7da0757
> Reviewed-on: https://chromium-review.googlesource.com/736036
> Commit-Queue: lpy <lpy@chromium.org>
> Reviewed-by: Peter Beverloo <peter@chromium.org>
> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
> Reviewed-by: oysteine <oysteine@chromium.org>
> Reviewed-by: Zhen Wang <zhenw@chromium.org>
> Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#512654}

TBR=dcheng@chromium.org,kinuko@chromium.org,peter@chromium.org,zhenw@chromium.org,japhet@chromium.org,oysteine@chromium.org,lpy@chromium.org

Change-Id: I0ecfcf6fe272d6be9dacf022e9221db346294abd
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 775691
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation
Reviewed-on: https://chromium-review.googlesource.com/745282Reviewed-by: default avatarlpy <lpy@chromium.org>
Commit-Queue: lpy <lpy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512683}
      5d86ecd0
    • Jay Civelli's avatar
      Servicifying ShellHandlerWin. · 8232f416
      Jay Civelli authored 
      As part of the effort to deprecate UtilityProcessMojoClient, changing
ShellHandlerWin to a service and consumers to bind the service through
the service manager.
Renamed the interface from ShellHandlerWin to WinShellUtil.

Bug: 777032
Change-Id: I71a45a38a5fd0d5d02a8a0bccabf6a7e140acbd7
Reviewed-on: https://chromium-review.googlesource.com/736147
Commit-Queue: Jay Civelli <jcivelli@chromium.org>
Reviewed-by: default avatarScott Violet <sky@chromium.org>
Reviewed-by: default avatarTom Sepez <tsepez@chromium.org>
Reviewed-by: default avatarPatrick Monette <pmonette@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512682}
      8232f416
    • Mohsen Izadi's avatar
      Adjust overscroll thresholds for touchpad · 4ef8db7d
      Mohsen Izadi authored 
      To improve touchpad overscroll sensitivity, start and completion
thresholds for touchpad are increased by 20%. This needed splitting some
threshold into two separate ones for touchpad and touchscreen.

Also, both vertical and horizontal overscroll now use maximum of screen
width and screen height to calculate completion threshold. Previously,
vertical overscroll was using screen height and horizontal overscroll
was using screen width. This change makes overscroll in both dimensions
more consistent.

Also, some parameters had different values for vertical vs horizontal
overscroll. They have been merged into a single parameter.

BUG=772103
TEST=RenderWidgetHostViewAuraOver*Test.* in content_unittests

Change-Id: Id4efa17b247fffdbd13c0087be5afbec85f81131
Reviewed-on: https://chromium-review.googlesource.com/740782Reviewed-by: default avatarAlex Moshchuk <alexmos@chromium.org>
Reviewed-by: default avatarSadrul Chowdhury <sadrul@chromium.org>
Commit-Queue: Mohsen Izadi <mohsen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512681}
      4ef8db7d
  3. 30 Oct, 2017 27 commits