GitLab

Broken at
  https://chromium-review.googlesource.com/c/chromium/src/+/2417091

The build configuration that provides the PDF_ENABLE_XFA symbol does
not appear to be present for files at the pdf/ directory level, only
for those at the pdf/pdfium/ directory level. To avoid requiring these
definitions at a higher level (since this minimizes recompilation when
the value changes), add a helper function in pdf/pdfium/ to return this
information.

Change-Id: I2499816aa9e5ac08c7064a961d2ed4f70c7772f1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575042
Commit-Queue: Tom Sepez <tsepez@chromium.org>
Reviewed-by: K. Moon <kmoon@chromium.org>
Reviewed-by: Daniel Hosseinian <dhoss@chromium.org>
Cr-Commit-Position: refs/heads/master@{#833832}

This change is in preparation of multipaste related VK API changes,
where the ChromeVirtualKeyboardDelegate will need to be a
ClipboardHistoryControllerObserver. This will allow the VK to observe
clipboard history changes.

Bug: 1099318
Change-Id: I5535d45255b137219cf76b76f6d94c9bfb5ca9e2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2573636Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Alex Newcomer <newcomer@chromium.org>
Commit-Queue: Matthew Mourgos <mmourgos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#833831}

IndexedDBContextImpl had the following two member variables:

  IndexedDBDispatcherHost indexed_db_factory_;
  std::unique_ptr<IndexedDBFactoryImpl> indexeddb_factory_;

The first name was confusing. Renamed to:

  IndexedDBDispatcherHost dispatcher_host_;

to avoid confusion.

Bug: none
Change-Id: Iaefb0e077f94ea2e1639a4c7aeb28a29f9a3ffab
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575037Reviewed-by: Joshua Bell <jsbell@chromium.org>
Commit-Queue: Chris Mumford <cmumford@google.com>
Cr-Commit-Position: refs/heads/master@{#833830}

https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/b917ab64e84b..2d21a8fb4dbe

2020-12-04 cjamcl@chromium.org Add WATCHLISTS entry for lighthouse
2020-12-04 bmeurer@chromium.org [LMI] Add support for inspecting WebAssembly.Memory objects.
2020-12-04 tvanderlippe@chromium.org Port pretty-printing layout tests to Karma
2020-12-04 kimanh@chromium.org [LMI] Show signed/unsigned values next to each other, if different
2020-12-04 tvanderlippe@chromium.org Improve formatting of do-while loop
2020-12-04 tvanderlippe@chromium.org Fix permissions for test scripts

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: chromium:1110202,chromium:1155566,chromium:983851
Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com
Change-Id: I3f64c8136baa665dfdbaafad82c370ae754d2d2f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575216Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#833829}

Using wpt-import in Chromium 1aa111f7.

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
cbiesinger@chromium.org:
  external/wpt/css/css-flexbox
foolip@chromium.org, lpz@chromium.org, robertma@chromium.org:
  external/wpt/tools
mstensho@chromium.org:
  external/wpt/css/css-break
  external/wpt/css/css-multicol
rego@igalia.com:
  external/wpt/css/css-contain
  external/wpt/css/css-grid
yhirano@chromium.org, mkwst@chromium.org, japhet@chromium.org:
  external/wpt/fetch

NOAUTOREVERT=true
TBR=foolip@google.com

No-Export: true
Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel,linux-wpt-input-fyi-rel
Change-Id: Ic7dc1808879a15bc57c0b4d65d22a323780a9a03
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2572988Reviewed-by: Stephen McGruer <smcgruer@chromium.org>
Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Stephen McGruer <smcgruer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#833828}

This CL makes sure all ImageCapture related capabilities, constraints,
and settings are copied to the cloned MediaStreamTrack. This wasn't the
case before.

Bug: 934063
Change-Id: I783d0804e56f46152e1ba02255ff454dd1ba76aa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567917Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Commit-Queue: François Beaufort <beaufort.francois@gmail.com>
Cr-Commit-Position: refs/heads/master@{#833827}

Remove an unsupported eliding multiline mode: ELIDE_LONG_WORDS
The eliding mode is still supported by ElideRectangleText(...)
and still used in Canvas.

This CL only prevent an incorrect use in RenderText and remove it
from the fuzzer.

R=msw@chromium.org

Bug: 1150235
Change-Id: I53aee3ddc2ba9fd8e7b69995e25aa697644b6894
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2561438Reviewed-by: Robert Liao <robliao@chromium.org>
Reviewed-by: Keren Zhu <kerenzhu@chromium.org>
Commit-Queue: Etienne Bergeron <etienneb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#833826}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/1df52ed5909b..ff8800deaa33

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC sergeyu@google.com,mmentovai@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: chromium:1138953
Tbr: sergeyu@google.com,mmentovai@google.com
Change-Id: I87b70dc70cae70364cef5f9525795f959c2acde4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2574997Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#833825}

Tested that all targets now build via:
autoninja -C out/Release $(build/android/list_java_targets.py --proguard-enabled)

Bug: 1155547
Change-Id: Ie32d62e108778c219a190e363be9c82b747a2a02
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2574597
Auto-Submit: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: Paul Jensen <pauljensen@chromium.org>
Reviewed-by: Paul Jensen <pauljensen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#833824}

Some callback aliases were missed when I was taking out the BLE
authenticator code earlier this year. This removes them.

Change-Id: Ic69352e4fde6892821e9076f111d030299e9451f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575156Reviewed-by: Nina Satragno <nsatragno@chromium.org>
Commit-Queue: Ken Buchanan <kenrb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#833823}

Change-Id: Ie468abd468d88cca3f6eb01855f1033718545b72
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575319Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
Commit-Queue: Sorin Jianu <sorin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#833822}

This change adds the intent parameters data class as well as API methods
into LensController for starting the AGSA connection early and launching
the intent via the Lens SDK.

Bug: 1098431
Change-Id: I5e9d1777e352c246bf93372d6e7fe2d2b22c78f7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551424Reviewed-by: Ben Goldberger <benwgold@google.com>
Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org>
Commit-Queue: Juan Mojica <juanmojica@google.com>
Cr-Commit-Position: refs/heads/master@{#833821}

This reverts commit 00437792.

Reason for revert: suspect to be causing apps.LaunchGallery failures on CrOS
https://bugs.chromium.org/p/chromium/issues/detail?id=1155028#c21

Original change's description:
> [FSA] Add IsSafePathComponent checks to GetFile/GetDirectoryHandle.
>
> This isn't directly using net::IsSafePortablePathComponent since what
> is safe for the File System Access API is not the same as what is safe
> for Downloads. As such currently this duplicates a lot of the
> implementation of this method, but in a followup we should attempt to
> unify these two implementations as much as possible.
>
> Bug: 1150810, 1154757
> Change-Id: Iba4c92ef5f1cd924aa22b9dd201762d48b4bbc3b
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2568383
> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org>
> Reviewed-by: Victor Costan <pwnall@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#833042}

TBR=mek@chromium.org,pwnall@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 1150810
Bug: 1154757
Bug: 1155028
Change-Id: I6c0fb2af7096d4f7f47d3e17a40c5a69105808cd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2574931Reviewed-by: Ben Pastene <bpastene@chromium.org>
Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Commit-Queue: Marijn Kruisselbrink <mek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#833820}

This CL fixes the CachedMetricsProfile and DemographicMetricsProvider
for ChromeOS Ash. It introduces a profile selection strategy for
CachedMetricsProfile and skips the number of profiles on disk check in
DemographicMetricsProvider for ChromeOS Ash.

Bug: 1145655
Change-Id: I3cf69673e428cc7ff81e4d1e5f1650a6d96bdcc2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527521Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: Roger McFarlane <rogerm@chromium.org>
Reviewed-by: Vincent Boisselle <vincb@google.com>
Commit-Queue: Toby Huang <tobyhuang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#833819}

In http://crrev.com/833775 a command line flag was renamed in
list_java_targets.py. Update generate_gradle.py accordingly.

Bug: None
Change-Id: I91c85063f5eb1ae442731536103492c2fe15ff7a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575018
Commit-Queue: Egor Pasko <pasko@chromium.org>
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Auto-Submit: Egor Pasko <pasko@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#833818}

We couldn't do this when increment_install was not a GN arg, but it's
easy to do now that it is :).

Bug: None
Change-Id: I42c243fa530e448158405bf4157016f578f319ad
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2573011
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Auto-Submit: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Peter Wen <wnwen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#833817}

This patch checks the result of WebContents::FromRenderFrameHost() for
null to avoid crashing.

Bug: 1064628
Change-Id: Ib755a014e72e2428e8343aa2aac2b3b707c484ab
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2572908Reviewed-by: Liquan (Max) Gu <maxlg@chromium.org>
Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#833816}

Previously, chrome.accessibilityPrivate.enableChromeVoxMouseEvents only sent mouse events through the accessibility -> chrome.automation layer only when ChromeVox was enabled.

Make it so that we also send (when requested) to the accessibility common extension when magnifier is enabled.

R=josiahk@chromium.org

Test: browser_tests --gtest_filter=*Spoken*.SpeakingTextUnderMouseForShelfItem* for ChromeVox. Magnifier tests tbd when it gets used for upcoming features.
Change-Id: If620e69d3d7a0d0480afac412ae9c4d52b8cfba8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2572797
Commit-Queue: David Tseng <dtseng@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#833815}

Change-Id: I59d9725499dfabe490411391350f5050ebe326c8
Bug: 1152527
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2574258
Commit-Queue: rajendrant <rajendrant@chromium.org>
Reviewed-by: Robert Ogden <robertogden@chromium.org>
Cr-Commit-Position: refs/heads/master@{#833814}

Screen: http://screen/BhQEsVaDzMLxAEj
Spec: https://carbon.googleplex.com/cros-ux/pages/diagnostics/mvp#000933fc-29e1-4d4b-aa49-9d1b8fb16a24

Bug: 1125150
Test: browser_test --gtest_filter=Diagnostics*
Change-Id: Ic52a8249e29e17ce703a1acc91d1e8280db93073
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2572790Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Commit-Queue: Joon Ahn <joonbug@chromium.org>
Cr-Commit-Position: refs/heads/master@{#833813}

Support for the enterprise bypass of the TLS 1.0/1.1 removal will be
removed in May 2021. This adds a notice to the policy page to clarify
this. The sunsetting of this bypass has been previously announced
in https://www.chromestatus.com/feature/5759116003770368,
https://security.googleblog.com/2018/10/modernizing-transport-security.html
(in 2018), and https://blog.chromium.org/2019/10/chrome-ui-for-deprecating-legacy-tls.html
(in 2019).

Bug: 896013
Change-Id: Ib0cb2ba9bc8a925a1a8bfd3ee17995ae0a23bd3d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2569811
Commit-Queue: Chris Thompson <cthomp@chromium.org>
Reviewed-by: David Benjamin <davidben@chromium.org>
Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#833812}

Add NavigationCallback.onFirstContentfulPaint variant that matches up to CCT's version for easier comparison.

Bug: 1152600
Change-Id: I3025464676ecb2cc649e445701cdc5797e4d068d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2559285Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#833811}

Bug: 1145666
Change-Id: I452ba10bb5fab5cada0aa072d9c33f0ae79bab37
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567985
Commit-Queue: Elaine Chien <elainechien@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Thomas Lukaszewicz <tluk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#833810}

https://skia.googlesource.com/skia.git/+log/fa8d6915cbbf..db873dd600c3

2020-12-04 reed@google.com add util for checker image
2020-12-04 reed@google.com Reland "Remove some flutter flags"
2020-12-04 johnstiles@google.com Code cleanup: fix case of member functions.
2020-12-04 johnstiles@google.com Disallow identifier names that overlap existing types.
2020-12-04 mtklein@google.com don't parse svgs we won't run
2020-12-04 reed@google.com Revert "Remove some flutter flags"

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC westont@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Cq-Do-Not-Cancel-Tryjobs: true
Bug: None
Tbr: westont@google.com
Change-Id: I72e9e5993d5f8092f87fe137d948ebb63c3d1753
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575099Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#833809}

BUG=1043200

Change-Id: Idec165bcfb959b75d789315703c69151cc6434b8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551320
Commit-Queue: Karan Bhatia <karandeepb@chromium.org>
Reviewed-by: Kelvin Jiang <kelvinjiang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#833808}

TBR=govind@chromium.org

Change-Id: I82b7c6bfe236eb122ca642e0141e75c9097706fb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2574599Reviewed-by: Ben Mason <benmason@chromium.org>
Commit-Queue: Ben Mason <benmason@chromium.org>
Cr-Commit-Position: refs/heads/master@{#833807}

https://chromium.googlesource.com/openscreen.git/+log/12b95e78a4d5..b9d9529da93a

2020-12-04 jophba@chromium.org Add RBE-CAS instance names to buildbucket

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/openscreen-chromium
Please CC jophba@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: jophba@chromium.org
Change-Id: I150c2969c5d97535c39bccf97907b9c55def5ffc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575217Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#833806}

Bug: 1071393
Bug: b/154204041
Test: web_engine_unittests
Change-Id: I3ba86964279ef7f467506d0781bee1e75b169a0e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2571699
Commit-Queue: Wez <wez@chromium.org>
Reviewed-by: David Dorwin <ddorwin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#833805}

CanRequestNewDndState indicates whether or not the DoNotDisturb feature
should be enabled for the Phone Hub UI.

Bug: 1155244
Test: chromeos_components_unittest
Change-Id: Ief42e2f3cefdcb2aa4a74b5e41a5f7329ae330c3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2572958
Commit-Queue: Jimmy Gong <jimmyxgong@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#833804}

Bug: 1116418
Change-Id: Icecc7124ce0f8e448a5ae95037eb3a3adfe7af2c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575296Reviewed-by: Yifan Luo <lyf@chromium.org>
Reviewed-by: Daniel Vogelheim <vogelheim@chromium.org>
Commit-Queue: Yifan Luo <lyf@chromium.org>
Cr-Commit-Position: refs/heads/master@{#833803}

Currently today OpenXR event pump does not have a callback to the render
loop and instead setting a state for session end and relies on the next
frame to check that state.  This is not reliable as most of the time,
the frame pump stops after sessions ends and the state logic has race
condition inside that changes as the code churns. This change add an
explicit callback to notify the end of a XR session so that the render
loop can reliably trigger the blink callback on session's end.

Bug: 1148648
Change-Id: I5447b0d053bbc1d575c9b509edc0ca5d6f76bca8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2535852
Commit-Queue: Phu Le <phle@microsoft.com>
Reviewed-by: Alexander Cooper <alcooper@chromium.org>
Cr-Commit-Position: refs/heads/master@{#833802}

This reverts commit 8d4df26b.

Reason for revert: 
Reverting for now -- this enables Finch configs for Lacros -- which in turn will turn on Vulkan backend for Skia, which can (sometimes) crash Lacros on launch.

Original change's description:
> Set "dev" channel for all lacros builds.
>
> Linux-chrome (of which lacros is a variant) has its channel set as a
> runtime environment variable by the launcher script. For Lacros, we must
> set the environment variable from ash. For now, we always set "dev" for
> all builds of Lacros.
>
> Change-Id: I840286b6fd5772701c3f6d927986405697b82097
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2570448
> Commit-Queue: Erik Chen <erikchen@chromium.org>
> Reviewed-by: James Cook <jamescook@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#833460}

TBR=jamescook@chromium.org,erikchen@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com

Change-Id: I25d3d72d27571645ef9b1723e624e75859579d8b
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2574803Reviewed-by: Erik Chen <erikchen@chromium.org>
Commit-Queue: Erik Chen <erikchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#833801}

TestPrintBackend was reworked to include a more consistent behavior
across its interfaces.  With this in place we can now update the testing
for print backend service to use AddValidPrinter() that ensures valid
printer definitions.

This allows the GetDefaultPrinterName test to be re-enabled and prepares
for further updates related to printer capabilities.

Bug: 809738
Change-Id: Iedf2d219da40cb508b6778f70889e86cccfb0052
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538365Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Commit-Queue: Alan Screen <awscreen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#833800}

Exposes necessary tail suggest fields of an autocomplete match, wrapped
in Foundation types.

Bug: none
Change-Id: Ia8a8a1e69befc3a8e510dfa196deda1544b9290e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2571876
Commit-Queue: edchin <edchin@chromium.org>
Reviewed-by: edchin <edchin@chromium.org>
Reviewed-by: Robbie Gibson <rkgibson@google.com>
Auto-Submit: Stepan Khapugin <stkhapugin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#833799}

Bug: 1155430
Change-Id: I5e323b8ecfdcdfbbbd9c98f575c864e17ff62d81
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2574078Reviewed-by: Finnur Thorarinsson <finnur@chromium.org>
Reviewed-by: Theresa  <twellington@chromium.org>
Commit-Queue: Gang Wu <gangwu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#833798}

Previously, we were using "key1", "key2", etc. as the GUIDs for our
test engines.

This was confusing, because "key1", etc. was also used for the keywords
to our test engines.

For clarity, we've changed all GUIDs of the form "key1" to "guid1",
and added a DCHECK to warn developers not to do it again.

No functional changes here, just a simple rename of constants in our
test files.

Bug: 1022775
Change-Id: I776feb17190942fc23e4c5a5d669bc0dbfec537b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2573339
Commit-Queue: Tommy Li <tommycli@chromium.org>
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#833797}

This reverts commit 4c19ca70.

Reason for revert: Broke NTP tests on MSan bots, see https://ci.chromium.org/ui/p/chromium/builders/ci/Linux%20MSan%20Tests/26482/test-results?expected=false&exonerated=true&flaky=true

Original change's description:
> [NTP][RQ] Adds field trial testing config for repeatable queries
>
> This is in preparation to promote the canary experiment which
> originally landed in cl/339288320 to Beta.
>
> Fixed: 1155314
> Change-Id: I4b87b89736e4cb461d416aacef98ed888596568c
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2573130
> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org>
> Reviewed-by: Weilun Shi <sweilun@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#833576}

TBR=mahmadi@chromium.org,sweilun@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com

Change-Id: I2f53745425e4df57bae943cbd3a4ab3c23de8cda
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575340Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#833796}

There are multiple reasons for which we show same message in case of
sign-in and check-in failure so we're adding an error code on the UI
to help distinguish the underlying reasons.

BUG=b:166322619
TEST=deploy to DUT, force the sign-in failure, verify message is shown

Change-Id: If8e758d02777c3aaa5ced74ac44eaa54dee8a59e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2569988
Commit-Queue: Muhammad Hasan Khan <mhasank@chromium.org>
Reviewed-by: Hidehiko Abe <hidehiko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#833795}

Apply batching to CriticalPersistedTabData tests so that they run
faster.

Bug: 1152295
Change-Id: I655e4ffe2f79a8549311b32a1f7ff760f3dda34e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2556453Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org>
Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Commit-Queue: David Maunder <davidjm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#833794}

The test creates a fake RELRO region in private memory and checks that
it is spawned into a sealed read-only shared memory region.

Since the normal way of using the ModernLinker involves a separate DSO
(=shared library), this would add more moving parts to base_unittests.
We prefer less advanced ways with GN, so another approach is chosen: all
the necessary code is linked with base_unittests.

Testing the way ModernLinker loads libraries would be difficult without
extra libraries pushed to the device, but RELRO region creation, sharing
and consumption can be tested using this approach.

Bug: 1154224
Change-Id: Ia78cce98f566084f6f799a7a35ab3cc45beb9346
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2571758Reviewed-by: Benoit L <lizeb@chromium.org>
Commit-Queue: Egor Pasko <pasko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#833793}