GitLab

This CL extends the following metrics:
  SBDownloadFeedback.UploadResult
  SBDownloadFeedback.SizeSuccess
  SBDownloadFeedback.ActiveFeedbacks
  SBDownloadFeedback.SizeFailure
There is planned work to make uploads more reliable, which will be tracked
by improvements in these metrics.

Bug: 988669
Change-Id: Ifb49101e348e95ce09a9fed8e54c6b193e0d903b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895388Reviewed-by: Brian White <bcwhite@chromium.org>
Commit-Queue: Daniel Rubery <drubery@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711920}

This CL restores the missing scrim when there is a single entry on the
navigation sheet. The repro step is unique in that it's the only
situation where the sheet with a single entry "Show full history" is
displayed. All the others show at least 2.

The scrim didn't appear since BottomSheet didn't trigger the event
|onSheetOpened|. The minimum swipable state is set to
peek(https://crrev.com/c/1880495), but the sheet height with a single
entry is smaller than that of the peek state (1.5 x entry height),
therefore didn't meet the condition that fires the event.

To address the issue, following changes were made:

1) BottomSheetContent disables peek/half state for this occasion so
that the sheet can go straight to full state.

2) Skip calling |expandSheet| but used BottomSheetContent state info
to have the same effect. The explicit call to the API, when combined
with the above change, causes the same state transition (full ->
full), which cancels the animation effect.

Bug: 1020408
Change-Id: I2b9d3d2f495a167dd844be82b9796bfeeb2fda81
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893129Reviewed-by: Matthew Jones <mdjones@chromium.org>
Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711919}

Form submission stopped working after crrev.com/c/1850358 when using
event.preventDefault() and form.submit() in a click event handler for a
<button type=submit> when the button has child elements and the click
was made on one of the child elements.

Bug: 1020086
Change-Id: I8976298ac56a64ff7033cb2f7b46ee5116229464
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1896050Reviewed-by: Mason Freed <masonfreed@chromium.org>
Commit-Queue: Joey Arhar <jarhar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711918}

This adds internal state to the PermissionWizard class, and logic to
show the UI for all pages and states of the wizard.

This also fixes the button action selectors and targets.

Bug: 1015201
Change-Id: I49690bceba7f9f55ae07ddde171b5a4eda4faa3c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895786
Commit-Queue: Lambros Lambrou <lambroslambrou@chromium.org>
Reviewed-by: Yuwei Huang <yuweih@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711917}

When the embedded Assistant is initially shown, it uses a small window.
When a big response arrives, its size is increased (to what is called
|ash::AppListViewState::kHalf|).  When this happened, the focus was lost
from the input text box (and moved to the - at this point not visible -
launcher search box).

This is fixed by updating the |AppListView| to not move the focus to the
launcher search box if the embedded Assistant UI is showing.

I also introduced a new |AssistantTextfield| which is used for inputting
text based queries. This makes things like logs and stacktraces easier
to parse as they will now mention |AssistantTextfield| instead of just
|Textfield| which is used everywhere.

test: Added unittests and manually verified.
bug: b/143715841
Change-Id: I4da2b363ec6c93b5bb166b415e45c60c08206810
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1896047
Commit-Queue: Jeroen Dhollander <jeroendh@google.com>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Tao Wu <wutao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711916}

Bug: 1014313
Change-Id: I21f170d67f92a3514040d2f8fb3315c0770379ee
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894254
Auto-Submit: Daniel Murphy <dmurph@chromium.org>
Commit-Queue: Brian White <bcwhite@chromium.org>
Reviewed-by: Brian White <bcwhite@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711915}

Using wpt-import in Chromium a9ceb3fa.
With Chromium commits locally applied on WPT:
1d5b803f "Add WebVTT support for inline styling - Web Platform Tests"
9be931cb "[WPT/common/security-features] Refactor navigable tests"


Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
rego@igalia.com:
  external/wpt/css/vendor-imports/mozilla/mozilla-central-reftests

NOAUTOREVERT=true
TBR=raphael.kubo.da.costa

No-Export: true
Change-Id: Icf9092a879be83b1c407b0759f4bb465d907e67d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895799Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#711914}

Uses explicit deletion instead, removes use of base/macros.h.

Bug: chromium:1010217
Change-Id: I187bba0ded61bd50a0488fe9f5f001e032d5ae0b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1836134
Commit-Queue: Peter Boström <pbos@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711913}

My best idea to address Oshima's code review comment at [1] is by
renaming things to reflect workflows, and as a first step toward doing
so, the present CL removes IndicatorState::kDragAreaLeft which does not
correspond to any workflow. The current split view drag indicators code
is full of naming that attempts to describe visuals but does so
inadequately. Look at the code comment that I am adding to
DragWindowFromShelfController::GetIndicatorState in [2]. Even worse than
that, look at the comments on the following unit tests:
SplitViewTabDraggingTest.DragSnappedWindow
SplitViewTabDraggingTest.DragSnappedWindowWhileOverviewOpen

[1] https://chromium-review.googlesource.com/c/chromium/src/+/1894754/1/ash/wm/splitview/split_view_highlight_view.cc
[2] https://chromium-review.googlesource.com/c/chromium/src/+/1894754/1/ash/home_screen/drag_window_from_shelf_controller.cc

Bug: None
Change-Id: I4f9cb85c818023c0a3b5c12e818d3a3ccf56e158
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895390Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Commit-Queue: Avery Musbach <amusbach@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711912}

Bug: 1020384
Change-Id: Ief2a422511d70b667aea3d7b48d5731848ba2bd1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895888Reviewed-by: Ben Pastene <bpastene@chromium.org>
Commit-Queue: Tina Lu <ltina@google.com>
Cr-Commit-Position: refs/heads/master@{#711911}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/a95cbb23f5dc..9faf2ee6c3b6

git log a95cbb23f5dc..9faf2ee6c3b6 --date=short --no-merges --format='%ad %ae %s'
2019-11-01 bpastene@chromium.org cros_chrome_sdk: Print a link to a board's builder when its SDK is missing.

Created with:
  gclient setdep -r src/third_party/chromite@9faf2ee6c3b6

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromite-chromium-autoroll
Please CC chrome-os-gardeners@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel
TBR=chrome-os-gardeners@google.com

Bug: None
Change-Id: I701aee03d28d23a690649f96b5e709fdda4afe2f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1896095Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#711910}

Speculatively fixes RenderWidget::DidCommitAndDrawCompositorFrame in
performance_browser_tests not being parsed as a perf result by changing
it to RendererFrameDraw. It is believe that the colons in the original
name were interfering with the parser script's ability to correctly
extract the metric name.

Bug: 923564
Change-Id: I3f5a91a0b11ea8a6bd3363b8ecf6aa044a8425d4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888774
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Reviewed-by: Yuri Wiitala <miu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711909}

The following bots:
  Linux FYI Debug (NVIDIA)
  Linux FYI GPU TSAN Release
  Linux FYI Release (AMD R7 240 / Intel [U]HD 630 / NVIDIA)

  Mac FYI Debug (Intel)
  Mac FYI Retina Debug (AMD / NVIDIA)
  Mac FYI GPU ASAN Release
  Mac FYI Release (Intel)
  Mac FYI Retina Release (AMD / NVIDIA)
  Mac Pro FYI Release (AMD)

  Win10 FYI x64 Release (NVIDIA GeForce GTX 1660)
  Win10 FYI x64 Debug (NVIDIA)
  Win10 FYI x64 Exp Release (Intel HD 630)
  Win10 FYI x64 Release (AMD RX 550 / Intel [U]HD 630 / NVIDIA)

Will run the following tests:
  dawn_end2end_tests
  dawn_end2end_validation_layers_tests
  dawn_end2end_wire_tests

On the DEPS version of Dawn

Bug: chromium:1016948
Change-Id: I91029164d935e4d91d28eb3b802232a358645b0c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873288
Commit-Queue: Austin Eng <enga@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711908}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/5689bf7c..aadf1619

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I3d807da2280ea357275b0c648e4786111b94c215
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895397Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#711907}

When loading the offline dino after a navigation, the UserAgent is reset
to the CriOS user agent. This CL makes sure that we also consider that
we are on iOS when CriOS is present in the UserAgent.

Bug: 1008774
Change-Id: I67238b0f137e626476e635593651b8d716472cd5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893959Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Auto-Submit: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711906}

Always activate MetricsAndCrashSampling so that we can emulate the
sampling for users that didn't apply it client side.

Adds a feature that we can use to start having all clients apply it.

Change-Id: I497f36bc093945b225db853fe4d271680cab1e8e
Bug: 1016572
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872988
Commit-Queue: Steven Holte <holte@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711905}

This CL moves the MPRIS implementation into the SystemMediaControls
component. It deletes the usage of the MPRIS-specific API in favor of
the platform-agnostic SystemMediaControls API.

Public design doc:
https://docs.google.com/document/d/1_UjhXdXzQlPEwFKpogTZm-ILylKid4lTiOomqHv-IPg/edit?usp=sharing

Bug: 949596
Change-Id: I2af605dd742969fa474dfe14ec62167ebb80852b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895385Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Tommy Steimel <steimel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711904}

This change moves the LevelDBScopes implementation from content/browser
to componenets/services/storage.

Other than the file moves (and associated macro, include, and export
updates), this change:
* Deletes the BarrierBuilder in lieu of having an anonymous version in
  the unittests file directly.
* Moves the scopes lock range test for IndexedDB-specific lock ranges
  to indexed_db_unittest, as that is where the test should go.

R: rockot@google.com
Bug: 1015212
Change-Id: Ied21b955b903d06621798091771a46d4f3e47854
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895863Reviewed-by: Ken Rockot <rockot@google.com>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Daniel Murphy <dmurph@chromium.org>
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Auto-Submit: Daniel Murphy <dmurph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711903}

TBR=govind@chromium.org

Change-Id: I545c54194a85de91756881e42b67d2d6cd70428e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895972Reviewed-by: Ben Mason <benmason@chromium.org>
Reviewed-by: Krishna Govind <govind@chromium.org>
Commit-Queue: Ben Mason <benmason@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711902}

This DCHECK was first added in
http://crrev.com/19b1b85cd5c3227697d348a39cec89ddf5980690

But the code in question could be run as root, in the case when
curtain-mode is false. The host only aborts running as root if curtain
mode is enabled. The host service explicitly runs in both "Aqua" and
"LoginWindow" contexts, as specified in the launchd agent's plist.

Instead, this CL skips the permission-checks when host runs as root.

Change-Id: Idf07719d0780f3627290e96710c36d0fe98e8f7a
Bug: 1020739
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1896122
Commit-Queue: Lambros Lambrou <lambroslambrou@chromium.org>
Commit-Queue: Jamie Walch <jamiewalch@chromium.org>
Auto-Submit: Lambros Lambrou <lambroslambrou@chromium.org>
Reviewed-by: Jamie Walch <jamiewalch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711901}

Bug: 1010217
Change-Id: Iaa1d73bfec3522db08d04bedeb59603e16c8ffe0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895857
Auto-Submit: Peter Kasting <pkasting@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711900}

This adds time of profiling done, duration, title, icon.
Also it includes new event when buffer was committed.
In addition tracing is automatically stopped on active tracing window is
gone to simplify reading testing results.

TEST=Locally
BUG=b/143532713

Change-Id: I6b9fa7ba2a1628172949c856e7be7ef984505e3e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894040Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Commit-Queue: Yury Khmel <khmel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711899}

MRFileDialog's delegate (MediaRouterViewsUI) may get deleted before
MRFileDialog if the Cast dialog somehow gets closed before the file
selection dialog does. Use a WeakPtr to prevent crashes in this scenario.

Bug: 1019925
Change-Id: Ibcc6e9f8297e5a40777acb87767e127afe04d197
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894970Reviewed-by: Brandon Tolsch <btolsch@chromium.org>
Commit-Queue: Takumi Fujimoto <takumif@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711898}

Remove unused variable after issue 1536474
(commit 0f755b17)

|status_label_| is used instead |status_text_|.

Change-Id: I56ce991f5e88dbfe8957f920c26a4a1249b69676
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893254Reviewed-by: Min Qin <qinmin@chromium.org>
Reviewed-by: Shakti Sahu <shaktisahu@chromium.org>
Commit-Queue: Shakti Sahu <shaktisahu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711897}

https://chromium.googlesource.com/catapult.git/+log/840ecb38c04e..f5eca592259a

git log 840ecb38c04e..f5eca592259a --date=short --no-merges --format='%ad %ae %s'
2019-11-01 dproy@chromium.org Update reference binaries

Created with:
  gclient setdep -r src/third_party/catapult@f5eca592259a

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/catapult-autoroll
Please CC oysteine@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=oysteine@google.com

Bug: None
Change-Id: I114100b2f64bdea199ed76ab7f4288e829888e8c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895874Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#711896}

https://chromium.googlesource.com/angle/angle.git/+log/fe26bae45243..422ebad20adb

git log fe26bae45243..422ebad20adb --date=short --no-merges --format='%ad %ae %s'
2019-11-01 jmadill@chromium.org Fix ANGLE_get_image cube map handling.
2019-11-01 shrekshao@google.com Reorder BaseVertexBaseInstance draw calls parameters

Created with:
  gclient setdep -r src/third_party/angle@422ebad20adb

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-chromium-autoroll
Please CC ynovikov@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=ynovikov@google.com

Bug: chromium:891861
Change-Id: I0da4784fbcc34806630a1f9ee3e0ac97682fe2c1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895940Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#711895}

They're failing on every run

R=crouleau@chromium.org

Bug: chromium:1013295, dawn:208, dawn:254
Change-Id: I77ef362f798ccde18023d3744c8c3a06e13708dd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895114Reviewed-by: Caleb Rouleau <crouleau@chromium.org>
Commit-Queue: oysteine <oysteine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711894}

CL:1800725 changed FidoRequestHandlerBase's |notify_observer_callback_|
barrier to block on each of the discoveries sending DiscoveryStarted()
before reporting transport availability to the UI layer. However, on a
machine with BLE available but powered off, FidoBleDiscoveryBase will
never invoke DiscoveryStarted() until the adapter is powered on.
Powering on the adapter is triggered by the UI after receiving the
transport availability callback. Hence, with a powered-off BLE adapter,
on requests instantiating the BLE discovery transport availability
callback was never invoked, and as a result the UI never appeared.

As it happens, the DiscoveryStarted() callback is rather redundant
anyway. It's important for the platform discoveries (TouchID, Windows)
as a way of ensuring their authenticators are added to the request
handler, before signaling transport availability to the UI. But for
Bluetooth specifically, there is a separate callback for determining
Bluetooth availability and power status that the barrier waits on.
Nothing the Bluetooth discovery does actually requires the UI to block.

Therefore, this change modifies FidoBleDiscoveryBase to invoke
DiscoveryStarted() right after enumerating Bluetooth adapters. As a side
effect, the boolean |success| argument to DiscoveryStarted() now only
signals whether the discovery found an adapter, whereas previously it
also indicated e.g. whether caBLE advertising succeeded. But that
doesn't really seem to matter since that argument is only ever consumed
in unit tests anyway.

Fixed: 1018416
Change-Id: I33549a24b1c399fee61374e44f5478f10d9db71d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881974Reviewed-by: Adam Langley <agl@chromium.org>
Reviewed-by: Nina Satragno <nsatragno@chromium.org>
Commit-Queue: Martin Kreichgauer <martinkr@google.com>
Cr-Commit-Position: refs/heads/master@{#711893}

This CL converts PeerConnectionTracker away from string,
to use WTF::String.

Note that there is still left over std::string when it is
needed to interface with libwebrtc.

Other classes got minimally changed to adapt to the changes
needed for PeerConnectionTracker, but will have their own conversion
round next.

BUG=787254
R=guidou@chromium.org, haraken@chromium.org

Change-Id: I94c05b7d7830bba16e05a3fb7b2bfb8c063ab61b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880961
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711892}

See crbug.com/1019139#c8 for this change's motivation.

See https://chromium-review.googlesource.com/c/catapult/+/1894511
for catapult-side change.

This change will be followed up with another change
restricts the exit code to 111 completely (That can't
be done until catapult side change lands, and that
change can't land until this one does.)

Bug: 1019139
Change-Id: If0243e792282cfcbcbeb2a943648efd7916e1d57
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893823
Commit-Queue: Caleb Rouleau <crouleau@chromium.org>
Auto-Submit: Caleb Rouleau <crouleau@chromium.org>
Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711891}

Ensuring that users don't get a WebAuthn opt-in promo while in incognito mode.
This also avoids a browser crash if a user attempts to downstream incognito.

Bug: 949269
Change-Id: I2b4af11a8bb1d8df115f0748d30d8785a99cfacc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894291
Commit-Queue: Manas Verma <manasverma@google.com>
Reviewed-by: Jared Saul <jsaul@google.com>
Cr-Commit-Position: refs/heads/master@{#711890}

This is called when the page uses window.open, or an anchor with an
href=blank.

BUG=none
TEST=none (will be covered via instrumentation test)

Change-Id: I0e0b1aeb776f1eb4712295bcd790c357dcf0a047
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894673
Commit-Queue: Scott Violet <sky@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711889}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/ab7bec343496..c39a77883d7b

git log ab7bec343496..c39a77883d7b --date=short --no-merges --format='%ad %ae %s'
2019-11-01 iannucci@chromium.org [gclient] Reset to parent commit with rebase_patch_ref=False instead of master.

Created with:
  gclient setdep -r src/third_party/depot_tools@c39a77883d7b

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/depot-tools-chromium-autoroll
Please CC agable@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

TBR=agable@chromium.org

Bug: None
Change-Id: Ifc638852ad10a622c64d6052e597c2236586e286
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895917Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#711888}

crrev.com/c/1713826 flipped slashes from / to \ so that clang-cl
commands could be copy/paste run on Windows. While investigating a
recent compiler bug I had the need to copy/paste run linker commands on
Windows and realized that I hadn't flipped those slashes. This change
finishes the job, for lib/link commands, tested with component and
non-component builds of base.


Change-Id: If5570ab3093b42908bebab9944cde82da31a055d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894094
Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711887}

This is a reland of 856b8913

The iOS issue was resolved by 9124e345
and a corresponding internal CL.

Original change's description:
> Limit GN visibility of libxml for security audit control.
>
> This splits the libxml_utils helper classes into xml_reader and
> xml_writer targets. The xml_writer can be safely used from any target.
> The xml_reader has strictly limited visibility to locations that are
> audited by the Security Team. Direct access to the libxml target is now
> also limited.
>
> Bug: 699306
> Change-Id: I141de7d855f5cb8e886e99403e048cf331f7320c
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884750
> Reviewed-by: Nico Weber <thakis@chromium.org>
> Reviewed-by: David Benjamin <davidben@chromium.org>
> Reviewed-by: Owen Min <zmin@chromium.org>
> Reviewed-by: Rohit Rao <rohitrao@chromium.org>
> Reviewed-by: Reilly Grant <reillyg@chromium.org>
> Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> Commit-Queue: Robert Sesek <rsesek@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#711536}

Tbr: thakis@chromium.org
Tbr: davidben@chromium.org
Tbr: rohitrao@chromium.org
Bug: 699306
Change-Id: I633309f7efc3c920b97dced173607d73dc48d991
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894877
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Owen Min <zmin@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711886}

Bug: 1020609
Change-Id: I84fb6c13ca3ab0d3002853b17772775a7ff3eb54
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895968Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Gang Wu <gangwu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711885}

- For input and generated PDFs, validate all the page sizes.
- Set the page size / printable area to 72 DPI, which is what the
  PdfNupConverterClient normally receives.

Bug: 1004529
Change-Id: I615b014c08332a55c395f06352424fe1c96a4601
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895071
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711884}

Currently markers are assigned a mostly empty style, it just inherits
from the list item and has some customizations like `display`.

This patch makes them use the style of the ::marker pseudo-element.
The inheritance is also from the list item, and the customizations are
applied afterwards.

The change only affects markers originated by real elements. Markers
originated by ::before or ::after pseudo-elements should get the styles
from ::before::marker or ::after::marker, but this will be addressed in
a follow-up patch.

Spec: https://drafts.csswg.org/css-pseudo-4/#marker-pseudo

BUG=457718

TEST=external/wpt/css/css-pseudo/marker-and-other-pseudo-elements.html
TEST=external/wpt/css/css-pseudo/marker-color.html
TEST=external/wpt/css/css-pseudo/marker-font-properties.html

Change-Id: Ide2fbc344e4732257044ebd3e7966906af21c434
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893265Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Commit-Queue: Oriol Brufau <obrufau@igalia.com>
Cr-Commit-Position: refs/heads/master@{#711883}

This CL helps to calculate the hotseat's state based on the app list's
visibility when the chromevox is enabled. If the app list shows,
it ensures that the hotseat's state is kShown instead of kExtended.

Bug: 1020417
Change-Id: I2354af512939c91bbcf707115ab9882856c6c78a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893961Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Andrew Xu <andrewxu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711882}

Fix cases where the focus was lost when navigating back from
 - chrome://settings/content/serialPorts
 - chrome://settings/content/all

Bug: None
Change-Id: Ibbd149272593264131787bae1df9106e8de60b3a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894832
Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Jordy Greenblatt <jordynass@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711881}