GitLab

https://quiche.googlesource.com/quiche.git/+log/5a39301cb829..98502c3bedc6

$ git log 5a39301cb..98502c3be --date=short --no-merges --format='%ad %ae %s'
2020-04-02 wub gfe-relnote: (n/a) In QUIC BBRv1, default enable connection options LRTT and BBQ2, and deprecate unused QUIC connection options BBS1 and BBRS. Protected by --gfe2_reloadable_flag_quic_bbr_default_exit_startup_on_loss.
2020-04-02 bnc gfe-relnote: undeprecate gfe2_reloadable_flag_quic_create_incoming_stream_bug
2020-04-02 bnc Use |offset| in QuicReceiveControlStreamTests for easier readability.
2020-04-02 bnc gfe-relnote: Emit H3_SETTINGS_ERROR and H3_MISSING_SETTINGS when appropriate.  Protected by gfe2_reloadable_flag_quic_enable_version_draft_25_v3 and gfe2_reloadable_flag_quic_enable_version_draft_27.
2020-04-01 quiche-dev Add Pigeon USPS GSO Support via quic::PigeonWriter.
2020-04-01 dschinazi Add default returns to MockSendAlgorithm bandwidth calls
2020-04-01 dschinazi Improve decryption error logging
2020-04-01 renjietang Remove QuicStreamIdManager::DelegateInterface::OnStreamIdManagerError().
2020-04-01 wub gfe-relnote: False deprecate --gfe2_reloadable_flag_quic_bbr_startup_rate_reduction.
2020-04-01 dschinazi Parameterize QuicSecretTest by QUIC version
2020-03-31 dschinazi Fix DebugDFatalIfMarkingClosedStreamWriteBlocked test
2020-03-31 renjietang Remove unnecessary error check in QuicStreamIdManager.
2020-03-31 dschinazi Parameterize QuicCryptoClientHandshakerTest by version

Created with:
  roll-dep src/net/third_party/quiche/src

R=bnc@chromium.org

Change-Id: Iebf28bf21288f6bc1d19e882c86c633315085231
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134687Reviewed-by: Bence Béky <bnc@chromium.org>
Commit-Queue: Victor Vasiliev <vasilvv@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755950}

Their usage was removed in https://crrev.com/706442.

Change-Id: Ib8d01db98766737899826bcb1432461332f6201c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2133268Reviewed-by: Roman Sorokin [CET] <rsorokin@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755949}

https://webrtc.googlesource.com/src.git/+log/55c991cc81ae..de6fa1ef2946

git log 55c991cc81ae..de6fa1ef2946 --date=short --first-parent --format='%ad %ae %s'
2020-04-02 brandtr@webrtc.org Reland "Let WebRtcVideoChannel::ResetUnsignaledRecvStream delete all default streams."
2020-04-02 titovartem@google.com Move media configuration for PC level tests into separate class
2020-04-02 mbonadei@webrtc.org Replace std::string::find() == 0 with absl::StartsWith (part 2).

Created with:
  gclient setdep -r src/third_party/webrtc@de6fa1ef2946

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/webrtc-chromium-autoroll
Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: webrtc-chromium-sheriffs-robots@google.com
Change-Id: I128329895e4150358236063a17fcdfc43e3182fa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134707Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#755948}

Bug: chromium:1060795,chromium:1066073,chromium:1066074,chromium:1066075,chromium:1066076,chromium:1066077,chromium:1066078,chromium:1066079,chromium:1066080,chromium:1066081,chromium:1066082,chromium:1066083,chromium:1066084,chromium:1066085,chromium:1066086
Change-Id: I598cb9202776de5976b28826e0f02fa4edef5af2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2128308Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Commit-Queue: Robert Kaplow <rkaplow@chromium.org>
Auto-Submit: Ilya Nikolaevskiy <ilnik@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755947}

This allows us to better disambiguate whether we had attempted to fetch
for the navigation at all. Currently, we could do something around
host covered status but that does not provide the full picture.

Bug: 1054649
Change-Id: Ie39d0e3e83fde149a8a6e40e8aacbcc033e57dc2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2128087Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Michael Crouse <mcrouse@chromium.org>
Commit-Queue: Sophie Chang <sophiechang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755946}

Bug: b/67907746
Test: cast_crash_storage_impl_fuchsia_unittest
Change-Id: I7aa6f23cad265179db35720a7344709fe40bd4aa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120098
Commit-Queue: Christopher Whelan <chwhelan@google.com>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Michael Spang <spang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755945}

COOP was parsed for redirects already, but not properly enforced.
This patch makes sure any redirect combination that would have led to a
switch does put the final URL in a separate BrowsingInstance.

Change-Id: Ia289cf661add09a8e86392c7c650219b90ac0a1b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132220Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
Commit-Queue: Arthur Hemery <ahemery@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755944}

Computed style for outline-offset was not returning the proper value
if "outline-style" was "none".
This was due to a check in ComputedSyle::OutlineOffset()
that this patch removes.

This code could be there because this is needed for "outline-width"
as specified in the spec [1], however there's nothing about this
on the "outline-offset" property.

This patch modifies outline-offset-computed.html, as it had
some extra lines (similar to what's needed for "outline-width")
to make it work in Chromium (and WebKit https://webkit.org/b/209913)
due to this bug.

[1] https://drafts.csswg.org/css-ui/#outline-props

Bug: 1005372
Test: css/css-ui/parsing/outline-offset-computed.html
Change-Id: Ief8d4fe22c462ec2bb493b20b1b22b8d0797e1ee
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134133Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Commit-Queue: Manuel Rego <rego@igalia.com>
Cr-Commit-Position: refs/heads/master@{#755943}

Suppress -Wunreachable-code-return warnings that can be fixed easily by rejiggering preprocessor conditions.

No behavior change.

Bug: chromium:1066980
Change-Id: I151bbd88ef39e18ae8f07c3e32e4b21de26520df
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132780
Auto-Submit: Nico Weber <thakis@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755942}

No change to production logic. This adds a "--webview-verbose-logging"
flag to WebView, intended to replace the "log verbosifier" app. Log
verbosifier was designed to work on production Android images, where we
couldn't specify an arbitrary commandline flag. However, Dev UI will
support commandline flags even on production devices, so the log
verbosifier is obsolete.

This does not remove support for log verbosifier for the time being,
although I intend to deprecate and remove support soon (I'll let M83 be
a transition milestone).

Bug: 988200
Test: Verify the flag is picked up by Dev UI and it works as expected
Test: Verify log verbosifier app independently still works (tested on Q)
Change-Id: I1e75c9c1fdfe09144a40d2717e2024272cc9264d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2133274
Commit-Queue: Nate Fischer <ntfschr@chromium.org>
Reviewed-by: Richard Coles <torne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755941}

It is already included in the parent DEPS file.

Change-Id: Iaf5d8c59cb50b17a2a4e229c894b8e7c3a07601c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2131294
Auto-Submit: David Dorwin <ddorwin@chromium.org>
Commit-Queue: Kevin Marshall <kmarshall@chromium.org>
Reviewed-by: Kevin Marshall <kmarshall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755940}

Bug: 1060800
Change-Id: I7e28e1e57458d26577cc06413e35db921cd583de
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134566Reviewed-by: Sorin Jianu <sorin@chromium.org>
Commit-Queue: Mila Green <milagreen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755939}

The pre-FormControlsRefresh date picker considered the cell with
'highlight' to be the active cell with respect to ARIA, and it was the
highlighted cell that moved around by arrow-key navigation.  In the
refreshed design, highlight is no longer managed in JS, and the cell
marked as 'selected' in JS is the one that is moved around by arrow-key
navigation and is therefore the one that should be considered focused
by accessibility.  However the management of aria-activedescendant and
aria-selected was never migrated from highlight to selection. This
change does this migration.

For test coverage, the change re-enables
DumpAccessibilityTreeTest.AccessibilityInputDateWithPopupOpen and
modifies it to dump the full popup tree instead of stopping at the
'Today' button.  The column header values are skipped so that the
/blink subtest doesn't produce different results on different
platforms (Windows uses Mo/Tu/We etc instead of M/T/W/etc for the
day  abbreviation localizations).

date/week/month-picker-ax.html are updated to account for the extra
MarkDirty events that are fired to to the fact that focus/selection
is now being managed again for the calendar cells.  month-picker-ax.html
is moved to promise_test to match the format of the other two tests and
changed to assert instead of timing out on failure.

Bug: 1022920,1054901
Change-Id: Iaa98605582a12fcf44d87748ca3bc572518528fc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2111750
Commit-Queue: Dan Clark <daniec@microsoft.com>
Reviewed-by: Kevin Babbitt <kbabbitt@microsoft.com>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Mason Freed <masonfreed@chromium.org>
Reviewed-by: Ionel Popescu <iopopesc@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#755938}

BUG=702154

Change-Id: Ic5b338b9c4a59be0d777b38c6341d9ca293ba9bb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2131152
Commit-Queue: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Reviewed-by: Peter Wen <wnwen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755937}

This component provides ShellMainDelegate, an implementation of
ContentMainDelegate that creates the various Content Shell-based
interfaces for each process. It can be asked to create web test
versions of these interfaces also.

This component will be able to see web_test components, while
content_shell_lib will not need to anymore. (At least in the renderer
so far.) This will allow us to
1) make content/shell/renderer/web_test into a separate component
2) merge test_runner into that same component (or vice versa?) without
   regressing separation by merging test_runner into content_shell_lib.

The dependency graph would be like
content_shell_app -> content_shell_lib
content_shell_app -> web_test_renderer -> content_shell_lib

R=avi@chromium.org

Bug: 866140
Change-Id: I7f530851b60e478260d681b0c43b089d630a6b77
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132940Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755936}

This is a reland of c00c874f

Original change's description:
> clang build.py: change LLVM_ENABLE_ZLIB from ON to FORCE_ON
> 
> This uses the FORCE_ON option to enable zlib to ensure that clang
> actually finds and uses zlib. Also moved this setting out of
> base_cmake_args so that it is only used in the main clang build,
> since there is another 32-bit build that can't use this zlib.
> 
> Also changed to remove and re-download the zlib source on
> every build.
> 
> Change-Id: Ifceabc2ba06e4e4a56464f18de80610a0f043641
> Bug: 1061189
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2118674
> Commit-Queue: Amy Huang <akhuang@google.com>
> Reviewed-by: Nico Weber <thakis@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#753301}

Bug: 1061189
Change-Id: If208eab801b1105814979134d0c75092c8c3f396
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2126970Reviewed-by: Hans Wennborg <hans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755935}

Bug: 927509
Change-Id: Icc150445dd72857d9d85fa2939e77bd7b1718c00
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132399
Commit-Queue: Brian White <bcwhite@chromium.org>
Auto-Submit: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Brian White <bcwhite@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755934}

These were left unused after https://crrev.com/582971.

Change-Id: I3b57367c49367331709eb3b208e1e5fecd3fda74
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2133121Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755933}

These were left unused after https://crrev.com/605294.

Change-Id: I7a4ea28e498d344252779c3379ff69d73d89695c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2133565Reviewed-by: Justin Cohen <justincohen@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755932}

This new FeatureList class contains the
IMPROVED_COOKIE_CONTROLS[_FOR_THIRD_PARTY_COOKIE_BLOCKING] features,
which are used by Clank's Site Settings UI, which is in the process of
being componentized so it can be used by WebLayer.

Bug: 1058597
Change-Id: I46ceae9dc71e6d96b89278fe7fd28ebfdf8e337d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2123336Reviewed-by: Christian Dullweber <dullweber@chromium.org>
Reviewed-by: Henrique Nakashima <hnakashima@chromium.org>
Reviewed-by: Theresa  <twellington@chromium.org>
Reviewed-by: Finnur Thorarinsson <finnur@chromium.org>
Commit-Queue: Robbie McElrath <rmcelrath@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755931}

Bug: 1066980
Change-Id: Iad325860483f84b7d1538f1908daf145b45ff8fc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2133924
Commit-Queue: Nico Weber <thakis@chromium.org>
Commit-Queue: Ian Clelland <iclelland@chromium.org>
Auto-Submit: Nico Weber <thakis@chromium.org>
Reviewed-by: Ian Clelland <iclelland@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755930}

This reverts commit 9dc21ef5.

Reason for revert: This identified the root cause of a flaking test is a bug within the gpu frame submission code path. More work is needed to debug the root cause. In the interim I'm removing this logging until someone can take a closer look

Original change's description:
> Add logging when receiving an invalid frame token
> 
> To investigate issue 1045372 some crash keys were added to log the old
> and new frame tokens however this doesn't work for the flaky browser
> tests I am investigating in issue 1022321. This change adds log messages
> which should show up when the test flakes.
> 
> Bug: 1022321
> Change-Id: If1c88d1cea3dc771c96a4d636b6797a8686b6315
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2123030
> Auto-Submit: Reilly Grant <reillyg@chromium.org>
> Commit-Queue: Jonathan Ross <jonross@chromium.org>
> Reviewed-by: Jonathan Ross <jonross@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#754145}

TBR=jonross@chromium.org,reillyg@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 1022321
Change-Id: Ibdcf7b30b77f836bb3d0257c77c056c31f554298
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134608Reviewed-by: Jonathan Ross <jonross@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Commit-Queue: Jonathan Ross <jonross@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755929}

This CL fixes the issue where text runs after overlapping annotations
are not added to the accessibility tree. In the loop where text runs are
added to the accessibility tree, some text runs are skipped due to
incorrect normalization after overlapping annotations are added to the
tree.

Tests have been added to validate the scenario.

Fixed: 1066802
Change-Id: I6e7b3c72d9c25c45033a057d44261e888e9e7796
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2131808Reviewed-by: Kevin Babbitt <kbabbitt@microsoft.com>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Ankit Kumar 🌪️ <ankk@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#755928}

MarketingBackendConnector communicates over the Access Points API
to set the user's preference regarding marketing emails. The component
will be used on the last screen of OOBE - Marketing opt-in screen.

Bug: 1056672
Change-Id: I7f3b43b80395ab19c1dfc3313b91453f2e314bd8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2128492
Commit-Queue: Renato Silva <rrsilva@google.com>
Reviewed-by: Denis Kuznetsov [CET] <antrim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755927}

This prevents TaskEnvironment::FastForwardBy() from instantiating
ScopedBlockingCalls and confusing internal //base tests.

It is also conceptually correct as we wouldn't want to replace
worker threads blocked on TestTaskTracker.

R=fdoray@chromium.org

Bug: 1064645
Change-Id: I304ccbf270177ddb1435aed81e52b26fe9b5a41b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2133049Reviewed-by: François Doray <fdoray@chromium.org>
Commit-Queue: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755926}

OWASP documentation has seemed to move to
https://cheatsheetseries.owasp.org. The source can be found on
https://github.com/OWASP/CheatSheetSeries/blob/master/cheatsheets/, but
all of the old material that our CORB documentation links to is now
hosted on their new site.

R=yhirano@chromium.org

Change-Id: I7c171f709816d69615ff82c10b8bb8fc9c51e08a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134569
Commit-Queue: Dominic Farolino <dom@chromium.org>
Reviewed-by: Łukasz Anforowicz <lukasza@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755925}

This matches the behavior of regular extension install dialog in
the same situaton, because the parent permission dialog is never used
for delegated permissions, which the only time optional permissions
are shown in the regular extension install dialog, as can be seen at:
https://cs.chromium.org/chromium/src/chrome/browser/extensions/extension_install_prompt.cc?l=602

See bug for a concrete example of where this inconsistency appears.

Bug: 1067037
Change-Id: I5aab8d159d9abc8ba73347be187d0fdcb4034a70
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2133217Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Dan S <danan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755924}

This CL disables the notification if shelf navigation buttons
are enabled for accessibility in tablet mode.

Bug: 1066914
Change-Id: I3fa6dbae462df614154c5a5727800eb4a0a4b625
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2133116Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Ahmed Mehfooz <amehfooz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755923}

Bug: 1025603
Change-Id: Ie2ef10c03b9ffea77436c0932727d1545fcf895f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132540Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Min Qin <qinmin@chromium.org>
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755922}

This moves helper code that the browser uses over to the browser/
directory and removes the DEPS rules that were left to support this
violation.

R=avi@chromium.org

Bug: 866140
Change-Id: Ib49c7e5e6f64f34db87a73ef5368384ee73e1c19
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2133876Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755921}

https://android.googlesource.com/platform/external/perfetto.git/+log/586f781bd78b..96e14888195d

git log 586f781bd78b..96e14888195d --date=short --first-parent --format='%ad %ae %s'
2020-04-02 lalitm@google.com Merge "tp: fix returning utid of freed thread in rss stat event"

Created with:
  gclient setdep -r src/third_party/perfetto@96e14888195d

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-chromium-autoroll
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: perfetto-bugs@google.com
Change-Id: I4f7e3ad75b1468de8a242f61d6f25994a96a4904
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134357Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#755920}

Drive-by: update video tests to return correct promise and improve
style.

Bug: 1052765
Change-Id: Id1c31b577f0431b2073f0ae486926283aca41759
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132200
Commit-Queue: Guido Urdaneta <guidou@chromium.org>
Reviewed-by: Marina Ciocea <marinaciocea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755919}

This reverts commit 26f39e78.

Reason for revert: it has passed

Original change's description:
> CL to verify that presubmit does not know anythyng about includes
> 
> This CL tests whether we have existing presubmit check to remove
> includes that are not needed
> 
> Change-Id: I821b3cefdc82c8bddf8be20a711af5b121822d82
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879922
> Reviewed-by: Anatoliy Potapchuk <apotapchuk@chromium.org>
> Reviewed-by: Oleg Davydov <burunduk@chromium.org>
> Commit-Queue: Anatoliy Potapchuk <apotapchuk@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#755881}

TBR=apotapchuk@chromium.org,burunduk@chromium.org

Change-Id: I763613a4d48113c515cae121af544ccc1cb95bdd
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2133931Reviewed-by: Anatoliy Potapchuk <apotapchuk@chromium.org>
Commit-Queue: Anatoliy Potapchuk <apotapchuk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755918}

The tests were not initializing the font correctly nor were they
waiting for it to load. This should fix those issues, however the
2d.text.measure.width.space test still fails because of how collapsing
whitespace works. Not sure if this a bug in the test or implementation.

BUG=1066953

Change-Id: I2f0b81da891e6c701b1c9aa7d8d871615ab0ca28
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132674Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Reviewed-by: Robert Ma <robertma@chromium.org>
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755917}

TBR=kinuko@chromium.org

Bug: 1058600
Change-Id: I7eb62790b096cacde13fd0392caa71a7bfc35a7a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2131358Reviewed-by: Evan Stade <estade@chromium.org>
Reviewed-by: Robbie McElrath <rmcelrath@chromium.org>
Reviewed-by: Natalie Chouinard <chouinard@chromium.org>
Reviewed-by: Finnur Thorarinsson <finnur@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755916}

This reverts commit 55ee8df4.

Reason for revert: This test is flaking at 10% rate. It is dealing with a race condition inside the GPU frame submission code path. We are disabling it until someone has the time to sort out the root cause.

Original change's description:
> Revert "Disable WebBluetoothTest.WebBluetoothAfterCrash"
> 
> This reverts commit cc673fd0.
> 
> Reason for revert: Unable to reproduce test flakiness.
> 
> Original change's description:
> > Disable WebBluetoothTest.WebBluetoothAfterCrash
> >
> > See details in:
> > https://analysis.chromium.org/p/chromium/flake-portal/flakes/occurrences?key=ag9zfmZpbmRpdC1mb3ItbWVySQsSBUZsYWtlIj5jaHJvbWl1bUBicm93c2VyX3Rlc3RzQFdlYkJsdWV0b290aFRlc3QuV2ViQmx1ZXRvb3RoQWZ0ZXJDcmFzaAw
> >
> > TBR=reillyg@chromium.org
> >
> > Bug: 1022321
> > Change-Id: I01fcb892eea350bc60a05fc8f5b1aab9088cffc1
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904191
> > Reviewed-by: Hongchan Choi <hongchan@chromium.org>
> > Commit-Queue: Hongchan Choi <hongchan@chromium.org>
> > Auto-Submit: Hongchan Choi <hongchan@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#713544}
> 
> Bug: 1022321
> Change-Id: I8bc50f7c4328cf4da82e6e4230a4a9b1fe1365cd
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121347
> Reviewed-by: Hongchan Choi <hongchan@chromium.org>
> Commit-Queue: Reilly Grant <reillyg@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#753452}

TBR=reillyg@chromium.org,hongchan@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 1022321
Change-Id: Ic835ad85cb0b30a3cb2778aa237f926f92ffeb81
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134574Reviewed-by: Jonathan Ross <jonross@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Commit-Queue: Jonathan Ross <jonross@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755915}

This re-enables a flaky test which has been disabled the last few years.
It seems OK locally, so let's see if it flakes on the bots.

Bug: 653307
Test: run_webview_instrumentation_test_apk --num_retries=0
Test: --break-on-failure --repeat=1000
Test: -f MediaAccessPermissionRequestTest.*
Change-Id: I5aa806a2087c031ef674278f8c50f2ff4c6eb1f6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134575
Commit-Queue: Nate Fischer <ntfschr@chromium.org>
Commit-Queue: Bo <boliu@chromium.org>
Auto-Submit: Nate Fischer <ntfschr@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755914}

WebRTC recommends not setting the min-bitrate. This setting makes sense
only in the simulcast/SVC case, where higher streams would be disabled
if there's not enough bitrate for them.

Bug: 1067091
Change-Id: Ief47cd36cb00a8f9f576e78f64d111e831bb83a7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2133409Reviewed-by: Jamie Walch <jamiewalch@chromium.org>
Commit-Queue: Lambros Lambrou <lambroslambrou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755913}

This CL further brings into alignment with design specifications the
style of newly introduced collapsible radio toggles on the Security &
Cookies pages.

A new "data" icon is also introduced representing a vertical bar chart.

Bug: 1061947
Change-Id: I9cf8c3662227ec33da5227118acab750da0110d4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2129706Reviewed-by: dpapad <dpapad@chromium.org>
Commit-Queue: Theodore Olsauskas-Warren <sauski@google.com>
Cr-Commit-Position: refs/heads/master@{#755912}

This patch removes all unlocking from the activation signal code path.

This is in line with the proposed spec: auto unlocks only on selection,
focus, and visibility. Hidden-matchable issues an event but does not
unlock.

R=chrishtr@chromium.org

Change-Id: Id47e1edcf4a2042e286ce50943f5c5b4a6b5fc4a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134571Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Commit-Queue: vmpstr <vmpstr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755911}