GitLab

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/8a305558..c7aa5ac7

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I0b5933032dfa5ade86518307c07db9ec8297fc4a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067977Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#743417}

This CL may cause a small binary size increase, roughly proportional
to how long it's been since our last AFDO profile roll. For larger
increases (around or exceeding 100KB), please file a bug against
gbiv@chromium.org. Additional context: https://crbug.com/805539

Please note that, despite rolling to chrome/android, this profile is
used for both Linux and Android.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/afdo-chromium-autoroll
Please CC gbiv@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Tbr: gbiv@chromium.org
Change-Id: I138fff767f7fa644ecec09aa1183d554bff43b69
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066979Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#743416}

WebAppPictureInPictureWindowControllerBrowserTest no longer uses
extensions methods to create web apps.



Bug: 1053876
Change-Id: I2dec113cd7fa00c45643839b66017619b0a1156e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062123
Commit-Queue: Eric Willigers <ericwilligers@chromium.org>
Reviewed-by: Alan Cutter <alancutter@chromium.org>
Reviewed-by: François Beaufort <beaufort.francois@gmail.com>
Cr-Commit-Position: refs/heads/master@{#743415}

This is a reland of d4838474

Previously in chromeos/components/sample_system_web_app_ui/BUILD.gn,
the build rule js_library("app") was causing build failures due to a
missing app.js file. This cl fixes the file path for the js files.

Original change's description:
> [system-web-apps] Add chrome-untrusted iframe to sample system web app
>
> An example of how to embed a chrome-untrusted iframe into a system web
> app.
>
> To do so, we need to add abstract methods in WebUI despite WebUIImpl
> being the only class to actually implement it. This is so the
> WebUIController can add requestable schemes so the WebUI can request
> the chrome-untrusted resource.
>
> Bug: 1048951
> Change-Id: Ia3152e21412845cf421df74bb00a16e0a8f264b8
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037186
> Commit-Queue: Jessica Huang <jessing@google.com>
> Reviewed-by: calamity <calamity@chromium.org>
> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
> Auto-Submit: Jessica Huang <jessing@google.com>
> Cr-Commit-Position: refs/heads/master@{#742999}

TBR=kinuko@chromium.org

Bug: 1048951
Change-Id: I38307ef0966813426e99e97ecf54403c54124917
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066404Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: calamity <calamity@chromium.org>
Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Cr-Commit-Position: refs/heads/master@{#743414}

https://chromium.googlesource.com/catapult.git/+log/4a3fef3b6875..518e466ec497

git log 4a3fef3b6875..518e466ec497 --date=short --first-parent --format='%ad %ae %s'
2020-02-21 fancl@chromium.org Fix matching for sheriff-config
2020-02-20 bsheedy@chromium.org Update minidump_stackwalk

Created with:
  gclient setdep -r src/third_party/catapult@518e466ec497

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/catapult-autoroll
Please CC crouleau@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: chromium:1040502,chromium:1052720
Tbr: crouleau@google.com
Change-Id: I042ac2367209a30b69bb13c83582dd8159429cb9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067927Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#743413}

This requires changing wayland/fuzzer/wayland_templater.py a bit.
-Wmisleading-indentation used to fire on harness.cc (see try jobs on
https://chromium-review.googlesource.com/c/chromium/src/+/2063736/1),
because harness.cc.tmpl is indentede according to jinja directive
level, not indented according to generated output code level.

That makes the .tmpl files readable, but the generated code looks weird.

As a fix, pipe the jinja output through clang-format before writing
it to disk, so that the output looks readable too (to both compilers
and humans). This is the approach we use in other code generators in
Chromium as well.

While here, also change the script to only write its output if
the contents change. This allows ninja to not run the compile step
for the generated cc files if the file contents don't change (due
to a no-op change to the generator, or due to a whitespace-only change
to the .tmpl file that clang-format now normalizes away).

The wayland_templater.py change is meant to be behavior-preserving.

Bug: 031169
Change-Id: I045070be3c1649e8752b6e09bb6655b1f3f60fb4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066108Reviewed-by: Nic Hollingum <hollingum@google.com>
Commit-Queue: Nico Weber <thakis@chromium.org>
Auto-Submit: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#743412}

It is not needed to cancel the check if the request is never sent.
Also introduce a helper function to send the check to the
database_manager. This helper function will be reused in another
refactoring CL.

Bug: 1050859
Change-Id: I64f1d721f77c60c93d0829dd0c0bf8c791b4f053
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067462Reviewed-by: Daniel Rubery <drubery@chromium.org>
Commit-Queue: Xinghui Lu <xinghuilu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#743411}

In http://crrev.com/c/1922699 I made anchor clicks cancel all form
submissions on a page in order to make this test pass:
external/wpt/html/browsers/browsing-the-web/navigating-across-documents/006.html

The test basically says that anchor navigations should take precedence
over form submissions when the form submission is initiated by the
onclick handler of the anchor element.

However, when the anchor has href="#", form submissions should actually
go through, and this has introduced a bug on websites which rely on this
behavior.

This logic I added to cancel form submissions would not be necessary if
we made anchor clicks navigate asynchronously like the spec says to do,
so I made a bug to do so and remove this logic: http://crbug.com/1053679

Bug: 1053312
Change-Id: I27bf193cf0d544222cddad932728a1d0f61ba62a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063265Reviewed-by: Kent Tamura <tkent@chromium.org>
Reviewed-by: Mason Freed <masonfreed@chromium.org>
Commit-Queue: Joey Arhar <jarhar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#743410}

Drops a use case of Dictionary in IDL.
Following the spec, this CL replaces Dictionary type with an IDL
dictionary JsonWebKey used in importKey().


Bug: 385376, 839389, 1047081
Change-Id: I531f3088301d330cb15dcba5de9fad2cd6f997f9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065193Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Reviewed-by: Eric Roman <eroman@chromium.org>
Commit-Queue: Hitoshi Yoshida <peria@chromium.org>
Cr-Commit-Position: refs/heads/master@{#743409}

Remove unused code.

Bug: b/145218971
Test: manual
Change-Id: I54e08fc38e967517212b2f41fabe6bb872d17cf3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067938
Commit-Queue: Tao Wu <wutao@chromium.org>
Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#743408}

The build break is due to a missing dependency on //chrome/updater:version_header.

TBR: ganesh@chromium.org
Bug: 1054682
Change-Id: I36bb38ef63965e4e39ec7901bdb3e326592d8a03
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067951Reviewed-by: Sorin Jianu <sorin@chromium.org>
Commit-Queue: Sorin Jianu <sorin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#743407}

Previously we use them to prevent from evaluating a script until the
byte-for-byte comparison is completed. However, now comparison is done in the
browser process and we don't use them.
This CL removes an unused callback pause_after_download_callback_ in
ServiceWorkerVersion and a message ResumeAfterDownload on
EmbeddedWorkerInstanceClient.

Bug: 999907
Change-Id: I3505bd95c13685096cfabef3208cfa304046f324
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2060446Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Commit-Queue: Makoto Shimazu <shimazu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#743406}

This CL adds two new UKMs

* HistoryNavigation/BackForwardCache.IsServedFromBackForwardCache
* HistoryNavigation/BackForwardCache.NotRestoredReasons

Both are similar to the existing UMAs, and records the same things as
UKMs. IsServedFromBackForwardCache records whether the page was restored
from the cache. NotRestoredReasons records the reasons why the page was
not restored from the cache. NotRestoredReasons are represented as a
bitmask.

Bug: 1033410
Change-Id: I4513d235d344ff94bad56358c26693a20e8bad05
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1961830Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#743405}

Change-Id: I563cea0cb482ac581814407500b0784361db089b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067742
Auto-Submit: John Chen <johnchen@chromium.org>
Commit-Queue: Caleb Rouleau <crouleau@chromium.org>
Reviewed-by: Caleb Rouleau <crouleau@chromium.org>
Cr-Commit-Position: refs/heads/master@{#743404}

crrev.com/c/2039812 Added the Variations.DownloadJobFetchTime metric,
which was written via TimesHistogramSample. That class only supports
durations up to 10 seconds, which isn't sufficient for that metric. This
CL replaces that histogram with Variations.DownloadJobFetchTime2 (you
have to create a new metric when changing a histogram's bucket
distribution) that can store durations up to 20 minutes, which is twice
the time Android allows for jobs to execute.

Test: out/aw/bin/run_webview_instrumentation_test_apk -f \
Test: 'VariationsSeedLoaderTest#*'
Bug: 1047536
Change-Id: I9a1f97982f13d075d32ad96f853ac33088da125b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067546Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Changwan Ryu <changwan@chromium.org>
Commit-Queue: Robbie McElrath <rmcelrath@chromium.org>
Cr-Commit-Position: refs/heads/master@{#743403}

After some trial and error, I think the best strategy for migrating our
java code to GURL is to convert all of the leaf nodes (typically jni
boundaries) to GURL, providing a deprecated interface for existing
usage, then convert the rest.

Bug: 783819
Change-Id: I8c00386e70008a588e0d5e249e3c398112c94e99
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2044759Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
Cr-Commit-Position: refs/heads/master@{#743402}

Added a new ChipRanker type, which will house a new Dolphin model.
This model will rank apps alongside both local and drive files, which
will allow us to compare the different types of items.
These ranks will be used to adjust the scores of the files to be
in line with the app scores, while still preserving the original
ordering of both groups.
This ensures the files will display appropriately in the suggestion
chips, but that their ranking elsewhere will be unaffected.

Bug: 1034842
Change-Id: I618e2694b74c6c5917eef66a900ef822f5422b92
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1989742Reviewed-by: Tony Yeoman <tby@chromium.org>
Reviewed-by: Jia Meng <jiameng@chromium.org>
Commit-Queue: Eleni Dimitriadis <edimitriadis@google.com>
Cr-Commit-Position: refs/heads/master@{#743401}

Currently, video frame metadata is reported back up from the compositor
to the blink layer as soon as a new frame is presented. Since video-rAF
callbacks have their execution delayed until the next rendering steps,
by the time the callbacks are run, there is a chance for a newer frame
to have been presented. This means that the metadata we have would be
referring to the frame that is now being displayed on screen, instead
of current frame.

This CL removes the pushing of the metadata, and instead pulls it at the
last moment, right before the callbacks are run. This means we are more
likely to get metadata that is relevant for the upcoming v-sync, instead
of the one that just happened. However, we might miss more frames, as
measured by non consecutive "presented frames".

Bug: 1049761
Change-Id: I544d190a477f79c9d917a65b781ae68cd099dc37
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042143
Commit-Queue: Thomas Guilbert <tguilbert@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#743400}

https://chromium.googlesource.com/angle/angle.git/+log/166875eb84cc..ce4918f18f73

git log 166875eb84cc..ce4918f18f73 --date=short --first-parent --format='%ad %ae %s'
2020-02-21 jmadill@chromium.org Vulkan: Sanitize Images & Buffers with non-zero values.
2020-02-20 spang@chromium.org Generate entrypoints for Fuchsia external objects extensions
2020-02-20 jmadill@chromium.org Vulkan: Add command stream diagnostics when graph is disabled.
2020-02-20 tobine@google.com Vulkan:Add FramebufferVk cache
2020-02-20 jmadill@chromium.org Vulkan: Enable FenceNV extension without graph.
2020-02-20 spang@chromium.org Add external object extensions for Fuchsia to GL API
2020-02-20 jmadill@chromium.org Vulkan: Make mapped memory available with graph disabled.

Created with:
  gclient setdep -r src/third_party/angle@ce4918f18f73

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-chromium-autoroll
Please CC cwallez@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel
Bug: None
Tbr: cwallez@google.com
Change-Id: I7fbc16d657933d16eb876d190132ff58d7d909a9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067587Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#743399}

Bug: 634140
Change-Id: I01af9fec6cdce911b2111bdebcb6a8ac1269d272
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066460Reviewed-by: Xing Liu <xingliu@chromium.org>
Commit-Queue: Anand Mistry <amistry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#743398}

Bug: 976949
Change-Id: I076b56bdad13f12b664d41586b143bb238e15c52
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067720Reviewed-by: Toni Baržić <tbarzic@chromium.org>
Commit-Queue: Matthew Mourgos <mmourgos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#743397}

This CL moves chromeOS strings for settings Device pointer page strings
from settings_strings.grdp to os_settings_strings.grdp. It continues
the process of moving all chromeOS specific strings.

Bug: 967883
Change-Id: I193b33a5bbaf251b4e2cb0d6a8ea67c9a7906c52
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065251
Commit-Queue: Nnamdi Theodore Johnson-kanu <tjohnsonkanu@google.com>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#743396}

Bug: 1031595
Change-Id: If0f9c8625de099c730cbf2fc909efdec1b21245b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065415
Commit-Queue: Filip Gorski <fgorski@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Reviewed-by: Theresa  <twellington@chromium.org>
Auto-Submit: Filip Gorski <fgorski@chromium.org>
Cr-Commit-Position: refs/heads/master@{#743395}

This CL continues the process of moving OS specific strings from
settings_strings.grdp to os_settings_strings.grdp, specifically
parental control page strings.

Bug: 967883
Change-Id: Ie9ba498cf7980b8ed202b9784cd94038613d739c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065142
Commit-Queue: Nnamdi Theodore Johnson-kanu <tjohnsonkanu@google.com>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#743394}

Refactor the current app pause dialog view, to add a base class app
dialog, to keep consistency for the app pause dialog and the app block
dialog. The app uninstall dialog might be changed to inherit from app
dialog as well, when the decision has been made for
https://bugs.chromium.org/p/chromium/issues/detail?id=1010303

BUG=1035136

Change-Id: I2e5a17f75bce8f343d15ffa1b7e7b542ea433b8a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2060433Reviewed-by: Trent Apted <tapted@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Reviewed-by: Aga Wronska <agawronska@chromium.org>
Commit-Queue: Nancy Wang <nancylingwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#743393}

This implements the logic for the paint preview capture experiment.
The experiment is behind a chrome flag that is disabled by default.
Experiment doc: http://go/fdt-sample-experiment

Bug: 1039810
Change-Id: I0b9db1ebe06d5b10da482ca1105c88d33afd1bc4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2044064Reviewed-by: Henrique Nakashima <hnakashima@chromium.org>
Reviewed-by: Calder Kitagawa <ckitagawa@chromium.org>
Reviewed-by: Theresa  <twellington@chromium.org>
Commit-Queue: Mehran Mahmoudi <mahmoudi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#743392}

This CL reverts https://crrev.com/c/1529500.

The reason why we hid the auto-hide shelf at the time is that we
didn't apply the collision detection logic to the PIP initial
bounds and the auto-hide shelf could overlap with PIP. Now that we
apply collision detection to the initial bounds, we can now revert
this CL.

Currently there are a few issues with PIP if the auto-hide shelf
gets hidden when there's a single PIP window.
- When you trigger PIP via minimize, the original window gets
  minimized first and the auto-hide shelf becomes shown, but soon
  after PIP shows up and the shelf becomes hidden again, which
  looks a bit weird.
- When PIP gets shown, the auto-hide shelf is still visible and
  then it gets hidden, but the PIP window doesn't move to the
  bottom as at this point the gravity is "to the right".

BUG=b:149889866
TEST=Manually confirmed the PIP interacts well with the auto-hide
TEST=shelf.

Change-Id: I643487b53b23931bdabd816a30c6337741d15fc4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065256Reviewed-by: Eliot Courtney <edcourtney@chromium.org>
Reviewed-by: Stefan Kuhne <skuhne@chromium.org>
Commit-Queue: Kazuki Takise <takise@chromium.org>
Auto-Submit: Kazuki Takise <takise@chromium.org>
Cr-Commit-Position: refs/heads/master@{#743391}

CWVSyncController needs a way to unobserve signin::IdentityManager
before its associated CWVWebViewConfiguration destroys its
WebViewBrowserState. This avoids a DCHECK in the IdentityManager's
observer list.

Change-Id: I1a0d15bc4bc57a3cf1dd7fbc5a38bdb0adefad0f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067472Reviewed-by: Hiroshi Ichikawa <ichikawa@chromium.org>
Commit-Queue: John Wu <jzw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#743390}

crrev.com/c/2032038 revealed that android_browsertests are opening
the NTP on initialization rather than about:blank. This caused issues
w/ the switch from the old NTP to start surface, which doesn't have
an associated WebContents.

This CL instead always opens the initial tab in android_browsertests
on about:blank, which should ensure that an actual Tab (and
WebContents) are created regardless of whether we're using the NTP
or start surface.

Change-Id: I5a87e3093a5f78ea76179fe605b859df9dc3b193
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065331
Commit-Queue: John Budorick <jbudorick@chromium.org>
Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#743389}

When an OOPIF is bigger than its parent frame, we limit the area of the
iframe to be rasterized to the size of its parent frame, plus some extra
space to prevent scroll guttering. In this situation, The existing code
centers this area to be composited around the part of the iframe that is
visible in the top-level document after all intervening clips have been
applied. This CL does not change the size of the rect, but it centers
the rect around the parent frame.

The motivation for this CL is that a subsequent CL is going to change
RemoteFrameView::GetCompositingRect() so that it isn't calculated on the
fly (which is the root cause of the linked bug). Instead, the
compositing rect will be computed during each lifecycle update, and
GetCompositingRect() will return a cached value computed during the
last lifecycle update.

In the subsequent CL, the compositing rect needs to be updated prior
to the parent frame committing to the compositor thread, because the
parent frame will submit the child frame's compositing bounds, and it
needs to be up-to-date. But the current logic to compute the compositing
bounds relies on the result of FrameView::UpdateViewportIntersection,
which doesn't run until after compositor commit.

So the whole motivation for this change is to break the dependency
on RemoteFrameView::last_intersection_state_ when computing the
compositing bounds.

Although the interest rect will no longer be centered around the
iframe's viewport intersection, the "extra" area intended to prevent
scroll guttering will still always be at least 15% of the parent frame's
size in each direction, so this should not regress any visible behavior.

BUG=1033746

Change-Id: I1aac0dea2dddaa60be12de2d3635bb77cbd55c52
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2045223
Commit-Queue: Stefan Zager <szager@chromium.org>
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#743388}

If there are no excluded credentials then appidExclude shouldn't matter.
Previously we hit an assertion failure and crashed in this case. (See
bug.) This was introduced with M80.

BUG=1054499

Change-Id: I074ca094140feca599ab1bc59e59af1fbbcb88a0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067387
Commit-Queue: Adam Langley <agl@chromium.org>
Commit-Queue: Martin Kreichgauer <martinkr@google.com>
Auto-Submit: Adam Langley <agl@chromium.org>
Reviewed-by: Martin Kreichgauer <martinkr@google.com>
Cr-Commit-Position: refs/heads/master@{#743387}

AXRelativeBounds assumes that the bounds are relative to the root of the
tree by default, but in ARC, every nodes' bounds are computed relative
to its container.

AutomationInternalCustomBindings::ComputeGlobalNodeBounds computes the
bounds by first calling AXTree::RelativeToTreeBoundsInternal to compute
the node's relative bounds to its root using AXRelativeBounds, and then
applying the difference between the root and the container.

In Dialog or Popup window, the root node can have some amount of offset
to its container. As a result, every computed bounds in such window
has "doubled" offset to ARC container.

This CL fixes the computation.

This CL also simplifies geometry_util in arc a11y because
exo::WMHelper::GetInstance() never returns nullptr.

Bug: b:145260260
Test: manual. With TalkBack-test app, Alerts window has correct bounds.
Change-Id: I93033ad0b2771828cdf00d17d1ebe039ef1d7044
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2061930
Commit-Queue: Hiroki Sato <hirokisato@chromium.org>
Reviewed-by: David Tseng <dtseng@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#743386}

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll
Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast
Tbr: cr-fuchsia+bot@chromium.org
Change-Id: I9a30b9cd9c174e1e0ab4d5c5b76626ed1146dfbc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067922Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#743385}

TBR: dmazzoni@chromium.org, dtseng@chromium.org
Change-Id: I8fb826b2993e0a032fa77f7d6281980e21fb5394
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067414Reviewed-by: Nektarios Paisios <nektar@chromium.org>
Commit-Queue: Nektarios Paisios <nektar@chromium.org>
Auto-Submit: Nektarios Paisios <nektar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#743384}

This is a reland of 2131f972

Original change's description:
> [mb.py] Check multiple locations for the real python.
>
> Sometimes the value of sys.prefix (or sys.real_prefix in vpython)
> includes the bin/ directory within the python installation, and
> sometimes it does not. To accommodate this, check both prefix/bin and
> prefix itself for the python executable.
>
> Bug: 1049421
> Change-Id: Ia7c072dc0b4b8232ec8fdce20f9211e3c978a3ad
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055976
> Commit-Queue: Sajjad Mirza <sajjadm@chromium.org>
> Reviewed-by: Nico Weber <thakis@chromium.org>
> Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#741574}

Bug: 1049421
Change-Id: Ib0d83fa1b6613e62334336cf567d9c311dba2cfd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067291Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Sajjad Mirza <sajjadm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#743383}

As Enhanced Protection is a superset of SBER,
everywhere that checks for SBER should also
have a check for enhanced protection.

Bug: 1054254
Change-Id: Ie8a89d450d0a6b7fd823fb4dc802ffe8bb1a27dd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065858
Commit-Queue: Bettina Dea <bdea@chromium.org>
Reviewed-by: Daniel Rubery <drubery@chromium.org>
Cr-Commit-Position: refs/heads/master@{#743382}

It's needed for the iOS version of the lookalike interstitial.

Change-Id: Iee91e52696cbb68b119c155151e4028af3c3d066
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067675Reviewed-by: Livvie Lin <livvielin@chromium.org>
Commit-Queue: Mustafa Emre Acer <meacer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#743381}

This CL moves chromeOS strings for settings Bluetooth page strings from
settings_strings.grdp to os_settings_strings.grdp. It continues
the process of moving all chromeOS specific strings.

Bug: 967883
Change-Id: If8f294c312ba8ba4731c76839d30d683a92d6543
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065400
Commit-Queue: Nnamdi Theodore Johnson-kanu <tjohnsonkanu@google.com>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#743380}

See e.g.
https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=chrome_public_test_apk&tests=org.chromium.chrome.browser.photo_picker.DecoderServiceHostTest%23testCancelation

Change-Id: I8c6398d741ee64148701cdde4459d78998f4ae60
Tbr: finnur@chromium.org
Bug: 1054652
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067739Reviewed-by: Justin DeWitt <dewittj@chromium.org>
Commit-Queue: Justin DeWitt <dewittj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#743379}

This CLs updates the drag and drop interactions such that only
the DOM is updated as the user drags a tab or group element. The
tab strip model is only changed once the user commits the move by
dropping the element in place.

The DragManager now initializes a new DragSession every time a
drag begins, and uses the session to store and retrieve indices.

This will also make it easier and more consistent to drop a tab or
group from another window into a specific index. The idea is to create
a TabElement or TabGroupElement as a drag enters from another
window and keep most of the code the same.

Bug: 1048894
Change-Id: I92e9866ce2b57aae2736fa81b7a5e9e1b334cdfe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065329Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: John Lee <johntlee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#743378}