- 29 Dec, 2020 40 commits
-
-
Chris Lu authored
It is not guaranteed that upon a badge tap that the associated Infobar still exists. The Messages implementation has a similar issue, but Objc nil object selector executions are no-ops. Thus, an explicit nil check is necessary before attempting to present an Infobar modal overlay. Fixed: 1041375 Change-Id: I072879ef4ab2a163223cc896ea3a59288c09998e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2605400 Auto-Submit: Chris Lu <thegreenfrog@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#839589}
-
chromium-internal-autoroll authored
Release_Notes: http://go/media_app-x20/relnotes/Main/media_app_202012290600_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/media_app/app/+/gYicacAmlNBTfmj5bqOqzRfHBhSEG6KBAY2UtDyAakQC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/media-app-chromium-autoroll Please CC media-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: media-app@grotations.appspotmail.com Change-Id: I42705f082d530b2fc23f44546a6fb5b3b55c89a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2605593Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#839588}
-
Danila Kuzmin authored
Bug: 1162262 Change-Id: I44c5a9041eb384a654dffd962cb7aa4487f49dd9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2603755Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Danila Kuzmin <dkuzmin@google.com> Cr-Commit-Position: refs/heads/master@{#839587}
-
Danila Kuzmin authored
Bug: 1159430 Change-Id: I9923cc0a1590a26a2fa9988a6bbd5220d40fa9e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2604911 Commit-Queue: Danila Kuzmin <dkuzmin@google.com> Reviewed-by:
-
Yang Guo authored
We are renaming "online" to "no throttling" for the network throttling setting. We need to rebaseline the test expectation when the rename rolls from devtools-frontend into chromium. Bug: 1028078 Change-Id: Icb1db48350401d697a62b57e9dd6f825377c9c32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2606344 Commit-Queue: Yang Guo <yangguo@chromium.org> Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Auto-Submit: Yang Guo <yangguo@chromium.org> Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/master@{#839585}
-
Nico Weber authored
...at least once there's an arm cipd binary. gclient's DEPS variables have a host_cpu variable (backed by detect_host_arch.py in depot_tools, which even correctly returns "arm64" on M1s), but it can't be queried via Var() in DEPS (and even if that was possible, the x64 value is "x64" and not "amd64" like we'd need for the cipd package name) and we can't use it in a gclient `condition` here either since we'd have to do something like 'src/buildtools/mac': { ...'gn/gn/mac-amd64' condition: 'host_os == "mac" and host_cpu == "x64"' } 'src/buildtools/mac': { ...'gn/gn/mac-arm64' condition: 'host_os == "mac" and host_cpu == "arm64"' } and then gclient would complain that we have two entries for the key 'src/buildtools/mac'. So gclient variables and cipd deps don't synergize very well here. However, cipd has a bunch of built-in variables too, and ${arch} is populated based on runtime.GOARCH and that is "amd64" in x64 and "arm64" on arm64, so we can use that: https://chromium.googlesource.com/infra/luci/luci-go/+/master/cipd/client/cipd/ensure/doc.go (In fact, we could use `gn/gn/${{platform}}` and remove the conditional on host_os. That might confuse linux/arm and windows/arm machines since we might not have gn prebuilts for those, but trying to build on those platforms probably doesn't work great for other reasons already?) Bug: 1103319 Change-Id: I2d445a02e5e05f9553929404a3d569f7fe7a2213 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2602663 Commit-Queue: Nico Weber <thakis@chromium.org> Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:Dirk Pranke <dpranke@google.com> Cr-Commit-Position: refs/heads/master@{#839584}
-
Monica Basta authored
Bug: 1161528 Change-Id: I80dd4f0e2950f0cbaba864fd7529dab10e15cbce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2602430 Commit-Queue: Monica Basta <msalama@chromium.org> Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#839583}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-deterministic-dbg;luci.chromium.try:fuchsia-x64-cast Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: I622f5e4593f3365a4e0d93076f39aaaafb5775bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2606208Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#839582}
-
Henrique Ferreiro authored
Additionally remove blink::DragOperation in favor of the Mojo type. Follow-up CLs will move blink.mojom.AllowedDragOperations and unify the rest of the drag-and-drop types with these definitions. Bug: 1093536, 919392 Change-Id: Iddcf7298a6656a6cec9be3bb60ba8177581e68bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587049 Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#839581}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/6005f1179a65..355e9766ff81 2020-12-29 fmayer@google.com Merge "Use packages.list to read profileability." If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: Ic9bbf240aef6bb7b1cd2374be9e2e14eca41dd17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2606307Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1609221064-1228ab180b0732d4cc578b7cded2cefd740548bb.profdata to chrome-mac-master-1609241635-1a5deaa23ae88856f623544afdac379b41a9d7db.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I89dcf68275bcb730e001292f2282020abfe3b376 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2606304Reviewed-by:
-
Yunke Zhou authored
We noticed that the system will hang up when ChromeVox dialog is shown on the welcome screen during OOBE. Disable the feature first for further investigation. Bug: 1161107, b/176129191 Change-Id: I5b14db099000fa217a062362b40070e24974e25a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2603754Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1609221064-24424bfd2155989c442b2a02c4811561491f33e6.profdata to chrome-linux-master-1609241635-e4b96f72ae58e1971ec4cf3bb5311f454317b912.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I2a9ad3948ecdb3a131c682543e20a36dbeb1032c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2606220Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/2382e63de188..8db531ffa636 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: Change-Id: I7a70e5048828673662742bada46715c620e6d345 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2605418Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/b5f42f1dedca..c6a4cc37015a 2020-12-29 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I4ce86ea5b1e7cc0fa5a46b138d47e96684e6abd1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2606217Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1609124291-e7a0465f695fe158abf9ec0e9104d31fe42b886f.profdata to chrome-win64-master-1609221064-65e0288b21a9cea51e4f1fac1a8b654b327fc015.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I6be5402fa1653bf63a397d32465415f4c1bf4964 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2605811Reviewed-by:
-
Thomas Tellier authored
Bug: 1101326 Change-Id: I0a43e246b5e659f4e246bf0ec3eb32e3d627c1a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2603572 Commit-Queue: Thomas Tellier <tellier@google.com> Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/1f0df96659ae..5994a16ca076 2020-12-29 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision b264ce95..0afd0128 (839451:839551) 2020-12-28 deadbeef@webrtc.org Correct "DSAWithSHA256" OID. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I913a3426afc8b6f2e45648f9ae89d6517d9b39a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2606206Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/220642a93da1..095fd1d3ad25 2020-12-29 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from e02e8b37 to aba6331a (134 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: jonahr@google.com Change-Id: If1498e4636469af2c292b9e23c46977a1a524dc2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2605810Reviewed-by:
-
Henrique Ferreiro authored
effectAllowed and dropEffect are limited to at most 9 different strings. Additionally, since drag-and-drop is only used in the UI thread, it should be thread-safe. Given these conditions, AtomicString will be more efficient and safe to use. This was mentioned as a TODO in https://bugs.webkit.org/show_bug.cgi?id=33607#c9. Bug: 1093536 Change-Id: I161ee9ad5d772aa70f0c2f7615abe23c0ec624c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2599533 Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Reviewed-by:
Darwin Huang <huangdarwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#839570}
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-chrome TBR=chrome-os-gardeners@google.com Change-Id: I50448436c46e54a58698f5b117f5c1ee9c32da38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2605592Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#839569}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/41dde25e96c5..2382e63de188 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: Change-Id: I4db7d55eb7ff3a0cfae62c74e2a3061cecfc1b97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2604303Reviewed-by:
-
Sergey Poromov authored
Some tests were already disabled in https://crrev.com/c/2605403 But others are still failing: https://ci.chromium.org/ui/p/chromium/builders/ci/Linux%20CFI/19334/overview TBR=jdarpinian@chromium.org Bug: 1162117 Change-Id: I615aaba11b736e81c9051dc867c2605ddcdd1615 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2602435Reviewed-by:
Sergey Poromov <poromov@chromium.org> Commit-Queue: Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#839567}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/bcfb0a5a..ef6c6121 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Id8e79cd0faaaef97317de4dfecff0dfcc3a688d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2603466Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#839566}
-
Sergey Poromov authored
The test is flaky: https://ci.chromium.org/p/chromium/builders/ci/Linux%20ChromiumOS%20MSan%20Tests Sample run: https://ci.chromium.org/ui/p/chromium/builders/ci/Linux%20ChromiumOS%20MSan%20Tests/21913/overview TBR=dmazzoni@chromium.org TBR=dtseng@chromium.org Bug: 1162238 Change-Id: I05ea294ec4cfb46761552b1fc972895444a7987b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2605747Reviewed-by:
-
Kuo Jen Wei authored
This CL introduce following |#mode-selector| changes: 1. Set the fadding effect area to 24px. 2. Fine tune scrollbar height, color, border-radius. 3. Makes gap between |.mode-item| to 16px, 4. Remove 5px top/bottom padding of #mode-group, let the gap between scrollbar and |.mode-items| solely determined by top/bottom margin of |.mode-times| and avoid focus ring overlapped with scrollbar. Bug: b/172340037 Test: Manuall verify with UX spec. Change-Id: I52db56f1a309748d1bfcaa585143301e09ca7233 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2600432Reviewed-by:
Shik Chen <shik@chromium.org> Auto-Submit: Inker Kuo <inker@chromium.org> Commit-Queue: Inker Kuo <inker@chromium.org> Cr-Commit-Position: refs/heads/master@{#839564}
-
Danila Kuzmin authored
Bug: 1156662 Change-Id: I2be68f5013ddad64c16c8036d53c0be9ef437e59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2600746 Commit-Queue: Danila Kuzmin <dkuzmin@google.com> Reviewed-by:
-
Kuo Jen Wei authored
Bug: b/172340037 Test: Manuall verify with UX spec. Change-Id: I4b831b3e73314441793adf98f7e19fe4d2866906 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596714Reviewed-by:
-
Sergey Poromov authored
This reverts commit 451e2db2. Reason for revert: All Mac builds are consistently failing after this CL: https://ci.chromium.org/ui/p/chromium/builders/ci/Mac10.13%20Tests/33289/overview https://ci.chromium.org/ui/p/chromium/builders/ci/Mac10.14%20Tests/12001/overview https://ci.chromium.org/ui/p/chromium/builders/ci/Mac10.15%20Tests/7041/overview Original change's description: > Add platform specific expected files for select-event.html test > > Bug: 1161590 > Change-Id: I17f1fadfba815efa42bff7afe7abc3f27960e533 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2605394 > Reviewed-by: Joey Arhar <jarhar@chromium.org> > Commit-Queue: Yu Han <yuzhehan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#839496} TBR=jarhar@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com,yuzhehan@chromium.org Change-Id: I12afff6389f413e076d58671c68711933092b017 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1161590 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2605746Reviewed-by:
-
Wei Lee authored
Since currently the layout in CCA does not support zoom in/out, we should prevent user from zooming-in/out in the app. Bug: b/176455103 Test: CCA is not scalable with pinch gesture or hotkeys Change-Id: Ib52fbe2264bc3ac8f4d99dbfb61548731fa85915 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2602306 Commit-Queue: Wei Lee <wtlee@chromium.org> Reviewed-by:
-
Internal Frameworks Autoroller authored
TBR=bling-team@google.com Change-Id: I14b80c6dbdef7b48cf70bcfa32cf52430edfa892 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2606124Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#839559}
-
rajendrant authored
TBR=mcrouse@chromium.org Bug: 1162052 Change-Id: I7fa97b383b8f70d5f17e277434874c6ac5c1779b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2604945Reviewed-by:
rajendrant <rajendrant@chromium.org> Commit-Queue: rajendrant <rajendrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#839558}
-
Alice Wang authored
This CL refactors the AccountHolder usage in FirstRunUtilsTest. Bug: 1161437 Change-Id: I3baac52615f15ce7457875526220f2cd9cc54748 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2603852Reviewed-by:
Wenyu Fu <wenyufu@chromium.org> Commit-Queue: Alice Wang <aliceywang@chromium.org> Cr-Commit-Position: refs/heads/master@{#839557}
-
Kuo Jen Wei authored
Fine tune the inner window size of 4:3/16:9/minimal to 788x538/788x428/505x428 px and left/right/bottom line to 44/50/44 px. Bug: b/172340037 Test: Manually verify with UX spec. Change-Id: Ia5761337cd3c0734bee30e8ba6bcccb0b67c2587 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596713 Auto-Submit: Inker Kuo <inker@chromium.org> Reviewed-by:
-
Noel Gordon authored
Add Content Security Policy (CSP) to file manager SWA frontend code to allow the Metadata Shared Worker code to load without error. That code loads from chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj, so add 'script-src' and 'worker-src' policy to allow code from that origin. Once those policies are specified, one also has to include 'self', and also 'chrome://resources' for scripts loaded from that source. Scripts chrome://resources/mojo/mojo/public/js/mojo_bindings_lite.js chrome://resources/polymer/v1_0/html-imports/html-imports.min.js would be blocked by CSP if their origin is not present in 'script-src' policy for example. Bug: 1113981 Change-Id: I524aa0e3dba5c4c5b6252eb1330cb19f152dec26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2602967 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
Alex Danilo <adanilo@chromium.org> Cr-Commit-Position: refs/heads/master@{#839555}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1609199712-53d931f587c8bfb3642e1d3559fa944b25ac41c0.profdata to chrome-mac-master-1609221064-1228ab180b0732d4cc578b7cded2cefd740548bb.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ia22bc04530147b552c29ceddc9a2ba52c99ad3bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2605841Reviewed-by:
-
Colin Blundell authored
SubresourceFilterProfileContext will shortly be needed in the context of //weblayer. In preparation, this CL adds SubresourceFilterProfileContextFactory to //weblayer. The configuration of the class follows that of //chrome's configuration, with one exception: //chrome's factory integrates with history (via SubresourceFilterHistoryObserver), while //weblayer does not integrate //components/history at all. Bug: 1116095 Change-Id: I134b9c59d0f4bcc48c242bdeaba2033143ec8d29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2603571Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#839553}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1609199712-7e463f0207d055b7b562c386dc767d4724824c2c.profdata to chrome-linux-master-1609221064-24424bfd2155989c442b2a02c4811561491f33e6.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I2addfff1126d8361c2e16b83454ca0d76d032a4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2605839Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/f7c0ea8a48cf..41dde25e96c5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:790886 Tbr: Change-Id: I80c71a537de260b0463532b9a89b20965adfb65c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2602254Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/a5a1f14e..bcfb0a5a Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ieae7becd5585cdfd62689084863aa9056598edae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2605834Reviewed-by:
-
