GitLab

The CL adds new metadata model to DirectoryModel, and let DirectoryModel call the new metadata model's method to notify change of Entry.

BUG=410766
TEST=None

Review URL: https://codereview.chromium.org/892083004

Cr-Commit-Position: refs/heads/master@{#314988}

Review URL: https://codereview.chromium.org/885733003

Cr-Commit-Position: refs/heads/master@{#314987}

The CL lets GesturePropertyProvider decide device types based
on a logic identical to the old inputcontrol script. This
solves some regressions we met on hybrid devices.

Contributed by sheckylin@chromium.org

BUG=454697
TEST=samus ChromeOS build

Review URL: https://codereview.chromium.org/902543002

Cr-Commit-Position: refs/heads/master@{#314986}

This is necessary so that layout tests can run with --site-per-process.  Layout tests run with --dump-render-tree, which also forces --process-per-tab, and the latter was conflicting with --site-per-process.

BUG=417518

Review URL: https://codereview.chromium.org/891063002

Cr-Commit-Position: refs/heads/master@{#314985}

This CL consolidates the SearchResultListView creation in ContentsView
into a single flow used by the classic and experimental app list. They
now both use SearchResultPageView with a SearchResultListView inside.

This change is being made to facilitate further refactoring.

BUG=455059

Review URL: https://codereview.chromium.org/896633005

Cr-Commit-Position: refs/heads/master@{#314984}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/f05b633..2fb8a57

TBR=dcheng@chromium.org,apavlov@chromium.org

Review URL: https://codereview.chromium.org/878043003

Cr-Commit-Position: refs/heads/master@{#314983}

81318c1 Correct cpu_arch value for x86 arch.

BUG=455167

Review URL: https://codereview.chromium.org/904563002

Cr-Commit-Position: refs/heads/master@{#314982}

WifiCredentialSyncableServiceFactory normally uses
chromeos::LoginState to associate a SyncableService with a Shill
profile. For this to work, LoginState must have been set properly,
before someone tries to use the Factory to create a SyncableService.

The precondition is met in production mode. However, in sync
integration tests, it is difficult to arrange for LoginState to be
configured properly. The problem is that the sync integration test
framework creates multiple SyncableServices, without providing the
test case the ability to change configuration between the construction
of the SyncableServices.

Acccomodate the way sync integration test work, by allowing the
WifiCredentialSyncableServiceFactory to ignore LoginState. When
LoginState is ignored, the factory will, instead, use the
BrowserContext to associate the new SyncableService with a Shill
profile. This works for sync integration tests, because each
SyncableService created by the test framework has a separate
BrowserContext.

BUG=chromium:431435
TEST=components_unittests --gtest_filter="Wifi*"

Review URL: https://codereview.chromium.org/876833002

Cr-Commit-Position: refs/heads/master@{#314981}

This CL fixes an issue where the experimental app list animation from
the start page to the custom launcher page was janky because the bounds
were being calculated incorrectly. This CL fixes the animation to use
the size of the view being animated rather than the entire contents
bounds.

BUG=None

Review URL: https://codereview.chromium.org/901133003

Cr-Commit-Position: refs/heads/master@{#314980}

SWRegistration.unregister() depends on WebSWProvider, but it's not available
in SWGlobalScope because the provider isn't supplied on the worker startup
sequence. This series of CLs make it available and support unregister() in
the service worker context.

This CL implements createServiceWorkerProvider() to supply a provider and
sets the document URL of its provider host to the worker script URL in
order to allow unregister() call on SWGlobalScope.

[1] Chromium: THIS PATCH
[2] Blink: https://codereview.chromium.org/900793002/

BUG=452910
TEST=compile

Review URL: https://codereview.chromium.org/893363003

Cr-Commit-Position: refs/heads/master@{#314979}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/66fcf2e..f05b633

TBR=dcheng@chromium.org,apavlov@chromium.org

Review URL: https://codereview.chromium.org/906433002

Cr-Commit-Position: refs/heads/master@{#314978}

TBR=machenbach@chromium.org

Review URL: https://codereview.chromium.org/901153008

Cr-Commit-Position: refs/heads/master@{#314977}

TBR=clamy@chromium.org
BUG=455994
NOTRY=true

Review URL: https://codereview.chromium.org/901393002

Cr-Commit-Position: refs/heads/master@{#314976}

BUG=
R=msw

Review URL: https://codereview.chromium.org/891183003

Cr-Commit-Position: refs/heads/master@{#314975}

BUG=304341,450799

Review URL: https://codereview.chromium.org/894843003

Cr-Commit-Position: refs/heads/master@{#314974}

This patch adds an additional function to the UsbService::Observer
interface that should be used to perform cleanup operations when a USB
device is disconnected. This is separate from the OnDeviceRemoved
function so that implementations of that function, which may depend on
other subsystems' knowledge of a connected device, can run before any
cleanup actions have taken place.

A browsertest for the chrome.usb.getUserSelectedDevices is included
which demonstrates the need for this 2-phase event handling.

BUG=452298

Review URL: https://codereview.chromium.org/891853002

Cr-Commit-Position: refs/heads/master@{#314973}

R=thakis@chromium.org
BUG=455342

Review URL: https://codereview.chromium.org/874163005

Cr-Commit-Position: refs/heads/master@{#314972}

The "usbDevices" entry in permission list should be inside an object

Review URL: https://codereview.chromium.org/886353008

Cr-Commit-Position: refs/heads/master@{#314971}

Mechanical change that adds instrumentation required to locate the source of
jankiness (i.e. a long-running fragment of code executed as a part of the task
that causes jank) in the code. See the bug for details on what kind of jank we
are after.  A number of similar CLs were landed, and none of them caused issues.
The code of the instrumentation is highly optimized and is not expected to
affect performance. The code simply creates a diagnostic task which is identical
to ones created by PostTask or IPC message handlers.

BUG=455884,455942,455952
TEST=none
TBR=mmenke,michaeln,zea

Review URL: https://codereview.chromium.org/900793009

Cr-Commit-Position: refs/heads/master@{#314970}

This was broken by https://codereview.chromium.org/834673007. Constructing
a PairingRegistry with a null delegate causes pairing to be offered, but if
selected, the host process will crash.

BUG=455501

Review URL: https://codereview.chromium.org/903963002

Cr-Commit-Position: refs/heads/master@{#314969}

We no longer need these UMA.
This reverts commit 7f60d255.

BUG=433734
TEST=None

Review URL: https://codereview.chromium.org/888083004

Cr-Commit-Position: refs/heads/master@{#314968}

The Google style guide states that only one of {virtual,override,final}
should be used for each declaration, since override implies virtual and
final implies both virtual and override.

This patch was automatically generated with an OS=android build using a
variation of https://codereview.chromium.org/598073004.

BUG=417463

Review URL: https://codereview.chromium.org/897223003

Cr-Commit-Position: refs/heads/master@{#314967}

Previously each locale filename was passed separately on the command
line. This causes problems on Windows because of the 8K command line limit.

A follow-up cl will move the webapp filenames into separate files to reduce
the liklihood that we'll encounter this limit in the future.

BUG=

Review URL: https://codereview.chromium.org/905553002

Cr-Commit-Position: refs/heads/master@{#314966}

The model dispatches the requests depends on the entry's location.

BUG=410766
TEST=FileManagerJsTest.FileSystemMetadataModel

Review URL: https://codereview.chromium.org/890423004

Cr-Commit-Position: refs/heads/master@{#314965}

The Google style guide states that only one of {virtual,override,final}
should be used for each declaration, since override implies virtual and
final implies both virtual and override.

This patch was automatically generated with an OS=android build using a
variation of https://codereview.chromium.org/598073004.

BUG=417463

Review URL: https://codereview.chromium.org/897423002

Cr-Commit-Position: refs/heads/master@{#314964}

This reverts r127788.  Positional parameters aren't part of the C standard
(they are part of POSIX though), we don't really use them in the codebase,
and they don't work in chrome/android with libc++.  Rather
than have a test for them, make them also not work on Windows (like they
originally didn't) -- we shouldn't use positional printf parameters anyways.

Change the 5 uses to not use positional parameters.

BUG=118064,117028,427718

Review URL: https://codereview.chromium.org/902643002

Cr-Commit-Position: refs/heads/master@{#314963}

This is interfering slightly with tab ordering. The plugin never used to be tab
focusable.

BUG=455552

Review URL: https://codereview.chromium.org/889603005

Cr-Commit-Position: refs/heads/master@{#314962}

The onBlur handler was accidentally removed by my recent refactoring.
The images are required for submissions to CWS; only the icon needs to
included in the crx, however.

Review URL: https://codereview.chromium.org/868663007

Cr-Commit-Position: refs/heads/master@{#314961}

This test fails within the WebContentsObserverSanityChecker, since no IPC
for RenderFrameCreated is sent. Disable while we find a good way to make
the sanity checker play nicely within the unit test framework running in
--site-per-process

BUG=417518

Review URL: https://codereview.chromium.org/905463004

Cr-Commit-Position: refs/heads/master@{#314960}

R=calamity@chromium.org
BUG=455895
TEST=manual

Review URL: https://codereview.chromium.org/901153007

Cr-Commit-Position: refs/heads/master@{#314959}

BUG=455311

Review URL: https://codereview.chromium.org/868503003

Cr-Commit-Position: refs/heads/master@{#314958}

The Google style guide states that only one of {virtual,override,final}
should be used for each declaration, since override implies virtual and
final implies both virtual and override.

This patch was automatically generated with an OS=android build using a
variation of https://codereview.chromium.org/598073004.

BUG=417463

Review URL: https://codereview.chromium.org/900793008

Cr-Commit-Position: refs/heads/master@{#314957}

This adds a new distallable type (mobile-friendly distillable) and adds
a histogram for tracking what types of pages are actually distilled.

BUG=444160

Review URL: https://codereview.chromium.org/900963003

Cr-Commit-Position: refs/heads/master@{#314956}

Review URL: https://codereview.chromium.org/905653002

Cr-Commit-Position: refs/heads/master@{#314955}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/dc9973e..66fcf2e

TBR=dcheng@chromium.org,apavlov@chromium.org

Review URL: https://codereview.chromium.org/898143004

Cr-Commit-Position: refs/heads/master@{#314954}

The Google style guide states that only one of {virtual,override,final}
should be used for each declaration, since override implies virtual and
final implies both virtual and override.

This patch was automatically generated with an OS=android build using a
variation of https://codereview.chromium.org/598073004.

BUG=417463

Review URL: https://codereview.chromium.org/900183004

Cr-Commit-Position: refs/heads/master@{#314953}

In old implementation, 'audio/aac' is not supported when using
IsSupportedMediaMimeType to check. That will block aac audio to play.

Review URL: https://codereview.chromium.org/895523002

Cr-Commit-Position: refs/heads/master@{#314952}

The Google style guide states that only one of {virtual,override,final}
should be used for each declaration, since override implies virtual and
final implies both virtual and override.

This patch was automatically generated with an OS=android build using a
variation of https://codereview.chromium.org/598073004.

BUG=417463

Review URL: https://codereview.chromium.org/900613004

Cr-Commit-Position: refs/heads/master@{#314951}

Revert of Roll Clang 223108:228129 (patchset #5 id:80001 of https://codereview.chromium.org/881763003/)

Reason for revert:
compiler crash in http://build.chromium.org/p/chromium/builders/Mac/builds/33226

Assertion failed: (Offset <= PieceOffset && "overlapping or duplicate pieces"), function emitLocPieces, file /work/chromium/src/third_party/llvm/lib/CodeGen/AsmPrinter/DwarfDebug.cpp, line 1676.

0.	Program arguments: /Volumes/data/b/build/slave/Mac/build/src/third_party/llvm-build/Release+Asserts/bin/clang -cc1 -triple x86_64-apple-macosx10.6.0 /* snip */ -x c ../../third_party/mesa/src/src/mesa/program/prog_opt_constant_fold.c
1.	<eof> parser at end of file
2.	Code generation
clang:error: unable to execute command: Illegal instruction: 4
clang:error: clang frontend command failed due to signal (use -v to see invocation)
clang version 3.7.0 (trunk 228129)
Target: x86_64-apple-darwin13.4.0

Original issue's description:
> Roll Clang 223108:228129
>
> Also introduce a build number in the package name, stop versioning
> the Blink GC plugin, and remove repackage.sh.
>
> BUG=444089
>
> Committed: https://crrev.com/d30327adf468b78f79819a69bca12b64b7cb70ae
> Cr-Commit-Position: refs/heads/master@{#314946}

TBR=thakis@chromium.org,jln@chromium.org,jbauman@chromium.org,hans@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=444089

Review URL: https://codereview.chromium.org/898713004

Cr-Commit-Position: refs/heads/master@{#314950}

Revert of Linux MSan: enable swarming/sharding for browser_tests. (patchset #1 id:1 of https://codereview.chromium.org/899283003/)

Reason for revert:
broke browser_tests

Original issue's description:
> Linux MSan: enable swarming/sharding for browser_tests.
>
> Also, try enabling swarming for base_unittests on CrOS MSan.
>
> BUG=454828
> TBR=phajdan.jr@chromium.org
>
> Committed: https://crrev.com/0f7445a90f7a8e2aa54a812d2c96654cefbd8eaf
> Cr-Commit-Position: refs/heads/master@{#314892}

TBR=phajdan.jr@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=454828

Review URL: https://codereview.chromium.org/898083003

Cr-Commit-Position: refs/heads/master@{#314949}