- 17 Sep, 2019 40 commits
-
-
Tanmoy Mollik authored
Bug: 1004264 Change-Id: Ic2164a87dc65216cae1ab0943c9a4396623232b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1805667 Commit-Queue: Tanmoy Mollik <triploblastic@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#697263}
-
arthursonzogni authored
Bug: 976218 Change-Id: I08c10155b6f9522fa29d3f0f2af3e86c756d7b26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809306Reviewed-by:
Lowell Manners <lowell@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#697262}
-
Francois Doray authored
This CL verifies that the thread priority is normal when a test process is launched and before/after each test. The goal is to avoid having tests that assume they run at normal priority be disabled because of other misbehaving tests (e.g. https://crbug.com/931706). Bug: 931706 Change-Id: I5ca18b87720b5305285be481f7b60ff5c941a324 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1804786 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Auto-Submit: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#697261}
-
Lily Chen authored
This adds a fieldtrial testing config for SameSiteCookieMessages, which turns on the feature CookieDeprecationMessages for all versions 77+. Bug: 966576 Change-Id: Ibe4a83448cc1c2b547970e68de8e6f8b12e8a6e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1802635Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Lily Chen <chlily@chromium.org> Cr-Commit-Position: refs/heads/master@{#697260}
-
Will Cassella authored
Since `XRRuntimeManager::GetRuntimeForOptions` returns a non-owning pointer, we can't pipe it all the way from `RequestSession` through `ShowConsentPrompt`, `OnConsentResult`, and `DoRequestSession`. However, we can eliminate the call in `DoRequestSession` (expecting the caller to provide it), and at least pass the ID through to `OnConsentResult` to assert that we receive the same runtime from the call there. Imagine the following scenario: 1) `RequestSession` finds a device, and posts a consent prompt for that device. 2) The device becomes unavailable. 3) The user accepts the consent prompt. 4) `OnConsentResult` selects a different device, and chrome caches consent for it. That's kind of weird, so this CL fixes that scenario. Change-Id: I71385b59f286d3d7c4a78590342eafe716175649 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1804688Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Reviewed-by:
Brandon Jones <bajones@chromium.org> Commit-Queue: Will Cassella <cassew@google.com> Cr-Commit-Position: refs/heads/master@{#697259}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/56bc26904935..ea5731baa00c Created with: gclient setdep -r src-internal@ea5731baa00c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: Id65d099d1e361b9cefdb7eb784640658c67fbb55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808595Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#697258}
-
Sigurdur Asgeirsson authored
It would be a bit harder to separate construction from initialization, because these instances are created through WebContentsUserData<>::CreateForWebContents. Bug: 966840 Change-Id: I18b48518769fb6c99237ae17e87683bd76d8758e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808463Reviewed-by:
Patrick Monette <pmonette@chromium.org> Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Cr-Commit-Position: refs/heads/master@{#697257}
-
Toni Barzic authored
Result of GetTileGridSize() depends on the cached tile padding value, which is set in UpdateTilePadding(). Currently, AppsGridView::Layout calculates grid size before the padding is set, which means that the resulting grid size might not match the current apps grid state if layout is done just after the screen bounds change. The grid size is used to calculate item container bounds, which means the item container bounds get calculated incorrectly after screen bounds change. To fix the issue, call UpdateTilePadding() before GetTileGridSize() BUG=1003756 Change-Id: Ie390d6e3b48bc8fd00f88e9ecc17d759a4d82cc9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1807578Reviewed-by:
Jun Mukai <mukai@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Commit-Queue: Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#697256}
-
Mikel Astiz authored
There are occasional flakes in: external/wpt/html/semantics/embedded-content/media-elements/ready-states/autoplay-hidden.optional.html BUG=1004760 Change-Id: I8e5b5598707e68521fbfeda26d3e030a33153055 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808865 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Auto-Submit: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
-
Nate Fischer authored
No change to logic. This switches to the new device.IsApplicationInstalled() where it helps code readability. Bug: 1002774 Test: Manual - try the scripts Change-Id: I514310922e2453ff887028006e7d97939de81139 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808586 Auto-Submit: Nate Fischer <ntfschr@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#697254}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/08a7e90d730a..818d963727de git log 08a7e90d730a..818d963727de --date=short --no-merges --format='%ad %ae %s' 2019-09-17 vapier@chromium.org fix dict keys usage outside of iteration Created with: gclient setdep -r src/third_party/chromite@818d963727de If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I1c300039cbe8301a9ed1b5258d611494ba8fb811 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808593Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#697253}
-
sczs authored
-Adds a public started property to ChromeActivityOverlayCoordinator, this way we'll know when the UIActivityIndicatorView is being presented. -Prevents CBDTableVC from dismissing when UIActivityIndicatorView is present. -Adds a test for CBD swipe down dismissal. Didn't add one when the UIActivityIndicatorView is present since it can be hard to display for a long time and it can introduce flake in case it takes too long, or its dismissed too quickly. Bug: 980037 Change-Id: Id71af9b302f2956763958d7d097f3dd4534b1b28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808185Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#697252}
-
Chris Dalton authored
Bug: 630695 Change-Id: I48bb3df0f0a8fb5bcc0fbc2e0ac4a4e1bb90d66e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808384 Commit-Queue: Florin Malita <fmalita@chromium.org> Reviewed-by:
Florin Malita <fmalita@chromium.org> Cr-Commit-Position: refs/heads/master@{#697251}
-
Denis Solonkov authored
This change implements two components: 1) SectionHeader class in elf_headers.py 2) _CreateLoadForCompressedSection method in compress_section.py Bug: 998082 Change-Id: I101ca19d1acb900b2366aefb23c93535caa35047 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1798668 Commit-Queue: Denis Solonkov <solonkovda@google.com> Reviewed-by:
Alex Ilin <alexilin@chromium.org> Reviewed-by:
-
Boris Sazonov authored
Disable 'Yes, I'm in' button in the sign-in screen if AccountManagerFacade couldn't obtain accounts due to Google Play services error. mHasGmsError is already checked SigninFragmentBase.areControlsEnabled, so click will be ignored either way. In this case, making the button actually disabled should reduce the confusion. Bug: 997218 Change-Id: Icc84b82290e3df981afe7b6a4871a84e53a31735 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1807326 Commit-Queue: Alex Ilin <alexilin@chromium.org> Auto-Submit: Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
-
Mike Dougherty authored
CRWJSInjectionReceiver shouldn’t be retained, except by CRWWebController. Update other references to weak. Bug: 1004321 Change-Id: I0c936b476fb65c8d1d2e0f0be6f5179257897aab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1807606 Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Auto-Submit: Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#697248}
-
Jacob DeWitt authored
Generic profiles are format "generic-trigger-grip-touchpad-thumbstick" instead of "grip-touchpad-thumbstick-controller". There are also some other slight profile name changes. Bug: 992631 Change-Id: Ic71f0db0e3a8c6dbc9003a045a6ce300ec01b180 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808157Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
-
Scott Violet authored
This is necessary so that any resources that are loaded by the implementation side come from the right place. BUG=none TEST=none Change-Id: Ia493e5fcaf1e955ef621ca8b870a8c63145bab69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808304Reviewed-by:
Clark DuVall <cduvall@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#697246}
-
sczs authored
- Creates Mobile.Messages.ConcurrentPresented Histogram. - Logs the number of multiple concurrent Infobars added to the Infobar Manager. It has to be done at this level in order to count both legacy and "Messages" infobars. Bug: 961343, 1004509 Change-Id: If9680cad03977e22c6ef33829e1884676fe50e6f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1799313 Commit-Queue: Sergio Collazos <sczs@chromium.org> Reviewed-by:
Peter Lee <pkl@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#697245}
-
Nick Burris authored
Ensure a match is bounded by word boundaries. This implementation uses a similar approach to providing FindOptions::kWholeWord to FindBuffer::FindMatchInRange, however that option requires the search text to be a single word. Added tests and a web platform test case. Bug: 924965 Change-Id: Iaa6785181eb29f0d25f64026c3be05d095ace3ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1803723 Commit-Queue: Nick Burris <nburris@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#697244}
-
Etienne Bergeron authored
This CL has main goal to remove calls to the FontLink (GDI) fallback fonts. ShapeRuns is trying to find fonts to shape runs. There are cases where the runs are grouped together but they can be rendered with different fonts. Previously, we were trying to determine the fallback font based on the text of the first run, which is arbitrary. We observed cases where this is not true. As an example: // The following text will be split in 3 runs: // 1) u+1F3F3 u+FE0F u+FE0F (Segoe UI Emoji) // 2) u+0020 (Segoe UI) // 3) u+1F308 u+20E0 u+20E0 (Segoe UI Symbol) The current CL is adding a loop around GetFallback(...) to find the corresponding fallback font for each run using the fast fallback mechanism. We believe this may deprecate the usage of the FontLink code. R=robliao@chromium.org,asvitkine@chromium.org CC=drott@chromium.org Bug: 995789 Change-Id: Iced98fa37f20832d7c86c107472e9fb84ec9d277 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789844Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Dominik Röttsches <drott@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Cr-Commit-Position: refs/heads/master@{#697243}
-
Alex Ilin authored
Reason for reland: Changes were made to preserve compatibility with the old version of mojo library. Original change's description: > Remove use of deprecated SharedMemory in chromeos/wilco_dtc_supportd > > Remove use of the deprecated class SharedMemory. Instead use > the new classes: {Write,ReadOnly}SharedMemory{Region,Mapping}. > > The previous code was wrapping the shared memory inside a mojo > handle. Instead, pass directly the ReadOnlySharedMemory to mojo, > this is the preferred way. > > See Chromium Shared Memory Refactor design doc for more details: > https://docs.google.com/document/d/1lk2-7W7Cy7FDqG-6lgS8LRkzXABYTOytf6VUsWNf8-0/edit#heading=h.7nki9mck5t64 > > Bug: 795291 > Change-Id: I7ee031baf80533dac064fc779e31c40fc0eb202f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1566307 > Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> > Reviewed-by: Polina Bondarenko <pbond@chromium.org> > Reviewed-by: Alex Ilin <alexilin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#667164} Bug: 989503 Change-Id: I42079902caf9ad730e15f8c58d9d834f2dbf0174 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729225Reviewed-by:Oleh Lamzin <lamzin@google.com> Commit-Queue: Oleh Lamzin <lamzin@google.com> Cr-Commit-Position: refs/heads/master@{#697242}
-
Mark Cogan authored
TabStripController relies on -dalloc to stop its various WebStateList observations. If the WebStateList is destroyed before the dealloc runs, the non-empty observer DCHECKs are hit. The upcoming change to WebStateList ownership (see crrev.com/c/1796358) will cause this to happen, for example. To fix this, an explicit -disconnect method is added to TabStripController, and the tab strip coordinator calls it from -stop. Change-Id: I22c2fc967c0b42c544ab93dce17518e93d272f43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809298 Commit-Queue: Mark Cogan <marq@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#697241}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/747b3409bc2d..a90382fcf675 git log 747b3409bc2d..a90382fcf675 --date=short --no-merges --format='%ad %ae %s' 2019-09-17 bsalomon@google.com Pass color types when creating texture with initial data. Created with: gclient setdep -r src/third_party/skia@a90382fcf675 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC brianosman@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=brianosman@google.com Bug: None Change-Id: I5695816bc3b74c8d6e60890445e8ee69795d501b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808591Reviewed-by:
-
Miyoung Shin authored
This CL converts MtpManagerClient{AssociatedPtr, AssociatedPtrInfo} in services and components to the new Mojo type, and uses pending_associated_remote<MtpManagerClient> in mtp_manager.mojom. Bug: 955171 Change-Id: I6fb7561d42ea5dcf6bf6988a0e1d910599202fd1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1804713 Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Reviewed-by:Colin Blundell <blundell@chromium.org> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#697239}
-
Tim van der Lippe authored
ES modules allow files to explicitly import and export symbols [1]. This patch migrates ARIAUtils.js to an ES module, while maintaining backwards compatibility with existing usages of `window.UI.ARIAUtils`. The build system is updated to copy these modules verbatim, as it no longer require pre-processing to be loaded. The `module.json` no longer includes this file as a script, to make sure it is not double-bundled into `shell.js`. Instead, it is added to the new field `modules`, which contains all modules. By doing so, it becomes clear which files are converted to modules already and which require the legacy references to the global scope. This module and future modules will be imported from `root.js`, which is added to all existing HTML application files. Design Doc: https://docs.google.com/document/d/1h9dOy3nNPNfZ2AtZXzB-DwJqG4Oo37WWvKLCuzCcPzo/edit?usp=sharing [1]: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Statements/import TBR=jochen@chromium.org Change-Id: Ie79c8f2fce3aff96fa28af0b575eae39bfe8e1a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1748949Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Tim van der Lippe <tvanderlippe@google.com> Cr-Commit-Position: refs/heads/master@{#697238}
-
Mohamed Amir Yosef authored
Those member fields are leftovers from earlier implementations that are not needed anymore. Instead we should query the FormFetcher. Change-Id: I76a367c332257dd152cf4d3ec9b18b5f150105a9 Bug: 1004783 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809302Reviewed-by:
-
Randy Rossi authored
This feature flag alters chromecast's handling of gestures that originate from the edges of the screne. When enabled, it is assumed an external side swipe gesture detector is installed handling touch events downstream. The touch exploration controller enters pass through mode when touch events originate from the screen edges. The side swipe detector is also not installed. Bug: None Test: Manual, display assistant Change-Id: I23d35a322c09933fde3ac6989a90a692fb40e221 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1793249Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Commit-Queue: Randy Rossi <rmrossi@chromium.org> Cr-Commit-Position: refs/heads/master@{#697236}
-
sczs authored
Bug: 1004604 Change-Id: If571592b94f7505f1111cd957c3f73950b6060c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808380 Auto-Submit: Sergio Collazos <sczs@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#697235}
-
Alex Clarke authored
This web_test occasionally flakes, e.g.: https://test-results.appspot.com/data/layout_results/win10_chromium_x64_rel_ng/366664/webkit_layout_tests%20%28with%20patch%29/layout-test-results/results.html What's happening is depending on the task order test_runner::WebWidgetTestProxy::AnimateNow sometimes triggers this call stack: 0x7f987bf9bfea blink::MediaControlsImpl::NotifyElementSizeChanged()\n 0x7f987bfa7725 blink::MediaControlsImpl::MediaControlsResizeObserverDelegate::OnResize()\n 0x7f988685877e blink::ResizeObserver::DeliverObservations()\n 0x7f9886867879 blink::ResizeObserverController::DeliverObservations()\n 0x7f98858e0ce6 blink::LocalFrameView::NotifyResizeObservers()\n 0x7f98858ecda9 blink::LocalFrameView::RunStyleAndLayoutLifecyclePhases()::$_8::operator()()\n 0x7f98858e316f blink::LocalFrameView::ForAllNonThrottledLocalFrameViews<>()\n 0x7f98858e1dc0 blink::LocalFrameView::RunStyleAndLayoutLifecyclePhases()\n 0x7f98858e13e1 blink::LocalFrameView::UpdateLifecyclePhasesInternal()\n 0x7f98858e0572 blink::LocalFrameView::UpdateLifecyclePhases()\n 0x7f98858e0068 blink::LocalFrameView::UpdateAllLifecyclePhases()\n 0x7f988660b211 blink::PageAnimator::UpdateAllLifecyclePhases()\n 0x7f9886611a26 blink::PageWidgetDelegate::UpdateLifecycle()\n 0x7f988572bf8d blink::WebViewImpl::UpdateLifecycle()\n 0x7f98859d3842 blink::WebViewFrameWidget::UpdateLifecycle()\n 0x7f989a34bf28 content::RenderWidget::UpdateVisualState()\n 0x7f989a06c440 content::LayerTreeView::UpdateLayerTreeHost()\n 0x7f989266f40d cc::LayerTreeHost::RequestMainFrameUpdate()\n 0x7f98927814a5 cc::SingleThreadProxy::DoBeginMainFrame()\n 0x7f9892781118 cc::SingleThreadProxy::CompositeImmediately()\n 0x7f9892672cdf cc::LayerTreeHost::Composite()\n 0x7f98785c21f1 test_runner::DoComposite()\n 0x7f98785c1ff9 test_runner::WebWidgetTestProxy::SynchronouslyComposite()\n 0x7f98785c1b3d test_runner::WebWidgetTestProxy::AnimateNow()\n 0x7f98785c28a5 base::internal::FunctorTraits<>::Invoke<>()\n 0x7f98785c2787 base::internal::InvokeHelper<>::MakeItSo<>()\n 0x7f98785c26f2 _ZN4base8internal7InvokerINS0_9BindStateIMN11test_runner18WebWidgetTestProxyEFvvEJNS_7WeakPtrIS4_EEEEEFvvEE7RunImplIS6_NSt4__Cr5tupleIJS8_EEEJLm0EEEEvOT_OT0_NSD_16integer_sequenceImJXspT1_EEEE\n 0x7f98785c2639 base::internal::Invoker<>::RunOnce()\n 0x7f989d879a3e _ZNO4base12OnceCallbackIFvvEE3RunEv\n 0x7f989da24ac8 base::TaskAnnotator::RunTask()\n 0x7f989da758b4 base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWorkImpl()\n 0x7f989da7510b base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoSomeWork()\n 0x7f989da75bfc base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoSomeWork()\n 0x7f989d92bbad base::MessagePumpDefault::Run()\n 0x7f989da766c9 base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::Run()\n 0x7f989d9bac31 base::RunLoop::Run()\n 0x7f989a381332 content::RendererMain()\n 0x7f989a7c4a80 content::RunZygote()\n 0x7f989a7c4e87 content::RunOtherNamedProcessTypeMain()\n 0x7f989a7c5c0d content::ContentMainRunnerImpl::Run()\n 0x7f989a7c1988 content::ContentServiceManagerMainDelegate::RunEmbedderProcess()\n 0x7f9869d1f74e service_manager::Main()\n 0x7f989a7c4893 content::ContentMain()\n 0x55736df1817a main\n 0x7f9871e3952b __libc_start_main\n 0x55736df1802a _start\n That seems fine by itself and it posts a task to run MediaControlsImpl::ElementSizeChangedTimerFired. The problem happens if something removes the video node before the task posts. If that does happen we get this CHECK failure: ERR: [203657:1:0911/141243.637908:FATAL:media_control_slider_element.cc(105)] Check failed: track. \n 0x7f2a964dddbf base::debug::CollectStackTrace()\n 0x7f2a96212c0d base::debug::StackTrace::StackTrace()\n 0x7f2a96212bc8 base::debug::StackTrace::StackTrace()\n 0x7f2a96264629 logging::LogMessage::~LogMessage()\n 0x7f2a748dd9cb blink::MediaControlSliderElement::GetTrackElement()\n 0x7f2a748de145 blink::MediaControlSliderElement::TrackWidth()\n 0x7f2a748dddfb blink::MediaControlSliderElement::SetBeforeSegmentPosition()\n 0x7f2a748e31ec blink::MediaControlTimelineElement::RenderBarSegments()\n 0x7f2a748ebfca blink::MediaControlsImpl::ElementSizeChangedTimerFired()\n 0x7f2a748fa839 blink::TaskRunnerTimer<>::Fired()\n 0x7f2a78c6c719 blink::TimerBase::RunInternal()\n 0x7f2a78c6d405 base::internal::FunctorTraits<>::Invoke<>()\n 0x7f2a78c6d2e7 base::internal::InvokeHelper<>::MakeItSo<>()\n 0x7f2a78c6d252 _ZN4base8internal7InvokerINS0_9BindStateIMN5blink9TimerBaseEFvvEJNS_7WeakPtrIS4_EEEEEFvvEE7RunImplIS6_NSt4__Cr5tupleIJS8_EEEJLm0EEEEvOT_OT0_NSD_16integer_sequenceImJXspT1_EEEE\n 0x7f2a78c6d199 base::internal::Invoker<>::RunOnce()\n 0x7f2a78635e6e _ZNO4base12OnceCallbackIFvvEE3RunEv\n 0x7f2a786b91fd WTF::ThreadCheckingCallbackWrapper<>::RunInternal()\n 0x7f2a786b7af0 WTF::ThreadCheckingCallbackWrapper<>::Run()\n 0x7f2a786b8955 base::internal::FunctorTraits<>::Invoke<>()\n 0x7f2a786b8861 base::internal::InvokeHelper<>::MakeItSo<>()\n 0x7f2a786b87e2 _ZN4base8internal7InvokerINS0_9BindStateIMN3WTF29ThreadCheckingCallbackWrapperINS_12OnceCallbackIFvvEEES6_EEFvvEJNSt4__Cr10unique_ptrIS8_NSB_14default_deleteIS8_EEEEEEES6_E7RunImplISA_NSB_5tupleIJSF_EEEJLm0EEEEvOT_OT0_NSB_16integer_sequenceImJXspT1_EEEE\n 0x7f2a786b8729 base::internal::Invoker<>::RunOnce()\n 0x7f2a961d2a3e _ZNO4base12OnceCallbackIFvvEE3RunEv\n 0x7f2a9637dac8 base::TaskAnnotator::RunTask()\n 0x7f2a963ce8b4 base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWorkImpl()\n 0x7f2a963ce10b base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoSomeWork()\n 0x7f2a963cebfc base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoSomeWork()\n 0x7f2a96284bad base::MessagePumpDefault::Run()\n 0x7f2a963cf6c9 base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::Run()\n 0x7f2a96313c31 base::RunLoop::Run()\n 0x7f2a92cda332 content::RendererMain()\n 0x7f2a9311da80 content::RunZygote()\n 0x7f2a9311de87 content::RunOtherNamedProcessTypeMain()\n 0x7f2a9311ec0d content::ContentMainRunnerImpl::Run()\n 0x7f2a9311a988 content::ContentServiceManagerMainDelegate::RunEmbedderProcess()\n 0x7f2a6267674e service_manager::Main()\n 0x7f2a9311d893 content::ContentMain()\n 0x55fb45a7517a main\n 0x7f2a6a79052b __libc_start_main\n 0x55fb45a7502a _start\n This patch fixes that by adding a check to MediaControlsImpl::ElementSizeChangedTimerFired to ensure the MediaElement is still connected. NB these flakes get worse with a planned scheduler change where we want to prioritize loading and cmpositing tasks till FCP. BUG: 971191 Change-Id: I5725c013f8fa98e9cc8a36f634b34c033b15b19c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1800768Reviewed-by:
Tommy Steimel <steimel@chromium.org> Commit-Queue: Alex Clarke <alexclarke@chromium.org> Cr-Commit-Position: refs/heads/master@{#697234}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/263def0ec958..e7a75776335a git log 263def0ec958..e7a75776335a --date=short --no-merges --format='%ad %ae %s' 2019-09-17 fmayer@google.com Merge "Add producer for Perfetto Java Heap Profiler." 2019-09-17 fmayer@google.com Add libtinfo5 to sandbox container. Created with: gclient setdep -r src/third_party/perfetto@e7a75776335a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: None Change-Id: I4b38ae7c7eade1a38cc3cd9ce870ef9d742cd0d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808590Reviewed-by:
-
Aaron Leventhal authored
When a <label> changes, Blink uses PostNotification() for the name change on the element pointed to, but DeferTreeUpdate() for the contents of the label element itself. Therefore, the updates can occur at slightly different times. Bug: 1000965 Change-Id: I9d20da6f205c21aeb93e3237009fa905233ad1d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1803595 Auto-Submit: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#697232}
-
Khushal authored
R=rsesek@chromium.org Bug: 1004559 Change-Id: Ibe9b02724f45b2cf92f5e8a9f8c40ac933a73029 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808068 Auto-Submit: Khushal <khushalsagar@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#697231}
-
Sam Maier authored
These are DoNotInline equivalents, explicitly there to prevent verification failures. Bug: 998231 Change-Id: Idd4c030583eb39c99549a098697339ac11d6dc07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775237Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Tobias Sargeant <tobiasjs@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Sam Maier <smaier@chromium.org> Cr-Commit-Position: refs/heads/master@{#697230}
-
Tao Bai authored
Add IsExtensionUrl() in PageLoadMetricsEmbedderInterface, so we can decouple extension from page_load_metrics implementation. Bug: 995880 Change-Id: If4255915154302d852281af35bde3bbaf135f989 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1799030 Commit-Queue: Tao Bai <michaelbai@chromium.org> Reviewed-by:
Bryan McQuade <bmcquade@chromium.org> Cr-Commit-Position: refs/heads/master@{#697229}
-
Jared Saul authored
Bug: 932818 Change-Id: I231712b7bf5b65374e822e098f9bc6d0cc35614b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1807260Reviewed-by:
Siyu An <siyua@chromium.org> Reviewed-by:
-
Xida Chen authored
These two tests already have corresponding tests in wpt, this CL just adds some cases that are not yet covered under wpt. We still keep the prefixed tests to ensure coverage. Tested on both Chrome and Firefox, and they both pass the newly added test cases. Bug: 900581 Change-Id: Ic7ef80eb8d29179080d669b20279b59937c51960 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1805860Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#697227}
-
Alex Turner authored
Adds a NetworkIsolationKey to the requests so that they are still cached when the split cache config is enabled. We set the is_trusted param for a URLLoaderFactory in a safe browsing or system network context as it was previously left unset. Bug: 1003883 Change-Id: I6e93980c6034b11e11b6ab2a0620b377c6c8caa0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1803873Reviewed-by:
Shivani Sharma <shivanisha@chromium.org> Reviewed-by:
Nathan Parker <nparker@chromium.org> Reviewed-by:
-
Tanisha Mandre authored
Fixes a bug introduced in CL: https://chromium-review.googlesource.com/c/chromium/src/+/1699806 - Add flag check to for the 'Add Payment Method' button in the settings menu. - Make only delete button visible when the flag is disabled. Bug:1004349 Change-Id: Ibd31535a21fe2bd78ba3e06e78467f8048cea1f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1807353Reviewed-by:
Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
-
Oleg Davydov authored
Methods and initializations which make sense only for extensions tests moved from generic PolicyTest (int policy_test_util.h) to special ExtensionPolicyTest in extension_policy_browsertest.cc. Note that some tests in policy_browsertest.cc use extensions but don't test extension-related policies, so PolicyTest::LoadUpackedExtension remained in PolicyTest. Bug: 1002483 Change-Id: Ia5a0114bb1c2b8b1240cf41ad8e2c977418efe8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1807219 Commit-Queue: Oleg Davydov <burunduk@chromium.org> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Cr-Commit-Position: refs/heads/master@{#697224}
-
