GitLab

* Fix include:
   1) handle cases thread_times = None
   2) disable testBlinkPerfTracingMetricsForMeasureTime on Win

This CL adds support for tracing metrics with measureTime &
measureFrameTime methods in blink_perf harness.

If a test has "tracingCategories" & "traceEventsToMeasure" fields
specified, Telemetry will enable the specified tracing categories &
compute the cpu time of all the specified trace events (one per test
run).

Detailed examples of how to use this new API are in third_party/WebKit/PerformanceTests/TestData/

BUG=701059, 715822

TBR=wangxianzhu@chromium.org

Reviewer: you can see this in action by patching this CL & run:
./tools/perf/run_benchmark --browser=system blink_perf.testing --story-filter=frame --output-format=json
[ RUN      ] append-child-measure-time.html
...
...
CPU times of trace event "UpdateLayoutTree":
values 1.8760000000, 3.2080000000, 3.4260000000, 1.9020000000, 1.6990000000, 2.2940000000, 1.8570000000, 1.7100000000, 1.4170000000, 1.4150000000 ms
avg 2.0804000000 ms

CPU times of trace event "FrameView::layout":
values 4.6150000000, 8.3140000000, 8.6080000000, 4.4360000000, 4.0940000000, 5.9130000000, 4.5970000000, 3.9440000000, 3.4590000000, 3.4600000000 ms
avg 5.1440000000 ms
[ RUN      ] color-changes-measure-frame-time.html
...
...
CPU times of trace event "FrameView::prePaint":
values 5.9890000000, 5.9640000000, 6.2360000000, 6.3870000000, 5.9490000000, 6.3450000000, 6.3340000000, 6.9270000000, 6.8910000000 ms
avg 6.3357777778 ms

CPU times of trace event "FrameView::paintTree":
values 30.0950000000, 30.5020000000, 30.6510000000, 30.3380000000, 30.4160000000, 30.3480000000, 30.5110000000, 30.7570000000, 30.6140000000 ms
avg 30.4702222222 ms

After running the command above, the command also produces 2 trace files
locally, one for each test.

Review-Url: https://codereview.chromium.org/2819343002
Cr-Commit-Position: refs/heads/master@{#467445}
Committed: https://chromium.googlesource.com/chromium/src/+/0d2d43615b4553f00ac711f54dbcc0835f04366b

patch from issue 2819343002 at patchset 270001 (http://crrev.com/2819343002#ps270001)

Review-Url: https://codereview.chromium.org/2844133002
Cr-Commit-Position: refs/heads/master@{#467637}

BUG=715691

Review-Url: https://codereview.chromium.org/2844043002
Cr-Commit-Position: refs/heads/master@{#467636}

* createImageData() and getImageData() must return an ImageData for which the color space and storage format matches those of canvas.
If canvas pixel format is "float16", the storage format of the returned ImageData must be "float32". Values must be properly converted from float16 to float32.

* putImageData must do the color conversion from the color space and storage format of given ImageData to the color space and matching pixel format of canvas prior to putting data into the canvas.

BUG=704155,709777

Review-Url: https://codereview.chromium.org/2797213002
Cr-Commit-Position: refs/heads/master@{#467635}

Enables client certificate patterns for EAP-TLS networks in device
ONC policy. Device-wide client certificate patterns are restricted
to only match certificates which are present in the system token.
This prevents the device from presenting the user's certificates
involuntarily.

Two supporting changes were made to achieve this:
- CertLoader has been extended by the system_cert_list() method
  to retrieve available certificates which exist on the system token.
- The ClientCertConfig struct has a new onc_source member which
  can be checked to see if the client cert pattern originates from
  device policy.

BUG=655266
TEST=unit_tests && chromeos_unittests
Manual test scenario:
--
Prerequisites:
Install a certificate (subject common name e.g.: “cert_user”)
into the user token and a different certificate (subject common
name e.g.: “cert_system”) into the system token.
Have a EAP-TLS wifi network connected to a radius server which
would accept both client certificates.
--
Test Case 1: device policy ONC / user token certificate
Configure a device policy OpenNetworkPolicy to connect to the
EAP-TLS network with
     "ClientCertPattern": {
      "Subject": {
       "CommonName": "cert_user"
      }
Expected result: The device does not try to auto-connect to the
wifi network because the ClientCertPattern originating from device
policy does not match user certificates.
--
Test Case 2: device policy ONC / system token certificate
Configure a device policy OpenNetworkPolicy to connect to the
EAP-TLS network with
     "ClientCertPattern": {
      "Subject": {
       "CommonName": "cert_system"
      }
Expected result: The device auto-connects to the wifi network
because the ClientCertPattern originating from device policy
matches certificates present on the system token. It authenticates
with cert_system.
--
Test Case 3: user policy ONC / user token certificate
Configure a user policy OpenNetworkPolicy to connect to the
EAP-TLS network with
     "ClientCertPattern": {
      "Subject": {
       "CommonName": "cert_user"
      }
Expected result: The device auto-connects to the wifi network. It
authenticates with cert_user.
--
Test Case 4: user policy ONC / system token certificate
Configure a user OpenNetworkPolicy to connect to the EAP-TLS network
with
     "ClientCertPattern": {
      "Subject": {
       "CommonName": "cert_system"
      }
Expected result: The device auto-connects to the wifi network. It
authenticates with cert_system.

Review-Url: https://codereview.chromium.org/2828713002
Cr-Commit-Position: refs/heads/master@{#467634}

Move several safe-looking task types to suspendable task runner.
More task types will be moved to suspendable task runner, but
we'll start with this set and will monitor any problems
(there were some perfbot failures when all task queues were
moved to suspendable task runner).

R=haraken@chromium.org
CC=skyostil@chromium.org
BUG=702160

Review-Url: https://codereview.chromium.org/2808273003
Cr-Original-Commit-Position: refs/heads/master@{#464025}
Committed: https://chromium.googlesource.com/chromium/src/+/78a049660074003b8e1e602b0e7783ca7f1f4ee0
Review-Url: https://codereview.chromium.org/2808273003
Cr-Commit-Position: refs/heads/master@{#467633}

The blocking pool is being deprecated in favor of TaskScheduler.

BUG=667892

Review-Url: https://codereview.chromium.org/2839973002
Cr-Commit-Position: refs/heads/master@{#467632}

In crrev.com/2794803003 I introduced a bug that caused "Load unpacked extension" screen (available under chrome://extensions) to not display any files. This CL fixes it.

BUG=707864

Review-Url: https://codereview.chromium.org/2840043002
Cr-Commit-Position: refs/heads/master@{#467631}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/822954dd..fc61514c

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2843373002
Cr-Commit-Position: refs/heads/master@{#467630}

BUG=699269

Review-Url: https://codereview.chromium.org/2841383002
Cr-Commit-Position: refs/heads/master@{#467629}

I think it was accidentally removed in
https://codereview.chromium.org/2825133002.

BUG=

Review-Url: https://codereview.chromium.org/2851433002
Cr-Commit-Position: refs/heads/master@{#467628}

Changes: https://chromium.googlesource.com/external/webrtc/trunk/webrtc.git/+log/ce4e632..f66bef3

$ git log ce4e632..f66bef3 --date=short --no-merges --format=%ad %ae %s
2017-04-27 magjed@webrtc.org ObjC: Split out NV12 texture uploading into separate class
2017-04-27 glaznev@webrtc.org Support adding and removing MediaRecorder to camera 2 session.
2017-04-26 deadbeef@webrtc.org Allow a received audio codec's payload type to change.
2017-04-26 henrik.lundin@webrtc.org NetEq: Add a VoidAudioSink tool
2017-04-26 deadbeef@webrtc.org Don't crash if STUN error message is missing ERROR-CODE attribute.
2017-04-26 henrik.lundin@webrtc.org NetEq: Limit payload size for replacement audio input
2017-04-26 philipel@webrtc.org Stashed frames are now retried in a loop rather than recursively.
2017-04-26 henrik.lundin@webrtc.org NetEq: Add functionality to assist with delay analysis and tooling
2017-04-26 oprypin@webrtc.org Fix redirecting to local AppRTC server in video quality test
2017-04-26 sakal@webrtc.org Pause changing surface size when rendering is paused.

TBR=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng
BUG=

Review-Url: https://codereview.chromium.org/2849503002
Cr-Commit-Position: refs/heads/master@{#467627}

BUG=715414

Review-Url: https://codereview.chromium.org/2843363002
Cr-Commit-Position: refs/heads/master@{#467626}

Add the possibility to have month and years in time format.
A year is defined as 365 days.
A month is defined as 1year / 12.

'1 month' means more than one month and less than two month (same for
years).

CL mainly made by olivierrobin

BUG=694451

Review-Url: https://codereview.chromium.org/2845693002
Cr-Commit-Position: refs/heads/master@{#467625}

Save the data reduction proxy preferences in backups. Both the Java
and the C++ preferences are needed, since the Java pref is used during
startup.

BUG=705501

Review-Url: https://codereview.chromium.org/2843963002
Cr-Commit-Position: refs/heads/master@{#467624}

Revert of binding: Changes the association among global-proxy/global/window-instance (2nd attempt). (patchset #7 id:120001 of https://codereview.chromium.org/2693893007/ )

Reason for revert:
The change should be causing crash issues.
https://crbug.com/712638
https://crbug.com/713676
https://crbug.com/713667
https://crbug.com/715150
The root cause could be different but the CL should have at least triggered the crashes.

Original issue's description:
> binding: Changes the association among global-proxy/global/window-instance (2nd attempt).
>
> The first attempt is: https://crrev.com/2617733004
>
> Since V8 now supports internal fields for the global proxies,
> let's change the mappings among global proxy / global object /
> C++ instance in Blink.
>
> With this CL, the global proxy and C++ instance point to each
> other, and a global object points to the C++ instance (without
> reverse pointer).
>
> Note that this CL makes one big difference.  For non-window objects,
> Blink objects always live longer than V8 wrappers.  This CL
> introduces an exception; DOMWindow may be collected before the V8
> wrapper object gets collected because the V8 wrapper is the global
> proxy which remains the same while navigations.
>
> BUG=675872
> Review-Url: https://codereview.chromium.org/2693893007
> Cr-Commit-Position: refs/heads/master@{#465197}
> Committed: https://chromium.googlesource.com/chromium/src/+/ae0d679c61a85bc16722724a4a96e30a1dee9dd2

This CL reverts the following CL, too.
v8binding: Makes ToV8(window) work without a frame.
https://codereview.chromium.org/2713623002/

Original issue's description:
> v8binding: Makes ToV8(window) work without a frame.
>
> Makes DOMWindow hold a WindowProxyManager and makes
> it possible that ToV8(window) work without a frame.
>
> With this CL, all tests in
> external/wpt/html/webappapis/scripting/events/compile-event-handler-settings-objects.html
> pass without a failure.
>
> This CL is a preparation for
> https://crrev.com/2693893007
>
> BUG=
>
> Review-Url: https://codereview.chromium.org/2713623002
> Cr-Commit-Position: refs/heads/master@{#464907}
> Committed: https://chromium.googlesource.com/chromium/src/+/58af3664facba6332528fd983988d51cf3636af4

BUG=712638,713676,713667,715150

Review-Url: https://codereview.chromium.org/2848503002
Cr-Commit-Position: refs/heads/master@{#467623}

This interface isn't helpful.

BUG=591919

Review-Url: https://codereview.chromium.org/2841393002
Cr-Commit-Position: refs/heads/master@{#467622}

The rvrn feature [1] and the FeatureVariations part of GSUB describe
single glyph substitutions dependent on variation axis values. In order
to add test coverage for this, the variabletest_box.ttf font was
extended to have two new glyphs for r and R respectively displaying
"rvrn base" and "rvrn subst" (for "substituted"). When a new axis
'fvtt', ranging from 0 to 10, is set to >= 5, the rvrn_base glyph is
replaced with the rvrn_subst glyph. This enables creating a reftest of
where a lowercase r with font-variation-settings: "fvtt" 10; must match
the uppercase R, which selects the "rvrn_subst" glyph explicitly.

[1] https://www.microsoft.com/typography/OTSpec/features_pt.htm#rvrn

BUG=715900

Review-Url: https://codereview.chromium.org/2845953002
Cr-Commit-Position: refs/heads/master@{#467621}

Move CompositionUnderlineVectorBuilder.h to core/editing/ as part of the
removal of the web/ layer.

Now that core has visibility into public/web/ we can remove
CompositionUnderlineBuilder entirely and just provide a copy constructor on
CompositionUnderling to do the conversion from WebCompositionUnderline.

BUG=708879

Review-Url: https://codereview.chromium.org/2826373002
Cr-Commit-Position: refs/heads/master@{#467620}

Original CL: http://crrev.com/2747293005

Current implementation of AccountManagerHelper can instantiate wrong delegate
type if get() is called in too early. This CL fixes it. AtomicReference is used
to avoid relying on external synchronization, because get() can be called
from different threads. This CL also adds
AccountManagerHelper.resetAccountManagerHelperForTests method that makes sure
there's no interference between tests.

BUG=698258,710901
TBR=rogerta@chromium.org

Review-Url: https://codereview.chromium.org/2836373003
Cr-Commit-Position: refs/heads/master@{#467619}

Set the class var to nullptr in the constructor. Missing initialization
is suspected to cause crash.

BUG=715826

Review-Url: https://codereview.chromium.org/2842373002
Cr-Commit-Position: refs/heads/master@{#467618}

This is needed so that subclass destructors will be called when
destroying a PermissionPromptDelegate pointer. This currently has no
impact on behavior since there are no subclass destructors.

BUG=596786

Review-Url: https://codereview.chromium.org/2836093006
Cr-Commit-Position: refs/heads/master@{#467617}

Before we can generate StyleInheritedData, we must first remove any
references to it outside of ComputedStyle. A lot of files include the
header file for StyleInheritedData, but do not use it. This will cause
a compile error when we remove the file to generate it instead.

This patch removes the unused includes, as lead-up to generating
StyleInheritedData.

BUG=628043

Review-Url: https://codereview.chromium.org/2844613002
Cr-Commit-Position: refs/heads/master@{#467616}

This change fixes two issues:

1. Clamp instead of casting double values from parser to internal
   unsigned storage.
2. Promote width/height/numerator/denominator multiplications to double
   to avoid integer overflow for large numerator/denominators.

R=yoav@yoav.ws,suzyh@chromium.org
BUG=676709,714079

Review-Url: https://codereview.chromium.org/2836613002
Cr-Commit-Position: refs/heads/master@{#467615}

Add 'pending AssociatedInterfacePtr connection error with reason' test to associated_interface_ptr.html

BUG=695635

Review-Url: https://codereview.chromium.org/2843183002
Cr-Commit-Position: refs/heads/master@{#467614}

The interface taking a raw pointer is deprecated and being removed.

BUG=690937

Review-Url: https://codereview.chromium.org/2842263003
Cr-Commit-Position: refs/heads/master@{#467613}

This patch prunes the deprecated function from
DOMSelection::deleteFromDocument to improve code health.

BUG=698633
TEST=n/a; no behaviorial change

Review-Url: https://codereview.chromium.org/2844983002
Cr-Commit-Position: refs/heads/master@{#467612}

The blocking pool is being deprecated in favor of TaskScheduler.

BUG=667892
R=boliu@chromium.org

Review-Url: https://codereview.chromium.org/2837863003
Cr-Commit-Position: refs/heads/master@{#467611}

Accodring to Android documentation [1] read and write operations for
Ndef technology, should not throw IllegalStateException, however, those
operations do throw exception that must be handled. Unit tests are
updated to check that exception is handled and correct error reported
to caller.

[1] https://developer.android.com/reference/android/nfc/tech/Ndef.html

BUG=714039

Review-Url: https://codereview.chromium.org/2845463004
Cr-Commit-Position: refs/heads/master@{#467610}

I'm going to start writing different implementations of DocumentMarkerList for
the different MarkerTypes. This CL prepares us to be able to easily specify the
marker list class we want to use for each MarkerType.

BUG=707867

Review-Url: https://codereview.chromium.org/2826493003
Cr-Commit-Position: refs/heads/master@{#467609}

When the migration UI is notified by cryptohome that cryptohome gets unexpected
errors during migration and it gives up migration, we should remove the
user's cryptohome to make sure that the user will be able to log in to
the Desktop next time.

After the user's cryptohome is removed, we get password verification errors
on the existing user pod three times.
It seems an independent issue, so I filed crbug.com/715474 and will look into separately.

BUG=713556
TEST=manually tested by forcing cryptohome fail during migration and confirming the cryptohome is gone.

Review-Url: https://codereview.chromium.org/2838303003
Cr-Commit-Position: refs/heads/master@{#467608}

This changes TestStore to inherit from Store, allowing tests to use
more production code paths. It also adds a new flag to TestStore which
allows page actions to be handled normally (rather than preventing them
from executing), which is useful for integration testing.

BUG=697706

Review-Url: https://codereview.chromium.org/2839393002
Cr-Commit-Position: refs/heads/master@{#467607}

This patch does two things:
- Remove public methods on StyleBoxData. This is because these methods
  will no longer exist once we generate StyleBoxData.
- Rename vertical_align_ -> vertical_align_length_, to differentiate it
  from the keyword part of vertical-align (also called vertical_align_,
  stored in ComputedStyleBase)

This is preparation for generating StyleBoxData.

BUG=628043

Review-Url: https://codereview.chromium.org/2844163002
Cr-Commit-Position: refs/heads/master@{#467606}

The 'motion-path' property has been replaced by 'offset-path'.

'motion-path' is among the properties disabled in M58.

BUG=711937
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2827003002
Cr-Commit-Position: refs/heads/master@{#467605}

- Process the output of 'ninja' live through the pipe rather than
  waiting for it to finish.
- Use multiprocessing.

Benchmark results using pypy:
Before:
17.10user 14.38system 0:20.05elapsed 157%CPU (0avgtext+0avgdata 1708036maxresident)k
18.06user 15.63system 0:21.92elapsed 153%CPU (0avgtext+0avgdata 1710912maxresident)k
17.94user 13.72system 0:19.91elapsed 158%CPU (0avgtext+0avgdata 1172128maxresident)k

After:
15.28user 7.11system 0:06.25elapsed 357%CPU (0avgtext+0avgdata 319236maxresident)k
16.03user 7.74system 0:06.84elapsed 347%CPU (0avgtext+0avgdata 319396maxresident)k
15.24user 8.16system 0:06.36elapsed 367%CPU (0avgtext+0avgdata 318272maxresident)k

BUG=661774

Review-Url: https://codereview.chromium.org/2842513003
Cr-Original-Commit-Position: refs/heads/master@{#466900}
Review-Url: https://codereview.chromium.org/2846473002
Cr-Commit-Position: refs/heads/master@{#467604}

Currently:
- width and height share the same initial method InitialSize
- minWidth and minHeight share the same initial method InitialMinSize
- maxWidth and maxHeight share the same initial method InitialMaxSize

This patch makes each of those properties use its own initial method so
that they can be more easily generated (the generator does not support
sharing of initial methods).

Diff of generated files:
https://gist.github.com/d058699c786d95762067b28ccfbc1774/revisions

BUG=628043

Review-Url: https://codereview.chromium.org/2841353002
Cr-Commit-Position: refs/heads/master@{#467603}

This CL expands the comment for the UMA_HISTOGRAM_SPARSE_SLOWLY macro.
It is inspired by a recent code review discussion with isherman@.

BUG=none

Review-Url: https://codereview.chromium.org/2831543002
Cr-Commit-Position: refs/heads/master@{#467602}

Test network annotation tags added to network requests of:
net/base/layered_network_delegate_unittest.cc
net/filter/sdch_policy_delegate_unittest.cc
net/log/net_log_util_unittest.cc
net/log/write_to_file_net_log_observer_unittest.cc
net/nqe/network_quality_estimator_test_util.cc
net/nqe/network_quality_estimator_unittest.cc
net/nqe/throughput_analyzer_unittest.cc
net/quic/chromium/quic_network_transaction_unittest.cc
net/spdy/spdy_network_transaction_unittest.cc
net/test/embedded_test_server/embedded_test_server_unittest.cc
net/websockets/websocket_end_to_end_test.cc

BUG=656607

Review-Url: https://codereview.chromium.org/2833983002
Cr-Commit-Position: refs/heads/master@{#467601}

https://skia.googlesource.com/skia.git/+log/b8a1392b021f..ac0e705af1d6

$ git log b8a1392b0..ac0e705af --date=short --no-merges --format='%ad %ae %s'
2017-03-07 amaury.leleyzour Fix new IT blocks ARMv8

Created with:
  roll-dep src/third_party/skia


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=benjaminwagner@chromium.org

Change-Id: I1727756725ce39d1bff9b837f91204a3e423942e
Reviewed-on: https://chromium-review.googlesource.com/487739Reviewed-by: Skia Deps Roller <skia-deps-roller@chromium.org>
Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#467600}

DOM: NodeIterator.filter and TreeWalker.filter should return values which were specified to createNodeIterator/createTreeWalker.

We used to return values wrapped by NodeIterator interface. The DOM specification
doesn't define such behavior, and Edge, Firefox, and Safari do not.

The core part of this CL is CPP_VALUE_TO_V8_VALUE in v8_types.py. We return a v8
value stored in V8NodeFilterCondition.

Because we don't need to wrap values by NodeFilter, this CL has simplification like:

- Cleanup of indirection ownership;
 Old: NodeIteratorBase -> NodeFilter -> V8NodeFilterCondition as NodeFilterCondition
 New: NodeIteratorBase -> V8NodeFilterCondition

- Removal of a V8PrivateProperty
 It can be replaced with TraceWrapper.

This CL fixes 1,106 failures in external/wpt/dom/.

BUG=591919, 715418

Review-Url: https://codereview.chromium.org/2840163002
Cr-Commit-Position: refs/heads/master@{#467599}

They will show improvement of upcoming optimization changes.

Review-Url: https://codereview.chromium.org/2842313002
Cr-Commit-Position: refs/heads/master@{#467598}