GitLab

TBR=rsleevi@chromium.org

Change-Id: I3e63dc63920c2c23782c955f13f19b1a42c3bc56
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872159Reviewed-by: Nick Harper <nharper@chromium.org>
Reviewed-by: Ryan Sleevi <rsleevi@chromium.org>
Commit-Queue: Nick Harper <nharper@chromium.org>
Cr-Commit-Position: refs/heads/master@{#708062}

This re-lands f72a8099
"WebLayer: add tests for DownloadDelegate"

Bug: none
Change-Id: Ie18d955d2754baa9a91d742844ba42fdbc823d93
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872461
Commit-Queue: Evan Stade <estade@chromium.org>
Reviewed-by: Clark DuVall <cduvall@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#708061}

Bug: none
Change-Id: I796e54e6d92123dde787df0a674c4ba556fcf56a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869750
Commit-Queue: Dan Beam <dbeam@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Auto-Submit: Dan Beam <dbeam@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#708060}

Bug: 1002733
Change-Id: I9627f1c3208a0c0a8aaf1c1fe393266dfaa4bfd7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872755Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Commit-Queue: Min Chen <minch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#708059}

Currently, on Krane devices, the wallpaper preview header navbar is
cut off awkwardly because there is a hardcoded length.  This CL
ensures that the navbar changes size based on the screensize, so
the navbar doesn't cut off awkwardly.

screenshots (both after):
https://screenshot.googleplex.com/5wXNJCk2nww
https://screenshot.googleplex.com/wprpDqdd7mP

Bug: 997474
Change-Id: I99e89c57cf822c4e363313d2096aade2519f1101
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1868595
Commit-Queue: Regan Hsu <hsuregan@chromium.org>
Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#708058}

This initial implementation always displays the buttons in app windows
when the new "DesktopMinimalUI" feature flag is enabled. For now, the
buttons are shown in the top-right corner.

Remaining work:
- only show the buttons when minimal-ui is specified in the app manifest
- move the buttons to the top left corner
- decide on a color to use when "Back" is disabled

Screen shots:
https://bugs.chromium.org/p/chromium/issues/detail?id=1007151#c6

TBR: alemate@chromium.org
Bug: 1007151
Change-Id: I1a6bf03823462f684326d34f019f201902a1589b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863050
Commit-Queue: Eric Willigers <ericwilligers@chromium.org>
Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Reviewed-by: Alan Cutter <alancutter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#708057}

Bug: 959679
Change-Id: Ibe31eb89715b60313fef5b6772d9a1c5f2bd3c7b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866090Reviewed-by: Nik Bhagat <nikunjb@chromium.org>
Commit-Queue: Tony Yeoman <tby@chromium.org>
Cr-Commit-Position: refs/heads/master@{#708056}

The current base32 component only has an encoder. A decoder would be
valuable, especially in testing situations where the input of the
encoder can be compared to decoded output of the encoder.

Change-Id: Ic675bb7dff405237d04f563f465a89966270bce4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865545Reviewed-by: Gabriel Charette <gab@chromium.org>
Commit-Queue: Daniel Hosseinian <dhoss@chromium.org>
Cr-Commit-Position: refs/heads/master@{#708055}

When the 'shelf-hotseat' flag is enabled, the back button will only be
shown in tablet mode when in-app.

Some unittests have been changed to ensure the back button functionality
still works both with and without the 'shelf-hotseat' flag enabled.

Bug: 1012043
Change-Id: I9754f7a3d08473d4ecdd1573aa1ecf6ce33186ae
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857186
Commit-Queue: Matthew Mourgos <mmourgos@chromium.org>
Reviewed-by: Manu Cornet <manucornet@chromium.org>
Cr-Commit-Position: refs/heads/master@{#708054}

https://webrtc.googlesource.com/src.git/+log/eef5e4ffc239..ead0ec9a2017

git log eef5e4ffc239..ead0ec9a2017 --date=short --no-merges --format='%ad %ae %s'
2019-10-21 elrello@microsoft.com Add firing of OnRemoveTrack and OnRenegotationNeeded during rollback
2019-10-21 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 8587b26e..b528279c (707701:707828)

Created with:
  gclient setdep -r src/third_party/webrtc@ead0ec9a2017

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/webrtc-chromium-autoroll
Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

TBR=webrtc-chromium-sheriffs-robots@google.com

Bug: chromium:980875,chromium:None
Change-Id: I9a36982fae02d10eee067a1f65a552788666c6a0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872895Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#708053}

I added an example usage code snippet to the comments above
LoggedInUserMixin to further clarify how to use this class.

Bug: None
Change-Id: I22e13b93e736c5bc4fe3164815adf0ac49e42ccc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873136Reviewed-by: Aga Wronska <agawronska@chromium.org>
Commit-Queue: Toby Huang <tobyhuang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#708052}

AppServiceDataSource is used for the Apps searching on Chrome OS, so
the Extenions, ARC and Crostini's DataSource can be removed. Related
AppResult is removed too.

ExtensionAppResult is removed as well. So the unit test for
ExtensionAppResult is removed.

BUG=1016159

Change-Id: Ibf3c67b10178419772e2aabb2466721799658336
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1858538Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Commit-Queue: Nancy Wang <nancylingwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#708051}

When triggering a share intent chooser, use startActivityForResult as it
allows Chrome to receive a callback when the activity finishes and can
propagate the cancel much sooner.

This required swapping out Activity for WindowAndroid in the share API,
so it is largely a mechanical swap in the various places triggering share.

BUG=636274

Change-Id: Id3628e65757ca54713a57eefcd47efec24fc65a4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832589Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Commit-Queue: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#708050}

This CL refactors the handling of icons in AddToHomescreenDataFetcher so
that WebAPKs which have maskable icons have that icon correctly masked
in the A2HS prompt, but still use the raw icon in the WebAPK itself.

Using the raw icon in the WebAPK is necessary to ensure that the OS and
WebAPK server always have the original icon on which to apply their own
masks. However, that original icon is inappropriate to show the user in
the A2HS prompt, so ensure we mask it manually before it is shown.

BUG=977173

Change-Id: Ib3e469d31e236ef961f72d25dfb2170723fa73c4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869151
Commit-Queue: Dominick Ng <dominickn@chromium.org>
Commit-Queue: Mehran Mahmoudi <mahmoudi@chromium.org>
Reviewed-by: Mehran Mahmoudi <mahmoudi@chromium.org>
Auto-Submit: Dominick Ng <dominickn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#708049}

Bug: 985574
Change-Id: Ib2b3bee4601b3fe01aa3ff59548dc66fd4ed6ece
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872926Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Yun Liu <yliuyliu@google.com>
Cr-Commit-Position: refs/heads/master@{#708048}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/c21b70d6b576..e9fd87c45f43


Created with:
  gclient setdep -r src-internal@e9fd87c45f43

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC jbudorick@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome
TBR=jbudorick@google.com

Bug: chromium:None
Change-Id: Ib06a94ac8460f365bcbbe4aba47120065d2b4ca3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872896Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#708047}

This is a reland of a9df5b29

Differences from original cl:
- PageInfoUI::SecurityDescription GetSecurityDetails() changed to
PageInfoUI::SecurityDescriptionType GetSecurityDescriptionType()
- Initialize security_description_type_ in the header file
- In safety_tip_page_info_bubble_view_browsertest, static cast to a
regular page info bubble instead of safety tip bubble for
CheckPageInfoDoesNotShowSafetyTipInfo

Original change's description:
> Handle Safety Tip learn more link in page info
>
> Bug: 1007497
> Change-Id: I4498d39cabf4736a697294ad027082a53894a623
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857166
> Reviewed-by: Joe DeBlasio <jdeblasio@chromium.org>
> Reviewed-by: Emily Stark <estark@chromium.org>
> Commit-Queue: Livvie Lin <livvielin@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#706076}

Bug: 1007497
Change-Id: I8dcebe8a7ab974e72eea24280578f8f6830031b3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1867478Reviewed-by: Joe DeBlasio <jdeblasio@chromium.org>
Reviewed-by: Emily Stark <estark@chromium.org>
Commit-Queue: Livvie Lin <livvielin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#708046}

Looking through some of the comments on the pam_systemd module, it looks
like there were a couple things that weren't quite correct. This
(mostly) fixes them. It has the added benefit of enabling GNOME sessions
to launch within CRD on Ubuntu 18.04 (though not at the same time as on
the local console).

Bug: 1016583
Change-Id: I45441b346866dc0bbf02e43096e49c7d985ae4b7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873245Reviewed-by: Jamie Walch <jamiewalch@chromium.org>
Commit-Queue: Erik Jensen <rkjnsn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#708045}

With the on-going changes in the Blink tree, ChromeVox can once again not rely on nodes persisting their ids.

Blink may choose to destroy and re-create an entire subtree of nodes in reaction to a page making some kind of update. The actual DOM does not change, but Blink re-creates the accessibility subtree (resulting in new nodes, with new ids).

Note that ChromeVox has flip flopped on using tree path recovery in the past.
Related bugs:
885244
945708
(each of these were verified to work after this change).

Related changes:
https://chromium-review.googlesource.com/c/chromium/src/+/1889165
https://chromium-review.googlesource.com/c/chromium/src/+/1539262

Change-Id: I1c0bb78ce448c601d116aa90e408c36cab21b3d6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872557Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: David Tseng <dtseng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#708044}

Fix the following classes of lint errors

For i18n-content use javaScriptCase.
Found lines longer than 80 characters

This CL was generated manually, using code-search to double-check that
all references were updated.

BUG=None
TEST=Deploy to eve, check feedback dialog

Change-Id: Iaaf3d565fafcca251096fe97b48a3a4f363d8f61
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869995Reviewed-by: J Kardatzke <jkardatzke@chromium.org>
Reviewed-by: Ian Barkley-Yeung <iby@chromium.org>
Commit-Queue: Miriam Zimmerman <mutexlox@chromium.org>
Cr-Commit-Position: refs/heads/master@{#708043}

This is a reland of e0dffd84.
706934 fixed the compile issue with headless code and the
issues with the delayloads_unittests have been resolved.

Original change's description:
> Set is_multi_dll_chrome to false by default
>
> This change sets is_multi_dll_chrome to false by default thus merging
> chrome.dll and chrome_child.dll to a single dll.  This saves disk space
> and improves startup performance.  It is also consistent with all other
> platforms (windows was the only platform the split was enabled by
> default).
>
> Bug: 726150
> Change-Id: Iade2c7f1bbe696d45ebac7483072f7e2e7e84ab4
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1850272
> Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
> Reviewed-by: Will Harris <wfh@chromium.org>
> Reviewed-by: Nico Weber <thakis@chromium.org>
> Commit-Queue: Nico Weber <thakis@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#705667}

Bug: 726150
Change-Id: I8261e781102e23b2c2319a181295655dfda3b811
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1868389Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Will Harris <wfh@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#708042}

Adds |mOrigin| to keep track of the origin ID used.

Also removes some unnecessary logging, especially of errors when
a security level is not supported.

Bug: 917527
Test: Installed Chrome and looked at the adb log
Change-Id: Icb930af9b96da42d4ce1c675639ada4cb5cfc8ce
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1802697Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
Commit-Queue: John Rummell <jrummell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#708041}

Re-enables the Telemetry minidump symbolization tests on ChromeOS, but
with additional logging if several asserts fail. The flakiness that
caused the tests to be disabled on ChromeOS has not reproed locally or
on swarming, so hopefully this will give us enough information to fix
the issue if it occurs again on the bots.

Bug: 1014754
Change-Id: I9c064c0600dc713d2325b6eb5bdd77cdbe6a3eef
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869340
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Auto-Submit: Brian Sheedy <bsheedy@chromium.org>
Reviewed-by: Caleb Rouleau <crouleau@chromium.org>
Cr-Commit-Position: refs/heads/master@{#708040}

Since the WindowCycleView is owned by the Views hierarchy, its
Layout() may get called even after WindowCycleList is destroyed.
This CL fixes the crash by making sure Layout() returns early
in such situation.

BUG=1013174
TEST=Run test with --gtest_repeat=20, no flakes at all.

Change-Id: I6b2e66ac9695f27de2969b7c4fb6729b43db79f9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873087Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Ahmed Fakhry <afakhry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#708039}

This is necessary for the case where a dynamic group leader has its
resources revoked. In that situation, it needs to release its resources
without stopping the cast app; thus, the CastRenderer needs to remain
but the resources need to be released.

Test: With chromecast internal changes on 1.40ac branch.
Bug: b/141143745
Change-Id: Ia69aa32e7f97bd4126bead4f650f210d00e98d02
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872240
Commit-Queue: Antonio Rivera <antoniori@google.com>
Reviewed-by: Yuchen Liu <yucliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#708038}

Bug: 268984
Change-Id: Id59283a4bde7a87a88345672b10d9db9bf9b9c17
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869829Reviewed-by: Brandon Tolsch <btolsch@chromium.org>
Commit-Queue: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#708037}

Bug: 1016321
Change-Id: I50d285da5cfb1b3e8f8738c5fa16f5e85ebb2671
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872456Reviewed-by: kylechar <kylechar@chromium.org>
Reviewed-by: Brian White <bcwhite@chromium.org>
Commit-Queue: Peng Huang <penghuang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#708036}

Bug: 268984
Change-Id: I1e4e34c663cfa2c2cc2d5d903ee506b7171c4881
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869022Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#708035}

test_computed_value now checks that the value is supported.

Change-Id: Ic8c38df6030b3689f4fdec30a55f230d6cc113d2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866498Reviewed-by: Alison Maher <almaher@microsoft.com>
Commit-Queue: Eric Willigers <ericwilligers@chromium.org>
Auto-Submit: Eric Willigers <ericwilligers@chromium.org>
Cr-Commit-Position: refs/heads/master@{#708034}

Revert "Reland "Add field trial testing config for BoostThreadPriorityOnLibraryLoadingAndBackgroundMode.""

This reverts commit d97ee8ce.

Reason for revert: Still has the same failure mode.

Bug: 1014659

Original change's description:
> Reland "Add field trial testing config for BoostThreadPriorityOnLibraryLoadingAndBackgroundMode."
> 
> This is a reland of 9d6a01ba
> We now handle negative values returned from ::GetThreadPriority().
> https://chromium-review.googlesource.com/c/chromium/src/+/1829570
> 
> Original change's description:
> > Add field trial testing config for BoostThreadPriorityOnLibraryLoadingAndBackgroundMode.
> >
> > This experiment enables:
> > - Use THREAD_MODE_BACKGROUND_BEGIN/END to set the priority of
> >   background threads. This affects memory and IO priority in addition
> >   to CPU priority.
> > - Increase thread priority to "normal" in scopes where background
> >   threads load modules.
> >
> > The expectation is that this will improve responsiveness of Chrome
> > (input delay, first contentful paint), without regressing jank.
> >
> > We are adding the testing config in preparation for enabling this
> > via Finch in M79.
> >
> > Bug: 973868
> > Change-Id: I467cae12503e3ad724b665f3aebdaeb94e1325c9
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835023
> > Commit-Queue: Robert Kaplow <rkaplow@chromium.org>
> > Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
> > Auto-Submit: François Doray <fdoray@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#705960}
> 
> TBR=rkaplow@chromium.org
> 
> Bug: 973868
> Change-Id: I392cfb2f92e2ac0fa888fa1e323557ab35055b48
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872312
> Reviewed-by: François Doray <fdoray@chromium.org>
> Commit-Queue: François Doray <fdoray@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#707822}

TBR=fdoray@chromium.org,rkaplow@chromium.org

Change-Id: I814a086aea8caacacd09d4fb507c433b5fe7ebdc
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 973868
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872017Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Cr-Commit-Position: refs/heads/master@{#708033}

https://skia.googlesource.com/skia.git/+log/4036a6d8ac64..94e1a5268692

git log 4036a6d8ac64..94e1a5268692 --date=short --no-merges --format='%ad %ae %s'
2019-10-21 fmalita@chromium.org [skottie] fix clangtidy warning
2019-10-21 kjlubick@google.com [fuzzing] Add two fuzzers for SkDescriptor

Created with:
  gclient setdep -r src/third_party/skia@94e1a5268692

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC michaelludwig@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=michaelludwig@google.com

Bug: None
Change-Id: I8457f3d1dcaf3fdad7c76d0ea32297b57a7ad331
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872894Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#708032}

```yaml
IN CASE OF PROBLEMS: If this CL causes your site/app to break, you are
using deprecated features that have now been removed. Please see [2] to
enroll in the Deprecation Extension program to give yourself more time.
```

With this CL, two of the three Web Components v0 APIs are disabled by
default. The third, HTML Imports, will be disabled (soon) by a separate CL.

These features were deprecated in August, 2018, in [1]. The original
removal timeline called for a deadline of M73. Due to high use counters
for the features, this deadline was extended to M80, which is now here.
For those sites that need additional time, there is a "deprecation
extension" (sometimes called a "reverse origin trial") that can be used
to extend this removal for specific sites through M87. For more
information on that, see [2]. For overall context on this removal,
including motivation and ways to test/upgrade, see [3].

With this CL, these features will still be enabled for testing across
all test suites. Once this CL has had a chance to land and stabilize,
subsequent CLs will disable the features for all tests by default, and
enable a virtual test suite to continue testing specific code with WCv0
features enabled, to ensure the features continue to function through
the end of the deprecation extension period.

[1] https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/h-JwMiPUnuU/sl79aLoLBQAJ
[2] https://developers.chrome.com/origintrials/#/view_trial/2431943798780067841
[3] https://developers.google.com/web/updates/2019/07/web-components-time-to-upgrade

Bug: 911943
Change-Id: I939e1ead03a3196e63f0f9c192f916c87ab16562
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1850795Reviewed-by: Caleb Rouleau <crouleau@chromium.org>
Reviewed-by: Darin Fisher <darin@chromium.org>
Commit-Queue: Mason Freed <masonfreed@chromium.org>
Cr-Commit-Position: refs/heads/master@{#708031}

Input predictor's GeneratePrediction used to return a boolean for
whether the prediction exist and also a InputData class contains the
prediction results. This is unnecessary.
This CL makes:
1. GeneratePrediction returns a unique_ptr of InputData class. If
prediction exist, it's the predict result; otherwise, it's nullptr.
2. No need to check HasPrediction before GeneratePrediction.
It should be decided by predictor itself and returns result or nullptr
accordingly.

Change-Id: Id5e092dc98f4c0fa4e66ac709e05fbf7cae8c734
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849173
Commit-Queue: Ella Ge <eirage@chromium.org>
Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#708030}

The method is not used outside the chrome.browser.tab package.
Did a little refactoring in tests to make it private-package.

Bug: 995903
Change-Id: I65dcd3d5c0f5e773f5b0f49135f3c6a7ea19c533
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1870155
Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org>
Reviewed-by: Theresa  <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#708029}

This CL changes SharedRemote so that its sync calls now block only the
calling sequence rather than additionally blocking the underlying
Remote's bound sequence.

Fixed: 1016022
Change-Id: I2483c130d882de24686c0bb1396a894171a733fd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1871249
Commit-Queue: Ken Rockot <rockot@google.com>
Reviewed-by: Darin Fisher <darin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#708028}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/56dc7021..dd844944

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: Id4caac49de42d2f7290a7bd167d5c3fd8c72f5aa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1871896Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#708027}

Bug: 1013795
Change-Id: I1a0db4a62fee2ba9c014daa6780c4e118da1d3b1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857638Reviewed-by: Dan H <harringtond@chromium.org>
Commit-Queue: Jonathan Freed <freedjm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#708026}

This makes it better match its semantic counterparts.
CurrentValuesFromKeyPoints(...) is adjusted in a similar since it is
called by the function in $subject.

Also fix coding-style in SVGAnimationElement::UpdateAnimation().

Bug: 998526
Change-Id: Ib232c0dd7dacd29fe74a9b696a4715d1f9ef2f6e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869002
Commit-Queue: Fredrik Söderquist <fs@opera.com>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#708025}

Before this CL, when switching tab models, the GTS is populated even
if it is not visible. This led to loading the thumbnails
unnecessarily.

Bug: 1014792
Change-Id: Iecff9173e6e4a3ebae80961e067762c000c3caf7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869124
Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Reviewed-by: Mei Liang <meiliang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#708024}

This adds code to parse the maxCredentialCountInList and
maxCredentialIdLength fields from authenticatorGetInfo responses.

GetAssertionTask is changed to filter and batch allow lists when
silently probing credentials according to these values, if the
authenticator supports it. In particular, probing is skipped if the
allow list fits into a single batch (and the request doesn't have an App
ID that the GetAssertionTask might have to fall back to).

MakeCredentialTask similarly filters and batches before silently probing
for credentials in the exclude list parameter. Probing is skipped
entirely, if the exclude list fits into a single batch and the request
does not carry an appIdExclude extension.

Fixed: 954613
Change-Id: I644e602054e4e2ebb4101b98b867f5dbc61e0901
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1867448
Commit-Queue: Martin Kreichgauer <martinkr@google.com>
Reviewed-by: Adam Langley <agl@chromium.org>
Cr-Commit-Position: refs/heads/master@{#708023}