- 30 Jun, 2020 40 commits
-
-
Xida Chen authored
This CL converts base::Callback to base::RepeatingCallback. This is a code health CL, no behavior change. Bug: 1007635 Change-Id: I21172626d70e18e26df5d8d79b453884e30abd66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2275482 Commit-Queue: Xida Chen <xidachen@chromium.org> Commit-Queue: Christian Dullweber <dullweber@chromium.org> Auto-Submit: Xida Chen <xidachen@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#783932}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/739cfb2f5857..4b5792cc4a19 2020-06-30 sprang@webrtc.org Reland "Reland "Removes lock release in PacedSender callback."" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Idca19226215d2be4b6a57c425f13851d85d7fc37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276008Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#783931}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/4523e5e9206c..a72bd10ae637 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC drott@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1100812 Tbr: drott@google.com Change-Id: I0f3b3a7faed2e2382f921452c18d54f743bdf72e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276004Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#783930}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/dca47063ccd2..90f1d6ab5865 2020-06-30 johnkslang@users.noreply.github.com Merge pull request #2296 from ben-clayton/err-unresolved If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,ianelliott@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Tbr: radial-bots+chrome-roll@google.com,ianelliott@google.com Change-Id: Ia6fe76ff2212ebcab94e013f67c64f99325fba57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276005Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#783929}
-
Dominik Röttsches authored
This reverts commit 5563bea3. Reason for revert: Causing bot failures in blink_cors_browser_tests - NearbyConfirmationPageTest.All on linux-blink-cors-rel bot. https://ci.chromium.org/p/chromium/builders/ci/linux-blink-cors-rel/6653 Original change's description: > [Nearby] Add dummy nearby-confirmation-page component > > This component will contain a confirmation screen when sending to > strangers that are not in the local contacts. The component is empty > right now and will be populated in upcoming CLs. > > Bug: 1099710 > Change-Id: I37325d2d75e897a0a9f8be0e6930bf0fd4305f02 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2270323 > Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> > Reviewed-by: Michael van Ouwerkerk <mvanouwerkerk@chromium.org> > Commit-Queue: Richard Knoll <knollr@chromium.org> > Cr-Commit-Position: refs/heads/master@{#783903} TBR=khorimoto@chromium.org,mvanouwerkerk@chromium.org,knollr@chromium.org Change-Id: I28131e1d26e3f4ec6a37eac59525f01a4026165f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1099710 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276045Reviewed-by:
Dominik Röttsches <drott@chromium.org> Commit-Queue: Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#783928}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1593496775-686b801b00e226d40d93326669dcabc4de9f2009.profdata to chrome-mac-master-1593518062-9a8bcf79d9703750826ab2cdd2c19e0799442665.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: Ifd3eeb40a0d9686ae738895b15a5cd902ddb1649 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276009Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#783927}
-
Oriol Brufau authored
Accidentally added in r779284, it has no definition and it's not used. Bug: 457718 Change-Id: Iaf8217b8a167e9b59a27d32b047a8fb85fbb9881 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2275875Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Oriol Brufau <obrufau@igalia.com> Cr-Commit-Position: refs/heads/master@{#783926}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: If150488509ca437bb2eeb099a360fd13db0881cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276006Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#783925}
-
Edward Jung authored
Change-Id: I5a53b9f1ddbd1264e44318fdf443a6d9af976c4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2270467 Commit-Queue: Edward Jung (EMEA) <edwardjung@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#783924}
-
Olivier Robin authored
This reverts commit ec4668d3 and implements an alternative fix for crbug.com/1096489 crbug.com/1096489 was caused by a duplicate processing of URLContext pn scene activation. CL 2254599 fixed the bug but removed the wrong processing disabling processing of NSUserActivity. As URLContexts handling is asynchronous and uses startupParameters in the process, chis CL ensures that startupParameters are not handled during this process by 1. removing the URLContexts processing in transitionedToActivationLevel 2. pass applicationActive = false in openTabFromLaunchWithParams Bug: 1096489, 1069748 Change-Id: I625e0c4ca46f77426046ae3c2a32508762da466a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2266476 Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
Nohemi Fernandez <fernandex@chromium.org> Cr-Commit-Position: refs/heads/master@{#783923}
-
Sébastien Marchand authored
This reverts commit 59f71ba9. Reason for revert: It turns out that we can't do this as this is causing UAFs in tests using a BrowserTaskEnvironment and a TestingProfile: - Creating a TestingProfile forces the creation of all the BrowserContextKeyedServiceFactory associated with this profile. These factories are singletons and are leaked at the end of the test. - Destroying the BrowserTaskEnvironment at the end of the test causes the ThreadPool to shutdown. - If a BrowserContextKeyedServiceFactory ends up maintaining a reference to a task runner (like this factory does) then the second test that tries to use it is guaranteed to fail as it'll use a reference to a task runner that has been released. Original change's description: > Enable the SiteDataCacheFacadeFactory in tests > > Change-Id: Idea598dc21a96c4297841db2a733a2721f2d08e5 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261212 > Auto-Submit: Sébastien Marchand <sebmarchand@chromium.org> > Commit-Queue: Chris Hamilton <chrisha@chromium.org> > Reviewed-by: Chris Hamilton <chrisha@chromium.org> > Cr-Commit-Position: refs/heads/master@{#781543} TBR=chrisha@chromium.org,sebmarchand@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: I9972b136a93824fc959d94c9a74122c41cce5123 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274198Reviewed-by:
Sébastien Marchand <sebmarchand@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Auto-Submit: Sébastien Marchand <sebmarchand@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#783922}
-
Xi Han authored
When overview mode is hiding, the ExploreSurfaceViewBinder#setVisibility(false) is called to hide the FeedSurfaceView. However, removing it from its parent view makes the URL bar get focused. To fix it, we set the visibility of the Secondary TasksSurface before updating the visibility of the ExploreSurface. This bug only happens when single tab is shown on the StartSurface. A new test is added to prevent regression in the future. Bug: 1087905 Change-Id: If4d889e0842ee836e78f85debd74c99295025887 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2242647 Commit-Queue: Xi Han (OOO till July 6) <hanxi@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#783921}
-
Jan Krcal authored
This CL adds comments that explain why each of the priority user data types needs to be a priority type. Bug: 1084969 Change-Id: Idcce308be557bbfa961705dad072ef3f85a99131 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274599 Commit-Queue: Jan Krcal <jkrcal@chromium.org> Auto-Submit: Jan Krcal <jkrcal@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#783920}
-
Colin Blundell authored
This class will be reused in WebLayer's infobars implementation. Banners conceptually fit well within the purpose of //components/browser_ui, and so we move it there. Bug: 1099169 Change-Id: I441d8e1ef310be47bca1bda8ac6c015bd96ca172 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274503Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#783919}
-
Fredrik Söderqvist authored
* Drop custom computed style setters that are equivalent to what would be generated by default. * Make custom computed style getters return const StyleColor& (hopefully avoiding some redundant copying in the future when the type gets more complex). Note that while these custom getters are also equivalent to those generated by default, they are specified as custom to be able to make access to them private. For this reason, text-decoration-color is given a custom getter. * Drop 'style_builder_template_args' where 'initial_color' is StyleColor::CurrentColor() since that's the default. Bug: 1081945 Change-Id: I763b425d5c2336d375811542faa65cbc4a2d299e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2273279Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#783918}
-
Anastasiia Nikolaienko authored
Add Polymer component with error screen template for account addition flows. Usage: crrev.com/c/2259913 Mocks: https://screenshot.googleplex.com/W0QzJVTjMSg Bug: 1097030 Change-Id: I349079b0cbc2bd8ef692b1c71eccaa165a437446 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2260034Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Kush Sinha <sinhak@chromium.org> Commit-Queue: Anastasiia N <anastasiian@chromium.org> Cr-Commit-Position: refs/heads/master@{#783917}
-
wanghui authored
Pack the ffmpeg.dll into chrome.7z when "is_component_ffmpeg" is true. Bug:1100242 Change-Id: I9e82739b9edf38c75238f08bb0c0b160a600d926 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2269408Reviewed-by:
Greg Thompson <grt@chromium.org> Commit-Queue: Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#783916}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/e7d0d2dc3145..54c234edfb33 2020-06-30 jacktfranklin@chromium.org Fix formatting conflict with async test 2020-06-30 wolfi@chromium.org (e2e test) Port console last result test If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1099603 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I1cb4bbcb505262a03cffc5db3ede64f8c1d949ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276003Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#783915}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/722e769803e8..739cfb2f5857 2020-06-30 landrey@webrtc.org Add sync group validation in pc level test framework If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I6089357fee71dab3fbbaa8f1b7f56c45093745ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276002Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#783914}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/c047dd609ca7..3e560e727fb8 2020-06-30 fmayer@google.com Merge "Add __future__ to more python files." If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I9c2000b83d4625dae1834b6aff71dbb67bfb3854 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276000Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#783913}
-
Antonio Gomes authored
... instead of WebMediaStreamTrack. This is part of the effort to move as much public headers out of the Blink platform topmost public directory (//third_party/blink/public/platform/). BUG=704136 R=guidou@chromium.org Change-Id: I78ecf75cfe602de5b11962ece2a05d11d90f088d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2273677Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#783912}
-
Viktor Semeniuk authored
check This change allows IOSChromePasswordCheckManager to exist independently from UI when password check is running. If check is finished and no UI holds a pointer to it, the object will be destroyed. Also a factory to create IOSChromePasswordCheckManager was added. This factory holds only weak pointer to the manager. Bug: 1075494 Change-Id: Ib617b03c8ca4cec70924caa7c7e9a17deb090fbf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2263814Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Viktor Semeniuk <vsemeniuk@google.com> Cr-Commit-Position: refs/heads/master@{#783911}
-
Antonio Gomes authored
... to CreateMediaStreamComponent() now that its body operates in MediaStreamComponent. BUG=704036 R=guidou@chromium.org Change-Id: Ibd3b66f1d18d5500bec8903588d02664e47f7d10 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2273458Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#783910}
-
Antonio Gomes authored
... instead of WebMediaStreamTrack. Additionally, the CL also changes the class to operate over MediaStreamDescriptor, instead of WebMediaStream. BUG=704136 R=guidou@chromium.org, haraken@chromium.org Change-Id: I2aee2cd4005fd42df5c103fea550c038bf405e39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2273477Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#783909}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/774cd1b212a4..98a51fde05e8 2020-06-30 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SPIRV-Tools from 91c50e3fc993 to fc0dc3a9c734 (1 revision) 2020-06-30 xinghua.cao@intel.com Restrict member types for StructuredBuffer 2020-06-30 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-Tools from ff825d988fe8 to abc9dff824c3 (1 revision) 2020-06-30 angle-autoroll@skia-public.iam.gserviceaccount.com Roll glslang from 27e915ed4f20 to dca47063ccd2 (2 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ianelliott@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: ianelliott@google.com Change-Id: I49a2e885ae083c6e23055ef3a84f350f9d85e660 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2275998Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#783908}
-
Maksim Ivanov authored
s/LoginAsNewReguarUser/LoginAsNewRegularUser/ Bug: none Change-Id: I781ed2bc327c171139068092fdc716019a697c34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2275874Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#783907}
-
arthursonzogni authored
In the function: ShouldSwapBrowsingInstanceForCrossOriginOpenerPolicy(...) Rename the parameter: is_initiator_aboutblank into: is_initial_navigation The previous name was misleading. What we want to represent is whether this navigation is from the initial empty document or not. It doesn't really depend on the URL of the initiator. Note: There are some issues with callers of this function as well, is_initial_navigation is currently set to: !current_rfh->has_committed_any_navigation(). This gives the expected boolean most of time, except when: 1) The |current_rfh| is not the empty document and is crashed. 2) The |current_rfh| is the new RenderFrameHost, that committed before the navigation, due to an optimization after crash. Those 2 issues will be handled in followups. Bug: chromium:1076879 Change-Id: I1512aa91a3b46bdde25b36587ab9ae4f4941fa46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2273139 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Arthur Hemery <ahemery@chromium.org> Reviewed-by:
Pâris Meuleman <pmeuleman@chromium.org> Cr-Commit-Position: refs/heads/master@{#783906}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/14ac9d015283..4523e5e9206c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC drott@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: drott@google.com Change-Id: I5b230cabfa3298a2bf297c32555ab42b7c521915 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2275995Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#783905}
-
Olya Kalitova authored
Propagate PluginVmDataCollectionAllowed policy value in PluginVmServiceProvider GetPermissions call response. Test: no tests Bug: b/150908305 Change-Id: I67948de7ba7a3b303973ba683e7ad9f2e62c63fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2167396Reviewed-by:
Timothy Loh <timloh@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Olya Kalitova <okalitova@chromium.org> Cr-Commit-Position: refs/heads/master@{#783904}
-
Richard Knoll authored
This component will contain a confirmation screen when sending to strangers that are not in the local contacts. The component is empty right now and will be populated in upcoming CLs. Bug: 1099710 Change-Id: I37325d2d75e897a0a9f8be0e6930bf0fd4305f02 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2270323Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Commit-Queue: Richard Knoll <knollr@chromium.org> Cr-Commit-Position: refs/heads/master@{#783903}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/80e508e0d096..e7d0d2dc3145 2020-06-30 mathias@chromium.org Support emulating `prefers-reduced-data: reduce` If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1096068 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ib0dddf698f03f7dfea25b6d4dbe1777a39ec41e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2275997Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#783902}
-
Francois Beaufort authored
This CL adds metrics for how many users have cameras with PTZ capabilities. This metric is triggered only when a permission prompt would show up. Bug: 990185 Change-Id: Icba513c14977ef1249ed68788fc91d5059b1c0c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2273237 Commit-Queue: François Beaufort <beaufort.francois@gmail.com> Reviewed-by:
Alex Ilin <alexilin@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#783901}
-
Vasilii Sukhanov authored
cancelled. They are queued on another thread and consume significant resources. Fixed: 1098776 Change-Id: I1cdf3ecfec020bb05fa41d809f23fa62a2d3850c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2273219 Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#783900}
-
Mihai Sardarescu authored
This CL updates the tests in GaiaAuthFetcherIOSNSURLSessionBridgeTest suite to wait for the the NSURLDataTask to be resumed before continuing. Bug: 1065349 Change-Id: I347069235fd86c51454cf705f733b5219e69151b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2273058 Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#783899}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/b231c7fb717d..bae16b4df9d7 2020-06-30 cwallez@chromium.org dawn_wire/client: Encapsulate all buffer-related logic in Buffer.cpp If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: Ida77df142779c62a57c50061c838484e106b90d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2275994Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#783898}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/7a1af5878594..fc0dc3a9c734 2020-06-29 jaebaek@google.com Fix ADCE pass bug for mulitple entries (#3470) 2020-06-26 ehsannas@gmail.com Add gl_BaseInstance to the name mapper. (#3462) 2020-06-26 andreperezmaselco.developer@gmail.com Implement the OpMatrixTimesScalar linear algebra case (#3450) 2020-06-25 jaebaek@google.com Clear debug information for kill and replacement (#3459) 2020-06-25 alanbaker@google.com Validate location assignments (#3308) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,ianelliott@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Tbr: radial-bots+chrome-roll@google.com,ianelliott@google.com Change-Id: I95d1d1626c22597d85b28344a0ecd17fd78c621c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2275638Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#783897}
-
Xida Chen authored
With this CL landed: https://chromium-review.googlesource.com/c/chromium/src/+/2244002 The fps meter now have a completely new look, and it is actually showing the throughput of the page. This CL changes the name of "FPS meter" to "Frame Rendering Stats". Its description is also updated. The corresponding devtool front end changes is here https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2269939 Bug: None Change-Id: I22cc52abd37e12bb80db99daec339d467d4595f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2268398 Commit-Queue: Xida Chen <xidachen@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#783896}
-
Wei Lee authored
Such errors will cause failure of camera.CCAUIIntent. Bug: 1069137 Test: tast run [DUT] camera.CCAUIIntent Change-Id: Ie94df6c7e43e495525623bf29015cba2a477ebd4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264082 Commit-Queue: Wei Lee <wtlee@chromium.org> Reviewed-by:
Kuo Jen Wei <inker@chromium.org> Auto-Submit: Wei Lee <wtlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#783895}
-
Colin Blundell authored
This CL eliminates //weblayer's copy of chrome's InfoBarWrapper.java in favor of directly using the latter now that it has been componentized. There were no substantive changes introduced in //weblayer and no behavioral changes. Bug: 1099169 Change-Id: Ie9cc819f17ce30bb66085cb05040ce11696725ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2270554 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#783894}
-
Fergus Dall authored
These new classes are recorded by cicerone, but they still need to be recorded in enums.xml to give them names. Also update the enum in crostini_stability_monitor.h to keep things in sync. Bug: 977201 Change-Id: Ia7d1349fdaf8f2790f9896933d45dbc3ef5918be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2272620Reviewed-by:
Nicholas Verne <nverne@chromium.org> Commit-Queue: Fergus Dall <sidereal@google.com> Cr-Commit-Position: refs/heads/master@{#783893}
-