- 05 Dec, 2019 10 commits
-
-
Dave Tapuska authored
Simply move the SetFocusedFrame APIs into blink's LocalFrame/RemoteFrame implementations. BUG=1008432 Change-Id: If8e29ef03253af352ba9a98236f379135c331725 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1927212Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#721753}
-
George Steel authored
Goes with spec CL https://github.com/w3c/csswg-drafts/pull/4437 (merged) Follows up on https://crrev.com/c/1894477 Change-Id: I9f50739cb4dac68d3c9002c0f3ed509f6b379380 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949405Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Reviewed-by:
Kevin Ellis <kevers@chromium.org> Commit-Queue: George Steel <gtsteel@chromium.org> Cr-Commit-Position: refs/heads/master@{#721752}
-
Kazuki Takise authored
In tablet mode, the app list is expected to remain visible when the cycler is shown, so it shouldn't be dismissed. BUG: 1024494 TEST: Home screen isn't blank after using alt-tab in tablet mode Change-Id: Iade57ac11528d11501e8b319f2d5dbdbc6716b6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1927791Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Reviewed-by:
Stefan Kuhne <skuhne@chromium.org> Commit-Queue: Kazuki Takise <takise@chromium.org> Auto-Submit: Kazuki Takise <takise@chromium.org> Cr-Commit-Position: refs/heads/master@{#721751}
-
Yue Zhang authored
This CL adds e2e test to verify behavior of adaptive toolbar in grid tab switcher. Situations that are tested are: * Portrait and landscape +GTS +Duet * Portrait and landscape +GTS -Duet * Portrait and landscape -GTS +Duet Bug: 1012014 Change-Id: Ib82f38a60f8f8649d6961a59463e743dbbe0d7b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1938464 Commit-Queue: Yue Zhang <yuezhanggg@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#721750}
-
Tom Anderson authored
The Debug*Api family does exclusively logging, and does not add any DCHECK()s etc, so s/Debug/Log/g to make this more clear. R=kbr TBR=rjkroege BUG=None Change-Id: I0b31609880c2ce0b9266cc7263ae8edf1510fcc8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1951724Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#721749}
-
Balazs Engedy authored
ContextualNotificationPermissionUiSelector determines if the quiet prompt UI should be used to display a notification permission request on a given site. This is the case when: 1) the quiet UI is enabled in prefs for all sites, either directly by the user in settings, or by the AdaptiveQuietNotificationPermissionUiEnabler. 2) the quiet UI is triggered by crowd deny, either through: a) CrowdDenyPreloadData, that is, the component updater, or b) CrowdDenySafeBrowsingRequest, that is, on-demand Safe Browsing pings. The ContextualNotificationPermissionUiSelector is also wired up to the PermissionRequestManager instead NotificationPermissionUiSelectorBasedOnPrefs. Bug: 1028642 Change-Id: Ibb44ec1e0f0fe95d4fb350e9c2211199719df103 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1944395 Commit-Queue: Balazs Engedy <engedy@chromium.org> Reviewed-by:
Andy Paicu <andypaicu@chromium.org> Cr-Commit-Position: refs/heads/master@{#721748}
-
Clark DuVall authored
This adds minimal initialization needed for CrashReporterController, as well as delaying the call to processNewMinidumps() until after native initialization has happened. Also cleans up the creation of CrashReporterController to use AIDL instead of reflection. Bug: 1027076 Change-Id: Ib1969c82eb93b88965de8ee793fa3d6eb46c7bf0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1951551 Commit-Queue: Clark DuVall <cduvall@chromium.org> Reviewed-by:
Tobias Sargeant <tobiasjs@chromium.org> Cr-Commit-Position: refs/heads/master@{#721747}
-
Ken Rockot authored
This changes makes it possible for one ConnectionGroup to retain a reference to another "parent" group. The result allows multiple endpoints within a group to set their own idle handler without becoming detached from the original group: if an an idle handler is set on an endpoint which already belongs to a group, a new group is created with the original group as its parent and the endpoint references the new group instead. Thus this interface and any interfaces bound transitively through it will now reference the new group, but the new group will in turn keep the original group alive as if all those interface endpoints were referencing it directly. This change is useful to support the migration of the Audio Service off of Service Manager, as its client library currently uses an idle handler on an interface which will already belong to the main service interface's connection group under the new service model. Bug: 977637 Change-Id: I43443ca96a260c9860785eb30450896a95d7ffe2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940654 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#721746}
-
Mitsuru Oshima authored
Bug: b/141898654 Test: updated the test to catch this type of regression Change-Id: Icee3d5aeb825748333bbe7094f10124d0e61f59f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1951152 Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Malay Keshav <malaykeshav@chromium.org> Cr-Commit-Position: refs/heads/master@{#721745}
-
Connie Wan authored
This reverts commit a8ebb5e6. Reason for revert: <INSERT REASONING HERE> Original change's description: > Implement TabGroupHighlight > > See attached bug for screencast. Confirmed with UX that the highlight should only appear on drag, not hover. > > Bug: 1017822 > Change-Id: I0921f5cf425d82c25344adb4801de6de8746f771 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929490 > Reviewed-by: Taylor Bergquist <tbergquist@chromium.org> > Commit-Queue: Connie Wan <connily@chromium.org> > Cr-Commit-Position: refs/heads/master@{#721705} TBR=tbergquist@chromium.org,cyan@chromium.org,connily@chromium.org Change-Id: Ifd307f56a9c7db57e928a310f60f1a01e770a800 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1017822 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1951556Reviewed-by:
Connie Wan <connily@chromium.org> Commit-Queue: Connie Wan <connily@chromium.org> Cr-Commit-Position: refs/heads/master@{#721744}
-
- 04 Dec, 2019 30 commits
-
-
Evan Stade authored
Bug: none Change-Id: Id308c2dd2b429542e5b79fd58b4643a8c23b0a75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1951804 Auto-Submit: Evan Stade <estade@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#721743}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/77e5e0540b54..d90f59573de9 git log 77e5e0540b54..d90f59573de9 --date=short --first-parent --format='%ad %ae %s' 2019-12-04 hjd@google.com Merge "perfetto-cmd: Pass IsUser as arg" 2019-12-04 hjd@google.com Merge "Revert "Reland: Add statsd logging to perfetto_cmd"" Created with: gclient setdep -r src/third_party/perfetto@d90f59573de9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: I836602d24ad6cda88ea23a5d6cd04f3eed07963d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1951407Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#721742}
-
Mike Wittman authored
Implements browser tests to verify that startup profiles taken in the browser and child processes are received by the metrics provider. To work within the test timeouts and to avoid non-determinism this requires a couple adaptations to be made to the code when run under these tests. The profiling period is reduced from 30 seconds to one second, and profiles are taken in all renderer processes. The behavior is enabled by providing a 'browser-test' argument to the existing 'start-stack-profiler' switch. The main thread profiler for browser tests is moved later, after the command line is set up, to be able to observe the added switch argument. StackSamplingConfiguration is made responsible for the sampling parameters, reusing the GetSamplingParamsForCurrentProcess() function which was previously unused. This reland of https://crrev.com/716372 gates the tests on channel since the profiler is enabled only on trunk, canary, and dev, but the official continuous builders build as stable channel. Bug: 1011877, 1026575 Change-Id: I1cce130ff035007a2935dfccb2f7e2dca56880ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1938077 Commit-Queue: Mike Wittman <wittman@chromium.org> Reviewed-by:
Etienne Pierre-Doray <etiennep@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Auto-Submit: Mike Wittman <wittman@chromium.org> Cr-Commit-Position: refs/heads/master@{#721741}
-
Tom Anderson authored
This change makes the trace strings consistent with the class name. Previously, trace names would always show as TraceGLAPI, even for the other implementations like EGL, GLX, and WGL. R=kbr BUG=none Change-Id: Id4708c0b10c300d5c8da007ef693927a46da7fa7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1951548 Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Auto-Submit: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#721740}
-
shrekshao authored
https://pinpoint-dot-chromeperf.appspot.com/job/13f52f23220000 shows -1.8% improvement for thread_total_rendering_cpu_time_per_frame. (Though another perf try job shows only -0.4%, guess the improvment is not big enough compared to noise) Anyway theoretically this patch should bring improvement by moving branching ahead to compile time. Wrote a small c++ program. Compile with clang and it is verified by objdump that the template non-type variable with if style result with no if test assembly code generated, without use of "if constexpr" statement. Bug: 1026774 Change-Id: I21f36924aca06f9f0a286be06e268cb8a3f4e03a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949679Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Shrek Shao <shrekshao@google.com> Cr-Commit-Position: refs/heads/master@{#721739}
-
Aga Wronska authored
Adds WebTimeLimitsInterface to start and stop web time limits UI for Chrome and PWAs. It will be called by AppService. Implements the new interface in ChildUserService. Additional maintenance: * Move some classes into app_time namespace. * Create test API to expose internal details of ChildUserService. Bug: 1015661 Test: PerAppTimeLimitsTest Change-Id: I33c9f2fca3dcc5fb4364f086e9b606c642dba6d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947543Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Aga Wronska <agawronska@chromium.org> Cr-Commit-Position: refs/heads/master@{#721738}
-
Ilia Samsonov authored
googletest will no longer support empty prefix for parameterized INSTANTIATE_TEST_SUITE_P. Adding "All" prefix to existing empty prefix test suites. This CL was uploaded by git cl split. R=mohsen@chromium.org Bug: 1023677 Change-Id: Ibc5d9625d2e2c08177b4fed8e03fe06370910ff7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1925463 Auto-Submit: Ilia Samsonov <isamsonov@google.com> Reviewed-by:
Peter Boström <pbos@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#721737}
-
Lei Zhang authored
In base::File, |file_| is a ScopedPlatformFile. So add constructors that can take a ScopedPlatformFile directly, instead of having the caller release the PlatformFile, and then rewrapping it. Change-Id: Ie70cacc0a47263ff9ec5ce38f84032f1e469faa3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948195Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Joe Downing <joedow@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#721736}
-
Ilia Samsonov authored
googletest will no longer support empty prefix for parameterized INSTANTIATE_TEST_SUITE_P. Adding "All" prefix to existing empty prefix test suites. This CL was uploaded by git cl split. R=loonybear@chromium.org Bug: 1023677 Change-Id: I61b6638bcefb958cab0079adfc40c1378321e4a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1927058 Auto-Submit: Ilia Samsonov <isamsonov@google.com> Reviewed-by:
Raymes Khoury <raymes@chromium.org> Commit-Queue: Ilia Samsonov <isamsonov@google.com> Cr-Commit-Position: refs/heads/master@{#721735}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 457ad5ab. With Chromium commits locally applied on WPT: 500a74f5 "Add a runtime flag to enforce strict MIME type checks for workers." a2a91a99 "Allow another touch start happen when there are active touch points" 85b61e6b "[resource-timing] Ensure workerStart is protected by TAO" a75430aa "Fix appcache tests." a50e7e60 "Move `Sec-Fetch-User` to SetSecFetchMetadataHeaders." 83e4a43b "Refactor VRPose to fit better with WebXr concepts" a93be69b "Update reversing-an-animation test" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=raphael.kubo.da.costa No-Export: true Change-Id: I78951794b58a7cb400743e107a6f78b08a828a9a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1950889Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#721734}
-
Ilia Samsonov authored
googletest will no longer support empty prefix for parameterized INSTANTIATE_TEST_SUITE_P. Adding "All" prefix to existing empty prefix test suites. This CL was uploaded by git cl split. R=thakis@chromium.org Bug: 1023677 Change-Id: I754c80d5f281438539432343841ff3a251b90283 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1926922 Auto-Submit: Ilia Samsonov <isamsonov@google.com> Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#721733}
-
Fan Yang authored
https://quiche.googlesource.com/quiche.git/+log/f54082a0145f..d58736db7b79 $ git log f54082a01..e62e63cbd --date=short --no-merges --format='%ad %ae %s' 2019-11-27 fayang gfe-relnote: Use HandshakerDelegateInterface in QUIC handshakers. Abstract keys installation, keys discarding, default encryption level change and mark handshake complete to HandshakerDelegateInterface. Protected by gfe2_reloadable_flag_quic_use_handshaker_delegate. 2019-11-27 bnc Enforce header list size limit in QpackDecodedHeadersAccumulator. 2019-11-27 bnc Rename qpack_constants.* to qpack_instructions.*. 2019-11-27 renjietang Switch the order of QPACK streams sending stream type. Created with: roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src Change-Id: I9b46c079f94def86e82d0abc19b556ab63771b60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949151 Commit-Queue: Fan Yang <fayang@chromium.org> Commit-Queue: Nick Harper <nharper@chromium.org> Reviewed-by:
Steve Anton <steveanton@chromium.org> Reviewed-by:
Nick Harper <nharper@chromium.org> Cr-Commit-Position: refs/heads/master@{#721732}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/75a7e95c6f5c..460dca5483db Created with: gclient setdep -r src-internal@460dca5483db If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1029105,chromium:915409,chromium:966792 Tbr: jbudorick@google.com Change-Id: I38909a96b0895d77694bdf49e0f7956809a42aea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1951766Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#721731}
-
Toni Barzic authored
Adds 16 dip margin between page switcher and the app list view right edge - this effectively changes the minimal apps grid margin from the app list view edge to 56 dip (8 dip margin between apps grid and page switcher, 32 dip page switcher width, 16 dip between page switcher and app list view edge). Updates the the threshold at which the app list contents margin changes between 1/16 of the screen width and 1/12 of the screen width from 600 dip to 896 dip (which is the width at which the minimal apps grid horizontal margin would not fit into 1/16 of the screen width). Moves the margin calculation code to app list config, so it can be reused between apps container view (to calculate the apps container layout) and contents view (to calculate search box width). Along the way fix search box width calculation to respect the minimal search box width of 440 dip. BUG=1028332 Change-Id: I5ebb105775fc24a1e94c10011e7dc9f968e0ddeb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1941197 Commit-Queue: Toni Baržić <tbarzic@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#721730}
-
Ken Rockot authored
This sticks a Content Service instance directly in each BrowserContext rather than having them owned indirectly by BrowserContext via Service Manager APIs. The two existing uses are refactored to get NavigableContentsFactory receivers bound directly through the BrowserContext rather than using a Service Manager Connector. Bug: 977637 Change-Id: I4a3e41235e15a8b93973f152e8313d8612bfc290 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931444 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#721729}
-
Brandon Wylie authored
This is a reland of a59a4ff3 Original change's description: > Visually scale down the size of the Google G logo in the omnibox > > Bug: 1020774 > Change-Id: I48b32fdfbcf4dc2a20ba047ee3f93783f4fa2a38 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918047 > Commit-Queue: Brandon Wylie <wylieb@chromium.org> > Reviewed-by: Theresa <twellington@chromium.org> > Cr-Commit-Position: refs/heads/master@{#718931} Bug: 1020774 Change-Id: I27aa92db055e39570f8ba0099d5c54bf22236194 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946849Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Ender <ender@google.com> Commit-Queue: Brandon Wylie <wylieb@chromium.org> Cr-Commit-Position: refs/heads/master@{#721728}
-
Caroline Rising authored
Fix bug where the wrong color is shown for tab hover cards after switching between system light/dark modes. The fade label child views are set to be ignored by tab hover card layout. This means the background color is not updated for these labels after creation. This change update the color before an animation would take place. Bug: 1030328 Change-Id: I8204978fc8983f4ff4b3cc02922a0401cf039244 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1951090 Commit-Queue: Caroline Rising <corising@google.com> Reviewed-by:
Dana Fried <dfried@chromium.org> Cr-Commit-Position: refs/heads/master@{#721727}
-
Ken Rockot authored
Child processes send a message to BrowserChildProcessHostImpl to have the host register Resource Coordinator client pipes on their behalf. The implementation of this message accesses the corresponding ChildProcessLauncher's PID indiscriminately. Meanwhile the process may have died by the time the message is actually dispatched, and it's invalid to access that PID after process termination. While this race doesn't seem to affect security or stability of production code in practice, it does cause browser tests to hit a DCHECK on PID access, causing fairly common flake. This fixes the race by ensuring the Process is still valid before attempting to grab its PID. Fixed: 1029627 Change-Id: I3f8eb6e9f6cd5c94c4011b76446e7fce63c0d12c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1944618Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#721726}
-
John Z Wu authored
This will be used in CWVAutofillController to handle forms found in the page. Bug: 1030451 Change-Id: I2224e8ed65074bf0c4658db5a3e5016c3d13d36a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949299 Commit-Queue: John Wu <jzw@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#721725}
-
Sean Kau authored
BrowserNonClientFrameViewTabbedTest.HitTestsTabStrip was disabled due to flakiness caused by a class that was not properly cleaned up between tests. This issue has now been resolved and this test is being re-enabled. Still flaky for TSAN. Updated TODO to reflect the TSAN bug. Bug: 1015949 Change-Id: I3ecbc316369742ab40cf5abba7ea8f247dff8d48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1951650 Commit-Queue: Sean Kau <skau@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#721724}
-
Sammie Quon authored
See bug for screencast. The bug was caused because even if a finger is idle, we still get miniscule event location and scroll updates. For example, a log I got had something like: scroll: 0.1875, -0.1875, 0.325, -0.325 etc while my finger was stationary. To prevent this, add up the scrolls and update the grid once they reach a threshold, which i choose 1. Test: manual Change-Id: I206ca709b11c82dd108a6655792279cdf8404163 Fixed: 1030724 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1951964Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#721723}
-
Peter Kotwicz authored
This CL: - merges the WebAPK/CCT browser control visibility logic - merges the WebAPK/CCT close button visibility logic BUG=991079 Change-Id: I6f955a584a6cc33709d00aecb028ea52552b28d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1902483 Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Cr-Commit-Position: refs/heads/master@{#721722}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/google/shaderc/+log/db3c93975a8f..dadf12a4bd9c git log db3c93975a8f..dadf12a4bd9c --date=short --first-parent --format='%ad %ae %s' 2019-12-04 rharrison@google.com Remove unused variable from C++ API (#926) Created with: gclient setdep -r src/third_party/shaderc/src@dadf12a4bd9c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/shaderc-chromium-autoroll Please CC radial-bots+chrome-roll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: radial-bots+chrome-roll@google.com Change-Id: I3fca8800f8c28c00779aa29e269772c334952d8f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1951661Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#721721}
-
Garrett Beaty authored
This is a reland of b46672aa Added branched versions of triggered builders that aren't present in the mirror configuration for the waterfall try builders. Original change's description: > Add branched versions of Phase B CI builders. > > All branch CI builders have been moved to be scheduled once per day. As > we get capacity and get the builds into a good state, we will move them > to be continuously triggered. > > Bug: 1024641, 922150 > Change-Id: Ie066240907dd581175c94cbca431e5a6bf37deb3 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948050 > Reviewed-by: Aaron Gable <agable@chromium.org> > Commit-Queue: Aaron Gable <agable@chromium.org> > Auto-Submit: Garrett Beaty <gbeaty@chromium.org> > Cr-Commit-Position: refs/heads/master@{#721218} Bug: 1024641, 922150 Change-Id: I93f158401e8a741439c16f069f6936cdb198f03f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1951331Reviewed-by:
Aaron Gable <agable@chromium.org> Commit-Queue: Garrett Beaty <gbeaty@chromium.org> Cr-Commit-Position: refs/heads/master@{#721720}
-
Kevin McNee authored
BrowserPlugin is being removed, so this event resending code is dead. Bug: 533069 Change-Id: Ieb5d2e14671621dcb1d85646f3d12887f8c3d68f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1951332Reviewed-by:
James MacLean <wjmaclean@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Kevin McNee <mcnee@chromium.org> Cr-Commit-Position: refs/heads/master@{#721719}
-
Carlos Caballero authored
MessageLoop is going away soon. This CL was uploaded by git cl split. R=maybelle@chromium.org Bug: 891670 Change-Id: I53fe47639f2f146806d52791fc7d34b8fd5d8221 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1944670 Auto-Submit: Carlos Caballero <carlscab@google.com> Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#721718}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/024cbe1befe1..391d4f3130da git log 024cbe1befe1..391d4f3130da --date=short --first-parent --format='%ad %ae %s' 2019-12-04 tsepez@chromium.org Remove #ifdef around right-button methods in fpdf_view_c_api_test.c 2019-12-04 tsepez@chromium.org Expose FORM_OnRButton{Down,Up} to non-XFA builds Created with: gclient setdep -r src/third_party/pdfium@391d4f3130da If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: pdfium-deps-rolls@chromium.org Change-Id: Ia43b81e53d114f53b60cd6bff59b29a24c99fbd1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1951656Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#721717}
-
David Dorwin authored
Bug: 973095 Change-Id: Ic0f0dffdaf16a4a024e08a08ea3daa811d8e192c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935156Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: David Dorwin <ddorwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#721716}
-
Anushruth authored
Some builds take more than 3 hours leading to timeout of almost complete builds. Extend timeout until the builds are faster. R=bpastene@google.com Bug: 1030593 Change-Id: I4c85e14abfe1613e1f6908f175cbfaf1b8e91214 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1951091Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: Anushruth <anushruth@chromium.org> Cr-Commit-Position: refs/heads/master@{#721715}
-
Christopher Cameron authored
It's unlikely that CoreAnimation remains a power win when we get to many layers, because of how we reconstruct the CALayer tree. Further, when we get to ~20k layers, we start seeing corruption. Bug: 1022116, 1024110, 835395 Change-Id: If74cd2b0d80c11dabf050be160d7eee3fb81e274 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1951659Reviewed-by:
Eric Karl <ericrk@chromium.org> Reviewed-by:
ccameron <ccameron@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#721714}
-