GitLab

This reverts commit 66c9faff.

Reason for revert:

Findit (https://goo.gl/kROfz5) identified CL at revision 826750 as the
culprit for flakes in the build cycles as shown on:
https://analysis.chromium.org/p/chromium/flake-portal/analysis/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vNjZjOWZhZmYwYTZjNmFkZDYzNGNhOTIzOTQyNjg4NmFkMzA3NTJiNQw

Sample Failed Build: https://ci.chromium.org/b/8863818632966090416

Sample Failed Step: blink_web_tests on Mac-10.15

Sample Flaky Test: virtual/disable-user-agent-client-hint-feature/external/wpt/client-hints/viewport-width-window.https.html

Original change's description:
> [client-hints] Viewport-Width correct value for navigation requests
> 
> Currently, Viewport-Width hints send the display width for navigation
> requests, rather than the actual viewport width.
> This CL fixes that for iframes and for new windows that have the same
> viewport as their opener.
> 
> Bug: 825892
> Change-Id: Ib01f394325ed3753b9a89dbdbcada1db0d3b029c
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2494876
> Commit-Queue: Yoav Weiss <yoavweiss@chromium.org>
> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org>
> Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
> Reviewed-by: Tarun Bansal <tbansal@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#826750}


Change-Id: I6a36b74e8791409b90fd84a81bb2ef2f29d29eea
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 825892
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2535873
Cr-Commit-Position: refs/heads/master@{#826951}

We found that the test
scrolling/scrollbars/scrollbar-mousedown-move-mouseup.html is flaky when
the scroll unification flag is enabled. Below is the failing reason,
scroll_manager.cc(548) Check failed:
!RuntimeEnabledFeatures::ScrollUnificationEnabled().
blink::ScrollManager::HandleGestureScrollUpdate()
blink::ScrollManager::HandleGestureScrollEvent()
blink::EventHandler::HandleGestureScrollEvent()
blink::WebViewImpl::HandleGestureEvent()
blink::PageWidgetDelegate::HandleInputEvent()
blink::WebViewImpl::HandleInputEvent()

We will disable it for now until we fix this problem for scrollbar.


Bug: 1130020
Change-Id: Icd4b0aede785d35598cd3d7b901b032c2d23c5e8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533476
Commit-Queue: Lan Wei <lanwei@chromium.org>
Reviewed-by: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#826950}

This policy was superseded by DeviceLoginScreenVirtualKeyboardEnabled

BUG=chromium:1096164

Change-Id: I506c114e6cbd2a38d71a7c128eb90f916108376a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485751
Commit-Queue: Chris Sharp <csharp@chromium.org>
Reviewed-by: Amr Aboelkher <amraboelkher@google.com>
Reviewed-by: Amr Aboelkher <amraboelkher@chromium.org>
Reviewed-by: Pavol Marko <pmarko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#826949}

This unit test was incorrectly implemented. Fixed by initializing it and
correctly expecting all relevant mocked function calls.

Bug: 1146778
Change-Id: I005c4154dc2d2e53167aa67f56f92a27314f7b19
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527632Reviewed-by: Rahul Arakeri <arakeri@microsoft.com>
Reviewed-by: Robert Flack <flackr@chromium.org>
Commit-Queue: Sahir Vellani <sahir.vellani@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#826948}

This reverts commit 5d7223a8.

Reason for revert: Introduce issue 1148031.

Original change's description:
> Enable setting request idempotency for Android.
>
> 0-RTT for idempotent request is enabled here:
> https://chromium-review.googlesource.com/c/chromium/src/+/2508299
> Here an idempotency setter is added in java UrlRequest builder to
> enable 0-RTT for idempotent request on Android.
>
> Change-Id: Ia9a366605f178221438d1c161714d3be1061203c
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2511911
> Commit-Queue: Yu Su <yuyansu@google.com>
> Reviewed-by: David Schinazi <dschinazi@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#823434}

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 1148031
Change-Id: I5a7414a903a3733f3f27f70f311abe9e96bcb9d3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532610Reviewed-by: David Schinazi <dschinazi@chromium.org>
Commit-Queue: Yu Su <yuyansu@google.com>
Cr-Commit-Position: refs/heads/master@{#826947}

Firebase is only used to record the `first_open` event, so there
is no need to start it if the event was recorded in a previous
execution of the app.

Add a new value to the metrics used to record the state of the
Firebase initialisation.

Bug: 1148441
Change-Id: I3e2bb50f3d2d4458e53e4dc0464e0e19a5504e55
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2534895
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Auto-Submit: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Justin Cohen <justincohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#826946}

Bug: 1148448
Change-Id: I48ef88d223abd83411be7406e270a3df0f11b6d9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2534935Reviewed-by: James Cook <jamescook@chromium.org>
Commit-Queue: Erik Chen <erikchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#826945}

This is a reland of ae52b2a4 with fixes
for robolectric tests, which run on the JVM which appears to have
stricter verification checks.

Original change's description:
> [WebLayer] Change the return type of Fragment.getActivity() to Activity.
>
> This CL adds the ability to specify a script in an android_aar_prebuilt
> rule that can modify prebuilt jar files, and adds a script to change
> Fragment.getActivity() and Fragment.requireActivity() to return an
> Activity instead of a FragmentActivity.
>
> This is the first CL in a chain that will allow us to remove the fake
> activity we create when embedding Fragments that cross classloader
> boundaries.
>
> Bug: 1123216
> Change-Id: I4b9d3ca5f9c3a4d86e08d64f49d601c08fca9a70
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432413
> Reviewed-by: Theresa  <twellington@chromium.org>
> Reviewed-by: Andrew Grieve <agrieve@chromium.org>
> Commit-Queue: Robbie McElrath <rmcelrath@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#823582}

Bug: 1123216
Change-Id: I83ed0c47cda12e4a71ed90cc0bce4cde2a07782d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521343Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Theresa  <twellington@chromium.org>
Commit-Queue: Robbie McElrath <rmcelrath@chromium.org>
Cr-Commit-Position: refs/heads/master@{#826944}

In order to get the DWM full screen optimization and save power, the
overlay size must match the screen size when in fullscreen mode. If
there are a few pixels off, this CL adjusts the overlay size to fit the
screen.

Remove |disable_larger_than_screen_overlays| workaround since this is
now handled by this fullscreen size adjustment function.

Bug: 720059, 1027046
Change-Id: I08feb0ec42d0ae3157e64edac4b467795cf426f4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2508203
Commit-Queue: Maggie Chen <magchen@chromium.org>
Reviewed-by: Sunny Sachanandani <sunnyps@chromium.org>
Cr-Commit-Position: refs/heads/master@{#826943}

This change adds a spoken feedback test for the tutorial in OOBE,
using an existing ChromeVox test as a template
(ChromeVoxTutorialTest.QuickOrientationLessonTest)

We also add a basic test for the tutorial when signed in.

Fixed: 1127048
AX-Relnotes: N/A
Change-Id: I4715fe719de24c14462bde369a753e519619d7fd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533754
Commit-Queue: Akihiro Ota <akihiroota@chromium.org>
Reviewed-by: David Tseng <dtseng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#826942}

Bug: 1148367
Change-Id: Ibab803adbe500108754b1d697d5a8a5ec869bc55
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2535810
Commit-Queue: Nico Weber <thakis@chromium.org>
Commit-Queue: Hans Wennborg <hans@chromium.org>
Auto-Submit: Nico Weber <thakis@chromium.org>
Reviewed-by: Hans Wennborg <hans@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#826941}

ImageContextImpl can sometimes not have a SkPromiseImageTexture
associated with it and return null from promise_image_texture(). This
happens when there the texture is missing and it's an external image
that a fallback can't be created for. Check before trying to dereference
a nullptr.

Bug: 1148283, 1092080, 1148095
Change-Id: I45c0c5a233925b889778fe6e65f2b3fbfa077ecb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533589Reviewed-by: Khushal <khushalsagar@chromium.org>
Reviewed-by: Peng Huang <penghuang@chromium.org>
Commit-Queue: kylechar <kylechar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#826940}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/2f813eb9ddbb..f86e9704c66b

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC dbertoni@google.com,zmin@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: chromium:1127088,chromium:1143402
Tbr: dbertoni@google.com,zmin@google.com
Change-Id: Id2a113a7ae67d1dfdf090dbd84f8ac209445cd86
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533160Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#826939}

Also moves some histogram codes to capture_mode_metrics.

Bug: 1140182
Test: added tests
Change-Id: I14fcb45512333ac3978884aae6db6a83cb1e8110
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2530220
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#826938}

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll
Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-deterministic-dbg;luci.chromium.try:fuchsia-x64-cast
Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com
Change-Id: I607e1dd57415795e5740a30d7e4f4d473b62c29e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2534619Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#826937}

This is a reland of d22a4cef

Fixes:
- Add :wtf_support target for mojo targets, even when only requiring
  headers.
- Slim down :wtf target by only requiring //v8:cppgc_headers when
  using the Oilpan library.

Original change's description:
> wtf: Build traits based on cppgc for when using Oilpan library
>
> Currently WTF uses forward declarations to define basic GC traits that
> are used throughout WTF and Blink globally, i.e., without any specific
> context or other traits being available. This is an implicit
> dependency on blink.
>
> With Oilpan throuhg V8, we make this dependency a header-only
> dependency that is explicit which allows to re-use existing traits
> from the library to define the WTF equivalents.
>
> Change-Id: I3995c0d587424299ed880adcd5ac848a635e4f1e
> Bug: chromium:1056170
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532236
> Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
> Reviewed-by: Kentaro Hara <haraken@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#826397}

Cq-Include-Trybots: luci.chromium.try:linux-chromeos-rel
Bug: chromium:1056170
Change-Id: Ic9594e7d4824d12cd06273854c9391ee97503fca
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532222Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Ken Rockot <rockot@google.com>
Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#826936}

This is a reland of 17bbb4dd

WEB_ENGINE_EXPORT was missing in the original, causing the component
build to fail. It has been added now.

Original change's description:
> [fuchsia] Implement NavigationPolicyThrottle for navigation blocking
>
> * Add an implementation of NavigationPolicyThrottle to WebEngine
> * Add NavigationPolicyHandler, which keeps track of throttles and checks
>   if navigations need to be passed on to the client
> * Add a FakeNavigationPolicyProvider for tests
>
> Test: NavigationPolicyThrottleTest
> Bug: 1117601
> Change-Id: I0bdf94345b10d829bea4aeb85f74204970a97239
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519039
> Commit-Queue: Sharon Yang <yangsharon@chromium.org>
> Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#826625}

Bug: 1117601
Change-Id: If1b5e3e9e6e199795be7076641c73edfdf5fafb6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2534608
Commit-Queue: Sharon Yang <yangsharon@chromium.org>
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#826935}

This CL updates some method names to follow Coding Guidelines for Cocoa.
Additionally unused method were removed and some method arguments and
signatures were updated.

Bug: None
Change-Id: I03c1426d25f7671db1fd723b105b4d1a7d8705ff
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527796
Commit-Queue: Eugene But <eugenebut@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#826934}

Roll Chrome Mac PGO profile from chrome-mac-master-1605074376-4a1ac92ae1c3d96ed8ec2e639c66896bbbb0571f.profdata to chrome-mac-master-1605182400-7fb6cfb0609ea611bc3a38e3ac52d34b26c93566.profdata

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-chromium
Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:mac-chrome
Tbr: pgo-profile-sheriffs@google.com
Change-Id: Ifc8c04da996f41ff060fb942cfa1c6622bceeb1c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2534012Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#826933}

In http://crrev.com/c/2504089 I changed this function to use the new
CanonicalCookie factory method FromStorage() which returns a nullptr if
the resulting CanonicalCookie does not pass IsCanonical().

Since it turns out not every system cookie is guaranteed to be
canonical, which means dereferencing the pointer returned by FromStorage
sometimes resulted in a crash.

In order to fix this, this CL changes CanonicalCookieFromSystemCookie to
return the unique_ptr returned by FromStorage. It also updates the
callsites of CanonicalCookieFromSystemCookie to ignore the cookie in the
case that FromStorage returns a nullptr.

Bug: 1146386
Change-Id: Ic00a1e14af065b5b8b68e36d89ec043d5385f5b2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527729
Commit-Queue: Dylan Cutler <dylancutler@google.com>
Reviewed-by: Mark Cogan <marq@chromium.org>
Reviewed-by: Lily Chen <chlily@chromium.org>
Cr-Commit-Position: refs/heads/master@{#826932}

These histograms are still detecting the back/forward list being
out-of-sync with WKWebView's URL, caused by bugs in WebKit.
Once these bugs are no longer detected, we can remove workarounds
and also remove the histograms.

Bug: 1147719
Change-Id: Ib4d661ff430c286332b0564c74c4e5850716638a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533793Reviewed-by: Brian White <bcwhite@chromium.org>
Commit-Queue: Ali Juma <ajuma@chromium.org>
Cr-Commit-Position: refs/heads/master@{#826931}

BUG=1002262

Change-Id: I91c23b26a01cfc03b77e57e86ad85c80d21f7646
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2531177
Commit-Queue: Adam Langley <agl@chromium.org>
Reviewed-by: Martin Kreichgauer <martinkr@google.com>
Cr-Commit-Position: refs/heads/master@{#826930}

Adding a unit test to make sure scopes route nodes that
appear with no names route decendant do not cause a
refocus event after the scopes route node is removed.

Bug: 172838043
Test: Unit test
Change-Id: If238756d685c8c1d2548a5cac18436bc461bab76
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532665Reviewed-by: Daniel Nicoara <dnicoara@chromium.org>
Commit-Queue: Randy Rossi <rmrossi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#826929}

Small latest(final) updates according to the strings doc:
https://docs.google.com/document/d/1fqzX-QYidDKijMpPd8kaoFwg1zHAIGB7laD4tIBPzSk/edit?ts=5fab1a70

Bug: 1133324, 1134566
Change-Id: I677cbf50d4e7b1aa55189d71e0af73fa3700f726
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532462
Auto-Submit: Sergey Poromov <poromov@chromium.org>
Commit-Queue: Ahmed Fakhry <afakhry@chromium.org>
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#826928}

This makes the `if` statements in `ApplyPreferences` easier to read.

Bug: none
Test: change a preference and check chrome://histograms shows the sample
Change-Id: I99fdb9ad29d4f6df33444f7b12c20a1a5784f4d9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491973Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Commit-Queue: Harry Cutts <hcutts@chromium.org>
Cr-Commit-Position: refs/heads/master@{#826927}

This CL adds a some logic to read registry key values to control
the logging state for the host.  I've also integrated the
EventTraceData class with the EtwTraceConsumer for parsing.

The WXS file creates the logging reg key but by default we don't
log anything.  If logging is enabled, then we will create the
ETW classes to control and consume the events.  Once we have
ensured that the functionality is stable and have worked out any
issues, we can consider whether to turn it on by default.

The next CL will add the file logging and event logging classes.
I'd like to land this first to keep the CLs small and get as much
in before branch point as possible.

Bug: 1144185
Change-Id: I5778e57651b6afc99819140c911c2ace79803d74
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2535011Reviewed-by: Jamie Walch <jamiewalch@chromium.org>
Commit-Queue: Joe Downing <joedow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#826926}

xproto_types.h is included in all xlib code, so including an xcb header
may add unnecessary header bloat to many files in the build.

R=sky

Bug: None
Change-Id: Ib77d6de6ab58e36906d37d888ea8deaa93f2e5a5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532907
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#826925}

Because BubbleDialogModelHost needs to support links a StyledLabel is
occasionally used. This isn't supported in Checkbox because it
subclasses LabelButton which uses a plain Label.

Before this change, a BoxLayoutView was used to fake the Checkbox layout
but using a separate view for the Label/StyledLabel. This has the
downside of reducing the size of the Checkbox controller (which does not
contain the label), which also reduces the clickable area.

This change replaces the BoxLayoutView with a subclass of Checkbox and
installs the BoxLayout using the prior configuration. This puts the
label inside the Checkbox control which enlargens the Checkbox clickable
area.

Clicking links does not trigger the Checkbox control as the child Links
handle events internally and they don't propagate to the parent control.

Bug: 1138505, 1138770
Change-Id: Ic01e538cf5f0dd16611d08c307bb8df689c07d78
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532860Reviewed-by: Allen Bauer <kylixrd@chromium.org>
Commit-Queue: Peter Boström <pbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#826924}

 - Place stray calls to chrome.send() and cr.sendWithPromise() in
   c/b/r/settings/chromeos/date_time_page/ behind a browser proxy.
 - Update date_time_page_tests.js to leverage TestBrowserProxy.
 - Remove any calls to the obsolete registerMessageCallback() test
   helper, as well as any setTimeout() calls in
   date_time_page_tests.js.

This cleanup also revealed a completely defunct test case
"set date and time button", where no code in the test was actually
executed (also fixed).

The motivation behind this is to remove usages of
registerMessageCallback() test helper in order to eventually fully
remove it.

Bug: 1148403,1147940
Change-Id: I786cb2485483c7477bd6fd746cd3f1a054be4d3f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532674Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Commit-Queue: dpapad <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#826923}

When a render surface's |clip_rect| or |content_rect| changes, we should
invalidate its backdrop filter cache flag even when the damage from
under the surface doesn't intersect the surface's current rect.

Of course surface property can be changed due to other reasons, such as
transform change, effect change or ancestor property change. Not all
such changes should cause the backdrop filter cache flag to invalidate,
and an example is removal of a child layer. However, currently all such
changes are treated uniformly, i.e. will trigger backdrop filter cache
flag to invalidate.

This CL also removes the constraint to only set the backdrop filter
cache flag when there's blur effect so now all render surfaces will have
a valid value for this flag.

Bug: 1147894
Change-Id: I2f09363f7553ba0c1e6caaa2443391c9c582e441
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533530Reviewed-by: weiliangc <weiliangc@chromium.org>
Commit-Queue: Jun Liu <yjliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#826922}

The wpt/css/composite-bgcolor-animation was newly added in this CL:
https://chromium-review.googlesource.com/c/chromium/src/+/2464428,
which is specifically to tests the ongoing work of composite background
color animation.

It turns out that we already have wpt/css/css-backgrounds that has
a lot of tests in it to test painting background color. So this CL
moves the tests under composite-bgcolor-animation to css-backgrounds,
and then make the entire css-backgrounds a virtual test suite. This
will ensure more test coverage.

As a result of creating a new virtual test suite, there are 4 tests
currently failing. IMHO that should not block this CL because this
feature is behind a flag.

Bug: 1148305
Change-Id: I3759d0f431d8bcdb5e73f6aec42462ccdb343101
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533586Reviewed-by: Kevin Ellis <kevers@chromium.org>
Commit-Queue: Xida Chen <xidachen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#826921}

https://screenshot.googleplex.com/SgbgU5UtXDYGaCN.png

BUG=1146567,1106937

Change-Id: I7739c9938d7082bd274ef944df875c43f68d726e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533315Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: Regan Hsu <hsuregan@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Tim Song <tengs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#826920}

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll
Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com
Change-Id: I6e5afe911ea53f3a178f05b461214962d740e347
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2534624Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#826919}

Final piece of a 3-sided change to move CriteriaHelper to base/

This removes the remaining shim now that downstream usage has been
migrated.

Bug: 1134178
Change-Id: I6599bbdbd00fd33d68135e574512c7c8ff41bd72
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2530450
Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#826918}

https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/9534205dbf29..43efdd17a959

2020-11-12 tvanderlippe@chromium.org Use TypeScript-authored files in changes/
2020-11-12 aerotwist@chromium.org Fix unit tests
2020-11-12 patrick.brosset@microsoft.com Flex: make flex badges in the elements pane update dynamically

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: chromium:1011811,chromium:1144090,chromium:1148296
Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com
Change-Id: I44219c5071a278a0be7a367d848a4a1d6c7f1948
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533242Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#826917}

DocumentAnimations::UpdateAnimations is called for each frame so even
though we collect the main frame animations we overwrite them when we
collect the subframe animations. We should collect animations across all
documents and aggregating these to be sent to the AnimationHost.


Bug: 1128410
Change-Id: I4e75d674e0b4d887682c01e44040483311f15b34
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437491Reviewed-by: Robert Flack <flackr@chromium.org>
Reviewed-by: Xida Chen <xidachen@chromium.org>
Commit-Queue: Lan Wei <lanwei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#826916}

It looks like when WebView and other Views are scrollable together, such
as the Gmail composition activity, the GestureScrollEnd event
coordinates will jump a lot from the last GestureScrollUpdate event. If
we move the cursor in this case, the cursor will jump few lines above
the current position.

This is because the GestureScrollEnd event is generated from the Android
MotionEvent::Action::CANCEL event, this is a event to notify the current
View that the following events won't be dispatched to it anymore and
the coordinates is in a different coordinate system.

In this case, from WebView's point of view, the scroll sequence will be
terminated if the touch event is going vertically, because the Android
motion event won't be dispatched to WebView in this type of layout, so
we won't be able to move the cursor up and down and user has to fallback
to the regular way to move the cursor.

Bug: 1145146
Change-Id: Iac29ca9a3799fdbdf19fffc52b23650111bc1138
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533687Reviewed-by: Robert Flack <flackr@chromium.org>
Commit-Queue: Shimi Zhang <ctzsm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#826915}

Using wpt-import in Chromium cc89d61c.
With Chromium commits locally applied on WPT:
c0e73fce "[webcodecs] Make sure callbacks aren't called after encoder.reset()"


Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
foolip@chromium.org, lpz@chromium.org, robertma@chromium.org:
  external/wpt/tools

NOAUTOREVERT=true
TBR=lpz@google.com

No-Export: true
Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel,linux-wpt-payments-fyi-rel
Change-Id: I95cca371ee06eecc0d52fff67b6898a47d7562bb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2535110Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#826914}

This CL was accomplished via:

  sed -i -e 's/MasterPreferences/InitialPreferences/g'

with a small amount of manual cleanup and `git cl format`.

Bug: 1097204
Change-Id: If51f1f5f0ca361bd2e38aaefb872c1b1f26bf59c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533573Reviewed-by: Greg Thompson <grt@chromium.org>
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#826913}

This CL updates the SODA components to use the local state (AKA global
prefs) instead of profile prefs to keep track of the SODA file paths.

Bug: 1147587
Change-Id: Ic6039558eeee07f07aa3509b2f6fd9d48d4e9ee5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2530590Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
Commit-Queue: Evan Liu <evliu@google.com>
Cr-Commit-Position: refs/heads/master@{#826912}