GitLab

Originally chrome://crashes only displayed uploaded crashes, and only
displayed the time at which the crash report was uploaded.

On systems using Crashpad we also have access to the crash capture-time
which is useful in identifying crash reports which occurred while
offline, for example, such that the capture and upload times would
differ considerably.

This patch was originally drafted by phistuck@gmail.com and
jiameng@chromium.org.

BUG=664430,674249

Review-Url: https://codereview.chromium.org/2612993003
Cr-Commit-Position: refs/heads/master@{#442091}

BUG=676493

Review-Url: https://codereview.chromium.org/2611203003
Cr-Commit-Position: refs/heads/master@{#442090}

BUG=678341

Review-Url: https://codereview.chromium.org/2618083002
Cr-Commit-Position: refs/heads/master@{#442089}

After automatic rename by rewrite_to_chrome_style clang tool, the |rtl|,
|ltr| and |inherit| constant identifiers in CanvasRenderingContext2D.cpp
would become |kRtl|, |kLtr|, |kInherit| and would unfortunately conflict
with identifiers defined elsewhere (e.g. with |kRtl| and |kLtr| enum
values from TextDirection enum defined in TextDirection.h).

This CL preemptively prevents the problem above, by adding a
'DirectionString' suffix to the 3 affected identifiers in
CanvasRenderingContext2D.cpp

BUG=641004

Review-Url: https://codereview.chromium.org/2611723004
Cr-Commit-Position: refs/heads/master@{#442088}

BUG=none

Review-Url: https://codereview.chromium.org/2617903004
Cr-Commit-Position: refs/heads/master@{#442087}

Current items (Open in new tab, Open in incognito tab, Copy link
address, Copy link text) shown in the context menu for mailto tag link
do not make sense.

Update the items shown in the context menu when long pressing a mailto
link. The items include:
1. Send message: same behavior as clicking the link which will navigate
to default mail app to send an email with parsed info from url.
2. Add to contacts:
  - If no email address in the mailto, hid the menu item
  - If more than one email addresses is present, select the first one
    for adding to the contacts
3. Copy: copy all the email addresses (everything between mailto: and ?)

BUG=389056

Review-Url: https://codereview.chromium.org/2605283002
Cr-Commit-Position: refs/heads/master@{#442086}

A test trace is a trace that shows which tests are running and for how long.

Review-Url: https://codereview.chromium.org/2617233002
Cr-Commit-Position: refs/heads/master@{#442085}

base::vsnprintf already handles the windows difference so we don't need the
platform ifdefs. We can also optimistically format into the buffer and if it
fits avoid formatting twice.

Review-Url: https://codereview.chromium.org/2620453002
Cr-Commit-Position: refs/heads/master@{#442084}

https://skia.googlesource.com/skia.git/+log/f55ea6a1deb2..83f532e9b5b8

$ git log f55ea6a1d..83f532e9b --date=short --no-merges --format='%ad %ae %s'
2017-01-06 mtklein Add a real SkXbyak bench, implement enough to run it.
2017-01-06 mtklein exclude src/opts/SkXbyak.cpp from g3 build
2017-01-06 kjlubick Add in Path fuzzer
2017-01-06 djsollen Add support for 64-bit devices when using gdb on Android
2017-01-06 bsalomon Purge clip masks when they are no longer findable.
2017-01-04 fmalita Avoid SkFixed overflow in decal bitmap procs
2017-01-06 bsalomon Remove arithmetic mode GrXP code.
2017-01-06 bsalomon Add support for tagging GrUniqueKeys with a debug string
2017-01-06 mtklein SkXbyak basics

BUG=676459,675444

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
TBR=csmartdalton@google.com

Review-Url: https://codereview.chromium.org/2617043004
Cr-Commit-Position: refs/heads/master@{#442083}

We expose API enums on objects with in the API; this is mostly useful
because our enum style is pretty wildly inconsistent (hacker_style,
camelCase, and SCREAMING_STYLE are all used). This allows authors to
use the enum directly by using chrome.foo.BarEnum.SOMETHING.

Add support for this in native bindings.

BUG=653596

Review-Url: https://codereview.chromium.org/2615773002
Cr-Commit-Position: refs/heads/master@{#442082}

WebmMuxer sets WebM's DefaultDuration to the expected delta between
frames (derived from the frame rate), but that messes up (some) players
due to frames arriving at a different rate. This is a legimimate case
if, e.g.  the encoded data stream is paused.

This CL essentially avoids setting this parameter so that players
can just look at each encoded frame timestamp instead.

[1] http://www.webmproject.org/docs/container/#track

BUG=606000

Review-Url: https://codereview.chromium.org/2617143003
Cr-Commit-Position: refs/heads/master@{#442081}

"-latomic" flag is not necessary.

Besides, libatomic.so is unavailable in the next toolchain update.

BUG= internal b/33944287
TEST= builds.

Review-Url: https://codereview.chromium.org/2611173003
Cr-Commit-Position: refs/heads/master@{#442080}

CodeMirror takes a line seperator as an argument, so we don't have to
use a regular expression.

BUG=none

Review-Url: https://codereview.chromium.org/2615633012
Cr-Commit-Position: refs/heads/master@{#442079}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/f84aaa04d4d0..fa6d5ce49e34

$ git log f84aaa04d..fa6d5ce49 --date=short --no-merges --format='%ad %ae %s'
2017-01-06 jessimb Adding skeleton for /speed_releasing endpoint.
2017-01-06 rnephew [Android][Telemetry] Log processes running during Nexus 7 runs.
2017-01-06 benjhayden Fix some old style violations in UserModelBuilder.
2017-01-06 rnephew [BattOr] Upload Windows AVRDude binary for flashing BattOr firmware.

BUG=667470

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2617873003
Cr-Commit-Position: refs/heads/master@{#442078}

This change strips InstallerState of all multi-install knowledge and
trickles the change through the rest of the installer. An
InstallerState now has exactly one Product on which it operates. There
is substantial room for further improvement, which will come after
InstallDetails is woven into setup.

Various "delete old stuff" operations are also coalesced into a single
post-install/update step rather than sprinkled around Chrome's install
path.

While at it, this change also removes some old Chrome Frame code that
is no longer used (IE low rights elevation policy, GCF in use, COM
DLLs) and attempts some IWYU fixes.

BUG=577816

Review-Url: https://codereview.chromium.org/2589753002
Cr-Commit-Position: refs/heads/master@{#442077}

Once we have shipped this for a release this feature flag can be removed.
I've tested Windows and the issues causing the spurious ET_MOUSE_EXITED
don't exist anymore so I believe this is safe to ship in this fashion.

BUG=450631,240300,352106,386896,569998,575208

Review-Url: https://codereview.chromium.org/2618063002
Cr-Commit-Position: refs/heads/master@{#442076}

Some of the exclusions introduced by crrev.com/2618853002 to deal
with OOM flakiness on lowmem devices are too aggressive and were
already dealt with by crrev.com/2589813002 .
Effectively this is a partial revert of crrev.com/2618853002 .

BUG=675255

Review-Url: https://codereview.chromium.org/2616063002
Cr-Commit-Position: refs/heads/master@{#442075}

The following traits are used:

Priority:
  BACKGROUND
    User won't notice if this task takes an arbitrarily long time
    to complete.

  and

  Inherited (default)
    The priority is inherited from the calling context (i.e. TaskTraits
    are initialized with the priority of the current task).

Shutdown behavior: CONTINUE_ON_SHUTDOWN
  Tasks posted with this mode which have not started executing before
  shutdown is initiated will never run. Tasks with this mode running at
  shutdown will be ignored (the worker will not be joined).

  Note: Tasks that were previously posted to base::WorkerPool should
  use this shutdown behavior because this is how base::WorkerPool
  handles all its tasks.

May Block:
  Tasks posted with MayBlock() may block. This includes but is not
  limited to tasks that wait on synchronous file I/O operations:
  read or write a file from disk, interact with a pipe or a socket,
  rename or delete a file, enumerate files in a directory, etc. This
  trait isn't required for the mere use of locks.

BUG=659191

Review-Url: https://codereview.chromium.org/2601413002
Cr-Commit-Position: refs/heads/master@{#442074}

This CL handles the situation when default app is not available
after Arc starts. In this case, default app entry is removed from
the app launcher.

BUG=b/31934494
TEST=Extended unit tests
TEST=Manually on device.
     Normal flow: Start Arc by clicking default app icon. Spinning
     item appears in shelf for the starting app. Play Store starts,
     spiining item stil exists and installtion stars (view in
     notification). Once default app is installed, it automatically
     pops up and spinning item is replaced with normal icon.
     App is not available flow: Repeat steps above. Installation
     for default app does not appear and spinning item is removed
     from shelf soon after. Default app is also removed from the
     app launcher.
     Re-sign in. In both cases default app state is preserved.

Review-Url: https://codereview.chromium.org/2601323002
Cr-Commit-Position: refs/heads/master@{#442073}

To tell us the % of page views that do top navigations in sandboxed
iframes w/ or w/o 'allow-top-navigation' and user gesture.

This is for this intent to implement/ship feature:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/Flt2IixYQK4

BUG=662506

Review-Url: https://codereview.chromium.org/2614073004
Cr-Commit-Position: refs/heads/master@{#442072}

It's much safer to cache the WebContents instead of WindowAndroid to
deal with tab reparenting, for example. This patch changes the credit
card OCR scanner extension point to cache the WebContents instead of
WindowAndroid.

This patch also adds chrome://flags/#autofill-scan-theme-dialog to be
used by Chrome's implementation of the credit card scanner. This flag is
disabled by default and will be removed once the best theme for the scan
dialog is determined.

BUG=678642

Review-Url: https://codereview.chromium.org/2614883003
Cr-Commit-Position: refs/heads/master@{#442071}

The namespace accidentally got removed while experimenting with a fix for
notification grouping.

BUG=678694

Review-Url: https://codereview.chromium.org/2619643002
Cr-Commit-Position: refs/heads/master@{#442070}

Replace with a console warning that this policy will be reinstated evenutally.

BUG=678328

Review-Url: https://codereview.chromium.org/2617773002
Cr-Commit-Position: refs/heads/master@{#442069}

Revert of Add an experimental standalone content suggestions UI. (patchset #8 id:140001 of https://codereview.chromium.org/2593523005/ )

Reason for revert:
Speculative revert, likely broke:

https://uberchromegw.corp.google.com/i/chromium.linux/builders/Android%20Tests%20%28dbg%29/builds/38814

However, there appears to be logdog problems, so I'm not sure if we are getting realistic error messages.

E 1343.751s run_tests_on_device(07601d750ae534e5)  Error not bootstrapped. Failed to start logdog: Missing project [LOGDOG_STREAM_PROJECT]
Traceback (most recent call last):
  File "/b/s/w/irq8DwmG/build/android/pylib/android/logdog_logcat_monitor.py", line 28, in __init__
    self._stream_client = bootstrap.ButlerBootstrap.probe().stream_client()
  File "/b/s/w/irq8DwmG/tools/swarming_client/libs/logdog/bootstrap.py", line 48, in probe
    raise NotBootstrappedError('Missing project [%s]' % (cls._ENV_PROJECT,))
NotBootstrappedError: Missing project [LOGDOG_STREAM_PROJECT]

Original issue's description:
> Add an experimental standalone content suggestions UI.
>
> The UI is hidden behind a feature flag that enables a menu item (which
> uses innovative string compression techniques to avoid bloat due to
> i18n) to open the standalone content suggestions UI.
>
> While the activity and menu item are not meant to be shipped in an
> enabled state, this will allow iterating on a content suggestions UI
> outside of the NTP.
>
> Review-Url: https://codereview.chromium.org/2593523005
> Cr-Commit-Position: refs/heads/master@{#441980}
> Committed: https://chromium.googlesource.com/chromium/src/+/1b34593a53181b7f8a06a97206219c16486b33a1

TBR=mvanouwerkerk@chromium.org,dgn@chromium.org,bauerb@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Review-Url: https://codereview.chromium.org/2614023005
Cr-Commit-Position: refs/heads/master@{#442068}

Mash should really use ChromeNativeAppWindowViewsAuraAsh, but that
depends upon a bunch of types in ash. So, make mash use
ChromeNativeAppWindowViewsAura, which isn't perfect, but at least it
doesn't crash.

BUG=679028
TEST=none
R=msw@chromium.org

Review-Url: https://codereview.chromium.org/2617923004
Cr-Commit-Position: refs/heads/master@{#442067}

In interface media::VideoCaptureDevice::Client, change interface Buffer to a
move-only struct. The new struct separates the concerns of providing access
handles (for in-process as well as for inter-process transit) from access
permissions. This allows clients to explicitly obtain in-process memory-mapped
handles when they need it. Clients who only want to pass along the buffer or
move it across process boundaries do not need memory-mapped handles.

In interface media::VideoCaptureBufferPool, renamed
 GetBufferHandle() -> GetHandleForInProcessAccess()
 GetHandleForTransit() -> GetHandleForInterProcessTransit().

Removed outdated implementation in video_capture Mojo service. We leave the
implementation empty, until refactoring the interfaces has been completed.

This CL is part of the Mojo Video Capture work. For the bigger picture,
see [1] CL1.9.10

For a peek at the follow-up CLs, please see
https://codereview.chromium.org/2607203002/
https://codereview.chromium.org/2602983002/

BUG=584797
TEST=
  content_unittests --gtest_filter="*Video*",
  video_capture_unittests,
  Apprtc loopback on Debug,
  Desktop Capture Example extension on Release

[1] https://docs.google.com/a/chromium.org/document/d/1Qw7rw1AJy0QHXjha36jZNiEuxsxWslJ_X-zpOhijvI8/edit?usp=sharing

Review-Url: https://codereview.chromium.org/2573223002
Cr-Commit-Position: refs/heads/master@{#442066}

With this change, this code will set both the Java and native side
prefs if any of the three indicators of TOS being seen are true,
i.e. either of the two prefs or "any user has seen ToS".

This is especially needed to fix variations seed fetching from
native code in the case of Backup & Restore, which does not
appear to restore the Chrome native pref.

BUG=669543

Review-Url: https://codereview.chromium.org/2614183002
Cr-Commit-Position: refs/heads/master@{#442065}

The new testfiles added in the CL had a problem. Fixed it now.

This reverts commit 9c484365.

BUG=676762
R=mmenke@chromium.org

Review-Url: https://codereview.chromium.org/2613093003 .
Cr-Commit-Position: refs/heads/master@{#442064}

BUG=674795
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2617903002
Cr-Commit-Position: refs/heads/master@{#442063}

Reland of [ios] Test new dialogs API in CRWWebControllerPageDialogOpenPolicyTest. (patchset #1 id:1 of https://codereview.chromium.org/2615283002/ )

Reason for revert:
Reverting broke tests on the main waterfall, so unreverting =)

Original issue's description:
> Revert of [ios] Test new dialogs API in CRWWebControllerPageDialogOpenPolicyTest. (patchset #1 id:1 of https://codereview.chromium.org/2613163002/ )
>
> Reason for revert:
> This is crashing on 32-bit devices.
>
> Thread 0 Crashed:: Dispatch queue: com.apple.main-thread
> 0   com.apple.CoreFoundation      	0x05b57301 _CFRelease + 1505
> 1   org.chromium.gtest.generic-unit-test	0x00a3afb7
> base::internal::ScopedNSProtocolTraitsRelease(objc_object*) + 39
> 2   org.chromium.gtest.generic-unit-test	0x00071d47
> base::internal::ScopedNSProtocolTraits<NSString*>::Release(NSString*) + 23
> 3   org.chromium.gtest.generic-unit-test	0x00071d28
> base::ScopedTypeRef<NSString*, base::internal::ScopedNSProtocolTraits<NSString*>
> >::~ScopedTypeRef() + 40
> 4   org.chromium.gtest.generic-unit-test	0x00071cf7
> base::scoped_nsprotocol<NSString*>::~scoped_nsprotocol() + 23
> 5   org.chromium.gtest.generic-unit-test	0x00071cd7
> base::scoped_nsobject<NSString>::~scoped_nsobject() + 23
> 6   org.chromium.gtest.generic-unit-test	0x00071567
> base::scoped_nsobject<NSString>::~scoped_nsobject() + 23
> 7   org.chromium.gtest.generic-unit-test	0x000716dd
> web::TestJavaScriptDialog::~TestJavaScriptDialog() + 45
> 8   org.chromium.gtest.generic-unit-test	0x00071707
> web::TestJavaScriptDialog::~TestJavaScriptDialog() + 23
> 9   org.chromium.gtest.generic-unit-test	0x00383724 (anonymous
> namespace)::CRWWebControllerPageDialogOpenPolicyTest_AllowConfirmWithTrue_Test::TestBody()
> + 4212
> 10  org.chromium.gtest.generic-unit-test	0x00adafe7 void
> testing::internal::HandleSehExceptionsInMethodIfSupported<testing::Test,
> void>(testing::Test*, void (testing::Test::*)(), char const*) + 103
> 11  org.chromium.gtest.generic-unit-test	0x00aae98a void
> testing::internal::HandleExceptionsInMethodIfSupported<testing::Test,
> void>(testing::Test*, void (testing::Test::*)(), char const*) + 106
> 12  org.chromium.gtest.generic-unit-test	0x00aae8b6 testing::Test::Run() + 246
> 13  org.chromium.gtest.generic-unit-test	0x00ab062f testing::TestInfo::Run() +
> 255
> 14  org.chromium.gtest.generic-unit-test	0x00ab1d44 testing::TestCase::Run() +
> 260
> 15  org.chromium.gtest.generic-unit-test	0x00ac59ce
> testing::internal::UnitTestImpl::RunAllTests() + 974
> 16  org.chromium.gtest.generic-unit-test	0x00add3c7 bool
> testing::internal::HandleSehExceptionsInMethodIfSupported<testing::internal::UnitTestImpl,
> bool>(testing::internal::UnitTestImpl*, bool
> (testing::internal::UnitTestImpl::*)(), char const*) + 103
> 17  org.chromium.gtest.generic-unit-test	0x00ac559a bool
> testing::internal::HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl,
> bool>(testing::internal::UnitTestImpl*, bool
> (testing::internal::UnitTestImpl::*)(), char const*) + 106
> 18  org.chromium.gtest.generic-unit-test	0x00ac549f testing::UnitTest::Run() +
> 335
> 19  org.chromium.gtest.generic-unit-test	0x00a4bc93 RUN_ALL_TESTS() + 19
>
> Original issue's description:
> > [ios] Test new dialogs API in CRWWebControllerPageDialogOpenPolicyTest.
> >
> > Use TestJavaScriptDialogPresenter instead of deprecated
> > CRWWebUserInterfaceDelegate.
> >
> > BUG=661445
> > TBR=kkhorimoto@chromium.org
> >
> > Review-Url: https://codereview.chromium.org/2613163002
> > Cr-Commit-Position: refs/heads/master@{#441998}
> > Committed: https://chromium.googlesource.com/chromium/src/+/e3cb6842bb7d440a8f8259bea661e5b97159fdca
>
> TBR=michaeldo@chromium.org,eugenebut@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=661445
>
> Review-Url: https://codereview.chromium.org/2615283002
> Cr-Commit-Position: refs/heads/master@{#442036}
> Committed: https://chromium.googlesource.com/chromium/src/+/8c9857238e62da4de34c8b02458418916c8a77d0

TBR=michaeldo@chromium.org,eugenebut@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=661445

Review-Url: https://codereview.chromium.org/2615293002
Cr-Commit-Position: refs/heads/master@{#442062}

Adding Mali Workaround patch for the latest Mali-G71
https://www.arm.com/products/graphics-and-multimedia/mali-gpu

BUG=678508

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2611933002
Cr-Commit-Position: refs/heads/master@{#442061}

The native window parenting should happen in the window server,
since a sandboxed gpu process won't be able to do it.

BUG=643746

Review-Url: https://codereview.chromium.org/2610783003
Cr-Commit-Position: refs/heads/master@{#442060}

BUG=657102

Review-Url: https://codereview.chromium.org/2613733002
Cr-Commit-Position: refs/heads/master@{#442059}

Downstream code expects nonzero resources to be discovered during
FrameSerializer::serializeFrame. However, this can happen in some cases
when processing image documents.

BUG=678893

Review-Url: https://codereview.chromium.org/2613253002
Cr-Commit-Position: refs/heads/master@{#442058}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/24315c519ee9..f84aaa04d4d0

$ git log 24315c519..f84aaa04d --date=short --no-merges --format='%ad %ae %s'
2017-01-06 rnephew [BattOr] Update Win, Mac and Linux battor agent binaries in deps manager.
2017-01-06 simonhatch Dashboard - Fix some internal bisects not starting automatically.
2017-01-06 eakuefner [StyleGuide] Add specific delineation for JavaScript
2017-01-06 sullivan Do not create data stoppage alerts for ref builds.

BUG=677303,678659

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2617223002
Cr-Commit-Position: refs/heads/master@{#442057}

Original patch got reverted due to compile error.

BUG=678034

Review-Url: https://codereview.chromium.org/2615263002
Cr-Commit-Position: refs/heads/master@{#442056}

(the page info bubble for chrome:// pages)

BUG=585076

Review-Url: https://codereview.chromium.org/2616573002
Cr-Commit-Position: refs/heads/master@{#442055}

    "Import wpt@eeecf3e14368d4ab5221cde688003dedeca30dba"
    This reverts commit cfd8c14d.

    "Update MANIFEST.json to newest version."
    This reverts commit dc2a9e04.

Reason for revert:
Begins running layout tests without proper expectations.

Original issue's description:
> Update MANIFEST.json to newest version.
>
> Background: Recently in web-platform-tests the format of MANIFEST.json changed, and I filed http://crbug.com/678077 for this. I committed a change http://crrev.com/2610243002 which updated the layout test runner to find web-platform-tests with the new manifest format, but the actual manifest file was too large to upload to Rietveld and was not committed. After that change, no wpt tests are found when running run-webkit-tests imported/wpt.
>
> This change would update MANIFEST.json, although the actual file is still too large to upload to Rietveld, so this CL (in patch 1 at least) appears empty. I believe it would have to be landed directly.
>
> TBR=dpranke
>
> BUG=678077
>
> Review-Url: https://codereview.chromium.org/2615903004 .
> Cr-Commit-Position: refs/heads/master@{#441999}
> Committed: https://chromium.googlesource.com/chromium/src/+/dc2a9e048fd191a43a35c8f6ee1e4cecb7fc919d

TBR=dpranke@chromium.org,qyearsley@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=678077

Review-Url: https://codereview.chromium.org/2619613002 .
Cr-Commit-Position: refs/heads/master@{#442054}

Fix NavigationControllerBrowserTest.SubframeForwardRedirect with PlzNavigate and site isolation enabled.

The problem is that NavigationRequest::dest_site_instance_ is set in the constructor of that class. If RenderFrameHostManager::CanSubframeSwapProcess determines that a cross process redirect should happen for the subframe (because of site isolation) then we might need to use a new site instance.

BUG=674734
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2594263004
Cr-Commit-Position: refs/heads/master@{#442053}

The WebMediaPlayerCast class is-a RendererMediaPlayerInterface, which
has methods that look like blink::WebMediaPlayer methods, but it is
a chromium-style class. The WebMediaPlayerAndroid is-a
blink::WebMediaPlayer and also a RendererMediaPlayerInterface so
its overrides end up overriding both at once. This is problematic
because, while also being difficult to follow where control flow
goes, when the blink names are renamed in the Great Blink Rename to
be chromium style, incorrectly-blink-styled names outside of blink
will not be renamed and the inheritance here will break.

The two methods here are hasVideo() and paused(). It turns out that
neither method is ever used as part of the
RendererMediaPlayerInterface. And only paused() is used as part of
the concrete WebMediaPlayerCast class. So I have removed them both
from the RendererMediaPlayerInterface and added IsPaused() as a
non-virtual method on WebMediaPlayerCast instead.

R=hubbe@chromium.org
BUG=578344

Review-Url: https://codereview.chromium.org/2619593002
Cr-Commit-Position: refs/heads/master@{#442052}