- 11 Sep, 2019 40 commits
-
-
Daniel Vogelheim authored
The current origin policy interstitial uses the all-red super danger interstitials style, and the text messages indicate an imemdiate security threat (which could be true, but it might also be a simple mis-configuration). This changes this to an SSL-error-like interstitial design, and a more neutral language. Bug: 971598, 751996 Change-Id: I31dba2ae7646eb1e2ee747ab93c9854516ffeddb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1795604Reviewed-by:
Carlos IL <carlosil@chromium.org> Commit-Queue: Daniel Vogelheim <vogelheim@chromium.org> Cr-Commit-Position: refs/heads/master@{#695591}
-
Mitsuru Oshima authored
This reverts commit c954302b. Reason for revert: This broke ChromePFQ bots (in chromeos infra) Bug: 1002895 Original change's description: > Roll src/third_party/dawn f35dcfe60a62..03e31edd98f1 (1 commits) > > https://dawn.googlesource.com/dawn.git/+log/f35dcfe60a62..03e31edd98f1 > > git log f35dcfe60a62..03e31edd98f1 --date=short --no-merges --format='%ad %ae %s' > 2019-09-11 rafael.cintron@microsoft.com Cleanup d3d12::Device::ExecuteCommandLists > > Created with: > gclient setdep -r src/third_party/dawn@03e31edd98f1 > > If this roll has caused a breakage, revert this CL and stop the roller > using the controls here: > https://autoroll.skia.org/r/dawn-chromium-autoroll > Please CC cwallez@google.com on the revert to ensure that a human > is aware of the problem. > > To report a problem with the AutoRoller itself, please file a bug: > https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug > > Documentation for the AutoRoller is here: > https://skia.googlesource.com/buildbot/+/master/autoroll/README.md > > CQ_INCLUDE_TRYBOTS=luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel > TBR=cwallez@google.com > > Bug: None > Change-Id: Ie97ffefe9e808bbb711df73a180d44e8f0407eff > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1797802 > Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Cr-Commit-Position: refs/heads/master@{#695501} TBR=cwallez@google.com,chromium-autoroll@skia-public.iam.gserviceaccount.com Change-Id: Ifc95a0aade560a1dad9fd405e42f8154ffc226d8 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: None Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1797089Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#695590}
-
Omer Katz authored
HasPendingActivity of classes inheriting from ScriptWrappable are not allowed to allocate. Using GetNFCProxy in HasPendingActivity resulted in allocation. This issue was found by clusterfuzz. Added a call to GetNFCProxy during NFCReader initialization. This guarantees that a NFCProxy object exists when we call HasPendingActivity down the line and avoids the allocation. Bug: 1001974 Change-Id: I83abd54641618a56d33a73150ffdfccd3d64a73e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1796370 Commit-Queue: Omer Katz <omerkatz@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#695589}
-
Rouslan Solomakhin authored
Before this patch, when merchant requested a shipping address before providing any shipping options, Chrome would show the payment overview sheet with deselected shipping address. The user would need to first click [Select] in the shipping address section, then select the shipping address. This patch shows the shipping address selection when the user needs to select a shipping address. After this patch, Chromes shows the shipping address selection screen when the merchant requests a shipping address before providing any shipping options. Disabled by default behind "StrictHasEnrolledAutofillInstrument" feature. Can be tested with: chrome://flags/#enable-web-payments-experimental-features Bug: 1001644 Change-Id: I1eef3021f474f8de244412204afd7b5b63e84821 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787702 Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Danyao Wang <danyao@chromium.org> Cr-Commit-Position: refs/heads/master@{#695588}
-
Renato Silva authored
ChromeOS Login Screen - Aura Shell Change the way how a PIN gets checked if its composed of only numbers. PINs were checked with base::StringToInt which returns false when their value would overflow an Int. Replace it with base::ContainsOnlyChars(). Bug: 998930 Change-Id: I44fdee46413f82cdfe24d18d66af0ec00ed3d95b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783146 Commit-Queue: Renato Silva <rrsilva@google.com> Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#695587}
-
Alex Oldemeier authored
The policy template needs to be updated to reflect the new default behaviour of WebRtcEventLogCollectionAllowed. Bug: 983113 Test: compile Change-Id: I72184fecf3841400aa9db49302fd10dbfed50263 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1795242Reviewed-by:
Alexander Hendrich <hendrich@chromium.org> Commit-Queue: Alexander Hendrich <hendrich@chromium.org> Auto-Submit: Alex Oldemeier <aoldemeier@chromium.org> Cr-Commit-Position: refs/heads/master@{#695586}
-
Chromium WPT Sync authored
Using wpt-import in Chromium d5e7e89d. With Chromium commits locally applied on WPT: cf88186a "[LayoutNG] Fix `vertical-align: top` and `bottom`" 30dde1e3 "[LayoutNG] Fix `vertical-align: top/bottom` with leading" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=lpz No-Export: true Change-Id: Ia15ad858029761d2f759338c233442f543e30f51 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1798262Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#695585}
-
vitaliii authored
Disable WebRtcDataBrowserTest.CallWithDataAndMedia on Win and Linux, because flaky. TBR=liberato@chromium.org,phoglund@chromium.org Bug: 986872 Change-Id: Ifcfe2480ca77cdd3745dbd9a0bb31abbc1a86dbb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1796666Reviewed-by:
vitaliii <vitaliii@chromium.org> Commit-Queue: vitaliii <vitaliii@chromium.org> Cr-Commit-Position: refs/heads/master@{#695584}
-
Jérôme Lebel authored
Enabling testSignInDisconnectFromChromeManaged test. Updating the test to support unity, and closing the settings after doing the sign-in. Bug: 929967 Change-Id: I3185916df9f9bfe01ef430d630d94c435be0db0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1793185 Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#695583}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/0b8eca795349..9dbfeac8b553 git log 0b8eca795349..9dbfeac8b553 --date=short --no-merges --format='%ad %ae %s' 2019-09-11 angle-autoroll@skia-public.iam.gserviceaccount.com Roll ./third_party/spirv-tools/src 7f7236f1eba0..c0e9807094ef (4 commits) Created with: gclient setdep -r src/third_party/angle@9dbfeac8b553 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC syoussefi@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=syoussefi@chromium.org Bug: chromium:None Change-Id: I49a9398da9e33670ffe821d307377538330e7be5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1797159Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#695582}
-
Vadym Doroshenko authored
The dataflow is the following: 1.The user is typing in the non-password field, this data is saved in PossibleUsernameData struct in PasswordManager. 2.When the password form is submitted PossibleUsernameData instance is passed to form manager. 3.If as a result of the parsing, the username is not found and data from PossibleUsernameData looks plausible (see possible_username_data.h::IsPossibleUsernameValid for more details). then the typed value is taken as username. Bug: 959776 Change-Id: I33de65211af2de5f2f8b7f486682fcf303b89414 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715352 Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#695581}
-
redatawfik authored
- Create class "CreditCardScannerImageProcessor" which handles processing a credit card image and call the consumer with the results. - Move all text recognition logic from mediator to "CreditCardScannerImageProcessor". Bug: 984545 Change-Id: Ifbdb1b6fbc22804ba969c2c2dec89fadbaa095d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783443 Commit-Queue: Reda Tawfik <redatawfik@google.com> Reviewed-by:
Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#695580}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/70767cba4254..fcfeefe03386 git log 70767cba4254..fcfeefe03386 --date=short --no-merges --format='%ad %ae %s' 2019-09-11 mbonadei@webrtc.org Move rtc_error.{h,cc} to its own build target. 2019-09-11 srte@webrtc.org Reland "Adds peer scenario connection interface." Created with: gclient setdep -r src/third_party/webrtc@fcfeefe03386 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: None Change-Id: I8b9b59334a47bd92999fb9f2685283ffce712f28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1797160Reviewed-by:
-
Felipe Andrade authored
Changes references to the old policy documentation, replacing by the new policy list page. The patterns for the old and new URLs can be found on the bug description. Bug: 987706 Change-Id: I53b020af2499731b159987f1995da943bf160ddb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1780836 Commit-Queue: Felipe Andrade <fsandrade@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Matt Mueller <mattm@chromium.org> Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Cr-Commit-Position: refs/heads/master@{#695578}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/14318c140949..c13cb6e62441 git log 14318c140949..c13cb6e62441 --date=short --no-merges --format='%ad %ae %s' 2019-09-11 olivernewman@google.com Handle output placeholder missing backing file Created with: gclient setdep -r src/third_party/skia@c13cb6e62441 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC mtklein@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=mtklein@google.com Bug: None Change-Id: I585c63a2c67a772181338aa75c513dd837920ca9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1798382Reviewed-by:
-
Julie Jeongeun Kim authored
This CL converts SSLPrivateKeyPtr to new Mojo types. It updates ContinueWithCertificate from network_context.mojom and methods and members which use SSLPrivateKeyPtr with new mojo types. Bug: 955171, 978694 Change-Id: I7a97cc208aa1b6d354b8c5e82556f2fb0c929fda Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786376 Commit-Queue: Julie Kim <jkim@igalia.com> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#695576}
-
Denis Kuznetsov authored
This is a cleanup that removes unused "android" attribute: 1) cr_button does not support this attribute anymore, so it does not have sense to have it in oobe_buttons. 2) There is no code that uses this attribute for oobe dialogs, so it can be safely removed. android attribute was introduced to make sure Assistant buttons were looking android-like about 2 years ago. TBR=alemate@chromium.org Bug: 1000606 Change-Id: I97f1988de91c8945f915110c705e9cc2b83697e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789706 Commit-Queue: Denis Kuznetsov <antrim@chromium.org> Reviewed-by:
-
Fredrik Söderquist authored
Add this method, removing the two old IsFrozen() and PreviousIntervalBegin() to reduce API surface. Bug: 998526 Change-Id: I688dffc96cfe05462b81dbb3cbefad0d38ea00e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1795826 Commit-Queue: Fredrik Söderquist <fs@opera.com> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#695574}
-
Reilly Grant authored
This change renames the following interfaces and removes the [NoInterfaceObject] annotation so that these types are now exposed to script: Coordinates -> GeolocationCoordinates Position -> GeolocationPosition PositionError -> GeolocationPositionError This is done in response to an effort to remove this annotation from WebIDL. Spec pull requests (merged): https://github.com/w3c/geolocation-api/pull/20 https://github.com/w3c/geolocation-api/pull/23 Intent to Ship: https://groups.google.com/a/chromium.org/d/msg/blink-dev/Xig9oewsQMA/eyC7dbtiAAAJ Bug: 931847 Change-Id: I38d0172afc33d5757b664e2807356d8727e82d7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1471230 Commit-Queue: Reilly Grant <reillyg@chromium.org> Reviewed-by:
Yoav Weiss <yoavweiss@chromium.org> Cr-Commit-Position: refs/heads/master@{#695573}
-
Alexander Hendrich authored
(reland of https://crrev.com/c/1636350) This CL adds a new device policy to whitelist certain USB devices for certain urls in order to be used by the WebUSB API on the login screen. We already have a user policy for that, so this device policy reuses the existing user policy's infrastructure, but only affects the login screen (i.e. does not affect affiliated/non-affiliated user sessions). Bug: 1000270, 968373, 854329 Change-Id: I5abff8b7cca18650182af2dcfc63009cd9960f0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789392 Commit-Queue: Alexander Hendrich <hendrich@chromium.org> Reviewed-by:
Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#695572}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: Idf7dd4badb884c5a582da7b3cf3e425a44844f99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1797161Reviewed-by:
-
Kamila Śledź authored
The API for sending the redirect URL is specified by the .proto file. The endpoint is still passed in a command line switch. Bug: 984021 Change-Id: I38fae8c86a942eae91ba3be3ad4eaa95701748d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787322 Commit-Queue: Kamila Śledź <kamilasledz@google.com> Reviewed-by:
Denis Kuznetsov <antrim@chromium.org> Reviewed-by:
-
Manuel Rego Casasnovas authored
The behavior of percentage row tracks and gutters was updated long time ago (M70), but we never remove the deprecation message that was added before the change was shipped. That message is not useful anymore so we should remove it. The patch still keeps the use counter, as this behavior hasn't been updated on Firefox yet. So it's nice to keep the statistics of how many sites might be affected. Updated the test expectations to remove the deprecation message. BUG=846187 Change-Id: Ide2215b2c1527b87630a69dcc98cec27bc1963ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1796368Reviewed-by:
Javier Fernandez <jfernandez@igalia.com> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Commit-Queue: Manuel Rego <rego@igalia.com> Cr-Commit-Position: refs/heads/master@{#695569}
-
Olya Kalitova authored
Adds call from CrostiniAnsibleManagementService to Cicerone in order to start Ansible playbook application. TEST=unit_tests --gtest_filter="Crostini*" Bug: 1000287 Change-Id: I2424856aff05d9a9d908fbaada43525b40943edd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1782562 Commit-Queue: Olya Kalitova <okalitova@chromium.org> Reviewed-by:
Nicholas Verne <nverne@chromium.org> Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#695568}
-
Peter Kasting authored
Bug: 1000055 Change-Id: Ib0243d3de02c933546521c46ac20b97cbec3f88e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1793255 Auto-Submit: Peter Kasting <pkasting@chromium.org> Commit-Queue: Alexander Alekseev <alemate@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#695567}
-
Abhijeet Kandalkar authored
This CL has two goals, 1. Use DynamicTo<HTMLMeterElement> as new downcast helper 2. Use IsA<HTMLMeterElement>(element) in place of IsHTMLMeterElement(element) Bug: 891908 Change-Id: Ibd4d7866992b0ead69045e10af68d5faa4f36d0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1794365Reviewed-by:
-
Martin Robinson authored
Instead of calculating ATK hyperlink indices and constantly having to keep them up to date, always attempt to calculate them when queried via the API. This prevents them from ever being stale. Bug: 999631 Change-Id: I769c778baa513b52cc6a50d1b6d92b51594f4c09 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789590Reviewed-by:
Joanmarie Diggs <jdiggs@igalia.com> Commit-Queue: Martin Robinson <mrobinson@igalia.com> Cr-Commit-Position: refs/heads/master@{#695565}
-
Makoto Shimazu authored
This measures the performance for docs. Bug: 1002397 Change-Id: I15d38c9ed62057cea2471a1002bbcaa60a9de8aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1794723Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
-
Abhijeet Kandalkar authored
This CL has two goals, 1. Use DynamicTo<HTMLOListElement> as new downcast helper 2. Use IsA<HTMLOListElement>(element) in place of IsHTMLOListElement(element) Bug: 891908 Change-Id: Iee700b7dbe624b28bf202e0c01e21dfb906ec693 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1794443Reviewed-by:
-
Julie Jeongeun Kim authored
It updates CreateNetworkContext() from ContentBrowserClient and all methods and members which implements it. The unit tests which use NetworkContextPtr are converted to mojo::Remote or mojo::PendingRemote. Bug: 955171, 978694 Change-Id: I0df0f9fec0b70f2704d924c7b52a24127f21c373 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1784026 Commit-Queue: Julie Kim <jkim@igalia.com> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#695562}
-
Jan Krcal authored
This is a reland of 5a3884b6. The original patch has been reverted because it caused flakiness in ChromeLauncherControllerWithArcTest.Arc* tests. Since the real underlying issue 966561 has been fixed in the mean-time, it should be safe to reland. Original change's description: > [Sync] Use forwarding delegate for PRINTERS sync > > Printers sync runs on the UI thread but so far uses a proxy delegate > that posts tasks from UI thread to UI thread. > > This CL simplifies that and employs a forwarding delegate that runs > tasks synchronously. After this CL, all data types running on the UI > thread will have forwarding delegates. > > Bug: 867801 > Change-Id: I08e261323a9caa816899dd924f09ecdee69ec936 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1621907 > Commit-Queue: Jan Krcal <jkrcal@chromium.org> > Auto-Submit: Jan Krcal <jkrcal@chromium.org> > Reviewed-by: Mikel Astiz <mastiz@chromium.org> > Cr-Commit-Position: refs/heads/master@{#661732} TBR=mastiz@chromium.org Bug: 867801 Change-Id: I653d746337b860570447abdd74532b288161f203 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1796807Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Commit-Queue: Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#695561}
-
Himanshu Jaju authored
For Q and above, we don't open the dialer in any case. For N and below, we always open the dialer. If the device is locked then a notification is shown which is dismissed on unlock. For O and P, we open dialer if devices is unlocked. If the devices is locked then we don't open the dialer and keep the notification. Bug: 1002137 Change-Id: I81f4386439efe2b60b6b35a8bb8cdc7c59fb591c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1795766 Commit-Queue: Himanshu Jaju <himanshujaju@chromium.org> Reviewed-by:
Alex Chau <alexchau@chromium.org> Reviewed-by:
Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Cr-Commit-Position: refs/heads/master@{#695560}
-
Tanisha Mandre authored
- Fixed the QR code 'loadResultImmediately' boolean & result' receiver to use the superclass property value instead of duplicated instance variable. - Shifted the scanner transitioning delegate to the QR scanner view controller as it is not required in the superclass. Bug: 1000343 Change-Id: Id1d214e72df0cfd92111c56c04bcb22d37d731c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1791156 Commit-Queue: Tanisha Mandre <tanishamandre@google.com> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
-
Fredrik Söderquist authored
This state is fairly high maintenance and used only for frame scheduling and to check if updates need to be triggered for newly added timed elements. So get rid of it. (For now - it may reappear in the future but then more likely as part of the time container.) Also make a pass over arguments which passes the current presentation time, and rename it to that as well as using double rather than SMILTime. Bug: 998526 Change-Id: Icdb477ad86c349d0ddab5b9843b87dc186fd3b67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1795764 Commit-Queue: Fredrik Söderquist <fs@opera.com> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/df70582bd999..d10454e66ac1 Created with: gclient setdep -r src-internal@d10454e66ac1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I612c2b1c82cf493921b40e50626dfe152c44707c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1797157Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#695557}
-
Julie Jeongeun Kim authored
This CL converts ApplicationMediaCapabilitiesRequest and ApplicationMediaCapabilitiesPtr to new Mojo types. It uses ReceiverSet and PendingRemote or Remote instead of BindingSet and ApplicationMediaCapabilitiesPtr. Bug: 955171 Change-Id: I4b03e7bc1c4412e370d2fbd95d812a0ee53a08dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786705 Commit-Queue: Julie Kim <jkim@igalia.com> Reviewed-by:
-
Sigurd Schneider authored
This CL displays the duration of a network task in the timeline view as a sum, for example: 15.10 ms = 12.66 ms network access duration + 2.44 ms resource processing The 12.66 ms match what is displayed for the resource in the network tab, but only if the resource has been loaded by the renderer. The numbers are still wrong for navigation requests issued from the main thread, but this is because the back-end reporting is wrong. (To be fixed in a follow-up). Bug: chromium:865066 Change-Id: Id5e2aa71349836352a4bf62f9a0bb17e8c8b59be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764146 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Alexei Filippov <alph@chromium.org> Cr-Commit-Position: refs/heads/master@{#695555}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/050abd8dd5c4..c5f9c0682125 git log 050abd8dd5c4..c5f9c0682125 --date=short --no-merges --format='%ad %ae %s' 2019-09-11 khokhlov@google.com [Telemetry] Always serialize traces Created with: gclient setdep -r src/third_party/catapult@c5f9c0682125 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC oysteine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=oysteine@google.com Bug: chromium:981349 Change-Id: Iea64d0dbc517e81b8cb4a96b99f6f9cb8979b4ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1797156Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/55f663f5ddff..70767cba4254 git log 55f663f5ddff..70767cba4254 --date=short --no-merges --format='%ad %ae %s' 2019-09-11 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision d65ce76c..95ebb2b7 (695395:695497) Created with: gclient setdep -r src/third_party/webrtc@70767cba4254 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:None Change-Id: I99ffd71cd8c0dfa00deaa6df560f69da4397ae97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1797087Reviewed-by:
-
Henrique Ferreiro authored
As part of the Mojo migration, there was a remaining reference to mojo::ChildProcessRequest from the content/common/child_process.mojom interface. Bug: 955171 Change-Id: Ic79fdcecca3f4cce29be5f027992999731f69ab7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1796804Reviewed-by:
-
