- 23 Sep, 2016 40 commits
-
-
tedchoc authored
This change, http://crrev.com/2297193003, introduced a chrome specific InvalidationClientService, but it did not properly update all the appropriate references. This pulls the registered service from the AndroidManifest.xml if applicable. Does it through this indirection as components/ is unaware of chrome/. BUG=647774 Review-Url: https://codereview.chromium.org/2352943002 Cr-Commit-Position: refs/heads/master@{#420718}
-
rockot authored
It needs to be a public dependency as it's exposed by chrome/browser/ui/browser.h and uses generated code. BUG=649766 R=thakis@chromium.org TBR=ben@chromium.org Review-Url: https://codereview.chromium.org/2368633002 Cr-Commit-Position: refs/heads/master@{#420717}
-
clm authored
Review-Url: https://codereview.chromium.org/2361413002 Cr-Commit-Position: refs/heads/master@{#420716}
-
paulmeyer authored
This patch implements new find-in-page functionality that allows for frames that are either newly added or navigated during a find session to be automatically searched so that matches in their new content are automatically highlighted and included in the results shown in the find bar. Also, there is a fix included in this patch to prevent the find-in-page bar from closing when a subframe navigates (the find session should only end if the main frame navigates). Design doc: https://docs.google.com/document/d/1r4F19FIKg4zPJCaSyJ9-T0sgFbxlCGKL3FjqQEAKegg/view BUG=2220,621660 Review-Url: https://codereview.chromium.org/2236403004 Cr-Commit-Position: refs/heads/master@{#420715}
-
agrieve authored
This will give us an easy toggle for testing out obfuscation. BUG=620323 Review-Url: https://codereview.chromium.org/2369573002 Cr-Commit-Position: refs/heads/master@{#420714}
-
zmin authored
BUG=642059 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2351173004 Cr-Commit-Position: refs/heads/master@{#420713}
-
ekaramad authored
Currently, with the flag --use-cross-process-frames-for-guests switched on, MimeHandlerView still creates a BrowserPlugin while on the browser side we expect an OOPIF based implementation. This causes PDF viewer to crash. On the other hand, GuestViews will soon use OOPIF. Hence, temporarily, we need to make MimeHandlerView an exception and force it to use BrowserPlugin's codepath even when the switch above is turned on. BUG=563285 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation Review-Url: https://codereview.chromium.org/2165523004 Cr-Commit-Position: refs/heads/master@{#420712}
-
dmazzoni authored
It was using different time calls for the start time and current time. BUG=589632 Review-Url: https://codereview.chromium.org/2367693003 Cr-Commit-Position: refs/heads/master@{#420711}
-
skia-deps-roller authored
https://chromium.googlesource.com/skia.git/+log/cc0937273030..aa840647fc7f $ git log cc0937273..aa840647f --date=short --no-merges --format='%ad %ae %s' 2016-09-23 bsalomon Don't compute path keys for volatile paths in GrShape. 2016-09-23 csmartdalton Add Pixel C knobs to skpbench 2016-09-23 jvanverth Some Vulkan memory fixes and cleanup 2016-09-23 reed change SkXfermodeImageFilter to carry no impl information BUG=649562 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel TBR=borenet@google.com Review-Url: https://codereview.chromium.org/2367933002 Cr-Commit-Position: refs/heads/master@{#420710}
-
eroman authored
parse an entire Certificate. (Part of a series of changes for simplifying the parsing tests to be in terms of just certificates for consistent entry point and expectations) BUG=634443 Review-Url: https://codereview.chromium.org/2361233002 Cr-Commit-Position: refs/heads/master@{#420709}
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug (or complain) build: https://crrev.com/446c7dc4627650a1011b835c3e452ed2114f81df Add result_details as a log of nest step. (hzl@google.com) TBR=martiniss@chromium.org,phajdan.jr@chromium.org BUG=605572 Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Review-Url: https://codereview.chromium.org/2364183002 Cr-Commit-Position: refs/heads/master@{#420708}
-
alexclarke authored
The TimeDomain now only knows about the first wake up per queue and the system tries to only have one pending delayed DoWork posted on the base runloop. Because of this any cancelled delayed tasks get removed by TaskQueueImpl::WakeUpForDelayedWork before a wakeup is requested. TimeDomain has been changed to take advantage of this new limitation and several redundant methods have now been removed. The bug which caused the revert of V1 has been fixed, specifically ThrottlingHelper::PumpThrottledTasks doesn't get broken by the new assumptions since we're no longer using ClearExpiredWakeups. BUG=638542, 605718 Review-Url: https://codereview.chromium.org/2359493002 Cr-Commit-Position: refs/heads/master@{#420707}
-
kbr authored
BUG=639145, 649250 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel NOTRY=true Review-Url: https://codereview.chromium.org/2360353002 Cr-Commit-Position: refs/heads/master@{#420706}
-
brettw authored
This disables header checking for split static libraries. In addition to the internal issues discussed in the added comment to split_static_library.gni, there is a circular include cycle between //chrome/browser and //chrome/browser/ui. Both of these are split static libraries, so enabling check for this configuration would additionally require listing all of the split ui targets in the allow_circular_includes_from annotation in the browser target. Since this is only for official builds, we still get header checking on the normal builds so there should be no missing coverage for header checking. R=dpranke@chromium.org Review-Url: https://codereview.chromium.org/2363083003 Cr-Commit-Position: refs/heads/master@{#420705}
-
dcheng authored
This hook automatically installs and maintains a merge tool config for the clang-format merge driver, which can help automatically resolve conflicts that arise from clang-format reformatting patches. Note that this change does not have any impact other than tweaking the git config of the main project). The custom merge driver will later be activated by updating .gitattributes with lines like: *.cpp merge=clang-format *.h merge=clang-format BUG=574611 Review-Url: https://codereview.chromium.org/2359933005 Cr-Commit-Position: refs/heads/master@{#420704}
-
jbudorick authored
BUG=649693 Review-Url: https://codereview.chromium.org/2364083002 Cr-Commit-Position: refs/heads/master@{#420703}
-
tedchoc authored
Custom tab context menus worked previously because CustomTabActivity was in charge of creating the initial tab, and all subsequent tabs reuse the delegate of the parent tab. When restoring, the TabModelSelectorImpl via TabPersistentStore was creating the tabs and using the default logic in ChromeTabCreator. This change moves ChromeTabCreator creation to the activities themselves, which allows CCTs to overwrite the default tab delegate construction. This also moves the svelte tab saving logic to the selector, which is consistent with all other tab saving behavior (and allows the activity to be unaware of that dependency and enables creation w/ fewer params). BUG=649139 Review-Url: https://codereview.chromium.org/2359923005 Cr-Commit-Position: refs/heads/master@{#420702}
-
tommycli authored
Since the browsertest modifies the feature flags after browser startup, it can lead to inconsistent and unexpected behavior. This CL preserves the existing features flags. BUG=649783 Review-Url: https://codereview.chromium.org/2362383002 Cr-Commit-Position: refs/heads/master@{#420701}
-
dewittj authored
This check is implementation-dependent (and unused outside the model). As such it belongs only inside the offline page model. BUG=622763 Review-Url: https://codereview.chromium.org/2345133002 Cr-Commit-Position: refs/heads/master@{#420700}
-
jbudorick authored
BUG=634052 Review-Url: https://codereview.chromium.org/2366763003 Cr-Commit-Position: refs/heads/master@{#420699}
-
skym authored
pattern, and fixed lint violations. BUG=647875 Review-Url: https://codereview.chromium.org/2365763002 Cr-Commit-Position: refs/heads/master@{#420698}
-
John Abd-El-Malek authored
BUG=504347 R=scottmg@chromium.org Review URL: https://codereview.chromium.org/2368563003 . Cr-Commit-Position: refs/heads/master@{#420697}
-
kbr authored
BUG=none NOTRY=true Review-Url: https://codereview.chromium.org/2367493003 Cr-Commit-Position: refs/heads/master@{#420696}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/8358e322..12bdd904 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org Review-Url: https://codereview.chromium.org/2360343005 Cr-Commit-Position: refs/heads/master@{#420695}
-
robliao authored
BUG=637095 Review-Url: https://codereview.chromium.org/2360053002 Cr-Commit-Position: refs/heads/master@{#420694}
-
ellyjones authored
When the tab switches between allowed and blocked, cookie info from the previous tab should no longer be shown. BUG=649006 Review-Url: https://codereview.chromium.org/2361123002 Cr-Commit-Position: refs/heads/master@{#420693}
-
pauljensen authored
Chrome has eschewed ACCESS_WIFI_STATE permission so this code is disabled. Chrome is also the only user of this NetworkChangeNotifier signal so remove the code as it is consequently dead. BUG=647691 R=jkarlin Review-Url: https://codereview.chromium.org/2359173002 Cr-Commit-Position: refs/heads/master@{#420692}
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug (or complain) build: https://crrev.com/10c269e979170ea092fca73b154a7992a5f07374 Roll recipe dependencies (trivial). (recipe-roller@chromium.org) depot_tools: https://crrev.com/ff84560ede8fbc53160a760c0284c0234eaeeff1 Introduce git merge driver for the blink reformatting (dcheng@chromium.org) TBR=martiniss@chromium.org,phajdan.jr@chromium.org BUG=574611 Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Review-Url: https://codereview.chromium.org/2367053002 Cr-Commit-Position: refs/heads/master@{#420691}
-
avi authored
BUG=555865 Review-Url: https://codereview.chromium.org/2361953003 Cr-Commit-Position: refs/heads/master@{#420690}
-
bruthig authored
List of materialized rows: - IME - OS update - VPN - Accessibility - Rotation lock - Bluetooth - SMS - Tracing - Network BUG=638321, 632147, 632114, 632040, 632023, 632129, 632027 Review-Url: https://codereview.chromium.org/2365523002 Cr-Commit-Position: refs/heads/master@{#420689}
-
eroman authored
Review-Url: https://codereview.chromium.org/2366493003 Cr-Commit-Position: refs/heads/master@{#420688}
-
skia-deps-roller authored
https://chromium.googlesource.com/skia.git/+log/1cd88c4b759b..cc0937273030 $ git log 1cd88c4b7..cc0937273 --date=short --no-merges --format='%ad %ae %s' 2016-09-23 caryclark fix msan bug in pathops 2016-09-23 mtklein Include GLTestContext_command_buffer.cpp in G3 build. 2016-09-23 brianosman Revert of Create special surfaces according to original device (not always in N32) (patchset #9 id:160001 of https://codereview.chromium.org/2349373004/ ) CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel TBR=borenet@google.com Review-Url: https://codereview.chromium.org/2363113002 Cr-Commit-Position: refs/heads/master@{#420687}
-
bajones authored
BUG=389343 Review-Url: https://codereview.chromium.org/2367673002 Cr-Commit-Position: refs/heads/master@{#420686}
-
ericrk authored
When uploading an image, the DeferredTextureImageUsageParams should not have changed from initial sizing time. Somehow this can happen. This is not a correctness error, but a slight perf issue, as it will cause us to lazy generate mips as opposed to doing so asynchronously. We should fix this issue and re-add the DCHECKs to enforce this, but until we are able to, remove the DCHECK. BUG=649167 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel Review-Url: https://codereview.chromium.org/2361493005 Cr-Commit-Position: refs/heads/master@{#420685}
-
ellyjones authored
This is part 3 of removing non-material top chrome support. BUG=649368 Review-Url: https://codereview.chromium.org/2364933002 Cr-Commit-Position: refs/heads/master@{#420684}
-
xidachen authored
When this test: pixel_offscreenCanvas_webgl_commit_worker.html was added, the generated reference image is a blank image which is incorrect. Now we have fixed the problem, the reference image needs to be updated. So this CL increment the revision number for the test by 1. This CL also updates the test by post an empty message back from worker-->main thread. BUG=563852 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2359263002 Cr-Commit-Position: refs/heads/master@{#420683}
-
hayesjordan authored
Implement the RegisterListener, UnregisterListener, and notify methods in an abstract class so that all Physical Web data sources can have an the ability to push data to subscribers. BUG=636490 Review-Url: https://codereview.chromium.org/2349483002 Cr-Commit-Position: refs/heads/master@{#420682}
-
agrieve authored
This cuts down the sub-project count from 390->280. But Android Studio still runs out of memory (at least with default max heap settings). BUG=620034 Review-Url: https://codereview.chromium.org/2364063002 Cr-Commit-Position: refs/heads/master@{#420681}
-
jbroman authored
Convert String and AtomicString specializations, which are trivially converted to StringView, to inherit from it as well. Add one site which uses the StringView specialization. Review-Url: https://codereview.chromium.org/2359663002 Cr-Commit-Position: refs/heads/master@{#420680}
-
braveyao authored
The capture part has been landed in cl https://codereview.chromium.org/2125973002/. This cl is to implement the control part in chrome/ and content/. The document is here, https://goo.gl/QNH29g. This cl proposes a pemission design on Android, including permission info bar and head up notification, which will show up each time at starting screen capture and user can check/stop the capture without leaving current page. And all of these is behind a flag as an experimental feature. BUG=487935 Review-Url: https://codereview.chromium.org/2123863004 Cr-Commit-Position: refs/heads/master@{#420679}
-