- 21 Jul, 2017 40 commits
-
-
Ryan Sleevi authored
This was merely a documentation issue; the actual CA was included within the //net/data/ssl/symantec/excluded directory, and properly excluded by //net/http/transport_security_state_ct_policies.inc, but the README file unintentionally omitted it. BUG=none R=davidben@chromium.org Change-Id: I62426618cfa58ad392a94999c4db71f22f70b1c3 Reviewed-on: https://chromium-review.googlesource.com/569003 Commit-Queue: Ryan Sleevi <rsleevi@chromium.org> Reviewed-by:
David Benjamin <davidben@chromium.org> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Cr-Commit-Position: refs/heads/master@{#488714}
-
Geoff Lang authored
R=kbr@chromium.org BUG=710673 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I323c5c020f62e4d388a5cae547b93887fc375640 Reviewed-on: https://chromium-review.googlesource.com/581348Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org> Cr-Commit-Position: refs/heads/master@{#488713}
-
Dianna Hu authored
Now that the flags protecting jamessynge@'s HTTP2FrameDecoder have been deprecated, we can begin cleaning up the old code. Next step is probably to try to start sorting out the adapters. This CL lands server change 162220378 by dahollings. BUG=488484 Change-Id: I875f5a6448dc9c0bc765f62a5b6424510dc6ff6a Reviewed-on: https://chromium-review.googlesource.com/581389Reviewed-by:
Bence Béky <bnc@chromium.org> Commit-Queue: Dianna Hu <diannahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#488712}
-
Yuwei Huang authored
Add i18n support for the host setup view. Also add missing strings in the settings menu. Bug: 747091 Change-Id: Ideea85dc2d0d9933e39bfe9c6e9a1b00a190291c Reviewed-on: https://chromium-review.googlesource.com/580729Reviewed-by:
Scott Nichols <nicholss@chromium.org> Commit-Queue: Yuwei Huang <yuweih@chromium.org> Cr-Commit-Position: refs/heads/master@{#488711}
-
Gregory Chatzinoff authored
Create a MetricsRecorder protocol that allows implementors to record a metric for a given NSInvocation. Objects implementing this protocol will be able to register with the dispatcher to be called when a relevant selector is invoked on the dispatcher. Bug: none Change-Id: Icb0074f6d3857ea9b7c0043c052e5e35dc6598ec Reviewed-on: https://chromium-review.googlesource.com/578305Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Gregory Chatzinoff <gchatz@chromium.org> Cr-Commit-Position: refs/heads/master@{#488710}
-
Dongseong Hwang authored
minigbm doesn't allow to pass no flags to gbm_bo_create(). GBM_BO_USE_TEXTURING implies texture, so use GBM_BO_USE_TEXTURING to create texture buffer. GBM_BO_USE_TEXTURING implies GPU_READ. GBM_BO_USE_RENDERING implies GPU_WRITE. BufferUsage::SCANOUT needs both of them because it implies GPU_READ_WRITE. TEST=run chrome on amd64-generic BUG=683347 Change-Id: I7431be6f5b4a8d95e6be11d86cfbf0c14b919668 Reviewed-on: https://chromium-review.googlesource.com/549095Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
David Reveman <reveman@chromium.org> Reviewed-by:
Stéphane Marchesin <marcheu@chromium.org> Reviewed-by:
Dongseong Hwang <dongseong.hwang@intel.com> Commit-Queue: Dongseong Hwang <dongseong.hwang@intel.com> Cr-Commit-Position: refs/heads/master@{#488709}
-
Ian Vollick authored
The animation machinery in cc/animation currently makes unfortunate assumptions about the meaning of the animations it processes. For example, if you're animating an SkColor, it must be the background color. You couldn't also animate your foreground color. This coupling also prevents the system from being extended for use with things like custom properties. With this change, the animation machinery only treats interpolated types (eg, SkColor, FilterOperations, etc) distictly, and lets the target property be a generic annotation that is the business of client of the animation system. Bug: 747185 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel Change-Id: Idb3baf159c3da8531d75c7c8ba0a159fac197d48 Reviewed-on: https://chromium-review.googlesource.com/580608 Commit-Queue: Ian Vollick <vollick@chromium.org> Reviewed-by:
Ali Juma <ajuma@chromium.org> Cr-Commit-Position: refs/heads/master@{#488708}
-
Justin Schuh authored
Adds a compiler warning that works in all compilation modes on Clang/GCC, and in Prefast on MSVC. The rationale is all other value-extracting CheckedNumeric<> functions already prevent the caller from ignoring the validity state, but without this change calling AssignIfValid() could silently ignore an invalid state. Change-Id: I7e16f3cf7f026151ef39215bfe01c05e7c58b32f Reviewed-on: https://chromium-review.googlesource.com/580296Reviewed-by:
Erik Chen <erikchen@chromium.org> Commit-Queue: Justin Schuh <jschuh@chromium.org> Cr-Commit-Position: refs/heads/master@{#488707}
-
Michael Nordman authored
This reverts commit bb3210d3. Speculative revert for crbug/744550 Bug: 744550 Change-Id: I0b8a2464c2932d00349d3fd9a80ba7595c929ff7 TBR=mark,rsesek Change-Id: I0b8a2464c2932d00349d3fd9a80ba7595c929ff7 Reviewed-on: https://chromium-review.googlesource.com/580639Reviewed-by:
Michael Nordman <michaeln@chromium.org> Commit-Queue: Michael Nordman <michaeln@chromium.org> Cr-Commit-Position: refs/heads/master@{#488706}
-
khmel authored
This prevents appearing default Play Store icon on the shelf for AOSP images. Test: Unit test + manually Bug: b/36133646 Change-Id: I90d05513d98c57a7ec514b66a8b468255434e841 Reviewed-on: https://chromium-review.googlesource.com/580646Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Yury Khmel <khmel@google.com> Cr-Commit-Position: refs/heads/master@{#488705}
-
Zhen Wang authored
Add timeout to force load the next background tab after the timer expires. Bug: 730098 Change-Id: I6cbb26288a02fdd61ece85e42c3106fa8e20a33b Reviewed-on: https://chromium-review.googlesource.com/580188Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Commit-Queue: Zhen Wang <zhenw@chromium.org> Cr-Commit-Position: refs/heads/master@{#488704}
-
Matt Wolenetz authored
Since M56, all Chrome build types that include proprietary codecs and use the unified media pipeline have been able to demux and decode FLAC-in-MP4, but canPlayType() hasn't been updated yet. Further motivation to update that, a prerequisite for supporting FLAC-in-MP4 with MSE in Chrome is that canPlayType('{audio,video}/mp4, "flac"') needs to return "probably". This change updates canPlayType() to indicate FLAC-in-MP4 is supported, and includes new tests for src= FLAC-in-MP4. A further complication is that MP4's AudioSampleEntry samplerate field is fixed point 16.16 bits, so lacks range to handle bitrates above 65535Hz. The FLAC-in-MP4 spec [1] guides how to encode the correct sample rate when it is outside this scale, and this change includes test files at both 44.1kHz and 192kHz to verify FFmpegDemuxer extracts the correct samplerate information. Also, based on investigation leading to https://crbug.com/747050#c3, this change includes a comment indicating lack of decode support for *encrypted* FLAC (in any container) on Android (which would need FLAC decode support directly in MediaCodec, rather than in MediaExtractor as some devices appear to do). In the future, perhaps more refined logic can be used to identify cases where encrypted FLAC-in-MP4 on Android is supported by the device. BUG=666000,747050 TEST=Added sfx-flac.mp4 FFmpeg AudioDecoderTest cases, basic media playback browsertests for bear-flac.mp4 and bear-flac-192kHz.mp4, FFmpegDemuxerTests, PipelineIntegrationPerfTests, and a PipelineIntegrationTest; Updated MediaCanPlayTypeTests and MimeUtilTest.ParseAudioCodecString; Change-Id: I04df11c34aa539c53dd2c8868257f7ef9608ddc7 Reviewed-on: https://chromium-review.googlesource.com/580575Reviewed-by:Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org> Cr-Commit-Position: refs/heads/master@{#488703}
-
Kinuko Yasuda authored
Add some more code from ServiceWorkerContextRequestHandler to ScriptURLLoaderFactory. Also added small cleanup around IsInstalled. Re-land of: https://chromium-review.googlesource.com/544720 and https://chromium-review.googlesource.com/547160 Bug: 715640 Change-Id: Iae432fb2619d1a3b05ba26cbce7563b93e86339d Reviewed-on: https://chromium-review.googlesource.com/579030 Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#488702}
-
Bruce Dawson authored
https://chromium.googlesource.com/external/gyp.git/+log/eb296f67da07..d61a9397e668 $ git log eb296f67d..d61a9397e --date=short --no-merges --format='%ad %ae %s' 2017-06-27 mblsha mac_tool.py: Handle non-zero ibtool return code. 2017-04-25 refack win: mkdir even when copying directory 2017-04-24 mark win ninja/make: Always use a native compiler executable with MSVS 2017 2017-04-24 mark Fix MSVC++ 32-on-32 builds after b62d04ff85e6 2017-04-24 dpranke Disable flaky test/copies/gyptest-all under msvs. 2017-04-24 refack win,ninja: ninja generator better on windows 2017-04-24 dpranke Clean up gyptest.py. 2017-04-21 dpranke Disable a bunch of tests on Mac. 2017-04-18 dpranke Update test/no-cpp/gyptest-no-cpp. In order to support building clang with a locally installed copy of VC++ 2017 using gn we need the latest version of tools\gyp. BUG=683729 Change-Id: Id3420b00667f89b7eb33aa2227f2e8fdb8de180d Reviewed-on: https://chromium-review.googlesource.com/579892 Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#488701}
-
gogerald authored
Bug: 740257 Change-Id: Ib4b52311d30a663695f18ca6140b74531cb0d583 Reviewed-on: https://chromium-review.googlesource.com/581734Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Ganggui Tang <gogerald@chromium.org> Cr-Commit-Position: refs/heads/master@{#488700}
-
Matt Mueller authored
Bug: none Change-Id: I862fc5904a46ec51dcabe0df403b2e5c07169060 Reviewed-on: https://chromium-review.googlesource.com/574680 Commit-Queue: Ryan Sleevi <rsleevi@chromium.org> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Cr-Commit-Position: refs/heads/master@{#488699}
-
Paweł Hajdan, Jr authored
This will help Linux distro packagers use system toolchain. See included README file for context. Bug: none Change-Id: I82a5d34ab179b5f1ab1e0cbd12c51c3871ae876c Reviewed-on: https://chromium-review.googlesource.com/575984Reviewed-by:
Brett Wilson <brettw@chromium.org> Cr-Commit-Position: refs/heads/master@{#488698}
-
Jiaquan He authored
Voice queries just simply close the launcher. We don't need voice queries for Play Store app search. Bug=736027 Change-Id: Ic34c45ad105c20598b6fc4bcb345883f55ccc012 Reviewed-on: https://chromium-review.googlesource.com/579958Reviewed-by:
Yury Khmel <khmel@chromium.org> Commit-Queue: Jiaquan He <hejq@google.com> Cr-Commit-Position: refs/heads/master@{#488697}
-
Collin Baker authored
Adds methods to SnapshotController and SnapshotController::Client for the renovation framework. Also adds basic implementations to all SnapshotController::Client implementors. This doesn't change the behavior of the SnapshotController yet. Design doc: https://docs.google.com/document/d/1WuwRJaxBKAwVpeAHG0xhq5uRxMTB-j4LFleT4QEqANU Bug: 736933 Change-Id: Iee15c54fa4524b1c09a87f6e6c43a8df8ea630ee Reviewed-on: https://chromium-review.googlesource.com/580692Reviewed-by:
Peter Williamson <petewil@chromium.org> Reviewed-by:
Dmitry Titov <dimich@chromium.org> Reviewed-by:
Yafei Duan <romax@chromium.org> Commit-Queue: Collin Baker <collinbaker@google.com> Cr-Commit-Position: refs/heads/master@{#488696}
-
Sean Kau authored
Native CUPS has been turned on since M59 and it has settled well. The flag to turn it off is being removed. Also clean up code that is now extraneous. Bug: 733793 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I351790c7f8f0a486743e190355af7922b0105676 Reviewed-on: https://chromium-review.googlesource.com/575829Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Sean Kau <skau@chromium.org> Cr-Commit-Position: refs/heads/master@{#488695}
-
hkamila authored
Implemented the webui protobuf that will collect information about the database status as size, update, stores, and more. Bug: 734667 Change-Id: If920b7c3d90b7e6dfd24c0256b3042900737d7a5 Reviewed-on: https://chromium-review.googlesource.com/578384 Commit-Queue: Kamila Hasanbega <hkamila@google.com> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Reviewed-by:
Luke Z <lpz@chromium.org> Cr-Commit-Position: refs/heads/master@{#488694}
-
Nick Ward authored
Bug: Change-Id: I70fd0185bdf539a8e624bde60feb2df2ee1e02ed Reviewed-on: https://chromium-review.googlesource.com/550870Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Nick Ward <npward@google.com> Cr-Commit-Position: refs/heads/master@{#488693}
-
Nektarios Paisios authored
This results reading "blank" in some cases, when in fact the line contains text. R=dmazzoni@chromium.org TESTED=Manually using Jaws, existing unit tests Bug: 731067 Change-Id: I3c74e7c42a5178b5900df12e361e61cce318f0dc Reviewed-on: https://chromium-review.googlesource.com/575684 Commit-Queue: Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#488692}
-
Sigurdur Asgeirsson authored
R=robliao@chromium.org TBR=thakis@chromium.org Change-Id: I7e4c530b89f6c21f0197b7b7db2ec3046b45732b Reviewed-on: https://chromium-review.googlesource.com/581736 Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#488691}
-
Kenichi Ishibashi authored
The "PROP" pattern match checks and other checks except for "TREE" are currently broken and it's somewhat difficult to make them workable. It would be easier to check AST nodes directly. This CL drops "PROP" checks and adds some unittests. Follow-up CLs will remove other checks except for "TREE". BUG=617899 Change-Id: Ifb7041ab971fc584b0a43e8ce465e2e30905f9d4 Reviewed-on: https://chromium-review.googlesource.com/581129Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#488690}
-
Alex Zhang authored
To plumb RendererSettings through between browser and viz, we need struct traits for it and its members. ResourceSettings is a member of RendererSettings. This CL adds struct traits for ResourceSettings and a unit test for the struct traits. Bug: 732825 Change-Id: I03010130b3614cc316f6fc234dea4b5bfbf3fbf5 Reviewed-on: https://chromium-review.googlesource.com/575209Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Xingyu Zhang <staraz@chromium.org> Cr-Commit-Position: refs/heads/master@{#488689}
-
Vladislav Kaznacheev authored
Add a new "highlighter" tool using the same fast rendering method as laser pointer (CL extracting the common base class is to follow). Bug: b:63142451 Change-Id: Id848b77f08ae95c167c527a07aec6ccdf79f49f4 Reviewed-on: https://chromium-review.googlesource.com/558467 Commit-Queue: Vladislav Kaznacheev <kaznacheev@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Luis Hector Chavez <lhchavez@chromium.org> Reviewed-by:
David Reveman <reveman@chromium.org> Reviewed-by:
Jacob Dufault <jdufault@chromium.org> Cr-Commit-Position: refs/heads/master@{#488688}
-
Sidney San Martín authored
Bug: 741478 Change-Id: I7b576273b0e7ec08af24291115db1c8e8f9b3da8 Reviewed-on: https://chromium-review.googlesource.com/581232Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Sarah Chan <spqchan@chromium.org> Commit-Queue: Sidney San Martin <sdy@chromium.org> Cr-Commit-Position: refs/heads/master@{#488687}
-
Ojan Vafai authored
This reverts commit 83622231. Reason for revert: Caused test failures on https://build.chromium.org/p/chromium.linux/builders/Android%20Tests%20%28dbg%29/builds/44157 org.chromium.chrome.browser.photo_picker.PhotoPickerDialogTest#testSingleSelectionPhoto org.chromium.chrome.browser.photo_picker.PhotoPickerDialogTest#testMultiSelectionPhoto org.chromium.chrome.browser.photo_picker.PhotoPickerDialogTest#testNoSelection Original change's description: > Enable the seccomp-bpf sandbox for the Android photo picker > > This CL attempts to enable the seccomp-bpf sandbox, as we do for > renderer processes on Android, for the new photo picker when it is > supported by the device. > > The implementation loads the native library as if it's a Chrome child > process, and then calls the native InitializePhotoPickerSandbox function > to initialize the sandbox when available. UMA is logged. > > Because we end up loading the native library, this does create for an > additional delay of ~700ms before the first photo is shown. There may be > optimization opportunities by separating out the sandbox code in a separate > shared library, but this is made difficult by (a) our build system using > the crazy linker, and (b) the dependencies of //sandbox on //base. > > I've verified that the sandbox is enabled on two devices running > different versions of Android, both by printing the status of the > SeccompStarterAndroid, and through the following command: > > $ adb shell cat /proc/18424/status | grep Seccomp > Seccomp: 2 > > (Where "2" means that seccomp-bpf is enabled.) > > BUG=730066 > > Change-Id: I46e608bad8f69d3cf862c0953361c50f4c65c45c > Reviewed-on: https://chromium-review.googlesource.com/577853 > Reviewed-by: David Trainor <dtrainor@chromium.org> > Reviewed-by: Jorge Lucangeli Obes <jorgelo@chromium.org> > Reviewed-by: Bo Liu <boliu@chromium.org> > Reviewed-by: Ilya Sherman <isherman@chromium.org> > Commit-Queue: Peter Beverloo <peter@chromium.org> > Cr-Commit-Position: refs/heads/master@{#488643} TBR=jorgelo@chromium.org,peter@chromium.org,isherman@chromium.org,boliu@chromium.org,dtrainor@chromium.org,twellington@chromium.org Change-Id: I2b0d24e90ce50bf2bc913cc7219f48475a34bbda No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 730066 Reviewed-on: https://chromium-review.googlesource.com/581628Reviewed-by:
Ojan Vafai <ojan@chromium.org> Commit-Queue: Ojan Vafai <ojan@chromium.org> Cr-Commit-Position: refs/heads/master@{#488686}
-
Ojan Vafai authored
The non-virtual test is already listed as failing. Mark the virtual one as failing as well. Also, make them both only debug since it passes on release builds. BUG=746128 TBR=johnme@chromium.org Change-Id: I840dc81c2c0434f88974d4a3ff95c3dad79ec43f Reviewed-on: https://chromium-review.googlesource.com/581416Reviewed-by:
Ojan Vafai <ojan@chromium.org> Reviewed-by:
John Mellor <johnme@chromium.org> Commit-Queue: Ojan Vafai <ojan@chromium.org> Cr-Commit-Position: refs/heads/master@{#488685}
-
nednguyen authored
This benchmark is broken, and benchmark owner no longer works on the Chromium project. Bug: 747000 Change-Id: Ideddacfdf10b4628eb660eb37bee270d4f339020 Reviewed-on: https://chromium-review.googlesource.com/581417Reviewed-by:
Annie Sullivan <sullivan@chromium.org> Commit-Queue: Annie Sullivan <sullivan@chromium.org> Cr-Commit-Position: refs/heads/master@{#488684}
-
Tommy C. Li authored
We've already removed access to this feature from chrome://flags. This just removes the now-dead implementing code. Bug: 709550 Change-Id: I21cd2516874722525c2ddab4a2ab0840e46d38c4 Reviewed-on: https://chromium-review.googlesource.com/580363Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#488683}
-
catapult-deps-roller@chromium.org authored
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/3668235f8a91..950ede098bcd $ git log 3668235f8..950ede098 --date=short --no-merges --format='%ad %ae %s' 2017-07-21 loloangela Fixed errors related to bad-continuation Created with: roll-dep src/third_party/catapult Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: If118eb016db294f7efa8fb1c151f01d9b5d5b23b Reviewed-on: https://chromium-review.googlesource.com/581411 Reviewed-by: <catapult-deps-roller@chromium.org> Commit-Queue: <catapult-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#488682}
-
mark a. foltz authored
- Adds UseCounters to count presentations started on secure/insecure origins. - Logs a deprecation warning only when presentations are started, because of the warning frequency on PresentationRequest constructor or getAvailability. Blink-dev thread: https://groups.google.com/a/chromium.org/d/topic/blink-dev/lumj0lVdtHA/discussion Bug: 733381 Change-Id: I4352b2b9d3e887ade122bb8efb6e9a8efcbfd874 Reviewed-on: https://chromium-review.googlesource.com/578687 Commit-Queue: mark a. foltz <mfoltz@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#488681}
-
Alexander Semashko authored
I observed the use after free in WebContentsImplTest.LoadResourceWithEmptySecurityInfo. It was triggered by some downstream code that is not present in chromium, but the root cause is that the test sets ContentBrowserClient that is destroyed at the end of the test body. This CL extends the lifetime of this object in WebContentsImplTest. Bug: Change-Id: I8d6b553a20b497c346b47aeb043dedcd84e94abb Reviewed-on: https://chromium-review.googlesource.com/563380Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Alexander Semashko <ahest@yandex-team.ru> Cr-Commit-Position: refs/heads/master@{#488680}
-
Lucas Garron authored
rus-trip.ru: > [love.rus-trip.ru] - This subdomain of the affiliate program, it was not > planned to https brztec.com: > now this domains will host only static pages from blogspot and blogspot > doesn't support HTTPS when using personalized domains. supinbot.ovh: > I mistakenly enabled HSTS preloading a while back but I frequently have to > test new HTTP services that do not support HTTPS. enterprise-threat-monitor.com: > www.enterprise-threat-monitor.com - too many issues at enterprise customers pixelneat.com: > we added testing HSTS header by mistake and browsers already cached. We did > not have a problem until letsencrypt SSL has been reloaded, so encryption keys > are not the same which have browsers. fumo.se: > I have mistakenly used "includesubdomain and preload" which was not intended. pepchid.com: > I decide to use the new domain yilanju.com and set pepchid.com skip to the new > one, so I request you for the removal. xliu.cf: > The reason is that my registration for this domain name has expired, and the > provider Freenom is now reselling the domain. inspy.me: > The CA that issued my certificate (WoSign) became untrusted. And even though I > have shut my project down I think it is still a good idea to remove it from > HSTS preload list. graysonsmith.co.uk: > The domain is being transferred to a new company and they do not yet have SSL > set up on their servers. Bug: 527947 Change-Id: Ic69a2aa871995041ec13cbe95ba65405a361c874 TBR=palmer@chromium.org Change-Id: Ic69a2aa871995041ec13cbe95ba65405a361c874 Reviewed-on: https://chromium-review.googlesource.com/565801Reviewed-by:
Lucas Garron <lgarron@chromium.org> Commit-Queue: Lucas Garron <lgarron@chromium.org> Cr-Commit-Position: refs/heads/master@{#488679}
-
Adrienne Walker authored
This adds serialization/deserialization/testing for most of the internals of PaintFlags. SkValidatingSerializeFlattenable is used for more complex Skia objects. Still remaining to be handled are PaintShader and SkTypeface. Additionally, SkValidatingSerializeFlattenable ignores SkPictureImageFilters for security purposes and so these will have to be handled in some other manner in the future. This serialization is not yet called while running Chrome yet. This is all for testing purposes at this point. Bug: 737629 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ic1787721e7518367dca0c40f7a6a438bca980701 Reviewed-on: https://chromium-review.googlesource.com/578321Reviewed-by:
Vladimir Levin <vmpstr@chromium.org> Commit-Queue: enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#488678}
-
spqchan authored
The animated App Menu Icon is misaligned by 1pt on non-retina screens. To fix this, the icon needs to be translated by 0.5pt. Bug: 704786 Change-Id: Ida9155be424eb9ea46acb6f6ae41d245de3ae28c Reviewed-on: https://chromium-review.googlesource.com/580694Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Sarah Chan <spqchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#488677}
-
Gabriel Charette authored
{} initialization of LAZY_TASK_RUNNERs doesn't work when providing multiple traits. Update documentation to suggest explicit TaskTraits initialization. R=robliao@chromium.org Bug: 730170 Change-Id: Icbd93f47f9d3f36c344ea892ed4b7e11b00becd3 Reviewed-on: https://chromium-review.googlesource.com/580531Reviewed-by:Robert Liao <robliao@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#488676}
-
Christos Froussios authored
OSCrypt only needs to read from the backend during its initialisation. Instances created for this initialisation can be cleaned up afterwards. To support this change, the mocking of OSCrypt can no longer be based on a singleton. Tests using the mocking mechanism are updated. Bug: 709096 Change-Id: Iba5b37ad45ada11b9a217dc2c388313f2371f647 Reviewed-on: https://chromium-review.googlesource.com/571221Reviewed-by:
Roger Tawa <rogerta@chromium.org> Reviewed-by:
Mathieu Perreault <mathp@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Reviewed-by:
Pavel Yatsuk <pavely@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Christos Froussios <cfroussios@chromium.org> Cr-Commit-Position: refs/heads/master@{#488675}
-