- 09 Dec, 2020 40 commits
-
-
Thiemo Nagel authored
This reverts commit dc4eea24. Reason for revert: It looks like this is causing test failures --> https://ci.chromium.org/ui/p/chromium/builders/ci/linux-chromeos-dbg/21664/ Original change's description: > [Nearby] Update subpage visibility text and fix dialog a11y. > > Update device visibility button text in Nearby settings subpage. > Fix 'try again' link a11y in Nearby settings subpage dialog so > that the entire message is read out by ChromeVox when the link > is focused, rather than just the text of the link. > > Fixed: 1154718, 1156777 > Change-Id: I6594bcef97263e1f529112d1d9d5779fa66436a4 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575885 > Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> > Reviewed-by: James Vecore <vecore@google.com> > Commit-Queue: Gordon Seto <gordonseto@google.com> > Cr-Commit-Position: refs/heads/master@{#834958} TBR=khorimoto@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com,vecore@google.com,cclem@google.com,gordonseto@google.com Change-Id: Iee79682f082d42878209035b1a2802bbbe12a1ac No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2581482Reviewed-by:
Thiemo Nagel <tnagel@chromium.org> Commit-Queue: Thiemo Nagel <tnagel@chromium.org> Cr-Commit-Position: refs/heads/master@{#835146}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/c6b219431a16..b5c844554e30 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: If68e5d26195bff27bbc952b363a1a0c77140a59b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2581442Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#835145}
-
Koji Ishii authored
This patch turns some DCHECKs in |NGOffsetMapping| to CHECKs when it could lead to out-of-bounds access. |NGOffsetMapping| uses |std::prev| or |std::next| after checking the pointer by DCHECKs. If these DCHECKs fail, |std::prev| or |std::next| will read out-of-bounds. Turning them to CHECKs will turn such cases into crashes. Bug: 1156988 Change-Id: I574ffd38636861c7d7aa9985d4a43852aabcbbc4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2579933Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#835144}
-
rbpotter authored
R=dpapad@chromium.org Bug: None Change-Id: I6e20db96c8c8a831ff6c624765a6a078a06e22fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2578704 Commit-Queue: dpapad <dpapad@chromium.org> Auto-Submit: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#835143}
-
Mihai Sardarescu authored
The usage of PrimaryAccountManager::SignOut() was removed in CL https://chromium-review.googlesource.com/c/chromium/src/+/2573082, so it is now obsolete. Bug: 1155505 Change-Id: Ic6a67ab7a37f00d64c5a22f322a0ee1d08c7f9c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2574859Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#835142}
-
Jan Wilken Dörrie authored
This change replaces usages of Blacklist with Blocklist in components/password_manager/core/browser/android_affiliation and components/password_manager/core/browser/sync. Bug: 1147799 Change-Id: I3f186a860288b3e25607b65bdfde40d1b5ce15f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2579792Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#835141}
-
Ilya Nikolaevskiy authored
Bug: chromium:1155063 Change-Id: Ib9180912321b8f5e0d49f8e1cfbda53c47ee0222 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577219 Auto-Submit: Ilya Nikolaevskiy <ilnik@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#835140}
-
Alex Ilin authored
Screen readers should read the profile name when a profile card is focused. The label could be improved in the future to say something like "open a new browser for [ProfileName]". This CL is kept simple to be merge-able in the beta branch. Bug: 1156065 Change-Id: I634c8df6662dd4926b25deb231b1b8332ea80082 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2579843Reviewed-by:
Monica Basta <msalama@chromium.org> Commit-Queue: Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#835139}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/34717e17dce2..1edfa2693a5b 2020-12-09 szuend@chromium.org Leave TODOs on all use-sites of legacy ReportView widget 2020-12-09 bmeurer@chromium.org [debugger] Log timings of language extension plugin methods. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1083146,chromium:1156978 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I313766d6627fdf401891bfe91fa8c3d8ef48db3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2581208Reviewed-by:
-
Alex Ilin authored
This refactor removes dependency on UserManagerView from UserManagerProfileDialogDelegate. This will allow the ProfilePickerView to host a UserManagerProfileDialog as well. The dependency is removed by introducing a new UserManagerProfileDialogHostBase class that also holds common logic for managing dialogs. ProfilePickerView is going to add UserManagerProfileDialogHostBase as a base class in a follow-up CL. Bug: 1156096 Change-Id: Ib9e2a4e5c0c4060c96ab083aca1af71706a25e61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575024 Commit-Queue: Alex Ilin <alexilin@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ea80f524f61b..516d20deb974 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC tnagel@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: tnagel@google.com Change-Id: I956ced19ab25d10bd29e03e12605cde0e4850129 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580234Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#835136}
-
Ben Wagner aka dogben authored
This reverts commit 9c270678. Reason for revert: mbonadei noticed error when running Original change's description: > Mark some WebRTC perf measurements as biggerIsBetter > > Change-Id: I95a145f0380b0f413a71ef5a9bbacf840eb20b9f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577205 > Commit-Queue: John Chen <johnchen@chromium.org> > Auto-Submit: Ben Wagner aka dogben <benjaminwagner@google.com> > Reviewed-by: Mirko Bonadei <mbonadei@chromium.org> > Reviewed-by: John Chen <johnchen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#834889} TBR=mbonadei@chromium.org,johnchen@chromium.org,benjaminwagner@google.com,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com Change-Id: I4f90ecb003407c3737442f0a5d4ca691c4d12dbc No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580527Reviewed-by:
Mirko Bonadei <mbonadei@chromium.org> Commit-Queue: Ben Wagner aka dogben <benjaminwagner@google.com> Cr-Commit-Position: refs/heads/master@{#835135}
-
Internal Frameworks Autoroller authored
TBR=bling-team@google.com Change-Id: Ifa35fbd636d14dcc2e929c30c55f69151e2df503 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2581459Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#835134}
-
Thiemo Nagel authored
This reverts commit f0946b3e. Reason for revert: This seems to have caused failures on Linux Tests (dbg)(1) in virtual/composite-bgcolor-animation/external/wpt/css/css-backgrounds/border-radius-clip-002.htm https://ci.chromium.org/p/chromium/builders/ci/Linux%20Tests%20%28dbg%29%281%29 Original change's description: > Create compositor animation for background-color > > This CL is the first step of the background-color animation using > off-thread paint worklet infrastructure. The design doc is here: > https://docs.google.com/document/d/1usCnwWs8HsH5FU_185q6MsrZehFmpl5QgbbB4pvHIjI/edit > > In particular, this CL just make sure that we are able to create a > compositor animation for background-color. Then the compositor > thread ticks the animation and dispatches the paint job to > the worker thread to paint. > > In the actual paint, we do hard code the result, which means > there is no interpolation implementation at this moment. We > will implement the interpolation logic in a coming CL. > > Bug: 1139008, 1148369 > Change-Id: I9d2aba2106f38f89bce0e97df29fa0d4f30b2c76 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2549530 > Reviewed-by: Robert Flack <flackr@chromium.org> > Commit-Queue: Xida Chen <xidachen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#834886} TBR=flackr@chromium.org,xidachen@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com Change-Id: Ifd586ed57f8922e0e1e5cf1c8337a29110b6e8ba No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1139008 Bug: 1148369 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580341Reviewed-by:
-
Polina Bondarenko authored
Add SnapshotSessionController to control MGS with loaded ARC data snapshot and ARC data snapshot update flow. Consider MGS as failed if not 100% of required ARC apps are installed in 5 mins. BUG=b:161221001 TEST=components_unittests TEST=browser_tests Change-Id: I47b5021df115b4af6aa3fba543a34daf192c2fd7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550839Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Oleksandr Peletskyi <peletskyi@chromium.org> Commit-Queue: Polina Bondarenko <pbond@chromium.org> Auto-Submit: Polina Bondarenko <pbond@chromium.org> Cr-Commit-Position: refs/heads/master@{#835132}
-
Meredith Lane authored
Bug: N/A Change-Id: Id7ff65b9428c73e565561cd92f1fa375a0515048 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577076Reviewed-by:
Meredith Lane <meredithl@chromium.org> Reviewed-by:
Alex Rudenko <alexrudenko@chromium.org> Commit-Queue: Meredith Lane <meredithl@chromium.org> Cr-Commit-Position: refs/heads/master@{#835131}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/c6b219431a16..b5c844554e30 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I907dec210a97c8bb5e0de1800ea81a56541f7f50 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2581458Reviewed-by:
-
Rakina Zata Amni authored
Currently we use NavigationRequest's CommitNavigationParams' method in VerifyThatBrowserAndRendererCalculatedDidCommitParamsMatch, but that might differ than what the renderer returns on history same-document navigations due to the history API resetting methods to "GET". For POST ID, we use the last committed entry's POST ID on same-document navigations, but that will only work for main frame cases. We need to track the post ID directly in the RenderFrameHostImpl to cover cases with subframe navigations. This CL fixes the calculated values, and adds additional logging. Bug: 1155414 Change-Id: I81358e641b7b3aaeda7fbcec58c92cef97ba9d27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2576878 Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#835129}
-
Nate Fischer authored
No change to logic. This inlines BuildInfo.isAtLeast{Q,R} and BuildInfo.targetsAtLeast{Q,R} (and their C++ equivalents) in /media/audio. The methods themselves will be removed in a follow-up CL once all call sites have been removed. This CL was uploaded by git cl split. R=olka@chromium.org Bug: 1106920 Test: autoninja -C out/Default monochrome_public_apk Change-Id: Ife2dbda7b4d444f59df1dfc5be3f25cc269ad827 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575737 Auto-Submit: Nate Fischer <ntfschr@chromium.org> Reviewed-by:Olga Sharonova <olka@chromium.org> Commit-Queue: Olga Sharonova <olka@chromium.org> Cr-Commit-Position: refs/heads/master@{#835128}
-
arthursonzogni authored
The error message was: Unsafe JavaScript attempt to initiate navigation for frame but the navigation is not always initiated from JavaScript. It can be initiated by the user. This is misleading. Following mkwst@ suggestion: > I agree that it probably makes sense to change that string. Dropping > the word "JavaScript" might be enough. This patch remove "Javascript " Bug: 830043 Fixed: 830043 Change-Id: I73964c4f6a8a479ecca5c6c2c409d6f579030d07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2579744 Commit-Queue: Camille Lamy <clamy@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Auto-Submit: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#835127}
-
Philipp Hancke authored
temporarily allow webrtc/protocol/rtp-payloadtypes.html to fail in order to allow rolling a webrtc fix into chrome BUG=webrtc:12194 Change-Id: Ib9e99b42edb11fc421c7eea6ecb914b88511d59d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580801Reviewed-by:
Harald Alvestrand <hta@chromium.org> Commit-Queue: Harald Alvestrand <hta@chromium.org> Cr-Commit-Position: refs/heads/master@{#835126}
-
dpapad authored
Bug: 1132403 Change-Id: If07572c8f064b419c38335a767e19db5504a28c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2578711 Commit-Queue: dpapad <dpapad@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#835125}
-
Jasmine Chen authored
There is a race condition in how we added tracing in https://crrev.com/c/1158106 TraceLog is added in CameraHalDispatcherImpl constructor. Once TraceLog is enabled, it calls CameraHalDispatcherImpl::OnTraceLogEnabled. CameraHalDispatcherImpl then processes the call on its proxy thread. The issue is the proxy thread may not be started yet at this point, so CameraHalDispatcherImpl will crash when it tries to post a task onto the not-yet-started proxy thread. Bug: None Test: Build and deploy simplechrome on soraka Change-Id: If06c18da2aac25aae8ff79d061fd59b3344e9369 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2581125 Commit-Queue: Jasmine Chen <lnishan@google.com> Commit-Queue: Shik Chen <shik@chromium.org> Auto-Submit: Jasmine Chen <lnishan@google.com> Reviewed-by:
Shik Chen <shik@chromium.org> Cr-Commit-Position: refs/heads/master@{#835124}
-
Yuta Hijikata authored
The change is mostly mechanical replacing defined(OS_CHROMEOS) with BUILDFLAG(IS_CHROMEOS_ASH) and GN variable is_chromeos with is_chromeos_ash with some special cases (For those cases please refer to http://go/lacros-macros). The patch is made in preparation to switching lacros build from target_os=linux to target_os=chromeos. This will prevent lacros from changing behaviour after the switch. Bug: 1052397 Change-Id: If6b910012f7ee0bcebfcc648d48eb3f803eb3941 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560349 Commit-Queue: Yuta Hijikata <ythjkt@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#835123}
-
Harvey Yang authored
Fixes <1aefce02> (generic_sensor: Add PlatformSensor(Provider)ChromeOS) Keeps |sensor_device_remote_| when stopping the reads, so that we can resume the reads with StartSensor later. BUG=b:172414302 TEST=run on nightfury(hatch) Change-Id: I37057036ce9697fffad3e37eba6bca7654db398e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2546390 Commit-Queue: Cheng-Hao Yang <chenghaoyang@chromium.org> Reviewed-by:
Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Cr-Commit-Position: refs/heads/master@{#835122}
-
Yuta Hijikata authored
The change is mostly mechanical replacing defined(OS_CHROMEOS) with BUILDFLAG(IS_CHROMEOS_ASH) and GN variable is_chromeos with is_chromeos_ash with some special cases (For those cases please refer to http://go/lacros-macros). The patch is made in preparation to switching lacros build from target_os=linux to target_os=chromeos. This will prevent lacros from changing behaviour after the switch. Bug: 1052397 Change-Id: I2d2424bbd48aa4a7f711d30d259e1013ef3d6cf8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2578419 Commit-Queue: Yuta Hijikata <ythjkt@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#835121}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/406bc3320344..34717e17dce2 2020-12-09 petermarshall@chromium.org [surveys] Add survey triggers for the remaining Issues surveys If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1112738 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Idf34b0faa95f3d9b678f8dfac140d5bd855ef09e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2581439Reviewed-by:
-
edchin authored
This extends an expired histogram which will be useful in upcoming tab management work. Change-Id: I683fb275fbe59e10e06aa878b31cc492bf06d3c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2579714 Commit-Queue: Ilya Sherman <isherman@chromium.org> Reviewed-by:
-
Richard Stotz authored
This is a reland of https://crrev.com/c/2436344 This CL adds a mechanism to report file errors, as reported by base::File::Error, though DOMExceptions. Due to security and privacy considerations, not all errors are exposed to the user. For those operations performed by the browser process (open, rename), the exact error type is not exposed to the renderer. Errors that are not reported by base::File::Error are left unchanged and will be addressed in a followup CL. The design document for this change is https://docs.google.com/document/d/1rvs615AU2s8kVsmUlukbmtQNvUWFny0yzAS_gsnYZEs/ Bug: 1095537 Change-Id: I5b9623d22653daff168221468c2a1be837668c6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577472Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Richard Stotz <rstz@chromium.org> Cr-Commit-Position: refs/heads/master@{#835118}
-
Anton Bikineev authored
This fixes the race between PCScan and memory reclaimer (if reclaimer decommits a page that was snapshotted before running a PCScan task, the scanner will hit a page fault). Bug: 1156011 Change-Id: I90a9655962f4cc0849165287b3c8199d7401d386 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2579911Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Anton Bikineev <bikineev@chromium.org> Cr-Commit-Position: refs/heads/master@{#835117}
-
Timothy Loh authored
plugin_vm_installer.h: - Update declaration order to explicitly show installation flow, and match style guide. - Make a couple of internal functions private - Update comments to be clearer/simpler/etc. plugin_vm_installer.cc changes: - Re-order function definitions in .cc to match header file Bug: 1063748 Change-Id: I4618d5a3845d8ac381063cec0ae1adc798364702 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2576967 Commit-Queue: Timothy Loh <timloh@chromium.org> Reviewed-by:
Jason Lin <lxj@google.com> Cr-Commit-Position: refs/heads/master@{#835116}
-
Jinsuk Kim authored
LocationBarModel has several dependencies on classes in //chrome_java target that provide public static utils methods. This CL injects them as functional interfaces through the constructor. Bug: 1127732 Change-Id: Ia502e2d43bc140c1a6e5efa735e93a30a4b61e2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2543725Reviewed-by:
Patrick Noland <pnoland@chromium.org> Reviewed-by:
Chris Thompson <cthomp@chromium.org> Reviewed-by:
-
Andres Calderon Jaramillo authored
This CL removes the usage of a GpuMemoryBufferFactory from the V4L2VideoEncodeAccelerator. This is because we don't actually need it to allocate buffers and it simplifies things. Note that we must start the |encoder_task_runner_| with base::MayBlock() because the first encoder to make use of this path will open the render node. Bug: b:173167846 Test: video.EncodeAccel.h264_720p_nv12_dmabuf on elm Change-Id: I01d5f63f0b358c0ee9bb448ded7ba24355a72f9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2568548 Commit-Queue: Andres Calderon Jaramillo <andrescj@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#835114}
-
Alexis Hetu authored
This issue is related to the GetInstalledVersionLinuxTest.WithVersion test where, unlike on Windows or MacOS, querying Chrome's version relies on the content of the console output of a child process. This cl makes GetInstalledVersion() slightly more verbose in order to make it easy to identify potential warnings (or any other console outputs) when querying the version. Bug: chromium:1152832 Change-Id: Iea153887d3f1e439c1a6305b88c93dfef17cc4f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560609 Commit-Queue: Greg Thompson <grt@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#835113}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1607471901-85f06a8978ebf1d40d9cf80572b77a4ab0bcfbe1.profdata to chrome-linux-master-1607493425-c73fec691091cf0b277c9f5003730e7d0a079735.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I78161c39acf075030fe4dc27b2df22ab94b179a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2581421Reviewed-by:
-
Asami Doi authored
This CL enables the kCheckOfflineCapability feature with the warn only mode by default in M89. Bug: 965802 Change-Id: Ife97e09f4cb03cf3c3316f7d59368b7d64e10996 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580668Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/2979a9c445f4..ea80f524f61b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC shend@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: shend@google.com Change-Id: Iba3972c80b8b857044dbd64e6f3bdf1f74bde26c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2581222Reviewed-by:
-
Hiroki Nakagawa authored
This CL disallows activation of prerendered pages for pop-up windows. The previous CL (https://crrev.com/c/2494291) already did the same thing for iframes. In addition, this adds tests for both iframes and pop-up windows. We might also need to disallow both the contexts to trigger navigation for prerendering (trigger <link rel=prerender>), but it is out of the scope of this CL. Change-Id: I741b07983e2e8d9f9f3af88ca618129c5d52674f Bug: 1138711, 1138723 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560362Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#835109}
-
Victor Hugo Vianna Silva authored
If the new (DISABLED_BY_DEFAULT) IgnoreEncryptionKeysLongMissing feature is enabled, ModelTypeWorker will ignore both future and pending updates encrypted with keys that remained unknown for 'too long', as measured by UnknownEncryptionKeyInfo::gu_responses_while_should_have_been_known. The threshold for 'too long' is arbitrary for the moment. Two different metrics are added: the first is logged when a key starts being ignored, and records the number of pending updates that were dropped. The second is recorded individually for each incoming update entity that's encrypted with an ignored key. Future CLs will start persisting the notion of unknown keys across browser restarts. Bug: 1109221 Change-Id: I52b841368385ce347fbaa8746501ab07a5b7752a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567883Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Victor Vianna <victorvianna@google.com> Cr-Commit-Position: refs/heads/master@{#835108}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1607471901-3e959809a33b2895908083a52c31919f2827c11a.profdata to chrome-mac-master-1607493425-af0aa6c36468b9d0e6f03a33932dae6d4017f80e.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ic0d92302c8a5d75521835a639fd794a5cf331006 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2581420Reviewed-by:
-
