- 04 Dec, 2020 40 commits
-
-
Piotr Bialecki authored
Add depth buffer resolution limit along with a histogram to measure the resolution of depth buffer that was obtained from ARCore. Bug: 1154323 Change-Id: I7109c76732e76dd825f0a45e2dd32570b89e79d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2568752Reviewed-by:
Klaus Weidner <klausw@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Piotr Bialecki <bialpio@chromium.org> Cr-Commit-Position: refs/heads/master@{#833554}
-
Nicholas Hollingum authored
Anonymous apps are generated when borealis identifies a window with an app_id it does not recognize. In this CL we add the logic to remove those anonymous apps. When all the windows close associated with that anonymous app, we say the app is "finished", allowing observers to clean it up. Bug: b/172979315 Change-Id: I5c1c0cfd2ed15fcd35474c53011cbce6c0733d51 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2562624 Commit-Queue: Nic Hollingum <hollingum@google.com> Reviewed-by:
Daniel Ng <danielng@google.com> Reviewed-by:
Nancy Wang <nancylingwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#833553}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/19a302fca592..0d2de6f05c54 2020-12-03 syoussefi@chromium.org Vulkan: Fix precision issue in blit math If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ianelliott@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: chromium:1154759 Tbr: ianelliott@google.com Change-Id: Ic3a87fa0b240cfdeefdb5d995ec43bf01848006c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2572651Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#833552}
-
Yan, Shaobo authored
This CL replace SkImage::MakeFromYUVATexturesCopyToExternal with Sksurface. This will combine all of the uploading path to the same logic and remove duplicated codes. This CL also change the incorrect condition to try direct uploading path on Windows. BUG=1108154 Change-Id: Iaa44d23e984b192f4c3b38aa52c7d22dea879748 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2559649Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Reviewed-by:
Brian Salomon <bsalomon@google.com> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Shaobo Yan <shaobo.yan@intel.com> Cr-Commit-Position: refs/heads/master@{#833551}
-
Andrew Xu authored
This CL adds the ink drop ripple to the delete button. In order to achieve this, we create a new class called `DeleteButtonContainer` to paint the delete button background. Otherwise, because the ink drop ripple's layer is beneath the host view, the delete button's background will be placed above the ink drop ripple's layer. Due to the view hierarchy's change, this CL also modifies the api function provided by ContentsView to install the delete button. Bug: 1152815 Change-Id: I083850f41d15cb9c2c1974d84c217fcc93f83fed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2568152 Commit-Queue: Andrew Xu <andrewxu@chromium.org> Reviewed-by:
David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#833550}
-
adoneria authored
Added on chromium.updater buildergroup. This is to help updater team in easier monitoring of updater failures on chrome official builds for win and mac. Bug: 1155288 Change-Id: Ie65278f8f16f452cad0b72d525fc32e2b41a8240 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2572752Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Commit-Queue: Anjali Doneria <adoneria@google.com> Cr-Commit-Position: refs/heads/master@{#833549}
-
Renjie Tang authored
Split the content of QuicChromiumClientSession::OnProbeSucceeded() to two different methods for port migration and connection migration. These two methods will later be connected with IETF QUIC's path validators. Bug: 1151419, 1155306 Change-Id: Ie3eed049837fa87fd6fe0bff634a106c702a394d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2572780 Commit-Queue: Renjie Tang <renjietang@chromium.org> Commit-Queue: David Schinazi <dschinazi@chromium.org> Auto-Submit: Renjie Tang <renjietang@chromium.org> Reviewed-by:
David Schinazi <dschinazi@chromium.org> Cr-Commit-Position: refs/heads/master@{#833548}
-
Gavin Williams authored
New tests cover more of the failure scenarios related to scanning. Bug: 1059779 Change-Id: I246a26c7dda8e460c5239318b2017b4db97d03e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2569977 Commit-Queue: Gavin Williams <gavinwill@chromium.org> Reviewed-by:
Jesse Schettler <jschettler@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#833547}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/a45552c0f29d..8ddf5ae4b8a5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I19f86bf48a37e3d2652dd419e3545d92608b29cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2573131Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: I1025712c59ca7ac25c191cef3af65ef43d55f2f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2573283Reviewed-by:
-
Andre Vincent authored
Bug: 1080876 Change-Id: I278a8d4477f6811440e78e86b7bcf2fa7e10ad3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2569433Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Andre Vincent <andrevincent@google.com> Cr-Commit-Position: refs/heads/master@{#833544}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/5537c0394234..d1cf5db4152d 2020-12-02 dberris@chromium.org sheriff-config: Improve validation coverage 2020-12-02 dberris@chromium.org sheriff-config: Fix crashloop If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC wenbinzhang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1154561 Tbr: wenbinzhang@google.com Change-Id: I92ee5eaadc72ec277f9d34af7573b5d5ea797756 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2569457Reviewed-by:
-
Reilly Grant authored
These tests don't have any automation dependencies (since they are manual) so can be exported first. Bug: 884928 Change-Id: I6a3b9240d7ce8d61bfea43e5445d1334725bbd64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2572745 Commit-Queue: Reilly Grant <reillyg@chromium.org> Commit-Queue: Joshua Bell <jsbell@chromium.org> Auto-Submit: Reilly Grant <reillyg@chromium.org> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Cr-Commit-Position: refs/heads/master@{#833542}
-
Taylor Bergquist authored
This reverts commit 5e258bde. Reason for revert: Speculative fix for test failures in https://crbug.com/1155028 Original change's description: > Roll Media App from 9Aak3tK4o... to 6AHX-97XE... > > Release_Notes: http://go/media_app-x20/relnotes/Main/media_app_202012020600_RC00.html > > https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/media_app/app/+/6AHX-97XEsRATZXtxtSFgMgB4HPdjrF2NmTP1UctxQQC > > If this roll has caused a breakage, revert this CL and stop the roller > using the controls here: > https://skia-autoroll.corp.goog/r/media-app-chromium-autoroll > Please CC media-app@grotations.appspotmail.com on the revert to ensure that a human > is aware of the problem. > > To report a problem with the AutoRoller itself, please file a bug: > https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug > > Documentation for the AutoRoller is here: > https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md > > Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome > Bug: b/138543581,b/147599135,b/168067375,b/173978830,b/174442723,b/174536897 > Tbr: media-app@grotations.appspotmail.com > Change-Id: Ib6c2542e28b60d8c1a04a3d21d378e4a10cac32e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2569796 > Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> > Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> > Cr-Commit-Position: refs/heads/master@{#832834} TBR=chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com,media-app@grotations.appspotmail.com # Not skipping CQ checks because original CL landed > 1 day ago. TBR: sebsg@chromium.org Bug: b/138543581 Bug: b/147599135 Bug: b/168067375 Bug: b/173978830 Bug: b/174442723 Bug: b/174536897 Change-Id: Ib1c2c8377cc932aa8223bc72282ebbf29cd77dac Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2572164 Commit-Queue: Taylor Bergquist <tbergquist@chromium.org> Reviewed-by:
Taylor Bergquist <tbergquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#833541}
-
Evan Stade authored
Use it to sever a Chrome dependency from InstallableManager. ChromeWebappsClient is added to the //chrome/browser target in a new //chrome/browser/webapps directory, as there's no directory currently shared by Android and desktop for web apps. That is, //chrome/android/webapps and //chrome/browser/web_applications are platform-specific. Unfortunately the new method is called in many unit tests, so to avoid crashing we either have to instantiate a ChromeWebappsClient in each unit test (or unit test base class, i.e. at least BrowserWithTestWindowTest, ChromeRenderViewHostTestHarness, and ExtensionServiceTestBase), or we gracefully handle a missing client. I opted for the latter, although this decision may be revisited if many other WebappsClient callsites wind up needing to null check. Bug: 1147276 Change-Id: I40eaa3e999dbe987aa4ecc2bbfaafb57cbcdc0cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2566743 Auto-Submit: Evan Stade <estade@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Glenn Hartmann <hartmanng@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#833540}
-
Gary Tong authored
Change-Id: I0870a254683811a4e862518829b6cc49bd6d3d7d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2570560 Auto-Submit: Gary Tong <gatong@chromium.org> Commit-Queue: Gary Tong <gatong@chromium.org> Commit-Queue: Garrett Beaty <gbeaty@chromium.org> Reviewed-by:
-
David Van Cleve authored
Whoops. TBR=csharrison@chromium.org Change-Id: I9badb39d8d22041951fa8381271769a7d1cca5bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2573381Reviewed-by:
David Van Cleve <davidvc@chromium.org> Commit-Queue: David Van Cleve <davidvc@chromium.org> Cr-Commit-Position: refs/heads/master@{#833538}
-
Michael Ludwig authored
Bug: 1143929 Change-Id: I9259792778e80283e14f628cdce456c48d710af8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2571637 Commit-Queue: Michael Ludwig <michaelludwig@google.com> Reviewed-by:
Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#833537}
-
Jun Sheng authored
below tests are stable now and running in ChromiumOS CQ. inputs.VirtualKeyboardOOBE.stable inputs.VirtualKeyboardAccessibility.stable inputs.VirtualKeyboardChangeInput.stable inputs.VirtualKeyboardDeadKeys.french_stable inputs.VirtualKeyboardTypingApps.stable inputs.VirtualKeyboardTypingBrowser.stable BUG=b:174521942 TEST=none Change-Id: I822f947794683183a2370c4c280c94bde1cb625c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567052Reviewed-by:
Leo Zhang <googleo@chromium.org> Commit-Queue: Jun Sheng <shengjun@chromium.org> Commit-Queue: David Vallet <dvallet@chromium.org> Cr-Commit-Position: refs/heads/master@{#833536}
-
Alexis Menard authored
This CL adds the parsing bits for the CSS part of the specification. At this moment it's not resolving the actual values, this will come in a later CL. Intent to Prototype : https://groups.google.com/a/chromium.org/g/blink-dev/c/prHGPxF62i4 Specification: https://w3c.github.io/screen-fold/ Explainer: https://github.com/SamsungInternet/Explainers/blob/master/Foldables/FoldState.md and https://webscreens.github.io/form-factors/ Bug: 1066842 Change-Id: Ie167c1ffce1e41f7c58acd59bd1116d6d9b1cfd1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567092 Commit-Queue: Alexis Menard <alexis.menard@intel.com> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#833535}
-
Avi Drissman authored
Bug: 1136676 Change-Id: I4ca7106dc8ee64854ab70fc4724b692d68b91aba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2570116 Commit-Queue: Avi Drissman <avi@chromium.org> Auto-Submit: Avi Drissman <avi@chromium.org> Reviewed-by:
Collin Baker <collinbaker@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#833534}
-
Gavin Mak authored
Generate DIR_METADATA files and remove metadata from OWNERS files for directories under //third_party/. R=haraken@chromium.org Bug: 1113033 Change-Id: I2f74cd06d628685f7b9daa7981b86de73f34cb18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2572726 Auto-Submit: Gavin Mak <gavinmak@google.com> Commit-Queue: Kentaro Hara <haraken@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#833533}
-
Glen Robertson authored
Profile depending on a profile-keyed-service makes an immediate include cycle, meaning profile and the service (and all its deps) must be in the same build target (ie. the huge //chrome/browser target). Separating profile to its own target means other targets can depend on that instead of //chrome/browser, fixing dependency cycles. Bug: 1149277 Change-Id: Idffb303e0a10acfcdb011fe97fdc074b0faf7c49 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2554196 Commit-Queue: Glen Robertson <glenrob@chromium.org> Auto-Submit: Glen Robertson <glenrob@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#833532}
-
Nicholas Hollingum authored
With the introduction of go/anonymous apps we want a way to make sure that an app really does only exist temporarily and can be cleaned up afterwards. We add a kRemoved readiness, which is an indication to the apps service that an app is really gone now and associated memory should be cleaned up to preserve resources. Bug: b/172979315 Change-Id: I4960c9bf06df4067e84e2a4718f1653006e13261 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2563191 Commit-Queue: Nic Hollingum <hollingum@google.com> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
-
Aga Wronska authored
Content packs feature for supervised users has never been launched - deprecate the code. Bug: 1149788 Change-Id: Ifdb8db5d7c5c482d74c8419e74ef540a000b1fde Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551816 Commit-Queue: Aga Wronska <agawronska@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#833530}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/1ec57124a67c..91cf42a0759a 2020-12-03 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: Ic81ac83108fa1e88a6dcd2480b80e364bf90726f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2573280Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ba66a670730d..238470adc0e5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC tbergquist@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1025619,chromium:1150971 Tbr: tbergquist@google.com Change-Id: I6e3bc4250f919e3d107dfb6d30be720342afc690 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2573416Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#833528}
-
Darren Shen authored
Bug: b/174612548 Change-Id: I567f592c272f6607328f4a03de551fc4582decfe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2566320 Auto-Submit: Darren Shen <shend@chromium.org> Commit-Queue: Jing Wang <jiwan@chromium.org> Reviewed-by:
Jing Wang <jiwan@chromium.org> Cr-Commit-Position: refs/heads/master@{#833527}
-
Daniel Murphy authored
Bug: 1151485, 1151483 Change-Id: I6369a73f66e6429ac1d3873760b69f089b050441 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551779 Commit-Queue: Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Chase Phillips <cmp@chromium.org> Cr-Commit-Position: refs/heads/master@{#833526}
-
Kunihiko Sakamoto authored
This reverts commit d2ee30a3. Reason for revert: Caused gl_tests_validating failure on Linux CFI bot: https://ci.chromium.org/p/chromium/builders/ci/Linux%20CFI/19128 Original change's description: > Make sure ANGLE can find the proper libraries when running tests > > This cl is in the context of replacing SwiftShader's GL libraries > with SwANGLE (ANGLE with SwiftShader Vulkan as its backend). In order > to allow ANGLE to find the proper libvulkan.so when executing tests > on the bots, we have to make sure the proper rpath is set. > > This affects all tests that depend directly or indirectly on > //ui/gl:test_support. > > The affected tests include: > app_shell_unittests > aura_unittests > cc_unittests > compositor_unittests > gpu_unittests > interactive_ui_tests > message_center_unittests > media_unittests > snapshot_unittests > unit_tests > views_unittests > viz_unittests > wm_unittests > > Bug: chromium:1060139 > Change-Id: Ida242f511599d38ad1ec16e0f4711d80a957cc8f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2565490 > Reviewed-by: Kenneth Russell <kbr@chromium.org> > Reviewed-by: Greg Thompson <grt@chromium.org> > Reviewed-by: Dale Curtis <dalecurtis@chromium.org> > Reviewed-by: danakj <danakj@chromium.org> > Commit-Queue: Alexis Hétu <sugoi@chromium.org> > Cr-Commit-Position: refs/heads/master@{#833354} TBR=danakj@chromium.org,dalecurtis@chromium.org,thakis@chromium.org,sugoi@chromium.org,kbr@chromium.org,rdevlin.cronin@chromium.org,grt@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com,sugoi@google.com Change-Id: Icd0336a4d82b734804be88a0120ad26465f5e5e8 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:1060139 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2573258Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#833525}
-
Jiewei Qian authored
This is a followup to https://crrev.com/c/2569191, which the method was added. The callsite in chrome_new_window_client_browsertest.cc wasn't changed to match the return type. This caused a mismatch so EXPECT_EQ is asked to compare int with size_t, and can cause problem on certain build configurations. Change-Id: I092e0f0ea5d333359c8e11c39e7202f27e1849e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2573556 Auto-Submit: Jiewei Qian <qjw@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#833524}
-
Nicholas Hollingum authored
Similar to crrev.com/c/2562799, we remove the installer factory and move it to the omni-service. Bug: b/170596931 Change-Id: I182816dba38fd66d116a1d066d414d69b1503c7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567276 Commit-Queue: Nic Hollingum <hollingum@google.com> Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#833523}
-
Michael Hansen authored
The "Manage Contacts" button doesn't work when viewing the contact visibility page from the sharesheet flow. We need a custom subclass of views::WebView to perform the navigation. Bug: 1138445 Change-Id: Id90e83b6e307d136bd0114ee51fc42c53b2c8510 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567759 Commit-Queue: Michael Hansen <hansenmichael@google.com> Reviewed-by:
James Vecore <vecore@google.com> Cr-Commit-Position: refs/heads/master@{#833522}
-
Aleks Totic authored
New table layout works fine with fractional layout sizes. Bug: 958381 Change-Id: I759c17190acd2f826a39855a1bce3dd48963af96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2572788 Commit-Queue: Aleks Totic <atotic@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Auto-Submit: Aleks Totic <atotic@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#833521}
-
Lan Wei authored
Use testdriver Action API to simulate mouse click actions in css/selectors/focus-visible-004.html. Bug: 1145677 Change-Id: I3715e32893f0e977226412d8ffc8b6928ff7a1a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551803Reviewed-by:
Mustaq Ahmed <mustaq@chromium.org> Commit-Queue: Lan Wei <lanwei@chromium.org> Cr-Commit-Position: refs/heads/master@{#833520}
-
Marc Treib authored
Bug: 1152039 Change-Id: I1baedf226b8848951ac50f5370aa8b80feb06b74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567165 Auto-Submit: Marc Treib <treib@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#833519}
-
Internal Frameworks Autoroller authored
TBR=bling-team@google.com Change-Id: Icb4316185b7972714e192d0323621453f76d0a89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2572898Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#833518}
-
Melissa Zhang authored
Add close check so that sharesheet can't close if it's already in the process of closing. Bug: 1153284 Change-Id: I1279240e2ceb9c7769ab96244d8aa3d3393aec11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2570914 Auto-Submit: Melissa Zhang <melzhang@chromium.org> Commit-Queue: Dominick Ng <dominickn@chromium.org> Reviewed-by:
-
Michael Checo authored
Screenshot: http://shortn/_fvSN9f0N5B Spec: https://carbon.googleplex.com/cros-ux/pages/diagnostics/mvp Bug: 1125150 Test: browser_tests --gtest_filter=DiagnosticsApp* Change-Id: I7cc40e2e25f10c700ffb92bbaefc52a5ec63be62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567930 Commit-Queue: Michael Checo <michaelcheco@google.com> Reviewed-by:
Joon Ahn <joonbug@chromium.org> Cr-Commit-Position: refs/heads/master@{#833516}
-
Toni Barzic authored
Some file systems are unmounted during device suspend (for example drive FS), which was causing the holding space file system delegate's file path removal detection to remove them from the holding space on device suspend. To avoid this issue, holding space keyed service now observes device suspend status and shuts down holding space delegates when the device suspends. The delegates are re-initialized when suspend ends, restoring the model from persistence again. BUG=1152924 Change-Id: Iffe4586bcb87f47d687ceeff0fc76e60a443c0d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2568355 Commit-Queue: Toni Baržić <tbarzic@chromium.org> Reviewed-by:
-
