- 30 Jan, 2020 40 commits
-
-
tby authored
This is a reland of cbe25387 Original change's description: > [Structured metrics] Rearrange build files > > Currently, the generated classes for each event are created under the > //tools/metrics/structured target. I don't think this is the intended > use of the tools directory, because chrome targets explicitely can't > depend on it, and so can't access the generated events. > > This CL moves the codegen targets to //components/metrics/structured, > which is accessible from chrome (and just makes more sense). > > Bug: 1016655 > Change-Id: I6a295486a3dad094b44db67d70408c8629728bcc > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2029531 > Commit-Queue: Tony Yeoman <tby@chromium.org> > Auto-Submit: Tony Yeoman <tby@chromium.org> > Reviewed-by: Jia Meng <jiameng@chromium.org> > Cr-Commit-Position: refs/heads/master@{#736753} Bug: 1016655 Change-Id: I16f5ddd85b46d0b3420d7a40421a5cba60063f6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2030385Reviewed-by:
Jia Meng <jiameng@chromium.org> Commit-Queue: Tony Yeoman <tby@chromium.org> Cr-Commit-Position: refs/heads/master@{#736798}
-
Fabian Sommer authored
This is in preparation to use the UI for smart cards. Bug: 1001288 Change-Id: I6a2890eaf476a79db68e8bc6898c7e4fb89199c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2022770 Commit-Queue: Fabian Sommer <fabiansommer@google.com> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#736797}
-
Stephen Nusko authored
There was a lot of different uses of getting the SharedMemoryArbiter this unifies them all and makes it consistent. Bug: 1007310 Change-Id: I0a6aba5f739723b46261cb6e0ec174d07ddc2897 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026569Reviewed-by:
Stephen Nusko <nuskos@chromium.org> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Commit-Queue: Stephen Nusko <nuskos@chromium.org> Auto-Submit: Stephen Nusko <nuskos@chromium.org> Cr-Commit-Position: refs/heads/master@{#736796}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I996de028a1b2f135003a12bea40d62d24d57f83d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2030040Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#736795}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/29e5a1af6c1d..305542ea70b1 git log 29e5a1af6c1d..305542ea70b1 --date=short --first-parent --format='%ad %ae %s' 2020-01-30 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@305542ea70b1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: agable@chromium.org Change-Id: Ib29b230275804310d09dd921017d7287c534f531 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2030035Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/6ebcde89ed38..a66ca23b9f26 git log 6ebcde89ed38..a66ca23b9f26 --date=short --first-parent --format='%ad %ae %s' 2020-01-30 fancl@chromium.org Add /subscriptions/list endpoint Created with: gclient setdep -r src/third_party/catapult@a66ca23b9f26 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC wenbinzhang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:953181 Tbr: wenbinzhang@google.com Change-Id: Ic4d526e4674eac67db1d8a4df75ce426321fab08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2030039Reviewed-by:
-
Rune Lillesveen authored
Resolved in https://github.com/w3c/csswg-drafts/issues/4608 Pull request: https://github.com/w3c/csswg-drafts/pull/4714 Change-Id: Id902a8f7b920872a3dede346c98c87092a6147e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2027418Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#736792}
-
Yutaka Hirano authored
Using default implemnetation breaks WrappedResourceRequest semantics. Bug: 787704 Change-Id: Ic80403d884df5ca04460614c8fbc94fa27b417ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2029535Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#736791}
-
Arthur Hemery authored
Test flakes because of an already identified problem. Bug: 1040059 Change-Id: Id18c4111664a9c8adc186a8034085d7f84a265fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2027792 Auto-Submit: Arthur Hemery <ahemery@chromium.org> Reviewed-by:
Pâris Meuleman <pmeuleman@chromium.org> Commit-Queue: Arthur Hemery <ahemery@chromium.org> Cr-Commit-Position: refs/heads/master@{#736790}
-
Edward Jung authored
Experiment period has not seen any statistically differences in proceed or action rates on the security interstitials. Removing all experiment code. This will also fix the refresh flicker from the JS classname switching. Bug: 978002 Change-Id: Ida9649772ff6e5e0ddbcc10f779c3545884e42ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2010947 Commit-Queue: Edward Jung (EMEA) <edwardjung@chromium.org> Reviewed-by:
John Delaney <johnidel@chromium.org> Reviewed-by:
Carlos IL <carlosil@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#736789}
-
Maria Kazinova authored
calls. PasswordForm is a result of parsing and is a part of the browser process. The renderer process doesn't need it, as all necessary renderer process information is contained in FormData. Bug: 949519 Change-Id: Ifd7b96945206d895bd77e5aaeb18d31420646fb4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013055Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Maria Kazinova <kazinova@google.com> Cr-Commit-Position: refs/heads/master@{#736788}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/f1c330bde24f..8f44c3504ca6 git log f1c330bde24f..8f44c3504ca6 --date=short --first-parent --format='%ad %ae %s' 2020-01-30 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/skia@8f44c3504ca6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC reed@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: reed@google.com Change-Id: I77bb0d0b7b2d8ed4389f763bb1afdbef853909d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2030037Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/97f1d485b763..dd3f8d4922eb git log 97f1d485b763..dd3f8d4922eb --date=short --first-parent --format='%ad %ae %s' 2020-01-29 afdx@google.com spirv-fuzz: Add outlining test (#3164) 2020-01-29 afdx@google.com spirv-fuzz: Make functions "livesafe" during donation (#3146) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@dd3f8d4922eb If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,tobine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Bug: None Tbr: radial-bots+chrome-roll@google.com,tobine@google.com Change-Id: I8a87ff85d4de4e8e58597c6c5c01862aae94d306 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2030034Reviewed-by:
-
Isabella Scalzi authored
Addresses post-facto review comments of CL:2026548. Bug: 1038799 Change-Id: Id22e54a6824d7d28028145f5ef5eef3efb8ff846 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2029560 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#736785}
-
sandromaggi authored
The action is no longer used. Bug: b/148194528 Change-Id: Ia7b6cb5c5f6dd4ebdad059f35a15e35da469d159 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2027329Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Commit-Queue: Sandro Maggi <sandromaggi@google.com> Cr-Commit-Position: refs/heads/master@{#736784}
-
Simon Zünd authored
This CL removes a race in a breakpoint web test. The CL does a similar things an existing test helper, but in a safe way. {waitUntilPausedAndDumpStackAndResume} also prints the reason why we are paused. Since we pause at a breakpoint and we get a status message for that (plus a stack trace), we removed the reason from the test expectation in favor of a non-flaking test. R=petermarshall@chromium.org Change-Id: I20aa786d370e64eb16ed3a9036b5599a6be02651 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028888Reviewed-by:Peter Marshall <petermarshall@chromium.org> Commit-Queue: Simon Zünd <szuend@chromium.org> Cr-Commit-Position: refs/heads/master@{#736783}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/9a80305c0897..5e86b28ffb81 git log 9a80305c0897..5e86b28ffb81 --date=short --first-parent --format='%ad %ae %s' 2020-01-30 johnkslang@users.noreply.github.com Merge pull request #2071 from jeffbolznv/version_less Created with: gclient setdep -r src/third_party/glslang/src@5e86b28ffb81 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,tobine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: radial-bots+chrome-roll@google.com,tobine@google.com Change-Id: I2852784f0a72494ab3d00a5aa0bc936f4d3e04ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2029285Reviewed-by:
-
Vasilii Sukhanov authored
Bug: 1026818 Change-Id: Ia27a49cc27a09ba8288eb013cd522a5eea26ab11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2027850Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#736781}
-
Maksim Ivanov authored
Add VLOG statements for the certificate, signature and PIN requests into the chrome.certificateProvider API implementation. These logs will help in investigating testing and customer issues for the Chrome OS smart card login feature. The logs will have to be removed later, once the feature gets stabilized. Bug: 1046860 Change-Id: Id3aaa57118f9134f15dee0e861c606ebb3e03252 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2029508Reviewed-by:
Igor <igorcov@chromium.org> Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#736780}
-
Anatoliy Potapchuk authored
This CL contains a cleanup of redundant command line flags -- kForceAndroidAppMode, kForceWebAppMode, leaving only kForceAppMode for all kiosks. Also, it sends this flag to the renderer so the net_error page doesn't display suggestions which may redirect outside. Bug: 1034137 Change-Id: I3ecdc1916d6a33364b13624a8dcffc2c835df554 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2027907 Commit-Queue: Anatoliy Potapchuk <apotapchuk@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Edward Jung (EMEA) <edwardjung@chromium.org> Cr-Commit-Position: refs/heads/master@{#736779}
-
Kei Nakashima authored
This change is for following the spec of validationMessage. It affects the situation where willValidate is false and actual validation message exists. It enables validationMessage to return empty string in this situation. Bug: 1046211 Change-Id: Ie501535464b61366c81ee08d6b234fb52cc076f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024132 Auto-Submit: Kei Nakashima <keinakashima@google.com> Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#736778}
-
Colin Blundell authored
In preparation for sharing //chrome's SSLErrorHandler implementation, this CL makes CaptivePortalService available in WebLayer by adding a KeyedServiceFactory for it. //chrome's SSLErrorHandler requires a CaptivePortalService when captive portal detection is enabled (which it is on desktop platforms, i.e., Linux). The factory is modeled after that from //chrome, with a difference for the //weblayer environment: - The PrefService is passed via user_prefs::UserPrefs::Get() rather than via Profile::GetPrefs(). //weblayer's BrowserContextImpl has no getter for the PrefService, and as that getter is just a synonym for user_prefs::UserPrefs::Get() in //chrome, I see no reason to add it here. Note that this CL (and the bringup of support for Chrome's captive portal detection in WebLayer) will have no impact on Android, where Chrome's captive portal detection service is not enabled as SSLErrorHandler relies on the OS support. As this is the first instance of a KeyedServiceFactory in //weblayer, this CL also brings up the KeyedServiceFactory infrastructure in the //weblayer embedder. Bug: 1030692 Change-Id: Ic24c8a003f53598f9dd08f0da0ac87869398074f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2022671Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#736777}
-
Hirokazu Honda authored
VDAs used on ChromeOS logs real errors with VLOG(1). A verbose level in media/gpu is not set, so that these logs are not left in chrome log. This is hard for us to figure out issues from user reports. This replaces VLOG(1) for real errors with LOG(ERROR) in VDAs used on ChromeOS. Bug: b:146518063 Test: vda_test on kevin and hatch Change-Id: Ic2e7b3da9e5aba5ab6dd582888b7c0a0b6d29a97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2027010 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Alexandre Courbot <acourbot@chromium.org> Cr-Commit-Position: refs/heads/master@{#736776}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/4a6c9b66c515..b12649462ca2 git log 4a6c9b66c515..b12649462ca2 --date=short --first-parent --format='%ad %ae %s' 2020-01-30 mathias@chromium.org [e2e] Support limiting the search to a given root node Created with: gclient setdep -r src/third_party/devtools-frontend/src@b12649462ca2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1044632 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I01aacea67ee4e324ed66536628a1c0dd147c21f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2029284Reviewed-by:
-
Ioana Pandele authored
This reverts commit cbe25387. Reason for revert:Breaks compile on chromeos-amd64-generic-rel. "./../components/metrics/structured/key_data.cc:18:10: fatal error: 'tools/metrics/structured/structured_events.h' file not found #include "tools/metrics/structured/structured_events.h"" Original change's description: > [Structured metrics] Rearrange build files > > Currently, the generated classes for each event are created under the > //tools/metrics/structured target. I don't think this is the intended > use of the tools directory, because chrome targets explicitely can't > depend on it, and so can't access the generated events. > > This CL moves the codegen targets to //components/metrics/structured, > which is accessible from chrome (and just makes more sense). > > Bug: 1016655 > Change-Id: I6a295486a3dad094b44db67d70408c8629728bcc > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2029531 > Commit-Queue: Tony Yeoman <tby@chromium.org> > Auto-Submit: Tony Yeoman <tby@chromium.org> > Reviewed-by: Jia Meng <jiameng@chromium.org> > Cr-Commit-Position: refs/heads/master@{#736753} TBR=jiameng@chromium.org,tby@chromium.org Change-Id: Ic631a141d60e35e5a224d64d355ca1662e4c4c80 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1016655 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2029509Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Commit-Queue: Ioana Pandele <ioanap@chromium.org> Cr-Commit-Position: refs/heads/master@{#736774}
-
Trevor Perrier authored
This CL makes it so that all locales are used during resource_packaging for bundle builds. It is a reland of: https://crrev.com/c/2024159 which included the new locales on APK builds and was reverted. Before this change all language splits for the 27 + 9 new languages recently added to Clank were about half the size as older languages in monochrome_public_bundle.apks After this change the new languages and old languages are about the same size in monochrome_public_bundle.apks. Example Before (af,as, az, be, bn, and bs are new languages): 158921 2001-01-01 00:00 splits/base-af.apk 424765 2001-01-01 00:00 splits/base-am.apk 432527 2001-01-01 00:00 splits/base-ar.apk 226815 2001-01-01 00:00 splits/base-as.apk 165763 2001-01-01 00:00 splits/base-az.apk 203683 2001-01-01 00:00 splits/base-be.apk 473236 2001-01-01 00:00 splits/base-bg.apk 234710 2001-01-01 00:00 splits/base-bn.apk 163986 2001-01-01 00:00 splits/base-bs.apk Example After: 305787 2001-01-01 00:00 splits/base-af.apk 424765 2001-01-01 00:00 splits/base-am.apk 432527 2001-01-01 00:00 splits/base-ar.apk 569512 2001-01-01 00:00 splits/base-as.apk 325961 2001-01-01 00:00 splits/base-az.apk 468522 2001-01-01 00:00 splits/base-be.apk 473236 2001-01-01 00:00 splits/base-bg.apk 577862 2001-01-01 00:00 splits/base-bn.apk 324504 2001-01-01 00:00 splits/base-bs.apk Bug: 1035665 1046654 Change-Id: I4928e62ac29b35bf6c19508a70834149eabaaa82 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2029232Reviewed-by:
Megan Jablonski <megjablon@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Trevor Perrier <perrier@chromium.org> Cr-Commit-Position: refs/heads/master@{#736773}
-
Kenichi Ishibashi authored
Change the signature of the callback of FindRegistration methods to remove ServiceWorkerRegistration dependency from ServiceWorkerStorage. ServiceWorkerRegistration instantiation has been moved to ServiceWorkerRegistry. As a side effect ServiceWorkerDatabase::RegistrationData and ResourceList are allocated on heap instead of stack when FindRegistration methods are called. However this wouldn't have performance impacts because we only allocate them only when we look up database. Bug: 1039200 Change-Id: Ic7b543b50e59b37f861f3d37d074839186616643 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015863 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#736772}
-
Boris Sazonov authored
Reimplement GetPrimaryAccountId/HasPrimaryAccount in IdentityManager.java as helpers on top of GetPrimaryAccountInfo instead of standalone methods that are routed through JNI separately. This makes the code more concise, facilitates mocking and simplifies future changes to these methods. Bug: 1046746 Change-Id: I8bfb715cb562b957849ca6e272a1731c17d98194 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026573 Commit-Queue: David Roger <droger@chromium.org> Auto-Submit: Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#736771}
-
Friedrich Horschig authored
With this CL, the password_autofill_manager will push updates to the popup once the "unlock passwords" button is clicked. First, the clicked button will disappear (later: show a throbber). Second, the popup will show all passwords once they arrive (later: an empty state message if no additional passwords were found). To do that, the manager will pin the popup view so that it waits for updates and remove the unlock button. Bug: 1043963 Change-Id: I8a8db6a1bdc6d25b6c097202ab2a93914cddd9cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020966Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/25bcd6a6215e..f1c330bde24f git log 25bcd6a6215e..f1c330bde24f --date=short --first-parent --format='%ad %ae %s' 2020-01-30 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/skia@f1c330bde24f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC reed@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: reed@google.com Change-Id: I7bb15e642baac6eae9d46fe426a7bd108d7cf4f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2030031Reviewed-by:
-
Simon Zünd authored
The upcoming source map asyncification turns {addBinding} and {removeBinding} into async functions. This CL adds some {await}s in two web tests where they are needed. R=sigurds@chromium.org Bug: chromium:1032016 Change-Id: I9975c545af8746efd0d580339a4e6ca9573dd053 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2027468 Commit-Queue: Simon Zünd <szuend@chromium.org> Reviewed-by:Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#736768}
-
Jinsuk Kim authored
In order to prevent a runnable |mDetachRefreshLayoutRunnable| from being invoked after |SwipeRefreshLayout| is set to zero, this CL adds a missing null check. Bug: 1045952 Change-Id: I48bf09831a42dccda3f38b1101184a27caf0218c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028870 Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#736767}
-
Hiroki Sato authored
Previously, when the root node in ARC gets focus from ChromeVox, ChromeVox reads the entire window content. This CL prevents it by assigning the window title to the root node. Bug: None (preparation of b:148356674) Test: unit_tests --gtest_filter="AXTreeSourceArcTest.*" Change-Id: I884e2c19188468c48f6c26a4d4cb3eb72dc31144 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024635 Commit-Queue: Hiroki Sato <hirokisato@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Reviewed-by:
Sara Kato <sarakato@chromium.org> Cr-Commit-Position: refs/heads/master@{#736766}
-
Luciano Pacheco authored
Initial layout, sizes, colors, font and icons for file list header. It still needs a few touches in the colors and hover/ripple effects. Remove fill color from arrow up/down SVG icons so it's controlled by CSS. These 2 files weren't used before this CL. Bug: 992821 Change-Id: I51ed93ff93506592612d7da8cc1b5cd9a6f2f934 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2018564Reviewed-by:
Alex Danilo <adanilo@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#736765}
-
Julian Watson authored
The explicit destructor is pessimising performance by preventing the move constructor from being generated. Change-Id: Ia595d72a631decd522e22189fe42ec235fd7e381 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2029402 Commit-Queue: Julian Watson <juwa@google.com> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Auto-Submit: Julian Watson <juwa@google.com> Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#736764}
-
Rune Lillesveen authored
We used to have a root element color value based on an internal UA sheet value, but this is not according to spec since it affects the initial value for the color property, hence setting the color value to 'initial' should result in a used value that depends on the color-scheme for that element. Initial value for the color property is canvastext, but we do not yet ship color-scheme aware system colors, so instead we implement this as a method on ComputedStyle which is color-scheme aware and currently return black for light and white for dark. The devtools test changes are basically a revert of the necessary changes done when we introduced -internal-root-color. Bug: 939811 Change-Id: I63477751e1fe4aa3ce8292e8a3fc2cdb1dd3afbd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2027469 Commit-Queue: Rune Lillesveen <futhark@chromium.org> Reviewed-by:
-
Takuto Ikuta authored
https://chromium.googlesource.com/infra/luci/client-py.git/+log/885b3febcc17..0ac28472d073 $ git log 885b3febc..0ac28472d --date=short --no-merges --format='%ad %ae %s' 2020-01-29 tikuta client: do not use isolated in win7 2020-01-28 tikuta [client] use go isolated client other than win7 32bit bots 2020-01-24 tikuta [swarming] use go isolated when cipd is enabled on windows10 2020-01-23 tikuta Revert "[swarming] use go isolated when cipd is enabled on windows" 2020-01-22 tikuta [swarming] use go isolated when cipd is enabled on windows 2020-01-22 tikuta [client] update isolated 2020-01-22 tikuta [client] roll infra_libs 2020-01-21 tikuta [client] followup for crrev.com/c/2009949 2020-01-20 tikuta [client] make dir after clobbering cache directory 2020-01-20 tikuta [client] update lru version 2020-01-20 tikuta [client] show GiB for large size 2020-01-20 tikuta [client] fix total_size 2020-01-17 tikuta Revert "[client] do not apply clean for isolate_cache" 2020-01-17 tikuta Revert "Reland "Reland "[swarming] use go isolated when cipd is enabled by default""" 2020-01-17 tikuta Reland "Reland "[swarming] use go isolated when cipd is enabled by default"" 2020-01-17 tikuta [client] fix lru_test.LRUDictTest 2020-01-16 jojwang Add Google API protobufs 2020-01-16 tikuta [client] update isolated 2020-01-16 tikuta Revert "Reland "[swarming] use go isolated when cipd is enabled by default"" 2020-01-15 tikuta Reland "[swarming] use go isolated when cipd is enabled by default" 2020-01-15 tikuta [client] do not apply clean for isolate_cache 2020-01-14 tikuta Revert "[swarming] use go isolated when cipd is enabled by default" 2020-01-14 tikuta [client] include more info in ValueError 2020-01-14 tikuta [swarming] use go isolated when cipd is enabled by default 2020-01-14 tikuta [client] do not use data.isolate_cache when go isolated is used 2020-01-10 tikuta [client] pass cache parameter explicitly for go isolated 2020-01-08 tikuta Revert "run_isolated: fallback to python if go failed" 2020-01-08 tikuta [client] remove --go-cache-dir 2020-01-08 tikuta [client] update isolated 2020-01-08 tikuta [swarming] log content of path when we see UnicodeDecodeError 2019-12-17 agable Fix test_fix_url for python 3.8.1 2019-12-13 tikuta client: clobber cache when failed to load state file 2019-12-13 tikuta Revert "swarming: rename isolated_cache to isolated_cache_python" 2019-12-13 tikuta Revert "4th Reland "task_runner: enable go isolated client"" 2019-12-12 tikuta swarming: rename isolated_cache to isolated_cache_python 2019-12-12 tikuta 4th Reland "task_runner: enable go isolated client" 2019-12-11 tikuta run_isolated: fallback to python if go failed 2019-12-11 tikuta Revert "Reland "Reland "Reland "task_runner: enable go isolated client"""" 2019-12-10 tikuta Reland "Reland "Reland "task_runner: enable go isolated client""" 2019-12-09 tikuta Revert "Reland "Reland "task_runner: enable go isolated client""" 2019-12-09 tikuta run_isolated: remove --use-symlink flag 2019-12-06 tikuta Reland "Reland "task_runner: enable go isolated client"" 2019-12-05 tikuta run_isolated: update isolated client 2019-12-04 jwata [luci-py] fix jwata address in owners files 2019-12-03 tikuta run_isolated: update isolated client 2019-12-03 tikuta run_isolated: add --go-cache-dir flag 2019-12-03 tikuta run_isolated: update isolated client revision 2019-12-03 tikuta run_isolated: change type to str in args 2019-12-02 tikuta Revert "subprocess42: accept non-str arg" 2019-12-02 jwata [swarming] remove test_seq.py (...) 2019-10-29 tikuta client: replace ' unicode(' with ' six.text_type(' 2019-10-29 tikuta Handle sys.platform difference between Python2 and Python3 2019-10-29 tikuta client: change shebang of zip_package_test.py 2019-10-29 tikuta Reland "client: make zip_package_test.py run on Python3" 2019-10-29 tikuta Revert "client: make zip_package_test.py run on Python3" 2019-10-29 tikuta client: make zip_package_test.py run on Python3 2019-10-28 tikuta replace logging.warn with logging.warning 2019-10-28 tikuta client: make logging_utils_test.py run on Python3 2019-10-28 jwata [swarming] skip tests failing on mac 2019-10-28 tikuta client: fix indent in isolate_format.py 2019-10-28 tikuta client: use str string for python2 instead of unicode for extend/trim 2019-10-28 tikuta client: use extend in fs.readlink 2019-10-25 tikuta client: make isolated_format_test.py run on Python3 2019-10-25 tikuta client: use six.moves for some renamed modules in Python3 2019-10-25 jwata [swarming] remove test_support symlink from client and bot 2019-10-25 tikuta client: add missing encode in isolate_format.py 2019-10-25 tikuta make: isolate_format_test.py run on Python3 2019-10-25 tikuta client: update shebang for fs_test.py 2019-10-24 tikuta client: fix syntax warning in isolate_format.py 2019-10-24 tikuta client: tools_test.py can run in python3 2019-10-24 tikuta client: make fs_test.py run on Python3 2019-10-24 tikuta client: make auth_server_test.py run on Python3 2019-10-24 tikuta client: make file_path_test.py python3 compatible 2019-10-24 tikuta client: fix SyntaxWarning 2019-10-24 tikuta client: make _monkey_patch_oauth2client_locked_file run on Py2/3 2019-10-23 tikuta client: make extend/trim in fs for POSIX nop 2019-10-23 tikuta client: auth_test.py runs on python3 2019-10-23 tikuta client: make net_test.py run on Python3 2019-10-23 tikuta client: apply futurize stage1 under client/tests/ 2019-10-23 tikuta client: make large_test.py python3 compatible 2019-10-23 tikuta client: make lru_test.py python3 compatible 2019-10-21 jwata [luci-py] move failing tests to test_seq.py 2019-10-21 tikuta client: make luci_context_test.py run on python3 2019-10-21 jwata [swarming] delete old blacklist file pattern 2019-10-21 jwata [luci-py] Setup test runner for client, components, auth_service, config_service 2019-10-20 tikuta client: make test_env.py python3 compatible 2019-10-18 tikuta swarming: replace unicde with six.text_type 2019-10-18 tikuta roll depot_tools to 989bc351863dd6cbb7e645a027a3c5e04104e44f 2019-10-17 tikuta add jwata@google.com as OWNERS for swarming and client 2019-10-16 tikuta Specify vpython in shebang for test 2019-10-10 maruel Migrate print to python3 format. 2019-10-10 maruel Migrate remaining use of urllib to six.moves 2019-10-10 maruel Use six.moves to import urlparse to be python3 compatible 2019-10-10 maruel [client] Allow packages in utils/ to be imported at interactive prompt 2019-10-10 maruel Get rid of xrange 2019-10-09 maruel Update dict usage to be python3 compatible 2019-10-03 tikuta Revert "client: increase the number of io worker threads" 2019-09-30 tikuta client: fix typo 2019-09-26 tikuta client: fix comment posisition 2019-09-23 tikuta client: improve error message for too long command line args Created with: roll-dep src/tools/swarming_client Bug: 984869 Change-Id: Id6edf75d02fc4db3def3a428b3131cbb755d3d1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026514 Auto-Submit: Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
Yoshisato Yanagisawa <yyanagisawa@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#736762}
-
Takuto Ikuta authored
No-Try: true Bug: 955013 Change-Id: Id0c8835aa3af57b770d501d5010c9f456318fefa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2029398 Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Auto-Submit: Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
Yoshisato Yanagisawa <yyanagisawa@google.com> Cr-Commit-Position: refs/heads/master@{#736761}
-
Hitoshi Yoshida authored
If an IDL dictionary that is directly derived from DictionaryBase and has no inherited class, its Trace can be non-virtual. However, to make it consistent, this CL makes DictionaryBase's Trace virtual and make generated dictionaries override it. Bug: 839389 Change-Id: I3e897b4dbdd9ba944ae3eeb1bf3c9011718decd2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026629Reviewed-by:
-
shrekshao authored
Reland the CL with following fixes: * We still use DIRECT_DRAW as the copy method used when the source effective internal format's corresponding type is UNSIGNED_SHORT and it's unmatched with that of the dest. Since the spec doesn't require implementations to support this conversion. And failure of conversion is seen on Android Nvidia shield tablet devices. * Suppress ext-texture-norm16 test failure on win intel. * Add some copy texture format combinations in gl_tests. Skip RGBA16 to RGB10_A2 on Mac and Linux Intel. Original CL: https://chromium-review.googlesource.com/c/chromium/src/+/1907195 Bug: 1000354, 1042252, 1042239, 1042246, 1046873 Change-Id: I96fe001fe261ceff4cf8bc82e548544456cb11e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003080Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Shrek Shao <shrekshao@google.com> Cr-Commit-Position: refs/heads/master@{#736759}
-
