- 20 Jul, 2020 40 commits
-
-
ckitagawa authored
Break cyclic dependency of PlayerFrameMediator with - PlayerFrameScaleController - PlayerFrameScrollController BitmapState is tightly coupled to PlayerFrameMediator with good reason so a cyclic dependency there is somewhat unavoidable. This is achieved by having PlayerFrameCoordinator instantiate everything and then introducing a new class that handles dispatch of gestures. A helper for scaling is also added to break the two-way interdependence that existed in the mediator. Bug: 1099722 Change-Id: I13b258d973a5ff81cdf75505f59aabb02d66a6c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2295751 Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org> Reviewed-by:
Mehran Mahmoudi <mahmoudi@chromium.org> Reviewed-by:
Fred Mello <fredmello@chromium.org> Cr-Commit-Position: refs/heads/master@{#789996}
-
Nnamdi Theodore Johnson-Kanu authored
Bug: 1045266 Change-Id: Ife06c03e0de7ee59cd74c1d65c67e4465928b85c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303876 Commit-Queue: Nnamdi Theodore Johnson-kanu <tjohnsonkanu@google.com> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#789995}
-
Collin Baker authored
This removes code left from in-product help for new tabs, bookmarks, and incognito mode. These were last used in 2017. A new approach is taken for recent in-product help. Bug: 1106523 Change-Id: I893c3c53ef44a7a37f169fde6d3db2880935c5dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303969 Auto-Submit: Collin Baker <collinbaker@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Commit-Queue: Collin Baker <collinbaker@chromium.org> Cr-Commit-Position: refs/heads/master@{#789994}
-
Deepanjan Roy authored
We have a lab metric to track console error messages in telemetry stories, and when the count changes it is quite difficult to figure out what the new message is. This CL adds the error message and the url to the trace event. We will surface this information in the UI for easier debugging. Bug: 1086962 Change-Id: Ibeb739c7624941f7437f39e5087fbe574a782cf9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302837 Commit-Queue: Deep Roy <dproy@chromium.org> Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#789993}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/ea6f21a052c9..9e46bb61c5d7 2020-07-20 capn@google.com Support _PACK32 storage image formats and fix asserts If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I6d8f51afe7d7c35e8e3e53820bd703d631aaff12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2307482Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#789992}
-
Samuel Huang authored
Compile failure in AppServiceAppWindowArcAppBrowserTest.LogicalWindowId arises from signed / unsigned comparison: std::count_if() returns a signed type, but the EXPECT_EQ used an unsigned value. This issue has been causing Builder chromeos-kevin-builder-perf-fyi to fail since start of 2020-06. Bug: 1106626 Change-Id: I4278161ad2533ac566bf78851ceedbada841fa6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302834Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Philipp Weiß <phweiss@chromium.org> Commit-Queue: Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#789991}
-
David Bertoni authored
This tests were previously flaky, crashing during shutdown. Waiting for the storage partition cleanup tasks to finish fixes these crashes, which were happening because the temp directory for the test was being deleted while cleanup tasks were trying to run. Also, global state needs to be cleared between tests, since it could cause tests to fail, depending on run order. Bug: 836332, 839371 Change-Id: Ie440f035ac6778c723d7ae63d8f4f9f640158230 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2288354 Commit-Queue: David Bertoni <dbertoni@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#789990}
-
Himanshu Jaju authored
Updates wire_format to latest internal version, will be used by upcoming changes for nearby share. Bug: 1085068 Change-Id: I7ac7796e9fb89f5efda5c950a3662ab6d8ab21a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2306046Reviewed-by:
Alex Chau <alexchau@chromium.org> Reviewed-by:
Alex Gough <ajgo@chromium.org> Commit-Queue: Himanshu Jaju <himanshujaju@chromium.org> Cr-Commit-Position: refs/heads/master@{#789989}
-
Tim Volodine authored
Do not enable real-time URL checks functionality when Safe Browsing is disabled. Also add documentation regarding this in WebLayer API. Note: Real-time URL checks can technically be enabled separately from the standard safe browsing, but this applies to enterprise users using Chrome Browser Cloud Management. This use case is currently only supported on Desktop platforms. It does not apply to Chrome on Android and WebLayer. BUG=1106358 Change-Id: Ib181aec6ed9466958d2a36eca83553fd33dc662b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302854Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Tim Volodine <timvolodine@chromium.org> Cr-Commit-Position: refs/heads/master@{#789988}
-
Robbie Gibson authored
Bug: 1098722 Change-Id: Icd9da0e758c288a44716fb6f5a505267a76f42b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302756 Commit-Queue: Robbie Gibson <rkgibson@google.com> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#789987}
-
Mohamed Heikal authored
Change-Id: Ie52f3a5986fb6f368cddba4449eca3cd2cf0a3b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2305043Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Mohamed Heikal <mheikal@chromium.org> Cr-Commit-Position: refs/heads/master@{#789986}
-
Mike Dougherty authored
Update the scroll amount to bring the Find In Page menu item more into view. Although it was previously visible, it was at the very bottom edge of the pop over menu which seems to have been a source of flaky failure even when running locally. grey_replaceText sometimes causes a crash locally, so replace with typeText as there is no need to clear the text first in any of these tests. Additionally, there is no longer two accessibility elements with the same ID, and on iOS 12 the item with the accessibilityID is not an accessibilityElement. Simplify typeFindInPageText Fixed: 1029709 , 1030701 Change-Id: I7fca1bc87160b5404c40e592143e6841fee848cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303453 Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Auto-Submit: Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#789985}
-
Kyle Horimoto authored
A recent refactor [1] allowed KerberosCredentialsManager to be null for secondary users. This CL adds a missing null check which fixes a crash for multi-profile users. [1] https://chromium-review.googlesource.com/c/chromium/src/+/2291317 Fixed: 1106721 Change-Id: Ib66eab34c84a6b0b6cce63b4d610af346dbfad77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2306821 Auto-Submit: Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Regan Hsu <hsuregan@chromium.org> Reviewed-by:
Regan Hsu <hsuregan@chromium.org> Cr-Commit-Position: refs/heads/master@{#789984}
-
Sophie Chang authored
Bug: 1099371 Change-Id: If25b554b8316f64078325e1411872c33f7c2f5e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303861Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Commit-Queue: Sophie Chang <sophiechang@chromium.org> Cr-Commit-Position: refs/heads/master@{#789983}
-
Omid Tourzan authored
There are 2 messages for time display as it may show time in 2 parts like '1 hour 2 min' or 1 part like '2 hours' or '3 min'. We already have Dismiss label but its ID and usage is for drive banner. Added this new one as a general one to prevent confusion when referencing in the code or changing the other one. Bug: 953308 Change-Id: I7b7a2603e81ab8aea36a518d334546e1c4b8c905 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2306112Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Omid Tourzan <oto@chromium.org> Cr-Commit-Position: refs/heads/master@{#789982}
-
Mugdha Lakhani authored
Delete prerender browsertests that verify referrer policy and add equivalent tests to NoStatePrefetch. Please see this spreadsheet for details: https://docs.google.com/spreadsheets/d/1LFPB4UhPWQkBRz481lz49zmS25znhjSDUtagtTTSPQo/edit?usp=sharing Bug: 898955 Change-Id: I33e5fb9738abee2d5103c26d9ea0c345e0aa1213 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2299231 Commit-Queue: Mugdha Lakhani <nator@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#789981}
-
Javier Fernandez authored
We still lack the layout logic to support the 'last baseline' keyword value, defined in the CSS Box Alignment specification [1]. This keyword must be implemented by Flexbox and Grid, at least, before we can enable the parse again. [1] https://drafts.csswg.org/css-align/#valdef-justify-self-last-baseline Bug: 1102665, 886585, 885175 Change-Id: I06d43185086404fe471a033fc084c950ef115f5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300086 Commit-Queue: Javier Fernandez <jfernandez@igalia.com> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#789980}
-
Andrew Grieve authored
Suppression was recently removed, but it looks to still by needed for chromecast targets: https://ci.chromium.org/p/chromium/builders/try/cast_shell_android/592386 Bug: 1017190 Change-Id: I42db833add3ce07718e3f7d5ebfa66ff153ccc43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2306581 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Commit-Queue: Peter Wen <wnwen@chromium.org> Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#789979}
-
Tim Volodine authored
Failing on L/M Tablet bots. BUG=1107395 TBR=dtrainor@chromium.org Change-Id: Icfc80b3973bb70bdb5eaedf93e4a784584170208 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2307223Reviewed-by:
Tim Volodine <timvolodine@chromium.org> Commit-Queue: Tim Volodine <timvolodine@chromium.org> Cr-Commit-Position: refs/heads/master@{#789978}
-
Sebastien Marchand authored
This will make it possible to do page discarding from other policies. Change-Id: I0ddc0d5a2e60a873d8c295b76c0b482427967b7d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303774Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Cr-Commit-Position: refs/heads/master@{#789977}
-
David Bienvenu authored
GetChromiumModelIdForProfile passes the result of GetBrowserModelId to BuildAppModelId, but GetBrowserModelId calls BuildAppModelId. Conceptually, it's cleaner if BuildAppModelId is always the last step in computing an app model id. To do this, we have to extract out a method to shorten an app model id component, so that GetBrowserModelId can use it, instead of using BuildAppModelId. Change-Id: I633c41b83bfc14c52bb4b5e364bce8dfc68cdde2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304162 Commit-Queue: David Bienvenu <davidbienvenu@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#789976}
-
Chris Sharp authored
Bug: 1018157 Change-Id: Iedb5ab2a582c4c66b4a5f7b89109581c73f12e19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2296060 Commit-Queue: Chris Sharp <csharp@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#789975}
-
Lei Zhang authored
OutOfProcessInstance requires PPAPI dependencies. So split it away from the "internal" target, which is migrating away from PPAPI. Bug: 1103478 Change-Id: Id17208b497b4f2e45c015fc702b82d1c16282771 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2293326 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Daniel Hosseinian <dhoss@chromium.org> Cr-Commit-Position: refs/heads/master@{#789974}
-
Darwin Huang authored
|plain_text| was added in https://crrev.com/c/2243532/. It was used in earlier patchsets of the CL, but not by the time it was submitted. Change-Id: Ica681acb88455d9c29f8e0189dd8c4c88569e058 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2296480 Auto-Submit: Darwin Huang <huangdarwin@chromium.org> Commit-Queue: Jarryd Goodman <jarrydg@chromium.org> Reviewed-by:
Jarryd Goodman <jarrydg@chromium.org> Cr-Commit-Position: refs/heads/master@{#789973}
-
Dave Tapuska authored
- Move cc::BrowserControlParams into CC - Move definition of VisualProperties into blink and use a typemap - Add typemapping for LocalSurfaceIdAllocation for blink too. - Add mojom_traits for ScreenInfo and VisualProperties. BUG=1097816 Change-Id: I8e0742d74438ef489020aecbb03cb6b5bbb55763 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2299525Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#789972}
-
Kramer Ge authored
gl_tests_passthrough are failing on Linux FYI Release (AMD R7 240) because both use_virtualized_gl_contexts and use_passthrough_cmd_decoder are true. Bug: 41017049 Change-Id: I03ac645a90db613adb53b254fdf7729bcdeac30d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2307171Reviewed-by:
Peng Huang <penghuang@chromium.org> Commit-Queue: Kramer Ge <fangzhoug@chromium.org> Cr-Commit-Position: refs/heads/master@{#789971}
-
Majid Valipour authored
Currently the sms_service_unittests only exercises the verification backend which is not actually active by default since we are currently using User Consent backend. More than half the tests (10 out of 10) seems to apply to both backends. This patch refactors the logic so that the backend specific part of sms service are well encapsulated. It then updates the test so these common tests are exercised with both backends. Changes: - Introduce UserConsentHandler with two specific implementation 1. Noop: which does not show any UI to user and is used with user consent backend. 2. PromptBased: which prompts user to give consent and is used with verification backend. This encapsulates previous OpenInfoBar, OnCancel, OnConfirm methods from sms service. - The consent handler is created on construction of the service and is used for its lifetime. This makes it possible to easily inject mock consent handlers for testing. - Update mock Service to use a simple Noop consent handler for common tests which don't involve consent. - Introduce a more specialized ServiceWithPrompt that uses a prompt based consent handler for tests specific to prompt based logic. - Add unit tests for consent handlers. - Minor renaming, comments to clarify the code further. There is not expected to be any functional changes in this CL. Change-Id: I411bf9d12cb7a2051e545ce6dd8a50fe37204326 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254447Reviewed-by:Sam Goto <goto@chromium.org> Commit-Queue: Majid Valipour <majidvp@chromium.org> Cr-Commit-Position: refs/heads/master@{#789970}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 0b12cba1. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma@google.com No-Export: true Change-Id: Id42e40844442630aa6da2992273855da753cb83a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2305920Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#789969}
-
Carlos Caballero authored
This will allow us to make sure that the frame is current before showing any UI prompt to users. E.g. we do not what to show prompts for pages that are in the bfcache. The actual checks will be added in https://crrev.com/c/2307212 Change-Id: I0ba28d8ef089e3deec0e89cc2239ee8bd1890a32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236437 Commit-Queue: Carlos Caballero <carlscab@google.com> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Sreeja Kamishetty <sreejakshetty@chromium.org> Cr-Commit-Position: refs/heads/master@{#789968}
-
Jun Mukai authored
This CL introduces specific views_delegate implementation and screen, a window tree host, and some aura clients to make the views_examples working with target_os="chromeos". Bug: 1106480 Test: manually checking views_examples Change-Id: I25a8fc26d35e91452bd1bcee98f4b3bcecbd5021 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304098 Commit-Queue: Jun Mukai <mukai@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Cr-Commit-Position: refs/heads/master@{#789967}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/3ba1777cebcd..16fbc2477205 2020-07-20 jlavrova@google.com Reland "ICU API: only in SkParagraph, simplified (relanding reverted)." 2020-07-20 adlai@google.com Remove more GrContext imports & usage 2020-07-20 brianosman@google.com SkVertices: Fix calculation of size needed for attr marker names 2020-07-20 kjlubick@google.com [canvaskit] Make effect deserialization on for everything but npm. 2020-07-20 kjlubick@google.com [canvaskit] Enable some options on npm build 2020-07-20 egdaniel@google.com Fix vulkan unmapping of buffers during release. 2020-07-20 kjlubick@google.com [pathkit] Publish 0.7.0 to npm 2020-07-20 kjlubick@google.com [canvaskit] Publish 0.17.0 to npm 2020-07-20 johnstiles@google.com Move test code out of header into CPP file. 2020-07-20 kjlubick@google.com Fix more swiftshader links 2020-07-20 michaelludwig@google.com Respect SK_FORCE_8_BYTE_ALIGNMENT in GrBlockAllocator 2020-07-20 robertphillips@google.com Clean up some GrContext in tests If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC robertphillips@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1106889,chromium:1107173 Tbr: robertphillips@google.com Change-Id: I4277e2203f85140166cd06bea19cb3614987f9fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2307510Reviewed-by:
-
Jarryd authored
Bug: 1089336 Change-Id: I46edfeea4c7774ed73b7e1c78a394d0e906e8848 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2281204 Commit-Queue: Jarryd Goodman <jarrydg@chromium.org> Auto-Submit: Jarryd Goodman <jarrydg@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#789965}
-
Mugdha Lakhani authored
PrerenderHttpAuthentication has been deleted from Prerender browsertests, and an equivalent test added to NoStatePrefetch tests. Please see this spreadsheet for details: https://docs.google.com/spreadsheets/d/1LFPB4UhPWQkBRz481lz49zmS25znhjSDUtagtTTSPQo/edit?usp=sharing Bug: 898955 Change-Id: I539097682d2b842519538cb417c2e31ca1613f26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2297563 Commit-Queue: Mugdha Lakhani <nator@chromium.org> Reviewed-by:
-
Gang Wu authored
This is a reland of 5d52e576 Original change's description: > Reland "Reland "[Omnibox] Use ActivityState to check if we are in browser mode"" > > This is a reland of 5ae112d1 > > Original change's description: > > Reland "[Omnibox] Use ActivityState to check if we are in browser mode" > > > > This is a reland of be1e9636 > > > > Update the test to run on UI thread. > > > > Original change's description: > > > [Omnibox] Use ActivityState to check if we are in browser mode > > > > > > > > > In multi windows mode, check if we are in browser mode by WindowAndroid > > > is not working, should check ActivityState instead. > > > > > > Bug: 1102640 > > > Change-Id: I35a720a2aa6f337cc9f9ae43e39d83c9368fcb5a > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2286478 > > > Commit-Queue: Gang Wu <gangwu@chromium.org> > > > Reviewed-by: Ted Choc <tedchoc@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#786636} > > > > Bug: 1102640 > > Change-Id: Iefba5a5d0c181535bd7fb86cf0e073be2ebdbcdb > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2293074 > > Reviewed-by: Ted Choc <tedchoc@chromium.org> > > Commit-Queue: Gang Wu <gangwu@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#788816} > > Bug: 1102640 > Change-Id: I6da3c7ad8402cef83083a53f7ffc517f975720f8 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2301285 > Commit-Queue: Gang Wu <gangwu@chromium.org> > Reviewed-by: Ted Choc <tedchoc@chromium.org> > Cr-Commit-Position: refs/heads/master@{#789727} Bug: 1102640 Change-Id: Ib1a0f38d107df76dd0b6e7f3595c57f3fb066a33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2306823Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Gang Wu <gangwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#789963}
-
Maksim Moskvitin authored
The test is constantly failing on linux-chromeos builders. TBR=emaxx@chromium.org,cylai@google.com Bug: 1107426 Change-Id: I2ec9626bb2076d9382d8186578628a621b127bf6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2307334Reviewed-by:
Maksim Moskvitin <mmoskvitin@google.com> Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com> Cr-Commit-Position: refs/heads/master@{#789962}
-
Michael Spang authored
This is necessary to remove uses of the deprecated TaskEnvironment::DeprecatedGetMockClock function in tests. Change-Id: I56425b2bcc81b21d93c69c683b4134ee389704cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2306374Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Commit-Queue: Michael Spang <spang@chromium.org> Cr-Commit-Position: refs/heads/master@{#789961}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/google/shaderc/+log/13480cb0ab94..6af6e625573f 2020-07-20 bclayton@google.com Update license-checker.cfg with simplified rules (#1107) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/shaderc-chromium-autoroll Please CC radial-bots+chrome-roll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: radial-bots+chrome-roll@google.com Change-Id: Ieb80823dfd03930eb879d200914a8fe6b1e4eab1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2307473Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/fd5df6887258..fa504e744f9b 2020-07-20 dminor@webrtc.org Check that capture time is valid before adjusting it. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I5cdb06394e116ab0e81f8b08bb6c177d13e94524 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2307479Reviewed-by:
-
Boris Sazonov authored
Replaces ChromeSigninController usage in AndroidSyncSettings ctor with IdentityManager. Bug: 1093998 Change-Id: I56fc23be5f2849288d2aa425ccb90a7a5a385263 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2289972 Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#789958}
-
Meera Srinivasan authored
Change-Id: Ifb0e6255745bf0e25919e53c5c463ad30de9a4bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304964 Commit-Queue: Joe Downing <joedow@chromium.org> Reviewed-by:
Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#789957}
-
