GitLab

Added a id to replace tab_id as unique
identifier for the webviews that are created from the
platform views service.  The tab_id was always 0
because is_root_frame is true on creation.
Subsequent lookups for the ax tree id by tab id
were only working by chance. The linear search for the
tab id among the list of windows always matches the
first one found, which was the correct one.  This ensures
tab ids will be unique.

Bug: None
Test: display assistant created webviews followed by navigation
      causing render frames to be swapped

Change-Id: Ib6b9f1fd217367423f15965e5b760df1f170caa8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342640
Commit-Queue: Randy Rossi <rmrossi@chromium.org>
Reviewed-by: Daniel Nicoara <dnicoara@chromium.org>
Cr-Commit-Position: refs/heads/master@{#796903}

Follow guidance by reillyg@ in crrev.com/c/2314024 to discourage
clients other than Nearby from using [Sync] methods on adapter.mojom.

Change-Id: Ic71e1330747b240ba3f153ac96f6cbab0f375701
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2347166Reviewed-by: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Ryan Hansberry <hansberry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#796902}

Bug: 1114873
Change-Id: Ie2a30e03680172546052c00b83e8f10bf1be0dce
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346974
Commit-Queue: Arthur Eubanks <aeubanks@google.com>
Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Cr-Commit-Position: refs/heads/master@{#796901}

https://skia.googlesource.com/skia.git/+log/5edf510941a3..49983ef4e7de

2020-08-11 brianosman@google.com Runtime effect: Gather uniforms in one pass
2020-08-11 jvanverth@google.com MSAA improvements for Direct3D.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC fmalita@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Cq-Do-Not-Cancel-Tryjobs: true
Bug: None
Tbr: fmalita@google.com
Change-Id: Ie8779aa37fed168e1549ddec4c253ca0c10c867e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2348282Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#796900}

Takes into account the display_override manifest value when
determining if the PWA is installable.

For example, if the developer specifies:
  display: "browser"
  display_override: ["standalone"]

This should be installable, but prior to this change, chromium
would only evaluate the display property.

Since unsupported values are ignored when parsing the manifest,
only the first value in the parsed display_override array needs
to be evaluated.

To test the change use: chrome --enable-features=WebAppManifestDisplayOverride
Example websites:
 - (not installable) https://mwjacksonmsft.github.io/pwa/display-override-browser/index.html
 - (installable) https://mwjacksonmsft.github.io/pwa/display-override-custom/index.html

Explainer: https://github.com/WICG/display-override/blob/master/explainer.m
Design document: https://docs.google.com/document/d/1hEmbGVHMN38q1YTaaGccQ-Y5CHr7xIURYPRWXTuvZLo/edit?usp=sharing
I2P: https://groups.google.com/a/chromium.org/d/topic/blink-dev/WvIeZT8uSzw/discussion

Bug: 1109520
Change-Id: Ib3f7465ed36474b1166f136c3cd6655cc34add0e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333541
Commit-Queue: Mike Jackson <mjackson@microsoft.com>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Reviewed-by: Daniel Murphy <dmurph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#796899}

This is a reland of b545f589
The original cl failed in the MSAN test in
SupervisedUserNavigationThrottleTest::
AllowEDUCoexistenceInnerWebContents
where the inner WebContents is not attached by the time it is expected to.
This only happens in the MSAN test case. The fix simply delays the test
until it is sure that the inner WebContent is attached.

Bug: 1113054

Original change's description:
> Use only SafeSearch filter for EduCoexistence webview.
>
> This cl fixes the bug where the child user is stuck
> in EDU account addition flow when the user's parental
> control setting is 'Only allow certain sites'.
>
> Inorder to prevent this error from happening we will do
> only safe search filter for the EduCoexistence webview
> and not enforce the 'Only allow certain cites' settings
> potentially set by the child's parents.
>
> "https://accounts.google.com" is manually whitelisted. This
> is because there is a race condition where we don't know
> whether the WebContent is an inner WebContent belonging
> to EduCoexistence flow or not by the time throttling happens.
> This happens because navigation to accounts.google.com is
> started before the <webview> WebContents is attached to
> the outer WebContents hosted by the EduCoexistence flow WebUI.
>
> We are making this exception only to the webview that is present in
> the EDUCoexistence flow. The exception is made because the parent is
> present with the child during the flow. Extending this exception
> to every inner webcontents will may allow the child to break parental
> settings.
>
> Bug: 1079510
> Change-Id: I4f3e65e58537a845613b0c49b03f801f0a3caa08
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316443
> Reviewed-by: Marc Treib <treib@chromium.org>
> Reviewed-by: Aga Wronska <agawronska@chromium.org>
> Commit-Queue: Yilkal Abe <yilkal@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#794661}

Bug: 1079510
Change-Id: Ida69bb2fc63efbdbc3e06365290ddc2aed9790c3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2338856Reviewed-by: Marc Treib <treib@chromium.org>
Reviewed-by: Aga Wronska <agawronska@chromium.org>
Commit-Queue: Yilkal Abe <yilkal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#796898}

* Added logic to delay setting status icons on initialization
* Removed unnecessary logic to invoke setInitialState in the Mediator constructor

Bug: 1070620
Change-Id: I21174d0c874f56eb6ee218fa844bead1fe4a0451
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346285
Commit-Queue: Natalie Chouinard <chouinard@chromium.org>
Reviewed-by: Natalie Chouinard <chouinard@chromium.org>
Auto-Submit: Andrey Zaytsev <andzaytsev@google.com>
Cr-Commit-Position: refs/heads/master@{#796897}

This reverts commit 393e7114.

Reason for revert: Proper fix landed (see bug).

Original change's description:
> Reduce link pool to stop android-archive-rel OOM'ing
> 
> I'd like to still work on a fix that doesn't reduce the size for bots
> with less RAM, but need something quick'ish to fix bot.
> 
> Bug: 1098333
> Change-Id: Ifdfe8f07712e5073419ea0c0c0eb89092c31a1de
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2347384
> Commit-Queue: Andrew Grieve <agrieve@chromium.org>
> Commit-Queue: Dirk Pranke <dpranke@google.com>
> Auto-Submit: Andrew Grieve <agrieve@chromium.org>
> Reviewed-by: Dirk Pranke <dpranke@google.com>
> Cr-Commit-Position: refs/heads/master@{#796585}

TBR=dpranke@google.com,agrieve@chromium.org

Change-Id: I6b445001d0a8ab57d16f3ba2623906da1b509d37
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1098333
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2349398Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#796896}

instrumentation tests

I temporarily need to remove GOMA compilation. I can't seem to start
the GOMA proxy when running the recipe locally. I will be working with
LUCI users in order to figure out what to do for that. For the time
being I can work around this issue by removing GOMA compilation.

Bug: 1041619
Change-Id: Idab34e78b2ec0f6c8ea7e5517bb709096ed1aef1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346939Reviewed-by: Erik Staab <estaab@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Rakib Hasan <rmhasan@google.com>
Cr-Commit-Position: refs/heads/master@{#796895}

CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-chrome
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-chrome
TBR=chrome-os-gardeners@google.com

Change-Id: I9b6e20194d7697e70cf0e4a787d023ebe26af457
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2347316Reviewed-by: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com>
Commit-Queue: Jun Mukai <mukai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#796894}

This is the first step in the process of merging BrowserAccessibilityPosition and AXNodePosition into one class.
We need to adopt the same definition of an embedded object in both places.
This is the definition used by IA2 and ATK hypertext, which makes all non-textual nodes that are exposed to the platform APIs
into embedded objects.
Additionally, we include the definition used by UIA, which makes all empty leaf objects (objects with ignored descendants)
as embedded objects.

AX-Relnotes: n/a.

R=dmazzoni@chromium.org, aleventhal@chromium.org

Change-Id: I19bbc26f40d37a07b7dd6436fb0025505a0cfd89
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346653Reviewed-by: Aaron Leventhal <aleventhal@chromium.org>
Commit-Queue: Nektarios Paisios <nektar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#796893}

This test was disabled due to flakiness. Flakiness was fixed in
https://chromium-review.googlesource.com/c/chromium/src/+/2347392

BUG=1110429,1112931

Change-Id: Ia3eaa8c85d13761bc3934768e85a0faab6bc039c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2347403Reviewed-by: Aaron Colwell <acolwell@chromium.org>
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#796892}

https://android.googlesource.com/platform/external/perfetto.git/+log/01e0ccdc9b8b..21e5b4554a5f

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Tbr: perfetto-bugs@google.com
Change-Id: I5968ddcb8ea65eee86e30f71501716fbfb17f7f6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2347227Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#796891}

Bug: 1113521
Change-Id: I2eb4e2dfbe5de5d6b46ec1d22815cf014e90ec15
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2347979
Commit-Queue: Joey Arhar <jarhar@chromium.org>
Reviewed-by: Mason Freed <masonfreed@chromium.org>
Cr-Commit-Position: refs/heads/master@{#796890}

This crash happens under the following circumstances:
1. on android.
2. request manifest from WebContents.
3. ~WebContentsImpl

As part of WebContentsImpl deletion any outstanding requests for
manifests are run. The callback scheduled at 2 may trigger running
code in ContentFaviconDriver that attempts to use web_contents().
Problem is at this time WebContentsImpl has already set the
web_contents() of ContentFaviconDriver to null, and we crash.

Fix is to route the callback to ContentFaviconDriver and have
ContentFaviconDriver do nothing if web_contents() is null.

BUG=1114237
TEST=ContentFaviconDriverTest.WebContentsDeletedWithInProgressManifestRequest

Change-Id: I0e88884c1ea7a8ffacb443b65ba09786cf4f54c2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343718Reviewed-by: Peter Kotwicz <pkotwicz@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#796889}

Also flaky in Release and on Win10.

TBR=kbr

Bug: 772037
Change-Id: I6108376212d131c9972a47f3232614674b94beac
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2348696Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#796888}

Add case for setting localTime to null after having it set to a number.
Port to WPT infrastructure (testharness + reftest).

Bug: 870711
Change-Id: Iae22083f63004153666f4e119cf350f86c65eb55
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2348008
Commit-Queue: George Steel <gtsteel@chromium.org>
Reviewed-by: Kevin Ellis <kevers@chromium.org>
Cr-Commit-Position: refs/heads/master@{#796887}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ad052807cdc7..0b969adbdff1

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC ellyjones@google.com,apotapchuk@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: None
Tbr: ellyjones@google.com,apotapchuk@google.com
Change-Id: I109a39a9ec28e79bb7e1c9fb34ec698d68eb1727
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2349318Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#796886}

This CL adds a unit test for the case from CL
https://crrev.com/c/2027407.

There is also a fix of use-after-free bug in client tag based remote
update handler.

Bug: 1046309
Change-Id: I00302c5772aa960b1af5064d768bcd5e0f8dd45d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346431
Commit-Queue: Rushan Suleymanov <rushans@google.com>
Reviewed-by: Maksim Moskvitin <mmoskvitin@google.com>
Cr-Commit-Position: refs/heads/master@{#796885}

Please see demo screenshot in the linked bug.

Bug: b/161481969
Test: covered by unittests.
Change-Id: I8e3d867220ff7e23e79ac807ce6929fd04a246ca
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342784
Commit-Queue: Meilin Wang <meilinw@chromium.org>
Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#796884}

Adding:
- Open in New Tab
- Open in New Incognito Tab
- Open in New Window (if Multi-Window is supported and iPad)
- Open all tabs for section header
- Hide for now

Bug: 1093302
Change-Id: I1c1e79e34b73ab7b03082bc7ff40764dc7f33b28
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333827
Commit-Queue: Ewann Pellé <ewannpv@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Reviewed-by: Sebastien Lalancette <seblalancette@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#796883}

This was meant to be done in crrev.com/c/2220048, but a part of it was
overlooked there (that CL added only a DEFINE_VARIATION_PARAM(..) but
failed to also add the corresponding VARIATION_ENTRY(..) in the list).

Bug: 1044038
Change-Id: I54d11b14073f4908c634ba8539b870a0f5c6ec8d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346433
Auto-Submit: Marc Treib <treib@chromium.org>
Commit-Queue: Tommy Nyquist <nyquist@chromium.org>
Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Cr-Commit-Position: refs/heads/master@{#796882}

There needs to be some thought devoted to how we are sharing prefs with
update_client (and how and whether we should share code as well).

This change is very limited in scope, specifically to fix issue 1092503
and unblock other changes, allowing the test app to function correctly.

Bug: 1092503
Change-Id: I0500d3ae210a2a60e2991826432417a49ce88166
Fixed: 1092503
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2348537
Commit-Queue: Joshua Pawlicki <waffles@chromium.org>
Commit-Queue: Sorin Jianu <sorin@chromium.org>
Auto-Submit: Joshua Pawlicki <waffles@chromium.org>
Reviewed-by: Sorin Jianu <sorin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#796881}

Bug: 875235
Change-Id: Id85c0c5ad52bef9309e201416f9d47c30468efff
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2348231
Commit-Queue: Kent Tamura <tkent@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#796880}

Release_Notes:http://go/help_app-x20/relnotes/Nightly/help_app_nightly_202008110800_RC00.html

https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/help_app/app/+/qm8oRNi8gU7naD1qdw0-8dq2k2YWuPswsrYsoz6u_n8C

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/help-app-chromium-autoroll
Please CC help-app@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: b/159394333,b/162906760
Tbr: help-app@grotations.appspotmail.com
Change-Id: I1beff4b08702c8c390417f5062aef2aed2802628
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2349320Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#796879}

A new |error_msg| data member is added to LaunchSessionResponse struct
to provide more descriptive error messages.

Bug: 687380, b/154273698
Change-Id: If334dbfb0499cddcf3cfe36b3423ebf7005efb0a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335879
Commit-Queue: Muyao Xu <muyaoxu@google.com>
Reviewed-by: mark a. foltz <mfoltz@chromium.org>
Reviewed-by: Takumi Fujimoto <takumif@chromium.org>
Cr-Commit-Position: refs/heads/master@{#796878}

Mechanical change renaming platform window's handlers subdir so making
it more consistent with the other sub-directories.

R=sky@chromium.org

Bug: None
Change-Id: I5a355b4ed70a30ae803ce96c6ffee60cbfdd0bbf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2347401
Auto-Submit: Nick Yamane <nickdiego@igalia.com>
Commit-Queue: Scott Violet <sky@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#796877}

media/gpu/video_encode_accelerator_tests: Settle target bitrate by the video resolution and framerate

Originally video_encode_accelerator_tests tests a fixed bitrate
with any video. This enables to settle a good bitrate for testing
by determining it by the resolution and frame rate of a test
video.

Bug: 1045825
Test: video_encode_accelerator_tests on atlas
Change-Id: I129158cf0e877a0d06ce304f201c01969abd3be0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2325671
Commit-Queue: Hirokazu Honda <hiroh@chromium.org>
Reviewed-by: David Staessens <dstaessens@chromium.org>
Cr-Commit-Position: refs/heads/master@{#796876}

BUG=none
TEST=browser_tests --gtest_filter="OSSettingsAmbientModePageV3Test.All"

Change-Id: Ia097fb823b0e5f828444befe64b50b8e677c71cb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2347344Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Commit-Queue: Jeffrey Young <cowmoo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#796875}

  if (bleh) {
    (...)
  } else if (!bleh) {
    (...)
  }

BUG=None
R=sky@chromium.org

Change-Id: I7e303732499e1cfc77a23e08186a921612cbff27
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346608
Auto-Submit: Antonio Gomes (GMT-4) <tonikitoo@igalia.com>
Commit-Queue: Scott Violet <sky@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#796874}

Creates a vpcc box based on the configuration info. Reland now uses
a forward declaration for the kCMVideoCodecType_VP9 which is in the
11.0/10.16 SDK.

R=avi, sandersd

Bug: 1103432, 1105187
Test: Updated unittests.
Change-Id: I15158ec3329054981cab4eefc3316283952f2f48
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2348330
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#796873}

Bug: 1010217
Change-Id: I2ae48bd21aa792b32d2ddf736a567483295219a4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342237Reviewed-by: Darwin Huang <huangdarwin@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Commit-Queue: Darwin Huang <huangdarwin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#796872}

This CL adds a field trial parameter to the passwords account storage
feature. It is used to limit the number of times Chrome offers a user
that hasn't gone through the opt-in flow yet to move a password to their
account. The methods from crrev.com/c/2340966 are used to query the
number of times the user has already refused the move.

No behavior is actually changed however, since the refusal counter is
not yet incremented (future CLs).

TBR=vasilii@chromium.org

Bug: 1082152
Change-Id: I248f0964e1b406026016288d5e41fb64b2a6e10d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2345309
Commit-Queue: Victor Vianna <victorvianna@google.com>
Reviewed-by: Victor Vianna <victorvianna@google.com>
Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#796871}

The scanning UI is still under development. Extend the flag's expiration
to M90.

Bug: 1059779
Change-Id: I19bb927b02dbe916e74425a2f1b2b0b93139d1ac
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346829
Commit-Queue: Jesse Schettler <jschettler@chromium.org>
Reviewed-by: Bailey Berro <baileyberro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Auto-Submit: Jesse Schettler <jschettler@chromium.org>
Cr-Commit-Position: refs/heads/master@{#796870}

https://android.googlesource.com/platform/external/perfetto.git/+log/21e5b4554a5f..0376edf14e58

2020-08-11 lalitm@google.com Merge "trace_processor: Make GetColumnsForTable report errors"

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-chromium-autoroll
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel
Bug: None
Tbr: perfetto-bugs@google.com
Change-Id: I4548f77e6b03dc19db2bc9119ea731b50aa5ac46
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2349317Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#796869}

Bug: 1010217
Change-Id: Iccba7f237dee5ea57a0ea77eedd1ac56a58f2fa1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2344106
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org>
Cr-Commit-Position: refs/heads/master@{#796868}

This reverts commit 06578271.

Reason for revert: Getting reports of the version check not working from various users; see crbug.com/1115140

Original change's description:
> Rewrote PRESUBMIT.py
> 
> Rewrote PRESUBMIT.py (and associated tests) to new format. Runs
> REQUIRE_PRESUBMIT_VERSION at the top so that depot_tools can be
> made aware of the change and can time/rdb wrap each of the Check...
> functions separately, while also ensuring that they have the new
> version of depot_tools.
> 
> Requires the newer version of presubmit_support.py in depot_tools,
> which is described in crrev.com/c/2341828
> 
> Change-Id: I102e8c75834aff1eccdf4a27ffe6f0953b76ee57
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341362
> Reviewed-by: Dirk Pranke <dpranke@google.com>
> Commit-Queue: Saagar Sanghavi <saagarsanghavi@google.com>
> Cr-Commit-Position: refs/heads/master@{#796595}

TBR=dpranke@google.com,estaab@chromium.org,saagarsanghavi@google.com

Change-Id: Ib3295d141e997fc6792c381fea10e8892204bcdb
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2349428Reviewed-by: Dirk Pranke <dpranke@google.com>
Commit-Queue: Dirk Pranke <dpranke@google.com>
Cr-Commit-Position: refs/heads/master@{#796867}

The enterprise icon is changed into a badge on top of the gaia avatar.
The various texts are also updated to match the mocks in various cases,
depending whether the accounts are managed or not.

Screenshots:

Normal/Normal:
https://drive.google.com/file/d/1mE22Ro44l3IxstpFDNEz3oGMqxxfeYa4/view?usp=sharing
https://drive.google.com/file/d/1bVrkJ_vC-NTjE5hXh69Gf4FSEqemQkdp/view?usp=sharing

Managed/Normal:
https://drive.google.com/file/d/1VipZs_BjEtzWtBc_P-pjkR3HdYZB6C-H/view?usp=sharing
https://drive.google.com/file/d/1J9Io65diEFqwZq9kZbWnYixKLayKHJZn/view?usp=sharing

Normal/Managed:
https://drive.google.com/file/d/14R8iadPPOy5zYGdS7GsaCU8hlLQDL3CE/view?usp=sharing

Bug: 1076880
Change-Id: Ib66872356ed06d840a956e7d7b18686d29564a12
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339337
Commit-Queue: David Roger <droger@chromium.org>
Reviewed-by: Monica Basta <msalama@chromium.org>
Cr-Commit-Position: refs/heads/master@{#796866}

Bug: 1112874
Change-Id: Ibba008295747a9ac834309dad09771b7d0ff37c8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2344946Reviewed-by: Xi Han <hanxi@chromium.org>
Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Commit-Queue: Hao Dong <spdonghao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#796865}

Adds enough height to the CS collection view to allow for scroll
position to be maintained in Discover feed. Added height is calculated
from the cached NTP offset.

Bug: 1085419, 1108403
Change-Id: Ia9c2ed7dd7d5d3d8aa3413266404f956ae524cbf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2317811
Commit-Queue: Adam Trudeau-Arcaro <adamta@google.com>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#796864}