GitLab

Currently SearchBox is using the default per-thread task runner for its
mojo bindings. We are converting it to use per-frame task runner so that
BFCache can freeze the task runner correctly and don't need to evict
the page in case it receives mojo messages for SearchBox.

Change-Id: I16ddd7a19b4da0fec3eba61318e8901cb210b7af
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1877488
Commit-Queue: Rakina Zata Amni <rakina@chromium.org>
Reviewed-by: Hajime Hoshi <hajimehoshi@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Reviewed-by: Dan Beam <dbeam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709340}

Fixed: 1008199
Change-Id: I3037a9435c7d4e3f9d719275d8c538f8c2876e40
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876203
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Auto-Submit: Piotr Bialecki <bialpio@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709339}

This is a reland of a2c0ced3

Original change's description:
> [Fuchsia] Reenable protected mode in WebEngine
> 
> Bug: 982922, fuchsia:24570
> Change-Id: If9fb495249488c43f97e4451a14f0193911d600f
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1804527
> Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
> Commit-Queue: Emircan Uysaler <emircan@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#697683}

Bug: 982922, fuchsia:24570
Change-Id: Id4c70e7efbc1ba5c39f08178c5f8c62559838973
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1877193Reviewed-by: Wez <wez@chromium.org>
Commit-Queue: Emircan Uysaler <emircan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709338}

This adds a test suite for WebView's metrics integration. This verifies
WebView correctly configures the MetricsService such that it logs values
for proto fields in the UMA record. Most of these tests won't validate
the values make sense (verifying this logic should be in unittests for
each MetricsProvider), but rather that the field itself is populated (as
the status quo is many fields are simply not populated).

This configures the MetricsService to upload the initial log record very
quickly, as an optimization in the test case (the current delay of 20sec
would not be acceptable for each test). This does not modify the interval
between subsequent uploads, as each test case runs in a separate
process, so we'll never reach subsequent uploads.

Bug: 1011991
Test: run_webview_instrumentation_test_apk --gtest_filter=AwMetricsMetadataTest.*
Change-Id: If8b0400ec9904258ba9ae653e98b9c6d53a36d1c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1854507
Commit-Queue: Nate Fischer <ntfschr@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Tao Bai <michaelbai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709337}

This CL fixes a bug that shows a blank navigation sheet when invoked
while other bottom sheet is visible. When it cannot be opened, it
removes itself from the bottom sheet queue to prevent it from showing
up later.

Bug: 1016750
Change-Id: I0f0cee5088832224706ea7b999e9843420bdc0a7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1875888Reviewed-by: Matthew Jones <mdjones@chromium.org>
Reviewed-by: Theresa  <twellington@chromium.org>
Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709336}

Currently the API |GetSymbol| in V8PrivateProperty is used to get Symbol using HashMap with a static variable address as a key.
However, this key is not suitable for tracking private properties because the type is void*.

We can improve the tracking ability by using an instance of private property key dedicated class instead of void* type.

This CL creates a new class which is dedicated to private property keys, and adds a new API to get Symbol using an instance of the class.

Bug: 715418
Change-Id: Ieac862e8e2b5406a2c35c1a1f3368494833c3287
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1877490
Commit-Queue: Marina Sakai <marinasakai@google.com>
Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709335}

Change-Id: I137e4deaf16599b5ce304382b1d805914d77d69c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879390
Commit-Queue: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Ben Wells <benwells@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>
Auto-Submit: Joel Hockey <joelhockey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709334}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/de9e3cabe60e..86244d691364

git log de9e3cabe60e..86244d691364 --date=short --no-merges --format='%ad %ae %s'
2019-10-24 vadimsh@chromium.org [lucicfg] Update from v1.8.6 to v1.11.4.
2019-10-24 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).
2019-10-24 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).
2019-10-24 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).
2019-10-24 ehmaldonado@google.com presubmit: Run tests on Windows.
2019-10-24 jmadill@chromium.org git-cl: Add 'format-full-by-default' setting.

Created with:
  gclient setdep -r src/third_party/depot_tools@86244d691364

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/depot-tools-chromium-autoroll
Please CC agable@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

TBR=agable@chromium.org

Bug: None
Change-Id: I9c192ac3488b956e8584ee25d3e42b11ea80278f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879586Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#709333}

This reverts commit 62dae75f.

Reason for revert: this time will land the internal cl
  https://crrev.com/i/2015128 asap to keep the build green

Original change's description:
> Revert "Android: Private-package Tab.setIsShowingErroPage"
>
> This reverts commit 1e252fbf.
>
> Reason for revert: this change broke the internal build https://ci.chromium.org/p/chrome/builders/ci/android-internal-chromium-tot/b8898843520461106640
>
> Also, TabTestUtils.setIsShowingErrorPage() isn't defined as static, so the error couldn't be fixed in 1 internal CL.
>
> Original change's description:
> > Android: Private-package Tab.setIsShowingErroPage
> >
> > The method is called by a class in chrome.browser.tab package
> > in production code. Makes it a private-package method.
> >
> > Bug: 995903
> > Change-Id: I5f8b73200ae4a3c966b140a44e63cfc991f9b249
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872079
> > Reviewed-by: David Trainor <dtrainor@chromium.org>
> > Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#708466}
>
> TBR=dtrainor@chromium.org,jinsukkim@chromium.org
>
> Change-Id: Ieed0cf2e34f59cf4f7e68a4eb44dea0ea2f561aa
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 995903
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876389
> Reviewed-by: Alex Ilin <alexilin@chromium.org>
> Commit-Queue: Alex Ilin <alexilin@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#708594}

TBR=dtrainor@chromium.org,jinsukkim@chromium.org,alexilin@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 995903
Change-Id: I28634b5fd495b50823158f34589c032e472d988b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880231Reviewed-by: Jinsuk Kim <jinsukkim@chromium.org>
Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709332}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/25df51372600..5d8831fefd51

git log 25df51372600..5d8831fefd51 --date=short --no-merges --format='%ad %ae %s'
2019-10-25 ahassani@chromium.org chromeos_config: Mark littlejoe and viking as experimental

Created with:
  gclient setdep -r src/third_party/chromite@5d8831fefd51

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromite-chromium-autoroll
Please CC chrome-os-gardeners@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel
TBR=chrome-os-gardeners@google.com

Bug: None
Change-Id: I2c917493eb7954e52b11da64b55da008d22a1dd9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879522Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#709331}

|textures_per_picture| is an implementation detail of the binding
texture wrapper.  This CL moves it entirely there, rather than having
it passed in from D3D11VideoDecoder.

Change-Id: I1cf12bfd4bcc52defd3610e0a9e0f94cd41129ba
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876759Reviewed-by: Ted Meyer <tmathmeyer@chromium.org>
Commit-Queue: Frank Liberato <liberato@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709330}

This is the first change to convert the existing hashed logging code
into a general framework. This CL mostly removes code that was specific
to the search ranking use of hashed logging, and also changes the
API for logging.

Note that all hashed logging has been disabled for this refactor.

We need to delete this code now because there's a chain of
dependencies between the refactoring CLs. Roughly:

 1. Code referencing the current proto used to report logs must be
    deleted.

 2. The proto itself can then be changed internally, and re-exported
    to chromium. This has to be done as a unitary CL, with no other
    changes.

 3. Then, code can be re-added that references the new version of the
    proto.

Detailed changes:

 1. AppListLaunchRecorder::Record has become ::Log, which now takes
    lists of hashed and unhashed data. This is a tentative first try
    at the new API.

 2. The core hashed logic in AppListLaunchMetricsProvider has been
    deleted, because it will need to be generalized.

 3. The unit tests have all been disabled and the core EXPECT logic
    removed. This too must be rewritten for the generalized version.

Bug: 1016655
Change-Id: Iccc98771003c602b1a8375b4b2898e077f28def6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874411Reviewed-by: Thanh Nguyen <thanhdng@chromium.org>
Commit-Queue: Tony Yeoman <tby@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709329}

media::remoting::RpcBroker::ReceiveMessageCallback is used for
callers that wish to process messages via a call to
RpcBroker::ProcessMessageFromRemote. As it is legal to call
ProcessMessageFromRemote multiple times switching ReceiveMessageCallback
from base::Callback to base::RepeatingCallback.

Bug: 1007810
Change-Id: I3479ea065a4b1bc743f41e300f9ded81401b6415
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1875272Reviewed-by: Yuri Wiitala <miu@chromium.org>
Commit-Queue: Chris Mumford <cmumford@google.com>
Cr-Commit-Position: refs/heads/master@{#709328}

Use rollup along with existing Polymer CSS build and Uglify tools
to bundle Polymer 3 pages in optimized builds.

This will be used by the extensions Web UI in a followup CL:
https://chromium-review.googlesource.com/c/chromium/src/+/1817293

Bug: 965770
Change-Id: Id4538b5628d1d59824300598082d89ea316eb628
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846752
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709327}

We don't need this PostTask after NavigationLoaderOnUI.
This method is always called on the UI thread.

Bug: 824854, 1016865
Change-Id: Id8c5117ffead8860e660b4483465408ab18510c8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880488Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org>
Commit-Queue: Tsuyoshi Horo <horo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709326}

There are some e2e tests which set passphrase. After they run, we can
not reset account because we can not start sync. With this change, account
can correctly sign in after those tests, no matter the account requires
or not the passphrase.

TEST: tested e2e tests can still pass.
Bug: 1010568
Change-Id: I91ddf83fee188c5f6a16f8f97ded482437c21398
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1867470
Commit-Queue: Sven Zheng <svenzheng@chromium.org>
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709325}

https://skia.googlesource.com/skia.git/+log/b653813d5814..342fbc54844d

git log b653813d5814..342fbc54844d --date=short --no-merges --format='%ad %ae %s'
2019-10-24 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).
2019-10-24 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).
2019-10-24 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).

Created with:
  gclient setdep -r src/third_party/skia@342fbc54844d

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC michaelludwig@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=michaelludwig@google.com

Bug: None
Change-Id: I5ab954422127e58dbd3145bd252d623dea96426b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879583Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#709324}

This patch makes BlobToString()/CopyBody a helper function in
storage/browser/test/blob_test_utils.h which can be used by
service_worker_browsertest, cache_storage_cache_unittest and
background_fetch_data_manager_unittest.

Bug: 931094
Change-Id: I672e0896b9c817d6eeb7e61c1c02736aa62fad12
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865708Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
Commit-Queue: Wei4 Wang <wei4.wang@intel.com>
Cr-Commit-Position: refs/heads/master@{#709323}

Performance regressions, alas.

Bug: 1005070, 1013329, 1013326, 1013324
Change-Id: I15c0a539d5adde6f86de98ceec301863708307f6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880145Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Chris Palmer <palmer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709322}

TBR=michaelpg@chromium.org

Bug: 1018012
Change-Id: If3de2ca1745a674f2a4b972fcf72b683cde61bac
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880408Reviewed-by: Meredith Lane <meredithl@chromium.org>
Commit-Queue: Meredith Lane <meredithl@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709321}

https://dawn.googlesource.com/dawn.git/+log/6da1770507ec..1fdcb16b6995

git log 6da1770507ec..1fdcb16b6995 --date=short --no-merges --format='%ad %ae %s'
2019-10-24 cwallez@chromium.org Make dawn_wire use the webgpu.h header
2019-10-24 cwallez@chromium.org Vulkan: Implement initial version of the suballocation
2019-10-24 cwallez@chromium.org Preliminary changes to Vulkan memory suballocation
2019-10-24 cwallez@chromium.org Vulkan: Use the ResourceMemoryAllocator for all resources

Created with:
  gclient setdep -r src/third_party/dawn@1fdcb16b6995

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dawn-chromium-autoroll
Please CC cwallez@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel
TBR=cwallez@google.com

Bug: None
Change-Id: If9cb48571562c569436a2a2658f9fa8bb6e26f90
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879584Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#709320}

Clean up the BrowserActionTestUtilViews implementation a bit.
- Remove the TestToolbarActionsBarHelper base class from
  BrowserActionTestUtil; there's no need for it to be (conceptually)
  cross-platform.
- Cache the BrowserActionsContainer pointer on the
  BrowserActionTestUtilViews instance to avoid always doing a look-up
  through the GetContainer() method (and remove GetContainer()).
- Avoid caching the Browser on the object; it's only necessary for
  creating the overflow bar, and can be easily passed in to those calls
  (of which there are few).
- Finesse the constructors to make it clear when a
  BrowserActionsContainer is owned (through a manufactured view) vs not
  (by accessing one on the BrowserWindow).

Bug: 984654

Change-Id: Ibab94e0562fd04026f1b2642d6dbc170c049ead4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1877447
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Peter Boström <pbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709319}

As noted in b/143229899, a stale VmStopped signal can be sent to
Chrome if StopAllVms() call sent by session_manager takes a long
time to finish. Without this CL, such a signal could confuse the
VM adapter.

BUG=b:143229899
TEST=new tests pass

Change-Id: I72b918aebfc8b1218d25c931ce61bde728614a32
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1877603
Auto-Submit: Yusuke Sato <yusukes@chromium.org>
Commit-Queue: Yusuke Sato <yusukes@chromium.org>
Reviewed-by: Hidehiko Abe <hidehiko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709318}

The metrics are added for debugging crbug.com/1016546.

Bug: 1016546
Change-Id: I688e0f3a5464e6e6acee09c5d8fc14bb385af300
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879822
Commit-Queue: Xinghui Lu <xinghuilu@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Varun Khaneja <vakh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709317}

The class seemed to be gone as a part of the Onion Soup. Remove
references to the class and update comments.

Bug: N/A
Change-Id: Ia093586c40295d09bffcf713d6156a20e96b43c5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1877489
Commit-Queue: Kenichi Ishibashi <bashi@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709316}

Do a couple small cleanups in ExtensionsMenuView:
- Update includes and forward declarations (removing unused, adding
  missing)
- Add function comments
- Remove unused function CreateFixedSizeIconView() (the last usage was
  removed in crrev.com/7127b171)

Bug: None
Change-Id: I83513678011b6adf825377def47003a677e5fb17
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879605
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Peter Boström <pbos@chromium.org>
Reviewed-by: Charlene Yan <cyan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709315}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/c09baddc696f..98c55a366e1b


Created with:
  gclient setdep -r src-internal@98c55a366e1b

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC jbudorick@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome
TBR=jbudorick@google.com

Bug: chromium:None
Change-Id: I9d303d1ef772c72d0f8fa8eaa6b5d0533a43da97
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879580Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#709314}

https://chromium.googlesource.com/chromiumos/platform2/system_api.git/+log/4ed26a9a6564..8014da0ebf8c

$ git log 4ed26a9a6..8014da0eb --date=short --no-merges --format='%ad %ae %s'
2019-10-10 bgeffon debugd: Add Kstaled Enable/Disable method
2019-10-23 yusukes system_api: Add |cid| field to VmStoppedSignal message
2019-10-21 pmalani system_api: Add proto_library compile flag for fuzzers

Created with:
  roll-dep src/third_party/cros_system_api

BUG=b:143229899
TEST=try

Change-Id: Ic72b6d0282c1f8f5d4ae0201e4afa7e95f00e4c5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880327
Commit-Queue: Yusuke Sato <yusukes@chromium.org>
Commit-Queue: David Jacobo <djacobo@chromium.org>
Auto-Submit: Yusuke Sato <yusukes@chromium.org>
Reviewed-by: David Jacobo <djacobo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709313}

This function was originally added when there was a "silent" mode for
WebProtect uploading. Users would see no change if ShouldDelayVerdicts
returns false. With pre-delivery mode implemented, we should be showing
that UX when the admin does not block delivery.

Fixed: 1016896, 980779
Change-Id: Ie82416f365668af6ec135d7b142d35ad23db07d3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874203
Commit-Queue: Bettina Dea <bdea@chromium.org>
Reviewed-by: Bettina Dea <bdea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709312}

More tests have become flaky. Will suppress until the root cause is
found.
conformance/ogles/GL/radians/radians_001_to_006.html
conformance/ogles/GL/reflect/reflect_001_to_006.html
conformance/ogles/GL/refract/refract_001_to_006.html

Bug: 1017162
Change-Id: I5a089af9192fa242e883ab9bdda6564301bee55a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879850Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Jonah Ryan-Davis <jonahr@google.com>
Cr-Commit-Position: refs/heads/master@{#709311}

I'm going to add NetworkIsolationKey key as an argument (And eventually
make it non-optional, defensively). Getting rid of the legacy
constructor makes that a bit easier.

Also inline HostCache::Key() initial values in the header file, while
I'm here.

Bug: 997049
Change-Id: I995eac63434e0f673ea31669977f4aacfc2a1982
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874512
Commit-Queue: Matt Menke <mmenke@chromium.org>
Reviewed-by: Eric Orth <ericorth@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709310}

This character (þ) can be confused with both b and p when used in a domain
name. IDN spoof checker doesn't have a good way of flagging a character as
confusable with multiple characters, so it can't catch spoofs containing
this character. As a practical fix, this CL restricts this character to
domains under Iceland's ccTLD (.is). With this change, a domain name containing
"þ" with a non-.is TLD will be displayed in punycode in the UI.

This change affects less than 10 real world domains with limited popularity.

Bug: 798892, 843352, 904327, 1017707
Change-Id: Ib07190dcde406bf62ce4413688a4fb4859a51030
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879992
Commit-Queue: Mustafa Emre Acer <meacer@chromium.org>
Reviewed-by: Christopher Thompson <cthomp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709309}

We will be requiring cookies marked to permit access in 3rd-party contexts
to be secure; and this test was creating an insecure one, so change it.

Bug: 1016512
Change-Id: I4205508d7ff145f7d81fe36fcfa5854963462de7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879192
Commit-Queue: Wez <wez@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709308}

The dialog was incorrectly displaying "Connecting to..." when
the keyboard supported and provided "keys entered" events.
We should always continue to prompt the user to enter the passkey
as they enter the passkey.

Bug: 1007375
Change-Id: Ia5cf9d226fe17d902e01aaa24f642a1dab635af6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1875382
Commit-Queue: Ryan Hansberry <hansberry@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709307}

//aw/apk is where all standalone webview code should live (things not
run in another app's process as a result of starting a webview).
Since services run in webview's process, they belong in the apk folder.
This also moves the aidl files to //aw/java/.../common/services.

Test: Manually verify starting SystemWebView still starts the service.
Bug: 934152
Change-Id: I4e3c2f43c4dfbab41b8f187d82dbd03ce09147da
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864317Reviewed-by: Chris Palmer <palmer@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Filip Gorski <fgorski@chromium.org>
Reviewed-by: Changwan Ryu <changwan@chromium.org>
Reviewed-by: Richard Coles <torne@chromium.org>
Commit-Queue: Robbie McElrath <rmcelrath@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709306}

https://android.googlesource.com/platform/external/perfetto.git/+log/1ac605ab1a88..ff7d06ba71fd

git log 1ac605ab1a88..ff7d06ba71fd --date=short --no-merges --format='%ad %ae %s'
2019-10-24 lalitm@google.com trace_processor: add fast path for eq constraints on id columns

Created with:
  gclient setdep -r src/third_party/perfetto@ff7d06ba71fd

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-chromium-autoroll
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

TBR=perfetto-bugs@google.com

Bug: None
Change-Id: I10b824d39c411a4ef7e99e42ed483c431f31bd2d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879581Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#709305}

Bug: 1009122
Change-Id: I64e48c638b403911a8879ff1fa7b290628373bd9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1877454
Commit-Queue: Collin Baker <collinbaker@chromium.org>
Reviewed-by: Peter Boström <pbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709304}

In the attached bug (which has recently been re-introduced),
1. focus is requested on a node
2. in response, the page triggers some type of re-flow which causes the layout object of the node to be invalidated
3. some amount of non-determinism occurs where we might call AXObject CacheImpl::GetOrCreate on a node (keyed by layout object). This sometimes results in us creating a brand new AXLayoutObject or AXNodeObject for a Node that hasn't been destroyed.
4. when it arrives in the browser or in ChromeVox, the target of the focus looks like it was destroyed, so the focus event never gets fired.

Test: browser_tests --gtest_filter=Automation*.ForceLayout
Bug: 885244
Change-Id: I2f7747a98d15a6ae5b3ed75638a93d1078526015
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872422
Commit-Queue: David Tseng <dtseng@chromium.org>
Reviewed-by: Alice Boxhall <aboxhall@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709303}

We are already doing this in the GPU process as the histogram
Gpu.Metal.TestShaderCompileSucceeded. That histogram indicates that
we fail to compile the shader from the GPU process within 6 seconds 2%
of the time.

The new histogram Browser.Metal.TestShaderCompileTime histograms the
shader compile time, up to 1 minute, whereupon it uses the max bucket
(3 minutes).

Also add a DumpWithoutCrashing on timeout. This will have to be removed
after one promotion to dev (to not drown out real crashers), but will
help gather more information about crashing machine profiles.

Move the test shader code into the metal_util component so that it can
be used by both locations (the previous implementation was in /viz/).

Landed at crrev.com/708870
  R=avi,isherman
Reverted at crrev.com/708991
  Because of DCHECK that shader compilation succeeds, which does not
  happen on some bots. Added separate return value for this case.

TBR=avi

Bug: 974219
Change-Id: Icab8dab3293d897500e7f7774a02f99fc39cf831
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879968Reviewed-by: ccameron <ccameron@chromium.org>
Commit-Queue: ccameron <ccameron@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709302}

* Make the app list controller the only class that observes home
  launcher changes.
* Move "home launcher animation state" cached field to the app list
  controller.
* Rejiggle a bit the flow of information between our various observers
  (overview, app list visibility, home launcher gesture, etc.) so that
  more classes are generally aware of the final state of a transition
  sooner than previously.
* Add a "will start" API to the overview observer.
* Add a couple of "const" where appropriate.

Bug: 1012760,1013737,1012353,1016012,1012767,1009550,1006013,1016511
Change-Id: I15bc0fb519713145beffb9933295564b0d8a5f6b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872102
Commit-Queue: Manu Cornet <manucornet@chromium.org>
Reviewed-by: Alex Newcomer <newcomer@chromium.org>
Reviewed-by: Sammie Quon <sammiequon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709301}