- 28 Oct, 2019 10 commits
-
-
Gyuyoung Kim authored
As a following CL, this CL applies pending_receiver to the second parameter of CreateCastRenderer. - Convert FooRequest to mojo::PendingReceiver. Bug: 955171 Change-Id: I4e06c59e550c5ca0c17aadae40871de017c69f0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881000Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Sam McNally <sammc@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#709786}
-
Meredith Lane authored
This reverts commit ffff90fd. Reason for revert: Consistently failing on multiple ChromeOS bots. https://crbug.com/1018615 Original change's description: > [Sampling profiler] Implement signal-based stack copying in //base/profiler > > This CL extracts the core stack copying parts of > tracing::StackUnwinderAndroid into the dedicated base::StackCopierSignal > class, and adapts it for direct use by the sampling profiler stack > unwinding implementation. This drops some unneeded code; updates the code > to run on 32-bit Android, 64-bit Android, and 64-bit Linux platforms; > and converts the code to use C++ atomics. > > The StackUnwinderAndroid implementation will eventually be replaced > wholesale by the sampling profiler implementation for Android. This CL > does not attempt to reuse the extracted stack copying implementation on > its own, in order to avoid introducing bugs in StackUnwinderAndroid due > to the differing implementations. > > TBR=gab@chromium.org > > Bug: 988579 > Change-Id: I0293771679c5deae69fdbb007d8828ead575ee0f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872967 > Reviewed-by: Mike Wittman <wittman@chromium.org> > Reviewed-by: Gabriel Charette <gab@chromium.org> > Reviewed-by: Charlie Andrews <charliea@chromium.org> > Reviewed-by: ssid <ssid@chromium.org> > Commit-Queue: Mike Wittman <wittman@chromium.org> > Commit-Queue: Gabriel Charette <gab@chromium.org> > Auto-Submit: Mike Wittman <wittman@chromium.org> > Cr-Commit-Position: refs/heads/master@{#709597} TBR=gab@chromium.org,wittman@chromium.org,ssid@chromium.org,charliea@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 988579 Change-Id: Ib62446f431d971f2403b1fb9fcebaa130559c698 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1882190Reviewed-by:
Meredith Lane <meredithl@chromium.org> Commit-Queue: Meredith Lane <meredithl@chromium.org> Cr-Commit-Position: refs/heads/master@{#709785}
-
Kent Tamura authored
delegatesFocus: Share code in Element::focus() and MouseEventManager::SlideFocusOnShadowHostIfNecessary() This CL has no behavior changes. Bug: 1014094 Change-Id: I88dc1ca15210ff96c698f32416c3d284859ad583 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880899Reviewed-by:
Rakina Zata Amni <rakina@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#709784}
-
Meredith Lane authored
This reverts commit 07e39f96. Reason for revert: Causing flakiness on AppListClientImplBrowserTest.UninstallApp. Flakiness dashboard: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=browser_tests&tests=AppListClientImplBrowserTest.UninstallApp Original change's description: > Reland "Use AppService to uninstall apps on Chrome OS." > > This CL is used to reland the CL:1864496 and fix the browser_tests. > > CL:1864496 is reverted because it breaks the browser_tests: > AppListClientImplBrowserTest.UninstallApp > > The reason is a NativeWindowTracker should be created to track whether > |parent_window_| got destroyed. If destroyed, or load icon failed, > call OnDialogClosed to notify AppServiceProxy to remove the > UninstallDialog from set, and destroy UninstallDialog. > > BUG=1009248 > > Change-Id: I1a2fe6f087a5cc2f723ac0256510a385555e9347 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1875865 > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Reviewed-by: Dominick Ng <dominickn@chromium.org> > Commit-Queue: Nancy Wang <nancylingwang@chromium.org> > Cr-Commit-Position: refs/heads/master@{#709487} TBR=xiyuan@chromium.org,dominickn@chromium.org,nancylingwang@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1009248 Change-Id: Ib3b60ce1f11e9b0dcd5f5bc3870702eaf96c9896 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1882195Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 437cc065. With Chromium commits locally applied on WPT: 1d5b803f "Add WebVTT support for inline styling - Web Platform Tests" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: bjonesbe@adobe.com: external/wpt/css/css-shapes eae@chromium.org, szager@chromium.org: external/wpt/intersection-observer foolip@chromium.org: external/wpt/compat foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools guidou@chromium.org, armax@chromium.org: external/wpt/mediacapture-streams rego@igalia.com: external/wpt/css/css-grid NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: Iffe1946e7925604b8b3935a90bb2812f1c222f61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1882932Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#709782}
-
Hiroki Sato authored
When the node is non-editable and doesn't have a text property, the accessibility name field had an extra space. This fixes the issue. This CL also refines unit test (AccessibleNameComputationTextField). Bug: None Test: unit_tests --gtest_filter="AXTreeSourceArcTest.*" Change-Id: I2dca6990215e98bdf2a9a57a0888f05298a2985a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874995Reviewed-by:
David Tseng <dtseng@chromium.org> Reviewed-by:
Sara Kato <sarakato@chromium.org> Commit-Queue: Hiroki Sato <hirokisato@chromium.org> Cr-Commit-Position: refs/heads/master@{#709781}
-
Hiroki Sato authored
When DrawerLayout is opened, the contents behind the menu should not get accessibility focus. These nodes have ImportantForAccessibility=false attribute in Android. This CL respects the attribute to set ignored state in Chrome side. Bug: b:130186722 Test: unit_tests --gtest_filter="AXTreeSourceArcTest.*" Test: manually confirmed with PlayStore, hangouts, Dropbox, etc. that drawer menu navigation is restricted in the menu. Change-Id: I390920f3ec5ba2943a7474483f3180c8cd587ed7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1875853 Commit-Queue: Hiroki Sato <hirokisato@chromium.org> Reviewed-by:
-
David Staessens authored
This CL removes the md5 data files which are only used by the deprecated video_decode_accelerator_unittest. This test has been deprecated in favor of the video_decode_accelerator_tests and video_decode_accelerator_perf_tests, which get the md5 frame checksums from json files accompanying each test video. TEST=./video_decode_accelerator_tests on eve BUG=1802897 Change-Id: I2417dd1bda7ee9e23dcf5bdec75a04ade9497a08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1851631 Commit-Queue: David Staessens <dstaessens@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#709779}
-
Kunihiko Sakamoto authored
This is a doc for web developers who want to create Web Bundles that can be loaded with Chrome. Change-Id: I9cc05fa686e82910065fdd11d6e13e8ecec0ba6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880413Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Tsuyoshi Horo <horo@chromium.org> Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#709778}
-
Rob Schonberger authored
This modifies Centroid calculation to be O(1) when calculating a centroid of a stroke. Centroid fetching/checking happens a lot, so it's worthwhile to optimize. Nevertheless this is still a heavy O(1) - so alternatives are happily considered. Bug: 1009290 Change-Id: Ia421502c1cdf5e37bd5c6f80dc4f866af2119b7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880237Reviewed-by:
Michael Spang <spang@chromium.org> Commit-Queue: Rob Schonberger <robsc@chromium.org> Cr-Commit-Position: refs/heads/master@{#709777}
-
- 27 Oct, 2019 6 commits
-
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: Id5847d77875473521c8b9842386fcbab81637a76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881784Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#709776}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/403b00885ea5..97bcfab8abdd Created with: gclient setdep -r src-internal@97bcfab8abdd If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: None Change-Id: I76da19f2a1d077264062f35e60d32b66572c867a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1882651Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#709775}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/ff82e15d014a..62160f2f358a git log ff82e15d014a..62160f2f358a --date=short --no-merges --format='%ad %ae %s' 2019-10-27 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update SKP version Created with: gclient setdep -r src/third_party/skia@62160f2f358a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jcgregorio@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jcgregorio@google.com Bug: None Change-Id: Id0732cd090bb74d2fe335c1781e5fa7611ca4d2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1882570Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/0e9cc938..be638514 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I941b22302ac8b4bc23ce58f83b104dddea5fba1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1882140Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#709773}
-
Jamie Madill authored
This reverts commit c3d943c2. Reason for revert: Broke Windows builders. Bug: 1018587 Original change's description: > Update disable-blink-features=LayoutNG > > * 3 crashes in native-file-system. > * Mostly image rebaselines where scrollbar buttons became > grayed when the scroll position is at begin/end. Probably > someone fixed this. > * A few pixel differences in rendering fonts, for vertical > flow and "AM" in the date picker. > > TBR=ikilpatrick@chromium.org > NOTRY=true > > Change-Id: I1f8a9eb2fbb816f27bf2eb8d51e423919dbbf9a1 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1882249 > Reviewed-by: Koji Ishii <kojii@chromium.org> > Commit-Queue: Koji Ishii <kojii@chromium.org> > Cr-Commit-Position: refs/heads/master@{#709765} TBR=kojii@chromium.org,ikilpatrick@chromium.org NOTRY=true # Skipping CQ checks to get CQ in working state. Change-Id: I4551c8420fa9d28ff322abe59b02f6d9fd6609f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879345 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by:
Jamie Madill <jmadill@chromium.org> Cr-Commit-Position: refs/heads/master@{#709772}
-
Koji Ishii authored
Following bot results are included. 37 39 41 TBR=yosin@chromium.org NOTRY=true Bug: 982194 Change-Id: Iedc076dd23c41b3a90dae78e0ae52c448567acf9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881002 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#709771}
-
- 26 Oct, 2019 24 commits
-
-
Haines Sy authored
The NetworkChangeNotifier base class creates and initializes a NetworkChangeCalculator which synthesizes high-level network change notification events. Because it is created before the derived NetworkChangeNotifierFuchsia reads the initial network state, events must be dispatched for that initial state, for the NetworkChangeCalculator to be up-to-date. Bug: b/142796913 Change-Id: I51a319d0e5925721c81d7bb4b3eb15521dd1ba91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880449 Commit-Queue: Haines Sy <hainesy@google.com> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#709770}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/e7c8e80dbb2e..95a736bd3347 git log e7c8e80dbb2e..95a736bd3347 --date=short --no-merges --format='%ad %ae %s' 2019-10-26 jmadill@chromium.org Reland "Add more test_utils functions." Created with: gclient setdep -r src/third_party/angle@95a736bd3347 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jonahr@google.com Bug: chromium:1015810 Change-Id: Ib4798f24b475e0691874d10dd007d331004011d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881699Reviewed-by:
-
Yang Guo authored
Bug: 1011259 Change-Id: Ia8b5363d1d17416ce73f15366ab86d758a78b626 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872002Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#709768}
-
Koji Ishii authored
This patch fixes resolved direction for box items. Before this patch, it was set to the opposite direction. Bug: 982194 Change-Id: I1fcdd0c15fa453ac8a25ba6cc81769022cbfd2f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880895 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#709767}
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-compile-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-compile-chrome BUG=762641 TBR=chrome-os-gardeners@google.com Change-Id: Idb1c46c52fd89e96af99d076d05bd4122ebe808c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1882161Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#709766}
-
Koji Ishii authored
* 3 crashes in native-file-system. * Mostly image rebaselines where scrollbar buttons became grayed when the scroll position is at begin/end. Probably someone fixed this. * A few pixel differences in rendering fonts, for vertical flow and "AM" in the date picker. TBR=ikilpatrick@chromium.org NOTRY=true Change-Id: I1f8a9eb2fbb816f27bf2eb8d51e423919dbbf9a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1882249Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/76763cb90a43..e7c8e80dbb2e git log 76763cb90a43..e7c8e80dbb2e --date=short --no-merges --format='%ad %ae %s' 2019-10-26 jmadill@chromium.org Roll chromium_revision 60074bf9..5fe256ab (709436:709762) Created with: gclient setdep -r src/third_party/angle@e7c8e80dbb2e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jonahr@google.com Bug: chromium:1017514 Change-Id: I75189db50e4ed3012535b7f11962c845b0d303a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881403Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: Id966f672c5140eed017b1ee5fc7fc0c6864e279f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881782Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 7294eccd. With Chromium commits locally applied on WPT: 1d5b803f "Add WebVTT support for inline styling - Web Platform Tests" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: cvazac@akamai.com, igrigorik@chromium.org: external/wpt/server-timing hongchan@chromium.org, rtoy@chromium.org: external/wpt/webaudio igrigorik@chromium.org, yoavweiss@chromium.org: external/wpt/preload mek@chromium.org: external/wpt/webmessaging tdresser@chromium.org: external/wpt/navigation-timing NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: Ic24792683389612d50c91fc6ae560d64eee074e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1882129Reviewed-by:
-
Henrique Ferreiro authored
Bug: 919392 Change-Id: Idbc7d23d127027834c70f09821ae0f389ce260be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876347Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Cr-Commit-Position: refs/heads/master@{#709761}
-
Jinsong Fan authored
There two cases of the bug: 1. When the touch handles are on the same line, or one of them is invisible, the RectBetweenBounds becomes a line, and not union the handle rect, cause the context menu covers the touch handles. 2. Long press on any text, the showSelectionMenu is coming before concluding the selection. While the handles remain hidden for the duration of a longpress drag, including the time between a longpress and the start of drag motion. So, the handle rect is empty and cause the context menu covers the touch handles. The CL removes the empty check of RectBetweenBounds, so it always union the handle rect to fix case 1. For case 2, leave it to Ajith's CL to fix(http://crrev/c/995653). Bug: 1013477 Test: manual Change-Id: Ie4fbe0669b28d1a0e7ac0894d2ba07569b63dd05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857838 Commit-Queue: Jinsong Fan <fanjinsong@sogou-inc.com> Reviewed-by:
Mohsen Izadi <mohsen@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#709760}
-
Chromium WPT Sync authored
Using wpt-import in Chromium f494d2ca. With Chromium commits locally applied on WPT: 1d5b803f "Add WebVTT support for inline styling - Web Platform Tests" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: jsbell@chromium.org, mek@chromium.org: external/wpt/FileAPI mkwst@chromium.org, andypaicu@chromium.org: external/wpt/content-security-policy NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I4761910bd36f2a3a31059d16b0282a074133d256 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1882128Reviewed-by:
-
Mario Sanchez Prada authored
Convert the remaining bits referencing the viz::mojom::InputTargetClient mojo interface using the old APIs to the new mojo types. Bug: 955171 Change-Id: I1ff61c9eda3479fb4462dfee94f7e98a520b8a39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879895Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Cr-Commit-Position: refs/heads/master@{#709758}
-
Yang Guo authored
https://chromium.googlesource.com/devtools/devtools-frontend/+log/d3ddd33257..c20eb36aa7 TBR=lomitch@chromium.org Change-Id: Ibf03a314458df89fc08c0225f6af06b7a443b485 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879463Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#709757}
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-compile-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-compile-chrome BUG=762641 TBR=chrome-os-gardeners@google.com Change-Id: I80f354c018103ad8e42d2e27a37b2f4fea77aa3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881780Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/4812325d..0e9cc938 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ibbaa7b007e7187a1d1cb7daca95af12b2ce60024 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1882127Reviewed-by:
-
Julie Jeongeun Kim authored
This CL cleans up old Mojo types for mojom::ChildProcess with removing ChildProcessRequest. Bug: 955171 Change-Id: I8b95086f4c3c2cc39d559ff32f983a0c60f335f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879629Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/4b1db19bd426..7568fa8a28d9 git log 4b1db19bd426..7568fa8a28d9 --date=short --no-merges --format='%ad %ae %s' 2019-10-25 crouleau@chromium.org [Pinpoint] Use --run-full-story-set flag. Created with: gclient setdep -r src/third_party/catapult@7568fa8a28d9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC simonhatch@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=simonhatch@google.com Bug: chromium:982027 Change-Id: Ic908b4a209011255db62628f4de2fe2a889bf051 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881891Reviewed-by:
-
Fergal Daly authored
I deleted it incorrectly in https://crrev.com/c/1862137 but it's failing. TBR=altimin@chromium.org Bug: 1004786 Change-Id: Ibfdc2f4f3d720b6f40e66cb02ed8f96ef4441380 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881005Reviewed-by:
Fergal Daly <fergal@chromium.org> Commit-Queue: Fergal Daly <fergal@chromium.org> Cr-Commit-Position: refs/heads/master@{#709752}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: Iea82c12a112e89f26ff04d6e89510af394765e8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881760Reviewed-by:
-
Jamie Madill authored
Was missing the correct prefix. Bug: 1017514 Change-Id: I05ed5952664e23b632727f7f6c9366bd5bd494ac Tbr: dpranke@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881992Reviewed-by:
-
Miyoung Shin authored
This CL converts MediaMetricsProvider{Ptr, Request} in content and media to the new Mojo type. Bug: 955171 Change-Id: I12a9cd0c377a6081ad00f3503682d13078bc6b9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880990Reviewed-by:Frank Liberato <liberato@chromium.org> Reviewed-by:
-
David Bokan authored
This CL adds a browser-side to the AgentMetricsCollector. Each renderer periodically (on state changes and every 5 minutes) sends its current list of acive agents to the browser side. This is recorded in a global map. Tuple-origins are recorded with both their protocol and registrable domain. The "unique" version of the metric de-duplicates same protocol+ registrable domain agents to simulate a potential OOPIF coalescing stragegy. Non-tuple-origins are always counted as unique and are sent as an empty string. Change-Id: Ie841c6c145c508c4769af7a0048b27c1e22aec1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876878Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Reviewed-by:
-
Fergal Daly authored
The previously filtered unit_tests are passing locally and also on bot runs - Linux-dbg run of the entire unit_tests suite (not sure why it ran everything and not just the filtered tests) https://chromium-swarm.appspot.com/task?id=481a4b30b854e210 - Android-dbg run of just the filtered tests https://chromium-swarm.appspot.com/task?id=481a597f7de9f510 Change-Id: I50314cab92ef7a5c688fc70e3ac246146ce33dde Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880888 Commit-Queue: Fergal Daly <fergal@chromium.org> Reviewed-by:
Arthur Hemery <ahemery@chromium.org> Cr-Commit-Position: refs/heads/master@{#709747}
-
