- 22 Jan, 2021 40 commits
-
-
Peter Kasting authored
Bug: 1159562 Change-Id: Ia8145a0cffba9b6fb8edef4f37f9412e66367698 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2645481 Commit-Queue: Peter Kasting <pkasting@chromium.org> Commit-Queue: Allen Bauer <kylixrd@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Cr-Commit-Position: refs/heads/master@{#846392}
-
Stefan Zager authored
Speculative fix for crasher. If a throttled iframe is composited, CompositingRequirementsUpdater running on the parent document should notice the composited iframe and force compositing in the parent document. However, CompositingRequirementsUpdater will not run in the parent frame if the parent is not marked as needing compositing update. If the hypothesis is correct, it's still not clear how this situation can happen. A throttled iframe will not run compositing assignment update, so the state of its root graphics layer should not change, and the parent document should already be compositing and shouldn't need to run CompositingRequirementsUpdater. Bug: 1133662 Change-Id: Ica6ffbac1ae192c6795ef4b1379b9f2b919cf729 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2644350 Commit-Queue: Stefan Zager <szager@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#846391}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/8ce2fad80022..910cb2c9006f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC nsatragno@google.com,katydek@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1157673,chromium:1167948 Tbr: nsatragno@google.com,katydek@google.com Change-Id: I3ab6e351f8bb03a9327840ba0b06d7e2876a8129 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2645338Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#846390}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/3232876ee47b..44860edcd260 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I1cc04435bec5fbd1fb88a9a1c1b672dad4b975ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2644707Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#846389}
-
Stephen Sigwart authored
If the credit card name match was on "name", only return it as a match if there is a matched card number and expiration or security code. Bug: 1167977 Change-Id: I18cd0f6ee4205e16ee2a4cdba95502c0299016bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2636833 Commit-Queue: Stephen Sigwart <ssigwart@gmail.com> Reviewed-by:
Christoph Schwering <schwering@google.com> Cr-Commit-Position: refs/heads/master@{#846388}
-
Yuta Hijikata authored
Bug: None Change-Id: Icd607790fb69a12f1355f80c2710a309a1746dc8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643422 Commit-Queue: mark a. foltz <mfoltz@chromium.org> Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Cr-Commit-Position: refs/heads/master@{#846387}
-
Adam Ettenberger authored
Disabling new DumpAccessibilityTreeTest tests that are flaky : - AccessibilityAriaHiddenSingleDescendant - AccessibilityAriaHiddenSingleDescendantDisplayNone - AccessibilityAriaHiddenSingleDescendantVisibilityHidden https://ci.chromium.org/ui/p/chromium/builders/ci/Linux%20ChromiumOS%20MSan%20Tests/22224/overview Bug: 1169854, 1159660 Change-Id: I350e3bdb66026410623a64f0dc04c3f62ce2f4ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2645257Reviewed-by:
Katie Dektar <katie@chromium.org> Reviewed-by:
Kurt Catti-Schmidt <kschmi@microsoft.com> Commit-Queue: Adam Ettenberger <Adam.Ettenberger@microsoft.com> Cr-Commit-Position: refs/heads/master@{#846386}
-
Peter Kasting authored
Bug: 1159562 Change-Id: I59929dd816008c69bd82930e6834529218fde15d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2644705 Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by:
-
Theresa Sullivan authored
Use ActivityUtils#rotateActivityToOrientation (extracted from TabUiTestHelper) to wait for the orientation change to complete before proceeding with the rest of the test. Bug: 945861 Change-Id: I75f897a62fa98d28eae1594fcc9a4d4391e6fae7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2645347Reviewed-by:
Yue Zhang <yuezhanggg@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#846384}
-
Reilly Grant authored
This change converts callbacks from base::Bind and base::Callback to Once/Repeating in //chrome/browser/chromeos/chromebox_for_meetings. Bug: 1148570 Change-Id: I5ea12291720cc501393eae32d2a22a077dbb1e66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2645515 Auto-Submit: Reilly Grant <reillyg@chromium.org> Reviewed-by:
Kyle Williams <kdgwill@chromium.org> Commit-Queue: Kyle Williams <kdgwill@chromium.org> Cr-Commit-Position: refs/heads/master@{#846383}
-
Reilly Grant authored
This change converts callbacks from base::Bind and base::Callback to Once/Repeating in //chrome/browser/chromeos/net. Bug: 1148570 Change-Id: Id99cfb67bd2831576576b0c01c2cd9b3d5d4444f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2645505 Auto-Submit: Reilly Grant <reillyg@chromium.org> Commit-Queue: Satoru Takabayashi <satorux@chromium.org> Reviewed-by:
Satoru Takabayashi <satorux@chromium.org> Cr-Commit-Position: refs/heads/master@{#846382}
-
Michael Crouse authored
Bug: 1167857, 1167858, 11678595, 1167860, 1167861 Change-Id: I72754b1d8e99bcb75e7bf8b0004dc4a45d77909a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2642751Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Brian White <bcwhite@chromium.org> Auto-Submit: Michael Crouse <mcrouse@chromium.org> Cr-Commit-Position: refs/heads/master@{#846381}
-
Katie Dillon authored
Breaking up this cl[1] into two portions: before unload and unload metrics. Adding UKMs to help measure unload performance. More details on why we are adding these metrics can be found on the UKM Collection Review doc[2]. TL;DR is that Search is looking to see where they could improve unload and on the web platform side we are looking to run experiments to prioritize unload and these metrics will help measure impact. This CL adds the metrics we want to collect for unload. Unload durations and queueing durations will only be recoded for same-process navigations since the unload handlers are fired during the commit and are on the blocking path for the commit to proceed. In the cross-process case this is a different frame and so the navigation will not be blocked on the unload handlers. Metrics added in this CL are: 1. UnloadDuration 2. UnloadQueueingDuration (measuring the time from browser sending the commit navigation to the unload being run in the renderer). 3. BeforeUnloadToCommit (split by cross-process and same-process navigations since same-process navigations are blocked by unload handlers whilst cross-process navigations are not) [1] https://chromium-review.googlesource.com/c/chromium/src/+/2191143 [2] https://docs.google.com/document/d/1DECc8eJQluwkV5k64TX7Krl4zAcP7-Qk7pSirmHuCJs/edit?usp=sharing Bug: 1081617 Change-Id: Ic02e1e9fbcec94dce616ca80a6afa74a08b9a818 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2314877 Commit-Queue: Katie Dillon <kdillon@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Nate Chapin <japhet@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#846380}
-
Tanya Gupta authored
Moved all bitmap generation related classes into their own directory. Bug: 1153969 Change-Id: I42dc429bd2d6d7d59ebbd92558ea08665a3ccac6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2640920 Commit-Queue: Tanya Gupta <tgupta@chromium.org> Reviewed-by:
Kyle Milka <kmilka@chromium.org> Cr-Commit-Position: refs/heads/master@{#846379}
-
Alison Maher authored
forced-colors-mode-15.html was marked as flaky on Mac. forced-colors-mode-14.html is a similar test for active selection rather than inactive and is not flaky. Thus, I believe the flakiness is likely around "testRunner.setWindowFocus(false);". Similar to CL:1146523, delay calling setWindowFocus to avoid a race with the initial focus event. Bug: 1167210 Change-Id: I8e6ae87d8cd9b75ea01d2e9ff012c0ebcb9e32f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2641321 Commit-Queue: Alison Maher <almaher@microsoft.com> Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#846378}
-
siashah authored
This would impact the order of autofill suggestions on all platforms. Bug: 1156916 Change-Id: Icac331b398a127d21b84ab6b322d20290639ade9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2644244 Commit-Queue: Siddharth Shah <siashah@chromium.org> Reviewed-by:
Jared Saul <jsaul@google.com> Reviewed-by:
Siyu An <siyua@chromium.org> Cr-Commit-Position: refs/heads/master@{#846377}
-
Nicolás Peña Moreno authored
This CL adds a method that gets called when a frame reaches FCP. This allows us to aggressively flush the metrics from the renderer process to the browser process, which in turn means that our abandonment rates would be more accurate as a result, since the abandonment metric relies on whether FCP has been reached. Bug: 1048691 Change-Id: I7d0a4e2886a41f5eb007c0eed3b19e59df4917f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2642993Reviewed-by:
Steve Kobes <skobes@chromium.org> Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#846376}
-
Juliet Levesque authored
Migrates the crostini_browser_proxy component under the crostini_page to Polymer3. Change-Id: Ic4f7ca3ccbacea64e84cf02a29460dabef774efc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2640757Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Juliet Levesque <julietlevesque@google.com> Cr-Commit-Position: refs/heads/master@{#846375}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/783a881e..53d05d72 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I9fd87276e4a80f77279bfe348a20b9cd17fc03eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2644442Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#846374}
-
Ken Rockot authored
This moves the presentation web tests into wpt_internal and adapts them to use the newer Mojo JS modules. Since this already produces quite a bit of churn in the tests, the tests here are also opportunistically modernized where feasible, particularly concerning asynchronous logic. Bug: 1004256 Change-Id: I5515325cfc808cd5f0e7dff51840a94c4078b4b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2634278 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
-
Lijin Shen authored
Similar to crrev.com/c/2606874, add an extra check to avoid calling feature list before native is initialized. Bug: 1162510 Change-Id: I6f45bc0dbd7081abd41c105223f4b312d0af5ddb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2645506 Commit-Queue: Lijin Shen <lazzzis@google.com> Commit-Queue: Theresa <twellington@chromium.org> Auto-Submit: Lijin Shen <lazzzis@google.com> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#846372}
-
Mark Schillaci authored
This is a follow-up CL to add clearer dialog dismissal causes for the image descriptions dialog on Android. With this CL we now differentiate between dialogs that are dismissed by a user action on the dialog, vs dialogs that are dismissed due to changes in state, such as web contents being hidden or destroyed. This CL adds a new dialog dismissal cause for web contents destroyed. Original CL: crrev.com/c/2596417 AX-Relnotes: N/A Bug: 1057169 Change-Id: Id20d161d003dc9161fa9b3af792f6cc20b8aafe9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2630728 Commit-Queue: Mark Schillaci <mschillaci@google.com> Reviewed-by:
Mark Schillaci <mschillaci@google.com> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
-
Kevin Ellis authored
Animation times were change from Optional<double> to Optional<AnimationTimeDelta> in the following CL: https://chromium-review.googlesource.com/c/chromium/src/+/2591488 This change eroded the numerical precision of calculations involving time; however, we only require a time precision down to 1 microsecond (https://drafts.csswg.org/web-animations/#precision-of-time-values). Thus, it is safe to relax fuzzy equality constraints at the upper bounds of an animation. This patch, also addresses a previous inaccuracy where it was possible to recognize that an animation was limited (i.e. finished) yet not set the hold time when updating the finished state. Bug: 1169674, 1169111 Change-Id: I0d7869cac8809eb118b09b740a35a0fee4655303 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2644740 Commit-Queue: Kevin Ellis <kevers@chromium.org> Reviewed-by:
Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#846370}
-
Emircan Uysaler authored
This CL adds the corresponding Scenic commands for the received gfx::OverlayTransform for Fuchsia. This allows us to flip or rotate the overlay video content. Bug: 1169182 Change-Id: I9a5689251f3a363cd88db0d9b0bcc1b550cf2133 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2644565 Commit-Queue: Emircan Uysaler <emircan@chromium.org> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#846369}
-
Aleks Totic authored
Preparation for turning on the flag Change-Id: I33f36367d3d408307c5a884b697d3cfff97780bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2645033 Commit-Queue: Aleks Totic <atotic@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Auto-Submit: Aleks Totic <atotic@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#846368}
-
Nina Satragno authored
debugger-ui/inline-scope-variables.js was timing out but were only marked as Failure. Marking as timing out as well. Bug: 1149734,1150458 Change-Id: I71c6333bcfc6bb015285479a2ada156884e4b472 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2645369 Commit-Queue: Nina Satragno <nsatragno@chromium.org> Auto-Submit: Nina Satragno <nsatragno@chromium.org> Reviewed-by:
-
Cammie Smith Barnes authored
Removes '^chrome/browser/devtools/' from the _NOT_CONVERTED_TO_MODERN_BIND_AND_CALLBACK list in src/PRESUBMIT.py, as the chrome/browser/devtools directory has now been fully converted. Bug: 1007635 Change-Id: I370bcca30d2869b46c6e407ea336fa78824f1b30 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2645155Reviewed-by:
Charlie Reis <creis@chromium.org> Commit-Queue: Cammie Smith Barnes <cammie@chromium.org> Cr-Commit-Position: refs/heads/master@{#846366}
-
Toni Barzic authored
Records when the camera privacy switch state changes, when the "camera privacy switch on" notification is shown, and number of seconds between the time the notification is shown, and the time the user toggles the privacy switch off (using exact linear histogram to force the bucket size to 1 second). BUG=1165612 Change-Id: I435c2edbfba6844b2f7df91e9eb52062defe0799 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2634085 Commit-Queue: Toni Baržić <tbarzic@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#846365}
-
Brian Sheedy authored
Removes the Playstore version dimension from the AR tests running on Oreo. The Playstore version on the devices has changed, causing there to be no matching devices for testing, and the current version seems to work fine for the tests. Bug: 1168739 Change-Id: Id765b91a46b59789782d6e00593f49f0945c5ac7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2645348 Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Auto-Submit: Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#846364}
-
Katie Dektar authored
Had previously been re-enabled but appears to be flaking more frequently again. Bug: 1126876 Change-Id: Id3a6c5d50bb031b09646f9dddb6c5f5fe1960213 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2645466 Commit-Queue: Katie Dektar <katie@chromium.org> Commit-Queue: Daniel Hosseinian <dhoss@chromium.org> Auto-Submit: Katie Dektar <katie@chromium.org> Reviewed-by:
Hui Yingst <nigi@chromium.org> Reviewed-by:
Daniel Hosseinian <dhoss@chromium.org> Cr-Commit-Position: refs/heads/master@{#846363}
-
Henrique Nakashima authored
In builders, the path to dirmd needs to be passed as parameter. Add it preemptively so that when the recipe CL lands, this step doesn't fail due to the unexpected parameter. The parameter will be used when DIR_METADATA is parsed in getowners.py: https://chromium-review.googlesource.com/c/chromium/src/+/2645158 Bug: 1135347 Change-Id: Iee8ae9c653a8f41690ba357323f15294a2e91dad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2645062 Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Reviewed-by:
Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#846362}
-
Brian Ho authored
This CL adds some more logging around scoped_skia_write_access_ since we suspect that it being null causes a rare crash on Chrome OS. The member can be null for a number of reasons, so let's add some LOGs after each. This crash also happens rarely on Android which also uses the BufferQueue output surface, so these logging statements can probably help there as well. Bug: 1169364 Change-Id: Ia61510da3b8fb92166aed1edbb3bd33a262378d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2645151Reviewed-by:
Peng Huang <penghuang@chromium.org> Commit-Queue: Brian Ho <hob@chromium.org> Cr-Commit-Position: refs/heads/master@{#846361}
-
Rakib M. Hasan authored
Also add myself as owner for the deps file for that script and fixes the email address used for the common wpt scripts. Bug: None Change-Id: I72eb3e2a6ad52287ac83111d1f456c40df6ac572 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2644380Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Rakib Hasan <rmhasan@google.com> Cr-Commit-Position: refs/heads/master@{#846360}
-
Pete Williamson authored
Bug: 1165265 Change-Id: Id6a236cda259920b1e1069ebfaac646e68ed364f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2644057Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Carlos Knippschild <carlosk@chromium.org> Commit-Queue: Peter Williamson <petewil@chromium.org> Cr-Commit-Position: refs/heads/master@{#846359}
-
Elly Fong-Jones authored
This CL enacts the "class splitting refactor" (//docs/ui/views/class_splitting.md) on ColorChooserView, breaking it into: * A controller class called ColorChooser, whose lifetime is fully controlled by the client, and which is safe to call at any point in the lifecycle of the matching Widget/Views/etc * Two helper objects (instances of WidgetDelegate and View respectively) whose lifetimes are fully controlled by Views This CL serves as a prototype for how the class splitting refactor looks when applied to production code. Instead, have it use only the public API on WidgetDelegate. Bug: 1075649 Change-Id: I84655a9c204a9f5f88767ac792ce1abc846feda0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622995 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
-
Reilly Grant authored
This change converts callbacks from base::Bind and base::Callback to Once/Repeating in //chrome/browser/chromeos/display. Bug: 1148570 Change-Id: I707dd2dd440d2fbcc8a7fcad499cef29dc226a03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2645309 Auto-Submit: Reilly Grant <reillyg@chromium.org> Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#846357}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1611316382-2d0f555a9d3aa5811a7e026e1b7c53cee9a9715c.profdata to chrome-win64-master-1611338398-0baf9b45acb8a7713920cc39901da599be0fc770.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ic339793875e26f7e77b9d14c6e8097b414954a71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2645328Reviewed-by:
-
Reilly Grant authored
This change converts callbacks from base::Bind and base::Callback to Once/Repeating in //chrome/browser/chromeos/ownership. Bug: 1148570 Change-Id: Ic4d13d66bed7e6a14b952441de17d39f3dfc5618 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2645507 Commit-Queue: Reilly Grant <reillyg@chromium.org> Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Auto-Submit: Reilly Grant <reillyg@chromium.org> Reviewed-by:
-
Ahmed Mehfooz authored
Bug: 1169404 Change-Id: I458dee6a73e071f9f4d99dabf3907e5afb45963d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2642925Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/5b2a5204087d..57144c8685d3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Ic1a97e37f9efe784bf2578d3abd5c09d1a312ce7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2645109Reviewed-by:
-
