- 08 Oct, 2020 40 commits
-
-
Etienne Pierre-doray authored
Change-Id: I5a837c6e49c0beec1db69a54d6c8653e7d688045 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2459348Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Cr-Commit-Position: refs/heads/master@{#815114}
-
Raphael Kubo da Costa authored
Implement https://github.com/w3c/screen-wake-lock/pull/291, which makes the |type| parameter optional and default to "screen" in WakeLock.request(). Intent to Implement and Ship: https://groups.google.com/a/chromium.org/g/blink-dev/c/HxWEyZz2nmI ChromeStatus entry: https://chromestatus.com/feature/5725750881681408 Fixed: 1133696 Change-Id: Id3eb6281bfedeaabfa3a7e22d530d0133b50411f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2445017 Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Auto-Submit: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Cr-Commit-Position: refs/heads/master@{#815113}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/c895058e8c27..53db73226239 2020-10-08 szuend@chromium.org [ts] Type-check network/NetworkOverview.js with TypeScript 2020-10-08 szuend@chromium.org [ts] Type-check network/NetworkConfigView.js with TypeScript 2020-10-08 szuend@chromium.org [ts] Type-check network/NetworkWaterfallColumn.js with TypeScript If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ia1a0c247398573c324bc0641f21cd445ab237937 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461394Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#815112}
-
Justin Cohen authored
Bug: 1027429 Change-Id: Ic8d48b4a3a0a070bb850d5283ce688a8d4c1a703 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2456312Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#815111}
-
Yunke Zhou authored
Bug: 1135512 Change-Id: I5526b5cf4f06f7cba136d1981df977ebeb683bc7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2459867Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Commit-Queue: Yunke Zhou <yunkez@google.com> Cr-Commit-Position: refs/heads/master@{#815110}
-
Kent Tamura authored
IsContentMinimumInlineSizeZero() was wrong. Text controls should return true only if LogicalWidth().IsPercentOrCalc(). This change fixes 9 failing tests with LayoutNGTextArea flag. This CL has no behavior changes. LayoutNGTextArea flag is disabled yet. Bug: 1040826 Change-Id: I9f22de17ba8ea674240516c481558e5570a0c956 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461086Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#815109}
-
Olga Sharonova authored
This reverts commit 2a4aa8b6. Reason for revert: Speculative, suspected in breaking cros_browser_sanity_test, see https://ci.chromium.org/p/chrome/builders/ci/chromeos-eve-chrome/10590 Original change's description: > [CCA WebUI] Add deploy_swa function in cca.py > > It can help to boost the development when simply changing JS/CSS/HTML > on CCA (SWA). > > Bug: 1127459 > Test: cca deploy-swa [BOARD] [DEVICE] > Change-Id: I3f494a8d455b4c5632f91942f95b428b03294af9 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2456706 > Reviewed-by: Shik Chen <shik@chromium.org> > Reviewed-by: Inker Kuo <inker@chromium.org> > Commit-Queue: Wei Lee <wtlee@chromium.org> > Cr-Commit-Position: refs/heads/master@{#815087} TBR=shik@chromium.org,inker@chromium.org,wtlee@chromium.org Change-Id: I0ec15027ea4000d30ca7f7851dd8a6c806c37e0a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1127459 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461270Reviewed-by:
Olga Sharonova <olka@chromium.org> Commit-Queue: Olga Sharonova <olka@chromium.org> Cr-Commit-Position: refs/heads/master@{#815108}
-
Peter Kasting authored
Bug: 772945 Change-Id: I29af810a0b850c6e5d267dfa6f725865fe0de835 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2456486 Auto-Submit: Peter Kasting <pkasting@chromium.org> Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#815107}
-
Clemens Arbesser authored
Change-Id: Ic8f53c116cdbbf2fc752a348d1fc220288a54770 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461306 Auto-Submit: Clemens Arbesser <arbesser@google.com> Commit-Queue: Luca Hunkeler <hluca@google.com> Reviewed-by:
Luca Hunkeler <hluca@google.com> Cr-Commit-Position: refs/heads/master@{#815106}
-
Jan Krcal authored
This CL makes the tests more robust by always explicitly waiting for a concrete event and also improves logging for the future. Bug: 1126913 Change-Id: Ie6026f2c1e2b9ba06a3fe752e904418a9000e507 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461109 Commit-Queue: David Roger <droger@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Auto-Submit: Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#815105}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1602104345-f59e702ee5ca3195d69eeaf0b87216343ca1f336.profdata to chrome-win32-master-1602125584-6713bc5f5f4e479763b7dc4b9c334026b7e04f91.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I34f2d9a27c716a8c92bdf652a6904ccabcf9630c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2460568Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/c942e1b7..851a5e7f Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I443150691363b25ecf5b9af3739ae97df8e0b469 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461031Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#815103}
-
Matt Menke authored
They're mostly not being used, since IsolationInfo now mirrors those fields. While the fields in IsolationInfo still have one issue the fields in NetworkIsolationKey had (namely, they may be site instead of origin, for requests created from a NetworkIsolationKey), this does resolve one of the issues with the field: NetworkIsolationKeys are used as keys, and having two NIKs that are logically equal buy observably different is a potential source of bugs. Bug: None Change-Id: Id96ede47a3df2653e9db1c92694d261e13be4fb8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2451607 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Shivani Sharma <shivanisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#815102}
-
Stepan Khapugin authored
This reverts commit bb4205e3. Reason for revert: this test still fails. example: https://ci.chromium.org/p/chrome/builders/ci/ipad-device/13104 Original change's description: > [ios] Fix test ReplaceScrolledOffScreenCell > > Re-enables disabled test ReplaceScrolledOffScreenCell. > Uses hardcoded number of items in test instead of flakey > dynamic approach. > > Bug: 1104872 > Change-Id: Ic7ca34b7fa8936452fbc6efaee12563803eb023e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450812 > Reviewed-by: Mark Cogan <marq@chromium.org> > Commit-Queue: edchin <edchin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#814776} TBR=marq@chromium.org,edchin@chromium.org Change-Id: I01adfe29516ad5d31642892331f573c96246b1dd No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1104872 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461110Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#815101}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 0fe0c2f7. With Chromium commits locally applied on WPT: ae057949 "Add infrastructure/testdriver/actions/penPointerEventProperties.html" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: drott@chromium.org: external/wpt/css/css-text-decor NOAUTOREVERT=true TBR=lpz@google.com No-Export: true Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel,linux-wpt-payments-fyi-rel Change-Id: I1fee023995f6cd41f42ab5527e92d24f2b135d6f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461028Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#815100}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/1e48b0c6724e..c895058e8c27 2020-10-08 alexrudenko@chromium.org Migrate CommandMenu.js to TypeScript If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I5b1c7bf313ecabf9dd270b49b3ab8a6db5a246c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461126Reviewed-by:
-
Roman Sorokin authored
Also transfer ownership to rsorokin@ and cros-oac@ Fixed: 1130645 Change-Id: I441ac889d92c17197a88f90b30fa9af220e3d264 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2445469 Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Greg Levin <glevin@chromium.org> Reviewed-by:
Weilun Shi <sweilun@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#815098}
-
Swapnil authored
We want to investigate why the force installed extensions fail to install with error CRX_HEADER_INVALID. This CL adds UMA statistics to record whether the extension is from Chrome Web Store or not when extension fails with CRX_HEADER_INVALID error to get more details about it. New histogram added: "Extensions.ForceInstalledFailureWithCrxHeaderInvalidIsCWS" Bug: b/170080693 Change-Id: I5cbaef996151fa75aa5716c985c5ce2035a04ac1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2449334 Commit-Queue: Swapnil Gupta <swapnilgupta@google.com> Reviewed-by:
Oleg Davydov <burunduk@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/5f4e70b81046..952149303d06 2020-10-08 bclayton@google.com SpirvShaderDebugger: Have Function inherit LexicalBlock If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I0b653f86c4dc5301e5c590bc43b363a6ab622bbd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2460869Reviewed-by:
-
Eric Willigers authored
DesktopPWAsWithoutExtensions has shipped. The test no longer needs to be parameterized Bug: 1065748 Change-Id: I8005d00dc569fb63d1b3ca5f9856308a7216a88d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2455787 Commit-Queue: Sergey Poromov <poromov@chromium.org> Auto-Submit: Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#815095}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/24d353df49fd..b8389aa11092 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC olka@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: olka@google.com Change-Id: Ie75feda03fb3cf636b770454455e9e8a99733b0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2460870Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#815094}
-
Maksim Sadym authored
content_shell uses `ExecuteJavaScriptMethod` instead of `ExecuteJavaScriptForTests`, which should reduce serialisation/deserialisation overhead. The improvement for test run in `third_party/blink/web_tests/http/tests/devtools` is 2.02s (~1.2%). 95% confidence interval of this difference: From 0.3398 to 3.6936 Bug: chromium:1029427 Change-Id: Iba108d23192bde0fa12aa66654271cd85c5e4ada Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2452670 Commit-Queue: Maksim Sadym <sadym@chromium.org> Reviewed-by:
Mathias Bynens <mathias@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#815093}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/acdf3c1947a2..56df381f7893 2020-10-08 dberris@chromium.org [pinpoint] Support Monorail projects in UI If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC zhanliang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1111450 Tbr: zhanliang@google.com Change-Id: I27ecfdcf1abb0d26188bcc1305325fe4b4cf1a33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2459897Reviewed-by:
-
Bret Sepulveda authored
This removes part of permission prompts' dependency on PermissionRequest, with the goal of eventually moving the latter's functionality into the UI layer. Bug: 1110905 Change-Id: Icf53d3774c7415453c2266a0db07622483e7b197 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367836 Commit-Queue: Bret Sepulveda <bsep@chromium.org> Reviewed-by:
Olesia Marukhno <olesiamarukhno@google.com> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#815091}
-
Tim van der Lippe authored
This is required for landing https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2450036 R=szuend@chromium.org Bug: 1011811 Change-Id: Iff89f391e7bfa238c4eaeeb5e1ddc4efad19bd05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461267 Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org> Commit-Queue: Simon Zünd <szuend@chromium.org> Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org> Reviewed-by:
Simon Zünd <szuend@chromium.org> Cr-Commit-Position: refs/heads/master@{#815090}
-
Gauthier Ambard authored
The flag has been removed for a while, I forgot to remove the entry when removing the flag. Bug: none Change-Id: I5c733e1e659f30b6f003b2879be08e80f15af99c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2460810 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Auto-Submit: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#815089}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/1a87f1f025ef..6a09a9d46097 2020-10-08 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from a5a8696e to 090102a7 (466 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: timvp@google.com Change-Id: I0929a8a6c8a6b8f3da6ef2963dd50850eb9c35b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461047Reviewed-by:
-
Wei Lee authored
It can help to boost the development when simply changing JS/CSS/HTML on CCA (SWA). Bug: 1127459 Test: cca deploy-swa [BOARD] [DEVICE] Change-Id: I3f494a8d455b4c5632f91942f95b428b03294af9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2456706Reviewed-by:
Shik Chen <shik@chromium.org> Reviewed-by:
Inker Kuo <inker@chromium.org> Commit-Queue: Wei Lee <wtlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#815087}
-
Chris Thompson authored
This is an initial solution for crbug.com/1129197 -- the full solution is implemented in crrev.com/c/2422435 but requires changes to allow mocking CT results in order to land. This prevents logging private certificates, and adds a test explicitly exercising this case. It also makes the browser tests a bit more robust by tracking the last report seen by the test server and adding a step to flush a new report through for negative tests. Bug: 1129197 Change-Id: I7e1d4010b2666db7f98194aa1e3ba80df1e0a493 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2453777Reviewed-by:
Emily Stark <estark@chromium.org> Reviewed-by:
David Schinazi <dschinazi@chromium.org> Reviewed-by:
Nick Harper <nharper@chromium.org> Reviewed-by:
-
Gauthier Ambard authored
This CL removes dead code. Bug: none Change-Id: I35604f094924f30b6f342979369f8bbd8e089f3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424250 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
David Jean <djean@chromium.org> Cr-Commit-Position: refs/heads/master@{#815085}
-
Tanmoy Mollik authored
The sync row should launch signin flow if the user is signed in but did not give sync consent. This cl adds tests for that behavior. Bug: 1135686 Change-Id: If90233ca63ab0b9ad69121e2d68ae2c1e5f84c4a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454129 Commit-Queue: Tanmoy Mollik <triploblastic@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#815084}
-
Rohit Agarwal authored
The test logic before was counting the incognito notifications after having opened incognito tabs. However, that resulted in flakiness as sometimes we have two notifications for two incognito tabs and some other time we have only one notification. This CL instead of verifying the count of the notification displayed, relies on verifying whether there exists a notification which matches the StatusBarNotification#getTag with that of IncognitoNotificationManager#INCOGNITO_TABS_OPEN_TAG. Bug: 1134241 Change-Id: Iaf80ab369b29e2efcd124f7980f3b1ccba5f76c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2452472 Commit-Queue: Rohit Agarwal <roagarwal@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Cr-Commit-Position: refs/heads/master@{#815083}
-
Felipe Andrade authored
This work is been done in preparation for enabling Kerberos on MGS. See associated bug for further details. Bug: 983041 Change-Id: I4b351941bab4312067bcd7d687c62639259e5d59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2459367Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Felipe Andrade <fsandrade@chromium.org> Cr-Commit-Position: refs/heads/master@{#815082}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/38e6d226f24e..ac0723a06b53 2020-10-08 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 635de036d766 to 5f4e70b81046 (1 revision) 2020-10-08 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 3c775217 to af82ff26 (468 revisions) 2020-10-08 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from 7e22b1c44fb0 to 6b4a4a85dfd7 (9 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jvanverth@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: jvanverth@google.com Change-Id: I9f8a3039e5fec20bc45f03fe69bfbae14832d60c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2460565Reviewed-by:
-
Eric Willigers authored
DesktopPWAsWithoutExtensions has shipped. The test is no longer needed. Retiring the test also closes flaky test bugs. Bug: 1065748,1043466,1043806,1044900 Change-Id: I1344f2a2373ead35cf0700a26cdbf1af713e7bc9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2455567Reviewed-by:
Alan Cutter <alancutter@chromium.org> Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#815080}
-
Rainhard Findling authored
Bug: 1087263 Change-Id: I38fe5c305a2726e5600770adeffba26b031d99a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2445930Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Commit-Queue: Rainhard Findling <rainhard@chromium.org> Cr-Commit-Position: refs/heads/master@{#815079}
-
Alison Maher authored
In CL:2422213, the previous break token was stored as a reference in NGBoxFragmentBuilder. This change cleans up functions that take both as arguments since we can now access the break token from the builder. The only function where this was the case was FinishFragmentation(). No functional change. Bug: 829028 Change-Id: If9ea5a7ed937e9c2c127ae541b5c4de21dfed4f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2458781Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#815078}
-
Jérôme Lebel authored
ChromeIdentityService::GetIdentityWithEmail() is unused. The implementation is removed with: crrev.com/i/3318008. Change-Id: I8926f60be9bfd18814b1fc2aaadf4a3f9321c5dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2455607Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#815077}
-
Ioana Pandele authored
This is no longer useful. Bug: 1125735 Change-Id: Ib55174f552fcf6e05f72ee5db13ad24a18b51751 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440891Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Ioana Pandele <ioanap@chromium.org> Cr-Commit-Position: refs/heads/master@{#815076}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I849115f4af41f6c639f8424ae5cb868590501295 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2460867Reviewed-by:
-
