GitLab

If we have Arabic text in one line and English text in the second line
and select both lines then both touch handles will be right handles
(for RTL reasons). A previous CL (crrev.com/c/658599) assumed that
each handle had to have a different direction. This CL removes that
assumption.

Bug: 766466
Change-Id: Icdb725cc2cf21f593e90d5d90acbd2a489dbca1d
Reviewed-on: https://chromium-review.googlesource.com/678036Reviewed-by: Mohsen Izadi <mohsen@chromium.org>
Reviewed-by: Pedro Amaral <amaralp@chromium.org>
Commit-Queue: Pedro Amaral <amaralp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504215}

There is a Bluetooth issue which can result in a
BluetoothDiscoverySession returning IsActive() == false without a Stop()
call ever completing successfully. If this occurs, it is possible to
repro a stack overflow resulting in a crash.

This patch works around that issue to
ensure that it is not possible to get stuck out of sync.

Bug: 768521, 672263
Change-Id: I7574241db2be21f63aef371f567cf1d88aed0537
Reviewed-on: https://chromium-review.googlesource.com/683034
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504214}

Use device::mojom::HidDeviceInfo instead, make the device::HidDeviceInfo
internal of the //device/hid. So we can move the //device/hid into
//services in next step.

BUG=728223

Change-Id: I5d5cbd365f1debc7a963d54b9ccffc41fddda54a
Reviewed-on: https://chromium-review.googlesource.com/676946Reviewed-by: Colin Blundell <blundell@chromium.org>
Reviewed-by: Ken Rockot <rockot@chromium.org>
Commit-Queue: Ke He <ke.he@intel.com>
Cr-Commit-Position: refs/heads/master@{#504213}

This should be glProduceTextureCHROMIUM.
BUG=None

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I1961ced54de08b00f0b68ecfb560681568ee3436
Reviewed-on: https://chromium-review.googlesource.com/677024
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504212}

ServiceWorkerScriptURLLoader should check the HTTP response code of fetched
scripts and abort the subsequent sequence if it's not 2XX. This CL adds the
check and a unit test.

This also adds MockHTTPServer that is a handy utility to provide mocked
responses for ServiceWorkerScriptURLLoader and adds a test case for an empty
response body.

Bug: 748415
Change-Id: I3512d20650809ffca593197c200ce8dc871d435d
Reviewed-on: https://chromium-review.googlesource.com/672224
Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504211}

These 3 methods in each of SBRByPts and SBRByDts are not used by
anything, and are deleted by this change. I found these during
refactoring SBRByPts for PTS/DTS compliance, and split their deletion
into this CL to make compliance CL(s) smaller.

BUG=718641

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I2a50a6e618e6d3bcc2a799bec398ebe752dba690
Reviewed-on: https://chromium-review.googlesource.com/683154Reviewed-by: Dan Sanders <sandersd@chromium.org>
Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504210}

This patch changes the horizontal textfield insets in Harmony to be 8pt,
and changes the height to be 28pt by default. The height pre-Harmony
is changed by 2pt because its preferred height was taking into account
the border height as well, which is now fixed.

Bug: 764019
Change-Id: Icce4cc6a0a0038ccb23077299475aca1415ff9b6
Reviewed-on: https://chromium-review.googlesource.com/676474
Commit-Queue: Bret Sepulveda <bsep@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504209}

https://crrev.com/c/634847 started migration of view size storage
to ViewAndroid but it is not in effect yet, therefore the previous
size adjustment mechanism should be preserved. This CL restores
the resize flow accidentally removed and caused the reported regression.

Bug: 767658
Change-Id: I63b19043d404280b336663c46c17a646fcb7074e
Reviewed-on: https://chromium-review.googlesource.com/680156Reviewed-by: Matthew Jones <mdjones@chromium.org>
Reviewed-by: Donn Denman <donnd@chromium.org>
Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504208}

The crash occurs in AppsGridView::GetHeightOnTopOfAllAppsTiles. After
clicking the app icon, app list is dismissed. |folder_delegate_| becomes
nullptr, AppsGridView::GetHeightOnTopOfAllAppsTiles use
|suggestions_container_| without checking whether it is nullptr.

Changes:
Check nullptr for all usage of |suggestions_container_|,
|expand_arrow_view_| and |all_apps_indicator_| which are possibily
nullptr.

BUG=768287

Change-Id: I73832fdf0da95d431fb0c628bf0c8ba45c3b3a0a
Reviewed-on: https://chromium-review.googlesource.com/683227Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Weidong Guo <weidongg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504207}

This adds a learn more link to the TPM firmware update option on the device
reset aka powerwash OOBE screen.

BUG=chromium:767900
TEST=Manual

Change-Id: Iaaeb7c63f877b0b0d6e8e5fb3073a04eec3bd3e8
Reviewed-on: https://chromium-review.googlesource.com/682694Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Mattias Nissler <mnissler@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504206}

Changes:
Remove javascript/html code of Google Now, corresponding handlers, test
and strings.

BUG=731991,459827

Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I834d707eb3dee799e63348a3e717023b116a434d
Reviewed-on: https://chromium-review.googlesource.com/679739Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Stefan Kuhne <skuhne@chromium.org>
Commit-Queue: Weidong Guo <weidongg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504205}

Bug: 758467
Change-Id: I29102a65235a027da03abdec8b9e1d3e98b81115
Reviewed-on: https://chromium-review.googlesource.com/682554Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Commit-Queue: Eugene Ostroukhov <eostroukhov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504204}

https://pdfium.googlesource.com/pdfium.git/+log/92627618a937..ba14c0a5f12b

$ git log 92627618a..ba14c0a5f --date=short --no-merges --format='%ad %ae %s'
2017-09-22 thestig Update comments regarding dictionary keys in public APIS.
2017-09-25 dsinclair Hide CFX_UniqueKeyGen

Created with:
  roll-dep src/third_party/pdfium


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


TBR=dsinclair@chromium.org

Change-Id: I71ad62bc4a9e01ede71eeec5514979d35e9ffa81
Reviewed-on: https://chromium-review.googlesource.com/682998
Reviewed-by: <pdfium-deps-roller@chromium.org>
Commit-Queue: <pdfium-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504203}

AppListControllerSearchResultsBrowserTest.UninstallSearchResult is
broken by the Answer Card feature randomly. It happens when the
AnswerCardSearchProvider object is GCed before DidFinishNavigation
is called. Then the navigation context becomes nullptr and will
break the equal check with the content source.

This commit skips those late DidFinishNavigation calls by unsetting
the delegates when AnswerCardWebContents objects get recycled.

Crash logs:
[ RUN      ] AppListControllerSearchResultsBrowserTest.UninstallSearchResult
[10573:10573:0922/200830.460519:FATAL:answer_card_search_provider.cc(131)] Check failed: source == context_for_loading.contents.get() (0x15fd7b449f30 vs. (nil))
#0 0x00000387062c base::debug::StackTrace::StackTrace()
#1 0x00000388999c logging::LogMessage::~LogMessage()
#2 0x0000067d8611 app_list::AnswerCardSearchProvider::DidFinishNavigation()
#3 0x0000067d9a85 app_list::AnswerCardWebContents::DidFinishNavigation()
#4 0x00000267cb07 content::WebContentsImpl::DidFinishNavigation()
#5 0x000002375fb9 content::NavigationHandleImpl::~NavigationHandleImpl()
#6 0x00000237663e content::NavigationHandleImpl::~NavigationHandleImpl()
#7 0x00000266ad3c content::WebContentsImpl::~WebContentsImpl()
#8 0x00000266bade content::WebContentsImpl::~WebContentsImpl()
#9 0x0000067d91e3 app_list::AnswerCardWebContents::~AnswerCardWebContents()
#10 0x0000067d7ecd app_list::AnswerCardSearchProvider::~AnswerCardSearchProvider()
#11 0x0000067d7f2e app_list::AnswerCardSearchProvider::~AnswerCardSearchProvider()
#12 0x000008b3e28b app_list::SearchController::~SearchController()
...

Bug: 766784
Change-Id: Iaa5da44696c567815626d24d8bad5436cb971f27
Reviewed-on: https://chromium-review.googlesource.com/682756Reviewed-by: Vadim Tryshev <vadimt@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Jiaquan He <hejq@google.com>
Cr-Commit-Position: refs/heads/master@{#504202}

SourceBufferStream should not be buffering EOS buffers internally. In
fact, any access of such a buffer's timestamp() method would DCHECK.
This change removes an extraneous condition for such buffers leftover
from long-removed cross-fade splicing code.

BUG=718641

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Ie9a7bd9fb50195dd9f868462aae0879f5dedb6bc
Reviewed-on: https://chromium-review.googlesource.com/679734Reviewed-by: Chrome Cunningham <chcunningham@chromium.org>
Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504201}

Most files have underscores. Be consistent.

Change-Id: I43f0e73351b66257e706519aa2482f503cfc8ecf
Reviewed-on: https://chromium-review.googlesource.com/679517Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504200}

Change-Id: Ief5a75178dd9da1718fe559250a2719828dafe87
Reviewed-on: https://chromium-review.googlesource.com/665300
Commit-Queue: Quinten Yearsley <qyearsley@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504199}

This is a reland of 25a20e23
Original change's description:
> Make new NTLM implementation live.
> 
> - Passes all unit tests of previous implementation with minor exception
> - New implementation points empty security buffers at end of header
>   rather than 0 to follow the recommendation of the spec.
> 
> BUG=chromium:22532
> 
> Change-Id: I3e7617f512af70600b5c7e03be2dd8a7936a5bbd
> Reviewed-on: https://chromium-review.googlesource.com/598309
> Commit-Queue: Zentaro Kavanagh <zentaro@google.com>
> Reviewed-by: Asanka Herath <asanka@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#504077}

Bug: chromium:22532
Change-Id: I535474d33228442b0405053d5c9fbe7b7cc8116d
TBR: asanka@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/682435
Commit-Queue: Zentaro Kavanagh <zentaro@google.com>
Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504198}

TBR=piotrs

Bug: 768557
Change-Id: I412491a8dd6b88ef47a4cac3be59551f75f16a4f
Reviewed-on: https://chromium-review.googlesource.com/683008
Commit-Queue: Maria Khomenko <mariakhomenko@chromium.org>
Reviewed-by: Maria Khomenko <mariakhomenko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504197}

This CL adds a new isolate called telemetry_perf_tests_new. This
is a temporary name, so that we can test it out while keeping the
old isolate name. Eventually, this isolate will probably replace the
existing isolate.

The main difference between this and the current telemetry_perf_tests
is the script it's running, which is named
run_multiple_telemetry_benchmarks_as_googletest.py. As the name
suggests, the script runs multiple telemetry benchmarks, which is the
plan for a single swarming task in the future.

Bug: 758630
Change-Id: If3a8afbb22ae2dbf0ce9e69f9036449d47914d03
Reviewed-on: https://chromium-review.googlesource.com/668111Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Emily Hanley <eyaich@chromium.org>
Commit-Queue: Stephen Martinis <martiniss@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504196}

These functions should arguably have been defined to take uint32_t all along.
Use checked_cast to see if signedness or width bugs have been lurking in the
shadows.

Bug: None
Change-Id: Ieef9244f1ecf8e72b7dc4d5e85a42007b145d932
Reviewed-on: https://chromium-review.googlesource.com/676694Reviewed-by: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: Chris Palmer <palmer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504195}

Crash reports indicate that the EventDispatchDetails might actually be
wrong sometimes and that the EventProcessor is destroyed.

Add a weak ptr to trap the destruction of the current object.

BUG=763372

Change-Id: I5fec449221c962a6ce755cd3c69e62c2a0d3af9a
Reviewed-on: https://chromium-review.googlesource.com/658019Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504194}

With weston-terminal, exo can submit a frame before resizing bounds
of a shell surface. In that case, the local surface id is not set to
the frame sink for mus. It causes the crash. Fixing the crash by
setting the local surface id to the frame sink during creating the
frame sink.

Bug: None
Change-Id: I5b3202c176d2788a52aedbb259e7b18b5f5b8dd4
Reviewed-on: https://chromium-review.googlesource.com/682768Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Peng Huang <penghuang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504193}

supress deprecation warnings on ZoomButtonsController and
WebIconDatabase

BUG=755922

Change-Id: I7b0f6769127b45245652afcd53615d2f2fcde985
Reviewed-on: https://chromium-review.googlesource.com/682997Reviewed-by: Paul Miller <paulmiller@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Commit-Queue: James Wallace-Lee <jamwalla@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504192}

We are standardizing on the base implementation whenever possible.

Updates typedefs to using statements when code was changed.

file_transfer_message_handler_unittest.cc got a new helper function
since base::queue lacks an operator== required for gtest.

Bug: 757232
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I98d0c6880a5fcf5d236634abca51ba0fe41eeb6c
Reviewed-on: https://chromium-review.googlesource.com/682755
Commit-Queue: Brett Wilson <brettw@chromium.org>
Reviewed-by: Ken Rockot <rockot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504191}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/2d5148d57e6e..f7cc2170e1ab

$ git log 2d5148d57..f7cc2170e --date=short --no-merges --format='%ad %ae %s'
2017-09-25 rnephew [Telemetry]  Let --also-run-disabled-tests override StoryExpectations.DisableBenchmark
2017-09-25 rnephew [Telemetry] Remove Enabled/Disabled decorators from benchmark.py
2017-09-25 bpastene devil: Log output when forwarder has trouble exiting.
2017-09-25 bpastene devil: Don't check exit code when grep'ing through lsof.

Created with:
  roll-dep src/third_party/catapult
BUG=713222,767956,739899


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=sullivan@chromium.org

Change-Id: I6b80c0705eb3457b30d9cb36480bb46a01b9644d
Reviewed-on: https://chromium-review.googlesource.com/682772
Reviewed-by: <catapult-deps-roller@chromium.org>
Commit-Queue: <catapult-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504190}

This way it will actually be security reviewed.

Change-Id: I23dafdb528935c481b2f36694112caabcee0b47d
Reviewed-on: https://chromium-review.googlesource.com/681575Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504189}

This is a new feature that is enabled by the network service
(http://crbug.com/689549). A recent change landed on master, causing a
DCHECK at runtime, and blocking the roll: http://crrev.com/c/581488.

Disable this feature by default while we work with clamy@ to add
support.

BUG=768526

Bug: b/66275254 (Chromium merge for Cast)
Test: Run cast_shell on desktop, Cast YT.
Change-Id: I35323e01215b2923d0f24130dbb423c0cd55018d
Reviewed-on: https://chromium-review.googlesource.com/682955Reviewed-by: Luke Halliwell <halliwell@chromium.org>
Commit-Queue: Stephen Lanham <slan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504188}

Bug: 
Change-Id: Idf976d5de2b507c38bd2666f4e16d08e9fd5a25a
Reviewed-on: https://chromium-review.googlesource.com/683000Reviewed-by: Yash Malik <ymalik@chromium.org>
Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504187}

https://skia.googlesource.com/skia.git/+log/94fddf83816a..f40ae1a4b536

$ git log 94fddf838..f40ae1a4b --date=short --no-merges --format='%ad %ae %s'
2017-09-25 reed Revert "migrate to sk_sp for SkFontMgr API"
2017-09-25 benjaminwagner Specify CPU for CT Swarming tasks.
2017-09-25 reed migrate to sk_sp for SkFontMgr API
2017-09-25 mtklein Simplify / fix SkBitmap::ReadRawPixels()
2017-09-22 enne Make SkPath::readFromMemory failure silent

Created with:
  roll-dep src/third_party/skia
BUG=765858


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=jvanverth@chromium.org

Change-Id: Id721b8de8164bd59065b7a4a5203a5689e1022a3
Reviewed-on: https://chromium-review.googlesource.com/682954Reviewed-by: Skia Deps Roller <skia-deps-roller@chromium.org>
Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504186}

Currently blink caches SkImage uniqueIDs created by BitmapImage to
ensure reuse of cached decoded data for the frames of this image. The 2
systems that can cache the decode are cc and skia.

1) cc: The image decode cache in cc uses PaintImage::FrameKey to cache
the decodes and does not rely on SkImage uniqueIDs anymore.

2) skia: Skia's decode caching is tied to the lifetime of the SkImage,
which invalidates skia's cache in its dtor. This means that reusing the
same uniqueID will still result in purging of the decode from skia's
cache.

Also note that the only case where the reuse of uniqueID is important
is for each frame of a multiframe image. For static images,
BitmapImage already ensures caching of the decode by storing the
PaintImage which internally keeps a reference to the SkImage, and is
cleared in DestroyDecodedData. All cases which require animation of
images go through cc and use cc's image decode cache. The few cases,
for instance Canvas2D, which decode on the main thread and use skia's
cache only use the first frame of an animated image.

R=chrishtr@chromium.org, fmalita@chromium.org

Bug: 753639
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I78dcf84a8dad25c7742526af31c05ee381da7cf4
Reviewed-on: https://chromium-review.googlesource.com/677916Reviewed-by: Florin Malita <fmalita@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Commit-Queue: Khushal <khushalsagar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504185}

Both the local suggestion providers and the server can provide better
suggestions with this context.

Remove a now redundant / unnecessary function here.

Bug: 738559
Change-Id: I4780c99a1347b2aa80bc52cb57a1f772709b3ad8
Reviewed-on: https://chromium-review.googlesource.com/665514
Commit-Queue: Mark Pearson <mpearson@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504184}

Bug: 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ic15b36b92460885e00718e52bc882a111ff14227
Reviewed-on: https://chromium-review.googlesource.com/675666
Commit-Queue: Anton Urusov <urusant@google.com>
Reviewed-by: Dave Schuyler <dschuyler@chromium.org>
Reviewed-by: Georges Khalil <georgesak@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504183}

The changes make CompositorViewHolder not focusable and
OverviewListLayout not important when there is some view obscuring tabs.

Bug: 739382
Change-Id: I7739e25c31a659aae435c4e16313378caf7c4529
Reviewed-on: https://chromium-review.googlesource.com/679620Reviewed-by: Theresa <twellington@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Becky Zhou <huayinz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504182}

Remove armansito who isn't actively working on ChromeOS any more.

Change-Id: I8d65bc75c8ba67018038a4f7e6d166dc1c13ab43
Reviewed-on: https://chromium-review.googlesource.com/683005Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Brett Wilson <brettw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504181}

The flag is no longer used in Skia.

Change-Id: Ibe8dd12b274bc59d48c656665add5bcdd277ebdd
Reviewed-on: https://chromium-review.googlesource.com/682714Reviewed-by: Robert Phillips <robertphillips@google.com>
Commit-Queue: Florin Malita <fmalita@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504180}

The wireless network icon on the system tray has some information about
the signal strength which ChromeVox users miss out on.

Add a accessibility string in addition to convey the signal strength to
ChromeVox. The strings are weak, medium, strong and should match the
icon as well as possible.

Test: manual
Bug: 747468
Change-Id: Ib86ae9301a74342743fcf7e02aee874b18be4f15
Reviewed-on: https://chromium-review.googlesource.com/678917Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504179}

This migrates the Chromium version of the CRD app icons to AppIconset.

Bug: 768180
Change-Id: I2f369a93c617877be5d1f970cdbcd26f88ca5cfc
Reviewed-on: https://chromium-review.googlesource.com/680275
Commit-Queue: Yuwei Huang <yuweih@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Scott Nichols <nicholss@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504178}

Change-Id: I8ded09baf6ff050b088dd5c93b3a206a0bd6b695
Reviewed-on: https://chromium-review.googlesource.com/682475Reviewed-by: Scott Graham <scottmg@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Brett Wilson <brettw@chromium.org>
Commit-Queue: James Robinson <jamesr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504177}

UX with lock screen app windows being shown behind (as a background)
lock screen UI has been abandoned (in favour of simply closing the app
window). This means that TrayActionState::kBackground is now
unreachable, and can be removed.

This CL removed background state handling from
LockActionHandlerLayoutManager, which used to restack app window
over/bellow lock window depending on the current note action state
(now app windows should never be stacked bellow the lock window).

BUG=765039

Change-Id: I7cb95e2aa906fb7e8141f5ad7061df8973e10197
Reviewed-on: https://chromium-review.googlesource.com/669953Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Commit-Queue: Toni Barzic <tbarzic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504176}