- 01 Aug, 2019 40 commits
-
-
Charlene Yan authored
Bug: 901183 Change-Id: I14d43f32d571ff1a2fb23ce05c1d36e8ebd6541e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1713042Reviewed-by:
Robert Liao <robliao@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Commit-Queue: Charlene Yan <cyan@chromium.org> Cr-Commit-Position: refs/heads/master@{#683269}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/69e1462010af..80e7bd03d473 git log 69e1462010af..80e7bd03d473 --date=short --no-merges --format='%ad %ae %s' 2019-08-01 fmalita@chromium.org [skottie] Suppress placeholder range selector warnings 2019-08-01 robertphillips@google.com Disable LUM16F support for all Adreno devices Created with: gclient setdep -r src/third_party/skia@80e7bd03d473 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=benjaminwagner@google.com Bug: None Change-Id: I51b149c70ea40ece085e08ff7ba5c6ad7264d3ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730575Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#683268}
-
Andres Calderon Jaramillo authored
This CL renews this flag which was marked as expired for M77 in https://crrev.com/c/1729449. Just a few days prior to that CL, https://crrev.com/c/1721072 updated the expiry milestone for the flag in flag-metadata.json, but it seems this change was not picked up at the time of running tools/flags/list-flags.py. Now, tools/flags/list-flags.py --expired-by 77 doesn't list this flag. Test: None Bug: 868400 Change-Id: I9ecc0bd52469b1c2fd1aeece11003f036e2b56df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731174 Auto-Submit: Andres Calderon Jaramillo <andrescj@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Andres Calderon Jaramillo <andrescj@chromium.org> Cr-Commit-Position: refs/heads/master@{#683267}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/bd3f30535c33..59a041db7e50 git log bd3f30535c33..59a041db7e50 --date=short --no-merges --format='%ad %ae %s' 2019-08-01 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 4b9d9012..9c759119 (683063:683187) Created with: gclient setdep -r src/third_party/webrtc@59a041db7e50 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:None Change-Id: Ied83beffb3a546687c1b996d4cba1eed00237d29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730576Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#683266}
-
vikassoni authored
Add CHECK's to STreamTextureFactory and StreamTextureHostAndroid to debug - https://bugs.chromium.org/p/chromium/issues/detail?id=984309. Bug: 984309 Change-Id: I6c63bb6ee0e595e06c1368babb06966bea0238c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729832Reviewed-by:
Stefan Zager <szager@chromium.org> Reviewed-by:
Eric Karl <ericrk@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Commit-Queue: vikas soni <vikassoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#683265}
-
Nico Weber authored
Change-Id: Ideb0ee78b9be02c6acda3e1eddbae8dc9065fa15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731616 Commit-Queue: Nico Weber <thakis@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#683264}
-
Vincent Boisselle authored
We will need histograms to monitor the rollout of user demographics for UMA. Bug: 988142 Change-Id: I3a59daf0c2fb614949d6a9937dcc9f77efb2f04b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1721381Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Roger McFarlane <rogerm@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Vincent Boisselle <vincb@google.com> Cr-Commit-Position: refs/heads/master@{#683263}
-
Olivier Li authored
Bug: 969139 Change-Id: I9bb7df38642244f3a0612d885d73caedc51a382b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731293 Commit-Queue: Oliver Li <olivierli@chromium.org> Reviewed-by:
Joe Mason <joenotcharles@google.com> Cr-Commit-Position: refs/heads/master@{#683262}
-
Takuto Ikuta authored
The builder has 20 hour hourly resource usage in p99. http://shortn/_Guag8HYefG So I expect this won't add much burden to existing xenial pool. Current usage is in https://datastudio.google.com/s/uf5Kh6NZ8XA And we have 3400 xenial bots in MTV time now. Test on Xenial seems generally slow, so I need to mark some tests as timeout. https://ci.chromium.org/p/chromium/builders/ci/WebKit%20Linux%20MSAN/1075 https://ci.chromium.org/p/chromium/builders/try/linux-webkit-msan-rel/38 Total runtime: 17:00:52 (trusty) vs 19:37:25 (xenial). Bug: 954450, 856601 Change-Id: I6ad7e33cb678e33918614c21e58dc916d6dc3e1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728912Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#683261}
-
Caroline Rising authored
Pin button is visible when hoving the extensions menu button, when the extension's context menu is open, or when pinned. Bug: 959920 Change-Id: I73296cfd4502eb963954fa2e0c315ff57972478c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1720862 Commit-Queue: Caroline Rising <corising@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#683260}
-
Jared Saul authored
Bug: 988815 Change-Id: I02b5149313c0205a051dad12fbf12bda52c13de8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730257Reviewed-by:
Maxim Kolosovskiy <kolos@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Jared Saul <jsaul@google.com> Cr-Commit-Position: refs/heads/master@{#683259}
-
Ahmed Fakhry authored
This is a follow-up to CL https://crrev.com/c/1709966. Use the new widget's init properties to mark windows ignored in mini_views before they're added to the containers. This enables Desks to detect that it shouldn't bother updating the mini_views with these windows, which won't mirror there in the first place. BUG=979434, 866622 TEST=Added a new test. Change-Id: I8e104572a5573b6dd99110440523be1ee65806d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731671 Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#683258}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/1f08ded4fe9a..0aee86d1e39c Created with: gclient setdep -r src-internal@0aee86d1e39c The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I8634eed2309f8c47bb863d2dc9a187c50815fb04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730800Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#683257}
-
Sinan Sahin authored
Tests testCopyImageLinkCopiesLinkURL and testContextMenuRetrievesImageLinkOptions were failing when LayoutNG is enabled. The issue seems to be that the context menu is populated for the HTML element directly below the one the test is trying to long press. This CL works around the issue by adding an extra line break after the element in the test HTML. Bug: 959265 Change-Id: Ia5dd780c2b5edd4152412c6e61c8e6fb8749b0b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1721809Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Sinan Sahin <sinansahin@google.com> Cr-Commit-Position: refs/heads/master@{#683256}
-
James Cook authored
Steven and Michael are already owners because they are in //c/b/resources/settings/OWNERS. This just makes it explicit that they are good reviewers for the chromeos-specific bits too. Bug: none Change-Id: I4ae099a3b12a8d1d8dd5e5a4d1ab1e4ccf3d9b6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728434Reviewed-by:
May Lippert <maybelle@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#683255}
-
Daniel Bratell authored
The compiler can warn if you are using several variables with the same name, where one shadows another. This can be harmless or the sign of code that is hard to read and even potentially has bugs now or in the future. This enables the shadowing warning for blink/platform, which will implicitly ban variable shadowing there. Bug: 925310 Change-Id: Id49fcd57f92ca188fa11ccccc7c16a524c84f4f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730422Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#683254}
-
Vikas Soni authored
1. Refactor TextureOwner to separate out the codec buffer wait logic. This will help in merging SurfaceOwner and TextureOwner to create a single interface as well as single implementation of AImageReader and SurfaceTexture. 2. Create a wrapper class CodecBufferWaitCoordinator which owns TextureOwner object and the codec buffer wait logic. 3. Add a new class CodecBufferWaitCoordinator for testing. 4. Update unittests. Bug: 989304 Change-Id: Ia41c9f725f1787d82bf74e317bc6b9823280604b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715149 Commit-Queue: vikas soni <vikassoni@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#683253}
-
Sophie Chang authored
Note that the sentinel file approach that's currently used in the Previews component will not be updated to use the pref-based approach. The Previews sentinel file approach will be retained for a while to ensure this approach is stable and then we expect to delete it. Bug: 938080 Change-Id: I8779cc9b2eb1b25f33879066be59f72e1c208a99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1709663 Commit-Queue: Sophie Chang <sophiechang@chromium.org> Reviewed-by:
Doug Arnett <dougarnett@chromium.org> Cr-Commit-Position: refs/heads/master@{#683252}
-
Alex Cooper authored
Remove billorr@ from OWNERS as they are no longer on the team/reviewing code. Added self to OWNERS of third_party directories as appropriate. Change-Id: Icdfe38d098c9f7f2037ccb0836991f790a9d8b04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730523 Commit-Queue: Alexander Cooper <alcooper@chromium.org> Commit-Queue: Bill Orr <billorr@chromium.org> Auto-Submit: Alexander Cooper <alcooper@chromium.org> Reviewed-by:
Bill Orr <billorr@chromium.org> Reviewed-by:
David Dorwin <ddorwin@chromium.org> Reviewed-by:
Klaus Weidner <klausw@chromium.org> Cr-Commit-Position: refs/heads/master@{#683251}
-
Madeleine Barowsky authored
Attempted fixes for fuzzer bugs. Bug: 985995,986029,986007,987476 Change-Id: I3da85945fd722224da9c027f71944c97c823e8db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1718993 Commit-Queue: Madeleine Barowsky <mbarowsky@chromium.org> Reviewed-by:
enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#683250}
-
Owen Min authored
Disable TabHoverCardBubbleViewBrowserTest.InvokeUi_tab_hover_card on all Windows platforms. Bug: 932402 Change-Id: I5c07f588309907b87b8f5097307ed81fd70aa072 Tbr: kylixrd@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730922Reviewed-by:
Owen Min <zmin@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#683249}
-
John Delaney authored
This CL adds two metrics recording the time that the peak windowed CPU usage occurred in an ad frame/page. This is a useful metric to help understand in what cases these frames are under high CPU usage, either during initial load of the page or later in the page lifetime. Bug: 989672 Change-Id: Idf100d3aed04a9ed43e9bb19b23cd97e669a21b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729474Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Commit-Queue: John Delaney <johnidel@chromium.org> Cr-Commit-Position: refs/heads/master@{#683248}
-
Erik Chen authored
Historically, RenderView and RenderWidget were 1:1, and their lifetimes were entwined. 1) RenderViewHost would create the RenderView. 2) RenderView would create a RenderWidget and pass ownership of itself to the RenderWidget. 3) RenderViewHost's destructor would destroy the RenderWidget, thus destroying the RenderView We want the lifetime of RenderView and RenderWidget to be decoupled. The first step of this is making RenderView explicitly owned by the browser. This means that instead of (3), RenderViewHost's destructor will destroy the RenderView, which will in turn destroy the RenderWidget. One subtlety is that prior to this CL, RenderWidget was always destroyed asynchronously. The original reason for supporting this -- dealing with re-entrancy from nested message loops -- is no longer applicable. The IPC that destroys RenderWidget is asynchronous, which means it can never be called from a re-entrant context. However, it is possible for a RenderWidget associated with a child-frame to be synchronously destroyed by JS. This can be re-entrant. This CL updates destruction of RenderWidget to be synchronous when called from IPC. Bug: 987731 Change-Id: If4b319fab19d02c5495ba14e5cc929f441ca4d2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1717456 Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Auto-Submit: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#683247}
-
Jazz Xu authored
This CL includes: 1. Make OverlayWindowAndroid an WindowAndroid observer so that it can observe compositor state. 2. Add a Tab observer to PictureInPictureActivity so that when the tab that initiate PiP is destroyed or Chrome instance is closed, PictureInPictureActivity is notified and close properly. Bug: 964378 Change-Id: Iaab2ee5b1be3acf14d7380588aae63b0d666ec6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1717237Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Jazz Xu <jazzhsu@chromium.org> Cr-Commit-Position: refs/heads/master@{#683246}
-
Ilia Samsonov authored
MANUAL_ prefix handling moved from content test launcher delegate to gtest SetUp in browser tests. Bug: 936248 Change-Id: Ice0bdf1fa6cf19cb150de7ec03abbe8aacc36198 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1679166Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Ilia Samsonov <isamsonov@google.com> Cr-Commit-Position: refs/heads/master@{#683245}
-
Wei-Yin Chen (陳威尹) authored
When a readback cannot be returned because the tab is no longer attached to the view, all the subsequent readback would be abandoned, causing blank or stale thumbnails in Grid Tab Switcher. When this happens, the symptom persists until the tab is reattached to the view or a restart. This symptom caused StartSurfaceLayoutTest to be flaky. This CL tries to reduce the flakiness by reattaching the Tab to the view by switching to it. Bug: 989348 Change-Id: Ia714ac8f674b5194e91a56cf19b2b9e4ece8b55f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1727520Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#683244}
-
Florian Mayer authored
Change-Id: I5756149824d6cbdc2a91a7768607ef806fb52c6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730908Reviewed-by:
Eric Seckler <eseckler@chromium.org> Commit-Queue: Florian Mayer <fmayer@google.com> Auto-Submit: Florian Mayer <fmayer@google.com> Cr-Commit-Position: refs/heads/master@{#683243}
-
Himanshu Jaju authored
- No device with telephony capability - Device available but sync turned off Bug: 982229 Change-Id: I7eb6fe5226cbac9295faf47c8c20d487677a5273 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1726053 Commit-Queue: Himanshu Jaju <himanshujaju@chromium.org> Reviewed-by:
Richard Knoll <knollr@chromium.org> Cr-Commit-Position: refs/heads/master@{#683242}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/f275010c435a..5dd6b1e0a5ef git log f275010c435a..5dd6b1e0a5ef --date=short --no-merges --format='%ad %ae %s' 2019-08-01 saklein@chromium.org PackagesService: Fix uprev output. Created with: gclient setdep -r src/third_party/chromite@5dd6b1e0a5ef The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I9b954e13ffa25159e53e66c3f80fa89c1194336f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730796Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#683241}
-
Xing Liu authored
This CL adds MockBackgroundTaskCoordinator and create an interface for BackgroundTaskCoordinator, also move implementation code to cc file. Bug: 963304 Change-Id: I5308ca58d87d1e0c7e56b4b780955d132cc98c33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728346Reviewed-by:
Hesen Zhang <hesen@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#683240}
-
Albert Chaulk authored
This branch is suddenly getting hit, which should never happen, but misbehaving js is better than a browser crash Test: None Bug: 138416788 Change-Id: I3f81ac019b2d0b361bf390f0a1dfce1555a0e392 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730794 Commit-Queue: Albert Chaulk <achaulk@chromium.org> Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Cr-Commit-Position: refs/heads/master@{#683239}
-
Sami Kyostila authored
*** Note: There is no behavior change from this patch. *** The PostTask APIs will shortly be changed to require all tasks to explicitly specify their thread affinity, i.e., whether the task should run on the thread pool or a specific named thread such as a BrowserThread. This patch updates all call sites with thread affinity annotation. We also remove the "WithTraits" suffix to make the call sites more readable. Before: // Thread pool task. base::PostTaskWithTraits(FROM_HERE, {...}, ...); // UI thread task. base::PostTaskWithTraits(FROM_HERE, {BrowserThread::UI, ...}, ...); After: // Thread pool task. base::PostTask(FROM_HERE, {base::ThreadPool(), ...}, ...); // UI thread task. base::PostTask(FROM_HERE, {BrowserThread::UI, ...}, ...); This patch was semi-automatically prepared with these steps: 1. Patch in https://chromium-review.googlesource.com/c/chromium/src/+/1635827 to make thread affinity a build-time requirement. 2. Run an initial pass with a clang rewriter: https://chromium-review.googlesource.com/c/chromium/src/+/1635623 3. ninja -C out/Debug | grep 'requested here' | cut -d: -f1-3 | sort | \ uniq > errors.txt 4. while read line; do f=$(echo $line | cut -d: -f 1) r=$(echo $line | cut -d: -f 2) c=$(echo $line | cut -d: -f 3) sed -i "${r}s/./&base::ThreadPool(),/$c" $f done < errors.txt 5. GOTO 3 until build succeeds. 6. Remove the "WithTraits" suffix from task API call sites: $ tools/git/mffr.py -i <(cat <<EOF [ ["PostTaskWithTraits", "PostTask"], ["PostDelayedTaskWithTraits", "PostDelayedTask"], ["PostTaskWithTraitsAndReply", "PostTaskAndReply"], ["CreateTaskRunnerWithTraits", "CreateTaskRunner"], ["CreateSequencedTaskRunnerWithTraits", "CreateSequencedTaskRunner"], ["CreateUpdateableSequencedTaskRunnerWithTraits", "CreateUpdateableSequencedTaskRunner"], ["CreateSingleThreadTaskRunnerWithTraits", "CreateSingleThreadTaskRunner"], ["CreateCOMSTATaskRunnerWithTraits", "CreateCOMSTATaskRunner"] ] EOF ) This CL was uploaded by git cl split. R=blundell@chromium.org Bug: 968047 Change-Id: Ie7157527c1c36286c321800db5ecac024e8124c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728557 Commit-Queue: Sami Kyöstilä <skyostil@chromium.org> Auto-Submit: Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#683238}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/7ae4b7f3..69c9ca09 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I19e2313e425bc7efaa2f4f128ccd6ccc7b4e4313 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731331Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#683237}
-
Antonio Gomes authored
... so it does not collide with blink's conamed class, when these files get Onion soup'ed. BUG=704136 R=guidou@chromium.org Change-Id: I93961b646cb79ff29d54a10f5114bb4866e029f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731450 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Auto-Submit: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#683236}
-
Sami Kyostila authored
*** Note: There is no behavior change from this patch. *** The PostTask APIs will shortly be changed to require all tasks to explicitly specify their thread affinity, i.e., whether the task should run on the thread pool or a specific named thread such as a BrowserThread. This patch updates all call sites with thread affinity annotation. We also remove the "WithTraits" suffix to make the call sites more readable. Before: // Thread pool task. base::PostTaskWithTraits(FROM_HERE, {...}, ...); // UI thread task. base::PostTaskWithTraits(FROM_HERE, {BrowserThread::UI, ...}, ...); After: // Thread pool task. base::PostTask(FROM_HERE, {base::ThreadPool(), ...}, ...); // UI thread task. base::PostTask(FROM_HERE, {BrowserThread::UI, ...}, ...); This patch was semi-automatically prepared with these steps: 1. Patch in https://chromium-review.googlesource.com/c/chromium/src/+/1635827 to make thread affinity a build-time requirement. 2. Run an initial pass with a clang rewriter: https://chromium-review.googlesource.com/c/chromium/src/+/1635623 3. ninja -C out/Debug | grep 'requested here' | cut -d: -f1-3 | sort | \ uniq > errors.txt 4. while read line; do f=$(echo $line | cut -d: -f 1) r=$(echo $line | cut -d: -f 2) c=$(echo $line | cut -d: -f 3) sed -i "${r}s/./&base::ThreadPool(),/$c" $f done < errors.txt 5. GOTO 3 until build succeeds. 6. Remove the "WithTraits" suffix from task API call sites: $ tools/git/mffr.py -i <(cat <<EOF [ ["PostTaskWithTraits", "PostTask"], ["PostDelayedTaskWithTraits", "PostDelayedTask"], ["PostTaskWithTraitsAndReply", "PostTaskAndReply"], ["CreateTaskRunnerWithTraits", "CreateTaskRunner"], ["CreateSequencedTaskRunnerWithTraits", "CreateSequencedTaskRunner"], ["CreateUpdateableSequencedTaskRunnerWithTraits", "CreateUpdateableSequencedTaskRunner"], ["CreateSingleThreadTaskRunnerWithTraits", "CreateSingleThreadTaskRunner"], ["CreateCOMSTATaskRunnerWithTraits", "CreateCOMSTATaskRunner"] ] EOF ) This CL was uploaded by git cl split. R=rdevlin.cronin@chromium.org Bug: 968047 Change-Id: I2082e38973c90b49627bea4f27f7e00550f1a5ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729221 Auto-Submit: Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Asanka Herath <asanka@chromium.org> Commit-Queue: Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#683235}
-
Olivier Yiptong authored
This change adds a `url` parameter intended to be used later in the life of a file handle. One of the uses is to implement two steps in our security model: The SafeBrowsing check and the Quarantine Service process. Both of these steps require the source URL of the originator of the file data. Bug: 986588 Change-Id: I367e48a2654ac9aa0dc09979efabc9e31e261609 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729291 Commit-Queue: Olivier Yiptong <oyiptong@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Jay Harris <harrisjay@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#683234}
-
Kyle Milka authored
If daily refresh is enabled refresh the custom background image if it's been more than 24 hours since the last update. Bug: 850317 Change-Id: Ic3b5611bb9ce975998bce75936e19cfc3dd2ef66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1721682Reviewed-by:
Ramya Nagarajan <ramyan@chromium.org> Commit-Queue: Kyle Milka <kmilka@chromium.org> Cr-Commit-Position: refs/heads/master@{#683233}
-
Sky Malice authored
TBR: vitaliii@chromium.org Bug: 972871 Change-Id: I5196841239ddf2ba8294457ecc7542e6843374a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730953Reviewed-by:
Sky Malice <skym@chromium.org> Commit-Queue: Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#683232}
-
Kevin Marshall authored
Modifies the build to produce system image tarballs. Adds logic to unpack the tarballs and restructure their contents to mirror the layout of the image repository uploaded to CIPD. Bug: 977018 Change-Id: Ib4ccff8a514d72cd426232c6e1a548f593e38082 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1722287 Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#683231}
-
Sami Kyostila authored
*** Note: There is no behavior change from this patch. *** The PostTask APIs will shortly be changed to require all tasks to explicitly specify their thread affinity, i.e., whether the task should run on the thread pool or a specific named thread such as a BrowserThread. This patch updates all call sites with thread affinity annotation. We also remove the "WithTraits" suffix to make the call sites more readable. Before: // Thread pool task. base::PostTaskWithTraits(FROM_HERE, {...}, ...); // UI thread task. base::PostTaskWithTraits(FROM_HERE, {BrowserThread::UI, ...}, ...); After: // Thread pool task. base::PostTask(FROM_HERE, {base::ThreadPool(), ...}, ...); // UI thread task. base::PostTask(FROM_HERE, {BrowserThread::UI, ...}, ...); This patch was semi-automatically prepared with these steps: 1. Patch in https://chromium-review.googlesource.com/c/chromium/src/+/1635827 to make thread affinity a build-time requirement. 2. Run an initial pass with a clang rewriter: https://chromium-review.googlesource.com/c/chromium/src/+/1635623 3. ninja -C out/Debug | grep 'requested here' | cut -d: -f1-3 | sort | \ uniq > errors.txt 4. while read line; do f=$(echo $line | cut -d: -f 1) r=$(echo $line | cut -d: -f 2) c=$(echo $line | cut -d: -f 3) sed -i "${r}s/./&base::ThreadPool(),/$c" $f done < errors.txt 5. GOTO 3 until build succeeds. 6. Remove the "WithTraits" suffix from task API call sites: $ tools/git/mffr.py -i <(cat <<EOF [ ["PostTaskWithTraits", "PostTask"], ["PostDelayedTaskWithTraits", "PostDelayedTask"], ["PostTaskWithTraitsAndReply", "PostTaskAndReply"], ["CreateTaskRunnerWithTraits", "CreateTaskRunner"], ["CreateSequencedTaskRunnerWithTraits", "CreateSequencedTaskRunner"], ["CreateUpdateableSequencedTaskRunnerWithTraits", "CreateUpdateableSequencedTaskRunner"], ["CreateSingleThreadTaskRunnerWithTraits", "CreateSingleThreadTaskRunner"], ["CreateCOMSTATaskRunnerWithTraits", "CreateCOMSTATaskRunner"] ] EOF ) This CL was uploaded by git cl split. R=falken@chromium.org Bug: 968047 Change-Id: Iffe135d54c238ed7be67fe9bc1bdade9d050ee2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728666 Commit-Queue: Sami Kyöstilä <skyostil@chromium.org> Auto-Submit: Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#683230}
-