- 21 Jun, 2017 40 commits
-
-
danakj authored
Along with all associated names such as clients and subclasses. CompositorFrameSink is the name of the mojo APIs. Now that IPC is thru mojo, these APIs are actual C++ type names. Having other C++ types with the same name is eternally confusing. In the future one day LayerTreeFrameSink will submit ContentFrames or so instead of CompositorFrames, luckily its name won't need to change at that time. This CL is not opinionated on what things *should* be using. There are some places that are using LayerTreeFrameSinks that clearly should not be since they are not involved with LayerTreeHost. However this CL makes these more obvious instead of being hidden. Once this is done, we may rename the MojoCompositorFrameSink API to CompositorFrameSink and be free of the mojom::Mojo conundrum. R=enne@chromium.org, fsamuel@chromium.org TBR=sky@chromium.org, jam@chromium.org Bug: 722935 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I26377c13f46fc7aff9bb4f43590ee7e42c00df40 Reviewed-on: https://chromium-review.googlesource.com/538096 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Bo Liu <boliu@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Cr-Commit-Position: refs/heads/master@{#481086}
-
rlanday authored
I'm working on adding support for the Android spellcheck menu in https://codereview.chromium.org/2931443003 and we need to add another color to LayoutTheme to represent what color we should highlight a misspelled word while the menu is active. Android uses the same red color as the spellcheck underline but with some transparency added. We decided that it's better to add a separate method to LayoutTheme for getting the color than to assume that we'll want to do an alpha blend on every platform that might ever support this menu. BUG=715365 Review-Url: https://codereview.chromium.org/2953493002 Cr-Commit-Position: refs/heads/master@{#481085}
-
Anton Vayvod authored
Remove OnScreenAvailabilityNotSupported in favor of ScreenAvailability::DISABLED. BUG=723032 TEST=existing/updated tests. Change-Id: I824e832ad6454adfb4b221fd101b9eb4f65b46a3 Reviewed-on: https://chromium-review.googlesource.com/530324 Commit-Queue: Anton Vayvod <avayvod@chromium.org> Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#481084}
-
Daniel Cheng authored
Bug: 494719 Change-Id: I18072d5de766bb3bbade3b0a627abeb8f5e65715 Reviewed-on: https://chromium-review.googlesource.com/541160Reviewed-by:
Bugs Nash <bugsnash@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#481083}
-
Robert Flack authored
This relands patchset #4 id:60001 of https://codereview.chromium.org/2769353002/. Bug: 704817 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I737948ee6b81ec69a6f3ad778344b26423284554 Reviewed-on: https://chromium-review.googlesource.com/541636Reviewed-by:
Chris harrelson <chrishtr@chromium.org> Commit-Queue: Robert Flack <flackr@chromium.org> Cr-Commit-Position: refs/heads/master@{#481082}
-
yzshen authored
BUG= Review-Url: https://codereview.chromium.org/2940403002 Cr-Original-Commit-Position: refs/heads/master@{#481019} Committed: https://chromium.googlesource.com/chromium/src/+/e4da0e76b5b75d453fec094f62ad06659e66708e Review-Url: https://codereview.chromium.org/2940403002 Cr-Commit-Position: refs/heads/master@{#481081}
-
kojii authored
This patch implements more 'text-align' values: 'left', 'center', 'start', and 'end' (and its -webkit- versions.) 'text-align: justify' is to be worked out. Also supports the base direction, a.k.a. paragraph direction, as defined in UAX#9[1] for 'start' and 'end' to work. This support includes the heuristic resolution by 'unicode-bidi: plaintext'[2]. The heuristics for forced line breaks is not implemented yet. The failure of block-plaintext-004.html is caused by this. [1] http://unicode.org/reports/tr9/ [2] https://drafts.csswg.org/css-writing-modes-3/#valdef-unicode-bidi-plaintext BUG=636993 Review-Url: https://codereview.chromium.org/2940153002 Cr-Commit-Position: refs/heads/master@{#481080}
-
Andrey Kosyakov authored
This re-lands https://chromium-review.googlesource.com/535154 while fixing a silly crash due to binding to a not-yet-initialized member. Bug: 689520 Change-Id: I42ad68d73b9c3437dcfd97f099527a09ce1a0d09 Reviewed-on: https://chromium-review.googlesource.com/540118 Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#481079}
-
shend authored
Currently, the flex-wrap property is a 'storage_only' field, so it has no generated public getters/setters. This patch changes it to a 'keyword' field so that its getters/setters can be generated as well. We also generate the EFlexWrap enum and use the generated CSSValueID <-> EFlexWrap mappings. Diff: https://gist.github.com/cf118a1b16d0d7f12b32dbf644be638a/revisions BUG=628043 Review-Url: https://codereview.chromium.org/2944193002 Cr-Commit-Position: refs/heads/master@{#481078}
-
Sergey Ulanov authored
This is a reland of e8f9d07d Original change's description: > Remove Remoting API Key > > Chromoting host no longer needs API Key, so the key can be removed. > > Change-Id: I0960660ce2ddd5f4352ab691468d7c3881530d8d > Reviewed-on: https://chromium-review.googlesource.com/540035 > Reviewed-by: Roger Tawa <rogerta@chromium.org> > Reviewed-by: Joe Downing <joedow@chromium.org> > Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#480940} TBR=rogerta@chromium.org,pasko@chromium.org Change-Id: Icce0c8512c24ca8f902a9b1941232ab2c42b70b0 Reviewed-on: https://chromium-review.googlesource.com/540985Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#481077}
-
matthalp authored
The CoordinationUnitGraphObserver framework provides an API to observe and respond to to interesting events that occur throughout coordination unit lifetimes’ within the resource_coordinator service. R=*lpy@chromium.org,*oysteine@chromium.org,zhenw@chromium.org BUG=724306 Review-Url: https://codereview.chromium.org/2942403002 Cr-Commit-Position: refs/heads/master@{#481076}
-
Florin Malita authored
The test is attempting to catch the second frame of an animated GIF (2 x 400ms frames) using setTimeout(400). This is super-fragile. Refactor to use advanceImageAnimation() intead. BUG=chromium:734733,chromium:729075 Change-Id: I1528e602bed7f9599cb3bbf9a2821354a2e7aaef Reviewed-on: https://chromium-review.googlesource.com/541037Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Florin Malita <fmalita@chromium.org> Cr-Commit-Position: refs/heads/master@{#481075}
-
bsep authored
Revert of Fix Harmony checkbox having an ink drop highlight on click. (patchset #1 id:1 of https://codereview.chromium.org/2939043005/ ) Reason for revert: Breaks Chrome OS x86. Original issue's description: > Fix Harmony checkbox having an ink drop highlight on click. > > Follow-up to crrev.com/2911573002. There was a regression with a later > refactor of the ink drop code, and this fixes that. > > BUG=652510 > > Review-Url: https://codereview.chromium.org/2939043005 > Cr-Commit-Position: refs/heads/master@{#480958} > Committed: https://chromium.googlesource.com/chromium/src/+/6be568e4976c957d72d685a18b395bb60842273f TBR=sky@chromium.org,bruthig@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=652510 Review-Url: https://codereview.chromium.org/2948753003 Cr-Commit-Position: refs/heads/master@{#481074}
-
shrike authored
The "You can search from here with Google" first run bubble is a child window of the browser window, and is made key because it contains a button (so you can press the button via accessibility). All of this is fine, except the omnibox is the browser window's first responder and displays a focus ring. So, to the user it looks like they can start typing (and indeed, the bubble invites them to "Type to search or enter a URL to navigate...."), but the bubble consumes all key events. This is a jarring experience for a first-time Chrome Mac user. This cl changes the first run bubble to dismiss itself when the user starts typing. R=avi@chromium.org BUG=657592 Review-Url: https://codereview.chromium.org/2951013002 Cr-Commit-Position: refs/heads/master@{#481073}
-
pdr authored
This test has become flaky lately: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=http%2Ftests%2Finspector%2Findexeddb%2Fupgrade-events.html&testType=webkit_tests TBR=tmartino Bug: 735259 Change-Id: I352e6a27368a95750b1bd2dd6902ce16d328fd0d Reviewed-on: https://chromium-review.googlesource.com/542036Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#481072}
-
Stephen Martinis authored
Bug: 732898 Change-Id: I411932f8a835a5b0144040f62b71454a16f7a1ac Reviewed-on: https://chromium-review.googlesource.com/541858Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Stephen Martinis <martiniss@chromium.org> Cr-Commit-Position: refs/heads/master@{#481071}
-
xiaoyinh authored
Introduce a Mojo struct LoginUserInfo for login users which include basic information ash::mojom::UserInfo and other login/lock screen specific information. UserSelectionScreen will populate LoginUserInfo and send it back to lockscreen views. Compare to the user info we sent to current UI, LoginUserInfo have almost everything except: 1. user's gaiaId, which doesn't seem to be used by current UI.(user_pod_row.js) 2. public session information which doesn't exist on lockscreen. We might need it for login screen later and I have added a TODO for this. BUG=729687 Review-Url: https://codereview.chromium.org/2937553002 Cr-Commit-Position: refs/heads/master@{#481070}
-
James Cook authored
The current IME is always in the list of available IMEs, so just send its ID. Also get rid of ash::ImeInfo.selected since that can be inferred by comparing the ID of an IME to the current ID. Also cleanup some test init code in ImeControllerClientTest. Bug: 724305 Test: ash_unittests and chrome unit_tests Change-Id: Id830048980728e30c6ae39acd833e26beb83ff64 Reviewed-on: https://chromium-review.googlesource.com/540665 Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#481069}
-
Kenneth Russell authored
It's difficult to figure out why the crashes are being seen, so add explicit checks that will help track down the cause. These will be removed before the next branch point. BUG=733096 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Ic073fb288ff4084614142ff802e9a93457241c6a Reviewed-on: https://chromium-review.googlesource.com/540781Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#481068}
-
tanvir.rizvi authored
Move class DraggedNodeImageBuilder, DataTransfer::NodeImage(), DataTransfer::DeviceSpaceBounds(), DataTransfer::CreateDragImageForFrame() to DataTransfer.cpp. Move DragController::DragImageForSelection() to DragController.cpp. BUG=727981 Review-Url: https://codereview.chromium.org/2950793002 Cr-Commit-Position: refs/heads/master@{#481067}
-
Tien-Ren Chen authored
This reverts commit afc31e81. Reason for revert: WebKit_Win_x64_Builder_dbg failure Original change's description: > [SPv2] Rework GeometryMapper transform computation > > When computing the conversion matrix between two spaces, there are two > types of conversion that are commonly used, but with slightly different > semantics: > > m1 = destination_to_screen ^ -1 * source_to_screen > m2 = flatten(destination_to_screen) ^ -1 * flatten(source_to_screen) > > The former computes the space conversion, which is useful for mapping > 3D points from one space to 3D points in another space. The latter > computes the "projection through screen", which is useful for mapping > 2D points from a plane to a backing that is expected to be drawn onto > the screen. > > To illustrate the difference, see the following example: > <div style="transform:rotateY(45deg)">A</div> > <div style="transform:rotateY(-45deg)">B</div> > > The space conversion from A to B is equal to rotateY(90deg), but the > projection between the two planes is identity. > > Prior to this CL, GeometryMapper implemented a mixed semantics. This is > okay because all existing code only make queries that are co-planar, in > which case, either version returns identical result. This is because we > only make intra-compositing-layer queries, and 3D transform makes a > compositing boundary. > > This CL changed the implementation to strictly return the "projection > through screen". The algorithm runs in amortized O(1) by caching the > matrix between a node and its nearest coplanar ancestor that has a > invertible projection. > > Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 > Change-Id: Ia526dc6feb60c902f27589d73e78dfea235c6a93 > Reviewed-on: https://chromium-review.googlesource.com/534899 > Commit-Queue: Tien-Ren Chen <trchen@chromium.org> > Reviewed-by: Chris harrelson <chrishtr@chromium.org> > Cr-Commit-Position: refs/heads/master@{#481049} TBR=trchen@chromium.org,chrishtr@chromium.org Change-Id: I0d89ddadaa7889dd43705f9e7c0ef2876afafec2 No-Presubmit: true No-Tree-Checks: true No-Try: true Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Reviewed-on: https://chromium-review.googlesource.com/541943Reviewed-by:
Tien-Ren Chen <trchen@chromium.org> Commit-Queue: Tien-Ren Chen <trchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#481066}
-
catapult-deps-roller@chromium.org authored
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/1556ddcf20a1..a64c010c74cc $ git log 1556ddcf2..a64c010c7 --date=short --no-merges --format='%ad %ae %s' 2017-06-20 benjhayden Categorize diagnostics in how-to-write-metrics.md. 2017-06-20 erikchen Move symbolize_trace from tracing/bin to tracing/tracing/extras/symbolizer. Created with: roll-dep src/third_party/catapult BUG=734852 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: Iaffc9cdd2e7aa37a482dce08c4bde5dd233dfad1 Reviewed-on: https://chromium-review.googlesource.com/541922 Reviewed-by: <catapult-deps-roller@chromium.org> Commit-Queue: <catapult-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#481065}
-
Jeff Carpenter authored
The context for this change is to allow FindIt, which only speaks GTest, to run run-webkit-tests. Bug: 650747 Change-Id: Ic4930cda309395f1a19a619a701140909f6f296c Reviewed-on: https://chromium-review.googlesource.com/541757 Commit-Queue: Jeff Carpenter <jeffcarp@chromium.org> Reviewed-by:
Quinten Yearsley <qyearsley@chromium.org> Cr-Commit-Position: refs/heads/master@{#481064}
-
rnephew authored
[Telemetry] Move oopif, tab_switching, tracing, v8, and cluster telemetery benchmarks to story expectations TBR=charliea@chromium.org Bug: 713222 Change-Id: I6b4a71f0212b12cb31f0f53632aca36bef9e6c2d Reviewed-on: https://chromium-review.googlesource.com/541587Reviewed-by:
rnephew <rnephew@chromium.org> Commit-Queue: rnephew <rnephew@chromium.org> Cr-Commit-Position: refs/heads/master@{#481063}
-
tapted authored
The approach ends up pretty close to what's already done for Windows. On Mac, CTFontCreateForString() gives better fallbacks (i.e. they more often match what native UI does) and requires RenderTextHarfbuzz to do less work. However, it doesn't guarantee that the returned font can display every glyph in the provided string. So still use CTFontCopyDefaultCascadeListForLanguages (which is now a public API - hooray) to provide a last-resort list of fallback fonts. BUG=696867, 619684 Review-Url: https://codereview.chromium.org/2927953003 Cr-Commit-Position: refs/heads/master@{#481062}
-
pdfium-deps-roller@chromium.org authored
https://pdfium.googlesource.com/pdfium.git/+log/e10509a3d2a1..222e1a425e2d $ git log e10509a3d..222e1a425 --date=short --no-merges --format='%ad %ae %s' 2017-06-20 thestig Use early returns in more CPDFSDK_FormFillEnvironment code. 2017-06-20 npm Cleanup fpdf_parser_decode 2017-06-20 drgage Add FORM_GetSelectedText() function. 2017-06-20 thestig Add sample PDF with comboboxes. Created with: roll-dep src/third_party/pdfium BUG=59266 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls TBR=dsinclair@chromium.org Change-Id: I2204c2ba8126e518115d094200db4b44c6042a8e Reviewed-on: https://chromium-review.googlesource.com/541859 Reviewed-by: <pdfium-deps-roller@chromium.org> Commit-Queue: <pdfium-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#481061}
-
tedchoc authored
BUG=735145 Review-Url: https://codereview.chromium.org/2949903002 Cr-Commit-Position: refs/heads/master@{#481060}
-
szhangcs authored
BUG=734265 Review-Url: https://codereview.chromium.org/2711543002 Cr-Commit-Position: refs/heads/master@{#481059}
-
Luna Lu authored
Generated by script: grep -rli "lunalu" * | xargs -i@ sed -i 's/lunalu/loonybear/g' @ Change-Id: I022674b4e6dd8a30380539c38ff1dd949f92ade8 Reviewed-on: https://chromium-review.googlesource.com/533853Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Commit-Queue: Luna Lu <loonybear@chromium.org> Cr-Commit-Position: refs/heads/master@{#481058}
-
yosin authored
This is follow-up patch of the patch[1] which introduces |InSameLine()| to return wrong value for nodes without layout object. Original code: while (node && !node->GetLayoutObject() || InSameLine(...) The patch[1]: while (InSameLine(node, ...) InSameLine(Node* node) if (!node->GetLayoutObject()) return false; // This is wrong. This patch fixes this error. [1] http://crrev.com/2938923003: Introduce InSameLine() with Node and VisiblePosition BUG=734648 TEST=run_webkit_unit_tests --gtest_filter=VisibleUnitsTest.PreviousRootInlineBoxCandidatePositionWithDisplayNone Review-Url: https://codereview.chromium.org/2952563002 Cr-Commit-Position: refs/heads/master@{#481057}
-
yosin authored
This patch introduces |AdjustInlineBoxPositionForPrimaryDirection()| by moving code from then-clause of |AdjustInlineBoxPositionForTextNode()| with utilizing const-variable for improving readability. Note: The diff could be small but changing indentation makes diff larger. BUG=707656 TEST=n/a; no behavior changes Review-Url: https://codereview.chromium.org/2950763002 Cr-Commit-Position: refs/heads/master@{#481056}
-
Hiroshige Hayashizaki authored
ShouldAutoDetect(), DetectTextEncoding() and SetEncoding() calls and references to hint_* members are always coupled. This CL moves these code to AutoDetectEncodingIfAllowed() to make it clear that these are always coupled and executed only for |kUseAllAutoDetection|. Bug: 725654, 732893 Change-Id: Ia5a295bb2f600a4566f28738d421266ebb900343 Reviewed-on: https://chromium-review.googlesource.com/540179 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#481055}
-
renjieliu authored
Apply switches as previosuly discussed so we easily turn off language detection logging or translation logging if something goes wrong. BUG=728491, 722679 Review-Url: https://codereview.chromium.org/2941953002 Cr-Commit-Position: refs/heads/master@{#481054}
-
Javier Fernandez authored
We applied too much abstraction to the logic to retrieve, or to compute if required, the grid item's margin so it was flow-aware. However, we don't need to apply such abstraction when accesing data that depends only on the grid item's writing mode. We are already applying a flow-aware logic to determine whether we need to use item's logical width or height; for example, we do this during the track sizing algorithm when computed content-sized tracks. There is no specific bug associated to this CL, this is just a refactoring. Hence, no specific additional tests are required. Change-Id: I0a50d1224588e71f99699be6d7fdbe55952a1db6 Reviewed-on: https://chromium-review.googlesource.com/540595 Commit-Queue: Javier Fernandez <jfernandez@igalia.com> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Sergio Villar <svillar@igalia.com> Cr-Commit-Position: refs/heads/master@{#481053}
-
Stephen Lanham authored
While my original CL strived to maintain conformity with Chrome, it turns out that Features names are not at all consistent. Switch to snake_case, which both supports our legacy features and is more comfortable for developers. This will avoid the inevitable error in the backend where a developer uses underscores and fails to activate their feature. BUG= b/35424335 Change-Id: Ie2da5666964720c7134e7375189ea84f1e34ea34 Reviewed-on: https://chromium-review.googlesource.com/542035 Commit-Queue: Stephen Lanham <slan@chromium.org> Reviewed-by:
Alok Priyadarshi <alokp@chromium.org> Cr-Commit-Position: refs/heads/master@{#481052}
-
patricialor authored
Update the icon and the string used for the infobar that shows up when changing the site settings via the Page Info bubble. See https://drive.google.com/open?id=0BzEa5HU1aAqBamtNSUlFNTBZM3M for before/after screenshots of the infobar. BUG=734831 TEST=Navigate to https://www.google.com/. Open the Page Info bubble by clicking the "Secure" lock, and change "Location" to "Block". Close the Page Info bubble and observe the infobar's new string and icon. Review-Url: https://codereview.chromium.org/2952543002 Cr-Commit-Position: refs/heads/master@{#481051}
-
Sam McNally authored
https://crrev.com/480682 left behind some includes no longer needed by mojo bindings to avoid updating clients that relied on those transitive includes in that CL. This removes those includes and updates those clients. TBR=piman@chromium.org,imcheng@chromium.org,emircan@chromium.org Bug: 678155 Change-Id: Id5ed5671bd58b8c91b3e7cb2edab827e819e1f5b Reviewed-on: https://chromium-review.googlesource.com/541116 Commit-Queue: Sam McNally <sammc@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Cr-Commit-Position: refs/heads/master@{#481050}
-
Tien-Ren Chen authored
When computing the conversion matrix between two spaces, there are two types of conversion that are commonly used, but with slightly different semantics: m1 = destination_to_screen ^ -1 * source_to_screen m2 = flatten(destination_to_screen) ^ -1 * flatten(source_to_screen) The former computes the space conversion, which is useful for mapping 3D points from one space to 3D points in another space. The latter computes the "projection through screen", which is useful for mapping 2D points from a plane to a backing that is expected to be drawn onto the screen. To illustrate the difference, see the following example: <div style="transform:rotateY(45deg)">A</div> <div style="transform:rotateY(-45deg)">B</div> The space conversion from A to B is equal to rotateY(90deg), but the projection between the two planes is identity. Prior to this CL, GeometryMapper implemented a mixed semantics. This is okay because all existing code only make queries that are co-planar, in which case, either version returns identical result. This is because we only make intra-compositing-layer queries, and 3D transform makes a compositing boundary. This CL changed the implementation to strictly return the "projection through screen". The algorithm runs in amortized O(1) by caching the matrix between a node and its nearest coplanar ancestor that has a invertible projection. Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Ia526dc6feb60c902f27589d73e78dfea235c6a93 Reviewed-on: https://chromium-review.googlesource.com/534899 Commit-Queue: Tien-Ren Chen <trchen@chromium.org> Reviewed-by:
Chris harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#481049}
-
Matt Giuca authored
Previously, the method was visible, but calling it resulted in a SecurityError. Now it is simply gone (via [SecureContext] in the IDL). This brings the implementation in line with the draft spec at https://wicg.github.io/web-share. Bug: 734493 Change-Id: Ia246108fd7441f9b93bb0cbcf6a6fda4562d3a55 Reviewed-on: https://chromium-review.googlesource.com/541255 Commit-Queue: Matt Giuca <mgiuca@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#481048}
-
thanhph authored
dependency will be removed and replaced by ViewTestBase. Appropriate UIElement trees are also created to test DevTools. BUG=701835 Review-Url: https://codereview.chromium.org/2899783002 Cr-Commit-Position: refs/heads/master@{#481047}
-