GitLab

Since r478352 SecondaryUI buttons on Mac have all been MdTextButtons,
so we don't really care how regular LabelButtons look on Mac.

Remove some mac-specific logic from PlatformStyle and the
label_button_unittest.cc to make these tests pass. Some tests
currently fail just because the text color changes from solid
black/white to something different under MD due to logic in
ui::NativeTheme

Bug: 713030
Change-Id: I3b925918024d6c260da007ceb96900a2afb557a4
Reviewed-on: https://chromium-review.googlesource.com/741401Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512704}

This CL extends coverage of this method such that it isn't only creating YUV
planar frames.

Bug: 555909
Change-Id: I6be8f31a15ba2942feb24ecce5e5d94bb672ad43
Reviewed-on: https://chromium-review.googlesource.com/743022Reviewed-by: Yuri Wiitala <miu@chromium.org>
Reviewed-by: Emircan Uysaler <emircan@chromium.org>
Reviewed-by: Dan Sanders <sandersd@chromium.org>
Commit-Queue: Emircan Uysaler <emircan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512703}

First patch set has the old non-RLS expectations copied into
flag-specific/root-layer-scrolls, for comparison.

BUG=711468
R=pdr@chromium.org,skobes@chromium.org

Change-Id: Iaaaf6a31b37e80289c8265d53f18973b4eb8018c
Reviewed-on: https://chromium-review.googlesource.com/743710Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Stefan Zager <szager@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512702}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/d7dba58e..34cad05e

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org

Change-Id: I74299ab9eeea3cf1ad8b2c749dd56dfd316f6bc3
Reviewed-on: https://chromium-review.googlesource.com/744923Reviewed-by: v8 autoroll <v8-autoroll@chromium.org>
Commit-Queue: v8 autoroll <v8-autoroll@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512701}

- Hovering cursor over placeholder text now has correct 'I-beam' style.
- Disabled TextPrompts now look visually different, more transparent,
  consistent with the disabled style on disabled ToolbarButtons.

Screenshot: https://imgur.com/a/FgN8w

Bug: 773964
Change-Id: I87de99d01ac95653dba3eb62299a27ea2ff19de4
Reviewed-on: https://chromium-review.googlesource.com/744725Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Commit-Queue: Erik Luo <luoe@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512700}

This CL also runs git cl format on the test files.

BUG=778442

Change-Id: If823c7f0dc2c26485102c74223d1c1c6a946f0bb
Reviewed-on: https://chromium-review.googlesource.com/743162
Commit-Queue: Dominick Ng <dominickn@chromium.org>
Reviewed-by: Peter Kotwicz <pkotwicz@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512699}

The GetCrazyContext function calls the
crazy_context_add_search_path_for_address function to add the directory
where the crazy linker library was loaded from to the search path.
This function works by reading /proc/self/maps to discover the path
of the file from which the address passed as the second argument is
mapped, which is expected to be the crazy linker library.

However, there is no guarantee that the address of a static variable
such as s_crazy_context will be mapped; the linker may allocate them
into an unmapped region of the r/w segment.  This happens to be what
lld does with this variable. Because the address was not mapped,
we ended up failing to determine the search path, which led to a
failure to load libchrome.so in pre-modern APKs.

We can more reasonably rely on functions being memory mapped, so this
change causes us to take the address of a function instead.

Bug: 779185
Change-Id: I83cd882567c48a2cca443b7f5781c50ebc1b9bb4
Reviewed-on: https://chromium-review.googlesource.com/745201Reviewed-by: agrieve <agrieve@chromium.org>
Commit-Queue: Peter Collingbourne <pcc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512698}

Errors from JS such as Promise.reject() or TypeError/SyntaxError from
should not be grouped.

Bug: 774694
Change-Id: I791617939a6fd01f963d907e87f87f22031438c4
Reviewed-on: https://chromium-review.googlesource.com/742202Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Commit-Queue: Erik Luo <luoe@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512697}

Removes a needless call to setMenuBackgroundColor that relied on the tab
model selector being initialized, causing an NPE if that wasn't the
case. We already call setMenuBackgroundColor in updateVisuals, which is
called at the appropriate times.

Bug: 779472
Change-Id: Id87722088da11e178b92c4495eb0113faf454418
Reviewed-on: https://chromium-review.googlesource.com/744322Reviewed-by: Matthew Jones <mdjones@chromium.org>
Commit-Queue: Troy Hildebrandt <thildebr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512696}

The optimization to defer invalidations for offscreen animated images
also defers the invalidation resulting from a data update. Since
updating the data for an image results in creating a new generator,
this can create the following scenario.

If multiple elements have the same image and only one of them is
onscreen, the cached DisplayList for only the onscreen element is
invalidated. If the offscreen elements are in the interest rect, the
recordings committed to the compositor will have PaintImages with
different generators, holding different lengths of encoded data.

The above scenario breaks the assumption in cc that all PaintImages
received in a commit should share the same generator and be able to
display the same frame. If one of the images does not have the
selected frame, because it is holding stale data from a cached
recording, this results in a crash when rasterizing this recording.

This change fixes that by plumbing whether the invalidation for an
ImageChanged notification can be deferred. This disallows defering
of the invalidation if it resulted from a data update to the Image.

Note that since an invalidation here also includes raster invalidation,
this will result in more prepaint invalidations during image load. But
this is already the case with static images, and avoiding this requires
a larger change in how image updates are pushed to the compositor.

R=chrishtr@chromium.org

Bug: 775558
Change-Id: I9a6e166bf9f8db61758cac18040cca4612fc259a
Reviewed-on: https://chromium-review.googlesource.com/738622Reviewed-by: Philip Rogers <pdr@chromium.org>
Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org>
Commit-Queue: Khushal <khushalsagar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512695}

This reverts commit c75ea588.

Reason for revert: <INSERT REASONING HERE>
This CL breaks SettingsTestCase/testClearCookies and ExternalURLSSLTestCase 
Link:
https://build.chromium.org/p/chromium.mac/builders/ios-simulator-full-configs/builds/67
https://uberchromegw.corp.google.com/i/internal.bling.main/builders/iphone10-simulator/builds/8446

Original change's description:
> [ios] Moves setWebUsageEnabled to BrowsingDataRemovalController
> 
> Moves setWebUsageEnabled to BrowsingDataRemovalController from
> MainController. This is an intermediate step in order to remove Clear
> browsing data code from MainController.
> 
> 
> Bug: 
> Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet
> Change-Id: I06074b01635d655fb4acad8cb53795a8296b36ee
> Reviewed-on: https://chromium-review.googlesource.com/679014
> Commit-Queue: Sergio Collazos <sczs@chromium.org>
> Reviewed-by: Mark Cogan <marq@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#512648}

TBR=marq@chromium.org,sdefresne@chromium.org,sczs@chromium.org

Change-Id: I665265a6669b4941aac5e79dbc309bc65dba5447
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet
Reviewed-on: https://chromium-review.googlesource.com/745423Reviewed-by: Menglu Huang <huangml@chromium.org>
Commit-Queue: Menglu Huang <huangml@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512694}

This reverts commit 8232f416.

Reason for revert: Google Chrome Win builder failed.
shell_handler_win.mojom.h is still included by shell_integration_win.cc which was renamed by the original CL.
I'm wondering why the trybots missed this.

Original change's description:
> Servicifying ShellHandlerWin.
> 
> As part of the effort to deprecate UtilityProcessMojoClient, changing
> ShellHandlerWin to a service and consumers to bind the service through
> the service manager.
> Renamed the interface from ShellHandlerWin to WinShellUtil.
> 
> Bug: 777032
> Change-Id: I71a45a38a5fd0d5d02a8a0bccabf6a7e140acbd7
> Reviewed-on: https://chromium-review.googlesource.com/736147
> Commit-Queue: Jay Civelli <jcivelli@chromium.org>
> Reviewed-by: Scott Violet <sky@chromium.org>
> Reviewed-by: Tom Sepez <tsepez@chromium.org>
> Reviewed-by: Patrick Monette <pmonette@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#512682}

TBR=sky@chromium.org,thestig@chromium.org,jcivelli@chromium.org,noel@chromium.org,tsepez@chromium.org,pmonette@chromium.org

Change-Id: I03bb3ac7bfa0e9e98fc63034d7e81a62fcdfd21a
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 777032
Reviewed-on: https://chromium-review.googlesource.com/745461Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Commit-Queue: Makoto Shimazu <shimazu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512693}

This is a follow up after r510461. In that patch we added a TODO in
IndefiniteSizeStrategy::FreeSpaceForStretchAutoTracksStep().
This was related to how preferred widths were computed,
that could be missing the min-width information.

However after r511451 removing some wrong code
in LayoutGrid::UpdateBlockLayout(), that was trying to compute
the preferred widths, we can avoid doing any special calculation
for the columns case, as that's already managed
by LayoutBlock::ComputePreferredLogicalWidths().

Basically GridTrackSizing provides a min and max logical widths
that ignore min-width. But that's not an issue as LayoutGrid only
overrides ComputeIntrinsicLogicalWidths(),
then ComputePreferredLogicalWidths() will use that information
together with the min-size and properly compute the preferred widths.

For this reason in FreeSpaceForStretchAutoTracksStep() we don't need
any special computation for columns, the same that happens
in RecomputeUsedFlexFractionIfNeeded().

Added two unit tests to verify that the preferred widths are right
in both cases (auto and flexible tracks with min-width).

Bug=773625

Change-Id: I69efeb064fa03685c3e77bca33d294df3e1db79d
Reviewed-on: https://chromium-review.googlesource.com/741505Reviewed-by: Javier Fernandez <jfernandez@igalia.com>
Commit-Queue: Manuel Rego Casasnovas <rego@igalia.com>
Cr-Commit-Position: refs/heads/master@{#512692}

https://chromium.googlesource.com/angle/angle.git/+log/e7c5f4f05c87..163965d5ce2b

$ git log e7c5f4f05..163965d5c --date=short --no-merges --format='%ad %ae %s'
2017-10-11 cwallez BUILD.gn: prepare dEQP test support on Mac

Created with:
  roll-dep src/third_party/angle


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.angle:android_angle_rel_ng,android_angle_deqp_rel_ng,linux_angle_rel_ng,linux_angle_dbg_ng,linux_angle_deqp_rel_ng,linux_angle_ozone_rel_ng,mac_angle_rel_ng,mac_angle_dbg_ng,win_angle_rel_ng,win_angle_dbg_ng,win_angle_x64_rel_ng,win_angle_x64_dbg_ng,win_angle_deqp_rel_ng,win_angle_x64_deqp_rel_ng;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=cwallez@chromium.org

Change-Id: If105bad8635efef8c27bc54145eaa862836f5912
Reviewed-on: https://chromium-review.googlesource.com/744972Reviewed-by: angle-deps-roller . <angle-deps-roller@chromium.org>
Commit-Queue: angle-deps-roller . <angle-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512691}

Make triggering of Stopped in bg signal more generic, it should not be
tied to the experiment to stop loading.
A future CL will trigger a JS callback to indicate stopped to the app. 

Bug: 763573
Change-Id: I439e70fab824d2e243ebfa731d5f27464dc629ff
Reviewed-on: https://chromium-review.googlesource.com/736903
Commit-Queue: Shubhie Panicker <panicker@chromium.org>
Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
Reviewed-by: Fadi Meawad <fmeawad@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512690}

This CL adds a new harness to the safe browsing triggered popup
blocker browser test which mocks HTTP responses from the safe browsing
server.

It also tweaks the ScopedLoggingObserver to stop listening (globally)
on messages when it is destroyed, and it only considers messages that
have come in since it is instantiated.

Bug: 756009,756089
Change-Id: I2ad8bcebbdaf09252fa323e9de49c0de943e372b
Reviewed-on: https://chromium-review.googlesource.com/731406
Commit-Queue: Charlie Harrison <csharrison@chromium.org>
Reviewed-by: Shivani Sharma <shivanisha@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512689}

The flag is exposed in chrome://flags

Also deny requests that encounter certificate errors in
ChromeContentBrowserClientAllow::CertificateError, causing them to appear like
net errors with ERR_INSECURE_RESPONSE. Subsequent CLs will make them behave more
and more like old interstitials.

Bug: 778857
Change-Id: Ie50f8475db5ae0f6b98f17e17128587fc8553848
Reviewed-on: https://chromium-review.googlesource.com/742136Reviewed-by: Emily Stark <estark@chromium.org>
Commit-Queue: Lucas Garron <lgarron@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512688}

Only for Android. Right now OnEstablishedOnIO retries on failure
indefinitely. The main reason this is a problem on android is in
CompositorImpl, there is a timeout waiting for EstablishChannel. If the
failure is due to a gpu timeout, then CompositorImpl doesn't known about
the try and doesn't reset its timeout, thus making it more like to have
the entire browser be killed.

Move the timeout logic into BrowserGpuChannelHostFactory instead so
that the timeout can be reset when EstablishGpuChannel is retried.

Bug: 680777
Change-Id: I47da7d3f2b3ca238c3aec547497adf57dc63a73d
Reviewed-on: https://chromium-review.googlesource.com/742484
Commit-Queue: Bo <boliu@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512687}

Some of the decoder code paths depend on underlying driver (e.g.
version, extensions, workarounds), and of the client configuration (e.g.
context type and options). This CL allows the fuzzers to take some bits
from the input data to configure the decoder in different ways, to allow
exploring those various code paths and increasing coverage.

Bug: None
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I23a77878414ade4400a267b30d89f979a0ff4374
Reviewed-on: https://chromium-review.googlesource.com/744735Reviewed-by: Victor Miura <vmiura@chromium.org>
Commit-Queue: Antoine Labour <piman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512686}

This CL
- introduces integrity-related members to ScriptFetchOptions,
- sets them in PrepareScript(), WorkletGlobalScope.cpp and
  DynamicModuleResolver.cpp as specced, and
- uses them for classic scripts, in ClassicPendingScript::Fetch().

For module scripts, the integrity-related members are not used,
and are sometimes set incorrectly.
This will be fixed in a subsequent CL.

Bug: 771486, 772100
Change-Id: I0983bc6ad02b73472d67bf1b2ce169d2d71c5be3
Reviewed-on: https://chromium-review.googlesource.com/736721
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512685}

Bug: 779649
Change-Id: Ic3ffb1886a3d3dae5389aef0d5a52c12c6c31635
Reviewed-on: https://chromium-review.googlesource.com/744422
Commit-Queue: Dan Erat <derat@chromium.org>
Reviewed-by: Jeremy Klein <jlklein@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512684}

This reverts commit 8a3a84dc.

Reason for revert: Unit test failed in Linux Test, see https://luci-milo.appspot.com/buildbot/chromium.linux/Linux%20Tests/63991

Original change's description:
> Make resource_coordinator/ strongly typed.
> 
> This patch:
> 1. Added CU relation manipulation methods in mojo interface and public APIs;
> 2. Created one type of *ResourceCoordinator for each coordination unit type;
> 3. Removed generic CoordinationUnit mojo interface and implementation;
> 4. Replaced every call of SetProperty and SendEvent with new public APIs;
> 5. Added more tests.
> 
> BUG=775691
> 
> Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation
> Change-Id: I10b5c6a5ce9d8f0fbe3c2c3afef4ee4da7da0757
> Reviewed-on: https://chromium-review.googlesource.com/736036
> Commit-Queue: lpy <lpy@chromium.org>
> Reviewed-by: Peter Beverloo <peter@chromium.org>
> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
> Reviewed-by: oysteine <oysteine@chromium.org>
> Reviewed-by: Zhen Wang <zhenw@chromium.org>
> Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#512654}

TBR=dcheng@chromium.org,kinuko@chromium.org,peter@chromium.org,zhenw@chromium.org,japhet@chromium.org,oysteine@chromium.org,lpy@chromium.org

Change-Id: I0ecfcf6fe272d6be9dacf022e9221db346294abd
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 775691
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation
Reviewed-on: https://chromium-review.googlesource.com/745282Reviewed-by: lpy <lpy@chromium.org>
Commit-Queue: lpy <lpy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512683}

As part of the effort to deprecate UtilityProcessMojoClient, changing
ShellHandlerWin to a service and consumers to bind the service through
the service manager.
Renamed the interface from ShellHandlerWin to WinShellUtil.

Bug: 777032
Change-Id: I71a45a38a5fd0d5d02a8a0bccabf6a7e140acbd7
Reviewed-on: https://chromium-review.googlesource.com/736147
Commit-Queue: Jay Civelli <jcivelli@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Patrick Monette <pmonette@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512682}

To improve touchpad overscroll sensitivity, start and completion
thresholds for touchpad are increased by 20%. This needed splitting some
threshold into two separate ones for touchpad and touchscreen.

Also, both vertical and horizontal overscroll now use maximum of screen
width and screen height to calculate completion threshold. Previously,
vertical overscroll was using screen height and horizontal overscroll
was using screen width. This change makes overscroll in both dimensions
more consistent.

Also, some parameters had different values for vertical vs horizontal
overscroll. They have been merged into a single parameter.

BUG=772103
TEST=RenderWidgetHostViewAuraOver*Test.* in content_unittests

Change-Id: Id4efa17b247fffdbd13c0087be5afbec85f81131
Reviewed-on: https://chromium-review.googlesource.com/740782Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Commit-Queue: Mohsen Izadi <mohsen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512681}

This CL plumbs ScriptFetchOptions from ScriptLoader::PrepareScript()
to ClassicPendingScript::options_ to ClassicScript, instead of
reconstructing in ClassicPendingScript::GetSource().

Thus this CL removes ScriptLoader::nonce_.

Bug: 771486
Change-Id: I3b74da2e65176ae0c04068abba05413b675a28b0
Reviewed-on: https://chromium-review.googlesource.com/736876
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512680}

Upstream configure.ac invokes AC_USE_SYSTEM_EXTENSIONS, which adds
this flag on Linux. We need this for the upcoming libdrm rebase
which starts using vasnprintf, which is only available when this
flag is passed.

BUG=763760

Change-Id: I296446c8493f56f6bea74925c4f85a95658f9e15
Reviewed-on: https://chromium-review.googlesource.com/737472
Commit-Queue: Daniele Castagna <dcastagna@chromium.org>
Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512679}

This CL categorizes some disabled browser tests with service worker
related crbug link since they have similar stack trace.

This CL also enables a browser test that runs successfully when using
network service.

Bug: 769401
Change-Id: Icaeaad7c39c45b702bbf4a7e06ea40fbd2ff1985
Reviewed-on: https://chromium-review.googlesource.com/738876
Commit-Queue: Jun Cai <juncai@chromium.org>
Reviewed-by: Yuzhu Shen <yzshen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512678}

Bug: 769098
Change-Id: I0d67f5162183f13019bc18ebe98a99389bec04db
Reviewed-on: https://chromium-review.googlesource.com/742364
Commit-Queue: Elliot Glaysher <erg@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512677}

Under MD, these unit tests invoke PageInfoUI::PermissionActionToUIString(..)
which require the permission to have a source set. Use
content_settings::SETTING_SOURCE_USER.

Bug: 713030
Change-Id: I2ce0ece216dddc9dd1aff26b5dc166ce1ae437e5
Reviewed-on: https://chromium-review.googlesource.com/742347Reviewed-by: Trent Apted <tapted@chromium.org>
Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Commit-Queue: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512676}

These tests are command line tests which may use the same isolate and binary,
but with different permutations of command line arguments. This allows us to
run the same test suite with multiple sets of arguments. This is useful for
testing chromium-based tests that don't want to launch child processeses from
a single test, but rather run different permutations of the same test binary.

New tests added for the new functionality and for the previous "c plus plus"
isolate test functionality.

BUG=angleproject:2188

Change-Id: I97434db67ffbd9fc75edb712f6706543c7a5af54
Reviewed-on: https://chromium-review.googlesource.com/743683
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#512675}

Original CL: https://chromium-review.googlesource.com/737877

This CL avoids erroneous array bound checks in the standard algorithm
library.

This is a preparation for AVX optimization of blink::VectorMath
functions.

Bug: 778262
Change-Id: Ifc8465644a048cd0815c993dd824bdf62d04415a
Reviewed-on: https://chromium-review.googlesource.com/744005Reviewed-by: Raymond Toy <rtoy@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Eero Häkkinen <eero.hakkinen@intel.com>
Cr-Commit-Position: refs/heads/master@{#512674}

By David Dorwin request.

Bug: None
Change-Id: Ie06397c5d14db8260983f71aec405c0c07f66923
Reviewed-on: https://chromium-review.googlesource.com/740687Reviewed-by: David Dorwin <ddorwin@chromium.org>
Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Commit-Queue: Viatcheslav Ostapenko <sl.ostapenko@samsung.com>
Cr-Commit-Position: refs/heads/master@{#512673}

https://pdfium.googlesource.com/pdfium.git/+log/d2d4df84d3c2..d6e9cfaab055

$ git log d2d4df84d..d6e9cfaab --date=short --no-merges --format='%ad %ae %s'
2017-10-30 dsinclair Convert JS resource into enum class
2017-10-30 art-snake Remove useless code.
2017-10-30 hnakashima Deduplicate md5s in fpdfannot_embeddertest.cpp for Windows and others.
2017-10-30 art-snake Use CPDF_PageDataAvail to check page availability.
2017-10-30 dsinclair Rename global data files to match contents
2017-10-30 dsinclair Move fpdfsdk/javascript to fxjs/
2017-10-30 thestig Combine common code in fpdf_transformpage.cpp.
2017-10-30 art-snake Use CPDF_PageDataAvail to check page resources availability.
2017-10-30 dsinclair Rename util to cjs_util
2017-10-30 art-snake Use CPDF_PageDataAvail to check form availability.
2017-10-30 npm More safe ints in CJBig2_TRDProc
2017-10-30 dsinclair Move resource to js_resource

Created with:
  roll-dep src/third_party/pdfium


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


TBR=dsinclair@chromium.org

Change-Id: I4614921a455668308342f45894b3bffd2ed2b17c
Reviewed-on: https://chromium-review.googlesource.com/744737
Reviewed-by: <pdfium-deps-roller@chromium.org>
Commit-Queue: <pdfium-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512672}

MainController's -topPresentedViewController is deprecated. It performs a walk
from the bottom of the VC hierarchy to the top most VC. But this walk is
not necessary when the presenting VC is known.

In most cases, the presenting VC is known so the VC hierarchy walk is not 
necessary. We can pass the presenting VC through the dispatcher.

Bug: 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I69f9dd45ae5b55c9cfe95a56d014c11a7390f8fa
Reviewed-on: https://chromium-review.googlesource.com/705635
Commit-Queue: edchin <edchin@chromium.org>
Reviewed-by: edchin <edchin@chromium.org>
Reviewed-by: Gregory Chatzinoff <gchatz@chromium.org>
Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org>
Reviewed-by: Rohit Rao (ping after 24h) <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512671}

Enabling the checkout requires setting
    "custom_vars": {
      "checkout_libaom": True,
    },

in .gclient solutions[]

BUG=aomedia:937

Change-Id: I70e4e847a16155080016d090f8bca293e871a225
Reviewed-on: https://chromium-review.googlesource.com/726469
Commit-Queue: Johann Koenig <johannkoenig@google.com>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Brett Wilson <brettw@chromium.org>
Reviewed-by: Tom Finegan <tomfinegan@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Chris Palmer <palmer@chromium.org>
Reviewed-by: Martin Barbella <mbarbella@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512670}

When the URL defocus animation is running and the BottomSheet is open,
setting end margin on the location bar for the URL actions container
results in a blank space. Set the end margin to 0 at the beginning of
on the defocus animation rather than at the end.

BUG=752597

Change-Id: I55c6ec574966ec6b8ce3981d9afa0f7e7d2765d2
Reviewed-on: https://chromium-review.googlesource.com/744968Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512669}

I generally don't do reviews in chrome. There's a bunch of reviewers in
there already.

TBR=tedchoc

Change-Id: Id66fc37fbdf055418f22c90ddc8595bd7ef81093
Reviewed-on: https://chromium-review.googlesource.com/744596Reviewed-by: Bo <boliu@chromium.org>
Commit-Queue: Bo <boliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512668}

When handling a gesture on the compositor thread, we may checkerboard
tiles if no rasterized resource is available for them. This is currently
captured in Compositing.RenderPass.AppendQuadData UMA. This change adds
an equivalent UKM to capture this metric per site.

Since checkerboarding should only occur from input handled on the
compositor thread, the stats are accumulated only when we are actively
running an animation resulting from user input. In order to limit the
frequency with which the metric is recorded, the stats are accumulated
over the gesture duration and emitted when exiting it.

R=ajuma@chromium.org, vmpstr@chromium.org

Bug: 728273
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I1c47215963966f32f3c7d0f69661c87b21558ebb
Reviewed-on: https://chromium-review.googlesource.com/734134Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Reviewed-by: Ali Juma <ajuma@chromium.org>
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Reviewed-by: vmpstr <vmpstr@chromium.org>
Commit-Queue: Khushal <khushalsagar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512667}

See mount failure in e.g. https://ci.chromium.org/buildbot/tryserver.chromium.linux/fuchsia_arm64/13

Bug: 772031
Change-Id: Ic97e190754e1569b14c0d4643b3d6481fe539f5f
Reviewed-on: https://chromium-review.googlesource.com/744991Reviewed-by: Wez <wez@chromium.org>
Commit-Queue: Wez <wez@chromium.org>
Commit-Queue: Scott Graham <scottmg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512666}

Bug: none
Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I8c6cae22e85a75b0f288e356b1df73f254fe3795
Reviewed-on: https://chromium-review.googlesource.com/741926
Commit-Queue: Matt Mueller <mattm@chromium.org>
Reviewed-by: David Benjamin <davidben@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512665}