- 23 Oct, 2019 40 commits
-
-
Stephen McGruer authored
It seems like this is causing consistent failures on Mac10.10 tests; not sure why it was created by the WPT importer in the first place. https://ci.chromium.org/p/chromium/builders/ci/Mac10.10%20Tests/48035 TBR=klausw@chromium.org Bug: None Change-Id: I89cf2d8c0e7ec47f80952310b746c3a904bef863 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876889Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Reviewed-by:
Klaus Weidner <klausw@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#708737}
-
Wei-Yin Chen (陳威尹) authored
PseudoTab represents Tab-like cards in the Grid Tab Switcher. It can be used to represent a card before the Tab objects are constructed. Bug: 1016952 Change-Id: I908dbe70dae6af691ae45ab3342701b4995220bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874708 Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Cr-Commit-Position: refs/heads/master@{#708736}
-
Oriol Brufau authored
Since https://crrev.com/c/1477255, when you type something but the caret has been scrolled out of view, the scroll container only scrolls the minimum amount to make the caret become fully visible. The search field for languages has some line-height, min-height and padding-top values that make it taller than the caret. So there is some space above the caret which is not automatically scrolled into view when typing in the search field. The scroll container is later scrolled to the very top by some script, so it looks like it gets momentarily stuck while scrolling up. This patch fixes that by calling scrollIntoViewIfNeeded() on the search field when something is typed in it, so the scroll container is scrolled to the very top. Fixed: 1013556 Change-Id: I5524ad85e14d5d38a1aa31eb3ae061051ccc8dbb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873758 Commit-Queue: Oriol Brufau <obrufau@igalia.com> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#708735}
-
Garrett Beaty authored
Change-Id: Ica03d95af30be8221b67648578460ba2c7ce4a64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869682 Auto-Submit: Garrett Beaty <gbeaty@chromium.org> Reviewed-by:
Aaron Gable <agable@chromium.org> Commit-Queue: Garrett Beaty <gbeaty@chromium.org> Cr-Commit-Position: refs/heads/master@{#708734}
-
Wez authored
- Remove thakis@ and scottmg@, who should be OWNERS-of-last-resort, since they are already //build/OWNERS. - Remove jamesr@, who works on Fuchsia, not Chromium. - Correct the COMPONENT to Fuchsia. Change-Id: I25d41f0454522bf9d7fe0e025c623aed4b59d0a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876869 Auto-Submit: Wez <wez@chromium.org> Reviewed-by:
Scott Graham <scottmg@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#708733}
-
Ian Struiksma authored
Some issue is happening on the bot for this site that I haven't been able to reproduce locally, but disabling for now as I figure out what's happening. Bug: 1017266 Change-Id: Ia6387ca4bd03bd866040d96ff24e2d35075da660 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876728 Auto-Submit: Ian Struiksma <ianstruiksma@google.com> Commit-Queue: Caleb Rouleau <crouleau@chromium.org> Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#708732}
-
Lucas Furukawa Gadani authored
Bug: 984550 Change-Id: I2bf27ce77287394c782692483117ee105e214563 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1875385Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Lucas Gadani <lfg@chromium.org> Cr-Commit-Position: refs/heads/master@{#708731}
-
liberato@chromium.org authored
Change-Id: I6a15ad00706fe31ffb8484ff5a65607b7e4d55ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874723Reviewed-by:
Ted Meyer <tmathmeyer@chromium.org> Commit-Queue: Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#708730}
-
Dominic Mazzoni authored
This is a small fix for a subtle bug. The way touch exploration works on Android is complicated: * When the user taps or drags their finger, our View gets a hover event. * Accessibility code sends a hit test action to the renderer process * The renderer process fires a HOVER accessibility event on the accessibility node at that coordinate * WebContentsAccessibilityImpl.handleHover is called with that node. We fire an Android TYPE_VIEW_HOVER_ENTER event on that node and a TYPE_VIEW_HOVER_EXIT event on the previous node. * Finally, TalkBack sets accessibility focus to that node. As the user continues to drag their finger, we get lots of hover events on the view, but often the finger is over the same node. To prevent repeatedly firing TYPE_VIEW_HOVER_ENTER on the same node, we keep track of the last hover id in mLastHoverId. The problem with this was that if you moved accessibility focus somewhere else - like tapping outside of the web view, or swiping to a different element, we weren't clearing mLastHoverId, so if you subsequently tapped on the same element, we'd suppress it (incorrectly). The fix is just to clear mLastHoverId and fire the TYPE_VIEW_HOVER_EXIT whenever we're told to clear accessibility focus from the last node that was hovered. Then if the user subsequently taps on that node we'll send the right event and let them focus it again. Bug: 769736 Change-Id: I68f4c522bd6fe76657a5624abe291a45e7aafe58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874502Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#708729}
-
Oksana Zhuravlova authored
Bug: 1010364 Change-Id: I3e96e02bc1067afd3d33ab5873cf6ec0a2f17756 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864468 Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#708728}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/a1ed9d1a8492..08af1c80188f git log a1ed9d1a8492..08af1c80188f --date=short --no-merges --format='%ad %ae %s' 2019-10-23 tobine@google.com Vulkan:Store full 64bit handle in GarbageObject Created with: gclient setdep -r src/third_party/angle@08af1c80188f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jonahr@google.com Bug: None Change-Id: I7fce211f0d2e8390f71d9242363e82354886a717 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1875280Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#708727}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/e792f87ded42..794ed818b893 git log e792f87ded42..794ed818b893 --date=short --no-merges --format='%ad %ae %s' 2019-10-23 nigi@chromium.org Add a fuzzer for the public methods of CFX_ScanlineCompositor. Created with: gclient setdep -r src/third_party/pdfium@794ed818b893 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=pdfium-deps-rolls@chromium.org Bug: None Change-Id: I3be5b2eb3ec448c3cffb989509c3fb3d17161a2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876834Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#708726}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/1f6c8c4d5495..402fbcca936b git log 1f6c8c4d5495..402fbcca936b --date=short --no-merges --format='%ad %ae %s' 2019-10-23 shaobo.yan@intel.com Enable UpdateDynamicOffsetsMultipleTimesComputePipeline case Created with: gclient setdep -r src/third_party/dawn@402fbcca936b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel TBR=cwallez@google.com Bug: None Change-Id: I1fb02dc8daccad2ed3eb0d80f8a314a1f90d08f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876450Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#708725}
-
Anton Bikineev authored
This patch moves incremental marking steps in Oilpan from safe points to V8 task runner thereby letting scheduler know about GC existence. This is expected to regress atomic-pause duration, since incremental steps are not as prioritized as they used to be, but at the same time latency should improve. Bug: 1002998 Change-Id: I1f0fa3468160a3505fcf71f85655c0fd41dc1c67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1607642 Commit-Queue: Anton Bikineev <bikineev@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#708724}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/1342a6ae6285..9fb9a722fb28 git log 1342a6ae6285..9fb9a722fb28 --date=short --no-merges --format='%ad %ae %s' 2019-10-23 treehugger-gerrit@google.com Merge "perfetto: change gen_andorid_bp to use static libs for host tools" 2019-10-23 lalitm@google.com Merge "Revert "traceconv: ignore userspace events for traces with Android data"" 2019-10-23 lalitm@google.com Merge "traceconv: ignore userspace events for traces with Android data" 2019-10-23 treehugger-gerrit@google.com Merge "processor: Extract graphics event parsing into an importer module" 2019-10-23 eseckler@google.com Merge "processor: Refactor ExportJson() to rely on tracks rather than reftypes" 2019-10-23 lalitm@google.com Merge "trace_processor: add option to force a full sort of traces" Created with: gclient setdep -r src/third_party/perfetto@9fb9a722fb28 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: None Change-Id: I94f4a228d4dde45953d0f7a0eaf761bd4a1b39ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876075Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#708723}
-
Peter Kasting authored
Bug: 82078 Change-Id: I5bec95398951e1e1e453b7ab3114e1fcff106198 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1875269 Commit-Queue: Yuwei Huang <yuweih@chromium.org> Reviewed-by:
Yuwei Huang <yuweih@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#708722}
-
David Tseng authored
Bug: 865575 Reland of https://chromium-review.googlesource.com/c/chromium/src/+/1852414 This change differs in: - only show the viewport widget once all associated state is ready to respond to events. This fixes a potential crash. - only observe focus events on controls. Change-Id: I1addbfb4a9d89e738ca6992c3ccd1f88e9546104 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876688 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#708721}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/61a1e81e89bd..577977ad233c git log 61a1e81e89bd..577977ad233c --date=short --no-merges --format='%ad %ae %s' 2019-10-23 bsheedy@chromium.org Add localhost warning comment to Telemetry 2019-10-23 khokhlov@google.com Revert "[Telemetry] New intermediate file format" 2019-10-23 khokhlov@google.com [Telemetry] New intermediate file format Created with: gclient setdep -r src/third_party/catapult@577977ad233c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC sadrul@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=sadrul@google.com Bug: chromium:1005971,chromium:981349,chromium:981349 Change-Id: Iefd9ddef7b2cbd3e8a470c4252c176377cd5cbf7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876074Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#708720}
-
Mustaq Ahmed authored
With UAv2 shipped, UGIs are redundant except for a dependency from extension messaging. Since that dependency can't be removed right away, we will trim down UGI to a minimal class now to prevent new usage as much as possible. This CL takes care of the timeout policy plus all orphan entries in UGI. Change-Id: Ia1d44ae7457be22adaaab5aa569901560b0bd2e5 Bug: 959850 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869391Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Commit-Queue: Mustaq Ahmed <mustaq@chromium.org> Cr-Commit-Position: refs/heads/master@{#708719}
-
Nick Harper authored
Change-Id: Ia9c83a2c6930eb58c900acb90e6a305b4a948089 Bug: 1016701 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873987Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Nick Harper <nharper@chromium.org> Cr-Commit-Position: refs/heads/master@{#708718}
-
Will Harris authored
On macOS, it's possible if the keychain is locked for the key to be empty. Platforms that expect a key to never be empty already DCHECK inside os_crypt. This restores previous functionality in 113d3089 and prior. BUG=1016816 Change-Id: Ie407bdb3804804334c28bbebb3775767e674f49a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876734Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Eric Roman <eroman@chromium.org> Commit-Queue: Will Harris <wfh@chromium.org> Cr-Commit-Position: refs/heads/master@{#708717}
-
Johannes Kron authored
Add histograms of decode time per frame for VP9/H264 and 4k/HD resolution. There's one histogram per codec, resolution, and decoder (Hw or Sw). The code for updating the histograms was landed in the following WebRTC CL: https://webrtc.googlesource.com/src.git/+/e76b3abf610bc4acd386dbc5de9aff00a64823a3 which was rolled into Chrome here: https://chromium.googlesource.com/chromium/src.git/+/e5b31d3d2a5d6ffce82dfaec2aab98632283bd21 Bug: chromium:1007526 Change-Id: I83c2f4d005579e77f96fd9c5e71a6ff36b2bdf79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876408Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Johannes Kron <kron@chromium.org> Cr-Commit-Position: refs/heads/master@{#708716}
-
Patrick Monette authored
Shared workers are currently the only type of worker where a frame can be added as a client multiple times to the same worker. Since the only SharedWorkerService::Observer doesn't care about the exact number of times a frame connects to a single worker, the service now collapse duplicate notifications. Bug: 1016061 Change-Id: I393cf51dd0de86499350932dc34cb3c5e5e1ebfb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872632Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Patrick Monette <pmonette@chromium.org> Cr-Commit-Position: refs/heads/master@{#708715}
-
Garrett Beaty authored
Bug: 1011908 Change-Id: Ic7f4fc26d75811f04c9f988866bb479a40e0d0c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869713 Auto-Submit: Garrett Beaty <gbeaty@chromium.org> Reviewed-by:
Aaron Gable <agable@chromium.org> Commit-Queue: Garrett Beaty <gbeaty@chromium.org> Cr-Commit-Position: refs/heads/master@{#708714}
-
Stephen McGruer authored
TBR=benwells@chromium.org Bug: 1017305 Change-Id: Ia6d3f44d2b9fbe139192e8057167063aefcee7f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1875386Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#708713}
-
Sean Topping authored
Adds MediaControlUi, which can be used to enable a simple touch UI for media apps without a touch-supported UI. Some other changes are included in this CL to simplify internal code as a result of this change: * Remove CastWindowManager from CastContentWindow public API. * Rename CastWindowManager::SetWindowId() to SetZOrder(). * Move CastContentWindow from "shell" namespace to "chromecast". Merge-With: eureka-internal/316519 Bug: internal b/137663169 Test: CQ Change-Id: I2d78e73162bb30a652f591b5def651468e44eaf6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1817146Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Simeon Anfinrud <sanfin@chromium.org> Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Commit-Queue: Sean Topping <seantopping@chromium.org> Cr-Commit-Position: refs/heads/master@{#708712}
-
Anastasiia Nikolaienko authored
Change route for Sync subpage in focus configuration map for people page. onIronSelect_ in settings_animated_pages.js throws an assertion error for '#sync-status .subpage-arrow'. It looks like .subpage-arrow element was removed in https://crrev.com/c/1742350. Bug: 1014317 Change-Id: I7ca645cfae432305616fcf7e2415cebddd4c103b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1875101Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Anastasiia Nikolaienko <anastasiian@chromium.org> Cr-Commit-Position: refs/heads/master@{#708711}
-
Rayan Kanso authored
Pipes whether addresses are required to mojo, and handles the expected address return values. TBR=mkwst@chromium.org Bug: 1016870 Change-Id: I4d77de31736195c01754369e71f78d6825a1f811 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874206 Commit-Queue: Rayan Kanso <rayankans@chromium.org> Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#708710}
-
Stephen McGruer authored
TBR=eyaich@chromium.org Bug: 1017290 Change-Id: Ifc2e4fcbdc9a184d71ad8749c0a0f40ff95b241b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876733Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#708709}
-
Darin Fisher authored
This renamed ContentSettingsRenderer to ContentSettingsAgent and the corresponding class ContentSettingsObserver to ContentSettingsAgentImpl. This class represents the agent of the content settings system that runs in the renderer process. It is responsible for answering some of the blink::WebContentSettingsClient methods directly and for others it needs to delegate to the browser process. It does so through a new interface named ContentSettingsManager. This provides async and sync methods to check for permission to access different storage types. A big change here is that instead of answering these questions about storage access on the IO thread, now the code is answering those on the UI thread. The old code was constrained by the NPAPI plug-in system that forced synchronous IPCs from the renderer process to be handled not on the UI thread. Now we no longer have that constraint, and it is far simpler to just handle the IPCs directly on the UI thread. There is potential for some added delay to storage access if the browser's UI thread happens to be busy, but this should be a minor issue compared to the overall cost of accessing the storage systems. Change-Id: I97513988c900efe63f4feb02894d7a14e6fec8c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864823 Commit-Queue: Darin Fisher <darin@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#708708}
-
Johannes Henkel authored
This makes the code shorter, there is less shuffling things into and out of fields. Add comment about why we don't queue serialized messages. Change-Id: Icbb2e6cd3eb63290d845a817f06bc4bd6a5a59a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873203 Commit-Queue: Johannes Henkel <johannes@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#708707}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/21bfa401ddea..6adb0a26846c git log 21bfa401ddea..6adb0a26846c --date=short --no-merges --format='%ad %ae %s' 2019-10-23 mbonadei@webrtc.org Do not compile webrtc_lib_link_test if is_asan=true. Created with: gclient setdep -r src/third_party/webrtc@6adb0a26846c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: None Change-Id: I5ce2f02f580dae2e6d642508b942d8b703ad1d3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876710Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#708706}
-
Kelvin Jiang authored
This CL adds a MatchedRule (which consists of a rule ID and a source type) to RequestAction, which is needed to support the getRulesMatched and onRuleMatchedDebug functions for the DNR feedback API. Bug: 967942 Change-Id: Ie10bc5b0a84963a909bb72f3bd51b355fd9d530c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869989 Commit-Queue: Kelvin Jiang <kelvinjiang@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#708705}
-
Wei-Yin Chen (陳威尹) authored
TabAttributeCache stores URL, title, and root ID for tabs so that they are available before native initialization. Bug: 1016952 Change-Id: I45365dff66c89d859562c116e61a0a9ea75f2bd3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874707Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#708704}
-
Fan Yang authored
https://quiche.googlesource.com/quiche.git/+log/b5a8b9ebfa6e..4cc508c720ac $ git log b5a8b9ebf..4cc508c72 --date=short --no-merges --format='%ad %ae %s' 2019-10-22 fayang Fix build error in chromium by adding QUIC_EXPORT. 2019-10-22 renjietang Clean up code on SETTINGS. 2019-10-22 vasilvv Split QuicEndpoint into QuicEndpoint and QuicEndpointBase. 2019-10-22 renjietang Consider pending streams in ShouldKeepConnectionAlive. 2019-10-22 wub Internal QUICHE change 2019-10-22 renjietang Do not accept fin that would decrease the stream's final offset. 2019-10-22 zhongyi Add get method for initial_retransmittable_on_wire_timeout, which is used by chromium only and accidentally removed in cl/275943283. 2019-10-22 fayang gfe-relnote: Remove save_retransmittable_frames from QuicPacketCreator::AddFrame. No functional change expected, not protected. 2019-10-22 renjietang Clean up QuicPacketCreatorTest. 2019-10-22 fayang gfe-relnote: In QUIC, clean up !session_decides_what_to_write code path. 2019-10-21 quiche-dev Internal QUICHE change 2019-10-21 renjietang Fix buffer overflow issue by changing how test string is created. 2019-10-21 zhongyi When there is no retransmittable packet on the wire and there are open streams, the connection may send retransmittable PINGs to detect path degrading with aggressive timeout. 2019-10-21 renjietang gfe-relnote: deprecate gfe2_reloadable_flag_quic_rst_if_stream_frame_beyond_close_offset. 2019-10-21 renjietang gfe-relnote: deprecate gfe2_reloadable_flag_quic_aggressive_connection_aliveness 2019-10-21 renjietang gfe-relnote: deprecate gfe2_reloadable_flag_quic_do_not_send_settings. 2019-10-21 fayang gfe-relnote: In QUIC, populate the actual length of full padding frame in nonretransmittable_frames (of SerializedPacket). Protected by existing gfe2_reloadable_flag_quic_populate_nonretransmittable_frames. 2019-10-21 wub Internal QUICHE change 2019-10-21 fayang gfe-relnote: In QUIC, add a utility function CopySerializedPacket. Not used yet, not protected. 2019-10-21 fayang gfe-relnote: In QUIC, populate nonretransmittable_frames in SerializedPacket. Protected by gfe2_reloadable_flag_quic_populate_nonretransmittable_frames. 2019-10-18 vasilvv Implement QuicTransportStream, a stream that can be only accessed after client indication is received. 2019-10-18 wub gfe-relnote: (n/a) In quic_framer_process_data_packet_fuzzer, set framer's decrypter for INITIAL encryption level. Test only. 2019-10-18 renjietang Remove redundant calls to QuicSession::NeuterUnencryptedData(). 2019-10-18 dschinazi Refactor quic_client_interop to avoid dropping letters 2019-10-18 renjietang Coalesce adjacent stream frames. 2019-10-18 quiche-dev Add a new Tunnel Health Checker. The health checker is configured to run about every 5th ICMP probe and checks the packet exchanger's counters in both directions. If *no* packets have passed in one direction, this will tear down the tunnel, leaving it to be restarted on the next epoll cycle. 2019-10-18 zhongyi gfe-relnote: n/a, test change only. 2019-10-18 fayang Add two copy utility function CopyQuicFrame and CopyQuicFrames. 2019-10-18 fayang gfe-relnote: Add a bool to QuicSentPacketManager, indicating whether a forward secure packet gets acked. No functional change expected. Not protected. 2019-10-18 wub gfe-relnote: (n/a) Fix quic_framer_process_data_packet_fuzzer to not to use version 0. Test only. Created with: roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src Change-Id: Ie3d7ff02abbfda44dcb0611afe967f1c43422026 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872655 Commit-Queue: Fan Yang <fayang@chromium.org> Commit-Queue: Zhongyi Shi <zhongyi@chromium.org> Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#708703}
-
Huanzhong Huang authored
To address https://bugs.chromium.org/p/chromium/issues/detail?id=1005788#c41; allow screen reader to read out a text associated to cookie controls toggle. Bug: 1017143 Change-Id: I9031d3f82bcda44b0e8b6fd59c8e9b6a43dfc930 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876387Reviewed-by:
Dan Beam <dbeam@chromium.org> Commit-Queue: Huanzhong Huang <huanzhong@chromium.org> Cr-Commit-Position: refs/heads/master@{#708702}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/32803ff74448..e9462dd2dac4 git log 32803ff74448..e9462dd2dac4 --date=short --no-merges --format='%ad %ae %s' 2019-10-23 robertphillips@google.com Rename *worstCase* to backingStore* in GrSurfaceProxy 2019-10-23 fmalita@chromium.org GPU support for SkColorFilters::HSLAMatrix Created with: gclient setdep -r src/third_party/skia@e9462dd2dac4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC michaelludwig@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=michaelludwig@google.com Bug: None Change-Id: I689f298d6568ef4ecb3d6d39f7f5dbfc46ba9365 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876449Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#708701}
-
Dale Curtis authored
These are no longer needed and some of them have expired. BUG=1000058 R=tguilbert Change-Id: Icb64d7c76610d888c4083c72a6c0633a057d0fb7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874709Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#708700}
-
Elly Fong-Jones authored
Migrate to the new DialogDelegate::set_button_label() pattern. Also, since the string is static, use it directly from the view. Bug: 1011446 Change-Id: I067d07b75d7d02c628f009328e36afdfd1d1f7ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876467Reviewed-by:
Siyu An <siyua@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#708699}
-
Lily Chen authored
Bug: None Change-Id: I62d87f2fcb30322e0f311de7dfdf1d0992d044e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876793 Commit-Queue: Lily Chen <chlily@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#708698}
-