- 23 Jul, 2020 40 commits
-
-
Internal Frameworks Autoroller authored
TBR=bling-team@google.com Change-Id: I21d8638cbff328affadcd7cdc4780b6f614304cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315805Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#791185}
-
Andreas Haas authored
In the constructor of ArrayBufferContents, we did not create a V8::BackingStore if an byte array was provided, i.e. byte == nullptr. Without BackingStore, however, it was not possible to create a V8::ArrayBuffer for this ArrayBufferContents, as V8 expected that a BackingStore always exists. With this CL we always create a BackingStore, even though the data is nullptr. R=haraken@chromium.org, ulan@chromium.org Bug: chromium:1104580 Change-Id: I4a05de503f5916a9491dbe4595f699c0e834bb10 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302694Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#791184}
-
Victor Hugo Vianna Silva authored
Although new users can't enter this state, a number of users still remain on it. "legacy" probably reflects better this scenario. Bug: None Change-Id: I1e61f6ed601bc6ea8bb51490ab5ebc00d4dd7efc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2312803Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Victor Vianna <victorvianna@google.com> Cr-Commit-Position: refs/heads/master@{#791183}
-
Jinsuk Kim authored
This CL tentatively reverts following 6 CL's as a speculative fix for an ANR issue around ProfileDestroyer: https://crrev.com/c/2171463 "Clean up ProfileDestroyer." https://crrev.com/c/2134019 "Add tracing to make it easier to debug shutdown behavior." https://crrev.com/c/2113391 "Android: Handle multiple ProfileDestroyers correctly" https://crrev.com/c/2032385 "Fix a crash in ProfileDestroyer due to delayed RPH destruction" https://crrev.com/c/2022791 Revert "Only CHECK for RPHs that outlive an OTR profile in release" https://crrev.com/c/1971031 "Android: Fix a bug when closing all incognito tabs for preview tab" The first CL(1071031) landed to fix Issue 1029677, and subsequent CL's handled the remaining/new issues reported after that. The ANR bug (1095078/1095548) is suspected to have to do with ProfileDestroyer destruction of incognito profile. Not having found good clues, this is trying to see if the series of these changes in the class caused it. With this, the state of ProfileDestroyer is restored back to M80 which had no issues. This is NOT a permanent solution for the problem. Will reland the above CL's if they are proven innocent, or find a right fix if they indeed are the culprit. TBR=msarda@chromium.org Bug: 1029677, 1040839, 1095078, 1095548 Change-Id: I761809a90cd4f3a866ae7754da4dab34640dcb3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308616Reviewed-by:
Jinsuk Kim <jinsukkim@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#791182}
-
evliu authored
This is a reland of b01fb516 Reason for revert: Did not roll out internal DEPS (https://chrome-internal-review.googlesource.com/c/chrome/src-internal/+/3179564) Original change's description: > Add SODA API Key > > This CL adds an API key for the Speech On-Device API (SODA). Usage of > the API key is outlined here: go/securing-soda-on-chrome. > > Bug: 1107615 > Change-Id: Ic92418407e17a88426559251e77797bd0b34818b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2309133 > Reviewed-by: David Roger <droger@chromium.org> > Commit-Queue: Evan Liu <evliu@google.com> > Cr-Commit-Position: refs/heads/master@{#790550} Bug: 1107615 Change-Id: Id15cbafdc68bf75a06d21c8b70bbfeb1a63db83c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315237Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#791181}
-
Anders Hartvoll Ruud authored
They are no longer used by anything. Change-Id: Ibdfc66e8bc30841fc01292ca5961ecf522588c84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2310496 Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#791180}
-
dizg authored
Bug: 1105865 Change-Id: I8d2acf70dc1e24112961f4bc63595aaf6c326fa4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2312798Reviewed-by:
Monica Basta <msalama@chromium.org> Reviewed-by:
-
Simon Zünd authored
As per guidance of base/containers/README.md. R=sigurds@chromium.org Change-Id: I2e078e0199cdebd98ef442f6e3bb2974f1666041 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315017 Auto-Submit: Simon Zünd <szuend@chromium.org> Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Commit-Queue: Simon Zünd <szuend@chromium.org> Cr-Commit-Position: refs/heads/master@{#791178}
-
Maksim Ivanov authored
Fix the flakiness in the VpnProviderApiTest.DestroyConnectedConfig test caused by the C++ side missing the JS test success notification. In a detail, the test was first deleting the VPN config - which triggers the "disconnected" vpnProvider.onPlatformMessage event and the test's test.succeed() call - and then creating a ResultCatcher afterwards. With unlucky timing, all of the steps, including the test.succeed() event arrival to the browser process, were happening before the ResultCatcher was constructed. The fix is therefore to move the construction of the ResultCatcher to happen earlier, before deleting the VPN config. Bug: 1108527 Test: run "browser_process --gtest_filter=VpnProviderApiTest.DestroyConnectedConfig" under stress a thousand times Change-Id: Ib26da605dc379240b8925f275bd22d96aadd99e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315337 Auto-Submit: Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Andreea-Elena Costinas <acostinas@google.com> Reviewed-by:
Andreea-Elena Costinas <acostinas@google.com> Cr-Commit-Position: refs/heads/master@{#791177}
-
Viktor Semeniuk authored
This change adds show/hide button near password field, which reveals or hides password value. Bug: 1075494 Change-Id: I336dbaa4f44d0136c7331fde5133a293c76fe5c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302051 Commit-Queue: Viktor Semeniuk <vsemeniuk@google.com> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#791176}
-
Kim-Anh Tran authored
Bug: chromium:1105172 Change-Id: Ibec4c558a8d0f56c9275d8f0fc9aa1bb92ad6000 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315856 Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/master@{#791175}
-
Anders Hartvoll Ruud authored
Instead of relying on calls to UaRules/UserRules/AuthorRules/AllRules, just check the origin at each vector index directly. This prepares for the removal of the rule ranges in a subsequent CL. Change-Id: I86f57ca1c2f04619db99f7cd1c62345b8f0f262a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2310675 Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by:
-
Clemens Arbesser authored
Since it seems that we continue having problems with inflating vector graphics, I'm adding these two icons to the enum as a stop-gap to avoid blocking the PWM experience. Bug: b/145043394 Change-Id: I848ce65807d244fe49102a5ed1fef32aec474a83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315138 Commit-Queue: Clemens Arbesser <arbesser@google.com> Commit-Queue: Sandro Maggi <sandromaggi@google.com> Auto-Submit: Clemens Arbesser <arbesser@google.com> Reviewed-by:
Sandro Maggi <sandromaggi@google.com> Cr-Commit-Position: refs/heads/master@{#791173}
-
Mugdha Lakhani authored
This is so WebLayer can use it to support NoStatePrefetch. Bug: 1096088 Change-Id: Ide047108b783edf2001a17811f76f3a6bb476a72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2310329 Commit-Queue: Mugdha Lakhani <nator@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#791172}
-
Arthur Sonzogni authored
This reverts commit 183d178c. Reason for revert: Test aren't flaky anymore on trunk. They are flaky only on the m-84 branch. Original change's description: >
🤠 Disabling flaky MediaCanPlayTypeTest for Android > > MediaCanPlayTypeTest.CodecSupportTest_HLS > MediaCanPlayTypeTest.CodecSupportTest_mp3 > MediaCanPlayTypeTest.CodecSupportTest_mp4 > > TBR=dalecurtis > > Bug: 1090770 > Change-Id: I484d9840b343386f696d563aab3182219a69822f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2310536 > Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org> > Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> > Cr-Commit-Position: refs/heads/master@{#790767} TBR=dalecurtis@chromium.org,arthursonzogni@chromium.org Change-Id: Ic7f132acd8d636875f935a874d03d1f36c7de1ed No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1090770 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315677Reviewed-by:Arthur Sonzogni <arthursonzogni@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#791171}
-
Irina Fedorova authored
In the previous version, this function allowed changing the username and optionally changing the password. In the new version, this function allows to change only the password and returns true if the password was successfully changed. Bug: 377410 Change-Id: I0b555b404b781d8fa35c9eda1aff442141ab9219 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302638 Commit-Queue: Irina Fedorova <irfedorova@google.com> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#791170}
-
Idries Hamadi authored
Right now the definition of 'web' content is that the scheme is HTTP or HTTPS. Bug: 1083005 Change-Id: I32224eaf8a75668d11a7bdf31b0f1d239b3ff3f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2277811 Auto-Submit: Idries Hamadi <idries@google.com> Commit-Queue: Idries Hamadi <idries@google.com> Reviewed-by:
Tobias Sargeant <tobiasjs@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#791169}
-
Omid Tourzan authored
The change introduces 2 methods to set new primary text and secondary. Primary text will contain source and destination and secondary text will be the remaining time message. Remaining time 0 means no progress and set secondary text with pending. Time format will be in hour and minute unit, no second, day or etc. Bug: 953308 Change-Id: I163eb42af36ab8778eac6bada054aa0f8c281fc6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2307969 Commit-Queue: Omid Tourzan <oto@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Reviewed-by:
Alex Danilo <adanilo@chromium.org> Cr-Commit-Position: refs/heads/master@{#791168}
-
Anders Hartvoll Ruud authored
This is effectively what we're doing already, since the size of the author_range_ends_ vector just increased by one (and the size of that vector never decreases). Setting the current_tree_order_ when finishing user rules is not necessary. I don't know why we did this. Possibly it's a remnant of a previous solution. Overall, what matters is that current_tree_order_ is monotonically increasing for each call to FinishAddingAuthorRulesForTreeScope. This prepares the ua/user/author ranges for removal in a subsequent CL. Change-Id: I99947e5bfdf727ba772d296ecab65b424625dd91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2310495 Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by:
-
Jao-ke Chin-Lee authored
BUG=1062407 Change-Id: I069a65c1a1dfc09775cc1b078a3da1e20bc5f47d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2296870 Commit-Queue: Jao-ke Chin-Lee <jchinlee@chromium.org> Reviewed-by:
Andres Calderon Jaramillo <andrescj@chromium.org> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#791166}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/29cc4f31047a..cb2f73564cb5 2020-07-23 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools Chromium DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: If8d328510e5d738d586c6e86e86d82176cf54d20 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315289Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#791165}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1595461632-4ccfdc8488548d109e77211e6ed2d2e949d446f2.profdata to chrome-mac-master-1595483644-6e8695d24392ae339c7de29c47d12948bf6cd425.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: I9c33323ca297af804ccd4988061617ce955d1382 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315291Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1595397501-9bcbb05b12c8b76c3ee561633b2647f61403910d.profdata to chrome-win64-master-1595437495-2d3f811bb66fa71af5c868be4b1e4126108bec15.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win64-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: Id98e1808f438b83bc045f19761d616b8bd991784 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315186Reviewed-by:
-
Anders Hartvoll Ruud authored
Bug: 936084 Change-Id: I5a7c92c566770ef310c5ee863b42a77bb8448c01 Fixed: 1108133 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2310538Reviewed-by:
-
Yue Zhang authored
Even though TabGridDialog is available for low end devices with TabGroup M5, we don't have such coverage in TabGridDialogTest yet. This CL disables the tests for low end devices to keep test-go-phone bot green. Also, this CL enables the tests that are disabled due to failure on test-go-phone bot. Bug: 1108547 Change-Id: I250b1d1a5add21039b4c0d942e3b29d5d1b72724 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315442 Auto-Submit: Yue Zhang <yuezhanggg@chromium.org> Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#791161}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/abd75556630d..b8fe9093351f 2020-07-23 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update Go Deps 2020-07-23 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from f272427bda39 to 6a8a74986c35 (3 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC robertphillips@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: robertphillips@google.com Change-Id: I7d0b49c062455a861aeeb5fc1d5933d6148cdd2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315288Reviewed-by:
-
Olivier Robin authored
This does not work well with multiwindow. Bug: 1106759 Change-Id: Idc2140577d9616babc82b0100ae544641a241ec6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2309701 Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
-
Glen Robertson authored
Change-Id: Ia39504da8cfc3bd4cb2ac64db372a1487bbfc097 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315659Reviewed-by:
Glen Robertson <glenrob@chromium.org> Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Auto-Submit: Glen Robertson <glenrob@chromium.org> Commit-Queue: Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#791158}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/22d918bf..9c9ffbfc Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ie2c0709dadacaa8232ae0cb6203a461daa32584c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315301Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#791157}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d115cfdcf564..7c633d9713fc If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC meredithl@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1105096,chromium:912681 Tbr: meredithl@google.com Change-Id: I5a38053f6ef89cbb211520d3816d498cae85fa67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315283Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#791156}
-
Kyle Williams authored
Create GN flags to ensure target code compiles only on the cfm platform Create Feature flags to support experiments specifically for enabled chromium support for mojo based services on the platform layer of cfm provisioned devices. Adds support for hotline dbus and mojom BUG=chromium:1105567 TEST='Set feature and gn flag to true/false ran respective dbus/services tests' Change-Id: Ica004eddd2f59398dcacc4e0d35d1b536705fa2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298486 Commit-Queue: Kyle Williams <kdgwill@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#791155}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/d318489a1566..abd75556630d 2020-07-23 skia-autoroll@skia-public.iam.gserviceaccount.com Roll dawn from c4cebc7efae1 to 9061d5d154bc (3 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC robertphillips@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: robertphillips@google.com Change-Id: I844fefdca714f7d1cfb40c5c5cba3f535f9211d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315285Reviewed-by:
-
Meredith Lane authored
This change removes the label for each theme option, and instead uses aria-label option element itself. As the label is not visually rendered on the page, it is safe to be removed. This also fixes the issue of the label being announced separately to the control itself when navigating incrementally with VoiceOver. Note: This change has no visual change, only affects screenreader announcements. AX-Relnotes:N/A Fixed: 1087934 Change-Id: Ia7d063a03158ad8ca2f51a84b9535c427f7868cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2306138 Commit-Queue: Meredith Lane <meredithl@chromium.org> Reviewed-by:
-
rbpotter authored
Bug: 1105701 Change-Id: I426c7fb28e5bf599879668ecb8cbf5865769bbfa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2309453 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#791152}
-
Haiyang Pan authored
And disable the failed tests or test suites Bug: 1095778, 1108055, 1108121, 1108124 Change-Id: Ie75c783b34765131bcd739ea12da96764ba14825 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252599Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: Haiyang Pan <hypan@google.com> Cr-Commit-Position: refs/heads/master@{#791151}
-
Lei Zhang authored
Identify RenderFrameHosts using ID pairs instead of raw pointers, to make it possible to check if the IDs are still valid when used later. Bug: 1106342 Change-Id: I8ada468136a61eb837ad7d8b092915d17e958e45 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2305191Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Jeongeun Kim <je_julie.kim@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#791150}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/ca8f856ac1ab..f359cb667cb9 2020-07-23 jiajia.qin@intel.com Reland: Refactor DisplayGbm::generateConfigs 2020-07-23 jiajia.qin@intel.com Implement DRM_FORMAT to GL format conversion If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: chromium:1096442,chromium:1105208 Tbr: timvp@google.com Change-Id: Idc9df4a6e2fbb136247360bd3302754ae9776775 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315281Reviewed-by:
-
Kyle Williams authored
Creates a helper function to determine if the value passed by extensions::Extension::id(), which returns extensions::ExtensionsID, is a valid app id for a Packaged Application supported by the Chromebox For Meeting platform. BUG=chromium:1105567 TEST='autoninja -C out/Default chromeos:chromeos_unittests && ./out/Default/chromeos_unittests --dbus-stub --single-process-tests --gtest_filter=CfmAppIdUtilTest.*' Change-Id: I84e85563119afcb564407f88c214aa649ad79626 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304334 Commit-Queue: Kyle Williams <kdgwill@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 75d163e9. With Chromium commits locally applied on WPT: a02f2df5 "Implement Storage Access commands for TestDriver" 9c2ef271 "[COOP report] Add support for report-only" 48a79144 "[NativeFS] Keep directory iterator alive while it has pending promises." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: rego@igalia.com: external/wpt/css/css-grid NOAUTOREVERT=true TBR=robertma@google.com No-Export: true Change-Id: Idae60f308ac32f1a1fcbac995af9584037672c32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315299Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#791147}
-
Xianzhu Wang authored
Now we are calculating visual rects for all paintings, so no longer need FragmentData::VisualRect(). Rename LayoutObject::NeedsPaintOffsetAndVisualRectUpdate() to ShouldCheckGeometryForPaintInvalidation() which is to require paint property tree builder context for paint invalidation. Bug: 1104064 Change-Id: Ieb68d5cc8696f7b8046ae27c3e3d78d2b94b755f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2309661Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#791146}
-
