- 13 Oct, 2020 40 commits
-
-
chromium-internal-autoroll authored
Release_Notes: http://go/help_app-x20/relnotes/Main/help_app_nightly_202010130700_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/help_app/app/+/T-N5zwsSNhguTsU3uUhXyI74IImSdHGJ-z8uc9QLdUsC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/help-app-chromium-autoroll Please CC help-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: help-app@grotations.appspotmail.com Change-Id: I51048d21e10493a45147ece8a6ad51550a1b0ec7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466927Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#816608}
-
Muyao Xu authored
Bug: b/165366974, 1117673 Change-Id: Ieec1543d9fb6cd5a6e77d5790ee4c2138174b305 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466388Reviewed-by:
Takumi Fujimoto <takumif@chromium.org> Commit-Queue: Muyao Xu <muyaoxu@google.com> Cr-Commit-Position: refs/heads/master@{#816607}
-
Kyle Horimoto authored
These classes were in //chrome, making them inaccessible to tests that are not also in //chrome due to dependency issues. This CL moves them to //chromeos/services/nearby, alongside their associated .mojom definitions. These mocks are used in a follow-up CL to implement tests. This CL also initializes a SharedRemote associated with these classes and a getter to retrieve a reference to the SharedRemote. Bug: 1130069 Change-Id: I1bb87403a64a17c5b6f4da1b9f9daaf3ce414d64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2464844Reviewed-by:
James Vecore <vecore@google.com> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#816606}
-
chromium-autoroll authored
Roll ChromeOS Orderfiles from 87-4265.0-1601890590-benchmark-87.0.4280.16-r1 to 87-4277.0-1602498224-benchmark-87.0.4280.18-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-orderfile-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: Id9b4cc97108e0099d712b1243560ae4cb70538d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2468196Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#816605}
-
chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/afdo-chromium-autoroll Please CC gbiv@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: gbiv@chromium.org Change-Id: Iaa9c8d0ab9bbbc7ccb61248483c1bd907771fe4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2468141Reviewed-by:
-
Benoit Lize authored
The thread cache is disabled on Windows, as TLS is not implemented there. Add a Windows TLS implementation, and enable the thread cache. Bug: 998048 Change-Id: Ia9d90d5d5e78611e00e6456a770bdf00f44bb773 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426323 Commit-Queue: Benoit L <lizeb@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#816603}
-
Adam Langley authored
When a GMSCore FIDO operation fails, it'll return a non-zero status and null for the other parameters. This change causes the null byte arrays to be translated into empty spans rather than crashing. BUG=1002262 Change-Id: Idc3cb81e4ef17216634677e1d595b7357f2fb70e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463807 Commit-Queue: Adam Langley <agl@chromium.org> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#816602}
-
chinsenj authored
When a user fine tunes their capture region, it's useful to have more precision. This CL adds a magnifying glass to the capture region to address this. Test: manual + added test. Fixed: 1133751 Change-Id: I24f9652d1f97b2fbf29da6b771c6cc465b36d4dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2453772 Commit-Queue: Jeremy Chinsen <chinsenj@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#816601}
-
chromium-internal-autoroll authored
Release_Notes: http://go/media_app-x20/relnotes/Main/media_app_202010130700_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/media_app/app/+/fMicjS5JtS2sakj0BWcnD-WvPzJtgucl2EnBXFOBEnQC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/media-app-chromium-autoroll Please CC media-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome;luci.chrome.try:linux-chromeos-chrome-easwa Bug: b/159848445 Tbr: media-app@grotations.appspotmail.com Change-Id: I6c506c5a13cafb922b74971f2d249a6ec8a56c71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2467237Reviewed-by:
-
Alexander Dunaev authored
This CL unifies the behaviour and test expectations for the Download Manager on Linux platforms. Bug: 1109690 Change-Id: I45802dbc640c25b2b64384b5bfeb1dfccc9983e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2465855 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Auto-Submit: Alexander Dunaev <adunaev@igalia.com> Cr-Commit-Position: refs/heads/master@{#816599}
-
Caitlin Fischer authored
Change-Id: Ic661aa6d85ec6a77044046ef97111b8a2fca93ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2464209Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#816598}
-
Yuki Shiino authored
For a historical reason, HTML{Embed,Object}Element's named definer depends on a fallback logic of the definer and also the named property setter. This patch fixes the bug with a minimal change so that it's easy to backport it. Bug: 1137541 Change-Id: Ic3af70604a379814fae24970317868ab89f7c4c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2467744Reviewed-by: -
Rob Buis authored
The semantics tag should hide children except the first one [1], so add a stylesheet rule for that. This CL also reorganizes the stylesheet to match the order in the specification. [1] https://mathml-refresh.github.io/mathml-core/#semantics-and-presentation Bug: 6606 Change-Id: I8986f7953363e302e7c637bde1e5b67c3a040bef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2467903 Commit-Queue: Rob Buis <rbuis@igalia.com> Reviewed-by:
Frédéric Wang <fwang@igalia.com> Cr-Commit-Position: refs/heads/master@{#816596}
-
Jeremy Roman authored
Bug: 1134214 Change-Id: Ida7b374a939abaa76f95a8f9174c53601ec22b1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463716 Auto-Submit: Jeremy Roman <jbroman@chromium.org> Commit-Queue: Lucas Gadani <lfg@chromium.org> Reviewed-by:
Lucas Gadani <lfg@chromium.org> Cr-Commit-Position: refs/heads/master@{#816595}
-
Rushan Suleymanov authored
The only data type which used the class in unit tests is typed URL. All its unit tests were rewritten to use MockModelTypeChangeProcessor. Bug: 791939 Change-Id: I66b3ed34fad24e67a1d330a3ccc592cd8091c5c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2467901 Commit-Queue: Rushan Suleymanov <rushans@google.com> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#816594}
-
Miriam Zimmerman authored
When the user does not input any text in the free-form text box, we bring them back to it and don't let them send the report. However, right now we do this without signaling an alert to screen readers. Add an aria alert outside of the textbox to signal this. Also, update the text of the alert. BUG=chromium:1107656 TEST=deploy, enable chromevox, click "Send" with empty textarea, verify\ that alert text is read and focus is returned to textarea Change-Id: Ifd08ca90121ecd683b83225c27dfaae1ac2b9f4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2464767Reviewed-by:Ian Barkley-Yeung <iby@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Miriam Zimmerman <mutexlox@chromium.org> Cr-Commit-Position: refs/heads/master@{#816593}
-
yjliu authored
The FrameThrottlingObserver class observes the start/end of frame throttling. Bug: None Change-Id: Ied963e3098ab5dff447fb68c9939314568bb4aaa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466207 Commit-Queue: Jun Liu <yjliu@chromium.org> Reviewed-by:
Jun Mukai <mukai@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Auto-Submit: Jun Liu <yjliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#816592}
-
Mark Yacoub authored
When creating a plane for modeset, ensure that the plane buffer modifier matches the modifier we will use in the next page flip, which is created through the list of preferred modifiers. Also, pass the preferred modifiers list to GetModesetBuffer() so it could be manipulated for modeset tests. BUG=979736 TEST=The modifier of the buffer used in Modeset matches the consequent page flip. Change-Id: I59d5c499961b093f06c19e513a96f49dde471c4a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463363Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Commit-Queue: Daniele Castagna <dcastagna@chromium.org> Cr-Commit-Position: refs/heads/master@{#816591}
-
Clark DuVall authored
These histograms measure WebLayer startup before WebLayerImpl is loaded, which we were not measureing before. This will help tell if something here is contributing to slow startup. Bug: 1137468 Change-Id: I3e84fc399cf460d60d2e7445326493c528c09178 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466264 Commit-Queue: Clark DuVall <cduvall@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#816590}
-
Allen Bauer authored
Bug: 772945 Change-Id: I23bf2495c96f87471b6975595f03a787b375ac30 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466205 Commit-Queue: Allen Bauer <kylixrd@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#816589}
-
Rob Buis authored
When an mrow programmatically has a child added or removed, any direct operator children may need to recompute the lspace/rspace values in case no form value was given, since the fallback logic to compute the form value depends on the previous and next sibling [1]. Add the method CheckFormAfterSiblingChange to implement this update logic. Bug: 6606 [1] https://mathml-refresh.github.io/mathml-core/#dfn-algorithm-for-determining-the-form-of-an-embellished-operator Change-Id: I8c641fda6c3d32a263430aba474c409dc3e56fd5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2467957 Commit-Queue: Rob Buis <rbuis@igalia.com> Reviewed-by:
-
gogerald authored
Bug: 1136539 Change-Id: I1bd58115d0d2c0f4502049040181227bcee85d4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461709 Commit-Queue: Ganggui Tang <gogerald@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Auto-Submit: Ganggui Tang <gogerald@chromium.org> Cr-Commit-Position: refs/heads/master@{#816587}
-
Ian Kilpatrick authored
Previously we just took the end margin-strut, and used this for the scrollable-overflow. This was incorrect. As the end margin-strut is used for positioning self-collapsing blocks we ended up "double counting" these margins. This patch uses the "final" margin-strut, and subtracts the self-collapsing end margin-strut to correctly determine the block-end margin which contributes to scrollable-overflow. Bug: 1136403 Change-Id: I7d0d0fe801948c3ce818719f28f1a7c795a7ec56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466379 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#816586}
-
Harry Cutts authored
There's no need for these since they all come right after a `return`. Bug: none Change-Id: I5ddf94cc2a06dcabf77044546dbb16393f7b8afc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2465214 Auto-Submit: Harry Cutts <hcutts@chromium.org> Reviewed-by:
Michael Spang <spang@chromium.org> Commit-Queue: Michael Spang <spang@chromium.org> Cr-Commit-Position: refs/heads/master@{#816585}
-
Michael Ludwig authored
Bug: skia:9545 Change-Id: I2f1b7f39d17e2a417700d778e90a7904de8ee2cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2464093 Commit-Queue: Michael Ludwig <michaelludwig@google.com> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Peng Huang <penghuang@chromium.org> Auto-Submit: Michael Ludwig <michaelludwig@google.com> Cr-Commit-Position: refs/heads/master@{#816584}
-
Minggang Wang authored
Currently, NotifyUpdateUserGestureCarryoverInfo() declared in resource_load_stats.h is used to update information to determine whether a user gesture should carryover to future navigations, when a request is initiated. This patch adds NotifyUpdateUserGestureCarryoverInfo() into mojo interface ResourceLoadInfoNotifier for Android only to replace it. Thus, we could call it inside Blink, which is part of OnionSoup for loaders. After this patch, all functions defined in resource_load_stats.h/cc are removed and resource_load_stats.h/cc are deleted. Bug: 1110032 Change-Id: I8a8eb6f71b827792332806c97dd4038e4be81ba8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427154 Commit-Queue: Minggang Wang <minggang.wang@intel.com> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#816583}
-
Mariam Ali authored
This CL fixes a code typo and does not have any impact on code logic. Bug: none Change-Id: If396ba00649bd88de2ef1c60d581b57bce48bd24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2465918 Commit-Queue: Filip Gorski <fgorski@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Cr-Commit-Position: refs/heads/master@{#816582}
-
Dominique Fauteux-Chapleau authored
Bug: 1135671 Change-Id: I5e1da7d0c5f8e45106c6ff40473bc9605049cdaf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2460761Reviewed-by:
Daniel Rubery <drubery@chromium.org> Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org> Cr-Commit-Position: refs/heads/master@{#816581}
-
Dominique Fauteux-Chapleau authored
That test covers every ClientDownloadResponse::Verdict with every malware deep scan verdict and ensure the correct final state and reported event. Bug: 1134587 Change-Id: Idce2ae62ab527d819fc9394052132faaef3f80b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2457647Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/33bd4fbe1e5b..46129e98d33a 2020-10-13 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision ea6db480..7c745202 (816360:816476) 2020-10-13 ilnik@webrtc.org Revert "Remove deprecated video_frame_i420 build target" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1132299 Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I1f6fa4df6c4ee74879e3162fbfe6bb5d63d1b44d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466853Reviewed-by:
-
Marc Treib authored
- Deprecate the PROFILE_DESTRUCTION entry which was unused. - Add explicit numeric values to the remaining entries (as is recommended for enums used in UMA histograms). Bug: 939752 Change-Id: Iedd144b5a958a4bd55c78b1e25fba23d8d9f2ed4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2467956 Auto-Submit: Marc Treib <treib@chromium.org> Reviewed-by:
Maksim Moskvitin <mmoskvitin@google.com> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#816578}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/62054633ee57..4159ffc366a3 2020-10-13 sigurds@chromium.org [ts] Type-check sdk/RuntimeModel.js with TypeScript 2020-10-13 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. 2020-10-13 alexrudenko@chromium.org Combine overlays into a single resource 2020-10-13 kimanh@chromium.org Replacing direct calls to invoke_stepInto/stepOut If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811,chromium:1137302 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I9c4b2d5a169e3835a0e35ac7bf7bc731eb1d7d5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2467441Reviewed-by:
-
Andrey Zaytsev authored
Bug: 1131415 Change-Id: If45bd8a0f722428b031396423a74d256671346e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463577 Auto-Submit: Andrey Zaytsev <andzaytsev@google.com> Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#816576}
-
Alice Wang authored
This CL replaces the enum AccessPoint in account picker with a boolean to decide whether to show the incognito row. This is a refactoring. There is no behavior change with this CL. Bug: 1136802 Change-Id: I624b15ae24782428ff8f25ea0352c7af4790bd2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2460904Reviewed-by:
-
Matt Jones authored
This patch adds a check for the top edge of the viewport when propagating size change events. Previously only two of the three params were checked for differences when determining whether to send the event, now we check all three. Bug: 1136807 Change-Id: Id4a1b7cfac938a6bfd8fd21ae90fb8394d2806db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2464915Reviewed-by:
Mei Liang <meiliang@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#816574}
-
Miyoung Shin authored
This fixes a test failure of JavaBridgeBasicsTest#testObjectsInspection__MojoUsed since the ‘allow inspection’ variable is not updated when RemoteObjectGatewayHelper corresponding to the frame is already created. Bug: 1105933b Change-Id: I80c6fd3bcde77ea69b8bc445a3448c8ac69f5d8d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398071 Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#816573}
-
Sadrul Habib Chowdhury authored
The shared memory used for transporting ukm smoothness data is owned on the main-thread, but the write happens on the compositor thread. It is possible for the main-thread to discard the shared memory, and the compositor thread may still write to it in inopportune moments. To avoid this race, transfer the ownership of the shared memory to the compositor thread. BUG=1134659 Change-Id: I71df7ecc1393a0779c36b7d27a3496efb3bf2827 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2467356 Commit-Queue: Jonathan Ross <jonross@chromium.org> Auto-Submit: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#816572}
-
Jan Krcal authored
This CL makes sure the profile picker is skipped when an app is explicitly requested using a command-line parameter. Bug: 1123543 Change-Id: If894b3144946ea7d71bcfdf921563d65d4045cee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2464927 Commit-Queue: Tommy Martino <tmartino@chromium.org> Auto-Submit: Jan Krcal <jkrcal@chromium.org> Reviewed-by:
Tommy Martino <tmartino@chromium.org> Cr-Commit-Position: refs/heads/master@{#816571}
-
Nico Weber authored
I haven't worked on this code in years and am doing a very poor job at doing reviews here. Bug: none Change-Id: I6dfdbe5b173ee5826205b337a6d1222bea2bf48f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2468057Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Roger Tawa <rogerta@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#816570}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/06b956fe4525..bc2dd313cf94 2020-10-13 angle-autoroll@skia-public.iam.gserviceaccount.com Roll glslang from 2067d1a93e6e to f4f1d8a352ca (2 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ynovikov@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: ynovikov@chromium.org Change-Id: Ibe5c4928fd9055641769faa64563bf295bb8852c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2467086Reviewed-by:
-
