- 09 Sep, 2019 40 commits
-
-
Henrique Ferreiro authored
Convert the implementation and all users of the ash::mojom::AssistantAlarmTimerController, AssistantNotificationController and AssistantScreenContextController. Bug: 955171 Change-Id: I19142850f1cd445f6d43a4caf4c7bd88415680c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789386Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#694846}
-
Sadrul Habib Chowdhury authored
Add the checkerboarding metrics in the rendering benchmarks. Adding these extra histograms do not affect the size of the output traces by much. Below are some sample trace-sizes from pinpoint (10 traces for each story): . On windows: - amazon_pinch: 56.32MB -> 56.32MB - twitter_pinch: 58.68MB -> 57.49MB . On pixel 2: - bouncing_balls_shadow: 41.69MB -> 41.74MB - bing_mobile: 57.08MB -> 57.14MB BUG=984592 Change-Id: I3fdb065f8b85814a7b900c46b14f569ec406c243 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1785418Reviewed-by:Caleb Rouleau <crouleau@chromium.org> Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#694845}
-
Robert Liao authored
BUG=865318 Change-Id: I03ebbfdc95622f986e6271dbede4d1bfa740c5eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1788198 Commit-Queue: Robert Liao <robliao@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#694844}
-
Leon Han authored
BUG=520391 Change-Id: I5b9a807081657f2d211575a282ae7fa7f45c71ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1791927 Auto-Submit: Leon Han <leon.han@intel.com> Commit-Queue: Reilly Grant <reillyg@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#694843}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/44e6523d7ff3..cebb9635a5d5 git log 44e6523d7ff3..cebb9635a5d5 --date=short --no-merges --format='%ad %ae %s' 2019-09-09 jmadill@chromium.org GN: Expose XCB surface extension on Linux. Created with: gclient setdep -r src/third_party/swiftshader@cebb9635a5d5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@google.com Bug: chromium:b/140251624 Change-Id: I90a2718722f7687e3d945c6389a6384ef256edb9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1792000Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#694842}
-
Andrew Grieve authored
.part.end is a new section introduced by "partitioned libraries", a part of DFMS. It's a NOBITS section, so needs to be counted the same as .bss. This fixes some CQ runs failing due to: AssertionError: Padding was: $SOME_SMALL_NEGATIVE_NUMBER Bug: 1002085 Change-Id: I49e892d22f8888fd991202d99bc67e342c06db52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1791999 Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Christopher Grant <cjgrant@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#694841}
-
Gabriel Charette authored
These tests were previously migrated from single-threaded MessageLoop to a multi-threaded TaskEnvironment (then named ScopedTaskEnvironment) as part of crbug.com/891670. //base OWNERS decided in retrospect that it was better to keep a single-threaded option for TaskEnvironment and introduced SingleThreadTaskEnvironment. This CL retrofits that decision for /components/bookmarks. This CL is a no-op if it passes CQ. This CL was uploaded by git cl split. Edit: Revert changes to BookmarkNodeDataTest and BookmarkUtilsTest which rely on base::ThreadPool. R=sky@chromium.org Bug: 891670 Change-Id: I8a37c3ecc469fcbbdc52b80724f5d8b073e30414 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786903 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by: -
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/a0b94071e6bd..ac68e9c3dd09 git log a0b94071e6bd..ac68e9c3dd09 --date=short --no-merges --format='%ad %ae %s' 2019-09-09 lalitm@google.com trace_processor: migrate track table to new table macros 2019-09-09 lalitm@google.com trace_processor: make inserting into macro tables more explicit 2019-09-09 lalitm@google.com Merge "trace_processor: refactor Column to reduce boilerplate when adding types" 2019-09-09 hjd@google.com Merge "ui: Show full timestamp" Created with: gclient setdep -r src/third_party/perfetto@ac68e9c3dd09 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: chromium:135177627,chromium:135177627 Change-Id: If7b064422fdcbcddc16a9798adbc047f3dc9274e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1792001Reviewed-by:
-
Yun Liu authored
Revert this if capacity is not enough. Bug: 731759 Change-Id: Ia757461849ff14f277b23f3f6869e9d7c4e2bd61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1790729Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Yun Liu <yliuyliu@google.com> Cr-Commit-Position: refs/heads/master@{#694838}
-
Mohammad Refaat authored
The problem is the fullscreen VC is presented the ContentView is stashed to another window to keep the renderer from being killed. Then when when that VC is dismissed the contentView is inserted on the top of the container view, and that will cover any other view that was presented on the container view. The solution is to insert the contentView on the back of the container view. Bug: 982845 Change-Id: I65e1cb20cb7cdbb6396678cbc3fc26108a932a2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1788242Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Commit-Queue: Mohammad Refaat <mrefaat@chromium.org> Cr-Commit-Position: refs/heads/master@{#694837}
-
Daniel Rubery authored
This CL marks the following histograms as obsolete: SBClientDownload.DownloadFileHasDetachedSignatures SBClientDownload.ZipFileFailureByType SBClientDownload.ZipFileSuccessByTyep Since they are historically stable and not being used It extends the lifetime of: SBClientDownload.ZipFileSuccess Since it shifted dramatically in M75. Bug: 988809 Change-Id: I3add7ec4972d6be4ac0f4492f91cdfb643c88619 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1784970Reviewed-by:
Bettina Dea <bdea@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#694836}
-
Brandon Wylie authored
This will be helpful in methods such as typeInOmnibox, which rely on the assumption that the omnibox will have focus. Putting it in its own util file because it seems generally useful. Bug: 1000315 Change-Id: I7cb390046462c584ad48785963941fce133da0e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1784882 Commit-Queue: Brandon Wylie <wylieb@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#694835}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/2aaf66e4644a..ddef8d1b6b07 git log 2aaf66e4644a..ddef8d1b6b07 --date=short --no-merges --format='%ad %ae %s' 2019-09-09 titovartem@webrtc.org Add support of displaying video during the PC level test Created with: gclient setdep -r src/third_party/webrtc@ddef8d1b6b07 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: None Change-Id: Ib363502b20bc8cf7ee95fb2dea2ec71b7a87cf44 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1792447Reviewed-by:
-
Brett Kilty authored
In cases where kAudioDecoderLimit is > 1, SFX are getting held to the 1 decoder limit. One decoder is really about video, as that is the platform limitation. Multiple sources may attempt to play sound effects at the same time as these are just audio only sources. Bug: b/139941019 Test: Local build, test race condition and SFX. Change-Id: Ieb7ea18674e58e06dc050f7ff2756e14021ab40d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1792451 Commit-Queue: Brett Kilty <brettk@google.com> Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Cr-Commit-Position: refs/heads/master@{#694833}
-
Danan S authored
The Add Supervision dialog was using OnCloseContents() and OnDialogCloseRequested() to catch attempts to close the dialog, for the purpose of showing the signout confirmation dialog. This failed when OnCloseContents() was called, because by the time that callback was called, the web contents were already disposed of, resulting in dialog contents becoming unusable if the user chose to return to the dialog rather than signing out. Instead, capturing the close event in CanCloseDialog() occurs before the contents are invalidated, therefore it is the correct place to stop the closing of the dialog Bug: 1001732 Change-Id: I50262bd4606e3380700c81f98df925ea3a61f87c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1790130 Commit-Queue: Danan S <danan@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#694832}
-
Gabriel Charette authored
These tests were previously migrated from single-threaded MessageLoop to a multi-threaded TaskEnvironment (then named ScopedTaskEnvironment) as part of crbug.com/891670. //base OWNERS decided in retrospect that it was better to keep a single-threaded option for TaskEnvironment and introduced SingleThreadTaskEnvironment. This CL retrofits that decision for /ui/events/ozone. This CL is a no-op if it passes CQ. This CL was uploaded by git cl split. R=spang@chromium.org Bug: 891670 Change-Id: I2d1f3a4f10cf7c57414a04b8a5ebcb9ead9e342a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786939 Auto-Submit: Gabriel Charette <gab@chromium.org> Commit-Queue: Michael Spang <spang@chromium.org> Reviewed-by:
Michael Spang <spang@chromium.org> Cr-Commit-Position: refs/heads/master@{#694831}
-
vikassoni authored
Enable AImageReader for both MCVD and MediaPlayer video paths on android by default. Bug: 951832,838725 Change-Id: I0efa453a3a9e0212fd9b9d5d55cb928bfa46a9c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789755Reviewed-by:
Frank Liberato <liberato@chromium.org> Reviewed-by:
Eric Karl <ericrk@chromium.org> Commit-Queue: vikas soni <vikassoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#694830}
-
Moe Ahmadi authored
- Queries AutocompleteController when the realbox gets focus and is empty. - Stops AutocompleteController and clears Autocomplete results when realbox loses focus. Otherwise previous non-zero-prefix suggestions remain cached. - Displays the clock icon for the personalized zero-prefix suggestions, if applicable. Bug: 996516 Change-Id: Ib821e0f6f0e5b722f60b6388456c673a7b8b450b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786592 Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Dan Beam <dbeam@chromium.org> Reviewed-by:
manuk hovanesian <manukh@chromium.org> Cr-Commit-Position: refs/heads/master@{#694829}
-
Ionel Popescu authored
This CL updates the popup UI for the month view of the calendar picker. The current style was extended by using calendar_picker_refresh.css. More tests are going to be added when the new UI will be used as the default view for input type="month". Bug: 1001348 Change-Id: I10ea5fc4403f1290dc803d2bc3f9e1f701b61578 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1788680 Commit-Queue: Ionel Popescu <iopopesc@microsoft.com> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#694828}
-
Lukasz Anforowicz authored
Desirability of setting |request_initiator| to the website ========================================================== At a high-level, this change means that content script scripts behave more like the webpage that they are injected to. This kind of high-level change is desirable because: 1) the renderer process hosting the webpage is locked to the webpage's origin - anything running in such renderer (including content scripts) should be bound by webpage's capabilities 2) it simplifies reasoning about content scripts for extension authors (after this change content scripts run as webpage's origin [unless allowlisted]; this makes it easier for content scripts to issue SameSite and/or CORS requests on behalf the webpage) At a low-level, this change allows cleaning up some technical debt related to how same-*web*-origin XHRs have to be handled when initiated from content scripts. In particular: A) after this CL, we can remove hacks that OOR-CORS and CORB currently use to (heuristically, inaccurately) attempt to recognize same-origin requests (i.e. we can consider reverting https://crrev.com/c/1642752 and https://crrev.com/c/1394432). For more detailed comparison of how CORB, OOR-CORS and Sec-Fetch-Site behavior is affected by this CL, see the comparison table in https://docs.google.com/document/d/1ENNu-kRSCrgfaqrGO8T-lUqvItnS6VYw-jAdtRVUXic/edit#heading=h.h4a3p9fb5fo6 B) after this CL, requests initiated on behalf of the translate feature will use a request_initiator compatible with request_initiator_site_lock. This means that the translate feature no longer needs to provide a separate URLLoaderFactory (i.e. we can consider reverting https://crrev.com/c/1441277 and follow-ups). C) after this CL, we no longer need to suppress attaching of the Origin header for requests initiated by a content script (i.e. we can consider reverting https://crrev.com/c/1610667). Main change =========== The main change in this CL is in third_party/blink/renderer/core/fetch/request.cc. After this CL, |request->SetOrigin(...)| will be unconditionally called with the main world's origin. Retaining isolated world's origin ================================= The isolated world's origin needs to be retained for 2 reasons: i) For selecting the right URLLoaderFactory in case the extension is allowlisted (see URLLoaderFactoryBundle::GetFactory in //third_party/blink/common/loader/url_loader_factory_bundle.cc). ii) For finding CORS extension policies (see changes related to OriginAccessList) iii) For allowing the content scripts to access blob URLs belonging to *either* of 1) the main world or 2) the extension (see changes related to CanDisplay) Because of the above the CL introduces the new fields: - network::ResourceRequest::isolated_world_origin - blink::WebURLRequest::IsolatedWorldOrigin - blink::ResourceRequest::IsolatedWorldOrigin - blink::FetchRequestData::IsolatedWorldOrigin While it may seem that having two origin fields is more confusing, it is better than the old state because: *) There really *are* two origins associated with each request. Trying to represent this reality with just one origin in code is confusing and error-prone (as evidenced by the technical debt listed above). **) Forgetting to consider the other origin (e.g. isolated world origin) is safe - it might lead to functional bugs but shouldn't lead to security bugs. If code forgets to consider the other origin then it will only consider and/or grant capabilities of the web origin (which should be safe from security perspective). Bug: 940068 Change-Id: I9c3638070861e760227fb62af63f3d8a2c655f88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1633232Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#694827}
-
Yoichi Osato authored
This is a follow-up patch of previous change: "[WebSocket] Reduce memcpy at websocket_frame_parser.cc" https://chromium-review.googlesource.com/c/chromium/src/+/1774420 Bug: 1001915 Change-Id: Ib13c28038a82b4b6ca0eb53a3e4d56ac5242720c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1792030Reviewed-by:
John Chen <johnchen@chromium.org> Reviewed-by:
Adam Rice <ricea@chromium.org> Auto-Submit: Yoichi Osato <yoichio@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#694826}
-
Peter Boström authored
Bug: None Change-Id: I9c429945dcbf6b9a84871c1514d02b1d4e810cbf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1790723 Auto-Submit: Peter Boström <pbos@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
-
James Cook authored
The SplitSettings project has migrated Chrome OS settings into their own settings window. We show a dismissable banner in browser settings that directs users to OS settings. We intend to remove this banner in a few milestones, after most users stop clicking it (or have dismissed it), so measure how often we show it, and how users interact with it. The metrics are similar to the ones added for our other promo banner, from OS settings to browser settings, in this CL: https://chromium-review.googlesource.com/c/chromium/src/+/1779165 Bug: 999438 Change-Id: I0088d4876e9a89e7b33e71fdcd19462f4118eec3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787753Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#694824}
-
Miyoung Shin authored
This CL converts FakeBluetoothRequest and FakeCentralRequest in device to the new Mojo type, and uses pending_remote<FakeCentral> in fake_bluetooth.mojom Bug: 955171 Change-Id: I27a8887f998056f6913b1b53fe50e21165ca1018 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1788779Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/73b8376b302a..28d40b2e7ade git log 73b8376b302a..28d40b2e7ade --date=short --no-merges --format='%ad %ae %s' 2019-09-09 egdaniel@google.com Reland "Add support for direct use of vulkan primary command buffer in render pass." Created with: gclient setdep -r src/third_party/skia@28d40b2e7ade If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC mtklein@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=mtklein@google.com Bug: None Change-Id: I408eae16437f477117f8b5a7d516b04c6a37be4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1792010Reviewed-by:
-
Yun Liu authored
Bug: 1001387 Change-Id: Ibb4c984603a9cf1643bf11adae207437ea76c5b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1790271 Commit-Queue: Yun Liu <yliuyliu@google.com> Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Reviewed-by:
-
Ross McIlroy authored
This reverts commit 688cb8a3. Reason for revert: Underlying issue fixed with https://chromium-review.googlesource.com/c/v8/v8/+/1782169. Original change's description: > sheriff: mark tumblr_infinite_scroll flaky > > It was already marked flaky in desktop_common but needs to be marked as > such in desktop_memory as well. > > TBR=monicaciocea@chromium.org,eyaich@chromium.org > > Bug: 859500, 995813 > Change-Id: I2d93395a23d987ec11a2e3cd6d231d952ff50b23 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762488 > Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> > Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> > Cr-Commit-Position: refs/heads/master@{#688629} TBR=ellyjones@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 859500, 995813 Change-Id: Id26acefd175b13f42b8b9f3f0e4b2468b79a3913 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789310Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#694820}
-
Lan Wei authored
ExecutePerformActions function is called from testdriver Action API and Webdriver API, we expect that all the actions expect the last one in one tick to be sent asynchronously, so that there is no delay between those actions. To start actions in the next tick, we should wait for the response from the actions in the current tick, so by default we should send the last one in the tick synchronously. Change-Id: Id457bed235f607bd37dcc0bb44ad635b4875fc58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1790386Reviewed-by:
-
Nicolas Ouellet-Payeur authored
The initial use_mini_bho CL [1] fails to compile due to an untested function rename. [1] https://crrev.com/c/1699279 TBR=pastarmovj@chromium.org Bug: 950039 Change-Id: Ibc34b3d374965fc95b66a5d146299adfb67e7adb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1792852Reviewed-by:
Nicolas Ouellet-Payeur <nicolaso@chromium.org> Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Cr-Commit-Position: refs/heads/master@{#694818}
-
Adam Langley authored
The caBLE extension to WebAuthn is used to allow a phone to be used as a security key. However, it involves broadcasting a site-controlled value over BLE. This change causes: · the caBLE extension to be ignored if a request is made by a non-focused tab. (Otherwise the BLE broadcast could happen in a tab that isn't in the forefront.) · BLE broadcasts to be delayed for 500 milliseconds after the UI is triggered. This ensures that the UI has time to show itself and cannot be suppressed by rapidly canceling requests etc. Also note that a prior change[1] caused the caBLE extension to be ignored unless embedders opt-in as other embedders may not be displaying UI for this case. [1] https://chromium-review.googlesource.com/c/chromium/src/+/1776792 Change-Id: Id2bf2160448f58ee4c13ab649fc24eb56b45b382 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1779164 Commit-Queue: Adam Langley <agl@chromium.org> Reviewed-by:Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#694817}
-
Mohamed Amir Yosef authored
This CL moves the logic to decide whether leaked passwords should be checked for reuse or not to PasswordFeatureManager class. This will simplify the code when introducing Butter4Passwords. Change-Id: I0ab39edfe84f089ded5fc530e53a36d5c87c0958 Bug: 1001122 Change-Id: Ib5c9a1087bf4ba601d1643b2217c279449004dbf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789586 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#694816}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/4273c0b00841..523d565f1729 Created with: gclient setdep -r src-internal@523d565f1729 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: Iae8d3f367e74b1be68442e198dd21aa30042614c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1792009Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#694815}
-
Tarun Bansal authored
This reverts commit b6c231b5. Reason for revert: Suspected for causing compiling errors on mac. Original change's description: > [ios] Adds the ability to run unittests using XCTest. > > This new functionality is hidden behind both a GN arg > (enable_run_ios_unittests_with_xctest) and a commandline switch > (--enable-run-unittests-with-xctest), in order to default it to off > until the bots are updated to properly run XCTest-based unittests. > > The iOS test runner is updated to run in one of two modes. When > --enable-run-unittests-with-xctest is false (the default), behavior is > unchanged; TestSuite::Run() calls UIApplicationMain(), then the > UIApplicationDelegate calls TestSuite::Run() again, which actually runs > the tests when invoked the second time. When the switch is set to true, > the second invocation of TestSuite::Run() is made by our XCTestCase > subclass rather than by the application delegate. > > Xcode provides the ability to run XCTests and XCUITests from the > commandline, but does not provide any other way to install and run an > app outside of this test-based workflow. (We had an alternative that > used third party libraries, but they no longer work on iOS 13.) This > makes it difficult to install and run GoogleTest-based tests on iOS > devices, since they run as a single self-contained application, but it > would not be practical to drop GoogleTest support on iOS. Instead, we > are exploring invoking these tests via XCTest, which would allow us to > use Xcode's tooling but still run the same GoogleTest-based tests as on > other platforms. > > BUG=635509 > > Change-Id: I26c67d9c7e16a744f43a20f2d8c5839ca8b3c31a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787593 > Reviewed-by: Dirk Pranke <dpranke@chromium.org> > Reviewed-by: Mark Mentovai <mark@chromium.org> > Reviewed-by: Justin Cohen <justincohen@chromium.org> > Commit-Queue: Rohit Rao <rohitrao@chromium.org> > Cr-Commit-Position: refs/heads/master@{#694749} TBR=rohitrao@chromium.org,dpranke@chromium.org,justincohen@chromium.org,mark@chromium.org Change-Id: Ic67605ab0292551500a163e993c6d93fec3048c0 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 635509,1002144 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1791798Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#694814}
-
Akihiro Ota authored
This change sets the accessible name and role so that useful content is read aloud to the user when this view is focused using ChromeVox. This also fixes a bug where gibberish data was read when invoking the "Read page title" ChromeVox hotkey combo on the lock screen. Bug: 887760 Change-Id: I6506620eb21afd59f696b41a1222d329e11ff34f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1774829Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Akihiro Ota <akihiroota@chromium.org> Cr-Commit-Position: refs/heads/master@{#694813}
-
Chromium WPT Sync authored
Using wpt-import in Chromium b89dec94. With Chromium commits locally applied on WPT: 9d7721df "Strip the fragment directive and update scroll-to-text WPT" ae8fff2b "Fix duplicate value of client hint headers on asynchronous validation requests" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=lpz No-Export: true Change-Id: I97e0317e442bf6cc26014815ddc1a46bf0d463a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1792848Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#694812}
-
Hitoshi Yoshida authored
A Web IDL file idb_transaction_options.idl contains an invalid extended attribute [inline_doc]. This CL removes the attribute, and have no behavior change. Bug: 999690 Change-Id: Ia297d5ddf568a617640d363d1f1dda857e11b814 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1792215Reviewed-by:
enne <enne@chromium.org> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Commit-Queue: enne <enne@chromium.org> Auto-Submit: Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#694811}
-
Andrii Shyshkalov authored
This is to ensure that CQ's default can be switched to "cancel" for all other projects w/o affecting (negatively or positively) chromium. R=martiniss Bug: 959436 Change-Id: I25be0b99ad179a3847c141056beb295ec1c7ca88 No-Try: True Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1791901 Auto-Submit: Andrii Shyshkalov <tandrii@google.com> Commit-Queue: Stephen Martinis <martiniss@chromium.org> Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Cr-Commit-Position: refs/heads/master@{#694810}
-
Friedrich Horschig authored
When talkback is turned on, there would be a deferred focus event. This triggered hiding autofill suggestions which is wrong for the keyboard accessory. This CL ensures that the keyboard accessory relies fully on its own logic to decide when to hide autofill suggestions. Bug: 969202 Change-Id: I88d2c1456990d4e4ed8e292d37b7c8eb10d29797 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1790889Reviewed-by:
Christos Froussios <cfroussios@chromium.org> Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#694809}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/26505d54..03038a48 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Icce3a596b6ce518ec4cad790fa0cb0f346cfb7c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1792847Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#694808}
-
Richard Knoll authored
This replaces the default animation, slide-in from right to left, with a custom one that slides in the device list only from the bottom. Also used the correct background color instead of hardcoding white to support dark theme. Bug: 1001104, 1001550 Change-Id: Icffa16ea07250bf0f34ef1c8be2a5f6ff4b1db37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789239Reviewed-by:
Alex Chau <alexchau@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Alex Chau <alexchau@chromium.org> Cr-Commit-Position: refs/heads/master@{#694807}
-
