- 06 Mar, 2019 40 commits
-
-
Erik Jensen authored
File transfer may be undesirable in some enterprise environments, so this adds a policy to allow disabling it. Bug: 679313 Change-Id: Ided7fcb5cb5789851022c61605fb762fcf96705e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1501853 Commit-Queue: Erik Jensen <rkjnsn@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#638264}
-
Jeffrey Kardatzke authored
This fixes the placement of the Cancel and Send buttons in the feedback UI when the available screen area is smaller than the height of the feedback dialog. Previously, in that case the buttons would be pinned to the bottom of the viewport and the content in the dialog would scroll underneath the buttons. This separates them out into a separate div and removes their absolute positioning so that they no longer overlap. Some other margin were changed as well in order to prevent it from having 60px of gap between the privacy notice and the buttons. on current builds or another bug prevents this from being scrollable at all Bug: 866931 Test: Verified w/ and w/out magnifier on, SPM also needs to be disabled Change-Id: Ic58ee0cd3e7251ae3a37fc623f8928e9522066b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504232Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Jeffrey Kardatzke <jkardatzke@google.com> Cr-Commit-Position: refs/heads/master@{#638263}
-
Zhenyao Mo authored
1) A bug introduced during addressing review feedbacks so now the split files can't be split further because they are wrong. 2) The script doesn't work if one if the four switches are missing. This is problematic because we could easily split into a state where certain switches no longer have values. Added unit tests to make sure the above two issues are covered. BUG=932197 TEST=unittests R=askitkine@chromium.org Change-Id: Ic961f609f0a0d00ebf213206a70b4fb76b83aac8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1497797Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#638262}
-
Patrick Noland authored
This updates the consent flow to 1) Enable revocation via the consent activity 2) Only present the privacy preference when the user has consented 3) Have the privacy preference launch the consent activity for revocation instead of being a checkbox Bug:902490 Change-Id: I34fdc210ee03db100ab9c310ab5fe3d9cda15d76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1481739 Commit-Queue: Patrick Noland <pnoland@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#638261}
-
Daniel Murphy authored
IndexedDBFactoryImpl isn't scoped per origin and so can be used by multiple origins. The original code assumed that it was scoped per origin, so when in actuality it was used by multiple origins, when a single origin requested a lock this could interrupt other origins in certain cases. https://docs.google.com/document/d/1jX6OOQJ0aLrWAeqYLtARXPFawUlJPbHNIKAK-0vmFHU/edit#heading=h.6cqn78xajqmp R=cmp@chromium.org Bug: 934790 Change-Id: I10f3e7c1b43ad7310d8824648575d940568b534d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1487369 Commit-Queue: Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Chase Phillips <cmp@chromium.org> Cr-Commit-Position: refs/heads/master@{#638260}
-
Tony de Luna authored
During OOBE enrollment flow we fetch the list of policies and this may contain users such as a public session user. 1.If the list of users fetched is not empty we show the account picker screen. 2 If the list of users is empty we show the GAIA login screen. We should only update session state to LOGIN_PRIMARY if we show the account picker screen. Session state should remain OOBE if we show the GAIA login screen. Setting the value of session state controls the colors of the buttons and icons in the shelf and setting it incorrectly causes visual bugs. Bug: 937367 Change-Id: Iaa8f5913a36936f0959da8a517ddfb21ea5d5971 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1500632 Commit-Queue: Tony De Luna <tonydeluna@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#638259}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/4c84dbdce271..9584fe43a9c2 git log 4c84dbdce271..9584fe43a9c2 --date=short --no-merges --format='%ad %ae %s' 2019-03-06 chrisforbes@google.com Disable creation of multisample images until they work Created with: gclient setdep -r src/third_party/swiftshader@9584fe43a9c2 The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@chromium.org Change-Id: I0f7b5407bf2aed533b383ff67a49d005601d5a6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506474Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#638258}
-
Xiaocheng Hu authored
Hoist VisibleSelection creation from SelectionController::SetNonDirectionalSelectionIfNeeded() to callers This patch hoists the creation of VisibleSelection |new_selection| from the function to its callers, so that the elimination of VisibleSelection canonicalization is easier. Bug: 657237 Change-Id: Ic1c25d9474f1ade210c4389862bafc87e8e8d7b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1502152Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Shimi Zhang <ctzsm@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#638257}
-
Luna Lu authored
In content/public/browser/render_frame_host.h to make it clear how feature values are compared. TBR: kinuko, iclelland Change-Id: Iaee687abe3f49e4c2274fe158fd5ce4fd6151d2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504295 Auto-Submit: Luna Lu <loonybear@chromium.org> Reviewed-by:
Luna Lu <loonybear@chromium.org> Cr-Commit-Position: refs/heads/master@{#638256}
-
Maks Orlovich authored
SetCanonicalCookieAsync has just been fixed to do the check properly, so there is no need for android_webview::CookieManager do duplicate it. Also remove some logging normal devs can't see. Change-Id: If9b6472a9a11c74fab83afcd9e55dca75c0f03fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1486879 Commit-Queue: Maks Orlovich <morlovich@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#638255}
-
Chris Palmer authored
Or, try to. Also give more examples. Bug: None Change-Id: If7d57944aa61e017bb4b6a7d144ded3b51b04318 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1497366Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Commit-Queue: Chris Palmer <palmer@chromium.org> Cr-Commit-Position: refs/heads/master@{#638254}
-
Adrienne Walker authored
Now that shared images have a color space in them, we don't need to explicitly pass a color space. Color space transfer cache entries can be removed in a followup. Bug: 933901 Change-Id: I2c95aa14ee79da70a907ff3ce90d38550397ea8c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1495574 Commit-Queue: enne <enne@chromium.org> Reviewed-by:
enne <enne@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Reviewed-by:
Mike Klein <mtklein@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#638253}
-
Daniel Murphy authored
This reverts commit 6fc31bcf. Reason for revert: The crashes have stopped, so these debugging CLs are being reverted. Original change's description: > [SessionStorage] Resolve OpenSessionStorage at bind site > > R=mek@chromium.org > > Bug: 927534 > Change-Id: Ic50cb227f34127ed69cbd9e8edf13ca5824238d6 > Reviewed-on: https://chromium-review.googlesource.com/c/1479274 > Reviewed-by: Marijn Kruisselbrink <mek@chromium.org> > Commit-Queue: Daniel Murphy <dmurph@chromium.org> > Cr-Commit-Position: refs/heads/master@{#633881} TBR=dmurph@chromium.org,mek@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 927534 Change-Id: I0a02e62a4b5b6a3a6f6a5ff35ef43326c106a8f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506460Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#638252}
-
Javier Ernesto Flores Robles authored
The space was modifidied in order to match Apple's next and previous arrows below them. Bug: 912551 Change-Id: I41955034a9b9af396ef710dbb494d5a97bbc799f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1505946 Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#638251}
-
Ken Rockot authored
Amends an existing IO-thread-bound interface in child processes to obey a new Crash() message when received. This is to help debug child process hangs on platforms where we don't get hang crash reports yet. The message is used by the renderer hang monitor if it detects a hung renderer and the user agrees to kill it. Crashes resulting from this change should provide some insight into why renderers are hanging on Chrome OS. Bug: 938647 Change-Id: Ifb5dc8c2f755c4a25f3f712145e4ddb9e32a584a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1505832 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Cr-Commit-Position: refs/heads/master@{#638250}
-
Dan Beam authored
Screenshot: https://imgur.com/a/Zo7p0MI R=dpapad@chromium.org BUG=926658 Change-Id: I0631c213ad3ef7e5808af1ab9922f00791c60a4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1505116 Auto-Submit: Dan Beam (slow; perfing) <dbeam@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#638249}
-
manuk authored
This button compliments the previously named 'Import clipboard' button. With this CL, we have 4 buttons to export to or import from the clipboard or a file. Additionally, this CL renames the buttons and modifies accesskeys for clarity: - Copy (alt+c) - Paste (alt+v) - Download (alt+n) - Upload (alt+m) The 'Lock cursor position to end of input' checkbox also has its accesskey changed from alt+c to alt+x. Bug: 937321 Change-Id: Ieada086afd7e2d35e7b164679e1087245050ef91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1497117Reviewed-by:
-
Ian Kilpatrick authored
As above. This iterates over all the scrollable areas, and marks their respective layout objects as requiring layout. This is required as LayoutNG has caches more items than in the existing LayoutNG, and nothing marks the layout_box with the scrollbar as needing layout. This is similar to the kPaintChange, which invalidates paint all of paint when something like high-contrast mode is enabled. Bug: 922456 Change-Id: Ie65b14872a832b73b197247c06ce77727d8e6aec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1476811 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Stefan Zager <szager@chromium.org> Cr-Commit-Position: refs/heads/master@{#638247}
-
Nick Harper authored
Bug: 700280 Change-Id: Icf24e2f8c1b4c96c198039561fbf8c2d97cd2b82 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1500138Reviewed-by:
Bence Béky <bnc@chromium.org> Commit-Queue: Nick Harper <nharper@chromium.org> Cr-Commit-Position: refs/heads/master@{#638246}
-
Piotr Bialecki authored
Bug: 935025 Change-Id: Iab1b70463d9d6fe5a5104520160b392f5f17e9de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504000Reviewed-by:
Brandon Jones <bajones@chromium.org> Commit-Queue: Piotr Bialecki <bialpio@chromium.org> Cr-Commit-Position: refs/heads/master@{#638245}
-
Tommy Steimel authored
This CL adds a check to make sure there is a RemoteCommandCenterDelegate before we attempt to create a RemoteCommandMediaKeysListenerMac. Bug: 938070 Change-Id: Ie216a85e5c579b7d654888d00c24b67ddaa7351d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506108Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#638244}
-
Brandon Jones authored
Bug: 933411 Change-Id: I7e698846e7c733c15a82bd9079855df1e2d5abf4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504223Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Klaus Weidner <klausw@chromium.org> Commit-Queue: Brandon Jones <bajones@chromium.org> Cr-Commit-Position: refs/heads/master@{#638243}
-
rbpotter authored
Bug: 936787 Change-Id: I7eeb1f3f9da68e6a4274afab2804ea3f2df21366 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504309Reviewed-by:
Esmael El-Moslimany <aee@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#638242}
-
Mustafa Emre Acer authored
This test sanity checks that we display a lookalike interstitial for a relevant domain name. The test is adapted from chrome/browser/ssl/CaptivePortalTest.java. Bug: 936565 Change-Id: Ic92be9630c15ec4d88043411a79edf0a07ed78ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1497767Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
-
Christian Fremerey authored
This CL is in the context of enabling capturers to tell consumers, e.g. video encoders, what part of the video has changed (possibly none) since the last frame. Design Doc: https://docs.google.com/document/d/1YNYaP22fepgP_MXrFXytbo0LOyx29mdCKAsQ2TZAckg/edit?usp=sharing Functional changes in WebRTCVideoTrackSource: * Keep track of CAPTURE_COUNTER and and CAPTURE_UPDATE_RECT to determine when valid |update_rect| information is available. * Accumulate |update_rect| information when dropping frames before delivery to WebRTC * Mark whole frame as changed if cropping or scaling has changed since the last frame delivery. * Translate |update_rect| from being relative to the entire coded frame data (as delivered) to being relative to the visible_rect of the frame (as expected by WebRTC) * When hard-applying cropping and scaling into a new buffer, transform the |update_rect| information accordingly. Bug: 930186 Change-Id: Ic81e9d3bbe4a3f0c403dd709a338f0a699cbfeed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1464932Reviewed-by:
Emircan Uysaler <emircan@chromium.org> Commit-Queue: Christian Fremerey <chfremer@chromium.org> Cr-Commit-Position: refs/heads/master@{#638240}
-
Robert Liao authored
With the current Equals() semantics (BindStateBase pointer comparison), this should always return false as OnceCallback is a move only type. BUG=937566 Change-Id: I5477a51721f9c8bf1fa95636263b2095b9588452 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1497636 Auto-Submit: Robert Liao <robliao@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#638239}
-
Sammie Quon authored
The backdrop is created after the shield button and it's the same size so it was eating all the events. Set the backdrop to not be able to handle events. Test: ash_unittests OverviewSessionTest.SelectingWindowWithBackdrop Bug: 938645 Change-Id: I18d53cf9ba385ab24a7e3dcce1ceaf16fcde48d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504307Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#638238}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/6195cd0e66d0..767948b07604 git log 6195cd0e66d0..767948b07604 --date=short --no-merges --format='%ad %ae %s' 2019-03-06 dgarrett@google.com workspace_stages: Only warn on unittest failures. Created with: gclient setdep -r src/third_party/chromite@767948b07604 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@chromium.org Change-Id: Ib342f2fcb94897acb58d3c276df488ab9e8eb263 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506432Reviewed-by:
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: Id382889ba134a3fba888d19d4fe4372e6774f8b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506472Reviewed-by:
-
Karolina Soltys authored
Part of an ongoing effort of ThreadUtils --> PostTask migration. Bug: 863341 Change-Id: I2feb4d7dc6280da16d25e91f75f8b10266bb3fcf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1448219Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Auto-Submit: Karolina Soltys <ksolt@chromium.org> Cr-Commit-Position: refs/heads/master@{#638235}
-
Chase Phillips authored
Similar to the IDBCursor.Advance() commit 9a58b89a, IDBCursor.CursorContinue() previously took a separate IDBCallbacks interface that had its own lifecycle and could have a number of methods called on it. This CL updates CursorContinue() to use Mojo's native callback mechanism. Bug: 717812 Change-Id: Icc7d8b0be70a078f31d658ac9c35d83d8af12b0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1480810 Commit-Queue: Chase Phillips <cmp@chromium.org> Reviewed-by:
-
bsheedy authored
Significantly improves the speed at which Android RenderTest comparisons take place if Bitmap.sameAs returns false. This is done by reducing the number of times we call methods that have to hop through JNI and by bulk editing images instead of going through pixel-by-pixel. Rough benchmarking shows this to result in a ~3x speedup. Bug: 904012 Change-Id: I51dc259df9124c6023572a8510fa87dd435bf2f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1500413Reviewed-by:
Justin DeWitt <dewittj@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#638233}
-
Carlos IL authored
SSLCertificateErrorPageController is no longer only used on SSL errors, renamed it to SecurityInterstitialErrorPageController, and removed the net::Error code passed to EnablePageHelperFunctions since it's no longer used. Bug: 910794 Change-Id: I718e0fcbcb2643cb0c47818dda1f317aef4e75cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1503910Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
-
Christian Fremerey authored
Add support for having some clients require buffers of type kSharedMemoryViaRawFileDescriptor while others are using kSharedMemory while sharing the same device. This is done by having class BroadcastingReceiver convert the buffer type as needed when distributing buffer handles to the clients. Design Doc: https://docs.google.com/document/d/1mYnsZfLBRmbsDpUtfb6C7dzhfw2Kcxg_-uiG_6MnWVQ/edit?usp=sharing Test: content_browsertests --gtest_filter=WebRtcVideoCaptureSharedDeviceBrowserTest.* Bug: 783442 Change-Id: Ia636157dfddba3eec09476c4b2be7750ff931fd7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1413022 Commit-Queue: Christian Fremerey <chfremer@chromium.org> Reviewed-by:
Luke Sorenson <lasoren@chromium.org> Cr-Commit-Position: refs/heads/master@{#638231}
-
Aga Wronska authored
Bug: 938655 Test: manually Change-Id: I77a713e84a9fbd8b73470234e39f9a416c1cad4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504952Reviewed-by:
Jacob Dufault <jdufault@chromium.org> Commit-Queue: Aga Wronska <agawronska@chromium.org> Cr-Commit-Position: refs/heads/master@{#638230}
-
David Bertoni authored
This data member is not used. Change-Id: I4542a818349e17863ec30faab2625ee0ab1c8322 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504953Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: David Bertoni <dbertoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#638229}
-
Edin Kadric authored
This worked seamlessly; I only had to update unit tests: On Linux, Alt+left/right shouldn't do anything to be consistent with the behavior of Textfield. Also, on Mac Alt+left/right really moves between words, not to the beginning/end of the text. On Linux that's achieved with Ctrl+left/right. Bug: 923660 Change-Id: I891e7164e6dd2b88070915715d9e735321fd9b7e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1503617Reviewed-by:
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/ed5dc24c07a3..9ba187ae4751 git log ed5dc24c07a3..9ba187ae4751 --date=short --no-merges --format='%ad %ae %s' 2019-03-06 thestig@chromium.org Fix FPDF_FILEACCESS lifetime issue with FPDF_LoadCustomDocument(). Created with: gclient setdep -r src/third_party/pdfium@9ba187ae4751 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I966a47b3dd1fa33080b6baf21c94cc179daf0ccc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1505858Reviewed-by:
-
Owen Min authored
Disable the test on Android, Linux and Fuchsia due to flaky. Tbr: petewil@chromium.org Bug: 938812 Change-Id: I96504518c8556d5e8cdfb60a9e74c5dc8e1040ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506380Reviewed-by:
Owen Min <zmin@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#638226}
-
Christopher Cameron authored
The root cause of this bug is that the call to LSCopyApplicationURLsForBundleIdentifier that is made in WebAppShortcutCreator::GetAppBundlesByIdUnsorted will not necessarily find app shims that were created just moments ago (likely there is an asynchronous indexing that is going on). To fix this, make WebAppShortcutCreator::GetAppBundlesByIdUnsorted read through all of the app shims in the path under ~/Applications where app shims are created, and see if it finds an application that matches the one we are looking for, based on its Info.plist. Rather than add another place where Info.plists are manually parsed, merge all code that reads Info.plists from app bundles, and put all of the accessors for this data in a single BundleInfoPlist class. Note that some of the moved code is not well understood by this author (in particular, IsForCurrentUserDataDir and GetFullProfilePath). This BundleInfoPlist will be used more extensively in the updated code to delete zombie bundles and to provide more robust renaming. Bug: 937703 Change-Id: Ia292840debd9c74024d707f784dceab78443a536 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1500851 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#638225}
-
